From notifications at github.com  Fri Oct  1 01:58:40 2021
From: notifications at github.com (pazza)
Date: Thu, 30 Sep 2021 16:58:40 -0700
Subject: [bisq-network/bisq] Promote Keybase as a support channel within
 Bisq GUI (#4904)
In-Reply-To: <bisq-network/bisq/issues/4904@github.com>
References: <bisq-network/bisq/issues/4904@github.com>
Message-ID: <bisq-network/bisq/issues/4904/931786960@github.com>

Hi @xyzmaker123 thanks, I will take a look at the comments and come back to you.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/4904#issuecomment-931786960
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20210930/769182f5/attachment.htm>

From notifications at github.com  Fri Oct  1 19:01:38 2021
From: notifications at github.com (m52go)
Date: Fri, 01 Oct 2021 10:01:38 -0700
Subject: [bisq-network/bisq] Add "Buy BSQ" button next to trade fee
 selector (#5055)
In-Reply-To: <bisq-network/bisq/pull/5055@github.com>
References: <bisq-network/bisq/pull/5055@github.com>
Message-ID: <bisq-network/bisq/pull/5055/review/769193886@github.com>

@m52go commented on this pull request.



> +createOffer.buyBsq.popupMessage=Trading fees are paid to fund the Bisq DAO when making or taking an offer. Fees can be paid in BSQ or BTC.\n\n\
+  Bisq encourages traders to use BSQ by offering a discount of approximately 50%, since BSQ fees help fund Bisq's development. \
+  This discount varies as the BSQ/BTC rate fluctuates. To maintain the 50% discount target, trading fees are updated every cycle as necessary.\n\n\
+  For more details see [HYPERLINK:https://bisq.wiki/Trading_fees]

```suggestion
createOffer.buyBsq.popupMessage=Trading fees are paid to fund the Bisq DAO. Fees can be paid in BSQ or BTC.\n\n\
  BSQ fees directly help fund Bisq's development, so Bisq encourages traders to use BSQ by offering a 50% discount on trading fees. \
  This discount varies as the BSQ/BTC rate fluctuates. To maintain the 50% discount target, trading fees are updated every cycle as necessary.\n\n\
  For more about fees, see [HYPERLINK:https://bisq.wiki/Trading_fees]. For more about the Bisq DAO, see [HYPERLINK:https://bisq.wiki/Introduction_to_the_DAO#The_Bisq_DAO].
```

Just made some wording changes and added a link to the DAO introduction on the wiki.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5055#pullrequestreview-769193886
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211001/7bcf8220/attachment.htm>

From notifications at github.com  Fri Oct  1 19:05:19 2021
From: notifications at github.com (m52go)
Date: Fri, 01 Oct 2021 10:05:19 -0700
Subject: [bisq-network/bisq] Add "Buy BSQ" button next to trade fee
 selector (#5055)
In-Reply-To: <bisq-network/bisq/pull/5055@github.com>
References: <bisq-network/bisq/pull/5055@github.com>
Message-ID: <bisq-network/bisq/pull/5055/c932399997@github.com>

I recommend adding more context to this area in addition to the "Learn more" link. Some people still perceive BSQ to be a shitcoin, so having something short like...

"BSQ is colored BTC that helps fund Bisq developers. <a href="#">Learn More</a>" 

...next to the `BUY BSQ` button could help a lot.

![Screenshot from 2021-10-01 13-01-42](https://user-images.githubusercontent.com/735155/135659436-f9409020-5d49-46a3-a62c-3fdbc776a7aa.png)


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5055#issuecomment-932399997
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211001/d96bb212/attachment.htm>

From notifications at github.com  Fri Oct  1 23:55:11 2021
From: notifications at github.com (Conza)
Date: Fri, 01 Oct 2021 14:55:11 -0700
Subject: [bisq-network/bisq] Add "Buy BSQ" button next to trade fee
 selector (#5055)
In-Reply-To: <bisq-network/bisq/pull/5055@github.com>
References: <bisq-network/bisq/pull/5055@github.com>
Message-ID: <bisq-network/bisq/pull/5055/c932598795@github.com>

Fark yes to the learn more and context setting gents ???. 

Also very good point about coloured Bitcoin. 
Hence why I've commented elsewhere, we need BSQ to be separate compared to the shitcoins. We literally put it in that category (oof). 

But yeah, great first step ?.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5055#issuecomment-932598795
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211001/1af40fc4/attachment.htm>

From notifications at github.com  Sat Oct  2 09:20:42 2021
From: notifications at github.com (xyzmaker123)
Date: Sat, 02 Oct 2021 00:20:42 -0700
Subject: [bisq-network/bisq] DAO and Fund section in Bisq seems to be
 missing ability to copy links  (#5278)
In-Reply-To: <bisq-network/bisq/issues/5278@github.com>
References: <bisq-network/bisq/issues/5278@github.com>
Message-ID: <bisq-network/bisq/issues/5278/932699932@github.com>

@ripcurlx, @chimp1984, @pazza83  I'm considering implementing it, and I wonder if I'll be able to charge 350USD for it?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5278#issuecomment-932699932
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211002/e5899ada/attachment.htm>

From notifications at github.com  Sat Oct  2 10:31:09 2021
From: notifications at github.com (sqrrm)
Date: Sat, 02 Oct 2021 01:31:09 -0700
Subject: [bisq-network/bisq] [WIP] Atomic bsq trades (#5729)
In-Reply-To: <bisq-network/bisq/pull/5729@github.com>
References: <bisq-network/bisq/pull/5729@github.com>
Message-ID: <bisq-network/bisq/pull/5729/push/8063720560@github.com>

@sqrrm pushed 41 commits.

69939965f8efde96de05519b0d1220af42085935  Remove handling for bundledEnvelopes in send method
c447d14092946c80dd40450b0da0c00cfca4ee1b  Rename AtomicOfferPayload to BsqSwapOfferPayload
5c8f46c4746bb2dd0f69abf3298bd638a9d64ee4  Add extraDataMap to BsqSwapOfferPayload
13b849f507e7a9c994fb493b8b71060fa4d1cd28  Rename AtomicAccountPayload to BsqSwapAccountPayload
77b650897fd3feac7a96b6aa0cc24693723846ac  Rename AtomicAccount to BsqSwapAccount
c89e00538368f2b4de9c22948b28d766fcf258f1  Rename PaymentMethod.ATOMIC to PaymentMethod.BSQ_SWAP
13bdf2d108817d5535be468ada61cf11490f541c  Rename ProcessModelI to TradeProtocolModel
a717cfcd9a93e87d9ea63c735946b798cb7f668c  Rename AtomicProcessModel to BsqSwapProtocolModel
1f0f616c5315c884aaf1cdac13279e506cabb9ab  Rename AtomicProcessModel to BsqSwapProtocolModel in protobuf
f022d7096e41869f062bc16df9ba657714e124d8  Remove unused params
8e6a4289d484116567f505aa1c04d00dd91ca143  Rename AtomicTrade to BsqSwapTrade
914aaec5a7579773e10f6e4d594bac482f2bf8eb  Rename AtomicTrade to BsqSwapTrade in protobuf
2d926518ac1df4f3f506f5a4ac460b3cc1ed46f6  Rename AtomicTradeManager to BsqSwapTradeManager
f9bbb61494877f632bb0af6ceb5ea802c4fa2790  Move bisq.core.trade.atomic.AtomicTxBuilder to bisq.core.btc.AtomicTxBuilder
46b1a0f277064d320cf4d791066599782ae6f80e  Rename AtomicTxBuilder to BsqSwapTxHelper
b683664ad8a266c92bde6b638c3b7353622249a3  Rename AtomicMakerProtocol to BsqSwapMakerProtocol
d856544affddc3b56baee92ca4eaf1e4f9596904  Move bisq.core.trade.protocol.BsqSwapProtocolModel to bisq.core.trade.atomic.protocol.BsqSwapProtocolModel
2388bd46f733f0ada9af7be914b439c102bcca6a  Move trade model classes to bisq.core.trade.model package
d94e633819a88ae32b698d88d16c0e8194267487  Move protocol classes to bisq.core.trade.protocol package
39866b0bd29fe723508741a9e34922e56e9f80c9  Move common classes level up
c08128185ca88146ee1ec3699b1ef6a6c8e86e22  Rename ProcessModelServiceProvider to Provider
20effc7e7d0dec6e0eb5805ad1e41d8c7dd422e3  Move common classes to misc package
e711378a60013e5e301616accbdcf2e072e3a863  Move bisq.core.trade.protocol.messages to bisq.core.trade.messages
75b1c7cb5d777b649f4854f70042af77f5d1a64f  Move TradeManager, MakerTrade, TakerTrade one level up
5f65f41612d464e9342d5e16b1a0eb8e49505313  Update protocol and protocol model classes
50b78b199aacad7ff84aaed54bc56955a72dbff4  Remove Atomic prefixes for tasks
ceacbb7fca45d1be913d4219eb256f4ff2bc40c6  Rename CreateAtomicTxRequest and CreateAtomicTxResponse
3b8d94705e06428364de74bf3131d13b91271bf8  Rename methods, fields with atomic prefix
4100af0aa77d116f6181f4cfc4975e32720713a2  Rename views
52a022c3850a0910c1aa07a887089cb637c5e7cb  Rename AtomicOfferFunding
40e4582723195493e52544cf12f6d0567da55a26  Refactor placeoffer packages
19b0524d781a93105565f3e5f0b321770e74e721  Replace TransactionResultHandler with Runnable
7853f26a6fb876db882bde6ce2f91a79ce4593a4  Replace ocurrances of atomic with bsqSwap
fea00187dfdbdd7fe3c548d3b1e523222ec29f4e  Use OfferPayloadBase instead of ProtectedStoragePayload as type
a4059b4da1636f25336822cf2214a2766ebac752  Remove redundant OfferPayload.Direction
b390743ee51f7b8ca2752554f0beb18f31594c1e  Move AvailabilityResult to bisq.core.offer.availability
163bcce03a2764daa133893c51c97882d20857ba  Small refactorings, cleanups
cb81c6f0468c9954d5bffd39ec0b1a95827ac810  Refactor BsqSwapWalletWatcher and OpenOfferManager
088b85b77f706ebe6827aa526494fd2353ab2d18  Add counter to fee service check
7c740735b99f209354d9a2a2e1fb945706039180  Fix copy paste error
c4e129b326a259e0862788bf9468e4d4c1287d13  Merge pull request #9 from chimp1984/Bsq-swap-3


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/bisq-network/bisq/pull/5729/files/df88ef772a264045f5c905e2c03e9c3a5f3b9d31..c4e129b326a259e0862788bf9468e4d4c1287d13
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211002/fa75d7ce/attachment-0001.htm>

From notifications at github.com  Sat Oct  2 17:49:53 2021
From: notifications at github.com (burningman3)
Date: Sat, 02 Oct 2021 08:49:53 -0700
Subject: [bisq-network/roles] BTC donation address owner ("Burningman")
 (#80)
In-Reply-To: <bisq-network/roles/issues/80@github.com>
References: <bisq-network/roles/issues/80@github.com>
Message-ID: <bisq-network/roles/issues/80/932773638@github.com>

I will buy BSQ Sunday, Oct 03, between 15:00 CET and 18:00 CET.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/roles/issues/80#issuecomment-932773638
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211002/860741cb/attachment.htm>

From notifications at github.com  Sat Oct  2 22:37:13 2021
From: notifications at github.com (Stan)
Date: Sat, 02 Oct 2021 13:37:13 -0700
Subject: [bisq-network/bisq] Move volume formatting from DisplayUtils to
 VolumeUtil (#5740)
Message-ID: <bisq-network/bisq/pull/5740@github.com>

In practice, presentation/display logic should be kept in UIs, but the core api will need to duplicate a very small part of the code in `DisplayUtils` if a very small part of this refactoring is not done.  Instead of moving a tiny bit of the volume formatting methods, all of them are moved to core&#39;s `VolumeUtil`.
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/5740

-- Commit Summary --

  * <a href="https://github.com/bisq-network/bisq/pull/5740/commits/db6e2a51b2243c84a0be7cef7ae012d348359c1d">Move volume formatting from DisplayUtils to VolumeUtil</a>

-- File Changes --

    M core/src/main/java/bisq/core/util/VolumeUtil.java (83)
    M desktop/src/main/java/bisq/desktop/main/dao/wallet/send/BsqSendView.java (6)
    M desktop/src/main/java/bisq/desktop/main/market/MarketView.java (3)
    M desktop/src/main/java/bisq/desktop/main/market/offerbook/OfferBookChartView.java (67)
    M desktop/src/main/java/bisq/desktop/main/market/offerbook/OfferBookChartViewModel.java (21)
    M desktop/src/main/java/bisq/desktop/main/market/trades/TradeStatistics3ListItem.java (5)
    M desktop/src/main/java/bisq/desktop/main/market/trades/TradesChartsView.java (3)
    M desktop/src/main/java/bisq/desktop/main/market/trades/charts/volume/VolumeBar.java (4)
    M desktop/src/main/java/bisq/desktop/main/offer/FeeUtil.java (7)
    M desktop/src/main/java/bisq/desktop/main/offer/MutableOfferViewModel.java (8)
    M desktop/src/main/java/bisq/desktop/main/offer/offerbook/OfferBookViewModel.java (3)
    M desktop/src/main/java/bisq/desktop/main/offer/takeoffer/TakeOfferViewModel.java (3)
    M desktop/src/main/java/bisq/desktop/main/overlays/windows/ContractWindow.java (62)
    M desktop/src/main/java/bisq/desktop/main/overlays/windows/DisputeSummaryWindow.java (3)
    M desktop/src/main/java/bisq/desktop/main/overlays/windows/OfferDetailsWindow.java (19)
    M desktop/src/main/java/bisq/desktop/main/overlays/windows/SwiftPaymentDetails.java (9)
    M desktop/src/main/java/bisq/desktop/main/overlays/windows/TradeDetailsWindow.java (5)
    M desktop/src/main/java/bisq/desktop/main/portfolio/closedtrades/ClosedTradesViewModel.java (7)
    M desktop/src/main/java/bisq/desktop/main/portfolio/failedtrades/FailedTradesViewModel.java (6)
    M desktop/src/main/java/bisq/desktop/main/portfolio/openoffer/OpenOffersViewModel.java (5)
    M desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/PendingTradesView.java (5)
    M desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/PendingTradesViewModel.java (3)
    M desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/steps/buyer/BuyerStep2View.java (4)
    M desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/steps/seller/SellerStep3View.java (28)
    M desktop/src/main/java/bisq/desktop/util/DisplayUtils.java (83)
    M desktop/src/main/java/bisq/desktop/util/GUIUtil.java (7)
    M desktop/src/test/java/bisq/desktop/util/DisplayUtilsTest.java (15)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/5740.patch
https://github.com/bisq-network/bisq/pull/5740.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5740
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211002/fa4b5f01/attachment.htm>

From notifications at github.com  Sat Oct  2 22:48:48 2021
From: notifications at github.com (Stan)
Date: Sat, 02 Oct 2021 13:48:48 -0700
Subject: [bisq-network/bisq] Move volume formatting from DisplayUtils to
 VolumeUtil (#5740)
In-Reply-To: <bisq-network/bisq/pull/5740@github.com>
References: <bisq-network/bisq/pull/5740@github.com>
Message-ID: <bisq-network/bisq/pull/5740/push/8065793591@github.com>

@ghubstan pushed 1 commit.

36dcb99cf81106ef2ebdc252a27d75e524df6083  Be consistent about line-breaks when using conditional operator


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/bisq-network/bisq/pull/5740/files/db6e2a51b2243c84a0be7cef7ae012d348359c1d..36dcb99cf81106ef2ebdc252a27d75e524df6083
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211002/cdb9c504/attachment.htm>

From notifications at github.com  Sat Oct  2 23:25:55 2021
From: notifications at github.com (pazza)
Date: Sat, 02 Oct 2021 14:25:55 -0700
Subject: [bisq-network/bisq] Bisq SPV download stuck at %57 (#5707)
In-Reply-To: <bisq-network/bisq/issues/5707@github.com>
References: <bisq-network/bisq/issues/5707@github.com>
Message-ID: <bisq-network/bisq/issues/5707/932822575@github.com>

Hi @BENDYMAN20 did upgrading to 1.7.4 fix it for you?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5707#issuecomment-932822575
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211002/84db377e/attachment.htm>

From notifications at github.com  Sat Oct  2 23:28:32 2021
From: notifications at github.com (pazza)
Date: Sat, 02 Oct 2021 14:28:32 -0700
Subject: [bisq-network/bisq] Not possible to modify accepted countries 
 (#5692)
In-Reply-To: <bisq-network/bisq/issues/5692@github.com>
References: <bisq-network/bisq/issues/5692@github.com>
Message-ID: <bisq-network/bisq/issues/5692/932822809@github.com>

Yes a save changes button would be good

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5692#issuecomment-932822809
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211002/17cd8faa/attachment-0001.htm>

From notifications at github.com  Sat Oct  2 23:30:15 2021
From: notifications at github.com (BENDYMAN20)
Date: Sat, 02 Oct 2021 14:30:15 -0700
Subject: [bisq-network/bisq] Bisq SPV download stuck at %57 (#5707)
In-Reply-To: <bisq-network/bisq/issues/5707@github.com>
References: <bisq-network/bisq/issues/5707@github.com>
Message-ID: <bisq-network/bisq/issues/5707/932823002@github.com>

No, it didn't. I re installed completely afresh and went back to zero, it
is rather annoying...
Thanks for checking in..

On Sun, Oct 3, 2021 at 12:25 AM pazza ***@***.***> wrote:

> Hi @BENDYMAN20 <https://github.com/BENDYMAN20> did upgrading to 1.7.4 fix
> it for you?
>
> ?
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/bisq-network/bisq/issues/5707#issuecomment-932822575>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AUZ5NMUAZPW3TUE6NT5W7E3UE52FPANCNFSM5EKSVDMA>
> .
> Triage notifications on the go with GitHub Mobile for iOS
> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android
> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>
>


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5707#issuecomment-932823002
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211002/2432fe6e/attachment.htm>

From notifications at github.com  Sat Oct  2 23:46:46 2021
From: notifications at github.com (pazza)
Date: Sat, 02 Oct 2021 14:46:46 -0700
Subject: [bisq-network/bisq] Add "Buy BSQ" button next to trade fee
 selector (#5055)
In-Reply-To: <bisq-network/bisq/pull/5055@github.com>
References: <bisq-network/bisq/pull/5055@github.com>
Message-ID: <bisq-network/bisq/pull/5055/c932824618@github.com>

> @Conza88 @pazza83 Any other open points from your point of view that need to be addressed in this PR?

@ripcurlx thanks for this and the useful screen shots showing the flow.

> 1. If Create offer is already open it will focus in the Sell BTC tab the Filter by Currency dropdown, instead of pre-selecting BSQ

That seems like it would be a little confusing. Any way to get the user straight to the Sell BTC / Buy BSQ screen?

> 2. Just showing Buy BSQ IMO is keeping the user in the void, what will happen when clicking on it.

I Agree, @m52go's solution https://github.com/bisq-network/bisq/pull/5055#issuecomment-932399997 looks good 

> 3. Having Create Offer open in Sell BTC section, will close the Create Offer Tab when clicking on Buy BSQ in the Buy BTC > Take offer or Sell BTC > Create Offer section.

I think this seems ok for it to close.

4. Don't show Buy BSQ when trying to buy BSQ

I think the user should be pushed towards the take offer page, not the make offer page, (more immediate)

> 5. Process of creating a BSQ account is unclear for new users. When trying to buy BSQ user is guided to create a matching payment account.

Bisq handles this well with pop up to create an account.

> Clicking on Go to "Account" will open the account tab in the wrong section and if the user manages to understand that she needs to go to Altcoin Accounts and search for BSQ. Where do I get the BSQ address from?

Maybe pop up text can be updated to include a link to the wiki and mention it is an new altcoin account. @Conza88 previously felt BSQ should have it's own tab. I think this is good but one step at a time :)

> I do think as suggested by @Jakub-CZ that we should automatically create a BSQ Altcoin account and provide the user with the information where she can find the BSQ wallet later on for confirming a trade.

Agreed

> We should also add in the Confirm Payment Receipt screen similar to the Start payment screen a button link to the BSQ wallet. In this case maybe something like Show Payment in BSQ wallet.

Agreed


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5055#issuecomment-932824618
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211002/bae8670b/attachment.htm>

From notifications at github.com  Sat Oct  2 23:48:20 2021
From: notifications at github.com (pazza)
Date: Sat, 02 Oct 2021 14:48:20 -0700
Subject: [bisq-network/bisq] Include deviation from market price in Market
 section in Bisq (#5277)
In-Reply-To: <bisq-network/bisq/issues/5277@github.com>
References: <bisq-network/bisq/issues/5277@github.com>
Message-ID: <bisq-network/bisq/issues/5277/932824751@github.com>

Hi @xyzmaker123 the deviation is the markup (positive or negative the maker chose if choosing to trade on a percentage basis) 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5277#issuecomment-932824751
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211002/3afe1428/attachment.htm>

From notifications at github.com  Sat Oct  2 23:50:56 2021
From: notifications at github.com (pazza)
Date: Sat, 02 Oct 2021 14:50:56 -0700
Subject: [bisq-network/bisq] Bisq SPV download stuck at %57 (#5707)
In-Reply-To: <bisq-network/bisq/issues/5707@github.com>
References: <bisq-network/bisq/issues/5707@github.com>
Message-ID: <bisq-network/bisq/issues/5707/932824991@github.com>

That is frustrating. Send me a message on Keybase https://keybase.io/team/bisq if you are about now and I will be happy to take a look.  My username there is: pazza

SPV resyncs can be frustrating!!!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5707#issuecomment-932824991
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211002/0dbd0060/attachment.htm>

From notifications at github.com  Sun Oct  3 00:08:03 2021
From: notifications at github.com (BENDYMAN20)
Date: Sat, 02 Oct 2021 15:08:03 -0700
Subject: [bisq-network/bisq] Bisq SPV download stuck at %57 (#5707)
In-Reply-To: <bisq-network/bisq/issues/5707@github.com>
References: <bisq-network/bisq/issues/5707@github.com>
Message-ID: <bisq-network/bisq/issues/5707/932826739@github.com>

Will do, thanks!

On Sun, Oct 3, 2021 at 12:50 AM pazza ***@***.***> wrote:

> That is frustrating. Send me a message on Keybase
> https://keybase.io/team/bisq if you are about now and I will be happy to
> take a look. My username there is: pazza
>
> SPV resyncs can be frustrating!!!
>
> ?
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/bisq-network/bisq/issues/5707#issuecomment-932824991>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AUZ5NMU4DGJF24M2HAGE5VTUE55DLANCNFSM5EKSVDMA>
> .
> Triage notifications on the go with GitHub Mobile for iOS
> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android
> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>
>


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5707#issuecomment-932826739
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211002/41088825/attachment-0001.htm>

From notifications at github.com  Sun Oct  3 01:41:54 2021
From: notifications at github.com (jmacxx)
Date: Sat, 02 Oct 2021 16:41:54 -0700
Subject: [bisq-network/bisq] Add Tether (ERC20) (#5735)
In-Reply-To: <bisq-network/bisq/pull/5735@github.com>
References: <bisq-network/bisq/pull/5735@github.com>
Message-ID: <bisq-network/bisq/pull/5735/push/8066167421@github.com>

@jmacxx pushed 1 commit.

4a2e7fdbfa490c2ba5a598c226661e89d845ce0e  add TetherUSDERC20Test


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/bisq-network/bisq/pull/5735/files/c05b72f2154b514a18245dd5e143b21f7873dbdd..4a2e7fdbfa490c2ba5a598c226661e89d845ce0e
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211002/4f76f188/attachment.htm>

From notifications at github.com  Sun Oct  3 14:33:24 2021
From: notifications at github.com (xyzmaker123)
Date: Sun, 03 Oct 2021 05:33:24 -0700
Subject: [bisq-network/bisq] Include deviation from market price in Market
 section in Bisq (#5277)
In-Reply-To: <bisq-network/bisq/issues/5277@github.com>
References: <bisq-network/bisq/issues/5277@github.com>
Message-ID: <bisq-network/bisq/issues/5277/932941743@github.com>

@pazza83 Yeah - I understand. But let's consider this scenario:

1) Transaction A was made in Apr 2, 2021. Market price was 60 000, and there was transaction with price 65 000 - so deviation was +8%

2) Today it's Oct 2, 2021. Market price is 48 000 USD/BTC. We want to display deviation of transaction A on list. I suppose +8% should be displayed, not 35% (based on current price).

Question: is it possible to know what was average market price in Apr 2, 2021 today?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5277#issuecomment-932941743
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211003/e2f9b38b/attachment.htm>

From notifications at github.com  Sun Oct  3 18:48:59 2021
From: notifications at github.com (burningman3)
Date: Sun, 03 Oct 2021 09:48:59 -0700
Subject: [bisq-network/roles] BTC donation address owner ("Burningman")
 (#80)
In-Reply-To: <bisq-network/roles/issues/80@github.com>
References: <bisq-network/roles/issues/80@github.com>
Message-ID: <bisq-network/roles/issues/80/932986393@github.com>

#### BSQ Burning 2021-10-03
BSQ burnt: 50000
preimage: mwnfZ8IX
hash: d06355cdc3fa6e5ef3714bd015064c2549a439d9
message: ieifHN5Mu5sT2M2QA7ihyzKasNwx2ilO
signature: ICDEWT/F5IptafA+VWihrrtwgwCHACSHD/s04x3KqA1sYXPQLBplK1aXXGgVgWbuG2NG4IS7tNPvhMewerN/vMs=


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/roles/issues/80#issuecomment-932986393
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211003/c064b723/attachment.htm>

From notifications at github.com  Mon Oct  4 01:28:43 2021
From: notifications at github.com (jmacxx)
Date: Sun, 03 Oct 2021 16:28:43 -0700
Subject: [bisq-network/bisq] Add payment methods Bizum and Pix (#5741)
Message-ID: <bisq-network/bisq/pull/5741@github.com>

Fixes https://github.com/bisq-network/growth/issues/222
Fixes https://github.com/bisq-network/growth/issues/208


---

&lt;details&gt;
  &lt;summary&gt;Screenshots for Bizum&lt;/summary&gt;
  
![bizum_create_popup](https://user-images.githubusercontent.com/47253594/135775390-30d29633-76f7-48c3-b75d-f8fda4b0e016.png)
![bizum_create](https://user-images.githubusercontent.com/47253594/135775333-3035b6dd-e985-4a4f-858e-70215ddd3f7b.png)
![bizum_buy_popup](https://user-images.githubusercontent.com/47253594/135775338-dc8b54a8-e7b9-4559-8e0c-488a60493c2d.png)
![bizum_buy_offer](https://user-images.githubusercontent.com/47253594/135775342-c0c90bc8-2d51-4965-ab91-5cba404a754e.png)
![bizum_sell_popup](https://user-images.githubusercontent.com/47253594/135775347-c2e40559-d3a8-4a40-9cc5-e1a87e1ff496.png)
![bizum_sell](https://user-images.githubusercontent.com/47253594/135775350-0f118273-4cee-4f7c-b83d-30fee2b915ee.png)
![bizum_trade_buyer](https://user-images.githubusercontent.com/47253594/135775356-ed550abe-534c-4fdb-94fb-04b83e0b6277.png)
![bizum_trade_seller](https://user-images.githubusercontent.com/47253594/135775359-429f994f-79b7-4c5a-834c-08742e7d78a7.png)

&lt;/details&gt;

---

&lt;details&gt;
  &lt;summary&gt;Screenshots for Pix&lt;/summary&gt;
  
![pix_create_popup](https://user-images.githubusercontent.com/47253594/135775440-a0503270-54d1-4b26-a8f1-bbd7188d6247.png)
![pix_create](https://user-images.githubusercontent.com/47253594/135775443-a92da037-df9d-4b88-944c-09f1092c4206.png)
![pix_sell_popup](https://user-images.githubusercontent.com/47253594/135775447-cdb0dd0c-330e-42de-b3ff-bf6e73876e34.png)
![pix_sell_offer](https://user-images.githubusercontent.com/47253594/135775452-ef48e9a4-d208-4e9a-b502-dc2efd442911.png)
![pix_buy_popup](https://user-images.githubusercontent.com/47253594/135775453-e7bc646b-3064-44fe-b2aa-a8276ee73e23.png)
![pix_buy_takeoffer](https://user-images.githubusercontent.com/47253594/135775455-735a2ed9-8b27-4e0d-905f-327ae10a5a13.png)
![pix_trade_pay](https://user-images.githubusercontent.com/47253594/135775458-45e41f56-4be6-41d5-80e2-549f88f9ceb5.png)
![pix_trade_confirm](https://user-images.githubusercontent.com/47253594/135775461-f1f09a6c-b400-4f25-a5a4-fb1d3d45930e.png)

&lt;/details&gt;

---

You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/5741

-- Commit Summary --

  * <a href="https://github.com/bisq-network/bisq/pull/5741/commits/b156f034ad5ba0704f276affadcc47094b4a9d91">add payment methods Bizum and Pix</a>

-- File Changes --

    A core/src/main/java/bisq/core/payment/BizumAccount.java (56)
    M core/src/main/java/bisq/core/payment/PaymentAccountFactory.java (4)
    A core/src/main/java/bisq/core/payment/PixAccount.java (56)
    A core/src/main/java/bisq/core/payment/payload/BizumAccountPayload.java (99)
    M core/src/main/java/bisq/core/payment/payload/PaymentMethod.java (8)
    A core/src/main/java/bisq/core/payment/payload/PixAccountPayload.java (99)
    M core/src/main/java/bisq/core/proto/CoreProtoResolver.java (6)
    M core/src/main/java/bisq/core/trade/statistics/TradeStatistics3.java (4)
    M core/src/main/resources/i18n/displayStrings.properties (31)
    A desktop/src/main/java/bisq/desktop/components/paymentmethods/BizumForm.java (106)
    A desktop/src/main/java/bisq/desktop/components/paymentmethods/PixForm.java (106)
    M desktop/src/main/java/bisq/desktop/main/account/content/fiataccounts/FiatAccountsView.java (6)
    M desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/steps/buyer/BuyerStep2View.java (8)
    M proto/src/main/proto/pb.proto (10)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/5741.patch
https://github.com/bisq-network/bisq/pull/5741.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5741
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211003/6f9db9f5/attachment.htm>

From notifications at github.com  Mon Oct  4 10:27:57 2021
From: notifications at github.com (Christoph Atteneder)
Date: Mon, 04 Oct 2021 01:27:57 -0700
Subject: [bisq-network/bisq] Move volume formatting from DisplayUtils to
 VolumeUtil (#5740)
In-Reply-To: <bisq-network/bisq/pull/5740@github.com>
References: <bisq-network/bisq/pull/5740@github.com>
Message-ID: <bisq-network/bisq/pull/5740/review/770000429@github.com>

@ripcurlx approved this pull request.

utACK



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5740#pullrequestreview-770000429
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211004/0e2f8294/attachment-0001.htm>

From notifications at github.com  Mon Oct  4 10:28:08 2021
From: notifications at github.com (Christoph Atteneder)
Date: Mon, 04 Oct 2021 01:28:08 -0700
Subject: [bisq-network/bisq] Move volume formatting from DisplayUtils to
 VolumeUtil (#5740)
In-Reply-To: <bisq-network/bisq/pull/5740@github.com>
References: <bisq-network/bisq/pull/5740@github.com>
Message-ID: <bisq-network/bisq/pull/5740/issue_event/5402219158@github.com>

Merged #5740 into master.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5740#event-5402219158
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211004/dd886e71/attachment.htm>

From notifications at github.com  Mon Oct  4 10:32:17 2021
From: notifications at github.com (Christoph Atteneder)
Date: Mon, 04 Oct 2021 01:32:17 -0700
Subject: [bisq-network/growth] Add Bizum as a new payment method (popular
 in Spain) (#222)
In-Reply-To: <bisq-network/growth/issues/222@github.com>
References: <bisq-network/growth/issues/222@github.com>
Message-ID: <bisq-network/growth/issue/222/issue_event/5402245266@github.com>

Closed #222 via bisq-network/bisq#5741.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/growth/issues/222#event-5402245266
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211004/7cfee701/attachment.htm>

From notifications at github.com  Mon Oct  4 10:32:17 2021
From: notifications at github.com (Christoph Atteneder)
Date: Mon, 04 Oct 2021 01:32:17 -0700
Subject: [bisq-network/growth] New payment method from Brazil - PIX (#208)
In-Reply-To: <bisq-network/growth/issues/208@github.com>
References: <bisq-network/growth/issues/208@github.com>
Message-ID: <bisq-network/growth/issue/208/issue_event/5402245276@github.com>

Closed #208 via bisq-network/bisq#5741.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/growth/issues/208#event-5402245276
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211004/427862a6/attachment.htm>

From notifications at github.com  Mon Oct  4 10:32:18 2021
From: notifications at github.com (Christoph Atteneder)
Date: Mon, 04 Oct 2021 01:32:18 -0700
Subject: [bisq-network/bisq] Add payment methods Bizum and Pix (#5741)
In-Reply-To: <bisq-network/bisq/pull/5741@github.com>
References: <bisq-network/bisq/pull/5741@github.com>
Message-ID: <bisq-network/bisq/pull/5741/review/770005048@github.com>

@ripcurlx approved this pull request.

utACK - NIT: Please start your commit messages with an uppercase (https://chris.beams.io/posts/git-commit/)



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5741#pullrequestreview-770005048
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211004/f9b7f05f/attachment.htm>

From notifications at github.com  Mon Oct  4 10:32:31 2021
From: notifications at github.com (Christoph Atteneder)
Date: Mon, 04 Oct 2021 01:32:31 -0700
Subject: [bisq-network/bisq] Add payment methods Bizum and Pix (#5741)
In-Reply-To: <bisq-network/bisq/pull/5741@github.com>
References: <bisq-network/bisq/pull/5741@github.com>
Message-ID: <bisq-network/bisq/pull/5741/issue_event/5402245250@github.com>

Merged #5741 into master.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5741#event-5402245250
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211004/090fcd00/attachment.htm>

From notifications at github.com  Mon Oct  4 10:40:41 2021
From: notifications at github.com (Christoph Atteneder)
Date: Mon, 04 Oct 2021 01:40:41 -0700
Subject: [bisq-network/bisq] Display maker/taker BTC fees statistics the
 burning man collects per cycle (Discussion #5739)
In-Reply-To: <bisq-network/bisq/repo-discussions/5739@github.com>
References: <bisq-network/bisq/repo-discussions/5739@github.com>
Message-ID: <bisq-network/bisq/repo-discussions/5739/comments/1423568@github.com>

There is already a project in-progress that will also show this kind of information (BTC trade revenue fees are what you are looking for): https://github.com/bisq-network/growth/issues/245

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/discussions/5739#discussioncomment-1423568
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211004/91db44d5/attachment-0001.htm>

From notifications at github.com  Mon Oct  4 10:44:42 2021
From: notifications at github.com (Christoph Atteneder)
Date: Mon, 04 Oct 2021 01:44:42 -0700
Subject: [bisq-network/bisq] DAO and Fund section in Bisq seems to be
 missing ability to copy links  (#5278)
In-Reply-To: <bisq-network/bisq/issues/5278@github.com>
References: <bisq-network/bisq/issues/5278@github.com>
Message-ID: <bisq-network/bisq/issues/5278/933273539@github.com>

The problem I see with this feature request is the concrete implementation part. ATM there is the icon for the link, which is used everywhere in the client. When we want to introduce the copy icon, where should it be? Next to the link icon would be confusing IMO.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5278#issuecomment-933273539
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211004/389f415d/attachment.htm>

From notifications at github.com  Mon Oct  4 10:50:10 2021
From: notifications at github.com (Christoph Atteneder)
Date: Mon, 04 Oct 2021 01:50:10 -0700
Subject: [bisq-network/bisq] Add Tether (ERC20) (#5735)
In-Reply-To: <bisq-network/bisq/pull/5735@github.com>
References: <bisq-network/bisq/pull/5735@github.com>
Message-ID: <bisq-network/bisq/pull/5735/review/770022846@github.com>

@ripcurlx approved this pull request.





-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5735#pullrequestreview-770022846
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211004/07567b03/attachment.htm>

From notifications at github.com  Mon Oct  4 10:50:27 2021
From: notifications at github.com (Christoph Atteneder)
Date: Mon, 04 Oct 2021 01:50:27 -0700
Subject: [bisq-network/bisq] Add Tether (ERC20) (#5735)
In-Reply-To: <bisq-network/bisq/pull/5735@github.com>
References: <bisq-network/bisq/pull/5735@github.com>
Message-ID: <bisq-network/bisq/pull/5735/issue_event/5402352657@github.com>

Merged #5735 into master.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5735#event-5402352657
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211004/8ec70cd5/attachment.htm>

From notifications at github.com  Mon Oct  4 11:20:08 2021
From: notifications at github.com (Christoph Atteneder)
Date: Mon, 04 Oct 2021 02:20:08 -0700
Subject: [bisq-network/bisq] Add "Buy BSQ" button next to trade fee
 selector (#5055)
In-Reply-To: <bisq-network/bisq/pull/5055@github.com>
References: <bisq-network/bisq/pull/5055@github.com>
Message-ID: <bisq-network/bisq/pull/5055/push/8072483022@github.com>

@ripcurlx pushed 1 commit.

4841c411e5f43de82b5f150dff6bf644f3818896  Improve wording


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/bisq-network/bisq/pull/5055/files/730709469bcedcb8bfc2f81132c181ad2aebb795..4841c411e5f43de82b5f150dff6bf644f3818896
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211004/1d4ece0f/attachment.htm>

From notifications at github.com  Mon Oct  4 11:23:31 2021
From: notifications at github.com (Christoph Atteneder)
Date: Mon, 04 Oct 2021 02:23:31 -0700
Subject: [bisq-network/bisq] Add "Buy BSQ" button next to trade fee
 selector (#5055)
In-Reply-To: <bisq-network/bisq/pull/5055@github.com>
References: <bisq-network/bisq/pull/5055@github.com>
Message-ID: <bisq-network/bisq/pull/5055/c933304167@github.com>

> That seems like it would be a little confusing. Any way to get the user straight to the Sell BTC / Buy BSQ screen?

That is what it should do - I just pointed out the UI error with the Combox of the current implementation.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5055#issuecomment-933304167
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211004/43bee98e/attachment.htm>

From notifications at github.com  Mon Oct  4 11:56:43 2021
From: notifications at github.com (sqrrm)
Date: Mon, 04 Oct 2021 02:56:43 -0700
Subject: [bisq-network/bisq] Revert "Community tab" (#5736)
In-Reply-To: <bisq-network/bisq/pull/5736@github.com>
References: <bisq-network/bisq/pull/5736@github.com>
Message-ID: <bisq-network/bisq/pull/5736/review/770090414@github.com>

@sqrrm approved this pull request.

utACK



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5736#pullrequestreview-770090414
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211004/c558342e/attachment.htm>

From notifications at github.com  Mon Oct  4 11:56:51 2021
From: notifications at github.com (sqrrm)
Date: Mon, 04 Oct 2021 02:56:51 -0700
Subject: [bisq-network/bisq] Revert "Community tab" (#5736)
In-Reply-To: <bisq-network/bisq/pull/5736@github.com>
References: <bisq-network/bisq/pull/5736@github.com>
Message-ID: <bisq-network/bisq/pull/5736/issue_event/5402748703@github.com>

Merged #5736 into master.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5736#event-5402748703
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211004/dcb2b9c3/attachment-0001.htm>

From notifications at github.com  Tue Oct  5 19:14:49 2021
From: notifications at github.com (jmacxx)
Date: Tue, 05 Oct 2021 10:14:49 -0700
Subject: [bisq-network/bisq] Allow trader chat to continue after trade
 complete (#5742)
Message-ID: <bisq-network/bisq/pull/5742@github.com>


Trader chat no longer gets automatically closed at trade completion, and traders can open it again from closed trades.

Fixes #5734 

You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/5742

-- Commit Summary --

  * <a href="https://github.com/bisq-network/bisq/pull/5742/commits/5aa0a13c80049bc38758b3e88af5f073b9e9d8ec">Allow trader chat after trade complete</a>

-- File Changes --

    M core/src/main/java/bisq/core/support/SupportManager.java (4)
    M core/src/main/java/bisq/core/support/dispute/DisputeManager.java (3)
    M core/src/main/java/bisq/core/support/traderchat/TraderChatManager.java (46)
    M desktop/src/main/java/bisq/desktop/main/portfolio/closedtrades/ClosedTradesDataModel.java (12)
    M desktop/src/main/java/bisq/desktop/main/portfolio/closedtrades/ClosedTradesView.fxml (1)
    M desktop/src/main/java/bisq/desktop/main/portfolio/closedtrades/ClosedTradesView.java (224)
    M desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/PendingTradesView.java (13)
    M desktop/src/main/java/bisq/desktop/main/shared/ChatView.java (5)
    M desktop/src/main/java/bisq/desktop/main/support/dispute/DisputeChatPopup.java (2)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/5742.patch
https://github.com/bisq-network/bisq/pull/5742.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5742
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211005/3a56e645/attachment.htm>

From notifications at github.com  Tue Oct  5 19:25:06 2021
From: notifications at github.com (jmacxx)
Date: Tue, 05 Oct 2021 10:25:06 -0700
Subject: [bisq-network/bisq] Allow trader chat to continue after trade
 complete (#5742)
In-Reply-To: <bisq-network/bisq/pull/5742@github.com>
References: <bisq-network/bisq/pull/5742@github.com>
Message-ID: <bisq-network/bisq/pull/5742/push/8085101892@github.com>

@jmacxx pushed 1 commit.

ce369d9574b4d4545d478a8ce223ebaecb12cc53  Allow trader chat after trade complete


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/bisq-network/bisq/pull/5742/files/5aa0a13c80049bc38758b3e88af5f073b9e9d8ec..ce369d9574b4d4545d478a8ce223ebaecb12cc53
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211005/a1247332/attachment.htm>

From notifications at github.com  Tue Oct  5 19:31:51 2021
From: notifications at github.com (jmacxx)
Date: Tue, 05 Oct 2021 10:31:51 -0700
Subject: [bisq-network/bisq] Allow trader chat to continue after trade
 complete (#5742)
In-Reply-To: <bisq-network/bisq/pull/5742@github.com>
References: <bisq-network/bisq/pull/5742@github.com>
Message-ID: <bisq-network/bisq/pull/5742/push/8085148192@github.com>

@jmacxx pushed 1 commit.

616d0aa3062fcd2cec708d4cea56b06af742ab2d  Allow trader chat after trade complete


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/bisq-network/bisq/pull/5742/files/ce369d9574b4d4545d478a8ce223ebaecb12cc53..616d0aa3062fcd2cec708d4cea56b06af742ab2d
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211005/e7d6f95e/attachment.htm>

From notifications at github.com  Tue Oct  5 20:28:45 2021
From: notifications at github.com (user9102)
Date: Tue, 05 Oct 2021 11:28:45 -0700
Subject: [bisq-network/bisq] Lost ~0.02159616 BTC during 0.01 BTC trade
 (#5661)
In-Reply-To: <bisq-network/bisq/issues/5661@github.com>
References: <bisq-network/bisq/issues/5661@github.com>
Message-ID: <bisq-network/bisq/issues/5661/934659997@github.com>

I may have experienced same issue. Balance in wallet info is no longer matching available balance. I previously had a couple failed transactions. I have a couple trades a day and don't monitor the balance closely after each trade.

My recent deposit to bisq wallet didn't get reflected on the balance when I started to notice this issue. I picked an unused address from the list, not the one from the bottom of "Fund your wallet" address. BTC arrived and listed under the transactions tab, but not in Receive Funds or Send Funds. So I check the Wallet Info and notice there are more "missing" funds. If I added the new missing deposit and current available balance, the total still doesn't match the balance in Wallet Info.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5661#issuecomment-934659997
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211005/1e4cf29e/attachment.htm>

From notifications at github.com  Tue Oct  5 22:10:05 2021
From: notifications at github.com (Stan)
Date: Tue, 05 Oct 2021 13:10:05 -0700
Subject: [bisq-network/bisq] Refactor desktop Closed Tradable model utils for
 API (#5743)
Message-ID: <bisq-network/bisq/pull/5743@github.com>

Move some potentially shareable utility code from desktop&#39;s ClosedTrade models to core&#39;s new `ClosedTradeUtil`.

The API&#39;s `gettrades --category=&lt;open|closed|failed&gt;` method will need some of this logic on the server side, but the scope of the refactoring is larger in the interest of completeness, and avoiding duplication in the future.


This PR&#39;s branch is based off `master`, and is not part of any PR chain requiring review/merge of any parent PRs.
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/5743

-- Commit Summary --

  * <a href="https://github.com/bisq-network/bisq/pull/5743/commits/999c4a516dc20d1f1a7bd5ea3da922e5c0bb4ffd">Refactor desktop Closed Tradable model utils for API use</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5743/commits/738d22fbdfcc691babdb735aa44f8bf9d555d438">Rename method, add static import</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5743/commits/fae72883855a70f8c993091f7c08baad48f8101b">Adjust to renamed method</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5743/commits/30135177f86563ffc07e8c5542d558e692937092">Remove transitive javafx.collections dependency</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5743/commits/5f521068eaaa2613fd463ab09d35da7aa97b8d70">Remove unused PriceFeedService</a>

-- File Changes --

    A core/src/main/java/bisq/core/trade/closed/ClosedTradeUtil.java (390)
    M desktop/src/main/java/bisq/desktop/main/portfolio/closedtrades/ClosedTradesDataModel.java (117)
    M desktop/src/main/java/bisq/desktop/main/portfolio/closedtrades/ClosedTradesViewModel.java (239)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/5743.patch
https://github.com/bisq-network/bisq/pull/5743.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5743
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211005/f1b3a4c2/attachment-0001.htm>

From notifications at github.com  Wed Oct  6 09:29:15 2021
From: notifications at github.com (Christoph Atteneder)
Date: Wed, 06 Oct 2021 00:29:15 -0700
Subject: [bisq-network/bisq] Refactor desktop Closed Tradable model utils
 for API (#5743)
In-Reply-To: <bisq-network/bisq/pull/5743@github.com>
References: <bisq-network/bisq/pull/5743@github.com>
Message-ID: <bisq-network/bisq/pull/5743/review/772286656@github.com>

@ripcurlx approved this pull request.

utACK



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5743#pullrequestreview-772286656
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211006/dafbf31d/attachment.htm>

From notifications at github.com  Wed Oct  6 09:29:25 2021
From: notifications at github.com (Christoph Atteneder)
Date: Wed, 06 Oct 2021 00:29:25 -0700
Subject: [bisq-network/bisq] Refactor desktop Closed Tradable model utils
 for API (#5743)
In-Reply-To: <bisq-network/bisq/pull/5743@github.com>
References: <bisq-network/bisq/pull/5743@github.com>
Message-ID: <bisq-network/bisq/pull/5743/issue_event/5417100974@github.com>

Merged #5743 into master.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5743#event-5417100974
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211006/e1902872/attachment.htm>

From notifications at github.com  Wed Oct  6 09:52:37 2021
From: notifications at github.com (Christoph Atteneder)
Date: Wed, 06 Oct 2021 00:52:37 -0700
Subject: [bisq-network/bisq] Allow trader chat to continue after trade
 complete (#5742)
In-Reply-To: <bisq-network/bisq/pull/5742@github.com>
References: <bisq-network/bisq/pull/5742@github.com>
Message-ID: <bisq-network/bisq/pull/5742/c935684942@github.com>

@pazza83 @chimp1984 This PR would make it possible to open a chat again also from closed trades. I think it would be sufficient to not auto-close the chat window when it is open after a trade is completed.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5742#issuecomment-935684942
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211006/e1d96dd0/attachment.htm>

From notifications at github.com  Wed Oct  6 11:31:11 2021
From: notifications at github.com (Christoph Atteneder)
Date: Wed, 06 Oct 2021 02:31:11 -0700
Subject: [bisq-network/bisq] Add "Buy BSQ" button next to trade fee
 selector (#5055)
In-Reply-To: <bisq-network/bisq/pull/5055@github.com>
References: <bisq-network/bisq/pull/5055@github.com>
Message-ID: <bisq-network/bisq/pull/5055/c935837696@github.com>

@Jakub-CZ Was there a reason why you wanted to close the `Create Offer` view when switching the user to the Sell Bitcoin (Buy BSQ) screen?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5055#issuecomment-935837696
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211006/d9541735/attachment.htm>

From notifications at github.com  Wed Oct  6 12:16:06 2021
From: notifications at github.com (Christoph Atteneder)
Date: Wed, 06 Oct 2021 03:16:06 -0700
Subject: [bisq-network/bisq] Add "Buy BSQ" button next to trade fee
 selector (#5055)
In-Reply-To: <bisq-network/bisq/pull/5055@github.com>
References: <bisq-network/bisq/pull/5055@github.com>
Message-ID: <bisq-network/bisq/pull/5055/c935908490@github.com>

Now with more context. Clicking on `Learn More` opens the popup, clicking on `Buy BSQ` brings you to the Buy BSQ offer book.
![Bildschirmfoto 2021-10-06 um 12 13 35](https://user-images.githubusercontent.com/170962/136184208-95d73d64-9645-4ab9-8c05-4a5866082b02.png)
![Bildschirmfoto 2021-10-06 um 12 13 40](https://user-images.githubusercontent.com/170962/136184219-96b9efe1-92fc-4437-9667-cbd1570bfa43.png)
![Bildschirmfoto 2021-10-06 um 12 14 08](https://user-images.githubusercontent.com/170962/136184223-8e2451ab-85f3-4d14-b400-221dc6e28a5e.png)


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5055#issuecomment-935908490
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211006/1c1b7a1d/attachment.htm>

From notifications at github.com  Wed Oct  6 14:01:39 2021
From: notifications at github.com (=?UTF-8?B?SmFrdWIgTG91Y2vDvQ==?=)
Date: Wed, 06 Oct 2021 05:01:39 -0700
Subject: [bisq-network/bisq] Add "Buy BSQ" button next to trade fee
 selector (#5055)
In-Reply-To: <bisq-network/bisq/pull/5055@github.com>
References: <bisq-network/bisq/pull/5055@github.com>
Message-ID: <bisq-network/bisq/pull/5055/c936101280@github.com>

@ripcurlx:

I think there's no reason to close `Create Offer (to buy BTC)`.

The suggestion was to close `Create Offer (to sell BTC)`. There were two reasons:
1. If we leave it open then the user won't be able to create a new offer to buy BSQ. (also noted by @sqrrm)
2. I was hoping that closing the tab programmatically would get around the UI bug (unwanted focus on the currency combo box).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5055#issuecomment-936101280
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211006/7b019797/attachment.htm>

From notifications at github.com  Wed Oct  6 14:58:25 2021
From: notifications at github.com (A-Simon)
Date: Wed, 06 Oct 2021 05:58:25 -0700
Subject: [bisq-network/support] Fee reimbursement for trade 23773143 (#1009)
Message-ID: <bisq-network/support/issues/1009@github.com>

<img width="901" alt="Screen Shot 2021-09-28 at 5 56 49 PM" src="https://user-images.githubusercontent.com/46980254/136205976-28339bcf-3aee-4b03-a289-be60a868e2df.png">


Maker:  3968db85d14a1e98d6781233b1960d1a8263c64c94431f419ca6f1b4cff90098
Taker: N/A
Deposit: N/A


Bisq version: v1.7.4
BTC address for reimbursement: bc1qurt78pf637r69d8pke68kc7mumw0zn2lqkny0e

Other notes:

The trade protocol encountered some problems. 
The trade contract is not set.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/support/issues/1009
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211006/740d0bd9/attachment.htm>

From notifications at github.com  Wed Oct  6 16:57:24 2021
From: notifications at github.com (jmacxx)
Date: Wed, 06 Oct 2021 07:57:24 -0700
Subject: [bisq-network/bisq] Allow trader chat to continue after trade
 complete (#5742)
In-Reply-To: <bisq-network/bisq/pull/5742@github.com>
References: <bisq-network/bisq/pull/5742@github.com>
Message-ID: <bisq-network/bisq/pull/5742/c936439839@github.com>

:+1:  I'm ok with removing the chat feature from closed trades, if that's what people want.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5742#issuecomment-936439839
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211006/0ea9e56d/attachment.htm>

From notifications at github.com  Wed Oct  6 17:15:39 2021
From: notifications at github.com (chimp1984)
Date: Wed, 06 Oct 2021 08:15:39 -0700
Subject: [bisq-network/bisq] Allow trader chat to continue after trade
 complete (#5742)
In-Reply-To: <bisq-network/bisq/pull/5742@github.com>
References: <bisq-network/bisq/pull/5742@github.com>
Message-ID: <bisq-network/bisq/pull/5742/c936474281@github.com>

Great thanks @jmacxx that you implemented that so fast!
I have no strong opinion regarding re-opening.
Maybe the support guys can add their opinions.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5742#issuecomment-936474281
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211006/27611712/attachment.htm>

From notifications at github.com  Wed Oct  6 17:25:58 2021
From: notifications at github.com (slipperybeluga)
Date: Wed, 06 Oct 2021 08:25:58 -0700
Subject: [bisq-network/bisq] Exception message: Not able to find peers
 witness, unable to sign for trade (#5744)
Message-ID: <bisq-network/bisq/issues/5744@github.com>

This is a new ticket for a [closed issue from 2020.](https://github.com/bisq-network/bisq/issues/4065) I haven't used Bisq in months, so I had to install the latest version 1.7.4 and delete my hiddenservice folder to support v3 nodes. Unsure if that is relevant. 

Here is the error message that occurs when I click "confirm payment receipt":
**An error occurred at task: SellerSendPayoutTxPublishedMessage
Exception message: Not able to find peers witness, unable to sign for trade {} [Trade{**

While I am unable to click the "confirm payment receipt" button to close the transaction, both parties have received their deposits back and the buyer has gotten their BTC. The transaction still appears open in Bisq.

I have more complete logs I can send if helpful. I do not want to post them here. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5744
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211006/28c34dfb/attachment-0001.htm>

From notifications at github.com  Thu Oct  7 01:12:59 2021
From: notifications at github.com (raymondclowe)
Date: Wed, 06 Oct 2021 16:12:59 -0700
Subject: [bisq-network/growth] New payment method: Hong Kong Faster Payment
 System (FPS) (#251)
Message-ID: <bisq-network/growth/issues/251@github.com>

### Why

Very popular in Hong Kong.  Fast, safe, supported by all banks as well as various other non-bank payment systems.

All P2P I've done in the last year, as well as every purchase from vendors for things like phones and harddisks, has been paid using this.

The other party only has to give one of their FPS ID (a digit string), email address or phone number and they can receive payment instantly with no fees.  Their partially obscured name is provided for confirmation, then full name of sender is shown on completion.


### Region

Hong Kong only

### Currencies

Hong Kong dollars

### Chargeback risk

I don't think it is possible.  Not confirmed.

### Size of user base

Everybody in HK can use it, can't tell how many actually do.


### Data requirements

FPS ID is the minimum


### Verification

The receiver will get a notification.  Typically this is all done with bank or ewallet apps on phone.  So you just get a notification immediately, sometimes an email as well.

Some banks have a web interface.

### Duration

Never had a transaction take longer than maybe 3 seconds.  Typically under one second.

### Fees

No fees

### Fraud risk

I dont know how this could be used for fraud.

### Payment amounts

No minimum.  Not sure official maxium, most banks have some sort of limit but I've seen HK$50K transactions commonly.

### Payment description

Yes

### Name

This is "Faster Payment System", always called "FPS".  It is *not* related to the UK system "FPS/Faster Payments" although the end user experience is similar.


### More information:

https://www.hkma.gov.hk/eng/key-functions/international-financial-centre/financial-market-infrastructure/faster-payment-system-fps/



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/growth/issues/251
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211006/ceb5ea3c/attachment.htm>

From notifications at github.com  Thu Oct  7 02:26:32 2021
From: notifications at github.com (jmacxx)
Date: Wed, 06 Oct 2021 17:26:32 -0700
Subject: [bisq-network/bisq] Allow trader chat to continue after trade
 complete (#5742)
In-Reply-To: <bisq-network/bisq/pull/5742@github.com>
References: <bisq-network/bisq/pull/5742@github.com>
Message-ID: <bisq-network/bisq/pull/5742/push/8099261221@github.com>

@jmacxx pushed 1 commit.

c13fb950e3facaa6d041ff561422dccbacbf40ff  Allow trader chat after trade complete


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/bisq-network/bisq/pull/5742/files/616d0aa3062fcd2cec708d4cea56b06af742ab2d..c13fb950e3facaa6d041ff561422dccbacbf40ff
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211006/afd64c66/attachment.htm>

From notifications at github.com  Thu Oct  7 02:43:44 2021
From: notifications at github.com (jmacxx)
Date: Wed, 06 Oct 2021 17:43:44 -0700
Subject: [bisq-network/bisq] Allow trader chat to continue after trade
 complete (#5742)
In-Reply-To: <bisq-network/bisq/pull/5742@github.com>
References: <bisq-network/bisq/pull/5742@github.com>
Message-ID: <bisq-network/bisq/pull/5742/c937352189@github.com>

Discussed with support team, they prefer no chat on closed trades, so I reverted that feature.  You'll still be able to chat until the chat window is closed.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5742#issuecomment-937352189
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211006/a2483825/attachment.htm>

From notifications at github.com  Fri Oct  8 00:11:33 2021
From: notifications at github.com (jmacxx)
Date: Thu, 07 Oct 2021 15:11:33 -0700
Subject: [bisq-network/bisq] Add payment methods Monese and SatisPay (#5745)
Message-ID: <bisq-network/bisq/pull/5745@github.com>

Fixes https://github.com/bisq-network/growth/issues/227
Fixes https://github.com/bisq-network/growth/issues/213


---

&lt;details&gt;
  &lt;summary&gt;Screenshots for Monese&lt;/summary&gt;
  
![monese_account_popup](https://user-images.githubusercontent.com/47253594/136468670-75ad6398-607f-4730-8219-7ad90f2ab803.png)
![monese_account](https://user-images.githubusercontent.com/47253594/136468704-595c9271-eadd-4d59-bc82-6c3f2dc5d19a.png)
![monese_buy_popup](https://user-images.githubusercontent.com/47253594/136468736-019a34fd-9b32-4387-8a5c-0a2939919781.png)
![monese_buy](https://user-images.githubusercontent.com/47253594/136468756-ecb6153d-be03-4fe7-882e-a33dda88dd9a.png)
![monese_sell_popup](https://user-images.githubusercontent.com/47253594/136468766-2a0e71eb-bd6e-4fd8-8033-f1f862782296.png)
![monese_sell](https://user-images.githubusercontent.com/47253594/136468784-950c11d6-fe43-4432-a6be-4c893eb1a2bf.png)
![monese_start_payment](https://user-images.githubusercontent.com/47253594/136468794-6c5d5837-cae1-476c-9b33-39b37103d887.png)
![monese_confirm_payment](https://user-images.githubusercontent.com/47253594/136468808-15e17863-c35b-4f8b-a6a2-d9b525952ed9.png)

&lt;/details&gt;

---

&lt;details&gt;
  &lt;summary&gt;Screenshots for SatisPay&lt;/summary&gt;

![satispay_account_popup](https://user-images.githubusercontent.com/47253594/136468860-d2fc1f64-100b-403b-b062-1a4bdd007555.png)
![satispay_account](https://user-images.githubusercontent.com/47253594/136468863-82813e2e-cc11-401a-827b-1c0a5b5a3812.png)
![satispay_buy_popup](https://user-images.githubusercontent.com/47253594/136468907-5c5c3d1e-4e88-4f0d-8d85-a534069ce517.png)
![satispay_buy](https://user-images.githubusercontent.com/47253594/136468918-6fe99828-ba80-423a-ae0e-abe125339351.png)
![satispay_sell_popup](https://user-images.githubusercontent.com/47253594/136468944-8917a33c-d3ab-4be9-88dd-5c9c8375364d.png)
![satispay_sell](https://user-images.githubusercontent.com/47253594/136468947-9f52d2ba-0ba2-43fe-a677-be76ae9257a6.png)
![satispay_payment_started](https://user-images.githubusercontent.com/47253594/136468952-2acc89a6-663b-4e79-b1a1-b840c7ba27b0.png)
![satispay_confirm_payment](https://user-images.githubusercontent.com/47253594/136468965-c7604365-6dec-41de-a915-93d02723185c.png)


&lt;/details&gt;

---

You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/5745

-- Commit Summary --

  * <a href="https://github.com/bisq-network/bisq/pull/5745/commits/fb2e7c1f51e1799bfd3775a5a5da015a0ee0fcfd">Add payment methods Monese and SatisPay</a>

-- File Changes --

    M core/src/main/java/bisq/core/locale/CurrencyUtil.java (9)
    A core/src/main/java/bisq/core/payment/MoneseAccount.java (56)
    M core/src/main/java/bisq/core/payment/PaymentAccountFactory.java (4)
    A core/src/main/java/bisq/core/payment/SatisPayAccount.java (58)
    A core/src/main/java/bisq/core/payment/payload/MoneseAccountPayload.java (89)
    M core/src/main/java/bisq/core/payment/payload/PaymentMethod.java (6)
    A core/src/main/java/bisq/core/payment/payload/SatisPayAccountPayload.java (99)
    M core/src/main/java/bisq/core/proto/CoreProtoResolver.java (6)
    M core/src/main/java/bisq/core/trade/statistics/TradeStatistics3.java (4)
    M core/src/main/resources/i18n/displayStrings.properties (30)
    A desktop/src/main/java/bisq/desktop/components/paymentmethods/MoneseForm.java (116)
    A desktop/src/main/java/bisq/desktop/components/paymentmethods/SatisPayForm.java (106)
    M desktop/src/main/java/bisq/desktop/main/account/content/fiataccounts/FiatAccountsView.java (6)
    M desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/steps/buyer/BuyerStep2View.java (8)
    M proto/src/main/proto/pb.proto (12)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/5745.patch
https://github.com/bisq-network/bisq/pull/5745.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5745
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211007/4277e780/attachment.htm>

From notifications at github.com  Fri Oct  8 00:29:28 2021
From: notifications at github.com (jmacxx)
Date: Thu, 07 Oct 2021 15:29:28 -0700
Subject: [bisq-network/bisq] Add payment methods Monese and Satispay
 (#5745)
In-Reply-To: <bisq-network/bisq/pull/5745@github.com>
References: <bisq-network/bisq/pull/5745@github.com>
Message-ID: <bisq-network/bisq/pull/5745/push/8107626884@github.com>

@jmacxx pushed 1 commit.

df2d0b3332b6e5544e099b0e6651363818fc444b  Add payment methods Monese and SatisPay


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/bisq-network/bisq/pull/5745/files/fb2e7c1f51e1799bfd3775a5a5da015a0ee0fcfd..df2d0b3332b6e5544e099b0e6651363818fc444b
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211007/1e309902/attachment.htm>

From notifications at github.com  Fri Oct  8 15:25:55 2021
From: notifications at github.com (jmacxx)
Date: Fri, 08 Oct 2021 06:25:55 -0700
Subject: [bisq-network/bisq] Exception message: Not able to find peers
 witness, unable to sign for trade (#5744)
In-Reply-To: <bisq-network/bisq/issues/5744@github.com>
References: <bisq-network/bisq/issues/5744@github.com>
Message-ID: <bisq-network/bisq/issues/5744/938641734@github.com>

> While I am unable to click the "confirm payment receipt" button to close the transaction, both parties have received their deposits back and the buyer has gotten their BTC. The transaction still appears open in Bisq.

The trade has completed but still shows up in your open trades list.

The following advice involves clearing the data structure which keeps track of open trades.  This is only applicable in extreme circumstances when the normal flow of operations did not happen, as is the case here.  As always, [make a backup](https://bisq.wiki/Backing_up_application_data) first.

[Prerequisite: you must have no other open trades, as all current open trades will be removed.  If you have other open trades, do not continue until they have all completed].  

To remove the open trades, close down Bisq then delete the file `PendingTrades` file from the `db` folder within the [data directory](https://bisq.wiki/Data_directory).  


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5744#issuecomment-938641734
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211008/5c5e744a/attachment.htm>

From notifications at github.com  Sat Oct  9 01:58:05 2021
From: notifications at github.com (pazza)
Date: Fri, 08 Oct 2021 16:58:05 -0700
Subject: [bisq-network/bisq] Add "Buy BSQ" button next to trade fee
 selector (#5055)
In-Reply-To: <bisq-network/bisq/pull/5055@github.com>
References: <bisq-network/bisq/pull/5055@github.com>
Message-ID: <bisq-network/bisq/pull/5055/c939183569@github.com>

Hi @ripcurlx 

Should this pop up also include a link to: https://bisq.wiki/Trading_BSQ

![136184219-96b9efe1-92fc-4437-9667-cbd1570bfa43](https://user-images.githubusercontent.com/66367547/136636162-fd690c58-2ced-49d6-8369-544515b6c080.png)




-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5055#issuecomment-939183569
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211008/5b2003ee/attachment.htm>

From notifications at github.com  Sat Oct  9 06:50:21 2021
From: notifications at github.com (Conza)
Date: Fri, 08 Oct 2021 21:50:21 -0700
Subject: [bisq-network/bisq] Add "Buy BSQ" button next to trade fee
 selector (#5055)
In-Reply-To: <bisq-network/bisq/pull/5055@github.com>
References: <bisq-network/bisq/pull/5055@github.com>
Message-ID: <bisq-network/bisq/pull/5055/c939226320@github.com>

> @Conza88 previously felt BSQ should have it's own tab. I think this is good but one step at a time :)

Yep ha. All in bolded below. 

_"8. Improve BSQ overall

Implement Segwit for BSQ
**[Improve BSQ account creation & purchase process](https://github.com/bisq-network/bisq/issues/5046)**
Improve BSQ accessibility through OTC market and bonded reputation
Add Low priority payment type to BSQ
BSQ balance on wallet info screen includes merit BSQ
BSQ Fees equivalent not correctly calulated into BTC in info tooltip
Very poor UX with buying BSQ. BSQ should not be in the 'alt-coin' camp either imo. Coloured BTC is better. Make more present/clear in app (without implying its better than BTC)."_

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5055#issuecomment-939226320
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211008/0780fca9/attachment.htm>

From notifications at github.com  Sat Oct  9 12:56:18 2021
From: notifications at github.com (chimp1984)
Date: Sat, 09 Oct 2021 03:56:18 -0700
Subject: [bisq-network/bisq] Add "Buy BSQ" button next to trade fee
 selector (#5055)
In-Reply-To: <bisq-network/bisq/pull/5055@github.com>
References: <bisq-network/bisq/pull/5055@github.com>
Message-ID: <bisq-network/bisq/pull/5055/c939276824@github.com>

FYI @sqrrm 's atomic BSQ-BTC swap will be ready soon...

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5055#issuecomment-939276824
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211009/6c99a8d4/attachment.htm>

From notifications at github.com  Sat Oct  9 13:03:45 2021
From: notifications at github.com (Christoph Atteneder)
Date: Sat, 09 Oct 2021 04:03:45 -0700
Subject: [bisq-network/bisq] Allow trader chat to continue after trade
 complete (#5742)
In-Reply-To: <bisq-network/bisq/pull/5742@github.com>
References: <bisq-network/bisq/pull/5742@github.com>
Message-ID: <bisq-network/bisq/pull/5742/review/775569302@github.com>

@ripcurlx approved this pull request.

utACK



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5742#pullrequestreview-775569302
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211009/39504982/attachment.htm>

From notifications at github.com  Sat Oct  9 13:03:56 2021
From: notifications at github.com (Christoph Atteneder)
Date: Sat, 09 Oct 2021 04:03:56 -0700
Subject: [bisq-network/bisq] Keep trader chat open after trade has
 finished (#5734)
In-Reply-To: <bisq-network/bisq/issues/5734@github.com>
References: <bisq-network/bisq/issues/5734@github.com>
Message-ID: <bisq-network/bisq/issue/5734/issue_event/5437984541@github.com>

Closed #5734 via #5742.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5734#event-5437984541
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211009/72b6fe94/attachment.htm>

From notifications at github.com  Sat Oct  9 13:03:56 2021
From: notifications at github.com (Christoph Atteneder)
Date: Sat, 09 Oct 2021 04:03:56 -0700
Subject: [bisq-network/bisq] Allow trader chat to continue after trade
 complete (#5742)
In-Reply-To: <bisq-network/bisq/pull/5742@github.com>
References: <bisq-network/bisq/pull/5742@github.com>
Message-ID: <bisq-network/bisq/pull/5742/issue_event/5437984537@github.com>

Merged #5742 into master.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5742#event-5437984537
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211009/aa8497de/attachment.htm>

From notifications at github.com  Sat Oct  9 13:05:02 2021
From: notifications at github.com (Christoph Atteneder)
Date: Sat, 09 Oct 2021 04:05:02 -0700
Subject: [bisq-network/bisq] Add "Buy BSQ" button next to trade fee
 selector (#5055)
In-Reply-To: <bisq-network/bisq/pull/5055@github.com>
References: <bisq-network/bisq/pull/5055@github.com>
Message-ID: <bisq-network/bisq/pull/5055/c939278121@github.com>

> FYI @sqrrm 's atomic BSQ-BTC swap will be ready soon...

Even better :smile: That will speed-up the BSQ purchase process even more.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5055#issuecomment-939278121
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211009/a0a4122f/attachment.htm>

From notifications at github.com  Sat Oct  9 16:36:04 2021
From: notifications at github.com (jmacxx)
Date: Sat, 09 Oct 2021 07:36:04 -0700
Subject: [bisq-network/bisq] Fix issue of Trade Step 1 validation done too
 soon (#5746)
Message-ID: <bisq-network/bisq/pull/5746@github.com>

This PR fixes an issue where some trade data validation was performed too soon, before the transaction has been applied to the trade, resulting in an erroneous popup informing the user &quot;There is an issue with a missing or invalid transaction&quot;.

Resolves: #5494.

---

The trade data validation is done at transition to `Trade Step 1`, it does some basic [sanity checking of the deposit transaction](https://github.com/bisq-network/bisq/blob/2e38c3cf3525ff4275f26b755c9eea88b322af9d/core/src/main/java/bisq/core/trade/TradeDataValidation.java#L358-L377): that it is present, that it has 2 inputs, etc.  Unfortunately there is a timing issue whereby Trade Step 1 is sometimes reached before the transaction has been applied to the trade.

The trade currently transitions to Trade Step 1 when [the deposit transaction is exchanged P2P](https://github.com/bisq-network/bisq/blob/2e38c3cf3525ff4275f26b755c9eea88b322af9d/core/src/main/java/bisq/core/trade/protocol/tasks/seller/SellerSendsDepositTxAndDelayedPayoutTxMessage.java#L82-L104)
 in task `SellerSendsDepositTxAndDelayedPayoutTxMessage`.  

After broadcasting, the deposit transaction is [stored on the Trade](https://github.com/bisq-network/bisq/blob/2e38c3cf3525ff4275f26b755c9eea88b322af9d/core/src/main/java/bisq/core/trade/protocol/tasks/seller/SellerPublishesDepositTx.java#L50-L52) via `applyDepositTx()`.  This can be up to 5 seconds later.

Within that window of time, the trade shows with red &quot;failed&quot; iconography and the validation done at Trade Step 1 fails because of missing information in the Trade.




The goal of this PR is to make Trade Step 1 compatible with the assumption that the trade is initialized enough to check.  It makes a simple change moving the Trade Step 1 milestone further along the trade init path, after the broadcast, when the deposit tx has been applied to the trade.  This way we can be safe in the assumption that the trade is initialized enough to perform our validation.

---

**Other considerations:**

There are a number of other ways this could be addressed, such that the deposit tx is applied to the trade early enough in initialization.

1. Task SellerPublishesDepositTx could be invoked before SellerSendsDepositTxAndDelayedPayoutTxMessage.  
2. `applyDepositTx()` to the trade in SellerAsMakerFinalizesDepositTx.
 

Currently, I have picked the least intrusive change to fix this particular bug, although testing showed that these other two options also would work.  Upon reflection. I notice the chosen solution is slightly incongruent with the the [ordering of Trade.State](https://github.com/bisq-network/bisq/blob/2e38c3cf3525ff4275f26b755c9eea88b322af9d/core/src/main/java/bisq/core/trade/Trade.java#L113-L131) and the concept of trade Phase.  Perhaps it would be better to consider the options above, of applying deposit Tx to Trade earlier.

An added benefit of applying the deposit transaction earlier would be that the trade would no longer erroneously flash the failed icons prior to broadcast completing (which currently has the effect of causing undue alarm).
![failedtrade2](https://user-images.githubusercontent.com/47253594/136661869-b0466203-bb6f-4f4e-aab6-e3c65176d0f9.png)

So in fact I&#39;d prefer to have solution (2) above; it is cleaner although it might carry more change risk.
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/5746

-- Commit Summary --

  * <a href="https://github.com/bisq-network/bisq/pull/5746/commits/4b74bd82ba48a0722cbe11f7f8a4975d0eb2c4b7">Fix issue of Trade Step 1 validation done too soon</a>

-- File Changes --

    M desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/PendingTradesViewModel.java (14)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/5746.patch
https://github.com/bisq-network/bisq/pull/5746.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5746
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211009/00b46c10/attachment-0001.htm>

From notifications at github.com  Sun Oct 10 15:57:56 2021
From: notifications at github.com (jeforson)
Date: Sun, 10 Oct 2021 06:57:56 -0700
Subject: [bisq-network/support] Fee reimbursement for trade RPYSYF (#1010)
Message-ID: <bisq-network/support/issues/1010@github.com>

>_The XXXXX part in the issue title are the first characters of the Trade ID before the "-" (dash)._

![image](https://user-images.githubusercontent.com/52366428/136698753-1fac2667-86ac-4fe0-91e3-5c7fc956ee27.png)

>_The screenshot from the Bisq client must have the **Trade ID**, **Deposit**, **Maker** and **Taker** TXIDs visible. Of course some trades do not have all 3 types, that is ok. Make sure all private information is covered (like bank accounts, name, etc). **Do not upload images where sensitive private data is visible!**_

Maker:  f0dd54afcfad5cf3e626a25f2a8400c3383db6f65a8b7017612bfd6d7e075967
Taker: 4708e96e2ffb9a5e5961da8d46cd39ae03d4ce206c24dc6f5e24cf196d423526
Deposit: 8155ba0a195c384aa7c22e8a595db10b6145e0b5b7e8e5b08178e32f2691236a

>_A reimbursement request has to contain textual representation of **Maker**, **Taker** and **Deposit** TXIDs (copy them from the client to the issue). **All TXIDs that are visible in the screenshot must be copied to the issue in text form! Please use exact form for Maker/Taker/Deposit - no abbreviations like M:, T: or adding extra characters like "Maker TX:", etc. Leave those fields as they are and replace the "........" with the appropreate txid**_

Bisq version: 1.7.4
BTC address for reimbursement: bc1qxq8ju5hapzt3t946yuxf5hctf7khj66eumyf94

>_Provide the Bisq client version to help developers identify the causing issue._

Other notes: Lost maker and miner fees

>_Issue [#197](https://github.com/bisq-network/support/issues/197) can be used as a good example of a correct reimbursement request._


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/support/issues/1010
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211010/0574106b/attachment.htm>

From notifications at github.com  Sun Oct 10 18:16:19 2021
From: notifications at github.com (sqrrm)
Date: Sun, 10 Oct 2021 09:16:19 -0700
Subject: [bisq-network/bisq] [WIP] Atomic bsq trades (#5729)
In-Reply-To: <bisq-network/bisq/pull/5729@github.com>
References: <bisq-network/bisq/pull/5729@github.com>
Message-ID: <bisq-network/bisq/pull/5729/push/8122488624@github.com>

@sqrrm pushed 71 commits.

7872dbc1f31c7467539921e344f92a09f1b060af  Add common interface for tradePeer.
0354017281ceb6f162242ee9f86576d56f74ef29  Remove payment method handling
f9d384c200faf0a00ffc5039b20d7f4150484ec5  Add generics for TradePeer
3cc549b9e47f2a57ed7ee2fd26dab9a14a4bdb49  Rename getTradingPeer to getTradePeer
78ddc2da12d3a24ec10d9aedb8d0520828039655  Replace TradingPeer BsqSwapTradePeer in BsqSwapProtocolModel
503a065de84ce646ac43013f3e2bd85dc2303cf1  Add the 4 variants to trade and protocols
739811cd84d781436137c12638559fa304ae1845  Trade protocol update according to other trade protocol
7022505660bc58be33cab52fec1e6411e1d1c787  Use tx confidence listener in SellerSetupTxListener
d77127d6d4544b59140eda898cfd7f02e8b73f31  Cleanups
76982ffe094d22d75b2a80f0beea62984c1d3ed5  Rename bsqSwapProtocolModel to protocolModel
cadef15f6b0188bd304fcc6c8e095e3372ca13f2  Rename bsqSwapTrade to trade
82d05dd95025f968ea6594cd19adf0442c888892  Rename TradeProtocolModel to ProtocolModel
8167d6db3d6835ce631a8bda8cdd8c9b45bc6911  Rename bsqSwapTrade to trade
063dc93aca178f07345f3c7e69bc8c7da8550793  Move package bisq.core.trade.messages to bisq.core.trade.protocol.messages
b432110b4e67f5f99e2a423be43a4babbee15079  Move ClosedTradableManager and FailedTradesManager inside bisq.core.trade.model
011c9292ad72be923e2e87244713e8cd9614b9b8  Remove references from multisigbased trade domain from generic trade classes
7a5ba91a941d9aca77d97e908c1c951b58f935e4  Use concrete state/phase in impl classes
8a2fdb0770d5c5c5d6ae5b058381ec0d8fbdcf66  Move contract into trade package
853848dfa86f2545eaedc0da301a42ab7fc7cc4b  Use Trade as type in tradableList
18193562ad1548364ac63a9f2f60b2eea4d3b308  Remove offer only once trade is completed (tx visisble if maker is seller)
0f8d1c9e11572936f35eaacdf8e06ef47c5c52b9  Rename classes
030cff8fefb12bc3842825e5ca334a53b8bf2e7b  Rename trade package to bisq_v1
1f5f844a8171d3424990be8cb218a5d1defcabc2  Move TradeProtocolFactory level up
6a3c3a148902030ca2ec6d01d9706c435b7ce5c1  Rename bsqswap package to bsq_swap
9a36329c707af671971578a111a59751d343b0a5  Start work on BsqTradeDetailsWindow
b45211ec73bbf435889120f84aef9d393a4e043c  Add comment to make fee allocation in tx more clear
07cdf7062f6f102d313738ff2b43e9578148ad96  Rename BsqSwapWalletWatcher to BsqSwapOfferManager
5b51fd7c3156c628e64fe9b4cf20a155f8cca849  Add methods to DaoFacade and DaoStateService
63f2d2520ed01680fe76623348d6088b0bad70a9  Add fee listener
499302ba50f9ad2ad3cab1367984f6ee3a0d74d3  Use Singleton annotation
6700ca6bf10d418e0303fb08a1099b50c1f8ba83  Let BsqSwapAccountPayload extend PaymentAccountPayload
aa83e5b5856a9ae5484267aa53e041f33d3dc725  Add comment
fa0853a41f89aece36e235cd1ca9b4ca5eb26391  Increase fee tolerance.
4da55ea0ef9bc787e8c2310b74f7caed5a435f34  Rename getTradeVolume to getVolume
303b536ad111fa7bbf23ec5820f9f3135b437827  Add getBsqTradeAmount to BsqSwapCalculation
3e8357a273dd82345a639529d2cf197c1aa2e4ad  Check for witness before setting it
45b99212c156fbc68072d7b9fad6e5df35e9cd97  Remove unnecessary check, add comment
827d60348571f7ae204e0181a331bc1b41d25e45  Add todo
a2fcaa06c1cf6159941b09abbcf76a9f7c25559e  Add comment
725b8eb1cd94b7d89ff17daadf69c0d4282cf8bc  Refactor tx creation and verification
9242ab9d8d40dfaf3ccacf6c4608a176b8a1bb26  Add handling for trade complete in case we have not got it set already
359262560228ac3563edc4537ab9d44097391d10  Extract super class for sending messages
bb643205397c3f8661f8825869ba6356e13ab36a  Cleanups
e44a4313e8ca9de79f4374d4d3226260d1875ee1  Complete trade in case the tx broadcast got a timeout
fd56eef3352c45f327e8daec428d46985f2d7e25  Remove unused methods
9e109ce6683b05fec643508cabf56b56e352ea00  Add scriptTypeId to RawTransactionInput
8dc34c0e553428607d87781d7c25f72b2d7817ed  Replace constructor call with fromProto
efc5d0bba0352347f0def1be89f91ef4b1c23fee  Remove unused methods
095d78009963117fee6cb2e1fe6257c3aec7398e  Use RawTransactionInput constructor instead of getRawInputFromTransactionInput
4e70e5ba11e6a08fe83c212ad084998c2882f27f  Move getRawInputFromTransactionInput to TradeWalletService
73b897a7014c0d7647c5335a7efa56266d119f49  Fix wrong exception, add more log details
8e308e68a192121b67856e126def19575dd4c4f7  Rename getTxSize to getVBytesSize
138fa2a92096be45c58393d3c9b0ff70a69302ff  Fix check for segwit.
b4c1b4e827837f2d49c754cf1d542fa90a507832  Add handling for InsufficientMoneyException
9858c2684700169d7aa78269c2422f70c57e4051  Add verification for peers change amount
2e80f18641a0ff7b40cf665bf34c97b186281aa3  Add verification for peers change
0550fda754ca094de40a30a63605a45b3b4736f7  Store sellersBsqPayoutAmount in protocolModel.setPayout
b53c5449baa784d68e0e5fec420fc3fa08ee8a7e  Fix checks for change with trade fees and tx fees
a266db86544040fd680a6da34a587c6f983791a9  Comment out balance check (temp for dev)
aec5608721b5f333d3db4b07095ef4f5ef7e9a52  Do not handle dust here. We will handle it in caller
0e54439142c2a1e0ad4a8031704af331487acef2  Fix handling for slightly overpaid BTC funds
f5e19c08efa7466b281bb3f4eb1aa3af5e3141d1  Add address validation
6b799f9515e6148906c9e93d21dfb6292c664a65  Add check for change <= expectedChange
13adb3a49d4400a360146a01a9b1ed1b792930bf  Update protocol description
0a09bc0a1a0a90f55406af456442a59aad3dbac5  Rename methods and params
598186329d7ac52098ee71e3560cee21134c8436  Add getParentTxId method
4c1308748eb9dd3f4cf2bc7230c05aa7b752bf7f  Use getParentTxId method
7c1c93e68d3260fe650152d9c7caddc26f8ba952  Use isDust
f0fc08fe28d2ca151a552ff7fa1f861abba2afc7  Add getUnspentTxOutputValue method
30d025a67a4c18d227701176e581e13af8020b35  Handle dust in caller
9c7bdf33f40aff29043f0a40b39fff963c9a53ad  Merge pull request #16 from chimp1984/Complete-trade-protocol


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/bisq-network/bisq/pull/5729/files/c4e129b326a259e0862788bf9468e4d4c1287d13..9c7bdf33f40aff29043f0a40b39fff963c9a53ad
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211010/fba5d987/attachment-0001.htm>

From notifications at github.com  Sun Oct 10 22:22:25 2021
From: notifications at github.com (asvdf)
Date: Sun, 10 Oct 2021 13:22:25 -0700
Subject: [bisq-network/proposals] Allow custom fee for withdrawals (#343)
Message-ID: <bisq-network/proposals/issues/343@github.com>

> _This is a Bisq Network proposal. Please familiarize yourself with the [submission and review process](https://bisq.wiki/Proposals)._

The default fee set by the application to send the trade deposit from within Bisq itself can be easily avoided by setting your own fee from an external wallet, although the withdrawal can only be done from within Bisq, and the fee cannot be set to 1sat/vB, instead being forced to be at least 2sats/vB.
It is a very small amount but it does add up in the end, it should be very simple and extremely fast to implement a 1sat/vB min value, and during this extremely low fees period it seems pretty wasteful to pay double than needed.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/proposals/issues/343
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211010/cdf1b3f3/attachment.htm>

From notifications at github.com  Sun Oct 10 22:45:03 2021
From: notifications at github.com (MwithM)
Date: Sun, 10 Oct 2021 13:45:03 -0700
Subject: [bisq-network/compensation] Cycle 18 deadline is October 27th (#922)
Message-ID: <bisq-network/compensation/issues/922@github.com>

 The deadline for submitting compensations requests for review is October 27. More deatails at: https://github.com/bisq-network/compensation/issues

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/922
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211010/8a107618/attachment.htm>

From notifications at github.com  Sun Oct 10 22:45:05 2021
From: notifications at github.com (bisq-bot[bot])
Date: Sun, 10 Oct 2021 13:45:05 -0700
Subject: [bisq-network/compensation] Cycle 18 deadline is October 27th
 (#922)
In-Reply-To: <bisq-network/compensation/issues/922@github.com>
References: <bisq-network/compensation/issues/922@github.com>
Message-ID: <bisq-network/compensation/issues/922/939549683@github.com>



## Errors
USD amount not specified in summary section
BSQ amount not specified in summary section
No compensation lineitems found.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/922#issuecomment-939549683
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211010/a0a016e5/attachment.htm>

From notifications at github.com  Sun Oct 10 22:46:36 2021
From: notifications at github.com (bisq-bot[bot])
Date: Sun, 10 Oct 2021 13:46:36 -0700
Subject: [bisq-network/compensation] Cycle 29 deadline is October 27th
 (#922)
In-Reply-To: <bisq-network/compensation/issues/922@github.com>
References: <bisq-network/compensation/issues/922@github.com>
Message-ID: <bisq-network/compensation/issues/922/939549884@github.com>



## Errors
USD amount not specified in summary section
BSQ amount not specified in summary section
No compensation lineitems found.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/922#issuecomment-939549884
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211010/b3af7eb2/attachment.htm>

From notifications at github.com  Sun Oct 10 22:48:31 2021
From: notifications at github.com (bisq-bot[bot])
Date: Sun, 10 Oct 2021 13:48:31 -0700
Subject: [bisq-network/compensation] Cycle 29 deadline is October 17th
 (#922)
In-Reply-To: <bisq-network/compensation/issues/922@github.com>
References: <bisq-network/compensation/issues/922@github.com>
Message-ID: <bisq-network/compensation/issues/922/939550222@github.com>



## Errors
USD amount not specified in summary section
BSQ amount not specified in summary section
No compensation lineitems found.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/922#issuecomment-939550222
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211010/1eb2d84c/attachment.htm>

From notifications at github.com  Sun Oct 10 22:48:50 2021
From: notifications at github.com (bisq-bot[bot])
Date: Sun, 10 Oct 2021 13:48:50 -0700
Subject: [bisq-network/compensation] Cycle 29 deadline is October 17th
 (#922)
In-Reply-To: <bisq-network/compensation/issues/922@github.com>
References: <bisq-network/compensation/issues/922@github.com>
Message-ID: <bisq-network/compensation/issues/922/939550260@github.com>



## Errors
USD amount not specified in summary section
BSQ amount not specified in summary section
No compensation lineitems found.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/922#issuecomment-939550260
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211010/b3da5a12/attachment.htm>

From notifications at github.com  Mon Oct 11 00:11:16 2021
From: notifications at github.com (asvdf)
Date: Sun, 10 Oct 2021 15:11:16 -0700
Subject: [bisq-network/proposals] Allow custom fee for withdrawals (#343)
In-Reply-To: <bisq-network/proposals/issues/343@github.com>
References: <bisq-network/proposals/issues/343@github.com>
Message-ID: <bisq-network/proposals/issues/343/939561140@github.com>

Thank you @pazza83 , I also forgot to mention that in the worst case scenario, where you were so unlucky to withdraw at 1sat/vB right before a huge mempool rush lasting for weeks, it wouldn't be much of a hassle even without RBF, since someone could probably do a CPFP or wait for the transaction to disappear to find the funds back in Bisq wallet.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/proposals/issues/343#issuecomment-939561140
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211010/55e75d1b/attachment-0001.htm>

From notifications at github.com  Mon Oct 11 09:18:38 2021
From: notifications at github.com (Christoph Atteneder)
Date: Mon, 11 Oct 2021 00:18:38 -0700
Subject: [bisq-network/bisq] Add payment methods Monese and Satispay
 (#5745)
In-Reply-To: <bisq-network/bisq/pull/5745@github.com>
References: <bisq-network/bisq/pull/5745@github.com>
Message-ID: <bisq-network/bisq/pull/5745/review/775879500@github.com>

@ripcurlx approved this pull request.

utACK



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5745#pullrequestreview-775879500
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211011/98719cea/attachment.htm>

From notifications at github.com  Mon Oct 11 09:28:59 2021
From: notifications at github.com (Christoph Atteneder)
Date: Mon, 11 Oct 2021 00:28:59 -0700
Subject: [bisq-network/bisq] Fix issue of Trade Step 1 validation done too
 soon (#5746)
In-Reply-To: <bisq-network/bisq/pull/5746@github.com>
References: <bisq-network/bisq/pull/5746@github.com>
Message-ID: <bisq-network/bisq/pull/5746/c939763145@github.com>

I experienced this exact same issue for the first time this weekend (being on the seller side) as well. As I'm not so fluent with the trade protocol I'll wait for ACKs by @sqrrm or @chimp1984.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5746#issuecomment-939763145
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211011/d0b48dba/attachment.htm>

From notifications at github.com  Mon Oct 11 09:29:49 2021
From: notifications at github.com (Christoph Atteneder)
Date: Mon, 11 Oct 2021 00:29:49 -0700
Subject: [bisq-network/growth] Add Monese as a payment method (popular
 mobile bank app in UK and Europe) (#227)
In-Reply-To: <bisq-network/growth/issues/227@github.com>
References: <bisq-network/growth/issues/227@github.com>
Message-ID: <bisq-network/growth/issue/227/issue_event/5441282861@github.com>

Closed #227 via bisq-network/bisq#5745.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/growth/issues/227#event-5441282861
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211011/c8c995de/attachment.htm>

From notifications at github.com  Mon Oct 11 09:29:49 2021
From: notifications at github.com (Christoph Atteneder)
Date: Mon, 11 Oct 2021 00:29:49 -0700
Subject: [bisq-network/growth] Satispay (#213)
In-Reply-To: <bisq-network/growth/issues/213@github.com>
References: <bisq-network/growth/issues/213@github.com>
Message-ID: <bisq-network/growth/issue/213/issue_event/5441282870@github.com>

Closed #213 via bisq-network/bisq#5745.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/growth/issues/213#event-5441282870
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211011/b3daa8f9/attachment.htm>

From notifications at github.com  Mon Oct 11 09:30:03 2021
From: notifications at github.com (Christoph Atteneder)
Date: Mon, 11 Oct 2021 00:30:03 -0700
Subject: [bisq-network/bisq] Add payment methods Monese and Satispay
 (#5745)
In-Reply-To: <bisq-network/bisq/pull/5745@github.com>
References: <bisq-network/bisq/pull/5745@github.com>
Message-ID: <bisq-network/bisq/pull/5745/issue_event/5441282850@github.com>

Merged #5745 into master.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5745#event-5441282850
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211011/98e2094e/attachment.htm>

From notifications at github.com  Mon Oct 11 11:02:33 2021
From: notifications at github.com (Christoph Atteneder)
Date: Mon, 11 Oct 2021 02:02:33 -0700
Subject: [bisq-network/bisq] Add "Buy BSQ" button next to trade fee
 selector (#5055)
In-Reply-To: <bisq-network/bisq/pull/5055@github.com>
References: <bisq-network/bisq/pull/5055@github.com>
Message-ID: <bisq-network/bisq/pull/5055/push/8126254125@github.com>

@ripcurlx pushed 2 commits.

c218f50a7737435d49be742c7769b6c48d62098f  Improve informational popup
d27c6145fb9e025241cdaae5e18267820e51cb0c  Add info icon for disabled button


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/bisq-network/bisq/pull/5055/files/f40b0071219956444e461dc6ef7fa63da6accd01..d27c6145fb9e025241cdaae5e18267820e51cb0c
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211011/ca6595af/attachment-0001.htm>

From notifications at github.com  Mon Oct 11 11:20:34 2021
From: notifications at github.com (Christoph Atteneder)
Date: Mon, 11 Oct 2021 02:20:34 -0700
Subject: [bisq-network/bisq] Add "Buy BSQ" button next to trade fee
 selector (#5055)
In-Reply-To: <bisq-network/bisq/pull/5055@github.com>
References: <bisq-network/bisq/pull/5055@github.com>
Message-ID: <bisq-network/bisq/pull/5055/push/8126392515@github.com>

@ripcurlx pushed 1 commit.

85e0bf46830688f1ff4a207bad4e23276a62b876  Add tooltip for disabled create offer button


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/bisq-network/bisq/pull/5055/files/d27c6145fb9e025241cdaae5e18267820e51cb0c..85e0bf46830688f1ff4a207bad4e23276a62b876
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211011/6ffa043c/attachment.htm>

From notifications at github.com  Mon Oct 11 11:21:57 2021
From: notifications at github.com (Christoph Atteneder)
Date: Mon, 11 Oct 2021 02:21:57 -0700
Subject: [bisq-network/bisq] Add "Buy BSQ" button next to trade fee
 selector (#5055)
In-Reply-To: <bisq-network/bisq/pull/5055@github.com>
References: <bisq-network/bisq/pull/5055@github.com>
Message-ID: <bisq-network/bisq/pull/5055/c939847834@github.com>

Finally I found time to continue on this PR. Unfortunately it isn't possible to set a tooltip for a disabled node (mouse events are disabled), so I needed to wrap it into a StackPane putting a label on top to mimick this IMO standard behavior. TODO: Move into a re-usable component.

<img width="1367" alt="Bildschirmfoto 2021-10-11 um 11 19 53" src="https://user-images.githubusercontent.com/170962/136766015-0038e7c1-3213-4ed5-9213-244e624c7776.png">


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5055#issuecomment-939847834
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211011/ad36debb/attachment.htm>

From notifications at github.com  Mon Oct 11 11:38:42 2021
From: notifications at github.com (chimp1984)
Date: Mon, 11 Oct 2021 02:38:42 -0700
Subject: [bisq-network/bisq] Fix issue of Trade Step 1 validation done too
 soon (#5746)
In-Reply-To: <bisq-network/bisq/pull/5746@github.com>
References: <bisq-network/bisq/pull/5746@github.com>
Message-ID: <bisq-network/bisq/pull/5746/c939860853@github.com>

Thanks @jmacxx for looking into that.
I think the proposed fix is a bit dangerous as we use the ordinal of the trade states in various areas, so changing the order of states can has unintended side effects.

I think better is to change the handling in PendingTradesViewModel.onTradeStateChanged to something like that:
```
   // #################### Phase DEPOSIT_PAID
            case SELLER_PUBLISHED_DEPOSIT_TX:
                buyerState.set(BuyerState.STEP1);
                sellerState.set(SellerState.STEP1);
                break;

                // DEPOSIT_TX_PUBLISHED_MSG
                // seller perspective
            case SELLER_SENT_DEPOSIT_TX_PUBLISHED_MSG:
            case SELLER_SAW_ARRIVED_DEPOSIT_TX_PUBLISHED_MSG:
            case SELLER_STORED_IN_MAILBOX_DEPOSIT_TX_PUBLISHED_MSG:
            case SELLER_SEND_FAILED_DEPOSIT_TX_PUBLISHED_MSG:
                break;

                // buyer perspective
            case BUYER_RECEIVED_DEPOSIT_TX_PUBLISHED_MSG:

                // Alternatively the maker could have seen the deposit tx earlier before he received the DEPOSIT_TX_PUBLISHED_MSG
            case BUYER_SAW_DEPOSIT_TX_IN_NETWORK:
                buyerState.set(BuyerState.STEP1);
                sellerState.set(SellerState.STEP1);
                break;

```

I have not tested it, but I think it should lead to the expected behaviour to move to step 1 only after the deposit tx is published.

I guess there might be an issue though with false positive - failed broadcastTx attempts. Sometimes the broadcast gets a timeout in 5 sec. even the broadcast works but due some bitcoinj issue it returns a failure. In such cases the user would never move to step 1. I think the SellerPublishesDepositTx need to handle that to in the onFailure case (apply same code as in onSuccess). That might be a bit risky as if it really fails we still would apply it. Maybe the tx from the wallet gives enough information to decide if the broadcast worked or not. I guess the tx gets committed to the wallet also in case of a failure, so to just look up the tx in the wallet will likely not work. But maybe the confidence or some other tx details reveal more....


  

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5746#issuecomment-939860853
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211011/affd2061/attachment.htm>

From notifications at github.com  Mon Oct 11 12:04:39 2021
From: notifications at github.com (chimp1984)
Date: Mon, 11 Oct 2021 03:04:39 -0700
Subject: [bisq-network/bisq] Fix issue of Trade Step 1 validation done too
 soon (#5746)
In-Reply-To: <bisq-network/bisq/pull/5746@github.com>
References: <bisq-network/bisq/pull/5746@github.com>
Message-ID: <bisq-network/bisq/pull/5746/c939879623@github.com>

Ah the above would not work as the ordinal of SELLER_PUBLISHED_DEPOSIT_TX is < SELLER_SAW_ARRIVED_DEPOSIT_TX_PUBLISHED_MSG and we do not allow setting states to lower states. 

All those states:
```
SELLER_SENT_DEPOSIT_TX_PUBLISHED_MSG(Phase.DEPOSIT_PUBLISHED),
        SELLER_SAW_ARRIVED_DEPOSIT_TX_PUBLISHED_MSG(Phase.DEPOSIT_PUBLISHED),
        SELLER_STORED_IN_MAILBOX_DEPOSIT_TX_PUBLISHED_MSG(Phase.DEPOSIT_PUBLISHED),
        SELLER_SEND_FAILED_DEPOSIT_TX_PUBLISHED_MSG(Phase.DEPOSIT_PUBLISHED),
```

are only used in the  PendingTradesViewModel and as we should ignore those anyway we could decide to NOT set them, so the setting of the SELLER_PUBLISHED_DEPOSIT_TX would not get blocked (a comment why we dont set them and marking those states deprecated would be good as well).

The order of the states is a relict from the old trade protocol and also sometimes there is no deterministic order of events.
The state handling got too fine grained for the level where we use it.

Regarding the failed broadcast:
We use the default TxBroadcaster.Callback.onTimeout method which calls onSuccess at those expected false positive failures (see comment there). So the code in SellerPublishesDepositTx should work for those cases as it is. Would have been an issue anyway otherwise as the code at onSuccess is important to be executed and it would have led to bugs if that would not get called.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5746#issuecomment-939879623
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211011/92906898/attachment.htm>

From notifications at github.com  Mon Oct 11 14:23:02 2021
From: notifications at github.com (UX-P)
Date: Mon, 11 Oct 2021 05:23:02 -0700
Subject: [bisq-network/proposals] New role request- User Researcher (#344)
Message-ID: <bisq-network/proposals/issues/344@github.com>

> _This is a Bisq Network proposal. Please familiarize yourself with the [submission and review process]
<!-- Please do not remove the text above. -->

Hello, I would like to make a proposal in regards to creating a new role possibly within the Growth team. A User Researcher. This will consist of conducting one on one user interviews which will take place via zoom where interviewees have the option to turn their cameras off if preferable, for privacy reasons.  User focused questions will be discussed in order to really identify the interviewee?s expectations, the aim is to iron out usability concerns as early as possible. I will ask questions based on their overall user experience of Bisq as well as enquiring about the usability of specific areas on the site, including any features and processes.

The next stage will be to analysis the interviews and identify common topics, words or phrases via affinity mapping, this allows me to pinpoint the user's key issues and concerns during their user journey.

I will communicate my qualitative findings through a summary report available to the community manager and others within the growth team, and make proposals based on my evaluations. This will be known as a community proposal.

-**Community Proposal**-

A community proposal will be derived from the report analysis on a per monthly basis (timescale will vary depending on previous proposal).
 
This will be a supportive addition to the current proposal system. A community proposal will assist in Optimising user feedback to make overarching issues easier to identify and help to implement changes based on the way the overall user wishes to navigate the site.

-**Project Contributions**-

The User Researcher can also contribute on a per project basis at the owner?s request. During the initial stages of production, the project owner would discuss the specific aspects that they would like to focus on and what they would like to get out of this user needs assessment. 
I will form questions based on this subject area, and subsequently, explore channels to request interviews. 

As a user myself I will be balancing what I already know about Bisq and the current user experience with an open free form discussion to really learn about the overall user, gaining a more in-depth view that you cannot otherwise gage solely through social media chat channels. 

A user researcher is an ongoing role and is valid in all stages of design with the aim to humanise the online experience. In order to advance with the product, the usability of the initial software should be considered.  
User researching is essentially about improving the current phase and also providing insights to future projects that can be turned into actionable ideas and solutions. 
In order to widen the Bisq market and grow the platform it is essential to primarily know and understand our users to ensure a pleasant and seamless experience. 

Thank you for taking the time to read my proposal, and I look forward to your feedback. 


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/proposals/issues/344
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211011/cd3e2491/attachment.htm>

From notifications at github.com  Mon Oct 11 15:46:21 2021
From: notifications at github.com (m52go)
Date: Mon, 11 Oct 2021 06:46:21 -0700
Subject: [bisq-network/proposals] New role request- User Researcher (#344)
In-Reply-To: <bisq-network/proposals/issues/344@github.com>
References: <bisq-network/proposals/issues/344@github.com>
Message-ID: <bisq-network/proposals/issues/344/940047094@github.com>

This sounds like a good idea but I'm not clear about what to expect on an ongoing basis to justify creating another role. 

Perhaps you can coordinate with an existing or upcoming project and provide an example of what you can deliver first so people can better evaluate what such a role would accomplish.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/proposals/issues/344#issuecomment-940047094
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211011/6cb4aaf2/attachment.htm>

From notifications at github.com  Mon Oct 11 16:35:36 2021
From: notifications at github.com (jmacxx)
Date: Mon, 11 Oct 2021 07:35:36 -0700
Subject: [bisq-network/bisq] Fix issue of Trade Step 1 validation done too
 soon (#5746)
In-Reply-To: <bisq-network/bisq/pull/5746@github.com>
References: <bisq-network/bisq/pull/5746@github.com>
Message-ID: <bisq-network/bisq/pull/5746/push/8128827509@github.com>

@jmacxx pushed 1 commit.

9ab659ceac8993f50eb4c83f338d6345e7f417e4  Fix issue of Trade Step 1 validation done too soon


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/bisq-network/bisq/pull/5746/files/4b74bd82ba48a0722cbe11f7f8a4975d0eb2c4b7..9ab659ceac8993f50eb4c83f338d6345e7f417e4
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211011/6c9daaf5/attachment.htm>

From notifications at github.com  Mon Oct 11 16:40:54 2021
From: notifications at github.com (chimp1984)
Date: Mon, 11 Oct 2021 07:40:54 -0700
Subject: [bisq-network/bisq] Fix issue of Trade Step 1 validation done too
 soon (#5746)
In-Reply-To: <bisq-network/bisq/pull/5746@github.com>
References: <bisq-network/bisq/pull/5746@github.com>
Message-ID: <bisq-network/bisq/pull/5746/review/776319057@github.com>

@chimp1984 approved this pull request.

utACK



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5746#pullrequestreview-776319057
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211011/bbc5d6e3/attachment-0001.htm>

From notifications at github.com  Mon Oct 11 17:55:14 2021
From: notifications at github.com (jmacxx)
Date: Mon, 11 Oct 2021 08:55:14 -0700
Subject: [bisq-network/bisq] Fix issue of Trade Step 1 validation done too
 soon (#5746)
In-Reply-To: <bisq-network/bisq/pull/5746@github.com>
References: <bisq-network/bisq/pull/5746@github.com>
Message-ID: <bisq-network/bisq/pull/5746/c940151298@github.com>

To also prevent the initial red failed icons in Open Trades list, something like this would do it, what do you think?

PendingTradesView.java L370:

    private boolean isMaybeInvalidTrade(Trade trade) {
        return trade.hasErrorMessage() ||
                (Trade.Phase.DEPOSIT_PUBLISHED.ordinal() <= trade.getPhase().ordinal() && trade.isTxChainInvalid());
    }


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5746#issuecomment-940151298
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211011/8d41ce3c/attachment.htm>

From notifications at github.com  Mon Oct 11 19:09:20 2021
From: notifications at github.com (chimp1984)
Date: Mon, 11 Oct 2021 10:09:20 -0700
Subject: [bisq-network/bisq] Fix issue of Trade Step 1 validation done too
 soon (#5746)
In-Reply-To: <bisq-network/bisq/pull/5746@github.com>
References: <bisq-network/bisq/pull/5746@github.com>
Message-ID: <bisq-network/bisq/pull/5746/c940204576@github.com>

> To also prevent the initial red failed icons in Open Trades list, something like this would do it, what do you think?
> 
> PendingTradesView.java L370:
> 
> ```
> private boolean isMaybeInvalidTrade(Trade trade) {
>     return trade.hasErrorMessage() ||
>             (Trade.Phase.DEPOSIT_PUBLISHED.ordinal() <= trade.getPhase().ordinal() && trade.isTxChainInvalid());
> }
> ```

Looks ok to me.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5746#issuecomment-940204576
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211011/b0654b8f/attachment.htm>

From notifications at github.com  Mon Oct 11 21:05:02 2021
From: notifications at github.com (UX-P)
Date: Mon, 11 Oct 2021 12:05:02 -0700
Subject: [bisq-network/proposals] New role request- User Researcher (#344)
In-Reply-To: <bisq-network/proposals/issues/344@github.com>
References: <bisq-network/proposals/issues/344@github.com>
Message-ID: <bisq-network/proposals/issues/344/940368063@github.com>

@m52go  Thank you for your encouraging feedback. I will definitely take this on board and apply my strategy to specific projects and share the outcome with the appropriate teams. 


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/proposals/issues/344#issuecomment-940368063
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211011/7e2929a0/attachment.htm>

From notifications at github.com  Mon Oct 11 21:08:47 2021
From: notifications at github.com (jmacxx)
Date: Mon, 11 Oct 2021 12:08:47 -0700
Subject: [bisq-network/bisq] Allow standard mark & copy functionality for
 displayed text fields (#5747)
Message-ID: <bisq-network/bisq/pull/5747@github.com>

Instead of a &quot;Copy&quot; icon on every field, allow the text to be selected &amp; copied.  Replace `addConfirmationLabelLabel` with `addConfirmationLabelTextField`.

- Gives the ability to mark &amp; copy all text fields in Trade and Dispute tickets.
- Gives the ability to mark &amp; copy text from `TextFieldWithIcon`

Resolves https://github.com/bisq-network/bisq/discussions/5706

---

Screenshots:

![image](https://user-images.githubusercontent.com/47253594/136834731-c9bd4845-9399-4fdc-9ff9-2fd7d72844b7.png)

![image](https://user-images.githubusercontent.com/47253594/136834655-ac86c6db-a666-47dc-9872-038250bfcd6b.png)

![image](https://user-images.githubusercontent.com/47253594/136842402-6d9025af-90c9-474f-b57f-2250def5ea6c.png)

![image](https://user-images.githubusercontent.com/47253594/136834264-8bced81d-23d8-41ab-b1ef-e6c088c999cb.png)

You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/5747

-- Commit Summary --

  * <a href="https://github.com/bisq-network/bisq/pull/5747/commits/26028dfad538bfccbc595beb824efceb697536f9">Allow standard mark &amp; copy functionality for displayed text fields</a>

-- File Changes --

    M desktop/src/main/java/bisq/desktop/components/TextFieldWithIcon.java (5)
    M desktop/src/main/java/bisq/desktop/main/overlays/windows/ContractWindow.java (56)
    M desktop/src/main/java/bisq/desktop/main/overlays/windows/DisputeSummaryWindow.java (16)
    M desktop/src/main/java/bisq/desktop/main/overlays/windows/TradeDetailsWindow.java (41)
    M desktop/src/main/java/bisq/desktop/util/FormBuilder.java (28)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/5747.patch
https://github.com/bisq-network/bisq/pull/5747.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5747
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211011/f2784814/attachment.htm>

From notifications at github.com  Mon Oct 11 21:10:00 2021
From: notifications at github.com (jmacxx)
Date: Mon, 11 Oct 2021 12:10:00 -0700
Subject: [bisq-network/bisq] Add mark and copy functionality of 2 missing
 fields in the BSQ section (Discussion #5706)
In-Reply-To: <bisq-network/bisq/repo-discussions/5706@github.com>
References: <bisq-network/bisq/repo-discussions/5706@github.com>
Message-ID: <bisq-network/bisq/repo-discussions/5706/comments/1460837@github.com>

Fixed with https://github.com/bisq-network/bisq/pull/5747

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/discussions/5706#discussioncomment-1460837
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211011/86d3af82/attachment-0001.htm>

From notifications at github.com  Mon Oct 11 21:21:00 2021
From: notifications at github.com (jmacxx)
Date: Mon, 11 Oct 2021 12:21:00 -0700
Subject: [bisq-network/bisq] Fix issue of Trade Step 1 validation done too
 soon (#5746)
In-Reply-To: <bisq-network/bisq/pull/5746@github.com>
References: <bisq-network/bisq/pull/5746@github.com>
Message-ID: <bisq-network/bisq/pull/5746/push/8130784541@github.com>

@jmacxx pushed 1 commit.

56b3f3fae1dade4305fed2e336ebf524683001e8  Check for invalid tx chain only after deposit published


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/bisq-network/bisq/pull/5746/files/9ab659ceac8993f50eb4c83f338d6345e7f417e4..56b3f3fae1dade4305fed2e336ebf524683001e8
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211011/ec3df394/attachment.htm>

From notifications at github.com  Mon Oct 11 22:51:37 2021
From: notifications at github.com (chimp1984)
Date: Mon, 11 Oct 2021 13:51:37 -0700
Subject: [bisq-network/bisq] Fix issue of Trade Step 1 validation done too
 soon (#5746)
In-Reply-To: <bisq-network/bisq/pull/5746@github.com>
References: <bisq-network/bisq/pull/5746@github.com>
Message-ID: <bisq-network/bisq/pull/5746/review/776653135@github.com>

@chimp1984 approved this pull request.

utACK



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5746#pullrequestreview-776653135
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211011/7e600fa6/attachment.htm>

From notifications at github.com  Tue Oct 12 00:40:34 2021
From: notifications at github.com (jmacxx)
Date: Mon, 11 Oct 2021 15:40:34 -0700
Subject: [bisq-network/bisq] Fix logic of SEPA country comparison routine
 (#5748)
Message-ID: <bisq-network/bisq/pull/5748@github.com>

Minor bugfix: there is logic to display `All Euro countries` in place of listing out all 23 country codes (see screeshots below).  This was broken because the comparison routine was comparing the lists out of order.

---
Account details:
![image](https://user-images.githubusercontent.com/47253594/136862726-33c48658-cb54-45c2-ae3a-9ef67d3f258c.png)

Dispute details:
![image](https://user-images.githubusercontent.com/47253594/136862762-ef8d5f3c-935c-4661-ae27-0bdc03c2a8dc.png)


You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/5748

-- Commit Summary --

  * <a href="https://github.com/bisq-network/bisq/pull/5748/commits/9f95aa360712e1dc605522e8a59ef2384e08d67c">Fix logic of SEPA country comparison routine</a>

-- File Changes --

    M core/src/main/java/bisq/core/locale/CountryUtil.java (3)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/5748.patch
https://github.com/bisq-network/bisq/pull/5748.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5748
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211011/99e7a452/attachment.htm>

From notifications at github.com  Tue Oct 12 10:01:17 2021
From: notifications at github.com (Christoph Atteneder)
Date: Tue, 12 Oct 2021 01:01:17 -0700
Subject: [bisq-network/bisq] Fix issue of Trade Step 1 validation done too
 soon (#5746)
In-Reply-To: <bisq-network/bisq/pull/5746@github.com>
References: <bisq-network/bisq/pull/5746@github.com>
Message-ID: <bisq-network/bisq/pull/5746/review/777013262@github.com>

@ripcurlx approved this pull request.

utACK based on https://github.com/bisq-network/bisq/pull/5746#pullrequestreview-776653135



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5746#pullrequestreview-777013262
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211012/ed874c64/attachment.htm>

From notifications at github.com  Tue Oct 12 10:02:49 2021
From: notifications at github.com (Christoph Atteneder)
Date: Tue, 12 Oct 2021 01:02:49 -0700
Subject: [bisq-network/bisq] Fix issue of Trade Step 1 validation done too
 soon (#5746)
In-Reply-To: <bisq-network/bisq/pull/5746@github.com>
References: <bisq-network/bisq/pull/5746@github.com>
Message-ID: <bisq-network/bisq/pull/5746/issue_event/5447685606@github.com>

Merged #5746 into master.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5746#event-5447685606
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211012/3f24d0ec/attachment.htm>

From notifications at github.com  Tue Oct 12 10:05:00 2021
From: notifications at github.com (Christoph Atteneder)
Date: Tue, 12 Oct 2021 01:05:00 -0700
Subject: [bisq-network/bisq] Fix logic of SEPA country comparison routine
 (#5748)
In-Reply-To: <bisq-network/bisq/pull/5748@github.com>
References: <bisq-network/bisq/pull/5748@github.com>
Message-ID: <bisq-network/bisq/pull/5748/review/777017349@github.com>

@ripcurlx approved this pull request.

utACK



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5748#pullrequestreview-777017349
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211012/d263b383/attachment-0001.htm>

From notifications at github.com  Tue Oct 12 10:05:14 2021
From: notifications at github.com (Christoph Atteneder)
Date: Tue, 12 Oct 2021 01:05:14 -0700
Subject: [bisq-network/bisq] Fix logic of SEPA country comparison routine
 (#5748)
In-Reply-To: <bisq-network/bisq/pull/5748@github.com>
References: <bisq-network/bisq/pull/5748@github.com>
Message-ID: <bisq-network/bisq/pull/5748/issue_event/5447699022@github.com>

Merged #5748 into master.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5748#event-5447699022
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211012/f4e5c871/attachment.htm>

From notifications at github.com  Tue Oct 12 10:29:16 2021
From: notifications at github.com (Christoph Atteneder)
Date: Tue, 12 Oct 2021 01:29:16 -0700
Subject: [bisq-network/bisq] Allow standard mark & copy functionality for
 displayed text fields (#5747)
In-Reply-To: <bisq-network/bisq/pull/5747@github.com>
References: <bisq-network/bisq/pull/5747@github.com>
Message-ID: <bisq-network/bisq/pull/5747/push/8134557456@github.com>

@ripcurlx pushed 1 commit.

d23823495725b79e2a4b464daba0aa31559fd383  Fix wrong logger setup


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/bisq-network/bisq/pull/5747/files/26028dfad538bfccbc595beb824efceb697536f9..d23823495725b79e2a4b464daba0aa31559fd383
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211012/93cd9288/attachment.htm>

From notifications at github.com  Tue Oct 12 10:29:19 2021
From: notifications at github.com (Christoph Atteneder)
Date: Tue, 12 Oct 2021 01:29:19 -0700
Subject: [bisq-network/bisq] Allow standard mark & copy functionality for
 displayed text fields (#5747)
In-Reply-To: <bisq-network/bisq/pull/5747@github.com>
References: <bisq-network/bisq/pull/5747@github.com>
Message-ID: <bisq-network/bisq/pull/5747/c940785548@github.com>

I do agree that it is better to stick to common expected UI features compared to adding more copy icons to do such task.
For completeness this also affects the state string in step 3 on buyer side.
![Bildschirmfoto 2021-10-12 um 10 25 38](https://user-images.githubusercontent.com/170962/136920214-18b53526-b78e-40ad-9c9d-187d2b2368fb.png)

I've pushed one little logger fix as well, that was introduced by mistake and popped up while searching for references.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5747#issuecomment-940785548
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211012/5aed35cd/attachment.htm>

From notifications at github.com  Tue Oct 12 10:29:51 2021
From: notifications at github.com (Christoph Atteneder)
Date: Tue, 12 Oct 2021 01:29:51 -0700
Subject: [bisq-network/bisq] Allow standard mark & copy functionality for
 displayed text fields (#5747)
In-Reply-To: <bisq-network/bisq/pull/5747@github.com>
References: <bisq-network/bisq/pull/5747@github.com>
Message-ID: <bisq-network/bisq/pull/5747/review/777044592@github.com>

@ripcurlx approved this pull request.

ACK



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5747#pullrequestreview-777044592
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211012/883bc56e/attachment.htm>

From notifications at github.com  Tue Oct 12 10:47:44 2021
From: notifications at github.com (Christoph Atteneder)
Date: Tue, 12 Oct 2021 01:47:44 -0700
Subject: [bisq-network/bisq] Allow standard mark & copy functionality for
 displayed text fields (#5747)
In-Reply-To: <bisq-network/bisq/pull/5747@github.com>
References: <bisq-network/bisq/pull/5747@github.com>
Message-ID: <bisq-network/bisq/pull/5747/issue_event/5447961980@github.com>

Merged #5747 into master.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5747#event-5447961980
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211012/1658ddf6/attachment.htm>

From notifications at github.com  Tue Oct 12 16:38:49 2021
From: notifications at github.com (unofficial bisq contributor)
Date: Tue, 12 Oct 2021 07:38:49 -0700
Subject: [bisq-network/bisq] MempoolFeeRateProvider should use onion for api
 query (#5749)
Message-ID: <bisq-network/bisq/issues/5749@github.com>

<!--
   SUPPORT REQUESTS: This is for reporting bugs in the Bisq app.
   If you have a support request, please join #support on Bisq's
   Keybase team over at https://keybase.io/team/Bisq
-->

### Description
We have secure onion communication built inside, so don't leave the tor network and put load on exit nodes where possible



#### Version

<!-- commit id or version number -->

### Steps to reproduce

<!--if you can reliably reproduce the bug, list the steps here  -->

### Expected behaviour
The fee estimation should use http://mempoolhqx4isw62xs7abwphsq7ldayuidyx2v2oethdhhj6mlo2r6ad.onion/api/v1/fees/recommended as recommended by code example of http://mempoolhqx4isw62xs7abwphsq7ldayuidyx2v2oethdhhj6mlo2r6ad.onion/api


### Actual behaviour

 instead of https://" + "mempool.space" + "/api/v1/fees/recommended


### Screenshots

<!--Screenshots if gui related, drag and drop to add to the issue -->

#### Device or machine

<!-- device/machine used, operating system -->



#### Additional info

<!-- Additional information useful for debugging (e.g. logs) -->


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5749
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211012/2cbd04ff/attachment.htm>

From notifications at github.com  Tue Oct 12 16:44:43 2021
From: notifications at github.com (unofficial bisq contributor)
Date: Tue, 12 Oct 2021 07:44:43 -0700
Subject: [bisq-network/bisq] replace mempool.space with
 mempoolhqx4isw62xs7abwphsq7ldayuidyx2v2oethdhhj6mlo2r6ad.onion (#5750)
Message-ID: <bisq-network/bisq/pull/5750@github.com>

make use of mempoolhqx4isw62xs7abwphsq7ldayuidyx2v2oethdhhj6mlo2r6ad.onion api http://mempoolhqx4isw62xs7abwphsq7ldayuidyx2v2oethdhhj6mlo2r6ad.onion/api/v1/fees/recommended 

Fixes #5749 
reference #27

You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/5750

-- Commit Summary --

  * <a href="https://github.com/bisq-network/bisq/pull/5750/commits/ab35792854cd2cc983201cc0b8f3975571484e93">replace mempool.space with mempoolhqx4isw62xs7abwphsq7ldayuidyx2v2oethdhhj6mlo2r6ad.onion</a>

-- File Changes --

    M pricenode/src/main/java/bisq/price/mining/providers/MempoolFeeRateProvider.java (8)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/5750.patch
https://github.com/bisq-network/bisq/pull/5750.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5750
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211012/148d40b0/attachment.htm>

From notifications at github.com  Tue Oct 12 17:27:40 2021
From: notifications at github.com (jmacxx)
Date: Tue, 12 Oct 2021 08:27:40 -0700
Subject: [bisq-network/bisq] MempoolFeeRateProvider should use onion for
 api query (#5749)
In-Reply-To: <bisq-network/bisq/issues/5749@github.com>
References: <bisq-network/bisq/issues/5749@github.com>
Message-ID: <bisq-network/bisq/issues/5749/941120335@github.com>

That code is the PriceNode.  PriceNode connects to 4 mempool.space providers, via clearnet, intentionally.  
I don't see any benefit for the PriceNode to obtain its fee information using the Tor network.
It also obtains its market price information over clearnet.


However,

- The Bisq client obtains fee information from a PriceNode via Tor.
- The Bisq client obtains price information from a PriceNode via Tor.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5749#issuecomment-941120335
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211012/54d4979d/attachment.htm>

From notifications at github.com  Tue Oct 12 17:28:45 2021
From: notifications at github.com (jmacxx)
Date: Tue, 12 Oct 2021 08:28:45 -0700
Subject: [bisq-network/bisq] replace mempool.space with
 mempoolhqx4isw62xs7abwphsq7ldayuidyx2v2oethdhhj6mlo2r6ad.onion (#5750)
In-Reply-To: <bisq-network/bisq/pull/5750@github.com>
References: <bisq-network/bisq/pull/5750@github.com>
Message-ID: <bisq-network/bisq/pull/5750/review/777542774@github.com>

@jmacxx commented on this pull request.

NACK per https://github.com/bisq-network/bisq/issues/5749#issuecomment-941120335



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5750#pullrequestreview-777542774
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211012/0efe1390/attachment.htm>

From notifications at github.com  Tue Oct 12 18:18:14 2021
From: notifications at github.com (slipperybeluga)
Date: Tue, 12 Oct 2021 09:18:14 -0700
Subject: [bisq-network/bisq] Exception message: Not able to find peers
 witness, unable to sign for trade (#5744)
In-Reply-To: <bisq-network/bisq/issues/5744@github.com>
References: <bisq-network/bisq/issues/5744@github.com>
Message-ID: <bisq-network/bisq/issues/5744/941164607@github.com>

> > While I am unable to click the "confirm payment receipt" button to close the transaction, both parties have received their deposits back and the buyer has gotten their BTC. The transaction still appears open in Bisq.
> 
> The trade has completed but still shows up in your open trades list.
> 
> The following advice involves clearing the data structure which keeps track of open trades. This is only applicable in extreme circumstances when the normal flow of operations did not happen, as is the case here. As always, [make a backup](https://bisq.wiki/Backing_up_application_data) first.
> 
> [Prerequisite: you must have no other open trades, as all current open trades will be removed. If you have other open trades, do not continue until they have all completed].
> 
> To remove the open trades, close down Bisq then delete the file `PendingTrades` file from the `db` folder within the [data directory](https://bisq.wiki/Data_directory).

Deletion of PendingTrades db file has resolved the issue. Thank you. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5744#issuecomment-941164607
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211012/ab52f5a4/attachment-0001.htm>

From notifications at github.com  Tue Oct 12 18:18:15 2021
From: notifications at github.com (slipperybeluga)
Date: Tue, 12 Oct 2021 09:18:15 -0700
Subject: [bisq-network/bisq] Exception message: Not able to find peers
 witness, unable to sign for trade (#5744)
In-Reply-To: <bisq-network/bisq/issues/5744@github.com>
References: <bisq-network/bisq/issues/5744@github.com>
Message-ID: <bisq-network/bisq/issue/5744/issue_event/5450755988@github.com>

Closed #5744.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5744#event-5450755988
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211012/1cced5dd/attachment.htm>

From notifications at github.com  Tue Oct 12 20:45:59 2021
From: notifications at github.com (rumil2)
Date: Tue, 12 Oct 2021 11:45:59 -0700
Subject: [bisq-network/bisq] Failed trade (#5751)
Message-ID: <bisq-network/bisq/issues/5751@github.com>

I would label this thread better, but I am pretty ignorant about guidelines.
<!--
   SUPPORT REQUESTS: This is for reporting bugs in the Bisq app.
   If you have a support request, please join #support on Bisq's
   Keybase team over at https://keybase.io/team/Bisq
-->

### Description

Went to buy BTC, timed out after 60 seconds and gave me an error message.

#### Version

1.7.4

### Steps to reproduce

n/a

### Expected behaviour

I wanted to buy bitcoin.

### Actual behaviour

timed out, bisq failed, no bitcoin happened.

### Screenshots

![Untitled](https://user-images.githubusercontent.com/92396757/137011497-0e666fef-89c1-461d-825b-40e8b68aafcf.png)
![Untitled2](https://user-images.githubusercontent.com/92396757/137011505-7cad7686-ef7d-4372-98e0-8502f35a1d9d.png)

#### Device or machine

desktop, Windows 10



#### Additional info

[bisq.log](https://github.com/bisq-network/bisq/files/7332467/bisq.log)



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5751
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211012/94b2eab0/attachment.htm>

From notifications at github.com  Tue Oct 12 20:46:01 2021
From: notifications at github.com (boring-cyborg[bot])
Date: Tue, 12 Oct 2021 11:46:01 -0700
Subject: [bisq-network/bisq] Failed trade (#5751)
In-Reply-To: <bisq-network/bisq/issues/5751@github.com>
References: <bisq-network/bisq/issues/5751@github.com>
Message-ID: <bisq-network/bisq/issues/5751/941286262@github.com>

**Thanks for opening your first issue here!**<br/><br/>Be sure to follow the issue template. Your issue will be reviewed by a maintainer and labeled for further action.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5751#issuecomment-941286262
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211012/8d91aa99/attachment.htm>

From notifications at github.com  Tue Oct 12 21:10:34 2021
From: notifications at github.com (rumil2)
Date: Tue, 12 Oct 2021 12:10:34 -0700
Subject: [bisq-network/support] Fee reimbursement for trade sb3vly (#1011)
Message-ID: <bisq-network/support/issues/1011@github.com>

>_The XXXXX part in the issue title are the first characters of the Trade ID before the "-" (dash)._

![Untitled3](https://user-images.githubusercontent.com/92396757/137014721-079cacf4-1da1-4b66-95a8-92e531370ad7.png)

>_The screenshot from the Bisq client must have the **Trade ID**, **Deposit**, **Maker** and **Taker** TXIDs visible. Of course some trades do not have all 3 types, that is ok. Make sure all private information is covered (like bank accounts, name, etc). **Do not upload images where sensitive private data is visible!**_

Maker:  f1d7cbcd372f19cb3267e9ceb88c1e088a77f1c65e65b64b5d6bc397ad097d25
Taker: ...........
Deposit: ..........

>_A reimbursement request has to contain textual representation of **Maker**, **Taker** and **Deposit** TXIDs (copy them from the client to the issue). **All TXIDs that are visible in the screenshot must be copied to the issue in text form! Please use exact form for Maker/Taker/Deposit - no abbreviations like M:, T: or adding extra characters like "Maker TX:", etc. Leave those fields as they are and replace the "........" with the appropreate txid**_

Bisq version: 1.7.4
BTC address for reimbursement: https://mempool.space/address/bc1qpmea6hhkw83lhy6z4cm776hyq0g5jg6pnyau5f

>_Provide the Bisq client version to help developers identify the causing issue._

Other notes:

>_Issue [#197](https://github.com/bisq-network/support/issues/197) can be used as a good example of a correct reimbursement request._


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/support/issues/1011
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211012/5336e248/attachment.htm>

From notifications at github.com  Tue Oct 12 22:28:27 2021
From: notifications at github.com (jmacxx)
Date: Tue, 12 Oct 2021 13:28:27 -0700
Subject: [bisq-network/bisq] Add payment methods Strike and Verse (#5752)
Message-ID: <bisq-network/bisq/pull/5752@github.com>

Fixes https://github.com/bisq-network/growth/issues/220
Fixes https://github.com/bisq-network/growth/issues/223


---

&lt;details&gt;
  &lt;summary&gt;Screenshots for Strike&lt;/summary&gt;

![strike_account](https://user-images.githubusercontent.com/47253594/137018626-b08737e7-cf64-4baf-a630-977f54fb464a.png)
![strike_buyer_popup](https://user-images.githubusercontent.com/47253594/137018637-1051173f-6737-475b-a2ee-61a63301c06c.png)
![strike_buy_offer](https://user-images.githubusercontent.com/47253594/137018640-0ba12899-1d40-4af5-9ed5-37be647ed2f5.png)
![strike_sell_popup](https://user-images.githubusercontent.com/47253594/137018646-127f8f2a-d586-44a7-b8ad-c6e3277ef87b.png)
![strike_sell](https://user-images.githubusercontent.com/47253594/137018670-849840f5-a02a-4f18-a119-e1a327498946.png)
![strike_start_payment](https://user-images.githubusercontent.com/47253594/137018688-24de352c-f405-4d58-ae85-199ffb05566a.png)
![strike_confirm_payment](https://user-images.githubusercontent.com/47253594/137018720-88386ae4-592e-4530-9e64-dfbf5f162d82.png)

&lt;/details&gt;

---

&lt;details&gt;
  &lt;summary&gt;Screenshots for Verse&lt;/summary&gt;

![verse_account_popup](https://user-images.githubusercontent.com/47253594/137018763-95bc6b23-de92-4851-8f4e-f16a17164634.png)
![verse_account](https://user-images.githubusercontent.com/47253594/137018767-b073e7e6-cf8d-4c63-8a06-6024a955fba0.png)
![verse_sell_popup](https://user-images.githubusercontent.com/47253594/137018788-681abb75-66f4-4194-a166-51b8ea312c00.png)
![verse_sell_offer](https://user-images.githubusercontent.com/47253594/137018795-e5a144ab-80fa-46c0-848e-0fa7914364b3.png)
![verse_buy_popup](https://user-images.githubusercontent.com/47253594/137018805-41c518a7-f03c-4220-9f5e-59fb7ca14515.png)
![verse_buy_takeoffer](https://user-images.githubusercontent.com/47253594/137018816-a8036aab-656a-40f9-9c46-5c14aef6026d.png)
![verse_start_payment](https://user-images.githubusercontent.com/47253594/137018830-d518e1b4-6d88-44e9-9b29-6e3f277b8e05.png)
![verse_confirm_payment](https://user-images.githubusercontent.com/47253594/137018837-bb7ff59d-b116-4f1e-8249-a135beb2237f.png)

&lt;/details&gt;


You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/5752

-- Commit Summary --

  * <a href="https://github.com/bisq-network/bisq/pull/5752/commits/b72b70ee8cb301a87d37053c915f698c5629971e">Add payment methods Strike and Verse</a>

-- File Changes --

    M core/src/main/java/bisq/core/locale/CurrencyUtil.java (11)
    M core/src/main/java/bisq/core/payment/PaymentAccountFactory.java (4)
    A core/src/main/java/bisq/core/payment/StrikeAccount.java (56)
    A core/src/main/java/bisq/core/payment/VerseAccount.java (56)
    M core/src/main/java/bisq/core/payment/payload/PaymentMethod.java (6)
    A core/src/main/java/bisq/core/payment/payload/StrikeAccountPayload.java (99)
    A core/src/main/java/bisq/core/payment/payload/VerseAccountPayload.java (89)
    M core/src/main/java/bisq/core/proto/CoreProtoResolver.java (6)
    M core/src/main/java/bisq/core/trade/statistics/TradeStatistics3.java (4)
    M core/src/main/resources/i18n/displayStrings.properties (41)
    A desktop/src/main/java/bisq/desktop/components/paymentmethods/StrikeForm.java (106)
    A desktop/src/main/java/bisq/desktop/components/paymentmethods/VerseForm.java (116)
    M desktop/src/main/java/bisq/desktop/main/account/content/fiataccounts/FiatAccountsView.java (6)
    M desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/steps/buyer/BuyerStep2View.java (8)
    M proto/src/main/proto/pb.proto (10)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/5752.patch
https://github.com/bisq-network/bisq/pull/5752.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5752
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211012/0b9c9fb8/attachment-0001.htm>

From notifications at github.com  Wed Oct 13 09:41:32 2021
From: notifications at github.com (Christoph Atteneder)
Date: Wed, 13 Oct 2021 00:41:32 -0700
Subject: [bisq-network/growth] Add Verse as a payment method (popular
 European payment app) (#223)
In-Reply-To: <bisq-network/growth/issues/223@github.com>
References: <bisq-network/growth/issues/223@github.com>
Message-ID: <bisq-network/growth/issue/223/issue_event/5455125793@github.com>

Closed #223 via bisq-network/bisq#5752.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/growth/issues/223#event-5455125793
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211013/909efeb4/attachment.htm>

From notifications at github.com  Wed Oct 13 09:41:32 2021
From: notifications at github.com (Christoph Atteneder)
Date: Wed, 13 Oct 2021 00:41:32 -0700
Subject: [bisq-network/growth] Add Strike App as a new payment method
 (#220)
In-Reply-To: <bisq-network/growth/issues/220@github.com>
References: <bisq-network/growth/issues/220@github.com>
Message-ID: <bisq-network/growth/issue/220/issue_event/5455125783@github.com>

Closed #220 via bisq-network/bisq#5752.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/growth/issues/220#event-5455125783
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211013/4a25851c/attachment.htm>

From notifications at github.com  Wed Oct 13 09:41:35 2021
From: notifications at github.com (Christoph Atteneder)
Date: Wed, 13 Oct 2021 00:41:35 -0700
Subject: [bisq-network/bisq] Add payment methods Strike and Verse (#5752)
In-Reply-To: <bisq-network/bisq/pull/5752@github.com>
References: <bisq-network/bisq/pull/5752@github.com>
Message-ID: <bisq-network/bisq/pull/5752/review/778202161@github.com>

@ripcurlx approved this pull request.

utACK



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5752#pullrequestreview-778202161
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211013/1fdd6274/attachment.htm>

From notifications at github.com  Wed Oct 13 09:41:47 2021
From: notifications at github.com (Christoph Atteneder)
Date: Wed, 13 Oct 2021 00:41:47 -0700
Subject: [bisq-network/bisq] Add payment methods Strike and Verse (#5752)
In-Reply-To: <bisq-network/bisq/pull/5752@github.com>
References: <bisq-network/bisq/pull/5752@github.com>
Message-ID: <bisq-network/bisq/pull/5752/issue_event/5455125771@github.com>

Merged #5752 into master.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5752#event-5455125771
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211013/d65d574e/attachment.htm>

From notifications at github.com  Wed Oct 13 09:43:45 2021
From: notifications at github.com (Christoph Atteneder)
Date: Wed, 13 Oct 2021 00:43:45 -0700
Subject: [bisq-network/bisq] replace mempool.space with
 mempoolhqx4isw62xs7abwphsq7ldayuidyx2v2oethdhhj6mlo2r6ad.onion (#5750)
In-Reply-To: <bisq-network/bisq/pull/5750@github.com>
References: <bisq-network/bisq/pull/5750@github.com>
Message-ID: <bisq-network/bisq/pull/5750/c942019881@github.com>

Closing PR based on https://github.com/bisq-network/bisq/pull/5750#pullrequestreview-777542774

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5750#issuecomment-942019881
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211013/5e94cda1/attachment.htm>

From notifications at github.com  Wed Oct 13 09:43:46 2021
From: notifications at github.com (Christoph Atteneder)
Date: Wed, 13 Oct 2021 00:43:46 -0700
Subject: [bisq-network/bisq] replace mempool.space with
 mempoolhqx4isw62xs7abwphsq7ldayuidyx2v2oethdhhj6mlo2r6ad.onion (#5750)
In-Reply-To: <bisq-network/bisq/pull/5750@github.com>
References: <bisq-network/bisq/pull/5750@github.com>
Message-ID: <bisq-network/bisq/pull/5750/issue_event/5455137029@github.com>

Closed #5750.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5750#event-5455137029
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211013/e2ef3601/attachment.htm>

From notifications at github.com  Wed Oct 13 11:47:35 2021
From: notifications at github.com (Christoph Atteneder)
Date: Wed, 13 Oct 2021 02:47:35 -0700
Subject: [bisq-network/bisq] Add "Buy BSQ" button next to trade fee
 selector (#5055)
In-Reply-To: <bisq-network/bisq/pull/5055@github.com>
References: <bisq-network/bisq/pull/5055@github.com>
Message-ID: <bisq-network/bisq/pull/5055/c942122870@github.com>

The current process is now as follows for no-BSQ-coiner.
Someone wants to buy BTC via Revolut
![Bildschirmfoto 2021-10-13 um 11 24 31](https://user-images.githubusercontent.com/170962/137107473-30235bdd-ceb7-41dd-adc5-d88568be0273.png)
She decides she want to save money and support the project and clicks on Buy BSQ
![Bildschirmfoto 2021-10-13 um 11 24 37](https://user-images.githubusercontent.com/170962/137107648-dd3d4a88-2603-4812-bb4f-75a787b11ef3.png)
She clicks on `Take offer to buy BSQ`
![Bildschirmfoto 2021-10-13 um 11 30 08](https://user-images.githubusercontent.com/170962/137107778-a3c89b16-6987-4f15-a141-c2b390a084d6.png)
She clicks on `Create Account` (Account is created and the offer is taken and opens the take offer screen). Probably it should be named `Create Account and Take Offer`. Also there shouldn't be a `Buy BSQ` hint when the user tries to buy BSQ.
She proceeds with purchasing BSQ
![Bildschirmfoto 2021-10-13 um 11 30 23](https://user-images.githubusercontent.com/170962/137107864-3aed24db-7e6b-4f8c-a5c7-fa4961c030fc.png)
When needing to confirm the BSQ transfer there is now the `Show Payment in BSQ Wallet` Button to open the BSQ wallet. Further optimization is not necessary as BSQ <>BTC atomic swap offers will be available soon.
![Bildschirmfoto 2021-10-13 um 11 32 06](https://user-images.githubusercontent.com/170962/137108584-366083d2-969b-4919-80a5-1917a1ded3e4.png)
![Bildschirmfoto 2021-10-13 um 11 32 36](https://user-images.githubusercontent.com/170962/137108854-d864b3f0-14ed-4865-b61e-bb8bf3fd7e03.png)
After completing the trade she can select BSQ in the offer creation process. (ATM the BSQ Button is not gone as it is not updated live)
![Bildschirmfoto 2021-10-13 um 11 32 51](https://user-images.githubusercontent.com/170962/137108916-ca1ab91f-b6c3-449e-8f4a-08ae330c051d.png)

@pazza83 @Conza88 

so IMO following points are still open to make this PR mergable:

- [ ] Don't show `Buy BSQ` hint when trying to buy BSQ.
- [ ] BSQ Button has to be updated live (on view activation) so it is not displayed anymore after successful BSQ purchase
- [ ] The Combobox UI glitch mentioned in https://github.com/bisq-network/bisq/pull/5055#issuecomment-931183094



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5055#issuecomment-942122870
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211013/c858ad07/attachment-0001.htm>

From notifications at github.com  Wed Oct 13 12:35:14 2021
From: notifications at github.com (Christoph Atteneder)
Date: Wed, 13 Oct 2021 03:35:14 -0700
Subject: [bisq-network/bisq] Add "Buy BSQ" button next to trade fee
 selector (#5055)
In-Reply-To: <bisq-network/bisq/pull/5055@github.com>
References: <bisq-network/bisq/pull/5055@github.com>
Message-ID: <bisq-network/bisq/pull/5055/push/8144876918@github.com>

@ripcurlx pushed 3 commits.

d2e76a15a561e6288a79928a42359034de84229e  Refactor account name generation
67b3f58a4940ccf28beb06a8f85669cf269fffec  Simplify and clean up data models
ee0ce1065a31f2f66d77f2dee3a08c42e7ede0b9  Create BSQ account and take offer if not existing


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/bisq-network/bisq/pull/5055/files/85e0bf46830688f1ff4a207bad4e23276a62b876..ee0ce1065a31f2f66d77f2dee3a08c42e7ede0b9
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211013/4ebdd833/attachment.htm>

From notifications at github.com  Wed Oct 13 12:36:31 2021
From: notifications at github.com (Christoph Atteneder)
Date: Wed, 13 Oct 2021 03:36:31 -0700
Subject: [bisq-network/bisq] Add "Buy BSQ" button next to trade fee
 selector (#5055)
In-Reply-To: <bisq-network/bisq/pull/5055@github.com>
References: <bisq-network/bisq/pull/5055@github.com>
Message-ID: <bisq-network/bisq/pull/5055/c942163176@github.com>

I fixed the remaining issues except the Combobox UI glitch which I'll attend soon. @m52go Would be great to get also feedback on the wording of the newly introduced strings. Thanks!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5055#issuecomment-942163176
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211013/25ee6a39/attachment.htm>

From notifications at github.com  Wed Oct 13 12:48:01 2021
From: notifications at github.com (Christoph Atteneder)
Date: Wed, 13 Oct 2021 03:48:01 -0700
Subject: [bisq-network/bisq] Add "Buy BSQ" button next to trade fee
 selector (#5055)
In-Reply-To: <bisq-network/bisq/pull/5055@github.com>
References: <bisq-network/bisq/pull/5055@github.com>
Message-ID: <bisq-network/bisq/pull/5055/push/8144966570@github.com>

@ripcurlx pushed 1 commit.

5ec04afa1b409492fa6286851bb59486bb10d8ed  Fix failing tests


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/bisq-network/bisq/pull/5055/files/ee0ce1065a31f2f66d77f2dee3a08c42e7ede0b9..5ec04afa1b409492fa6286851bb59486bb10d8ed
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211013/49550719/attachment.htm>

From notifications at github.com  Wed Oct 13 17:36:50 2021
From: notifications at github.com (jmacxx)
Date: Wed, 13 Oct 2021 08:36:50 -0700
Subject: [bisq-network/bisq] Failed trade (#5751)
In-Reply-To: <bisq-network/bisq/issues/5751@github.com>
References: <bisq-network/bisq/issues/5751@github.com>
Message-ID: <bisq-network/bisq/issues/5751/942427953@github.com>

Hi @rumil2.  As Bisq is a P2P trading system, the two parties need to agree on the parameters of the trade.

In this case they could not come to an agreement on the current BTC market price.  The maker said 58861; the taker said 58176.  Since they were more than 1% different the maker aborted the trade, and the taker timed out.  Price differences can happen due to each peer checking individually.

Such is the difficult reality of distributed P2P trading.  It can be messy.

No funds left your wallet, and it should be ok to try again.

I noted down this problem in our [todo list](https://github.com/bisq-network/bisq/discussions/5668) of issues to try and improve.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5751#issuecomment-942427953
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211013/4ba4bd71/attachment.htm>

From notifications at github.com  Wed Oct 13 19:23:01 2021
From: notifications at github.com (Blackjack)
Date: Wed, 13 Oct 2021 10:23:01 -0700
Subject: [bisq-network/bisq] Not possible to modify accepted countries 
 (#5692)
In-Reply-To: <bisq-network/bisq/issues/5692@github.com>
References: <bisq-network/bisq/issues/5692@github.com>
Message-ID: <bisq-network/bisq/issues/5692/942545998@github.com>

Any update on this @xyzmaker123 ?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5692#issuecomment-942545998
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211013/baca4103/attachment.htm>

From notifications at github.com  Wed Oct 13 19:32:28 2021
From: notifications at github.com (Raheel Govindji)
Date: Wed, 13 Oct 2021 10:32:28 -0700
Subject: [bisq-network/bisq] Bisq requesting permissions for keystrokes on
 all apps [osx catalina] (#3373)
In-Reply-To: <bisq-network/bisq/issues/3373@github.com>
References: <bisq-network/bisq/issues/3373@github.com>
Message-ID: <bisq-network/bisq/issues/3373/942554096@github.com>

I'm still getting this prompt and I am using version 1.7.4 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/3373#issuecomment-942554096
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211013/71fa6f44/attachment-0001.htm>

From notifications at github.com  Wed Oct 13 22:29:43 2021
From: notifications at github.com (teambitcoin)
Date: Wed, 13 Oct 2021 13:29:43 -0700
Subject: [bisq-network/bisq] BISQ 64bit 1.7.2 won't launch on windows 10
 (#5648)
In-Reply-To: <bisq-network/bisq/issues/5648@github.com>
References: <bisq-network/bisq/issues/5648@github.com>
Message-ID: <bisq-network/bisq/issues/5648/942695883@github.com>

Found a work around. Right click shortcut, select the "shortcut" tab,  drop down that says RUN: Normal size window 

Change that to RUN: Maximized. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5648#issuecomment-942695883
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211013/a3e23072/attachment.htm>

From notifications at github.com  Wed Oct 13 23:43:00 2021
From: notifications at github.com (jmacxx)
Date: Wed, 13 Oct 2021 14:43:00 -0700
Subject: [bisq-network/bisq] Fix exception in offer entry UI (#5753)
Message-ID: <bisq-network/bisq/pull/5753@github.com>

Fixes an exception in offer entry when fixed prices are used.

## Steps to reproduce issue:

First, select the option of fixed price:

![image](https://user-images.githubusercontent.com/47253594/137216068-b44c0941-232d-4877-a946-004db3a08a8a.png)

- Click on create offer to Buy.
- Select the Fixed Price option (per screenshot above).
- Close the enter offer dialog.  This saves the setting.
- Again, click on create offer to Buy.
- Enter 0.01 (for BTC amount), [TAB], 0, [TAB], 0, [TAB], [TAB].
- Exception error popup message is shown.

![image](https://user-images.githubusercontent.com/47253594/137216395-0b2638d7-5381-4863-960c-d9ac283d0704.png)



![image](https://user-images.githubusercontent.com/47253594/137215572-e539d2c9-165e-4f81-aefc-efc358b7b0a3.png)


You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/5753

-- Commit Summary --

  * <a href="https://github.com/bisq-network/bisq/pull/5753/commits/0bb103ee42091f708523aa2e02259ac27601920e">Fix exception in offer entry UI</a>

-- File Changes --

    M desktop/src/main/java/bisq/desktop/main/offer/MutableOfferViewModel.java (4)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/5753.patch
https://github.com/bisq-network/bisq/pull/5753.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5753
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211013/d76b5ec5/attachment.htm>

From notifications at github.com  Thu Oct 14 11:09:30 2021
From: notifications at github.com (rumil2)
Date: Thu, 14 Oct 2021 02:09:30 -0700
Subject: [bisq-network/bisq] Failed trade (#5751)
In-Reply-To: <bisq-network/bisq/issues/5751@github.com>
References: <bisq-network/bisq/issues/5751@github.com>
Message-ID: <bisq-network/bisq/issues/5751/943164900@github.com>

Thank you for the reply. 
That seems ridiculous, but it makes sense. If I had to make a thread like this every time such a thing happened, I think Bisq would be rendered unusable. This was the first time I ever attempted a trade and now I'm wary about the whole Bisq system.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5751#issuecomment-943164900
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211014/73c02428/attachment.htm>

From notifications at github.com  Thu Oct 14 20:04:02 2021
From: notifications at github.com (pazza)
Date: Thu, 14 Oct 2021 11:04:02 -0700
Subject: [bisq-network/support] Fee reimbursement for trade RPYSYF (#1010)
In-Reply-To: <bisq-network/support/issues/1010@github.com>
References: <bisq-network/support/issues/1010@github.com>
Message-ID: <bisq-network/support/issues/1010/943594471@github.com>

Hi I was the mediator for this trade and confirm I asked @jeforson to open reimbursement request for miner and trade fees 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/support/issues/1010#issuecomment-943594471
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211014/29903496/attachment.htm>

From notifications at github.com  Thu Oct 14 20:05:30 2021
From: notifications at github.com (boring-cyborg[bot])
Date: Thu, 14 Oct 2021 11:05:30 -0700
Subject: [bisq-network/bisq] Fee reimbursement for trade 23773143 - Fee
 Reimbursement  (#5754)
In-Reply-To: <bisq-network/bisq/issues/5754@github.com>
References: <bisq-network/bisq/issues/5754@github.com>
Message-ID: <bisq-network/bisq/issues/5754/943595430@github.com>

**Thanks for opening your first issue here!**<br/><br/>Be sure to follow the issue template. Your issue will be reviewed by a maintainer and labeled for further action.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5754#issuecomment-943595430
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211014/0e639d42/attachment.htm>

From notifications at github.com  Thu Oct 14 20:05:31 2021
From: notifications at github.com (A-Simon)
Date: Thu, 14 Oct 2021 11:05:31 -0700
Subject: [bisq-network/bisq] Fee reimbursement for trade 23773143 - Fee
 Reimbursement  (#5754)
Message-ID: <bisq-network/bisq/issues/5754@github.com>

Maker: 3968db85d14a1e98d6781233b1960d1a8263c64c94431f419ca6f1b4cff90098
Taker: N/A
Deposit: N/A

Bisq version: v1.7.4
BTC address for reimbursement: bc1qurt78pf637r69d8pke68kc7mumw0zn2lqkny0e

Other notes:

The trade protocol encountered some problems.
The trade contract is not set.

Received a failed trade error as soon as I funded my wallet. Attempted to move from failed trades back to active for mediation to receive deposit back but was unsuccessful. 

https://mempool.space/address/bc1qd2aqjvwhl3gzqnc49ee8g8jaj3j8tnewtr2g6qaefdz8sng448hsrj0xh8
https://mempool.space/tx/ec198d87377eedb53db3db11ff7297bbccb8ed1485961cb9f1d83cd8804ffd4b

I posted a week ago [here](https://github.com/bisq-network/support/issues/1009) - Original date of the trade was 9/28

Screenshots:

<img width="901" alt="Screen Shot 2021-09-28 at 5 56 49 PM" src="https://user-images.githubusercontent.com/46980254/137371399-2e1e31b7-709a-489b-9a62-ac160967d913.png">
<img width="826" alt="screenshot 2" src="https://user-images.githubusercontent.com/46980254/137371489-2264c74d-5476-4e51-8119-80b1636a8ce8.png">
<img width="814" alt="Screen Shot 2021-09-28 at 5 53 13 PM" src="https://user-images.githubusercontent.com/46980254/137371526-d1870f45-9ff6-4411-9964-a6d1ad15c508.png">




-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5754
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211014/738e653b/attachment.htm>

From notifications at github.com  Thu Oct 14 20:39:22 2021
From: notifications at github.com (Christoph Atteneder)
Date: Thu, 14 Oct 2021 11:39:22 -0700
Subject: [bisq-network/bisq] Fix exception in offer entry UI (#5753)
In-Reply-To: <bisq-network/bisq/pull/5753@github.com>
References: <bisq-network/bisq/pull/5753@github.com>
Message-ID: <bisq-network/bisq/pull/5753/review/780122206@github.com>

@ripcurlx approved this pull request.

utACK



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5753#pullrequestreview-780122206
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211014/a93bdc12/attachment.htm>

From notifications at github.com  Thu Oct 14 20:39:37 2021
From: notifications at github.com (Christoph Atteneder)
Date: Thu, 14 Oct 2021 11:39:37 -0700
Subject: [bisq-network/bisq] Fix exception in offer entry UI (#5753)
In-Reply-To: <bisq-network/bisq/pull/5753@github.com>
References: <bisq-network/bisq/pull/5753@github.com>
Message-ID: <bisq-network/bisq/pull/5753/issue_event/5465695305@github.com>

Merged #5753 into master.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5753#event-5465695305
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211014/87f73f6b/attachment.htm>

From notifications at github.com  Fri Oct 15 04:00:10 2021
From: notifications at github.com (rexi1e)
Date: Thu, 14 Oct 2021 19:00:10 -0700
Subject: [bisq-network/bisq] Use onchain trade protocol for offchain trading
 (Discussion #5756)
Message-ID: <bisq-network/bisq/repo-discussions/5756@github.com>

Bisq neds to move offchain, and some proposals are there i know.

I remember proposal from long time ago for bsq bonds and such, but if i recall those bonds were meant to serve as collateral for arbitrarily high trade amounts, which is why the idea failed to make it further.

But what if we use existing 2 of 2 protocol as base for offchain traddes between specific people? I am inspired by model of Lightning : do 1 on-chain tx to secure funds and create incentives for both people to hold up their side of deal over time. Bisq is already based on 2 of 2 multisig for security. But on bisq, instead of sending bitcoin through lightning to bypass blockchain, this could mean sending fiat/btc at specified intervals of time to bypass blockchain (e.g. sepa, zelle for fiat and lightning and liquid for btc). To take most advantage of this, should do bigger amounts over longer periods of time.

e.g.

Bob and Alice wanna trade 1 btc over 12 months. Bob is seller and Alice wants to buy. Assume there is new payment account type that is longer-term (perhaps defined in months) and that outlines a schedule of transactions (e.g. X btc every Y days). So Bob and Alice enter into a trade with these new payment accounts and open 2of2 multisig with 15% dep., so  0.15 btc each locked, and decide to exchange 0.042 btc every 2 weeks for 12 months. Bob sends btc over lightning and Alice pays with sepa.

[Mobile app like this](https://github.com/bisq-network/proposals/issues/342) would be super nice for reminders in this kind of senario.

I am not 100% sure of all details but it seems like the basic pieces are there to make this feasible.

Further thoughts:
- would be good to have some way to associate signed accounts to this new long-term payment method (e.g. SEPA --> SEPA Long-Term) so that users can benefit from the extra piece of mind provided by signing. Important if doing long-term trade relationship i think
- maybe it is better to have payment regime defined in fiat instead of btc; but not sure if this is avoidable since bisq trades are definedin btc
- thus ending the trade relationship needs more thoughts.
  - Closing trade channel after any of the mutual exchanges should be easy; but may need rules to disincentivze closing channels early in the relationship since it makes on-chain tx relatively expensive. 
  - Or Maybe there is some way to transfer obligation to another trusted trader (e.g. one with a signed account of same type)?

Dispute resolution also needs some thoughts. Im not sure if is possible to verify invoice generation and payments (?). Liquid could work for sure. Of course fiat side could be verified as usual.

I am long time user and really looking forard to seeing Bisq move ahead off the chain !!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/discussions/5756
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211014/a9eac159/attachment-0001.htm>

From notifications at github.com  Fri Oct 15 10:30:52 2021
From: notifications at github.com (Christoph Atteneder)
Date: Fri, 15 Oct 2021 01:30:52 -0700
Subject: [bisq-network/bisq] Add "Buy BSQ" button next to trade fee
 selector (#5055)
In-Reply-To: <bisq-network/bisq/pull/5055@github.com>
References: <bisq-network/bisq/pull/5055@github.com>
Message-ID: <bisq-network/bisq/pull/5055/c944105779@github.com>

- [ ] Add popup after account creation to improve UX for new users

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5055#issuecomment-944105779
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211015/23c41688/attachment.htm>

From notifications at github.com  Fri Oct 15 11:10:57 2021
From: notifications at github.com (Christoph Atteneder)
Date: Fri, 15 Oct 2021 02:10:57 -0700
Subject: [bisq-network/bisq] Add "Buy BSQ" button next to trade fee
 selector (#5055)
In-Reply-To: <bisq-network/bisq/pull/5055@github.com>
References: <bisq-network/bisq/pull/5055@github.com>
Message-ID: <bisq-network/bisq/pull/5055/push/8161801374@github.com>

@ripcurlx pushed 1 commit.

d9fc0eb78611332ffcfe3e8e55e3548102df85f2  Add informational popup after account creation


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/bisq-network/bisq/pull/5055/files/5ec04afa1b409492fa6286851bb59486bb10d8ed..d9fc0eb78611332ffcfe3e8e55e3548102df85f2
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211015/5de280c8/attachment.htm>

From notifications at github.com  Fri Oct 15 11:11:41 2021
From: notifications at github.com (Christoph Atteneder)
Date: Fri, 15 Oct 2021 02:11:41 -0700
Subject: [bisq-network/bisq] Add "Buy BSQ" button next to trade fee
 selector (#5055)
In-Reply-To: <bisq-network/bisq/pull/5055@github.com>
References: <bisq-network/bisq/pull/5055@github.com>
Message-ID: <bisq-network/bisq/pull/5055/c944132606@github.com>

@m52go Could you please have a look at the strings used in this popup? Thanks!

<img width="1411" alt="Bildschirmfoto 2021-10-15 um 11 05 03" src="https://user-images.githubusercontent.com/170962/137463103-619ef596-739e-4a02-9045-8f3e971678d2.png">


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5055#issuecomment-944132606
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211015/0cf45e6b/attachment.htm>

From notifications at github.com  Fri Oct 15 16:20:09 2021
From: notifications at github.com (m52go)
Date: Fri, 15 Oct 2021 07:20:09 -0700
Subject: [bisq-network/bisq] Add "Buy BSQ" button next to trade fee
 selector (#5055)
In-Reply-To: <bisq-network/bisq/pull/5055@github.com>
References: <bisq-network/bisq/pull/5055@github.com>
Message-ID: <bisq-network/bisq/pull/5055/c944340805@github.com>

I was hoping to review the strings in context on regtest but don't see the new `Buy BSQ` button when making/taking offers to buy/sell. 

Does it only show in certain special conditions?

![Screenshot from 2021-10-15 10-08-20](https://user-images.githubusercontent.com/735155/137502502-0a5e256c-af16-44a2-ae62-6eaf2f3fd4ec.png)

![Screenshot from 2021-10-15 10-08-42](https://user-images.githubusercontent.com/735155/137502509-89cfc500-2045-4a29-ab49-a91050242a16.png)


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5055#issuecomment-944340805
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211015/f462939e/attachment.htm>

From notifications at github.com  Fri Oct 15 17:08:32 2021
From: notifications at github.com (Christoph Atteneder)
Date: Fri, 15 Oct 2021 08:08:32 -0700
Subject: [bisq-network/bisq] Add "Buy BSQ" button next to trade fee
 selector (#5055)
In-Reply-To: <bisq-network/bisq/pull/5055@github.com>
References: <bisq-network/bisq/pull/5055@github.com>
Message-ID: <bisq-network/bisq/pull/5055/c944377695@github.com>

> I was hoping to review the strings in context on regtest but don't see the new `Buy BSQ` button when making/taking offers to buy/sell.
> 
> Does it only show in certain special conditions?
> 
> ![Screenshot from 2021-10-15 10-08-20](https://user-images.githubusercontent.com/735155/137502502-0a5e256c-af16-44a2-ae62-6eaf2f3fd4ec.png)
> 
> ![Screenshot from 2021-10-15 10-08-42](https://user-images.githubusercontent.com/735155/137502509-89cfc500-2045-4a29-ab49-a91050242a16.png)

Yes, it is only displayed if you have too little BSQ to pay the trading fees. So best way is to create a new user on Regtest.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5055#issuecomment-944377695
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211015/8a326829/attachment.htm>

From notifications at github.com  Fri Oct 15 18:58:15 2021
From: notifications at github.com (leo816)
Date: Fri, 15 Oct 2021 09:58:15 -0700
Subject: [bisq-network/projects] Dev Call - Priorities (#60)
In-Reply-To: <bisq-network/projects/issues/60@github.com>
References: <bisq-network/projects/issues/60@github.com>
Message-ID: <bisq-network/projects/issues/60/944453142@github.com>



**Priority list**

 **1. BSQ<->BTC swap**

- @ripcurlx  annd @sqrrm are on this.
- the chimp also joined Sqrrm to review the new protocol, @ripcurlx has  switched to continue the work of Jakub-CZ with the buy-BSQ changes.

**2. API**

I am working on a new API CLI getrades --category=<open|closed|failed> method.  Submission of a PR for that will be preceded by some preliminary refactoring work in a couple of desktop module trade views and models (another PR). I think it will be ready ~6-SEP, +/- a couple of days.

After that (bugs or other priorities permitting), I was planning to build a Bisq webapp POC that depends on Core API (no gRPC), and will serve json to thin web/mobile clients.  The POC would respond to browser HTTP REST requests by serving them raw json.  I will not be building a UI.


**3. Messaging Problem**

- Some messages aren't going through, the reason is yet unclear.
- There seems to be a gap of information in the log. for 6 min. 
- Chimp mentioned the hybernate mode could be the cause for the messaging problem.
- PR to advise users when their PC has been in sleep mode (action item for @jmacxx) **DONE**
- upon starting mediation, prompt users to expect a mediator response within 48 hours or contact them on keybase (action item for @jmacxx) **DONE**

**4. Mobile app and UX**

- @Devinbilek update:
- Assign bounties and whether it needs consensus.
- Once that is decided, it will be advertised on twitter to look for the right talent
- Also some tasks will require ux design so hoping Pedro can mock them up.


**6.  XMR**

- Monero is our most traded altcoin, we should learn as much as possible and make sure we are doing what we can to attract as many users. these are the main complaints so far that users have reached out to us for:

1. If the auto-confirm is not activated, some sellers never respond and that can entail to having their funds locked for days. (are they all aware that they can activate this tool on settings?)
2. If the trade were to go to mediation, users have to write down their tx id and tx key to the mediator which is an annoying.
3. Given that trading on Bisq is tantamount to routinely checking if somebody hasn't lowered the price below your level it would be nice to have an option to one-click decresase or increase the offer price by 0.01% instead of manually entering the deviation when editing the offer.


**7.  Payment methods**
- @jmacx continuing to make progress,
- 23 payment methods was the goal of which 9 have been added already.


**8.  Adding Tether**

- @pazza83 already created the proposal.  https://github.com/bisq-network/proposals/issues/170#issuecomment-927207827
- We should add tether, just choose the most used chain(Omni, ERC20 or TRC20)

**- Topics for next call:**






-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/projects/issues/60#issuecomment-944453142
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211015/23babe10/attachment.htm>

From notifications at github.com  Fri Oct 15 19:18:15 2021
From: notifications at github.com (boring-cyborg[bot])
Date: Fri, 15 Oct 2021 10:18:15 -0700
Subject: [bisq-network/bisq] Version string is missing in bitcoin P2P
 protocol on Bisq 1.7.4 (#5757)
In-Reply-To: <bisq-network/bisq/issues/5757@github.com>
References: <bisq-network/bisq/issues/5757@github.com>
Message-ID: <bisq-network/bisq/issues/5757/944466289@github.com>

**Thanks for opening your first issue here!**<br/><br/>Be sure to follow the issue template. Your issue will be reviewed by a maintainer and labeled for further action.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5757#issuecomment-944466289
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211015/836afc58/attachment.htm>

From notifications at github.com  Fri Oct 15 19:18:15 2021
From: notifications at github.com (Stephan Oeste)
Date: Fri, 15 Oct 2021 10:18:15 -0700
Subject: [bisq-network/bisq] Version string is missing in bitcoin P2P protocol
 on Bisq 1.7.4 (#5757)
Message-ID: <bisq-network/bisq/issues/5757@github.com>

<!--
   SUPPORT REQUESTS: This is for reporting bugs in the Bisq app.
   If you have a support request, please join #support on Bisq's
   Keybase team over at https://keybase.io/team/Bisq
-->

### Description

<!-- brief description of the bug -->
In version 1.7.4 with Tor v3 support is the version string in the Bitcoin P2P protocol missing.
The impact is minimal, it just shows up as an empty string. But for statistics it would be good to have the Bisq version shown in the P2P.

#### Version
1.7.4

<!-- commit id or version number -->



### Steps to reproduce
Connet your Bisq client to your Bitcoin node and execute on your Bitcoin node:
```bitcoin-cli getpeerinfo``` and look for the subver key.

<!--if you can reliably reproduce the bug, list the steps here  -->


### Expected behaviour
    "subver": "/bitcoinj:0.?.?.bisq.?/Bisq:1.7.4/"

<!--description of the expected behavior -->

### Actual behaviour

     "subver": ""

<!-- explain what happened instead of the expected behaviour -->

### Screenshots
Output from one of my Bitcoin trusted nodes:
```
$ bitcoin-cli getpeerinfo | grep subver | sort | uniq -c | sort -n
      2     "subver": "/bitcoinj:0.15.8.bisq.13/Bisq:1.6.5/",
      3     "subver": "/bitcoinj:0.15.8.bisq.13/Bisq:1.7.0/",
      3     "subver": "/bitcoinj:0.15.9.bisq.14/Bisq:1.7.4/",
      4     "subver": "/bitcoinj:0.15.8.bisq.13/Bisq:1.6.2/",
      9     "subver": "/bitcoinj:0.15.8.bisq.13/Bisq:1.7.2/",
     14     "subver": "/bitcoinj:0.15.8.bisq.13/Bisq:1.7.3/",
     21     "subver": "/Satoshi:0.21.1/",
     23     "subver": "/Satoshi:22.0.0/",
    169     "subver": "",

```
<!--Screenshots if gui related, drag and drop to add to the issue -->

#### Device or machine

<!-- device/machine used, operating system -->



#### Additional info

<!-- Additional information useful for debugging (e.g. logs) -->


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5757
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211015/9b7c5528/attachment-0001.htm>

From notifications at github.com  Fri Oct 15 20:16:04 2021
From: notifications at github.com (leo816)
Date: Fri, 15 Oct 2021 11:16:04 -0700
Subject: [bisq-network/projects] Dev Call - Priorities (#60)
In-Reply-To: <bisq-network/projects/issues/60@github.com>
References: <bisq-network/projects/issues/60@github.com>
Message-ID: <bisq-network/projects/issues/60/944501972@github.com>

## Dev call 2021-10-15
### Topics

**1. BSQ<->BTC swap** 
Almost done, next release will include it.
@ripcurlx :
making the whole process easier (specially for non users)

**2. Payment Methods** 
@jmacxx added 14 new payment methods.

**3. API update**
@ghubstan API  update:

The API `gettrades` work is on hold while others are busy with the atomic-tx work -- we don't want to create a file conflict mess in the github repo.  After atomic-tx is merged, I'll follow up on adjustments in the API (to support atomic-tx), then will re-work the `gettrades` API on top of that.

Any work on a Bisq/WebApp POC will have pushed back to sometime in November or December.

I'm pretty busy with personal stuff this week, and most of next week.  The week of Oct. 25-29 is also busy with medical treatments for a family member, Mon thru Fri in that week.  I should be able to work a little, just don't know which hours right now. 
 XMR:  API work to support XMR / BTC trd pair was done, but also being held back until after atomic-tx work is merged. Then I will re-work that to. 

**4. XMR/BTC swap** 
Currently reviewing the process to implement it.

**5. Review of priority list**

<details>

<summary>Click to see new priority list</summary>

 these are Bisq's top priorities in the short-term:

**1. BSQ<->BTC swap** 
Almost done, next release will include it.
@ripcurlx :
making the whole process easier (specially for non users)

**2. API**
@ghubstan 
 After atomic-tx is merged, I'll follow up on adjustments in the API (to support atomic-tx), then will re-work the `gettrades` API on top of that.

Any work on a Bisq/WebApp POC will have pushed back to sometime in November or December.

 XMR:  API work to support XMR / BTC trd pair was done, but also being held back until after atomic-tx work is merged. Then I will re-work that to. 


**3. Messaging Problem**

Possible solution is included in the next release.


**4. Mobile app and UX**

- @Devinbilek update:
- Defined all of the tasks that need to be addressed.
- Working through the UX designs that pedro made.
- some screens and workflow are missing
- reached out to the Bitcoin design community. 1 person is interested.
- previous app developer is interested in helping with this one. (joaquin)

**6.  XMR**

- Monero is our most traded altcoin, we should learn as much as possible and make sure we are doing what we can to attract as many users. these are the main complaints so far that users have reached out to us for:

1. If the auto-confirm is not activated, some sellers never respond and that can entail to having their funds locked for days. (are they all aware that they can activate this tool on settings?)
2. If the trade were to go to mediation, users have to write down their tx id and tx key to the mediator which is an annoying.
3. Given that trading on Bisq is tantamount to routinely checking if somebody hasn't lowered the price below your level it would be nice to have an option to one-click decresase or increase the offer price by 0.01% instead of manually entering the deviation when editing the offer.


**7.  Payment methods**
- @jmacx continuing to make progress,
- 14 payment methods will be added.


**8.  Adding Tether**

- @jmacxx already implemented it. will be included in the next release.

**9. XMR/BTC swap** 
Currently reviewing the process to implement it.

**- Topics for next call:**






-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/projects/issues/60#issuecomment-944501972
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211015/99914112/attachment.htm>

From notifications at github.com  Fri Oct 15 20:58:15 2021
From: notifications at github.com (chimp1984)
Date: Fri, 15 Oct 2021 11:58:15 -0700
Subject: [bisq-network/projects] Investigate XMR-BTC atomic cross chain swap
 protocol options  (#61)
Message-ID: <bisq-network/projects/issues/61@github.com>

> _This is a Bisq Network project. Please familiarize yourself with the [project management process](https://bisq.wiki/Project_management)._

## Description
Research for figuring out feasibility and best architecture for integration XMR-BTC atomic cross chain swaps.
There are 2 projects which have implemented it:
- https://github.com/farcaster-project (funded by the XMR community, they worked since several years on that problem and have a deep cryptographic background)
- https://github.com/comit-network/xmr-btc-swap (startup prototyping several swaps like ETH, Grin, XMR, now working on Liquid covenants).

## Rationale
Atomic cross chain swaps are a very exciting development and as it is now technically possible to do it for XMR-BTC by using the approach utilizing adapter signatures and as XMR is the main market of Bisq we should investigate feasibility for that option.
With the new BSQ/BTC atomic swaps we have now a second trade protocol integrated and the learning could be re-used for adding yet another protocol. 
The targeted integration is considering Bisq as a client talking to the swap daemon as well as providing the offer book functionality. The actual protocol execution, cryptographic and blockchain related tasks are done inside their infrastructure which is running locally or on a user controlled server. It likely requires a full XMR node, a full BTC node and the swap daemon. 

## Criteria for delivery
A summary of the findings and plan how it can be integrated should be delivered.

## Measures of success
Get a basic understanding about the state of the 2 projects. Get a swap running locally (not needed for both, just with the favorite). Get a rough plan how it can be integrated with Bisq.

## Risks
The scope of that investigation should be time limited to 3 weeks so that in case no result has been found the risk for lost effort is limited.

## Tasks
- Check out the status of the 2 projects
- Decide on which one to focus on and get in touch with the dev team to learn about their commitment to help with support in case it is used in production
- Get a swap executed in local environment
- Figure out the best way how the infrastructure could be integrated with Bisq (e.g. RPC API)
- Figure out how Tor can be used for the network layer at the swap handshakes

## Estimates
TBD from devs who commit to the tasks

## Notes
In today's dev call (15.10) we discussed this idea and @jmacxx and @sqrrm signaled interest to work on that project. 
I can be part of it as well, but prefer to focus on the Bisq side.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/projects/issues/61
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211015/1e5200a1/attachment.htm>

From notifications at github.com  Fri Oct 15 22:21:17 2021
From: notifications at github.com (=?UTF-8?B?RGF2aWQgxIxlbG91ZA==?=)
Date: Fri, 15 Oct 2021 13:21:17 -0700
Subject: [bisq-network/support] Fee reimbursement for trade M2XnyDcw (#1012)
Message-ID: <bisq-network/support/issues/1012@github.com>

>_The XXXXX part in the issue title are the first characters of the Trade ID before the "-" (dash)._

<img width="864" alt="screenshot" src="https://user-images.githubusercontent.com/49923601/137548370-de15a1a1-9f75-4675-83bc-2241309036db.png">

>_The screenshot from the Bisq client must have the **Trade ID**, **Deposit**, **Maker** and **Taker** TXIDs visible. Of course some trades do not have all 3 types, that is ok. Make sure all private information is covered (like bank accounts, name, etc). **Do not upload images where sensitive private data is visible!**_

Maker:  b334c4552492e5eca237bde92c3cd579eb071738d8057c388011a2b8d26bc72a
Taker: 48b6783b6766abb931de9afa2b146c9ff4c9bc1509655bbec32d8edf31d5f244
Deposit: N/A

>_A reimbursement request has to contain textual representation of **Maker**, **Taker** and **Deposit** TXIDs (copy them from the client to the issue). **All TXIDs that are visible in the screenshot must be copied to the issue in text form! Please use exact form for Maker/Taker/Deposit - no abbreviations like M:, T: or adding extra characters like "Maker TX:", etc. Leave those fields as they are and replace the "........" with the appropreate txid**_

Bisq version: 1.7.4
BTC address for reimbursement: bc1qen954ypcll4m87vqyfja2rzhm2hx4nxmadqlex

>_Provide the Bisq client version to help developers identify the causing issue._

Other notes:

>_Issue [#197](https://github.com/bisq-network/support/issues/197) can be used as a good example of a correct reimbursement request._


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/support/issues/1012
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211015/e9b35bc1/attachment-0001.htm>

From notifications at github.com  Sat Oct 16 02:09:54 2021
From: notifications at github.com (pazza)
Date: Fri, 15 Oct 2021 17:09:54 -0700
Subject: [bisq-network/growth] Add WorldRemit - Multi-currency payment
 method (#230)
In-Reply-To: <bisq-network/growth/issues/230@github.com>
References: <bisq-network/growth/issues/230@github.com>
Message-ID: <bisq-network/growth/issues/230/944819254@github.com>

Payment method on hold.

WorldRemit sent an email to customers on 7th October 2021 informing them that they will be disabling transfers to most European countries from 14th October 2021.

As SEPA is most liquid fiat market it makes sense to put this payment method on hold for the time being. 


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/growth/issues/230#issuecomment-944819254
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211015/43395bcd/attachment.htm>

From notifications at github.com  Sat Oct 16 12:07:46 2021
From: notifications at github.com (cd2357)
Date: Sat, 16 Oct 2021 03:07:46 -0700
Subject: [bisq-network/bisq] Update tor docs (#5758)
Message-ID: <bisq-network/bisq/pull/5758@github.com>

Include link to tor-browser changelog.
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/5758

-- Commit Summary --

  * <a href="https://github.com/bisq-network/bisq/pull/5758/commits/1390450450040e5aef7e692f3aedb8723874abd2">Update tor docs</a>

-- File Changes --

    M docs/tor-upgrade.md (7)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/5758.patch
https://github.com/bisq-network/bisq/pull/5758.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5758
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211016/874df262/attachment.htm>

From notifications at github.com  Sat Oct 16 12:50:44 2021
From: notifications at github.com (Christoph Atteneder)
Date: Sat, 16 Oct 2021 03:50:44 -0700
Subject: [bisq-network/bisq] Update tor docs (#5758)
In-Reply-To: <bisq-network/bisq/pull/5758@github.com>
References: <bisq-network/bisq/pull/5758@github.com>
Message-ID: <bisq-network/bisq/pull/5758/review/781349856@github.com>

@ripcurlx approved this pull request.

utACK



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5758#pullrequestreview-781349856
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211016/4d0c68c6/attachment.htm>

From notifications at github.com  Sat Oct 16 12:50:56 2021
From: notifications at github.com (Christoph Atteneder)
Date: Sat, 16 Oct 2021 03:50:56 -0700
Subject: [bisq-network/bisq] Update tor docs (#5758)
In-Reply-To: <bisq-network/bisq/pull/5758@github.com>
References: <bisq-network/bisq/pull/5758@github.com>
Message-ID: <bisq-network/bisq/pull/5758/issue_event/5472937591@github.com>

Merged #5758 into master.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5758#event-5472937591
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211016/53c723c3/attachment.htm>

From notifications at github.com  Sat Oct 16 20:21:15 2021
From: notifications at github.com (BtcContributor)
Date: Sat, 16 Oct 2021 11:21:15 -0700
Subject: [bisq-network/roles] L1 Support Agent (#64)
In-Reply-To: <bisq-network/roles/issues/64@github.com>
References: <bisq-network/roles/issues/64@github.com>
Message-ID: <bisq-network/roles/issues/64/944974811@github.com>

### Cycle 29

- Been available on Keybase from 1:00pm - 3:00pm Monday to Friday
- Weekly support Calls, all took place this cycle except 1 that was not on usual schedule
- Reviewed the support Wiki: https://shrib.com/#Bronson9V9N8R4

Not so much support tickets to answer during my shifts, basically usual questions.

I hope one day to be maybe a mediator :) 

Thanks!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/roles/issues/64#issuecomment-944974811
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211016/7afcaf6c/attachment.htm>

From notifications at github.com  Sat Oct 16 20:22:14 2021
From: notifications at github.com (BtcContributor)
Date: Sat, 16 Oct 2021 11:22:14 -0700
Subject: [bisq-network/compensation] For Cycle 29 (#923)
Message-ID: <bisq-network/compensation/issues/923@github.com>

Hi all,
seventh cycle for me!

## Summary

- **BSQ requested**: **`322.58`** <!-- [BSQ amount] should be: USD amount / BSQ rate -->
- USD requested: 500
- BSQ rate: 1.55 USD per BSQ
- Previous compensation request (if applicable): #914

## Contributions delivered

| Title | Team | USD | Link | Notes |
| --- | --- | --- | --- | --- |
| L1 Support Agent | support | 500 | | https://github.com/bisq-network/roles/issues/64#issuecomment-944974811 ||

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/923
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211016/92bc1d4e/attachment.htm>

From notifications at github.com  Sat Oct 16 20:24:05 2021
From: notifications at github.com (BtcContributor)
Date: Sat, 16 Oct 2021 11:24:05 -0700
Subject: [bisq-network/compensation] For Cycle 29 (#923)
In-Reply-To: <bisq-network/compensation/issues/923@github.com>
References: <bisq-network/compensation/issues/923@github.com>
Message-ID: <bisq-network/compensation/issues/923/944975570@github.com>

**TxID**: 1c416c094518d14eb0ce0ea71d86d9fe256c69179962786f4bbb4a4bb0dd85ad

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/923#issuecomment-944975570
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211016/638a6e13/attachment-0001.htm>

From notifications at github.com  Sat Oct 16 23:13:04 2021
From: notifications at github.com (=?UTF-8?B?SmFrdWIgTG91Y2vDvQ==?=)
Date: Sat, 16 Oct 2021 14:13:04 -0700
Subject: [bisq-network/bisq] Typo in SWIFT payment method (#5759)
Message-ID: <bisq-network/bisq/issues/5759@github.com>

https://github.com/bisq-network/bisq/blob/31cc79428d0f5cde30ce31755392b1c392ddc593/core/src/main/resources/i18n/displayStrings.properties#L3463

To be consistent with other occurrences of this expression, `shared payment model (SHA)` should be `shared fee model (SHA)`.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5759
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211016/3c1a3059/attachment.htm>

From notifications at github.com  Sat Oct 16 23:14:29 2021
From: notifications at github.com (=?UTF-8?B?SmFrdWIgTG91Y2vDvQ==?=)
Date: Sat, 16 Oct 2021 14:14:29 -0700
Subject: [bisq-network/bisq] Fix typo (SHA) (#5760)
Message-ID: <bisq-network/bisq/pull/5760@github.com>

Fixes #5759

The string `shared payment model (SHA)` should be `shared fee model (SHA)`.

You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/5760

-- Commit Summary --

  * <a href="https://github.com/bisq-network/bisq/pull/5760/commits/dff043d8c45023b701215ceb536f693ef0e2366c">Fix typo (SHA)</a>

-- File Changes --

    M core/src/main/resources/i18n/displayStrings.properties (2)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/5760.patch
https://github.com/bisq-network/bisq/pull/5760.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5760
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211016/533b8b38/attachment.htm>

From notifications at github.com  Sat Oct 16 23:25:52 2021
From: notifications at github.com (=?UTF-8?B?SmFrdWIgTG91Y2vDvQ==?=)
Date: Sat, 16 Oct 2021 14:25:52 -0700
Subject: [bisq-network/bisq] Fix typo (SHA) (#5760)
In-Reply-To: <bisq-network/bisq/pull/5760@github.com>
References: <bisq-network/bisq/pull/5760@github.com>
Message-ID: <bisq-network/bisq/pull/5760/push/8170400576@github.com>

@Jakub-CZ pushed 1 commit.

7f31b1ce3cc9f1ab6f939e70d9e91bc4859317f8  Fix sentence about Strike.


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/bisq-network/bisq/pull/5760/files/dff043d8c45023b701215ceb536f693ef0e2366c..7f31b1ce3cc9f1ab6f939e70d9e91bc4859317f8
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211016/7385b928/attachment.htm>

From notifications at github.com  Sat Oct 16 23:33:45 2021
From: notifications at github.com (=?UTF-8?B?SmFrdWIgTG91Y2vDvQ==?=)
Date: Sat, 16 Oct 2021 14:33:45 -0700
Subject: [bisq-network/bisq] Fix typo (SHA) (#5760)
In-Reply-To: <bisq-network/bisq/pull/5760@github.com>
References: <bisq-network/bisq/pull/5760@github.com>
Message-ID: <bisq-network/bisq/pull/5760/push/8170419288@github.com>

@Jakub-CZ pushed 2 commits.

bd27b45abedff841bc91bff62a0e966c516032b6  Fix sentence about Strike
69c563e3d45478b01833d8bf8aca2b881237f439  Fix typo in Pix info


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/bisq-network/bisq/pull/5760/files/7f31b1ce3cc9f1ab6f939e70d9e91bc4859317f8..69c563e3d45478b01833d8bf8aca2b881237f439
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211016/f4be05fc/attachment.htm>

From notifications at github.com  Sat Oct 16 23:40:25 2021
From: notifications at github.com (=?UTF-8?B?SmFrdWIgTG91Y2vDvQ==?=)
Date: Sat, 16 Oct 2021 14:40:25 -0700
Subject: [bisq-network/bisq] Fix typo (SHA) (#5760)
In-Reply-To: <bisq-network/bisq/pull/5760@github.com>
References: <bisq-network/bisq/pull/5760@github.com>
Message-ID: <bisq-network/bisq/pull/5760/push/8170434565@github.com>

@Jakub-CZ pushed 1 commit.

b84df6ec2b2faa5b2cc0834e675124c52378f692  Fix typo


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/bisq-network/bisq/pull/5760/files/69c563e3d45478b01833d8bf8aca2b881237f439..b84df6ec2b2faa5b2cc0834e675124c52378f692
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211016/341ae7ec/attachment.htm>

From notifications at github.com  Sat Oct 16 23:47:10 2021
From: notifications at github.com (=?UTF-8?B?SmFrdWIgTG91Y2vDvQ==?=)
Date: Sat, 16 Oct 2021 14:47:10 -0700
Subject: [bisq-network/bisq] Fix typo (SHA) (#5760)
In-Reply-To: <bisq-network/bisq/pull/5760@github.com>
References: <bisq-network/bisq/pull/5760@github.com>
Message-ID: <bisq-network/bisq/pull/5760/push/8170450290@github.com>

@Jakub-CZ pushed 1 commit.

adf0562152def9eb1948f9f46bb512d49f3b9282  Remove duplicate "maximum" in payment descriptions


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/bisq-network/bisq/pull/5760/files/b84df6ec2b2faa5b2cc0834e675124c52378f692..adf0562152def9eb1948f9f46bb512d49f3b9282
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211016/ef3720dd/attachment-0001.htm>

From notifications at github.com  Sat Oct 16 23:50:28 2021
From: notifications at github.com (=?UTF-8?B?SmFrdWIgTG91Y2vDvQ==?=)
Date: Sat, 16 Oct 2021 14:50:28 -0700
Subject: [bisq-network/bisq] Fix typo (SHA) (#5760)
In-Reply-To: <bisq-network/bisq/pull/5760@github.com>
References: <bisq-network/bisq/pull/5760@github.com>
Message-ID: <bisq-network/bisq/pull/5760/review/781391984@github.com>

@Jakub-CZ commented on this pull request.



>    ? $1,000 maximum per deposit\n\
   ? $1,000 maximum total deposits per week\n\
   ? $1,000 maximum per payment\n\n\
 If you trade over the above limits your trade might be cancelled and there could be a penalty.
 payment.strike.info.buyer=Please send payment only to the BTC Seller's Strike username as provided in Bisq.\n\n\
-The maximum trade size is $1,000 maximum per payment.\n\n\
+The maximum trade size is $1,000 per payment.\n\n\

Is this really "**per payment**"? Or is this supposed to be "**per transaction**" like with some of the Indian payment methods?

E.g.:
https://github.com/bisq-network/bisq/blob/adf0562152def9eb1948f9f46bb512d49f3b9282/core/src/main/resources/i18n/displayStrings.properties#L3476-L3477

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5760#pullrequestreview-781391984
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211016/5f00657f/attachment.htm>

From notifications at github.com  Sun Oct 17 01:09:23 2021
From: notifications at github.com (m52go)
Date: Sat, 16 Oct 2021 16:09:23 -0700
Subject: [bisq-network/bisq] Fix typo (SHA) (#5760)
In-Reply-To: <bisq-network/bisq/pull/5760@github.com>
References: <bisq-network/bisq/pull/5760@github.com>
Message-ID: <bisq-network/bisq/pull/5760/c945019277@github.com>

Aside from the SHA error, this is another good reminder to make sure strings get a second look before merging. Something similar happened with [the community tab](https://github.com/bisq-network/bisq/pull/5736) recently.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5760#issuecomment-945019277
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211016/b8ba99fc/attachment.htm>

From notifications at github.com  Sun Oct 17 02:31:09 2021
From: notifications at github.com (pazza)
Date: Sat, 16 Oct 2021 17:31:09 -0700
Subject: [bisq-network/bisq] Fix typo (SHA) (#5760)
In-Reply-To: <bisq-network/bisq/pull/5760@github.com>
References: <bisq-network/bisq/pull/5760@github.com>
Message-ID: <bisq-network/bisq/pull/5760/review/781398612@github.com>

@pazza83 commented on this pull request.



>    ? $1,000 maximum per deposit\n\
   ? $1,000 maximum total deposits per week\n\
   ? $1,000 maximum per payment\n\n\
 If you trade over the above limits your trade might be cancelled and there could be a penalty.
 payment.strike.info.buyer=Please send payment only to the BTC Seller's Strike username as provided in Bisq.\n\n\
-The maximum trade size is $1,000 maximum per payment.\n\n\
+The maximum trade size is $1,000 per payment.\n\n\

Thanks for spotting the SHA error.

For Strike

> Is this really "per payment"? Or is this supposed to be "per transaction" like with some of the Indian payment methods?
Only $1000 USD can be deposited to a users account per week. 
The maximum payment size is $1000 USD.

Therefore it is not possible to buy or sell on Strike over $1000 USD per week. Users should limit their activity to trades of this size.

For Strike the limits are:

Users who have registered with only their email, name, and phone number have the following limits:

$100 maximum per deposit
$1,000 maximum total deposits per week
$100 maximum per payment
Users who increase their limits by providing more information have the following limits:

$1,000 maximum per deposit
$1,000 maximum total deposits per week
$1,000 maximum per payment

For IMPS the limits are:

Maximum of 200,000 INR can be sent per transaction. This is approximately $2,700 USD.
Maximum of 1,000,000 INR can be sent per day. This is approximately $13,500 USD.
Minimum payment is 1 INR ~ $0.01 USD

Therefore, trade sizes can be more fluid than Strike as multiple payments can be made to complete a trade.

Plan for both would be to include a link to the wiki once completed.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5760#discussion_r730331483
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211016/4c08008d/attachment.htm>

From notifications at github.com  Sun Oct 17 02:34:44 2021
From: notifications at github.com (pazza)
Date: Sat, 16 Oct 2021 17:34:44 -0700
Subject: [bisq-network/bisq] Promote Keybase as a support channel within
 Bisq GUI (#4904)
In-Reply-To: <bisq-network/bisq/issues/4904@github.com>
References: <bisq-network/bisq/issues/4904@github.com>
Message-ID: <bisq-network/bisq/issues/4904/945027455@github.com>

Hi @m52go happy to include the changes you mention here https://github.com/bisq-network/bisq/issues/5732#issuecomment-929370707 for the community tab.

Is there anything else you would like changed or included?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/4904#issuecomment-945027455
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211016/d2a182c0/attachment.htm>

From notifications at github.com  Sun Oct 17 02:40:28 2021
From: notifications at github.com (pazza)
Date: Sat, 16 Oct 2021 17:40:28 -0700
Subject: [bisq-network/bisq] Fee reimbursement for Failed trade 23773143 
 (#5754)
In-Reply-To: <bisq-network/bisq/issues/5754@github.com>
References: <bisq-network/bisq/issues/5754@github.com>
Message-ID: <bisq-network/bisq/issues/5754/945027950@github.com>

Hi @A-Simon thanks for raising the issue.

As you were the taker for this trade you have not lost any fees.

No taker transaction took place.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5754#issuecomment-945027950
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211016/b56b575d/attachment-0001.htm>

From notifications at github.com  Sun Oct 17 02:45:23 2021
From: notifications at github.com (pazza)
Date: Sat, 16 Oct 2021 17:45:23 -0700
Subject: [bisq-network/bisq] Failed trade (#5751)
In-Reply-To: <bisq-network/bisq/issues/5751@github.com>
References: <bisq-network/bisq/issues/5751@github.com>
Message-ID: <bisq-network/bisq/issues/5751/945028308@github.com>

Hi @rumil2 it is rare for this to happen. I think your got a little unlucky on your first trade. Hope your second trade goes more successful.

The P2P nature of Bisq does cause some challenges but the trade offs are worth it for the decentralized platform users can access. 

Feel free to reach out on [Keybase](https://keybase.io/team/bisq) if you have any future support needs.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5751#issuecomment-945028308
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211016/3f9631d4/attachment.htm>

From notifications at github.com  Sun Oct 17 02:55:48 2021
From: notifications at github.com (pazza)
Date: Sat, 16 Oct 2021 17:55:48 -0700
Subject: [bisq-network/growth] New payment method: Hong Kong Faster
 Payment System (FPS) (#251)
In-Reply-To: <bisq-network/growth/issues/251@github.com>
References: <bisq-network/growth/issues/251@github.com>
Message-ID: <bisq-network/growth/issues/251/945029159@github.com>

Hi @raymondclowe thanks for creating this issue. 

It would be great to add a payment method to encourage a HKD market.

I will take a look into this.

 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/growth/issues/251#issuecomment-945029159
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211016/da0b6f03/attachment.htm>

From notifications at github.com  Sun Oct 17 03:13:10 2021
From: notifications at github.com (pazza)
Date: Sat, 16 Oct 2021 18:13:10 -0700
Subject: [bisq-network/bisq] DAO and Fund section in Bisq seems to be
 missing ability to copy links  (#5278)
In-Reply-To: <bisq-network/bisq/issues/5278@github.com>
References: <bisq-network/bisq/issues/5278@github.com>
Message-ID: <bisq-network/bisq/issues/5278/945030756@github.com>

Hi @ripcurlx 

Maybe having the transaction IDs selectable / copy-able as per @jmacxx's solution here https://github.com/bisq-network/bisq/pull/5747 would work.

Main issue is trying to navigate the DAO > Wallet > Transaction information none of the text is able to be selected.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5278#issuecomment-945030756
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211016/8b8bbf61/attachment.htm>

From notifications at github.com  Sun Oct 17 03:52:03 2021
From: notifications at github.com (m52go)
Date: Sat, 16 Oct 2021 18:52:03 -0700
Subject: [bisq-network/bisq] Promote Keybase as a support channel within
 Bisq GUI (#4904)
In-Reply-To: <bisq-network/bisq/issues/4904@github.com>
References: <bisq-network/bisq/issues/4904@github.com>
Message-ID: <bisq-network/bisq/issues/4904/945034680@github.com>

I didn't really make any specific suggestions in that comment. 

I'm not even sure if the symbols thing is possible. Need a developer's feedback on that first, and if it's not possible, we might need to come up with a more creative way of implementing this.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/4904#issuecomment-945034680
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211016/e9079d6a/attachment.htm>

From notifications at github.com  Sun Oct 17 20:46:42 2021
From: notifications at github.com (Christoph Atteneder)
Date: Sun, 17 Oct 2021 11:46:42 -0700
Subject: [bisq-network/bisq] Fix typo (SHA) (#5760)
In-Reply-To: <bisq-network/bisq/pull/5760@github.com>
References: <bisq-network/bisq/pull/5760@github.com>
Message-ID: <bisq-network/bisq/pull/5760/review/781478761@github.com>

@ripcurlx approved this pull request.

utACK



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5760#pullrequestreview-781478761
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211017/21dcaad4/attachment.htm>

From notifications at github.com  Sun Oct 17 21:12:01 2021
From: notifications at github.com (Christoph Atteneder)
Date: Sun, 17 Oct 2021 12:12:01 -0700
Subject: [bisq-network/bisq] Typo in SWIFT payment method (#5759)
In-Reply-To: <bisq-network/bisq/issues/5759@github.com>
References: <bisq-network/bisq/issues/5759@github.com>
Message-ID: <bisq-network/bisq/issue/5759/issue_event/5474614308@github.com>

Closed #5759 via #5760.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5759#event-5474614308
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211017/585971f1/attachment.htm>

From notifications at github.com  Sun Oct 17 21:12:02 2021
From: notifications at github.com (Christoph Atteneder)
Date: Sun, 17 Oct 2021 12:12:02 -0700
Subject: [bisq-network/bisq] Fix typo (SHA) (#5760)
In-Reply-To: <bisq-network/bisq/pull/5760@github.com>
References: <bisq-network/bisq/pull/5760@github.com>
Message-ID: <bisq-network/bisq/pull/5760/issue_event/5474614303@github.com>

Merged #5760 into master.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5760#event-5474614303
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211017/5048fcbf/attachment.htm>

From notifications at github.com  Sun Oct 17 23:06:46 2021
From: notifications at github.com (Greg L. Turnquist)
Date: Sun, 17 Oct 2021 14:06:46 -0700
Subject: [bisq-network/bisq] Bisq doesn't operate on remote NAS devices over
 SMBFS (Issue #5761)
Message-ID: <bisq-network/bisq/issues/5761@github.com>

### Description

Bisq works great on my local Mac. But when I move my wallet to a remote RAID-based NAS (over SMBFS), it can't launch properly and thus fails to get started.

#### Version

1.7.4

### Steps to reproduce

1. Install latest version of Bisq.
2. Set up an alternative location for the wallet.
```
$ mount 

//zzz at remote-nas-storage-unit._smb._tcp.local/Bisq on /Volumes/Bisq (smbfs, nodev, nosuid, quarantine, mounted by zzz)
```
3. Launch Bisq but with an alternative command.
```
/Volumes/Bisq/Bisq.app/Contents/MacOS/Bisq --appDataDir=/Volumes/Bisq/BisqData
```

### Expected behaviour

I expected Bisq to come up just fine. In fact, it does if I let Bisq use the default path of `~/Library/Application Support/Bisq`.

### Actual behaviour

Bisq fails to launch. It complains about a potentially corrupted SPV file. But in truth, it appears to need to do some form of low level locking on the SPV file, which for some reason, the NAS in it's configuration is unable to do. 

And so it throws this stack trace:

```
Oct-16 21:08:29.682 [JavaFX Application Thread] ERROR b.core.btc.setup.WalletsSetup: Service failure from state: STARTING; failure={} java.io.IOException: org.bitcoinj.store.BlockStoreException: java.io.IOException: Operation not supported
	at bisq.core.btc.setup.WalletConfig.startUp(WalletConfig.java:352)
	at com.google.common.util.concurrent.AbstractIdleService$DelegateService$1.run(AbstractIdleService.java:62)
	at com.google.common.util.concurrent.Callables$4.run(Callables.java:119)
	at java.base/java.lang.Thread.run(Unknown Source)
Caused by: org.bitcoinj.store.BlockStoreException: java.io.IOException: Operation not supported
	at org.bitcoinj.store.SPVBlockStore.<init>(SPVBlockStore.java:159)
	at org.bitcoinj.store.SPVBlockStore.<init>(SPVBlockStore.java:91)
	at bisq.core.btc.setup.WalletConfig.startUp(WalletConfig.java:289)
	... 3 common frames omitted
Caused by: java.io.IOException: Operation not supported
	at java.base/sun.nio.ch.FileDispatcherImpl.lock0(Native Method)
	at java.base/sun.nio.ch.FileDispatcherImpl.lock(Unknown Source)
	at java.base/sun.nio.ch.FileChannelImpl.tryLock(Unknown Source)
	at java.base/java.nio.channels.FileChannel.tryLock(Unknown Source)
	at org.bitcoinj.store.SPVBlockStore.<init>(SPVBlockStore.java:133)
	... 5 common frames omitted
```

#### Device or machine

I'm doing this on MacOS Big Sur. The NAS runs ext4, which is standard Linux. But the partition is `smbfs, nodev, nosuid, quarantine`.


#### Additional info

I need this because running Bisq (Tor-based tech) directly on my machine violates security policy. By running everything off of my NAS, I can continue using Bisq. Hopefully, there is some easy adjustment to the code that may make it operational.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5761
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211017/cf0c5f3b/attachment.htm>

From notifications at github.com  Sun Oct 17 23:06:47 2021
From: notifications at github.com (boring-cyborg[bot])
Date: Sun, 17 Oct 2021 14:06:47 -0700
Subject: [bisq-network/bisq] Bisq doesn't operate on remote NAS devices
 over SMBFS (Issue #5761)
In-Reply-To: <bisq-network/bisq/issues/5761@github.com>
References: <bisq-network/bisq/issues/5761@github.com>
Message-ID: <bisq-network/bisq/issues/5761/945194885@github.com>

**Thanks for opening your first issue here!**<br/><br/>Be sure to follow the issue template. Your issue will be reviewed by a maintainer and labeled for further action.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5761#issuecomment-945194885
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211017/a6224744/attachment.htm>

From notifications at github.com  Mon Oct 18 05:06:30 2021
From: notifications at github.com (jmacxx)
Date: Sun, 17 Oct 2021 20:06:30 -0700
Subject: [bisq-network/bisq] Improve BSQ block requests (#3094)
In-Reply-To: <bisq-network/bisq/issues/3094@github.com>
References: <bisq-network/bisq/issues/3094@github.com>
Message-ID: <bisq-network/bisq/issues/3094/945322947@github.com>

Experienced this today in support.  User reported their DAO rebuild stopped syncing without any feedback.  Upon restarting Bisq the resync would start but eventually stall again.  Logs revealed that it was downloading blocks from a seednode, then after some time it would get disconnected and a connection would be made to a new seednode.  After 3 such disconnects it would simply give up with the log message "We tried 4 times but could not connect to a seednode".

https://github.com/bisq-network/bisq/blob/d0e88f7e2a63ca4dfd75c757c79deaa5be5c845e/core/src/main/java/bisq/core/dao/node/lite/network/LiteNodeNetworkService.java#L354-L358

I propose removing the MAX_RETRY limit and change the retry backoff time to `(retryCounter * RETRY_DELAY_SEC)` so that the subsequent seednode connection attempts get further and further apart, much like how login screens increase the time before you can make another attempt at entering your password.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/3094#issuecomment-945322947
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211017/f02bc7b2/attachment-0001.htm>

From notifications at github.com  Mon Oct 18 05:27:02 2021
From: notifications at github.com (pazza)
Date: Sun, 17 Oct 2021 20:27:02 -0700
Subject: [bisq-network/roles] Comptroller (Issue #111)
Message-ID: <bisq-network/roles/issues/111@github.com>

## Comptroller

This Comptroller role has been created following the proposal https://github.com/bisq-network/proposals/issues/340

As per the [roles wiki](https://bisq.wiki/Roles) I will outline the key aspects of the role to:

- To maximize role owner autonomy in order to achieve Bisq's decentralization goals
- To maximize transparency so that DAO stakeholders can effectively review and vote on role owner compensation requests

### Objectives of the comptroller role

To make it easy for Bisq contributors and stakeholders to access brief monthly reports that give a snapshot as to how Bisq is performing in terms of profit / loss ie, is Bisq earning more in trade fees that it is spending (both in terms of USD and BTC).

This would have a positive impact on making it:

- Easier to ascertain progress
- Easier to make real-time decisions on budgets and what resources are available
- Be better able to see the impact of work done to the success of Bisq
- Easier to use as starting point for any future audit (to validate financials)

### Duties

The following are the Comptroller duties:

To report monthly on the following: 

|   | USD | BTC |
| ------------- | ------------- | ------------- |
| Trade volume in given month  | $X  | X BTC  |
| BSQ trade revenue fees in given month  | $X  | X BTC |
| BTC trade revenue fees in given month | $X | X BTC |
| Net Profit (Loss) in given month  | $X  | X BTC |

To report monthly on the what percentage of fees paid were paid in BSQ.

### Rights
None 

### Owners
N/A

### Team
@bisq-network/support 

### Reporting
I will provide monthly reports underneath this role. As the reports are provided for each calendar month there may be cycles that do not have reports provided. 

A annual report similar will also be provided at the start of each fiscal year to report on the previous fiscal year. I will include a summary of observations alongside the report.

### Bonding
None as this role is not vital to Bisq operations, nor is any special permissions required.

### Compensation

The following compensation will be requested for the role:

| Amount | Duty |
| ------------- | ------------- |
| $75 USD | Monthly report |
| $150 USD  | Annual report |

### Limitations

Some elements lie outside the scope of this role. Specifically auditing the financials. More more information please see comments on the original proposal: https://github.com/bisq-network/proposals/issues/340

Tagging in @cbeams in case I have missed anything


### Wiki
A wiki will be created for the role in the future and linked here.






-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/roles/issues/111
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211017/86b19253/attachment.htm>

From notifications at github.com  Mon Oct 18 06:04:20 2021
From: notifications at github.com (pazza)
Date: Sun, 17 Oct 2021 21:04:20 -0700
Subject: [bisq-network/roles] Comptroller (Issue #111)
In-Reply-To: <bisq-network/roles/issues/111@github.com>
References: <bisq-network/roles/issues/111@github.com>
Message-ID: <bisq-network/roles/issues/111/945342800@github.com>

## Profit and loss - August 2021

This is my first cycle as for the Comptroller role.

Please see below the report for August 2021 (which coincides with cycle 27): 

|  August 2021 | USD | BTC |
| ------------- | ------------- | ------------- |
| Trade volume  | $6,527,571  | 143.0199 BTC  |
| BSQ trade revenue fees  | $8,562 | 0.18759448 BTC |
| BTC trade revenue fees  | $35,096 | 0.76895773 BTC |
| Contributor costs  | $17,351 | 0.38015315 BTC |
| Net Profit (Loss)  | $26,790 | 0.58697158 BTC |

Percentage of fees paid in BSQ in August 2021 was: 24.39%

I will maintain a link to the [spreadsheet](docs.google.com/spreadsheets/d/1EMwuKiFxP5QreN9eNUiX5Ub7ssukGcJ4FytuAXHCDgM/edit#gid=1292352923) I used with comments on the individual line items. 

### Summary

I have previously reported on the profit and loss for the fiscal year 2020/21 ($51,997 for the whole year), and for July 2021 ($5,325). 

Although this is my first cycle as the Comptroller a profit of $26,790 is a significant increase in profits when compared to the previous figures. I think it is likely this is the most profitable month to date excluding April 2021 when BTC prices and trade volumes and maybe September 2021 that I have yet to calculate (although contributor costs were higher).

The only anomaly with the figures is cycle 27 had low contributor costs.

If anyone has any comments, questions or suggestions please let me know.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/roles/issues/111#issuecomment-945342800
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211017/c9e1d3b3/attachment.htm>

From notifications at github.com  Mon Oct 18 06:08:36 2021
From: notifications at github.com (pazza)
Date: Sun, 17 Oct 2021 21:08:36 -0700
Subject: [bisq-network/proposals] Proposal for a new Comptroller role
 (#340)
In-Reply-To: <bisq-network/proposals/issues/340@github.com>
References: <bisq-network/proposals/issues/340@github.com>
Message-ID: <bisq-network/proposals/issues/340/945345073@github.com>

Closing as approved due to feedback in comments and discussion during team meetings.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/proposals/issues/340#issuecomment-945345073
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211017/ef775dc7/attachment.htm>

From notifications at github.com  Mon Oct 18 06:08:36 2021
From: notifications at github.com (pazza)
Date: Sun, 17 Oct 2021 21:08:36 -0700
Subject: [bisq-network/proposals] Proposal for a new Comptroller role
 (#340)
In-Reply-To: <bisq-network/proposals/issues/340@github.com>
References: <bisq-network/proposals/issues/340@github.com>
Message-ID: <bisq-network/proposals/issue/340/issue_event/5475469328@github.com>

Closed #340.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/proposals/issues/340#event-5475469328
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211017/6e3683b7/attachment.htm>

From notifications at github.com  Mon Oct 18 06:42:03 2021
From: notifications at github.com (pazza)
Date: Sun, 17 Oct 2021 21:42:03 -0700
Subject: [bisq-network/bisq] Some BTC addresses utilized by Bisq are receiving
 both trade fees and time-locked deposits (Issue #5762)
Message-ID: <bisq-network/bisq/issues/5762@github.com>

<!--
   SUPPORT REQUESTS: This is for reporting bugs in the Bisq app.
   If you have a support request, please join #support on Bisq's
   Keybase team over at https://keybase.io/team/Bisq
-->

### Description

Following discussion on Running the numbers of the Bisq DAO https://github.com/bisq-network/bisq/discussions/5171 and the subsequent discussions with other contributors a recent Bisq call. I thought it would be beneficial to open a separate issue to discuss the fact the some BTC addresses utilized by Bisq are receiving both trade fees and time-locked deposits.

Bisq utilizes BTC addresses to receive trade fees (for users not paying in BSQ) and to receive delayed payouts (time-locked deposits to a donation address) when either trader decides to send funds to arbitration. 

The addresses in current use can be seen here in a comment by @chimp1984 https://github.com/bisq-network/bisq/discussions/5171#discussioncomment-372304

Ideally, from an accounting / auditing perspective, Bisq would have addresses that only received either trade fees OR delayed payouts.

The issue with addresses receiving both trade fees AND delayed payouts is that it makes accounting / auditing more difficult.

### Version

1.7.4

### Steps to reproduce

Looking at all the addresses used by Bisq to receive trade fees and delayed payouts I compiled the following table. It appears that most addresses used by Bisq for this purpose receive both trade fees and time-locked deposits. 

| Address | Notes | Receiving trade fees | Receiving time-locked deposits | Last Active / Comments |
| ------------- | ------------- | ------------- | ------------- | ------------- |
| [1BVxNn3T12veSK6DgqwU4Hdn7QHcDDRag7](https://mempool.space/address/1BVxNn3T12veSK6DgqwU4Hdn7QHcDDRag7) | Default donation address  | Yes  | Yes  | April 2021, nit sure if this address has now been retired? |
| [3EtUWqsGThPtjwUczw27YCo6EWvQdaPUyp](https://mempool.space/address/3EtUWqsGThPtjwUczw27YCo6EWvQdaPUyp)  | burning2019 | Yes  | Yes | August 2021 - Sporadic use, not sure if due to people running old versions of Bisq? |
| [3A8Zc1XioE2HRzYfbb5P8iemCS72M6vRJV](https://mempool.space/address/3A8Zc1XioE2HRzYfbb5P8iemCS72M6vRJV)  | burningman2 | Yes | Yes | August 2021 - Sporadic use, not sure if due to people running old versions of Bisq? |
| [38bZBj5peYS3Husdz7AH3gEUiUbYRD951t](https://mempool.space/address/38bZBj5peYS3Husdz7AH3gEUiUbYRD951t)  | burningman3 | Yes | No | In constant use - I assume this is the main address for BTC trade fees. It is only receiving trade fees so this is good |
| [34VLFgtFKAtwTdZ5rengTT2g2zC99sWQLC](https://mempool.space/address/34VLFgtFKAtwTdZ5rengTT2g2zC99sWQLC)  | burningman3 | Yes | Yes | In constant use -  Mainly used as a donation address. Not sure why it is still receiving sporadic trade fees? |

### Expected behaviour

If possible the following addresses to be retired:

- 1BVxNn3T12veSK6DgqwU4Hdn7QHcDDRag7
- 3EtUWqsGThPtjwUczw27YCo6EWvQdaPUyp
- 3A8Zc1XioE2HRzYfbb5P8iemCS72M6vRJV

If possible the following address to receive no trade fees:

- 34VLFgtFKAtwTdZ5rengTT2g2zC99sWQLC

#### Additional info

If the above can be achieved would it be possible have a script or similar that could calculate:

- Trade fees received per month to 38bZBj5peYS3Husdz7AH3gEUiUbYRD951t
- Time locked deposit amounts sent to 34VLFgtFKAtwTdZ5rengTT2g2zC99sWQLC

Ideally the above would be included in the DAO charts:

![dao](https://user-images.githubusercontent.com/66367547/137670136-e1cabcde-9896-4a58-8f79-66dd729fc9a7.PNG)

Failing the above a script or something similar to differentiate total trade fees vs total delayed payouts per calendar month, cycle, or year would be a useful tool for accounting / auditing. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5762
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211017/e22e1161/attachment-0001.htm>

From notifications at github.com  Mon Oct 18 06:58:40 2021
From: notifications at github.com (pazza)
Date: Sun, 17 Oct 2021 21:58:40 -0700
Subject: [bisq-network/roles] L1 Support Agent (#64)
In-Reply-To: <bisq-network/roles/issues/64@github.com>
References: <bisq-network/roles/issues/64@github.com>
Message-ID: <bisq-network/roles/issues/64/945365056@github.com>

## Cycle 29 Support

Support for me has seemed a little quieter this cycle, but still supported the same amount of users in Keybase via PM as last cycle (30). I have been available on Keybase support for my usual hours.

Active on here, Keybase, Reddit and the Bisq community forum to support users as required.

Joined in all the weekly support calls.

Most issues were general support queries that were quickly resolved.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/roles/issues/64#issuecomment-945365056
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211017/4afbf72d/attachment.htm>

From notifications at github.com  Mon Oct 18 07:03:37 2021
From: notifications at github.com (pazza)
Date: Sun, 17 Oct 2021 22:03:37 -0700
Subject: [bisq-network/proposals] Develop a fully featured cross-platform
 graphical user interface to the Bisq network supporting mobile,
 desktop, and web clients (#342)
In-Reply-To: <bisq-network/proposals/issues/342@github.com>
References: <bisq-network/proposals/issues/342@github.com>
Message-ID: <bisq-network/proposals/issues/342/945366940@github.com>

Marking as approved but will leave open for ongoing discussion. 

@devinbileck please consider if opening a [project](https://bisq.wiki/Project_management) would be beneficial.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/proposals/issues/342#issuecomment-945366940
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211017/c0a8bd3f/attachment.htm>

From notifications at github.com  Mon Oct 18 07:05:17 2021
From: notifications at github.com (pazza)
Date: Sun, 17 Oct 2021 22:05:17 -0700
Subject: [bisq-network/proposals] Bisq regulatory issues (#341)
In-Reply-To: <bisq-network/proposals/issues/341@github.com>
References: <bisq-network/proposals/issues/341@github.com>
Message-ID: <bisq-network/proposals/issue/341/issue_event/5475629625@github.com>

Closed #341.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/proposals/issues/341#event-5475629625
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211017/42622823/attachment.htm>

From notifications at github.com  Mon Oct 18 07:05:17 2021
From: notifications at github.com (pazza)
Date: Sun, 17 Oct 2021 22:05:17 -0700
Subject: [bisq-network/proposals] Bisq regulatory issues (#341)
In-Reply-To: <bisq-network/proposals/issues/341@github.com>
References: <bisq-network/proposals/issues/341@github.com>
Message-ID: <bisq-network/proposals/issues/341/945367745@github.com>

Closing due to lacking information.

@daveblack1 please feel free to expand on your proposal. Information about how to create a proposal can be found here: https://bisq.wiki/Proposals

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/proposals/issues/341#issuecomment-945367745
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211017/4f6b78ed/attachment.htm>

From notifications at github.com  Mon Oct 18 07:06:42 2021
From: notifications at github.com (pazza)
Date: Sun, 17 Oct 2021 22:06:42 -0700
Subject: [bisq-network/proposals] BSQ trading fee update for Cycle 27
 (#339)
In-Reply-To: <bisq-network/proposals/issues/339@github.com>
References: <bisq-network/proposals/issues/339@github.com>
Message-ID: <bisq-network/proposals/issue/339/issue_event/5475634476@github.com>

Closed #339.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/proposals/issues/339#event-5475634476
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211017/461105db/attachment.htm>

From notifications at github.com  Mon Oct 18 07:08:19 2021
From: notifications at github.com (pazza)
Date: Sun, 17 Oct 2021 22:08:19 -0700
Subject: [bisq-network/proposals] List USDT (Tether) (#170)
In-Reply-To: <bisq-network/proposals/issues/170@github.com>
References: <bisq-network/proposals/issues/170@github.com>
Message-ID: <bisq-network/proposals/issues/170/945369322@github.com>

Approved. Many thanks to @jmacxx for completing this ready for version 1.7.5

@flix1 hope you can get some liquidity added to this market :)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/proposals/issues/170#issuecomment-945369322
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211017/a63bff11/attachment-0001.htm>

From notifications at github.com  Mon Oct 18 07:08:20 2021
From: notifications at github.com (pazza)
Date: Sun, 17 Oct 2021 22:08:20 -0700
Subject: [bisq-network/proposals] List USDT (Tether) (#170)
In-Reply-To: <bisq-network/proposals/issues/170@github.com>
References: <bisq-network/proposals/issues/170@github.com>
Message-ID: <bisq-network/proposals/issue/170/issue_event/5475639945@github.com>

Closed #170.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/proposals/issues/170#event-5475639945
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211017/9c1a7417/attachment.htm>

From notifications at github.com  Mon Oct 18 07:10:55 2021
From: notifications at github.com (pazza)
Date: Sun, 17 Oct 2021 22:10:55 -0700
Subject: [bisq-network/proposals] Allow custom fee for withdrawals (#343)
In-Reply-To: <bisq-network/proposals/issues/343@github.com>
References: <bisq-network/proposals/issues/343@github.com>
Message-ID: <bisq-network/proposals/issues/343/945370582@github.com>

Hi @asvdf  thanks for making this proposal.

I think this is an important issue for discussion but would benefit from you expanding on the proposal to stand the best chance of engaging users. For more info on how to write an effective proposal please see https://bisq.wiki/Proposals

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/proposals/issues/343#issuecomment-945370582
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211017/bef04bb4/attachment.htm>

From notifications at github.com  Mon Oct 18 07:19:10 2021
From: notifications at github.com (pazza)
Date: Sun, 17 Oct 2021 22:19:10 -0700
Subject: [bisq-network/proposals] New role request- User Researcher (#344)
In-Reply-To: <bisq-network/proposals/issues/344@github.com>
References: <bisq-network/proposals/issues/344@github.com>
Message-ID: <bisq-network/proposals/issues/344/945374083@github.com>

Hi @UX-P thanks for the propsoal.

Feel free to browse the [approved proposals](https://github.com/bisq-network/proposals/issues?q=is%3Aissue+is%3Aclosed+label%3Awas%3Aapproved) for ideas, or alternatively [current projects](https://github.com/bisq-network/projects/issues) for ideas.

[Keybase](https://keybase.io/team/bisq) may also a good place to discuss with other contributors how you could assist from a user researcher perspective.

I will leave this proposal open for a month or so if you want to come back with any updates as to what you might get involved with.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/proposals/issues/344#issuecomment-945374083
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211017/386e6c29/attachment.htm>

From notifications at github.com  Mon Oct 18 07:20:52 2021
From: notifications at github.com (Devin Bileck)
Date: Sun, 17 Oct 2021 22:20:52 -0700
Subject: [bisq-network/proposals] Develop a fully featured cross-platform
 graphical user interface to the Bisq network supporting mobile,
 desktop, and web clients (#342)
In-Reply-To: <bisq-network/proposals/issues/342@github.com>
References: <bisq-network/proposals/issues/342@github.com>
Message-ID: <bisq-network/proposals/issues/342/945374745@github.com>

As this is a seperate application from the Bisq core code base, I have created a [new repository](https://github.com/bisq-network/bisq-client) and started defining tasks and milestones within. So a dedicated project should not be necessary.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/proposals/issues/342#issuecomment-945374745
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211017/013a47ea/attachment.htm>

From notifications at github.com  Mon Oct 18 07:34:50 2021
From: notifications at github.com (pazza)
Date: Sun, 17 Oct 2021 22:34:50 -0700
Subject: [bisq-network/roles] Proposals Maintainer (#30)
In-Reply-To: <bisq-network/roles/issues/30@github.com>
References: <bisq-network/roles/issues/30@github.com>
Message-ID: <bisq-network/roles/issues/30/945379992@github.com>

### Cycle 29 Report

This cycle there was lot of good discussion taking place on the mobile GUI proposal. This has now been set up in a [new repository](https://github.com/bisq-network/bisq-client).

#### 3 proposals were accepted:

- @devinbileck's proposal to [Develop a fully featured cross-platform graphical user interface to the Bisq network supporting mobile, desktop, and web clients](https://github.com/bisq-network/proposals/issues/342)
- @pazza83's proposal [for a new Comptroller role ](https://github.com/bisq-network/proposals/issues/340)
- @flix1's proposal to [List USDT](https://github.com/bisq-network/proposals/issues/170)

#### 2 new proposals were opened

@UX-P's proposal to add a new role - [User Researcher](https://github.com/bisq-network/proposals/issues/344)
@asvdf's proposal to [allow custom fee for withdrawals](https://github.com/bisq-network/proposals/issues/343)

#### 1 proposal was closed as invalid.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/roles/issues/30#issuecomment-945379992
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211017/fee3a0fc/attachment.htm>

From notifications at github.com  Mon Oct 18 09:13:54 2021
From: notifications at github.com (cd2357)
Date: Mon, 18 Oct 2021 00:13:54 -0700
Subject: [bisq-network/bisq] chore: Bump tor to v0.4.5.10 (PR #5763)
Message-ID: <bisq-network/bisq/pull/5763@github.com>

Update netlayer and tor-binary dependencies.

You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/5763

-- Commit Summary --

  * <a href="https://github.com/bisq-network/bisq/pull/5763/commits/455a74a4a80c0a736a4f30464e337827869180dd">chore: Bump tor to v0.4.5.10</a>

-- File Changes --

    M build.gradle (2)
    M gradle/witness/gradle-witness.gradle (17)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/5763.patch
https://github.com/bisq-network/bisq/pull/5763.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5763
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211018/dad137ea/attachment-0001.htm>

From notifications at github.com  Mon Oct 18 09:53:09 2021
From: notifications at github.com (=?UTF-8?B?RsOpbGl4?=)
Date: Mon, 18 Oct 2021 00:53:09 -0700
Subject: [bisq-network/proposals] List USDT (Tether) (#170)
In-Reply-To: <bisq-network/proposals/issues/170@github.com>
References: <bisq-network/proposals/issues/170@github.com>
Message-ID: <bisq-network/proposals/issues/170/945460433@github.com>

> @flix1 hope you can get some liquidity added to this market :)

I will do my best to kickstart it and attract other traders.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/proposals/issues/170#issuecomment-945460433
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211018/ac9c13ac/attachment.htm>

From notifications at github.com  Mon Oct 18 10:16:18 2021
From: notifications at github.com (asvdf)
Date: Mon, 18 Oct 2021 01:16:18 -0700
Subject: [bisq-network/proposals] Allow custom fee for withdrawals (#343)
In-Reply-To: <bisq-network/proposals/issues/343@github.com>
References: <bisq-network/proposals/issues/343@github.com>
Message-ID: <bisq-network/proposals/issues/343/945488782@github.com>

Thank you for getting back to me, I think I understood your post as "make the point so it will be more interesting for other users to accept", so I reworded the OP to this extent.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/proposals/issues/343#issuecomment-945488782
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211018/5ef75cae/attachment.htm>

From notifications at github.com  Mon Oct 18 10:48:32 2021
From: notifications at github.com (21m)
Date: Mon, 18 Oct 2021 01:48:32 -0700
Subject: [bisq-network/bisq] bisq mobile notifications should NOT rely on
 "google play services" (#2441)
In-Reply-To: <bisq-network/bisq/issues/2441@github.com>
References: <bisq-network/bisq/issues/2441@github.com>
Message-ID: <bisq-network/bisq/issues/2441/945542775@github.com>

A suggestion: why not take a step back in the process and instead of providing people the whole mobile app, relying on Google Play Services make the Bisq App simply make an HTTP request configurable in it?

This way anyone can set up a webhook to listen to this HTTP request and use whichever methods they deem relevant for delivering the notification instead of a) relying on a mobile app with Google Play Services and plus b) Bisq does not need to endorse nor develop/keep up to date, the mobile apps themselves.

Even users that aren' t technical can set up a webhook with zapier and such no-code tools.

I use Graphene OS and find it quite annoying that the Bisq UX is so poor in the notifications regard. Some notes on how the experience could be:

* user goes to Account > Notifications tab
* the Setup Section has a couple of simple fieds to configure the HTTP request (endpoint URL & auth token if any)
* Save button & Send Test notification button

And that's it, Bisq's development responsibility ends here and in providing some documentation as to how to set this up. I as the user can now get bisq notifications in the form of a Telegram bot, Matrix bot, even a postcard if I want. 

I do wonder (and I'm ignorant about it) if clearnet http requests can be made from within the bisq client directly or if they need to be sent to seed nodes in order to move from onion to clearnet

Thanks everyone, 

I'd really love to see bisq notifications again in my Graphene phone :) and I'm confident I'm not the only one


-------

On a Different note: the workaround I'm using now is that I set up a dumb Android phone with bisq that stays near my PC and put IFTTT on it. Whenever a notification from bisq arrives it sends me a private message over  to a private telegram group I have with just myself and the IFTTT bot






-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/2441#issuecomment-945542775
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211018/05d76f5c/attachment.htm>

From notifications at github.com  Mon Oct 18 14:04:00 2021
From: notifications at github.com (Christoph Atteneder)
Date: Mon, 18 Oct 2021 05:04:00 -0700
Subject: [bisq-network/bisq] chore: Bump tor to v0.4.5.10 (PR #5763)
In-Reply-To: <bisq-network/bisq/pull/5763@github.com>
References: <bisq-network/bisq/pull/5763@github.com>
Message-ID: <bisq-network/bisq/pull/5763/review/781958273@github.com>

@ripcurlx approved this pull request.

utACK - verification of hashes took place in other repositories already



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5763#pullrequestreview-781958273
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211018/c31b1b89/attachment.htm>

From notifications at github.com  Mon Oct 18 14:04:20 2021
From: notifications at github.com (Christoph Atteneder)
Date: Mon, 18 Oct 2021 05:04:20 -0700
Subject: [bisq-network/bisq] chore: Bump tor to v0.4.5.10 (PR #5763)
In-Reply-To: <bisq-network/bisq/pull/5763@github.com>
References: <bisq-network/bisq/pull/5763@github.com>
Message-ID: <bisq-network/bisq/pull/5763/issue_event/5477870703@github.com>

Merged #5763 into master.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5763#event-5477870703
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211018/6ff863d8/attachment.htm>

From notifications at github.com  Mon Oct 18 14:50:43 2021
From: notifications at github.com (m52go)
Date: Mon, 18 Oct 2021 05:50:43 -0700
Subject: [bisq-network/bisq] Add "Buy BSQ" button next to trade fee
 selector (#5055)
In-Reply-To: <bisq-network/bisq/pull/5055@github.com>
References: <bisq-network/bisq/pull/5055@github.com>
Message-ID: <bisq-network/bisq/pull/5055/review/782008137@github.com>

@m52go commented on this pull request.



> +offerbook.info.accountCreated.message=You''ve just successfully created a BSQ payment account.\n\
+  Your account can be found under Account > Altcoins Accounts > {0} and your BSQ wallet under DAO > BSQ Wallet.\n\n

```suggestion
offerbook.info.accountCreated.message=You''ve just successfully created a BSQ payment account.\n\
  See details of this payment account at Account > Altcoins Accounts > {0}. See details of your BSQ wallet at DAO > BSQ Wallet.\n\n
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5055#pullrequestreview-782008137
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211018/3c862d54/attachment.htm>

From notifications at github.com  Mon Oct 18 14:51:33 2021
From: notifications at github.com (m52go)
Date: Mon, 18 Oct 2021 05:51:33 -0700
Subject: [bisq-network/bisq] Add "Buy BSQ" button next to trade fee
 selector (#5055)
In-Reply-To: <bisq-network/bisq/pull/5055@github.com>
References: <bisq-network/bisq/pull/5055@github.com>
Message-ID: <bisq-network/bisq/pull/5055/review/782009156@github.com>

@m52go commented on this pull request.



> @@ -439,6 +442,13 @@ offerbook.info.buyAtFixedPrice=You will buy at this fixed price.
 offerbook.info.sellAtFixedPrice=You will sell at this fixed price.
 offerbook.info.noArbitrationInUserLanguage=In case of a dispute, please note that arbitration for this offer will be handled in {0}. Language is currently set to {1}.
 offerbook.info.roundedFiatVolume=The amount was rounded to increase the privacy of your trade.
+offerbook.info.accountCreated.headline=Congratulations
+offerbook.info.accountCreated.message=You''ve just successfully created a BSQ payment account.\n\
+  Your account can be found under Account > Altcoins Accounts > {0} and your BSQ wallet under DAO > BSQ Wallet.\n\n
+offerbook.info.accountCreated.tradeInstant=As you've chosen to take a BSQ instant offer a BSQ instant account was created for you. \
+  For instant trading it is required that both trading peers are online to be able \
+  to complete the trade in less than 1 hour.\n\n
+offerbook.info.accountCreated.takeOffer=You can no proceed to take this offer after closing this popup.

```suggestion
offerbook.info.accountCreated.takeOffer=You can now proceed to take this offer after closing this popup.
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5055#pullrequestreview-782009156
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211018/306bea01/attachment.htm>

From notifications at github.com  Mon Oct 18 14:55:30 2021
From: notifications at github.com (m52go)
Date: Mon, 18 Oct 2021 05:55:30 -0700
Subject: [bisq-network/bisq] Add "Buy BSQ" button next to trade fee
 selector (#5055)
In-Reply-To: <bisq-network/bisq/pull/5055@github.com>
References: <bisq-network/bisq/pull/5055@github.com>
Message-ID: <bisq-network/bisq/pull/5055/review/782013887@github.com>

@m52go commented on this pull request.



> +offerbook.info.accountCreated.tradeInstant=As you've chosen to take a BSQ instant offer a BSQ instant account was created for you. \
+  For instant trading it is required that both trading peers are online to be able \
+  to complete the trade in less than 1 hour.\n\n

```suggestion
offerbook.info.accountCreated.tradeInstant=You've chosen to take a BSQ instant offer, so a BSQ instant payment account was created for you. \n\n\
  Be aware that instant trades are meant to be completed within 1 hour, \
  so you should be online and available for the next 1 hour.\n\n
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5055#pullrequestreview-782013887
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211018/87606b1f/attachment.htm>

From notifications at github.com  Mon Oct 18 15:24:30 2021
From: notifications at github.com (chimp1984)
Date: Mon, 18 Oct 2021 06:24:30 -0700
Subject: [bisq-network/bisq] Some BTC addresses utilized by Bisq are
 receiving both trade fees and time-locked deposits (Issue #5762)
In-Reply-To: <bisq-network/bisq/issues/5762@github.com>
References: <bisq-network/bisq/issues/5762@github.com>
Message-ID: <bisq-network/bisq/issues/5762/945764146@github.com>

The Default donation address is used by people who have deactivated the DAO.

The old addresses are likely used because of out of sync DAO state. Really old Bisq nodes cannot be used for trading as there is an requirement for newer versions by the newer trade protocol.
We could detect if one of the old addresses are used and then enforce a DAO resync, this should clean up that problem for those who update to that version, so might take also a bit until its effective. Later we could let trades fail if those addresses are still used to enforce that users update, but not sure it that's justified.

I would recommend to ignore in the meantime those values or to include it in the tracking of the main addresses.

I will have a look why 34VLFgtFKAtwTdZ5rengTT2g2zC99sWQLC is receiving the trade fee. This should not be the case, but I guess its also from older versions... I guess we added the dedicated other address later...

In the meantime until a script for monthly reports on 38bZBj5peYS3Husdz7AH3gEUiUbYRD951t and 34VLFgtFKAtwTdZ5rengTT2g2zC99sWQLC are in place, we could just check each start of month manually the total balance received of those addresses and subtract the past balance to get the diff of that month. 



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5762#issuecomment-945764146
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211018/85158ac0/attachment-0001.htm>

From notifications at github.com  Mon Oct 18 17:06:32 2021
From: notifications at github.com (pazza)
Date: Mon, 18 Oct 2021 08:06:32 -0700
Subject: [bisq-network/bisq] Some BTC addresses utilized by Bisq are
 receiving both trade fees and time-locked deposits (Issue #5762)
In-Reply-To: <bisq-network/bisq/issues/5762@github.com>
References: <bisq-network/bisq/issues/5762@github.com>
Message-ID: <bisq-network/bisq/issues/5762/945871613@github.com>

Thanks for the comments and explanation. 

Maybe a script could be used to differentiate between single signature and multisig transactions to the above addresses.

- single signature transactions = trade fees
- multisig transactions = Delayed payouts

That way it does not matter which of the above addresses is used for what.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5762#issuecomment-945871613
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211018/c2b6d10d/attachment.htm>

From notifications at github.com  Mon Oct 18 21:56:21 2021
From: notifications at github.com (Chris Beams)
Date: Mon, 18 Oct 2021 12:56:21 -0700
Subject: [bisq-network/compensation] [WIP] For Cycle 29 (Issue #924)
Message-ID: <bisq-network/compensation/issues/924@github.com>

## Summary

- **BSQ requested**: 32.26
- USD requested: 50
- BSQ rate: [1.55](https://github.com/bisq-network/compensation/issues/921) USD per BSQ
- Previous compensation request (if applicable): #881

## Contributions delivered

| Title | Team | USD | Link | Notes |
| --- | --- | --- | --- | --- |
| DNS Admin | admin* | 25 | TODO | 
| Roles Maintainer | admin* | 25 | TODO | 


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/924
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211018/433a6e47/attachment.htm>

From notifications at github.com  Mon Oct 18 22:18:29 2021
From: notifications at github.com (chimp1984)
Date: Mon, 18 Oct 2021 13:18:29 -0700
Subject: [bisq-network/bisq] Avoid that outdated donation and fee addresses
 are used. (PR #5764)
Message-ID: <bisq-network/bisq/pull/5764@github.com>

Fixes https://github.com/bisq-network/bisq/issues/5762

In case we get an outdated donation address (RECIPIENT_BTC_ADDRESS)
we trigger a dao resync. The user get a popup for doing a restart
in that case.
For the fee address selection we do not fall back to the
RECIPIENT_BTC_ADDRESS in case no address from filter is provided
but we use the hard coded address of the current fee receiver address.

You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/5764

-- Commit Summary --

  * <a href="https://github.com/bisq-network/bisq/pull/5764/commits/621d9956837f5ace7a37d43b8db08a8cd19f736b">Fixes https://github.com/bisq-network/bisq/issues/5762</a>

-- File Changes --

    M core/src/main/java/bisq/core/dao/state/DaoStateSnapshotService.java (19)
    M core/src/main/java/bisq/core/offer/placeoffer/tasks/CreateMakerFeeTx.java (2)
    A core/src/main/java/bisq/core/trade/DelayedPayoutAddressProvider.java (47)
    M core/src/main/java/bisq/core/trade/protocol/tasks/seller/SellerCreatesDelayedPayoutTx.java (4)
    M core/src/main/java/bisq/core/trade/protocol/tasks/taker/CreateTakerFeeTx.java (2)
    M core/src/main/java/bisq/core/util/FeeReceiverSelector.java (16)
    M core/src/test/java/bisq/core/dao/state/DaoStateSnapshotServiceTest.java (3)
    M core/src/test/java/bisq/core/util/FeeReceiverSelectorTest.java (22)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/5764.patch
https://github.com/bisq-network/bisq/pull/5764.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5764
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211018/b51bb067/attachment.htm>

From notifications at github.com  Mon Oct 18 22:29:38 2021
From: notifications at github.com (Chris Beams)
Date: Mon, 18 Oct 2021 13:29:38 -0700
Subject: [bisq-network/roles] Comptroller (Issue #111)
In-Reply-To: <bisq-network/roles/issues/111@github.com>
References: <bisq-network/roles/issues/111@github.com>
Message-ID: <bisq-network/roles/issues/111/946140499@github.com>

Great to see this come together @pazza83.

A few items of feedback, in no particular order:

- I would, in principle, see this as an @bisq-network/admin role as opposed to @bisq-network/support, but for practical purposes, I agree it should be managed under support. @leo816, are you OK with reviewing and approving @pazza83's compensation requests relating to this role?

- The compensation amount requested looks reasonable to me. Certainly worth it to have ongoing profit and loss numbers.

- I like the simple breakdown of numbers you've started with here. I think it would be worth having a single rolled up, USD denominated revenue number that sums up the BSQ and BTC revenue numbers above, but this is a minor point.

- It would be good to see the actual BSQ number in the BSQ trade revenue fees line item. Same with contributor costs. Since these are actually denominated in BSQ, it would be good to see a third column "BSQ" that lists these values. Perhaps you could **bold** the values for each row that represent the original denomination.

- the link to the spreadsheet above is broken.

- In the table above, ((BSQ trade revenue fees + BTC trade revenue fees) - Contributor costs) = Net Profit (Loss), but the actual values in the table do not add up. (($8,562+$35,096) - $17,351) = **$26,307**, but the total listed above is **$26,790**. This is a minor discrepancy, but it makes me wonder what's missing from the table and/or spreadsheet that led to this.

In any case, I think this is a good start, and if all we do with this role is apply the same methodology to produce the same set of numbers every month, that'll already be a massive improvement. Thanks for taking it on @pazza83.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/roles/issues/111#issuecomment-946140499
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211018/773e6213/attachment.htm>

From notifications at github.com  Mon Oct 18 22:32:21 2021
From: notifications at github.com (Chris Beams)
Date: Mon, 18 Oct 2021 13:32:21 -0700
Subject: [bisq-network/roles] Roles Maintainer (#28)
In-Reply-To: <bisq-network/roles/issues/28@github.com>
References: <bisq-network/roles/issues/28@github.com>
Message-ID: <bisq-network/roles/issues/28/946142272@github.com>

## Cycle 29 report

- I updated the @bisq-network/ops team to reflect @wiz's departure as Ops team lead, and @Emzy stepping in in his place. See https://github.com/bisq-network/roles/issues/101#issuecomment-925701037.
- @pazza83 created the new Comptroller role at https://github.com/bisq-network/roles/issues/111.

/cc https://github.com/bisq-network/compensation/issues/924

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/roles/issues/28#issuecomment-946142272
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211018/7618da76/attachment-0001.htm>

From notifications at github.com  Mon Oct 18 22:33:23 2021
From: notifications at github.com (Chris Beams)
Date: Mon, 18 Oct 2021 13:33:23 -0700
Subject: [bisq-network/roles] DNS Admin (#18)
In-Reply-To: <bisq-network/roles/issues/18@github.com>
References: <bisq-network/roles/issues/18@github.com>
Message-ID: <bisq-network/roles/issues/18/946143016@github.com>

## Cycle 29 report

Nothing to report

/cc https://github.com/bisq-network/compensation/issues/924

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/roles/issues/18#issuecomment-946143016
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211018/cb2ea674/attachment.htm>

From notifications at github.com  Mon Oct 18 23:42:26 2021
From: notifications at github.com (chimp1984)
Date: Mon, 18 Oct 2021 14:42:26 -0700
Subject: [bisq-network/bisq] Some BTC addresses utilized by Bisq are
 receiving both trade fees and time-locked deposits (Issue #5762)
In-Reply-To: <bisq-network/bisq/issues/5762@github.com>
References: <bisq-network/bisq/issues/5762@github.com>
Message-ID: <bisq-network/bisq/issues/5762/946190303@github.com>

I just looked into Electrum. There you can create a new wallet with adding an address as watch only and you get all the transactions. Then you get loaded all txs and under wallet/history you can export it as csv and do some filtering for data in a spreadsheet.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5762#issuecomment-946190303
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211018/0a33f7e5/attachment.htm>

From notifications at github.com  Tue Oct 19 03:11:25 2021
From: notifications at github.com (pazza)
Date: Mon, 18 Oct 2021 18:11:25 -0700
Subject: [bisq-network/roles] Comptroller (Issue #111)
In-Reply-To: <bisq-network/roles/issues/111@github.com>
References: <bisq-network/roles/issues/111@github.com>
Message-ID: <bisq-network/roles/issues/111/946285732@github.com>

Hi @cbeams 

Many thanks for the feedback. I have updated the report to include your feedback.

> * I would, in principle, see this as an @bisq-network/admin role as opposed to @bisq-network/support, but for practical purposes, I agree it should be managed under support. @leo816, are you OK with reviewing and approving @pazza83's compensation requests relating to this role?
Yes, agreed. @leo816 asked me to list under support.

> * I like the simple breakdown of numbers you've started with here. I think it would be worth having a single rolled up, USD denominated revenue number that sums up the BSQ and BTC revenue numbers above, but this is a minor point.
I am not sure what you mean with this? Can you expand?

> * It would be good to see the actual BSQ number in the BSQ trade revenue fees line item. Same with contributor costs. Since these are actually denominated in BSQ, it would be good to see a third column "BSQ" that lists these values. Perhaps you could **bold** the values for each row that represent the original denomination.
Included, and updated.

> * the link to the spreadsheet above is broken.
Fixed

> * In the table above, ((BSQ trade revenue fees + BTC trade revenue fees) - Contributor costs) = Net Profit (Loss), but the actual values in the table do not add up. (($8,562+$35,096) - $17,351) = **$26,307**, but the total listed above is **$26,790**. This is a minor discrepancy, but it makes me wonder what's missing from the table and/or spreadsheet that led to this.
The prior table did not include [arbitration fees](https://github.com/bisq-network/roles/issues/93#issuecomment-901876354). I have included them now.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/roles/issues/111#issuecomment-946285732
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211018/ec466195/attachment.htm>

From notifications at github.com  Tue Oct 19 04:36:02 2021
From: notifications at github.com (pazza)
Date: Mon, 18 Oct 2021 19:36:02 -0700
Subject: [bisq-network/roles] Mediator (#83)
In-Reply-To: <bisq-network/roles/issues/83@github.com>
References: <bisq-network/roles/issues/83@github.com>
Message-ID: <bisq-network/roles/issues/83/946316649@github.com>

## Cycle 29 Report

Here is my cycle 29 mediator report.

In total I have 68 new cases since my last report.

11 of which are currently still in progress.

All is going well. This cycle has been my busiest to date, Likely due to @huey735 retiring his mediator key.

Many thanks to @jmacxx for fixing two issues this cycle:

- There is an issue with a missing or invalid transaction https://github.com/bisq-network/bisq/issues/5494 (this has caused an increasing number of mediation cases.
- Missing mediation proposals lead to no option for users to be able to send funds to donation address https://github.com/bisq-network/bisq/issues/5642 (this has improved mediation experience for users when things go wrong with missing messages)

Here is a breakdown of the cases: 

| Reason  | Cycle 29 |
| ------------- | ------------- |
| BANK_PROBLEMS  | 14  |
| BUG  | 14  |
| OPTION_TRADE  | 0  |
| OTHER  | 19 |
| PEER_WAS_LATE  | 7 |
| TRADER_NOT_RESPONDING  | 0 |
| TRADE_ALREADY_SETTLED  | 8  |
| USABILITY  | 0 |
| WRONG SENDER ACCOUNT  | 0  |
| TOTAL  | 62  |

Table above is not completely accurate as I have used the mediator report tool for the first time this cycle. Previously been entering the data manually. Will continue with using the tool from now on as it saves time and is more accurate.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/roles/issues/83#issuecomment-946316649
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211018/8f3c502a/attachment.htm>

From notifications at github.com  Tue Oct 19 04:51:07 2021
From: notifications at github.com (pazza)
Date: Mon, 18 Oct 2021 19:51:07 -0700
Subject: [bisq-network/compensation] For Cycle 29 (Issue #925)
Message-ID: <bisq-network/compensation/issues/925@github.com>

<!--
Compensation requests have a specific format that enables them to be evaluated by a bot for more efficient budgeting. Please make sure you stick to the template. A linter will evaluate your request after you remove [WIP] from the issue title and notify you of any issues.

See the following link for details:
https://bisq.wiki/Making_a_compensation_request

Feel free to browse other requests if you're not sure about something, or reach out in #compensation on Keybase (https://keybase.io/team/bisq).
-->

## Summary

- **BSQ requested**: **`[1,048.3]`** 
- USD requested: [1625] 
- BSQ rate: [1.55 USD/BSQ] USD per BSQ as per #921
- Previous compensation request: #919

## Contributions delivered for Cycle 29

> _Add contributions you have [delivered](https://github.com/bisq-network/proposals/issues/19) and roles you have performed here as new rows in the table below. Role line-items should include an asterisk (*) in the team column._

 Title | Team | USD | Link | Notes |
| --- | --- | --- | --- | --- |
| Mediator | *Support | 1000 | https://github.com/bisq-network/roles/issues/83#issuecomment-946316649 | This has been another busy cycle.  68 new cases since my last. |
Support Agent | *Support  | 500 | https://github.com/bisq-network/roles/issues/64#issuecomment-945365056 | Support role is going well. No major issues. I feel I have learnt a lot since taking on this role |
Proposals Maintainer | *Admin  | 50 | https://github.com/bisq-network/roles/issues/30#issuecomment-945379992 | Good discussion taking place on mobile GUI proposal |
Comptroller | *Support  | 75 | https://github.com/bisq-network/roles/issues/111#issuecomment-945342800 | First cycle in this role. Bisq made a profit in August of $26,790. Please feel free to share feedback on this new role. |

Not requested any compensation for the Payments Method Maintainer role this cycle. @jmacxx is making speedy work of adding the new payment methods. I will request compensation when new payment methods are added and documentation is complete. Hopefully I can start this once 1.7.5 is released with lots more payment methods.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/925
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211018/a37ca38f/attachment-0001.htm>

From notifications at github.com  Tue Oct 19 05:07:33 2021
From: notifications at github.com (jmacxx)
Date: Mon, 18 Oct 2021 20:07:33 -0700
Subject: [bisq-network/bisq] Avoid that outdated donation and fee
 addresses are used. (PR #5764)
In-Reply-To: <bisq-network/bisq/pull/5764@github.com>
References: <bisq-network/bisq/pull/5764@github.com>
Message-ID: <bisq-network/bisq/pull/5764/c946327829@github.com>

Could be good to define the hardcoded addresses in `Config.java` since they are used in more than one place, and to avoid having them sprinkled through the code, 
see: `Param.java, DaoFacade.java, DelayedPayoutAddressProvider.java, TxValidatorTest.java`

---

    // Option name constants
    public static final String TESTNET_DONATION_ADDRESS = "2N4mVTpUZAnhm9phnxB7VrHB4aBhnWrcUrV";
    public static final String REGTEST_DONATION_ADDRESS = "2MzBNTJDjjXgViKBGnatDU3yWkJ8pJkEg9w";
    public static final String INITIAL_DONATION_ADDRESS = "1BVxNn3T12veSK6DgqwU4Hdn7QHcDDRag7";
    public static final String BURNINGMAN_2019 = "3EtUWqsGThPtjwUczw27YCo6EWvQdaPUyp";
    public static final String BURNINGMAN_2 = "3A8Zc1XioE2HRzYfbb5P8iemCS72M6vRJV";
    public static final String BURNINGMAN_3 = "34VLFgtFKAtwTdZ5rengTT2g2zC99sWQLC";




-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5764#issuecomment-946327829
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211018/03c02869/attachment.htm>

From notifications at github.com  Tue Oct 19 05:21:03 2021
From: notifications at github.com (jmacxx)
Date: Mon, 18 Oct 2021 20:21:03 -0700
Subject: [bisq-network/roles] L1 Support Agent (#64)
In-Reply-To: <bisq-network/roles/issues/64@github.com>
References: <bisq-network/roles/issues/64@github.com>
Message-ID: <bisq-network/roles/issues/64/946333619@github.com>

### Cycle 29:

In addition to second level support, I've been spending time assisting users on keybase.

9/22/2021 support team meeting
9/24/2021 analyzed logs for 5918604 and czcgg resulting in https://github.com/bisq-network/bisq/issues/5725
9/27/2021 analyzed logs for 9186044 locked up funds from a failed trade
9/30/2021 looked into issue https://github.com/bisq-network/bisq/issues/5494 eventually came up with a fix
10/2/2021 looked into an issue with flailing offer count. (ended up being incorrect system time affecting Tor)
10/6/2021 support team meeting
10/7/2021 supported a user reporting problems with their bisq wallet receiving & address gaps
10/13/2021 support team meeting
10/17/2021 supported a user having problems DAO resync (https://github.com/bisq-network/bisq/issues/3094#issuecomment-945322947)



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/roles/issues/64#issuecomment-946333619
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211018/bc8c5ba8/attachment.htm>

From notifications at github.com  Tue Oct 19 05:28:10 2021
From: notifications at github.com (jmacxx)
Date: Mon, 18 Oct 2021 20:28:10 -0700
Subject: [bisq-network/compensation] For Cycle 29 (Issue #926)
Message-ID: <bisq-network/compensation/issues/926@github.com>



## Summary

- **BSQ requested**: **`2193.55`** 
- USD requested: 3400
- BSQ rate: 1.55 USD per BSQ
- Previous compensation request (if applicable):   https://github.com/bisq-network/compensation/issues/913


## Contributions delivered


> _Add contributions you have [delivered](https://github.com/bisq-network/proposals/issues/19) here as new rows in the table below. See comments below the table for guidance._

| Title | Team | USD | Link | Notes |
| --- | --- | --- | --- | --- |
Add five Indian payment methods | dev | 750 | https://github.com/bisq-network/bisq/pull/5696 | 1.7.5
Display support agent's Keybase link when opening mediation / arbitration | dev | 100 | https://github.com/bisq-network/bisq/pull/5716 | 1.7.5
Show a warning if PC has been in sleep mode | dev | 50 | https://github.com/bisq-network/bisq/pull/5719 | 1.7.5
Add CelPay and Nequi payment methods | dev | 300 | https://github.com/bisq-network/bisq/pull/5721 &nbsp; https://github.com/bisq-network/bisq/pull/5724 | 1.7.5
Add Tether (ERC20) | dev | 150 | https://github.com/bisq-network/bisq/pull/5735 | 1.7.5
Add payment methods Bizum and Pix | dev | 300 | https://github.com/bisq-network/bisq/pull/5741 | 1.7.5
Allow trader chat to continue after trade complete | dev | 150 | https://github.com/bisq-network/bisq/pull/5742 | 1.7.5
Add payment methods Monese and Satispay | dev | 300 | https://github.com/bisq-network/bisq/pull/5745 | 1.7.5
Fix issue of Trade Step 1 validation done too soon | dev | 250 | https://github.com/bisq-network/bisq/pull/5746 | 1.7.5
Allow standard mark & copy functionality for displayed text fields | dev | 150 | https://github.com/bisq-network/bisq/pull/5747 | 1.7.5
Fix logic of SEPA country comparison routine | dev | 50 | https://github.com/bisq-network/bisq/pull/5748 | 1.7.5
Add payment methods Strike and Verse | dev | 300 | https://github.com/bisq-network/bisq/pull/5752 | 1.7.5
Fix exception in offer entry UI | dev | 50 | https://github.com/bisq-network/bisq/pull/5753 | 1.7.5
Support / troubleshooting | support | 500 | https://github.com/bisq-network/roles/issues/64#issuecomment-946333619 | 

&nbsp;

## Other contributions

* organizing jitsi meetings with @bisq-network/bisq-devs
* release testing
* maintenance/operation of compensation-bot

&nbsp;

## Contributions in progress

-  Developing wallet code (potentially for future Misq/Bisq)
-  Taking a look into bisq memory issues
-  PR: Fix FeeService failover issues
-  Wiz asked for a stylized fee slider which I'll work on when time permits
-  Provide a reliable lightweight monitor with notifications



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/926
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211018/467bf528/attachment-0001.htm>

From notifications at github.com  Tue Oct 19 10:31:16 2021
From: notifications at github.com (RequestPrivacy)
Date: Tue, 19 Oct 2021 01:31:16 -0700
Subject: [bisq-network/bisq] Change Bisq window title in GNOME top bar (Issue
 #5765)
Message-ID: <bisq-network/bisq/issues/5765@github.com>

### Description

Request a more pleasing to look at and shorter title in the top bar of GNOME.

#### Device & Version

Debian 11 Bullseye
GNOME 3.38.5
Bisq v1.7.4


### Steps to reproduce

Launch Bisq in said environment.

### Expected behaviour

A short title like "Bisq" / "Bisq v1.7.4" / "Bisq - Exchange"

### Actual behaviour

Title is "bisq.desktop.app.BisqApp"

### Screenshots
![Bisq](https://user-images.githubusercontent.com/72392544/137872532-4e673d08-3f4f-483a-825f-ca1a5900b3f1.png)

<!--Screenshots if gui related, drag and drop to add to the issue -->


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5765
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211019/d7200d91/attachment.htm>

From notifications at github.com  Tue Oct 19 10:31:16 2021
From: notifications at github.com (boring-cyborg[bot])
Date: Tue, 19 Oct 2021 01:31:16 -0700
Subject: [bisq-network/bisq] Change Bisq window title in GNOME top bar
 (Issue #5765)
In-Reply-To: <bisq-network/bisq/issues/5765@github.com>
References: <bisq-network/bisq/issues/5765@github.com>
Message-ID: <bisq-network/bisq/issues/5765/946483631@github.com>

**Thanks for opening your first issue here!**<br/><br/>Be sure to follow the issue template. Your issue will be reviewed by a maintainer and labeled for further action.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5765#issuecomment-946483631
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211019/518e417a/attachment.htm>

From notifications at github.com  Tue Oct 19 14:57:15 2021
From: notifications at github.com (UX-P)
Date: Tue, 19 Oct 2021 05:57:15 -0700
Subject: [bisq-network/proposals] New role request- User Researcher (#344)
In-Reply-To: <bisq-network/proposals/issues/344@github.com>
References: <bisq-network/proposals/issues/344@github.com>
Message-ID: <bisq-network/proposals/issues/344/946695053@github.com>

Hi @pazza83 that's excellent, thank you. I have seen a project that would really benefit from a user researcher's perspective, I will discuss this in Keybase and be updating in the coming weeks. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/proposals/issues/344#issuecomment-946695053
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211019/bbfcf63d/attachment.htm>

From notifications at github.com  Tue Oct 19 15:06:09 2021
From: notifications at github.com (jan zens)
Date: Tue, 19 Oct 2021 06:06:09 -0700
Subject: [bisq-network/bisq] add alternative popup "no BSQ while Synchronizing
 DAO" (PR #5766)
Message-ID: <bisq-network/bisq/pull/5766@github.com>

change popup when choosing BSQ to pay while DAO  is synchronising from &quot;not enough BSQ funds&quot; to &quot;no BSQ while synchronising&quot;

resource string is in english in all languages except german

fixes #5522
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/5766

-- Commit Summary --

  * <a href="https://github.com/bisq-network/bisq/pull/5766/commits/f2cac86b50af9fcbcdf8eb82a274e19ebbb22c36">Trade Step 1: add popup &quot;no BSQ while Synchronizing DAO&quot;</a>

-- File Changes --

    M core/src/main/resources/i18n/displayStrings.properties (1)
    M core/src/main/resources/i18n/displayStrings_cs.properties (1)
    M core/src/main/resources/i18n/displayStrings_de.properties (1)
    M core/src/main/resources/i18n/displayStrings_es.properties (1)
    M core/src/main/resources/i18n/displayStrings_fa.properties (1)
    M core/src/main/resources/i18n/displayStrings_fr.properties (1)
    M core/src/main/resources/i18n/displayStrings_it.properties (1)
    M core/src/main/resources/i18n/displayStrings_ja.properties (1)
    M core/src/main/resources/i18n/displayStrings_pt-br.properties (1)
    M core/src/main/resources/i18n/displayStrings_pt.properties (1)
    M core/src/main/resources/i18n/displayStrings_ru.properties (1)
    M core/src/main/resources/i18n/displayStrings_th.properties (1)
    M core/src/main/resources/i18n/displayStrings_vi.properties (1)
    M core/src/main/resources/i18n/displayStrings_zh-hans.properties (1)
    M core/src/main/resources/i18n/displayStrings_zh-hant.properties (1)
    M desktop/src/main/java/bisq/desktop/main/offer/MutableOfferView.java (17)
    M desktop/src/main/java/bisq/desktop/main/offer/takeoffer/TakeOfferView.java (16)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/5766.patch
https://github.com/bisq-network/bisq/pull/5766.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5766
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211019/7d06559a/attachment.htm>

From notifications at github.com  Tue Oct 19 15:06:11 2021
From: notifications at github.com (boring-cyborg[bot])
Date: Tue, 19 Oct 2021 06:06:11 -0700
Subject: [bisq-network/bisq] add alternative popup "no BSQ while
 Synchronizing DAO" (PR #5766)
In-Reply-To: <bisq-network/bisq/pull/5766@github.com>
References: <bisq-network/bisq/pull/5766@github.com>
Message-ID: <bisq-network/bisq/pull/5766/c946703448@github.com>

**Thanks for opening this pull request!**<br/><br/>Please check out our [contributor checklist](https://bisq.wiki/Contributor_checklist) and check if *Travis* or *Codacy* found any issues with your PR. Also make sure your commits are signed, and that you applied [Bisq's code style](https://github.com/bisq-network/style/issues) and [formatting](.editorconfig).<br/><br/>A maintainer will add an `is:priority` label to your PR if it is up for compensation. Please see our [Bisq Q1 2020 Update post](https://bisq.network/blog/q1-2020-update/) for more details.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5766#issuecomment-946703448
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211019/27804c9c/attachment.htm>

From notifications at github.com  Tue Oct 19 16:35:36 2021
From: notifications at github.com (pazza)
Date: Tue, 19 Oct 2021 07:35:36 -0700
Subject: [bisq-network/proposals] BSQ trading fee update for Cycle 27
 (#339)
In-Reply-To: <bisq-network/proposals/issues/339@github.com>
References: <bisq-network/proposals/issues/339@github.com>
Message-ID: <bisq-network/proposals/issue/339/issue_event/5485801757@github.com>

Reopened #339.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/proposals/issues/339#event-5485801757
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211019/1953f2b1/attachment.htm>

From notifications at github.com  Tue Oct 19 16:51:08 2021
From: notifications at github.com (wiz)
Date: Tue, 19 Oct 2021 07:51:08 -0700
Subject: [bisq-network/compensation] For Cycle 29 (Issue #927)
Message-ID: <bisq-network/compensation/issues/927@github.com>

## Summary

* **BSQ requested**: **`4129`**
* USD requested: 6400
* BSQ rate: 1.55 USD per BSQ
* Previous compensation request (if applicable): #912

## Contributions delivered

| Title | Team | USD | Link | Notes |
| --- | --- | --- | --- | --- |
| Mempool Explorer Operator (2x) | ops* | 400 | https://github.com/bisq-network/roles/issues/107 | mempool.space, mempool.ninja |
| Bitcoin Node Operator (4x) | ops* | 200 | https://github.com/bisq-network/roles/issues/67 | node100,node140,node210,node220 |
| Bisq Analytics Operator (1x) | ops* | 100 | https://github.com/bisq-network/roles/issues/88 | matomo.bisq.network |
| Bisq Markets Operator (2x) | ops* | 200 | https://github.com/bisq-network/roles/issues/9 | bisq.markets |
| Bisq Pricenode Operator (1x) | ops* | 100 | https://github.com/bisq-network/roles/issues/14 | price.bisq.wiz.biz |
| Bisq Seednode Operator (3x) | ops* | 300 | https://github.com/bisq-network/roles/issues/15 | wizseed3, wizseed7, wizseeds |
| Bisq Wiki Operator (1x) | ops* | 100 | https://github.com/bisq-network/roles/issues/92 | bisq.wiki |
| Bitcoin 2021 sponsorship | growth | 5000 | https://github.com/bisq-network/compensation/issues/498 | see below |

## [Growth] Bitcoin 2021 sponsorship final payment

Bisq and Mempool joined forces to have an amazing presence at the Bitcoin 2021 conference in Miami in June and it was a huge success, we really had the biggest and best booth in the whole conference and met thousands of our community members.

<img src="https://user-images.githubusercontent.com/232186/137933599-6d18a478-3fc8-4081-bb8f-2049b0981dc9.jpeg">

Building the actual booth and other various expenses came to around $10K over the (previously approved budget](https://github.com/bisq-network/compensation/issues/498) which after discussion with @m52go the Bisq and Mempool projects agreed to split equally. Mempool has paid their $5K share of the final invoice and so this is the last payment for Bisq's side.

<img width="400" src="https://user-images.githubusercontent.com/232186/137934757-faf0bb26-0082-4c53-84d5-de2cb82eb6ae.jpeg"><img width="400" src="https://user-images.githubusercontent.com/232186/137933652-a19ef2eb-b9e4-4372-b5dc-d32b921bb41e.png">

The final piece of the sponsorship package contract to be delivered in November is our full page back cover advertisement on Bitcoin Magazine's issue with El Salvador on the cover, and Bisq and Mempool on the back cover :)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/927
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211019/1fea7915/attachment-0001.htm>

From notifications at github.com  Tue Oct 19 17:09:12 2021
From: notifications at github.com (wiz)
Date: Tue, 19 Oct 2021 08:09:12 -0700
Subject: [bisq-network/bisq] Version string is missing in bitcoin P2P
 protocol on Bisq 1.7.4 (#5757)
In-Reply-To: <bisq-network/bisq/issues/5757@github.com>
References: <bisq-network/bisq/issues/5757@github.com>
Message-ID: <bisq-network/bisq/issues/5757/946821765@github.com>

> **Thanks for opening your first issue here!**

Welcome to the Bisq project :joy:

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5757#issuecomment-946821765
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211019/d24834e5/attachment.htm>

From notifications at github.com  Tue Oct 19 18:16:53 2021
From: notifications at github.com (Stephan Oeste)
Date: Tue, 19 Oct 2021 09:16:53 -0700
Subject: [bisq-network/compensation] [WIP] For Cycle 28 (Issue #928)
Message-ID: <bisq-network/compensation/issues/928@github.com>

<!--
Compensation requests have a specific format that enables them to be evaluated by a bot for more efficient budgeting. Please make sure you stick to the template. A linter will evaluate your request after you remove [WIP] from the issue title and notify you of any issues.

See the following link for details:
https://bisq.wiki/Making_a_compensation_request

Feel free to browse other requests if you're not sure about something, or reach out in #compensation on Keybase (https://keybase.io/team/bisq).
-->


## Summary

> _Specify the total amount of BSQ you are requesting, along with the USD total and BSQ/USD rate (don't include the brackets!):_

- **BSQ requested**: **`789`** <!-- [BSQ amount] should be: USD amount / BSQ rate -->
- USD requested: 1200 <!-- [USD amount] should be: total of all contributions listed in "contributions delivered" table below -->
- BSQ rate: 1.52 USD per BSQ <!-- [rate] should be the rate used to determine the BSQ amount above, as specified in the cycle's rate announcement (https://bisq.wiki/Compensation_Maintainer#Announce_BSQ-USD_rate) -->
- Previous compensation request (if applicable): #917 <!-- Link to last compensation request submitted -->


## Contributions delivered

> _Add contributions you have [delivered](https://github.com/bisq-network/proposals/issues/19) and roles you have performed here as new rows in the table below. Role line-items should include an asterisk (*) in the team column._

| Title | Team | USD | Link | Notes |
| --- | --- | --- | --- | --- |
| 4* Bitcoin node operator | ops* | 200 | bisq-network/roles#67 |  |
| 4* Seed node operator | ops* | 400 | bisq-network/roles#15 | 1 old node (Onion V2) as backup for V3 issues |
| Pricenode operator | ops* | 100 | bisq-network/roles#14 |  |
| Mailman operator | ops* | 100 | bisq-network/roles#26 |  |
| Mempool operator | ops* | 200 | bisq-network/roles#107 |  |
| Monero Explorer Operator | ops* | 100 | bisq-network/roles#109 |  |
| Monitoring Operator | ops* | 100 | bisq-network/roles#10 |  |

<!-- 

Each contribution should be a new line-item in the table above. 

Title - optional, string.
Team - optional, must one of the following: admin, dev, growth, ops, support (case-insensitive). If the line-item is for a role, please add a `*`. See Example 2 below.
USD - optional, number. Please do not specify 'USD', as the column title makes units clear.
Link - optional, string.
Notes - optional, string.

Example 1 - typical contribution:

| Add local Bitcoin node configuration detection | dev | 240 | https://github.com/bisq-network/bisq/pull/3982

Example 2 - role (note the asterisk):

| Community manager | growth* | 400 | https://github.com/bisq-network/roles/issues/95#issuecomment-628431613

Example 3 - list of minor contributions, such as reviews:

| | | | https://github.com/bisq-network/bisq/pull/3968 | This and PRs below too small to be valued separately. See total at bottom.
| | | | https://github.com/bisq-network/bisq/pull/4040
| | | | https://github.com/bisq-network/bisq/pull/4044
| | | | https://github.com/bisq-network/bisq/pull/4048
| | | | https://github.com/bisq-network/bisq/pull/4066
| | dev | 400 | https://github.com/bisq-network/bisq/pull/4062 | Total for items above.

-->


## Contributions in progress

> _Provide links to work you're involved with that is still [in progress](https://github.com/bisq-network/proposals/issues/19). **This section is optional (the linter ignores it),** and is for your own benefit in keeping track of what you're doing and keeping other contributors up to date with the same._


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/928
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211019/2a1948ce/attachment.htm>

From notifications at github.com  Tue Oct 19 18:19:20 2021
From: notifications at github.com (Stephan Oeste)
Date: Tue, 19 Oct 2021 09:19:20 -0700
Subject: [bisq-network/roles] Bitcoin Node Operator (#67)
In-Reply-To: <bisq-network/roles/issues/67@github.com>
References: <bisq-network/roles/issues/67@github.com>
Message-ID: <bisq-network/roles/issues/67/946886192@github.com>

## Cycle 29 report

Running 4 Bitcoin Fullnodes.

4 onion address
3 clearnet address
2 VPS servers and 2 dedicated server.

### Events:
- Added an additional Tor v3 hidden service to all my instances

/cc bisq-network/compensation#928

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/roles/issues/67#issuecomment-946886192
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211019/5f0a8f02/attachment.htm>

From notifications at github.com  Tue Oct 19 18:20:12 2021
From: notifications at github.com (Stephan Oeste)
Date: Tue, 19 Oct 2021 09:20:12 -0700
Subject: [bisq-network/roles] Seednode Operator (#15)
In-Reply-To: <bisq-network/roles/issues/15@github.com>
References: <bisq-network/roles/issues/15@github.com>
Message-ID: <bisq-network/roles/issues/15/946886989@github.com>

## Cycle 29 report
running 4 seednode  instances
Running 1 tor onion v2 seednode
Running 3 tor onion v3 seednodes

- nothing to report

/cc bisq-network/compensation#929

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/roles/issues/15#issuecomment-946886989
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211019/66dbed6c/attachment.htm>

From notifications at github.com  Tue Oct 19 18:20:36 2021
From: notifications at github.com (Stephan Oeste)
Date: Tue, 19 Oct 2021 09:20:36 -0700
Subject: [bisq-network/roles] Pricenode Operator (#14)
In-Reply-To: <bisq-network/roles/issues/14@github.com>
References: <bisq-network/roles/issues/14@github.com>
Message-ID: <bisq-network/roles/issues/14/946887350@github.com>

## Cycle 29 report
 
Running 1 instance
- nothing to report

/cc bisq-network/compensation#929

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/roles/issues/14#issuecomment-946887350
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211019/3089cb05/attachment-0001.htm>

From notifications at github.com  Tue Oct 19 18:20:55 2021
From: notifications at github.com (Stephan Oeste)
Date: Tue, 19 Oct 2021 09:20:55 -0700
Subject: [bisq-network/roles] Mailman Operator (#26)
In-Reply-To: <bisq-network/roles/issues/26@github.com>
References: <bisq-network/roles/issues/26@github.com>
Message-ID: <bisq-network/roles/issues/26/946887672@github.com>

## Cycle 29 report
Running the bisq-contrib and bisq-github mailing list server.

- nothing to report

/cc bisq-network/compensation#929

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/roles/issues/26#issuecomment-946887672
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211019/8ef9bb3e/attachment.htm>

From notifications at github.com  Tue Oct 19 18:21:16 2021
From: notifications at github.com (Stephan Oeste)
Date: Tue, 19 Oct 2021 09:21:16 -0700
Subject: [bisq-network/roles] Mempool Explorer Operator (#107)
In-Reply-To: <bisq-network/roles/issues/107@github.com>
References: <bisq-network/roles/issues/107@github.com>
Message-ID: <bisq-network/roles/issues/107/946887983@github.com>

## Cycle 29 report
Running the mempool.emzy.de server.
- update to new version

/cc bisq-network/compensation#929

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/roles/issues/107#issuecomment-946887983
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211019/7c63de2e/attachment.htm>

From notifications at github.com  Tue Oct 19 18:21:48 2021
From: notifications at github.com (Stephan Oeste)
Date: Tue, 19 Oct 2021 09:21:48 -0700
Subject: [bisq-network/roles] Monero Explorer Operator (#109)
In-Reply-To: <bisq-network/roles/issues/109@github.com>
References: <bisq-network/roles/issues/109@github.com>
Message-ID: <bisq-network/roles/issues/109/946888481@github.com>

## Cycle 29 report

Running xmrblocks.monero.emzy.de
- moved to a new host (because of disk space)

/cc bisq-network/compensation#928

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/roles/issues/109#issuecomment-946888481
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211019/02ce4ce6/attachment.htm>

From notifications at github.com  Tue Oct 19 18:23:22 2021
From: notifications at github.com (Stephan Oeste)
Date: Tue, 19 Oct 2021 09:23:22 -0700
Subject: [bisq-network/roles] Monitoring Operator/Maintainer (#10)
In-Reply-To: <bisq-network/roles/issues/10@github.com>
References: <bisq-network/roles/issues/10@github.com>
Message-ID: <bisq-network/roles/issues/10/946889981@github.com>

## Cycle 2 report

Running monitor.bisq.network
- nothing to report

/cc bisq-network/compensation#928

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/roles/issues/10#issuecomment-946889981
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211019/762e70c5/attachment.htm>

From notifications at github.com  Tue Oct 19 18:26:38 2021
From: notifications at github.com (wiz)
Date: Tue, 19 Oct 2021 09:26:38 -0700
Subject: [bisq-network/bisq] Add new v3 onions for wiz's bitcoin nodes (PR
 #5767)
Message-ID: <bisq-network/bisq/pull/5767@github.com>

Request review by @emzy 
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/5767

-- Commit Summary --

  * <a href="https://github.com/bisq-network/bisq/pull/5767/commits/f1f4ef4547572c448f3a7337635b2ee25027e8a5">Add new v3 onions for wiz&#39;s bitcoin nodes</a>

-- File Changes --

    M core/src/main/java/bisq/core/btc/nodes/BtcNodes.java (9)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/5767.patch
https://github.com/bisq-network/bisq/pull/5767.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5767
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211019/132afddd/attachment.htm>

From notifications at github.com  Tue Oct 19 18:33:19 2021
From: notifications at github.com (wiz)
Date: Tue, 19 Oct 2021 09:33:19 -0700
Subject: [bisq-network/bisq] Add new v3 onions for wiz's bitcoin nodes (PR
 #5767)
In-Reply-To: <bisq-network/bisq/pull/5767@github.com>
References: <bisq-network/bisq/pull/5767@github.com>
Message-ID: <bisq-network/bisq/pull/5767/push/8189904568@github.com>

@wiz pushed 1 commit.

f616bc00f17a39a9a2f36c5b2b88a48e12a9de6c  Add new v3 onions for wiz's bitcoin nodes


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/bisq-network/bisq/pull/5767/files/f1f4ef4547572c448f3a7337635b2ee25027e8a5..f616bc00f17a39a9a2f36c5b2b88a48e12a9de6c
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211019/e3c0edc1/attachment-0001.htm>

From notifications at github.com  Tue Oct 19 18:38:51 2021
From: notifications at github.com (Stephan Oeste)
Date: Tue, 19 Oct 2021 09:38:51 -0700
Subject: [bisq-network/bisq] Add new v3 onions for wiz's bitcoin nodes (PR
 #5767)
In-Reply-To: <bisq-network/bisq/pull/5767@github.com>
References: <bisq-network/bisq/pull/5767@github.com>
Message-ID: <bisq-network/bisq/pull/5767/review/783532585@github.com>

@Emzy approved this pull request.

tested ack
Tested the Bitcoin nodes via command line parameter.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5767#pullrequestreview-783532585
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211019/d9dc3ca0/attachment.htm>

From notifications at github.com  Tue Oct 19 18:47:16 2021
From: notifications at github.com (Stephan Oeste)
Date: Tue, 19 Oct 2021 09:47:16 -0700
Subject: [bisq-network/bisq] Add new v3 onions for wiz's bitcoin nodes (PR
 #5767)
In-Reply-To: <bisq-network/bisq/pull/5767@github.com>
References: <bisq-network/bisq/pull/5767@github.com>
Message-ID: <bisq-network/bisq/pull/5767/review/783541381@github.com>

@Emzy approved this pull request.





-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5767#pullrequestreview-783541381
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211019/33698d1f/attachment.htm>

From notifications at github.com  Tue Oct 19 18:52:22 2021
From: notifications at github.com (m52go)
Date: Tue, 19 Oct 2021 09:52:22 -0700
Subject: [bisq-network/bisq] Remove m52go bitcoin node (PR #5768)
Message-ID: <bisq-network/bisq/pull/5768@github.com>

@ripcurlx would be great to get this in 1.7.5 as well, if possible. Already discussed with @wiz.
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/5768

-- Commit Summary --

  * <a href="https://github.com/bisq-network/bisq/pull/5768/commits/cc9238762fa9835cab53ffa93975b96f8047bf5e">Remove m52go bitcoin node</a>

-- File Changes --

    M core/src/main/java/bisq/core/btc/nodes/BtcNodes.java (2)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/5768.patch
https://github.com/bisq-network/bisq/pull/5768.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5768
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211019/79b3bc7e/attachment.htm>

From notifications at github.com  Tue Oct 19 19:30:32 2021
From: notifications at github.com (Christoph Atteneder)
Date: Tue, 19 Oct 2021 10:30:32 -0700
Subject: [bisq-network/bisq] Add new v3 onions for wiz's bitcoin nodes (PR
 #5767)
In-Reply-To: <bisq-network/bisq/pull/5767@github.com>
References: <bisq-network/bisq/pull/5767@github.com>
Message-ID: <bisq-network/bisq/pull/5767/review/783584967@github.com>

@ripcurlx approved this pull request.

utACK - based on https://github.com/bisq-network/bisq/pull/5767#pullrequestreview-783532585



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5767#pullrequestreview-783584967
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211019/4a085247/attachment.htm>

From notifications at github.com  Tue Oct 19 19:30:43 2021
From: notifications at github.com (Christoph Atteneder)
Date: Tue, 19 Oct 2021 10:30:43 -0700
Subject: [bisq-network/bisq] Add new v3 onions for wiz's bitcoin nodes (PR
 #5767)
In-Reply-To: <bisq-network/bisq/pull/5767@github.com>
References: <bisq-network/bisq/pull/5767@github.com>
Message-ID: <bisq-network/bisq/pull/5767/issue_event/5486892359@github.com>

Merged #5767 into master.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5767#event-5486892359
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211019/97754a42/attachment.htm>

From notifications at github.com  Tue Oct 19 19:32:18 2021
From: notifications at github.com (Christoph Atteneder)
Date: Tue, 19 Oct 2021 10:32:18 -0700
Subject: [bisq-network/bisq] Remove m52go bitcoin node (PR #5768)
In-Reply-To: <bisq-network/bisq/pull/5768@github.com>
References: <bisq-network/bisq/pull/5768@github.com>
Message-ID: <bisq-network/bisq/pull/5768/c946945707@github.com>

@m52go there is an error in your commit and you need to resolve now a conflict anyways because of another merge.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5768#issuecomment-946945707
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211019/4b51dcc4/attachment-0001.htm>

From notifications at github.com  Tue Oct 19 20:36:25 2021
From: notifications at github.com (m52go)
Date: Tue, 19 Oct 2021 11:36:25 -0700
Subject: [bisq-network/bisq] Remove m52go bitcoin node (PR #5768)
In-Reply-To: <bisq-network/bisq/pull/5768@github.com>
References: <bisq-network/bisq/pull/5768@github.com>
Message-ID: <bisq-network/bisq/pull/5768/push/8190755906@github.com>

@m52go pushed 1 commit.

4b10ba35c6ea9f74e7c10f50107c8200aa5de53d  Remove m52go bitcoin node


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/bisq-network/bisq/pull/5768/files/cc9238762fa9835cab53ffa93975b96f8047bf5e..4b10ba35c6ea9f74e7c10f50107c8200aa5de53d
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211019/cc7db2d6/attachment.htm>

From notifications at github.com  Tue Oct 19 20:43:23 2021
From: notifications at github.com (m52go)
Date: Tue, 19 Oct 2021 11:43:23 -0700
Subject: [bisq-network/bisq] Remove m52go bitcoin node (PR #5768)
In-Reply-To: <bisq-network/bisq/pull/5768@github.com>
References: <bisq-network/bisq/pull/5768@github.com>
Message-ID: <bisq-network/bisq/pull/5768/c947006623@github.com>

@ripcurlx done.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5768#issuecomment-947006623
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211019/56c78df1/attachment.htm>

From notifications at github.com  Tue Oct 19 21:01:50 2021
From: notifications at github.com (Devin Bileck)
Date: Tue, 19 Oct 2021 12:01:50 -0700
Subject: [bisq-network/compensation] [WIP] For Cycle 29 (Issue #929)
Message-ID: <bisq-network/compensation/issues/929@github.com>

<!--
Compensation requests have a specific format that enables them to be evaluated by a bot for more efficient budgeting. Please make sure you stick to the template. A linter will evaluate your request after you remove [WIP] from the issue title and notify you of any issues.

See the following link for details:
https://bisq.wiki/Making_a_compensation_request

Feel free to browse other requests if you're not sure about something, or reach out in #compensation on Keybase (https://keybase.io/team/bisq).
-->


## Summary

> _Specify the total amount of BSQ you are requesting, along with the USD total and BSQ/USD rate (don't include the brackets!):_

- **BSQ requested**: **`677.42`** <!-- [BSQ amount] should be: USD amount / BSQ rate -->
- USD requested: 1050 <!-- [USD amount] should be: total of all contributions listed in "contributions delivered" table below -->
- BSQ rate: 1.55 USD per BSQ <!-- [rate] should be the rate used to determine the BSQ amount above, as specified in the cycle's rate announcement (https://bisq.wiki/Compensation_Maintainer#Announce_BSQ-USD_rate) -->
- Previous compensation request (if applicable): #907  <!-- Link to last compensation request submitted -->


## Contributions delivered

> _Add contributions you have [delivered](https://github.com/bisq-network/proposals/issues/19) and roles you have performed here as new rows in the table below. Role line-items should include an asterisk (*) in the team column._

| Title | Team | USD | Link | Notes |
| --- | --- | --- | --- | --- |
| Bitcoin node operator | ops* | 150 | https://github.com/bisq-network/roles/issues/67#issuecomment-920348164 | 3 nodes
| Seed node operator | ops* | 400 | https://github.com/bisq-network/roles/issues/15#issuecomment-920348258 | 4 nodes
| Pricenode operator | ops* | 100 | https://github.com/bisq-network/roles/issues/14#issuecomment-920349368
| Relay operator for mobile notifications | ops* | 100 | https://github.com/bisq-network/roles/issues/82#issuecomment-920349467
| Mempool Explorer Operator | ops* | 200 | https://github.com/bisq-network/roles/issues/107#issuecomment-920349522
| Monero Explorer Operator | ops* | 100 | https://github.com/bisq-network/roles/issues/109#issuecomment-920350137

<!-- 

Each contribution should be a new line-item in the table above. 

Title - optional, string.
Team - optional, must one of the following: admin, dev, growth, ops, support (case-insensitive). If the line-item is for a role, please add a `*`. See Example 2 below.
USD - optional, number. Please do not specify 'USD', as the column title makes units clear.
Link - optional, string.
Notes - optional, string.

Example 1 - typical contribution:

| Add local Bitcoin node configuration detection | dev | 240 | https://github.com/bisq-network/bisq/pull/3982

Example 2 - role (note the asterisk):

| Community manager | growth* | 400 | https://github.com/bisq-network/roles/issues/95#issuecomment-628431613

Example 3 - list of minor contributions, such as reviews:

| | | | https://github.com/bisq-network/bisq/pull/3968 | This and PRs below too small to be valued separately. See total at bottom.
| | | | https://github.com/bisq-network/bisq/pull/4040
| | | | https://github.com/bisq-network/bisq/pull/4044
| | | | https://github.com/bisq-network/bisq/pull/4048
| | | | https://github.com/bisq-network/bisq/pull/4066
| | dev | 400 | https://github.com/bisq-network/bisq/pull/4062 | Total for items above.

-->


## Contributions in progress

> _Provide links to work you're involved with that is still [in progress](https://github.com/bisq-network/proposals/issues/19). **This section is optional (the linter ignores it),** and is for your own benefit in keeping track of what you're doing and keeping other contributors up to date with the same._

I have been making progress on the [new mobile client](https://github.com/bisq-network/proposals/issues/342), mostly just on the project planning/management side of things.

**Done:**
- Setup a [repository](https://github.com/bisq-network/bisq-client).
- Built out a [wiki](https://github.com/bisq-network/bisq-client/wiki) with technical details about the project.
- Defined [milestones](https://github.com/bisq-network/bisq-client/milestones?direction=asc&sort=title&state=open).
- Defined [tasks](https://github.com/bisq-network/bisq-client/issues).

**In Progress:**
- I am learning KMM in order to be able to build the [initial project structure](https://github.com/bisq-network/bisq-client/issues/1).

**To Do:**
- Waiting on updates to the UX designs. Some views and workflows are missing. Pedro seems busy, so I reached out to the [Bitcoin design](https://bitcoin.design/) community and am in contact with a product designer that is interested in contributing. He is new to Bisq so currently just getting familiar with it, then hopefully will be able to help out with the designs.
- Trying to find more contributors. Joachim, the developer that implemented the original Bisq app, may be interested/available to help build out the iOS views.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/929
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211019/8b3a11d8/attachment.htm>

From notifications at github.com  Wed Oct 20 06:36:18 2021
From: notifications at github.com (Devin Bileck)
Date: Tue, 19 Oct 2021 21:36:18 -0700
Subject: [bisq-network/roles] Bitcoin Node Operator (#67)
In-Reply-To: <bisq-network/roles/issues/67@github.com>
References: <bisq-network/roles/issues/67@github.com>
Message-ID: <bisq-network/roles/issues/67/947321674@github.com>

## Cycle 29 report

Running 3 instances.
Nothing to report.

/cc [bisq-network/compensation#929](https://github.com/bisq-network/compensation/issues/929)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/roles/issues/67#issuecomment-947321674
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211019/1a828e46/attachment-0001.htm>

From notifications at github.com  Wed Oct 20 06:36:47 2021
From: notifications at github.com (Devin Bileck)
Date: Tue, 19 Oct 2021 21:36:47 -0700
Subject: [bisq-network/roles] Seednode Operator (#15)
In-Reply-To: <bisq-network/roles/issues/15@github.com>
References: <bisq-network/roles/issues/15@github.com>
Message-ID: <bisq-network/roles/issues/15/947321837@github.com>

## Cycle 29 report

Running 4 instances; 3 Tor v3; 1 Tor v2.
Nothing to report.

/cc [bisq-network/compensation#929](https://github.com/bisq-network/compensation/issues/929)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/roles/issues/15#issuecomment-947321837
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211019/49fdb96e/attachment.htm>

From notifications at github.com  Wed Oct 20 06:37:04 2021
From: notifications at github.com (Devin Bileck)
Date: Tue, 19 Oct 2021 21:37:04 -0700
Subject: [bisq-network/roles] Pricenode Operator (#14)
In-Reply-To: <bisq-network/roles/issues/14@github.com>
References: <bisq-network/roles/issues/14@github.com>
Message-ID: <bisq-network/roles/issues/14/947321916@github.com>

## Cycle 29 report

Running 1 instance.
Nothing to report.

/cc [bisq-network/compensation#929](https://github.com/bisq-network/compensation/issues/929)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/roles/issues/14#issuecomment-947321916
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211019/77324f76/attachment.htm>

From notifications at github.com  Wed Oct 20 06:38:20 2021
From: notifications at github.com (Devin Bileck)
Date: Tue, 19 Oct 2021 21:38:20 -0700
Subject: [bisq-network/roles] Relay operator for mobile notifications (#82)
In-Reply-To: <bisq-network/roles/issues/82@github.com>
References: <bisq-network/roles/issues/82@github.com>
Message-ID: <bisq-network/roles/issues/82/947322360@github.com>

## Cycle 29 report

Running 2 instances (Tor v2 and Tor v3).
The Tor v2 relay is still receiving push messages from a few Bisq clients < 1.7.2, so I will continue to leave it running. Although Tor v2 should now be no longer officially supported as of October 15th, I don't mind leaving it running for a while longer as long as people are using it and it still works.

/cc [bisq-network/compensation#929](https://github.com/bisq-network/compensation/issues/929)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/roles/issues/82#issuecomment-947322360
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211019/14e571c9/attachment.htm>

From notifications at github.com  Wed Oct 20 06:38:48 2021
From: notifications at github.com (Devin Bileck)
Date: Tue, 19 Oct 2021 21:38:48 -0700
Subject: [bisq-network/roles] Mempool Explorer Operator (#107)
In-Reply-To: <bisq-network/roles/issues/107@github.com>
References: <bisq-network/roles/issues/107@github.com>
Message-ID: <bisq-network/roles/issues/107/947322557@github.com>

## Cycle 29 report

Running mempool.bisq.services.
I have been frequently updating to latest mempool and Bisq code bases to keep up to date with latest updates.

/cc [bisq-network/compensation#929](https://github.com/bisq-network/compensation/issues/929)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/roles/issues/107#issuecomment-947322557
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211019/e9f0a9c7/attachment.htm>

From notifications at github.com  Wed Oct 20 06:39:01 2021
From: notifications at github.com (Devin Bileck)
Date: Tue, 19 Oct 2021 21:39:01 -0700
Subject: [bisq-network/roles] Monero Explorer Operator (#109)
In-Reply-To: <bisq-network/roles/issues/109@github.com>
References: <bisq-network/roles/issues/109@github.com>
Message-ID: <bisq-network/roles/issues/109/947322631@github.com>

## Cycle 29 report

Running xmrblocks.bisq.services.
Nothing to report.

/cc [bisq-network/compensation#929](https://github.com/bisq-network/compensation/issues/929)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/roles/issues/109#issuecomment-947322631
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211019/14b40823/attachment.htm>

From notifications at github.com  Wed Oct 20 10:29:19 2021
From: notifications at github.com (Christoph Atteneder)
Date: Wed, 20 Oct 2021 01:29:19 -0700
Subject: [bisq-network/bisq] Remove m52go bitcoin node (PR #5768)
In-Reply-To: <bisq-network/bisq/pull/5768@github.com>
References: <bisq-network/bisq/pull/5768@github.com>
Message-ID: <bisq-network/bisq/pull/5768/review/784157629@github.com>

@ripcurlx approved this pull request.

utACK



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5768#pullrequestreview-784157629
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211020/f911e224/attachment.htm>

From notifications at github.com  Wed Oct 20 10:29:26 2021
From: notifications at github.com (Christoph Atteneder)
Date: Wed, 20 Oct 2021 01:29:26 -0700
Subject: [bisq-network/bisq] Remove m52go bitcoin node (PR #5768)
In-Reply-To: <bisq-network/bisq/pull/5768@github.com>
References: <bisq-network/bisq/pull/5768@github.com>
Message-ID: <bisq-network/bisq/pull/5768/issue_event/5490187058@github.com>

Merged #5768 into master.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5768#event-5490187058
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211020/e10b6601/attachment-0001.htm>

From notifications at github.com  Wed Oct 20 11:10:07 2021
From: notifications at github.com (leo816)
Date: Wed, 20 Oct 2021 02:10:07 -0700
Subject: [bisq-network/support] Fee reimbursement for trade 23773143
 (#1009)
In-Reply-To: <bisq-network/support/issues/1009@github.com>
References: <bisq-network/support/issues/1009@github.com>
Message-ID: <bisq-network/support/issue/1009/issue_event/5490437171@github.com>

Closed #1009.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/support/issues/1009#event-5490437171
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211020/da77c1da/attachment.htm>

From notifications at github.com  Wed Oct 20 11:10:07 2021
From: notifications at github.com (leo816)
Date: Wed, 20 Oct 2021 02:10:07 -0700
Subject: [bisq-network/support] Fee reimbursement for trade 23773143
 (#1009)
In-Reply-To: <bisq-network/support/issues/1009@github.com>
References: <bisq-network/support/issues/1009@github.com>
Message-ID: <bisq-network/support/issues/1009/947475734@github.com>

taker fee not found. Reimbursement is not justified. Please contact our support team on keybase if you have any doubts

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/support/issues/1009#issuecomment-947475734
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211020/a9871ee2/attachment.htm>

From notifications at github.com  Wed Oct 20 11:11:55 2021
From: notifications at github.com (leo816)
Date: Wed, 20 Oct 2021 02:11:55 -0700
Subject: [bisq-network/support] Fee reimbursement for trade sb3vly (#1011)
In-Reply-To: <bisq-network/support/issues/1011@github.com>
References: <bisq-network/support/issues/1011@github.com>
Message-ID: <bisq-network/support/issues/1011/947477316@github.com>

taker fee not found. Reimbursement is not justified. Fees were never paid.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/support/issues/1011#issuecomment-947477316
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211020/655073a8/attachment.htm>

From notifications at github.com  Wed Oct 20 11:11:54 2021
From: notifications at github.com (leo816)
Date: Wed, 20 Oct 2021 02:11:54 -0700
Subject: [bisq-network/support] Fee reimbursement for trade sb3vly (#1011)
In-Reply-To: <bisq-network/support/issues/1011@github.com>
References: <bisq-network/support/issues/1011@github.com>
Message-ID: <bisq-network/support/issue/1011/issue_event/5490448394@github.com>

Closed #1011.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/support/issues/1011#event-5490448394
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211020/f96e1919/attachment.htm>

From notifications at github.com  Wed Oct 20 11:40:45 2021
From: notifications at github.com (sqrrm)
Date: Wed, 20 Oct 2021 02:40:45 -0700
Subject: [bisq-network/compensation] For Cycle 29 (Issue #930)
Message-ID: <bisq-network/compensation/issues/930@github.com>

<!--
Compensation requests have a specific format that enables them to be evaluated by a bot for more efficient budgeting. Please make sure you stick to the template. A linter will evaluate your request after you remove [WIP] from the issue title and notify you of any issues.

See the following link for details:
https://bisq.wiki/Making_a_compensation_request

Feel free to browse other requests if you're not sure about something, or reach out in #compensation on Keybase (https://keybase.io/team/bisq).
-->


## Summary

> _Specify the total amount of BSQ you are requesting, along with the USD total and BSQ/USD rate (don't include the brackets!):_

- **BSQ requested**: **`232`** <!-- [BSQ amount] should be: USD amount / BSQ rate -->
- USD requested: 360 <!-- [USD amount] should be: total of all contributions listed in "contributions delivered" table below -->
- BSQ rate: 1.55 USD per BSQ <!-- [rate] should be the rate used to determine the BSQ amount above, as specified in the cycle's rate announcement (https://bisq.wiki/Compensation_Maintainer#Announce_BSQ-USD_rate) -->
- Previous compensation request (if applicable): #916  <!-- Link to last compensation request submitted -->


## Contributions delivered

> _Add contributions you have [delivered](https://github.com/bisq-network/proposals/issues/19) and roles you have performed here as new rows in the table below. Role line-items should include an asterisk (*) in the team column._

| Title | Team | USD | Link | Notes |
| --- | --- | --- | --- | --- |
|Data stores | dev | 50 | https://github.com/bisq-network/bisq/pull/5720 ||
|Release and testing | dev | 130 | https://github.com/bisq-network/bisq/pull/5730 ||
|Bisq desktop maintainer | dev* | 0 |  |  |
|Bitcoin node maintainer | dev* | 50 | link |  |
|Bitcoin node operator | ops* | 100 | link |  |
|Tor relay operator | ops* | 30 | link |  |


<!-- 

Each contribution should be a new line-item in the table above. 

Title - optional, string.
Team - optional, must one of the following: admin, dev, growth, ops, support (case-insensitive). If the line-item is for a role, please add a `*`. See Example 2 below.
USD - optional, number. Please do not specify 'USD', as the column title makes units clear.
Link - optional, string.
Notes - optional, string.

Example 1 - typical contribution:

| Add local Bitcoin node configuration detection | dev | 240 | https://github.com/bisq-network/bisq/pull/3982

Example 2 - role (note the asterisk):

| Community manager | growth* | 400 | https://github.com/bisq-network/roles/issues/95#issuecomment-628431613

Example 3 - list of minor contributions, such as reviews:

| | | | https://github.com/bisq-network/bisq/pull/3968 | This and PRs below too small to be valued separately. See total at bottom.
| | | | https://github.com/bisq-network/bisq/pull/4040
| | | | https://github.com/bisq-network/bisq/pull/4044
| | | | https://github.com/bisq-network/bisq/pull/4048
| | | | https://github.com/bisq-network/bisq/pull/4066
| | dev | 400 | https://github.com/bisq-network/bisq/pull/4062 | Total for items above.

-->


## Contributions in progress

> _Provide links to work you're involved with that is still [in progress](https://github.com/bisq-network/proposals/issues/19). **This section is optional (the linter ignores it),** and is for your own benefit in keeping track of what you're doing and keeping other contributors up to date with the same._

| Title | Team | USD | Link | Notes |
| --- | --- | --- | --- | --- |
| Atomic BSQ trading | dev | ~50000 |  | Bitcoinj bug is fixed and merged upstream. Chimp has been reviewing an fixing quite a few things but we're now ready to merge this to master. |


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/930
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211020/c15fe4fb/attachment-0001.htm>

From notifications at github.com  Wed Oct 20 11:42:51 2021
From: notifications at github.com (sqrrm)
Date: Wed, 20 Oct 2021 02:42:51 -0700
Subject: [bisq-network/roles] Bitcoin Node Maintainer (#66)
In-Reply-To: <bisq-network/roles/issues/66@github.com>
References: <bisq-network/roles/issues/66@github.com>
Message-ID: <bisq-network/roles/issues/66/947502756@github.com>

## Cycle 29 report
Bisq is now on tor v3, I think we can discontinue the v2 addresses for the bitcoin nodes now.

https://github.com/bisq-network/compensation/issues/930

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/roles/issues/66#issuecomment-947502756
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211020/f018ccc1/attachment.htm>

From notifications at github.com  Wed Oct 20 11:43:35 2021
From: notifications at github.com (sqrrm)
Date: Wed, 20 Oct 2021 02:43:35 -0700
Subject: [bisq-network/roles] Bitcoin Node Operator (#67)
In-Reply-To: <bisq-network/roles/issues/67@github.com>
References: <bisq-network/roles/issues/67@github.com>
Message-ID: <bisq-network/roles/issues/67/947503288@github.com>

## Cycle 29 report

Running 2 instances, some monitor complaints for one node but node is running fine

bisq-network/compensation#930

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/roles/issues/67#issuecomment-947503288
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211020/87be5c60/attachment.htm>

From notifications at github.com  Wed Oct 20 11:45:56 2021
From: notifications at github.com (sqrrm)
Date: Wed, 20 Oct 2021 02:45:56 -0700
Subject: [bisq-network/roles] Tor Relay Operator (#72)
In-Reply-To: <bisq-network/roles/issues/72@github.com>
References: <bisq-network/roles/issues/72@github.com>
Message-ID: <bisq-network/roles/issues/72/947504931@github.com>

## Cycle 29 report

4 nodes running, metrics at https://metrics.torproject.org/rs.html#search/sqrrm

Regarding bisqubutor's relays, could we come to some agreement to support some of their nodes? It seems good to support some, although 80+ is a bit much.

bisq-network/compensation#930

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/roles/issues/72#issuecomment-947504931
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211020/0d4a4a04/attachment.htm>

From notifications at github.com  Wed Oct 20 12:02:20 2021
From: notifications at github.com (chimp1984)
Date: Wed, 20 Oct 2021 03:02:20 -0700
Subject: [bisq-network/bisq] Refactorings (non funtional changes) (PR #5769)
Message-ID: <bisq-network/bisq/pull/5769@github.com>

This contains only renaming, moving and increasing visibility (package scope to public) as preparation for the further BSQ swap PRs.  
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/5769

-- Commit Summary --

  * <a href="https://github.com/bisq-network/bisq/pull/5769/commits/8fbccb75479ffcb1e7b1fcc0feed03aa7fc55735">Bump version number for v1.7.5</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5769/commits/e39ae59683f6c45fd741063a364d7ae8366d43c9">Update translations for v1.7.5</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5769/commits/48a0ebe30973915fd80ff778a131d33a8012a616">Add new v3 onions for wiz&#39;s bitcoin nodes</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5769/commits/94d3638d9841c8653a5db40fa5b1c52fa3e3b0e4">Remove m52go bitcoin node</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5769/commits/41d9d3f505516ed34c1f33d86952ef8f4d036d75">Move OfferPayload into package bisq.core.offer.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5769/commits/edf5c3e097094f35e4f25c439416cff196afbf76">Move CreateOfferService into package bisq.core.offer.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5769/commits/4341a7e0d2c5610baa95b09bdb82584b520bc776">Move MarketPriceNotAvailableException into package bisq.core.offer.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5769/commits/042476a68a22ea95eb9faaa84eeed8594a6c3d06">Move MutableOfferPayloadFields into package bisq.core.offer.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5769/commits/d9fd8a45f72d377e2ba04c95df1974aa44e36b87">Move TriggerPriceService into package bisq.core.offer.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5769/commits/e348000cb16923ab1b973ad9aa1bb0d2f616cc16">Move TakeOfferModel into package bisq.core.offer.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5769/commits/a2d1e8888d0c6274121428b86cdd39b32f3d6ba0">Move AvailabilityResult into package bisq.core.offer.availability</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5769/commits/1badd699a4a6a82910701a89c5fbad4115985503">Move bisq.core.offer.messages package into package bisq.core.offer.availability</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5769/commits/7197b316fccd63e2f0b66d27d167ea6cd0452c11">Move content of bisq.core.offer.placeoffer package into package bisq.core.offer.placeoffer.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5769/commits/1b4c4871c0d03e00dbc07571ac120d2a3a9c534d">Rename OfferFilter to OfferFilterService</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5769/commits/1e9b6065441d27873ad962920aed363ed9a25aa0">Move Contract, SellerAsMakerTrade, SellerAsTakerTrade, SellerTrade,</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5769/commits/8b21b85c3e8fd20b8d5c541ee6ad6ee5e099a0c6">Make updateDepositTxFromWallet public</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5769/commits/d42242762ffb448e8ebdda5e311602e6db60f1c7">Move Trade to bisq.core.trade.model.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5769/commits/fc3177c23f06d16eed25408fe7064f5364b2e42f">Move MakerTrade and TakerTrade to bisq.core.trade.model package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5769/commits/58cfcffeb970ffc81d9ba6979eb256892ce00ff2">Move Tradable to bisq.core.trade.model package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5769/commits/3474a2b69520d52af239c79cbaa65135bdc776d5">Move TradableList to bisq.core.trade.model package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5769/commits/d7b2e99e43a404c6121dcbb94a0acaf028037dbe">Make FluentProtocol.Event public</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5769/commits/e3eea6350cb07f3c517e0fc148b4d771fff26afc">Make setup in FluentProtocol public</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5769/commits/1b2e798faaa64fa19a3cd858c99c6af22d38fa99">Move protocol classes to bisq.core.trade.protocol.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5769/commits/508296c2a3b609ab9166d250226271622f430d34">Move tasks package into bisq.core.trade.protocol.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5769/commits/97906e05db34277a96631c4e4eeaef91dd732f04">Move TradingPeer into bisq.core.trade.protocol.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5769/commits/cbf2822cdf422cfca7404a0cb4486f498bc8a171">Move messages package into bisq.core.trade.protocol.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5769/commits/fd6934c4e3f1fd93744343bc7c1f907b7e981f8c">Move ClosedTradableManager, FailedTradesManager into bisq.core.trade.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5769/commits/fe2871baa50c5f196e92458d38bdda53ab9b6d77">Rename CleanupMailboxMessages to CleanupMailboxMessagesService</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5769/commits/e80cdf8ac7217ab0e2025be10e0feaa6dc8a5ee6">Move CleanupMailboxMessagesService, ClosedTradeUtil to package bisq.core.trade.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5769/commits/956ffc902d2258199a07f96adaa91ff98ae2411a">Move TransactionResultHandler, TradeResultHandler to package bisq.core.trade.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5769/commits/eacf446ab422352bb303eb9830b3dc03d9adc8e4">Move TradeDataValidation, DumpDelayedPayoutTx, TradeDataValidation, TradeUtil, TradeTxException to package bisq.core.trade.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5769/commits/e1de502a9bf1aae7e87830096934ac6a1684665d">Rename ProcessModelServiceProvider to Provider</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5769/commits/2733af955a3ec04d4311a18b691415933146b35c">Rename txID to txId</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5769/commits/932c0f856aa36ee87cb55dbb3b4e11992ed2b13c">Move createoffer package inside bisq.desktop.main.offer.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5769/commits/0efa0bd7cad6278faac96edc64f4008061a7998f">Move takeoffer package inside bisq.desktop.main.offer.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5769/commits/601956dc1fe2927549ff7723ef8cd25f16f646ee">Move MutableOffer view classes into bisq.desktop.main.offer.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5769/commits/9777005ec7e44b4efb123e7d5a9c48976bde2a81">Move OfferDataModel, OfferViewUtil into bisq.desktop.main.offer.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5769/commits/4a9db790682506fdda88f6d31f5874fc473dba2e">Rename FeeUtil to OfferViewModelUtil</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5769/commits/25bbad1f9c9f5383d8af6f64cbacdb74df2b1d01">Move OfferViewModelUtil into bisq.desktop.main.offer.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5769/commits/777287af95cfd791389b0cdbf9eecf9b98913496">Cleanups, refromatting, add final qualifier</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5769/commits/401880b64e8f8645e42d6a34179fcc71000c7363">Move TradingPeer to package bisq.core.trade.protocol.bisq_v1.model</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5769/commits/afed78813d3d81c1ca4d63adac6ca0d5cffb1741">Make setPaymentStartedAckMessage and setDepositTxSentAckMessage public</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5769/commits/734d429cc9612709bcee8c0e4784070406daf731">Move ProcessModel to package bisq.core.trade.protocol.bisq_v1.model</a>

-- File Changes --

    M apitest/scripts/trade-simulation-utils.sh (2)
    M apitest/src/test/java/bisq/apitest/method/trade/ExpectedProtocolStatus.java (2)
    M apitest/src/test/java/bisq/apitest/method/trade/TakeBuyBSQOfferTest.java (14)
    M apitest/src/test/java/bisq/apitest/method/trade/TakeBuyBTCOfferTest.java (8)
    M apitest/src/test/java/bisq/apitest/method/trade/TakeBuyBTCOfferWithNationalBankAcctTest.java (8)
    M apitest/src/test/java/bisq/apitest/method/trade/TakeSellBSQOfferTest.java (16)
    M apitest/src/test/java/bisq/apitest/method/trade/TakeSellBTCOfferTest.java (10)
    M build.gradle (2)
    M common/src/main/java/bisq/common/app/Version.java (2)
    M core/src/main/java/bisq/core/account/witness/AccountAgeWitnessService.java (8)
    M core/src/main/java/bisq/core/account/witness/AccountAgeWitnessUtils.java (2)
    M core/src/main/java/bisq/core/api/CoreApi.java (2)
    M core/src/main/java/bisq/core/api/CoreOffersService.java (22)
    M core/src/main/java/bisq/core/api/CoreTradesService.java (16)
    M core/src/main/java/bisq/core/api/CoreWalletsService.java (1)
    M core/src/main/java/bisq/core/api/model/TradeInfo.java (4)
    M core/src/main/java/bisq/core/app/BisqSetup.java (2)
    M core/src/main/java/bisq/core/app/DomainInitialisation.java (6)
    M core/src/main/java/bisq/core/btc/Balances.java (6)
    M core/src/main/java/bisq/core/btc/TxFeeEstimationService.java (8)
    M core/src/main/java/bisq/core/btc/listeners/TxConfidenceListener.java (10)
    M core/src/main/java/bisq/core/btc/nodes/BtcNodes.java (10)
    M core/src/main/java/bisq/core/btc/wallet/TradeWalletService.java (29)
    M core/src/main/java/bisq/core/btc/wallet/WalletService.java (3)
    M core/src/main/java/bisq/core/notifications/alerts/TradeEvents.java (2)
    M core/src/main/java/bisq/core/notifications/alerts/market/MarketAlerts.java (2)
    M core/src/main/java/bisq/core/offer/Offer.java (2)
    M core/src/main/java/bisq/core/offer/OfferBookService.java (1)
    R core/src/main/java/bisq/core/offer/OfferFilterService.java (10)
    M core/src/main/java/bisq/core/offer/OfferForJson.java (1)
    M core/src/main/java/bisq/core/offer/OfferRestrictions.java (2)
    M core/src/main/java/bisq/core/offer/OfferUtil.java (4)
    M core/src/main/java/bisq/core/offer/OpenOffer.java (2)
    M core/src/main/java/bisq/core/offer/OpenOfferManager.java (18)
    R core/src/main/java/bisq/core/offer/availability/AvailabilityResult.java (2)
    M core/src/main/java/bisq/core/offer/availability/OfferAvailabilityModel.java (2)
    M core/src/main/java/bisq/core/offer/availability/OfferAvailabilityProtocol.java (4)
    R core/src/main/java/bisq/core/offer/availability/messages/OfferAvailabilityRequest.java (2)
    R core/src/main/java/bisq/core/offer/availability/messages/OfferAvailabilityResponse.java (4)
    R core/src/main/java/bisq/core/offer/availability/messages/OfferMessage.java (2)
    M core/src/main/java/bisq/core/offer/availability/tasks/ProcessOfferAvailabilityResponse.java (4)
    M core/src/main/java/bisq/core/offer/availability/tasks/SendOfferAvailabilityRequest.java (2)
    R core/src/main/java/bisq/core/offer/bisq_v1/CreateOfferService.java (4)
    R core/src/main/java/bisq/core/offer/bisq_v1/MarketPriceNotAvailableException.java (2)
    R core/src/main/java/bisq/core/offer/bisq_v1/MutableOfferPayloadFields.java (2)
    R core/src/main/java/bisq/core/offer/bisq_v1/OfferPayload.java (2)
    R core/src/main/java/bisq/core/offer/bisq_v1/TakeOfferModel.java (4)
    R core/src/main/java/bisq/core/offer/bisq_v1/TriggerPriceService.java (4)
    R core/src/main/java/bisq/core/offer/placeoffer/bisq_v1/PlaceOfferModel.java (2)
    R core/src/main/java/bisq/core/offer/placeoffer/bisq_v1/PlaceOfferProtocol.java (12)
    R core/src/main/java/bisq/core/offer/placeoffer/bisq_v1/tasks/AddToOfferBook.java (4)
    R core/src/main/java/bisq/core/offer/placeoffer/bisq_v1/tasks/CheckNumberOfUnconfirmedTransactions.java (4)
    R core/src/main/java/bisq/core/offer/placeoffer/bisq_v1/tasks/CreateMakerFeeTx.java (4)
    R core/src/main/java/bisq/core/offer/placeoffer/bisq_v1/tasks/ValidateOffer.java (6)
    M core/src/main/java/bisq/core/proto/ProtoDevUtil.java (8)
    M core/src/main/java/bisq/core/proto/network/CoreNetworkProtoResolver.java (34)
    M core/src/main/java/bisq/core/proto/persistable/CorePersistenceProtoResolver.java (2)
    M core/src/main/java/bisq/core/provider/mempool/MempoolService.java (4)
    M core/src/main/java/bisq/core/setup/CorePersistedDataHost.java (4)
    M core/src/main/java/bisq/core/support/dispute/Dispute.java (2)
    M core/src/main/java/bisq/core/support/dispute/DisputeListService.java (2)
    M core/src/main/java/bisq/core/support/dispute/DisputeManager.java (10)
    M core/src/main/java/bisq/core/support/dispute/agent/MultipleHolderNameDetection.java (2)
    M core/src/main/java/bisq/core/support/dispute/arbitration/ArbitrationManager.java (8)
    M core/src/main/java/bisq/core/support/dispute/mediation/MediationManager.java (8)
    M core/src/main/java/bisq/core/support/dispute/refund/RefundManager.java (4)
    M core/src/main/java/bisq/core/support/traderchat/TradeChatSession.java (4)
    M core/src/main/java/bisq/core/support/traderchat/TraderChatManager.java (6)
    M core/src/main/java/bisq/core/trade/TradeManager.java (41)
    M core/src/main/java/bisq/core/trade/TradeModule.java (4)
    R core/src/main/java/bisq/core/trade/bisq_v1/CleanupMailboxMessagesService.java (10)
    R core/src/main/java/bisq/core/trade/bisq_v1/ClosedTradableManager.java (17)
    R core/src/main/java/bisq/core/trade/bisq_v1/ClosedTradeUtil.java (12)
    R core/src/main/java/bisq/core/trade/bisq_v1/DumpDelayedPayoutTx.java (6)
    R core/src/main/java/bisq/core/trade/bisq_v1/FailedTradesManager.java (17)
    R core/src/main/java/bisq/core/trade/bisq_v1/TradeDataValidation.java (3)
    R core/src/main/java/bisq/core/trade/bisq_v1/TradeResultHandler.java (4)
    R core/src/main/java/bisq/core/trade/bisq_v1/TradeTxException.java (2)
    R core/src/main/java/bisq/core/trade/bisq_v1/TradeUtil.java (4)
    R core/src/main/java/bisq/core/trade/bisq_v1/TransactionResultHandler.java (2)
    R core/src/main/java/bisq/core/trade/model/MakerTrade.java (2)
    R core/src/main/java/bisq/core/trade/model/TakerTrade.java (2)
    R core/src/main/java/bisq/core/trade/model/Tradable.java (2)
    R core/src/main/java/bisq/core/trade/model/TradableList.java (6)
    R core/src/main/java/bisq/core/trade/model/bisq_v1/BuyerAsMakerTrade.java (8)
    R core/src/main/java/bisq/core/trade/model/bisq_v1/BuyerAsTakerTrade.java (8)
    R core/src/main/java/bisq/core/trade/model/bisq_v1/BuyerTrade.java (4)
    R core/src/main/java/bisq/core/trade/model/bisq_v1/Contract.java (4)
    R core/src/main/java/bisq/core/trade/model/bisq_v1/SellerAsMakerTrade.java (8)
    R core/src/main/java/bisq/core/trade/model/bisq_v1/SellerAsTakerTrade.java (8)
    R core/src/main/java/bisq/core/trade/model/bisq_v1/SellerTrade.java (4)
    R core/src/main/java/bisq/core/trade/model/bisq_v1/Trade.java (11)
    M core/src/main/java/bisq/core/trade/protocol/FluentProtocol.java (7)
    R core/src/main/java/bisq/core/trade/protocol/Provider.java (32)
    R core/src/main/java/bisq/core/trade/protocol/TradeMessage.java (2)
    M core/src/main/java/bisq/core/trade/protocol/TradeProtocol.java (10)
    M core/src/main/java/bisq/core/trade/protocol/TradeProtocolFactory.java (14)
    M core/src/main/java/bisq/core/trade/protocol/TradeTaskRunner.java (2)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/BuyerAsMakerProtocol.java (47)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/BuyerAsTakerProtocol.java (50)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/BuyerProtocol.java (40)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/DisputeProtocol.java (41)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/MakerProtocol.java (4)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/SellerAsMakerProtocol.java (49)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/SellerAsTakerProtocol.java (40)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/SellerProtocol.java (44)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/TakerProtocol.java (4)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/messages/CounterCurrencyTransferStartedMessage.java (2)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/messages/DelayedPayoutTxSignatureRequest.java (4)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/messages/DelayedPayoutTxSignatureResponse.java (4)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/messages/DepositTxAndDelayedPayoutTxMessage.java (2)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/messages/DepositTxMessage.java (4)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/messages/InputsForDepositTxRequest.java (3)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/messages/InputsForDepositTxResponse.java (3)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/messages/MediatedPayoutTxPublishedMessage.java (2)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/messages/MediatedPayoutTxSignatureMessage.java (2)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/messages/PayoutTxPublishedMessage.java (2)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/messages/PeerPublishedDelayedPayoutTxMessage.java (2)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/messages/RefreshTradeStateRequest.java (2)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/messages/ShareBuyerPaymentAccountMessage.java (2)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/messages/TradeMailboxMessage.java (4)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/messages/TraderSignedWitnessMessage.java (2)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/model/ProcessModel.java (19)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/model/TradingPeer.java (2)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/ApplyFilter.java (4)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/BroadcastPayoutTx.java (4)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/ProcessPeerPublishedDelayedPayoutTxMessage.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/SendMailboxMessageTask.java (8)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/SetupPayoutTxListener.java (4)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/TradeTask.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/VerifyPeersAccountAgeWitness.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/arbitration/PublishedDelayedPayoutTx.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/arbitration/SendPeerPublishedDelayedPayoutTxMessage.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer/BuyerFinalizesDelayedPayoutTx.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer/BuyerProcessDelayedPayoutTxSignatureRequest.java (8)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer/BuyerProcessDepositTxAndDelayedPayoutTxMessage.java (12)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer/BuyerProcessPayoutTxPublishedMessage.java (9)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer/BuyerSendCounterCurrencyTransferStartedMessage.java (12)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer/BuyerSendsDelayedPayoutTxSignatureResponse.java (8)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer/BuyerSendsShareBuyerPaymentAccountMessage.java (12)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer/BuyerSetupDepositTxListener.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer/BuyerSetupPayoutTxListener.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer/BuyerSignPayoutTx.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer/BuyerSignsDelayedPayoutTx.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer/BuyerVerifiesFinalDelayedPayoutTx.java (8)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer/BuyerVerifiesPreparedDelayedPayoutTx.java (8)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer_as_maker/BuyerAsMakerCreatesAndSignsDepositTx.java (8)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer_as_maker/BuyerAsMakerSendsInputsForDepositTxResponse.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer_as_taker/BuyerAsTakerCreatesDepositTxInputs.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer_as_taker/BuyerAsTakerSendsDepositTxMessage.java (8)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer_as_taker/BuyerAsTakerSignsDepositTx.java (8)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/maker/MakerCreateAndSignContract.java (14)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/maker/MakerProcessesInputsForDepositTxRequest.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/maker/MakerRemovesOpenOffer.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/maker/MakerSendsInputsForDepositTxResponse.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/maker/MakerSetsLockTime.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/maker/MakerVerifyTakerFeePayment.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/mediation/BroadcastMediatedPayoutTx.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/mediation/FinalizeMediatedPayoutTx.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/mediation/ProcessMediatedPayoutSignatureMessage.java (8)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/mediation/ProcessMediatedPayoutTxPublishedMessage.java (9)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/mediation/SendMediatedPayoutSignatureMessage.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/mediation/SendMediatedPayoutTxPublishedMessage.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/mediation/SetupMediatedPayoutTxListener.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/mediation/SignMediatedPayoutTx.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller/SellerBroadcastPayoutTx.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller/SellerCreatesDelayedPayoutTx.java (8)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller/SellerFinalizesDelayedPayoutTx.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller/SellerProcessCounterCurrencyTransferStartedMessage.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller/SellerProcessDelayedPayoutTxSignatureResponse.java (8)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller/SellerProcessShareBuyerPaymentAccountMessage.java (12)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller/SellerPublishesDepositTx.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller/SellerPublishesTradeStatistics.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller/SellerSendDelayedPayoutTxSignatureRequest.java (8)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller/SellerSendPayoutTxPublishedMessage.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller/SellerSendsDepositTxAndDelayedPayoutTxMessage.java (12)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller/SellerSignAndFinalizePayoutTx.java (8)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller/SellerSignsDelayedPayoutTx.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller_as_maker/SellerAsMakerCreatesUnsignedDepositTx.java (8)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller_as_maker/SellerAsMakerFinalizesDepositTx.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller_as_maker/SellerAsMakerProcessDepositTxMessage.java (8)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller_as_maker/SellerAsMakerSendsInputsForDepositTxResponse.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller_as_taker/SellerAsTakerCreatesDepositTxInputs.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller_as_taker/SellerAsTakerSignsDepositTx.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/taker/CreateTakerFeeTx.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/taker/TakerProcessesInputsForDepositTxResponse.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/taker/TakerPublishFeeTx.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/taker/TakerSendInputsForDepositTxRequest.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/taker/TakerVerifyAndSignContract.java (14)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/taker/TakerVerifyMakerFeePayment.java (6)
    M core/src/main/java/bisq/core/trade/statistics/TradeStatistics2.java (4)
    M core/src/main/java/bisq/core/trade/statistics/TradeStatistics3.java (4)
    M core/src/main/java/bisq/core/trade/statistics/TradeStatisticsManager.java (4)
    M core/src/main/java/bisq/core/trade/txproof/xmr/XmrTxProofModel.java (4)
    M core/src/main/java/bisq/core/trade/txproof/xmr/XmrTxProofRequestsPerTrade.java (2)
    M core/src/main/java/bisq/core/trade/txproof/xmr/XmrTxProofService.java (10)
    M core/src/main/java/bisq/core/util/Validator.java (2)
    M core/src/main/resources/i18n/displayStrings_cs.properties (215)
    M core/src/main/resources/i18n/displayStrings_de.properties (167)
    M core/src/main/resources/i18n/displayStrings_es.properties (137)
    M core/src/main/resources/i18n/displayStrings_fa.properties (137)
    M core/src/main/resources/i18n/displayStrings_fr.properties (137)
    M core/src/main/resources/i18n/displayStrings_it.properties (139)
    M core/src/main/resources/i18n/displayStrings_ja.properties (137)
    M core/src/main/resources/i18n/displayStrings_pt-br.properties (141)
    M core/src/main/resources/i18n/displayStrings_pt.properties (141)
    M core/src/main/resources/i18n/displayStrings_ru.properties (137)
    M core/src/main/resources/i18n/displayStrings_th.properties (137)
    M core/src/main/resources/i18n/displayStrings_vi.properties (157)
    M core/src/main/resources/i18n/displayStrings_zh-hans.properties (151)
    M core/src/main/resources/i18n/displayStrings_zh-hant.properties (137)
    M core/src/test/java/bisq/core/account/witness/AccountAgeWitnessServiceTest.java (4)
    M core/src/test/java/bisq/core/offer/OfferMaker.java (2)
    M core/src/test/java/bisq/core/offer/OfferTest.java (2)
    M core/src/test/java/bisq/core/offer/OpenOfferManagerTest.java (3)
    M core/src/test/java/bisq/core/trade/TradableListTest.java (3)
    M daemon/src/main/java/bisq/daemon/grpc/GrpcErrorMessageHandler.java (2)
    M daemon/src/main/java/bisq/daemon/grpc/GrpcTradesService.java (2)
    M desktop/package/linux/Dockerfile (2)
    M desktop/package/macosx/Info.plist (4)
    M desktop/package/macosx/copy_dbs.sh (2)
    M desktop/package/macosx/finalize.sh (2)
    M desktop/package/macosx/replace_version_number.sh (4)
    M desktop/src/main/java/bisq/desktop/components/PeerInfoIcon.java (2)
    M desktop/src/main/java/bisq/desktop/components/PeerInfoIconSmall.java (2)
    M desktop/src/main/java/bisq/desktop/components/PeerInfoIconTrading.java (7)
    M desktop/src/main/java/bisq/desktop/components/paymentmethods/PaymentMethodForm.java (2)
    M desktop/src/main/java/bisq/desktop/components/paymentmethods/SwiftForm.java (3)
    M desktop/src/main/java/bisq/desktop/main/PriceUtil.java (2)
    M desktop/src/main/java/bisq/desktop/main/dao/bonding/reputation/MyReputationView.java (2)
    M desktop/src/main/java/bisq/desktop/main/debug/DebugView.java (100)
    M desktop/src/main/java/bisq/desktop/main/funds/locked/LockedListItem.java (2)
    M desktop/src/main/java/bisq/desktop/main/funds/locked/LockedView.java (4)
    M desktop/src/main/java/bisq/desktop/main/funds/reserved/ReservedView.java (4)
    M desktop/src/main/java/bisq/desktop/main/funds/transactions/DisplayedTransactions.java (2)
    M desktop/src/main/java/bisq/desktop/main/funds/transactions/DummyTransactionAwareTradable.java (2)
    M desktop/src/main/java/bisq/desktop/main/funds/transactions/TradableRepository.java (6)
    M desktop/src/main/java/bisq/desktop/main/funds/transactions/TransactionAwareOpenOffer.java (2)
    M desktop/src/main/java/bisq/desktop/main/funds/transactions/TransactionAwareTradable.java (2)
    M desktop/src/main/java/bisq/desktop/main/funds/transactions/TransactionAwareTradableFactory.java (4)
    M desktop/src/main/java/bisq/desktop/main/funds/transactions/TransactionAwareTrade.java (6)
    M desktop/src/main/java/bisq/desktop/main/funds/transactions/TransactionsListItem.java (4)
    M desktop/src/main/java/bisq/desktop/main/funds/transactions/TransactionsView.java (4)
    M desktop/src/main/java/bisq/desktop/main/funds/withdrawal/WithdrawalView.java (2)
    M desktop/src/main/java/bisq/desktop/main/market/MarketView.java (2)
    M desktop/src/main/java/bisq/desktop/main/market/offerbook/OfferBookChartView.java (2)
    M desktop/src/main/java/bisq/desktop/main/market/offerbook/OfferBookChartViewModel.java (2)
    M desktop/src/main/java/bisq/desktop/main/market/spread/SpreadViewModel.java (2)
    M desktop/src/main/java/bisq/desktop/main/offer/BuyOfferView.java (2)
    M desktop/src/main/java/bisq/desktop/main/offer/OfferView.java (6)
    M desktop/src/main/java/bisq/desktop/main/offer/SellOfferView.java (2)
    R desktop/src/main/java/bisq/desktop/main/offer/bisq_v1/MutableOfferDataModel.java (8)
    R desktop/src/main/java/bisq/desktop/main/offer/bisq_v1/MutableOfferView.java (5)
    R desktop/src/main/java/bisq/desktop/main/offer/bisq_v1/MutableOfferViewModel.java (22)
    R desktop/src/main/java/bisq/desktop/main/offer/bisq_v1/OfferDataModel.java (2)
    R desktop/src/main/java/bisq/desktop/main/offer/bisq_v1/OfferViewModelUtil.java (11)
    R desktop/src/main/java/bisq/desktop/main/offer/bisq_v1/OfferViewUtil.java (2)
    R desktop/src/main/java/bisq/desktop/main/offer/bisq_v1/createoffer/CreateOfferDataModel.java (6)
    R desktop/src/main/java/bisq/desktop/main/offer/bisq_v1/createoffer/CreateOfferView.fxml (2)
    R desktop/src/main/java/bisq/desktop/main/offer/bisq_v1/createoffer/CreateOfferView.java (4)
    R desktop/src/main/java/bisq/desktop/main/offer/bisq_v1/createoffer/CreateOfferViewModel.java (4)
    R desktop/src/main/java/bisq/desktop/main/offer/bisq_v1/takeoffer/TakeOfferDataModel.java (8)
    R desktop/src/main/java/bisq/desktop/main/offer/bisq_v1/takeoffer/TakeOfferView.fxml (2)
    R desktop/src/main/java/bisq/desktop/main/offer/bisq_v1/takeoffer/TakeOfferView.java (6)
    R desktop/src/main/java/bisq/desktop/main/offer/bisq_v1/takeoffer/TakeOfferViewModel.java (26)
    M desktop/src/main/java/bisq/desktop/main/offer/offerbook/OfferBook.java (2)
    M desktop/src/main/java/bisq/desktop/main/offer/offerbook/OfferBookView.java (12)
    M desktop/src/main/java/bisq/desktop/main/offer/offerbook/OfferBookViewModel.java (18)
    M desktop/src/main/java/bisq/desktop/main/overlays/editor/PeerInfoWithTagEditor.java (2)
    M desktop/src/main/java/bisq/desktop/main/overlays/notifications/NotificationCenter.java (8)
    M desktop/src/main/java/bisq/desktop/main/overlays/windows/ContractWindow.java (2)
    M desktop/src/main/java/bisq/desktop/main/overlays/windows/DisputeSummaryWindow.java (4)
    M desktop/src/main/java/bisq/desktop/main/overlays/windows/OfferDetailsWindow.java (2)
    M desktop/src/main/java/bisq/desktop/main/overlays/windows/SwiftPaymentDetails.java (2)
    M desktop/src/main/java/bisq/desktop/main/overlays/windows/TradeDetailsWindow.java (4)
    M desktop/src/main/java/bisq/desktop/main/portfolio/PortfolioView.java (6)
    M desktop/src/main/java/bisq/desktop/main/portfolio/closedtrades/ClosedTradableListItem.java (2)
    M desktop/src/main/java/bisq/desktop/main/portfolio/closedtrades/ClosedTradesDataModel.java (8)
    M desktop/src/main/java/bisq/desktop/main/portfolio/closedtrades/ClosedTradesView.java (8)
    M desktop/src/main/java/bisq/desktop/main/portfolio/closedtrades/ClosedTradesViewModel.java (4)
    M desktop/src/main/java/bisq/desktop/main/portfolio/duplicateoffer/DuplicateOfferDataModel.java (4)
    M desktop/src/main/java/bisq/desktop/main/portfolio/duplicateoffer/DuplicateOfferView.java (4)
    M desktop/src/main/java/bisq/desktop/main/portfolio/duplicateoffer/DuplicateOfferViewModel.java (4)
    M desktop/src/main/java/bisq/desktop/main/portfolio/editoffer/EditOfferDataModel.java (8)
    M desktop/src/main/java/bisq/desktop/main/portfolio/editoffer/EditOfferView.java (2)
    M desktop/src/main/java/bisq/desktop/main/portfolio/editoffer/EditOfferViewModel.java (2)
    M desktop/src/main/java/bisq/desktop/main/portfolio/failedtrades/FailedTradesDataModel.java (6)
    M desktop/src/main/java/bisq/desktop/main/portfolio/failedtrades/FailedTradesListItem.java (2)
    M desktop/src/main/java/bisq/desktop/main/portfolio/failedtrades/FailedTradesView.java (4)
    M desktop/src/main/java/bisq/desktop/main/portfolio/openoffer/OpenOffersDataModel.java (4)
    M desktop/src/main/java/bisq/desktop/main/portfolio/openoffer/OpenOffersView.java (2)
    M desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/PendingTradesDataModel.java (16)
    M desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/PendingTradesListItem.java (2)
    M desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/PendingTradesView.java (6)
    M desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/PendingTradesViewModel.java (8)
    M desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/TradeStepInfo.java (2)
    M desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/TradeSubView.java (2)
    M desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/steps/TradeStepView.java (4)
    M desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/steps/buyer/BuyerStep1View.java (2)
    M desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/steps/buyer/BuyerStep2View.java (4)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/5769.patch
https://github.com/bisq-network/bisq/pull/5769.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5769
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211020/b8b1412d/attachment-0001.htm>

From notifications at github.com  Wed Oct 20 12:21:22 2021
From: notifications at github.com (chimp1984)
Date: Wed, 20 Oct 2021 03:21:22 -0700
Subject: [bisq-network/bisq] Refactorings (non funtional changes) (PR
 #5769)
In-Reply-To: <bisq-network/bisq/pull/5769@github.com>
References: <bisq-network/bisq/pull/5769@github.com>
Message-ID: <bisq-network/bisq/pull/5769/push/8195845334@github.com>

@chimp1984 pushed 1 commit.

dca0c93f477f66da22f6eeba2532fffb844dde90  Cleanups


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/bisq-network/bisq/pull/5769/files/734d429cc9612709bcee8c0e4784070406daf731..dca0c93f477f66da22f6eeba2532fffb844dde90
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211020/035fe17c/attachment.htm>

From notifications at github.com  Wed Oct 20 14:19:51 2021
From: notifications at github.com (chimp1984)
Date: Wed, 20 Oct 2021 05:19:51 -0700
Subject: [bisq-network/bisq] BSQ swap low risk refactorings (PR #5770)
Message-ID: <bisq-network/bisq/pull/5770@github.com>

Based on https://github.com/bisq-network/bisq/pull/5769

Contains low risk but potential functional changes as preparation for BSQ swap PR.
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/5770

-- Commit Summary --

  * <a href="https://github.com/bisq-network/bisq/pull/5770/commits/8fbccb75479ffcb1e7b1fcc0feed03aa7fc55735">Bump version number for v1.7.5</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5770/commits/e39ae59683f6c45fd741063a364d7ae8366d43c9">Update translations for v1.7.5</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5770/commits/48a0ebe30973915fd80ff778a131d33a8012a616">Add new v3 onions for wiz&#39;s bitcoin nodes</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5770/commits/94d3638d9841c8653a5db40fa5b1c52fa3e3b0e4">Remove m52go bitcoin node</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5770/commits/41d9d3f505516ed34c1f33d86952ef8f4d036d75">Move OfferPayload into package bisq.core.offer.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5770/commits/edf5c3e097094f35e4f25c439416cff196afbf76">Move CreateOfferService into package bisq.core.offer.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5770/commits/4341a7e0d2c5610baa95b09bdb82584b520bc776">Move MarketPriceNotAvailableException into package bisq.core.offer.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5770/commits/042476a68a22ea95eb9faaa84eeed8594a6c3d06">Move MutableOfferPayloadFields into package bisq.core.offer.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5770/commits/d9fd8a45f72d377e2ba04c95df1974aa44e36b87">Move TriggerPriceService into package bisq.core.offer.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5770/commits/e348000cb16923ab1b973ad9aa1bb0d2f616cc16">Move TakeOfferModel into package bisq.core.offer.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5770/commits/a2d1e8888d0c6274121428b86cdd39b32f3d6ba0">Move AvailabilityResult into package bisq.core.offer.availability</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5770/commits/1badd699a4a6a82910701a89c5fbad4115985503">Move bisq.core.offer.messages package into package bisq.core.offer.availability</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5770/commits/7197b316fccd63e2f0b66d27d167ea6cd0452c11">Move content of bisq.core.offer.placeoffer package into package bisq.core.offer.placeoffer.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5770/commits/1b4c4871c0d03e00dbc07571ac120d2a3a9c534d">Rename OfferFilter to OfferFilterService</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5770/commits/1e9b6065441d27873ad962920aed363ed9a25aa0">Move Contract, SellerAsMakerTrade, SellerAsTakerTrade, SellerTrade,</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5770/commits/8b21b85c3e8fd20b8d5c541ee6ad6ee5e099a0c6">Make updateDepositTxFromWallet public</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5770/commits/d42242762ffb448e8ebdda5e311602e6db60f1c7">Move Trade to bisq.core.trade.model.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5770/commits/fc3177c23f06d16eed25408fe7064f5364b2e42f">Move MakerTrade and TakerTrade to bisq.core.trade.model package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5770/commits/58cfcffeb970ffc81d9ba6979eb256892ce00ff2">Move Tradable to bisq.core.trade.model package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5770/commits/3474a2b69520d52af239c79cbaa65135bdc776d5">Move TradableList to bisq.core.trade.model package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5770/commits/d7b2e99e43a404c6121dcbb94a0acaf028037dbe">Make FluentProtocol.Event public</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5770/commits/e3eea6350cb07f3c517e0fc148b4d771fff26afc">Make setup in FluentProtocol public</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5770/commits/1b2e798faaa64fa19a3cd858c99c6af22d38fa99">Move protocol classes to bisq.core.trade.protocol.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5770/commits/508296c2a3b609ab9166d250226271622f430d34">Move tasks package into bisq.core.trade.protocol.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5770/commits/97906e05db34277a96631c4e4eeaef91dd732f04">Move TradingPeer into bisq.core.trade.protocol.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5770/commits/cbf2822cdf422cfca7404a0cb4486f498bc8a171">Move messages package into bisq.core.trade.protocol.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5770/commits/fd6934c4e3f1fd93744343bc7c1f907b7e981f8c">Move ClosedTradableManager, FailedTradesManager into bisq.core.trade.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5770/commits/fe2871baa50c5f196e92458d38bdda53ab9b6d77">Rename CleanupMailboxMessages to CleanupMailboxMessagesService</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5770/commits/e80cdf8ac7217ab0e2025be10e0feaa6dc8a5ee6">Move CleanupMailboxMessagesService, ClosedTradeUtil to package bisq.core.trade.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5770/commits/956ffc902d2258199a07f96adaa91ff98ae2411a">Move TransactionResultHandler, TradeResultHandler to package bisq.core.trade.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5770/commits/eacf446ab422352bb303eb9830b3dc03d9adc8e4">Move TradeDataValidation, DumpDelayedPayoutTx, TradeDataValidation, TradeUtil, TradeTxException to package bisq.core.trade.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5770/commits/e1de502a9bf1aae7e87830096934ac6a1684665d">Rename ProcessModelServiceProvider to Provider</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5770/commits/2733af955a3ec04d4311a18b691415933146b35c">Rename txID to txId</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5770/commits/932c0f856aa36ee87cb55dbb3b4e11992ed2b13c">Move createoffer package inside bisq.desktop.main.offer.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5770/commits/0efa0bd7cad6278faac96edc64f4008061a7998f">Move takeoffer package inside bisq.desktop.main.offer.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5770/commits/601956dc1fe2927549ff7723ef8cd25f16f646ee">Move MutableOffer view classes into bisq.desktop.main.offer.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5770/commits/9777005ec7e44b4efb123e7d5a9c48976bde2a81">Move OfferDataModel, OfferViewUtil into bisq.desktop.main.offer.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5770/commits/4a9db790682506fdda88f6d31f5874fc473dba2e">Rename FeeUtil to OfferViewModelUtil</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5770/commits/25bbad1f9c9f5383d8af6f64cbacdb74df2b1d01">Move OfferViewModelUtil into bisq.desktop.main.offer.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5770/commits/777287af95cfd791389b0cdbf9eecf9b98913496">Cleanups, refromatting, add final qualifier</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5770/commits/401880b64e8f8645e42d6a34179fcc71000c7363">Move TradingPeer to package bisq.core.trade.protocol.bisq_v1.model</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5770/commits/afed78813d3d81c1ca4d63adac6ca0d5cffb1741">Make setPaymentStartedAckMessage and setDepositTxSentAckMessage public</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5770/commits/734d429cc9612709bcee8c0e4784070406daf731">Move ProcessModel to package bisq.core.trade.protocol.bisq_v1.model</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5770/commits/dca0c93f477f66da22f6eeba2532fffb844dde90">Cleanups</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5770/commits/e75296557739f6b8ae86bd3004781fd268036a9e">Add linebreak in error popup</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5770/commits/9f3034e91c83559c5a37b7c235c0c997a0e84042">Fix layout/text issues</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5770/commits/dc82fbabab24ab385b085afdfe0ef88c62849970">Increase visibility</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5770/commits/8768345b74148ab49f57cefef9952bb2ad5667be">Remove Inject annotation at abstract classes</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5770/commits/d1d1706a7f05539b930db6437f20b6934576515e">Add delegate methods to offer</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5770/commits/dfbc746d5b4dc3fd4c115adb34498089e744918d">Move Offer.Direction one level up and rename to OfferDirection</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5770/commits/6cf0a7c126fb2bf43ca004bb139b5b856ad1d67e">Rename paymentMethod.isAsset to paymentMethod.isBlockchain</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5770/commits/dad19ba1c174087e3f29f66577739409e32bc544">Add isFiat and isAltcoin methods.</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5770/commits/88198be7ffbfe00854207e3f9e6e907ffd7581b2">Rename availableConfirmedBalance to availableBalance</a>

-- File Changes --

    M apitest/scripts/trade-simulation-utils.sh (2)
    M apitest/src/test/java/bisq/apitest/method/trade/ExpectedProtocolStatus.java (2)
    M apitest/src/test/java/bisq/apitest/method/trade/TakeBuyBSQOfferTest.java (14)
    M apitest/src/test/java/bisq/apitest/method/trade/TakeBuyBTCOfferTest.java (8)
    M apitest/src/test/java/bisq/apitest/method/trade/TakeBuyBTCOfferWithNationalBankAcctTest.java (8)
    M apitest/src/test/java/bisq/apitest/method/trade/TakeSellBSQOfferTest.java (16)
    M apitest/src/test/java/bisq/apitest/method/trade/TakeSellBTCOfferTest.java (10)
    M apitest/src/test/java/bisq/apitest/method/wallet/BsqWalletTest.java (6)
    M apitest/src/test/java/bisq/apitest/method/wallet/WalletTestUtil.java (6)
    M build.gradle (2)
    M common/src/main/java/bisq/common/app/Version.java (2)
    M core/src/main/java/bisq/core/account/witness/AccountAgeWitnessService.java (18)
    M core/src/main/java/bisq/core/account/witness/AccountAgeWitnessUtils.java (2)
    M core/src/main/java/bisq/core/api/CoreApi.java (2)
    M core/src/main/java/bisq/core/api/CoreOffersService.java (46)
    M core/src/main/java/bisq/core/api/CorePaymentAccountsService.java (4)
    M core/src/main/java/bisq/core/api/CoreTradesService.java (16)
    M core/src/main/java/bisq/core/api/CoreWalletsService.java (5)
    M core/src/main/java/bisq/core/api/model/BsqBalanceInfo.java (16)
    M core/src/main/java/bisq/core/api/model/OfferInfo.java (4)
    M core/src/main/java/bisq/core/api/model/TradeInfo.java (4)
    M core/src/main/java/bisq/core/app/BisqSetup.java (2)
    M core/src/main/java/bisq/core/app/DomainInitialisation.java (6)
    M core/src/main/java/bisq/core/btc/Balances.java (6)
    M core/src/main/java/bisq/core/btc/TxFeeEstimationService.java (8)
    M core/src/main/java/bisq/core/btc/listeners/BsqBalanceListener.java (2)
    M core/src/main/java/bisq/core/btc/listeners/TxConfidenceListener.java (10)
    M core/src/main/java/bisq/core/btc/nodes/BtcNodes.java (10)
    M core/src/main/java/bisq/core/btc/wallet/BsqWalletService.java (10)
    M core/src/main/java/bisq/core/btc/wallet/TradeWalletService.java (29)
    M core/src/main/java/bisq/core/btc/wallet/WalletService.java (7)
    M core/src/main/java/bisq/core/notifications/alerts/TradeEvents.java (2)
    M core/src/main/java/bisq/core/notifications/alerts/market/MarketAlerts.java (6)
    M core/src/main/java/bisq/core/offer/Offer.java (59)
    M core/src/main/java/bisq/core/offer/OfferBookService.java (1)
    R core/src/main/java/bisq/core/offer/OfferFilterService.java (10)
    M core/src/main/java/bisq/core/offer/OfferForJson.java (9)
    M core/src/main/java/bisq/core/offer/OfferRestrictions.java (4)
    M core/src/main/java/bisq/core/offer/OfferUtil.java (25)
    M core/src/main/java/bisq/core/offer/OpenOffer.java (11)
    M core/src/main/java/bisq/core/offer/OpenOfferManager.java (34)
    R core/src/main/java/bisq/core/offer/availability/AvailabilityResult.java (2)
    M core/src/main/java/bisq/core/offer/availability/OfferAvailabilityModel.java (2)
    M core/src/main/java/bisq/core/offer/availability/OfferAvailabilityProtocol.java (4)
    R core/src/main/java/bisq/core/offer/availability/messages/OfferAvailabilityRequest.java (2)
    R core/src/main/java/bisq/core/offer/availability/messages/OfferAvailabilityResponse.java (4)
    R core/src/main/java/bisq/core/offer/availability/messages/OfferMessage.java (2)
    M core/src/main/java/bisq/core/offer/availability/tasks/ProcessOfferAvailabilityResponse.java (4)
    M core/src/main/java/bisq/core/offer/availability/tasks/SendOfferAvailabilityRequest.java (2)
    R core/src/main/java/bisq/core/offer/bisq_v1/CreateOfferService.java (14)
    R core/src/main/java/bisq/core/offer/bisq_v1/MarketPriceNotAvailableException.java (2)
    R core/src/main/java/bisq/core/offer/bisq_v1/MutableOfferPayloadFields.java (2)
    A core/src/main/java/bisq/core/offer/bisq_v1/OfferDirection.java (33)
    R core/src/main/java/bisq/core/offer/bisq_v1/OfferPayload.java (23)
    R core/src/main/java/bisq/core/offer/bisq_v1/TakeOfferModel.java (4)
    R core/src/main/java/bisq/core/offer/bisq_v1/TriggerPriceService.java (8)
    R core/src/main/java/bisq/core/offer/placeoffer/bisq_v1/PlaceOfferModel.java (2)
    R core/src/main/java/bisq/core/offer/placeoffer/bisq_v1/PlaceOfferProtocol.java (12)
    R core/src/main/java/bisq/core/offer/placeoffer/bisq_v1/tasks/AddToOfferBook.java (4)
    R core/src/main/java/bisq/core/offer/placeoffer/bisq_v1/tasks/CheckNumberOfUnconfirmedTransactions.java (4)
    R core/src/main/java/bisq/core/offer/placeoffer/bisq_v1/tasks/CreateMakerFeeTx.java (4)
    R core/src/main/java/bisq/core/offer/placeoffer/bisq_v1/tasks/ValidateOffer.java (6)
    M core/src/main/java/bisq/core/payment/payload/PaymentMethod.java (11)
    M core/src/main/java/bisq/core/proto/ProtoDevUtil.java (12)
    M core/src/main/java/bisq/core/proto/network/CoreNetworkProtoResolver.java (34)
    M core/src/main/java/bisq/core/proto/persistable/CorePersistenceProtoResolver.java (2)
    M core/src/main/java/bisq/core/provider/mempool/MempoolService.java (4)
    M core/src/main/java/bisq/core/setup/CorePersistedDataHost.java (4)
    M core/src/main/java/bisq/core/support/dispute/Dispute.java (2)
    M core/src/main/java/bisq/core/support/dispute/DisputeListService.java (2)
    M core/src/main/java/bisq/core/support/dispute/DisputeManager.java (10)
    M core/src/main/java/bisq/core/support/dispute/agent/MultipleHolderNameDetection.java (2)
    M core/src/main/java/bisq/core/support/dispute/arbitration/ArbitrationManager.java (8)
    M core/src/main/java/bisq/core/support/dispute/mediation/MediationManager.java (8)
    M core/src/main/java/bisq/core/support/dispute/refund/RefundManager.java (4)
    M core/src/main/java/bisq/core/support/traderchat/TradeChatSession.java (4)
    M core/src/main/java/bisq/core/support/traderchat/TraderChatManager.java (6)
    M core/src/main/java/bisq/core/trade/TradeManager.java (43)
    M core/src/main/java/bisq/core/trade/TradeModule.java (4)
    R core/src/main/java/bisq/core/trade/bisq_v1/CleanupMailboxMessagesService.java (10)
    R core/src/main/java/bisq/core/trade/bisq_v1/ClosedTradableManager.java (17)
    R core/src/main/java/bisq/core/trade/bisq_v1/ClosedTradeUtil.java (12)
    R core/src/main/java/bisq/core/trade/bisq_v1/DumpDelayedPayoutTx.java (6)
    R core/src/main/java/bisq/core/trade/bisq_v1/FailedTradesManager.java (17)
    R core/src/main/java/bisq/core/trade/bisq_v1/TradeDataValidation.java (3)
    R core/src/main/java/bisq/core/trade/bisq_v1/TradeResultHandler.java (4)
    R core/src/main/java/bisq/core/trade/bisq_v1/TradeTxException.java (2)
    R core/src/main/java/bisq/core/trade/bisq_v1/TradeUtil.java (4)
    R core/src/main/java/bisq/core/trade/bisq_v1/TransactionResultHandler.java (2)
    R core/src/main/java/bisq/core/trade/model/MakerTrade.java (2)
    R core/src/main/java/bisq/core/trade/model/TakerTrade.java (2)
    R core/src/main/java/bisq/core/trade/model/Tradable.java (2)
    R core/src/main/java/bisq/core/trade/model/TradableList.java (6)
    R core/src/main/java/bisq/core/trade/model/bisq_v1/BuyerAsMakerTrade.java (8)
    R core/src/main/java/bisq/core/trade/model/bisq_v1/BuyerAsTakerTrade.java (8)
    R core/src/main/java/bisq/core/trade/model/bisq_v1/BuyerTrade.java (4)
    R core/src/main/java/bisq/core/trade/model/bisq_v1/Contract.java (4)
    R core/src/main/java/bisq/core/trade/model/bisq_v1/SellerAsMakerTrade.java (8)
    R core/src/main/java/bisq/core/trade/model/bisq_v1/SellerAsTakerTrade.java (8)
    R core/src/main/java/bisq/core/trade/model/bisq_v1/SellerTrade.java (4)
    R core/src/main/java/bisq/core/trade/model/bisq_v1/Trade.java (11)
    M core/src/main/java/bisq/core/trade/protocol/FluentProtocol.java (7)
    R core/src/main/java/bisq/core/trade/protocol/Provider.java (32)
    R core/src/main/java/bisq/core/trade/protocol/TradeMessage.java (2)
    M core/src/main/java/bisq/core/trade/protocol/TradeProtocol.java (10)
    M core/src/main/java/bisq/core/trade/protocol/TradeProtocolFactory.java (14)
    M core/src/main/java/bisq/core/trade/protocol/TradeTaskRunner.java (2)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/BuyerAsMakerProtocol.java (47)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/BuyerAsTakerProtocol.java (50)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/BuyerProtocol.java (40)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/DisputeProtocol.java (41)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/MakerProtocol.java (4)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/SellerAsMakerProtocol.java (49)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/SellerAsTakerProtocol.java (40)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/SellerProtocol.java (44)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/TakerProtocol.java (4)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/messages/CounterCurrencyTransferStartedMessage.java (2)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/messages/DelayedPayoutTxSignatureRequest.java (4)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/messages/DelayedPayoutTxSignatureResponse.java (4)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/messages/DepositTxAndDelayedPayoutTxMessage.java (2)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/messages/DepositTxMessage.java (4)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/messages/InputsForDepositTxRequest.java (3)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/messages/InputsForDepositTxResponse.java (3)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/messages/MediatedPayoutTxPublishedMessage.java (2)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/messages/MediatedPayoutTxSignatureMessage.java (2)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/messages/PayoutTxPublishedMessage.java (2)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/messages/PeerPublishedDelayedPayoutTxMessage.java (2)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/messages/RefreshTradeStateRequest.java (2)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/messages/ShareBuyerPaymentAccountMessage.java (2)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/messages/TradeMailboxMessage.java (4)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/messages/TraderSignedWitnessMessage.java (2)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/model/ProcessModel.java (19)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/model/TradingPeer.java (2)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/ApplyFilter.java (4)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/BroadcastPayoutTx.java (4)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/ProcessPeerPublishedDelayedPayoutTxMessage.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/SendMailboxMessageTask.java (8)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/SetupPayoutTxListener.java (4)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/TradeTask.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/VerifyPeersAccountAgeWitness.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/arbitration/PublishedDelayedPayoutTx.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/arbitration/SendPeerPublishedDelayedPayoutTxMessage.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer/BuyerFinalizesDelayedPayoutTx.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer/BuyerProcessDelayedPayoutTxSignatureRequest.java (8)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer/BuyerProcessDepositTxAndDelayedPayoutTxMessage.java (12)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer/BuyerProcessPayoutTxPublishedMessage.java (9)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer/BuyerSendCounterCurrencyTransferStartedMessage.java (12)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer/BuyerSendsDelayedPayoutTxSignatureResponse.java (8)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer/BuyerSendsShareBuyerPaymentAccountMessage.java (12)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer/BuyerSetupDepositTxListener.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer/BuyerSetupPayoutTxListener.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer/BuyerSignPayoutTx.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer/BuyerSignsDelayedPayoutTx.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer/BuyerVerifiesFinalDelayedPayoutTx.java (8)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer/BuyerVerifiesPreparedDelayedPayoutTx.java (8)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer_as_maker/BuyerAsMakerCreatesAndSignsDepositTx.java (8)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer_as_maker/BuyerAsMakerSendsInputsForDepositTxResponse.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer_as_taker/BuyerAsTakerCreatesDepositTxInputs.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer_as_taker/BuyerAsTakerSendsDepositTxMessage.java (8)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer_as_taker/BuyerAsTakerSignsDepositTx.java (8)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/maker/MakerCreateAndSignContract.java (14)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/maker/MakerProcessesInputsForDepositTxRequest.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/maker/MakerRemovesOpenOffer.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/maker/MakerSendsInputsForDepositTxResponse.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/maker/MakerSetsLockTime.java (8)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/maker/MakerVerifyTakerFeePayment.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/mediation/BroadcastMediatedPayoutTx.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/mediation/FinalizeMediatedPayoutTx.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/mediation/ProcessMediatedPayoutSignatureMessage.java (8)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/mediation/ProcessMediatedPayoutTxPublishedMessage.java (9)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/mediation/SendMediatedPayoutSignatureMessage.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/mediation/SendMediatedPayoutTxPublishedMessage.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/mediation/SetupMediatedPayoutTxListener.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/mediation/SignMediatedPayoutTx.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller/SellerBroadcastPayoutTx.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller/SellerCreatesDelayedPayoutTx.java (8)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller/SellerFinalizesDelayedPayoutTx.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller/SellerProcessCounterCurrencyTransferStartedMessage.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller/SellerProcessDelayedPayoutTxSignatureResponse.java (8)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller/SellerProcessShareBuyerPaymentAccountMessage.java (12)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller/SellerPublishesDepositTx.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller/SellerPublishesTradeStatistics.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller/SellerSendDelayedPayoutTxSignatureRequest.java (8)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller/SellerSendPayoutTxPublishedMessage.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller/SellerSendsDepositTxAndDelayedPayoutTxMessage.java (12)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller/SellerSignAndFinalizePayoutTx.java (8)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller/SellerSignsDelayedPayoutTx.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller_as_maker/SellerAsMakerCreatesUnsignedDepositTx.java (8)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller_as_maker/SellerAsMakerFinalizesDepositTx.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller_as_maker/SellerAsMakerProcessDepositTxMessage.java (8)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller_as_maker/SellerAsMakerSendsInputsForDepositTxResponse.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller_as_taker/SellerAsTakerCreatesDepositTxInputs.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller_as_taker/SellerAsTakerSignsDepositTx.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/taker/CreateTakerFeeTx.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/taker/TakerProcessesInputsForDepositTxResponse.java (12)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/taker/TakerPublishFeeTx.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/taker/TakerSendInputsForDepositTxRequest.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/taker/TakerVerifyAndSignContract.java (14)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/taker/TakerVerifyMakerFeePayment.java (6)
    M core/src/main/java/bisq/core/trade/statistics/TradeStatistics2.java (13)
    M core/src/main/java/bisq/core/trade/statistics/TradeStatistics3.java (4)
    M core/src/main/java/bisq/core/trade/statistics/TradeStatisticsManager.java (4)
    M core/src/main/java/bisq/core/trade/txproof/xmr/XmrTxProofModel.java (4)
    M core/src/main/java/bisq/core/trade/txproof/xmr/XmrTxProofRequestsPerTrade.java (2)
    M core/src/main/java/bisq/core/trade/txproof/xmr/XmrTxProofService.java (10)
    M core/src/main/java/bisq/core/util/Validator.java (2)
    M core/src/main/resources/i18n/displayStrings_cs.properties (215)
    M core/src/main/resources/i18n/displayStrings_de.properties (167)
    M core/src/main/resources/i18n/displayStrings_es.properties (137)
    M core/src/main/resources/i18n/displayStrings_fa.properties (137)
    M core/src/main/resources/i18n/displayStrings_fr.properties (137)
    M core/src/main/resources/i18n/displayStrings_it.properties (139)
    M core/src/main/resources/i18n/displayStrings_ja.properties (137)
    M core/src/main/resources/i18n/displayStrings_pt-br.properties (141)
    M core/src/main/resources/i18n/displayStrings_pt.properties (141)
    M core/src/main/resources/i18n/displayStrings_ru.properties (137)
    M core/src/main/resources/i18n/displayStrings_th.properties (137)
    M core/src/main/resources/i18n/displayStrings_vi.properties (157)
    M core/src/main/resources/i18n/displayStrings_zh-hans.properties (151)
    M core/src/main/resources/i18n/displayStrings_zh-hant.properties (137)
    M core/src/test/java/bisq/core/account/witness/AccountAgeWitnessServiceTest.java (4)
    M core/src/test/java/bisq/core/offer/OfferMaker.java (7)
    M core/src/test/java/bisq/core/offer/OfferTest.java (2)
    M core/src/test/java/bisq/core/offer/OpenOfferManagerTest.java (3)
    M core/src/test/java/bisq/core/trade/TradableListTest.java (3)
    M daemon/src/main/java/bisq/daemon/grpc/GrpcErrorMessageHandler.java (2)
    M daemon/src/main/java/bisq/daemon/grpc/GrpcTradesService.java (2)
    M desktop/package/linux/Dockerfile (2)
    M desktop/package/macosx/Info.plist (4)
    M desktop/package/macosx/copy_dbs.sh (2)
    M desktop/package/macosx/finalize.sh (2)
    M desktop/package/macosx/replace_version_number.sh (4)
    M desktop/src/main/java/bisq/desktop/components/PeerInfoIcon.java (2)
    M desktop/src/main/java/bisq/desktop/components/PeerInfoIconSmall.java (2)
    M desktop/src/main/java/bisq/desktop/components/PeerInfoIconTrading.java (7)
    M desktop/src/main/java/bisq/desktop/components/paymentmethods/PaymentMethodForm.java (8)
    M desktop/src/main/java/bisq/desktop/components/paymentmethods/SwiftForm.java (3)
    M desktop/src/main/java/bisq/desktop/main/PriceUtil.java (8)
    M desktop/src/main/java/bisq/desktop/main/account/content/altcoinaccounts/AltCoinAccountsDataModel.java (2)
    M desktop/src/main/java/bisq/desktop/main/account/content/fiataccounts/FiatAccountsDataModel.java (2)
    M desktop/src/main/java/bisq/desktop/main/account/content/fiataccounts/FiatAccountsView.java (8)
    M desktop/src/main/java/bisq/desktop/main/dao/bonding/reputation/MyReputationView.java (6)
    M desktop/src/main/java/bisq/desktop/main/dao/burnbsq/assetfee/AssetFeeView.java (10)
    M desktop/src/main/java/bisq/desktop/main/dao/burnbsq/proofofburn/ProofOfBurnView.java (10)
    M desktop/src/main/java/bisq/desktop/main/dao/governance/make/MakeProposalView.java (4)
    M desktop/src/main/java/bisq/desktop/main/dao/governance/proposals/ProposalsView.java (6)
    M desktop/src/main/java/bisq/desktop/main/dao/wallet/BsqBalanceUtil.java (2)
    M desktop/src/main/java/bisq/desktop/main/dao/wallet/send/BsqSendView.java (16)
    M desktop/src/main/java/bisq/desktop/main/dao/wallet/tx/BsqTxView.java (2)
    M desktop/src/main/java/bisq/desktop/main/debug/DebugView.java (100)
    M desktop/src/main/java/bisq/desktop/main/funds/locked/LockedListItem.java (2)
    M desktop/src/main/java/bisq/desktop/main/funds/locked/LockedView.java (4)
    M desktop/src/main/java/bisq/desktop/main/funds/reserved/ReservedView.java (4)
    M desktop/src/main/java/bisq/desktop/main/funds/transactions/DisplayedTransactions.java (2)
    M desktop/src/main/java/bisq/desktop/main/funds/transactions/DummyTransactionAwareTradable.java (2)
    M desktop/src/main/java/bisq/desktop/main/funds/transactions/TradableRepository.java (6)
    M desktop/src/main/java/bisq/desktop/main/funds/transactions/TransactionAwareOpenOffer.java (2)
    M desktop/src/main/java/bisq/desktop/main/funds/transactions/TransactionAwareTradable.java (2)
    M desktop/src/main/java/bisq/desktop/main/funds/transactions/TransactionAwareTradableFactory.java (4)
    M desktop/src/main/java/bisq/desktop/main/funds/transactions/TransactionAwareTrade.java (6)
    M desktop/src/main/java/bisq/desktop/main/funds/transactions/TransactionsListItem.java (4)
    M desktop/src/main/java/bisq/desktop/main/funds/transactions/TransactionsView.java (4)
    M desktop/src/main/java/bisq/desktop/main/funds/withdrawal/WithdrawalView.java (2)
    M desktop/src/main/java/bisq/desktop/main/market/MarketView.java (8)
    M desktop/src/main/java/bisq/desktop/main/market/offerbook/OfferBookChartView.java (18)
    M desktop/src/main/java/bisq/desktop/main/market/offerbook/OfferBookChartViewModel.java (16)
    M desktop/src/main/java/bisq/desktop/main/market/spread/SpreadViewModel.java (8)
    M desktop/src/main/java/bisq/desktop/main/offer/BuyOfferView.java (4)
    M desktop/src/main/java/bisq/desktop/main/offer/OfferView.java (14)
    M desktop/src/main/java/bisq/desktop/main/offer/SellOfferView.java (4)
    R desktop/src/main/java/bisq/desktop/main/offer/bisq_v1/MutableOfferDataModel.java (27)
    R desktop/src/main/java/bisq/desktop/main/offer/bisq_v1/MutableOfferView.java (15)
    R desktop/src/main/java/bisq/desktop/main/offer/bisq_v1/MutableOfferViewModel.java (46)
    R desktop/src/main/java/bisq/desktop/main/offer/bisq_v1/OfferDataModel.java (2)
    R desktop/src/main/java/bisq/desktop/main/offer/bisq_v1/OfferViewModelUtil.java (11)
    R desktop/src/main/java/bisq/desktop/main/offer/bisq_v1/OfferViewUtil.java (6)
    R desktop/src/main/java/bisq/desktop/main/offer/bisq_v1/createoffer/CreateOfferDataModel.java (6)
    R desktop/src/main/java/bisq/desktop/main/offer/bisq_v1/createoffer/CreateOfferView.fxml (2)
    R desktop/src/main/java/bisq/desktop/main/offer/bisq_v1/createoffer/CreateOfferView.java (4)
    R desktop/src/main/java/bisq/desktop/main/offer/bisq_v1/createoffer/CreateOfferViewModel.java (4)
    R desktop/src/main/java/bisq/desktop/main/offer/bisq_v1/takeoffer/TakeOfferDataModel.java (19)
    R desktop/src/main/java/bisq/desktop/main/offer/bisq_v1/takeoffer/TakeOfferView.fxml (2)
    R desktop/src/main/java/bisq/desktop/main/offer/bisq_v1/takeoffer/TakeOfferView.java (17)
    R desktop/src/main/java/bisq/desktop/main/offer/bisq_v1/takeoffer/TakeOfferViewModel.java (46)
    M desktop/src/main/java/bisq/desktop/main/offer/offerbook/OfferBook.java (7)
    M desktop/src/main/java/bisq/desktop/main/offer/offerbook/OfferBookListItem.java (2)
    M desktop/src/main/java/bisq/desktop/main/offer/offerbook/OfferBookView.java (44)
    M desktop/src/main/java/bisq/desktop/main/offer/offerbook/OfferBookViewModel.java (36)
    M desktop/src/main/java/bisq/desktop/main/overlays/editor/PeerInfoWithTagEditor.java (2)
    M desktop/src/main/java/bisq/desktop/main/overlays/notifications/NotificationCenter.java (8)
    M desktop/src/main/java/bisq/desktop/main/overlays/windows/BsqEmptyWalletWindow.java (2)
    M desktop/src/main/java/bisq/desktop/main/overlays/windows/BtcEmptyWalletWindow.java (4)
    M desktop/src/main/java/bisq/desktop/main/overlays/windows/ContractWindow.java (2)
    M desktop/src/main/java/bisq/desktop/main/overlays/windows/DisputeSummaryWindow.java (4)
    M desktop/src/main/java/bisq/desktop/main/overlays/windows/OfferDetailsWindow.java (14)
    M desktop/src/main/java/bisq/desktop/main/overlays/windows/SignPaymentAccountsWindow.java (2)
    M desktop/src/main/java/bisq/desktop/main/overlays/windows/SwiftPaymentDetails.java (2)
    M desktop/src/main/java/bisq/desktop/main/overlays/windows/TradeDetailsWindow.java (4)
    M desktop/src/main/java/bisq/desktop/main/portfolio/PortfolioView.java (6)
    M desktop/src/main/java/bisq/desktop/main/portfolio/closedtrades/ClosedTradableListItem.java (2)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/5770.patch
https://github.com/bisq-network/bisq/pull/5770.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5770
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211020/89ed8972/attachment-0001.htm>

From notifications at github.com  Wed Oct 20 15:22:30 2021
From: notifications at github.com (chimp1984)
Date: Wed, 20 Oct 2021 06:22:30 -0700
Subject: [bisq-network/bisq] BSQ swap low risk refactorings (PR #5770)
In-Reply-To: <bisq-network/bisq/pull/5770@github.com>
References: <bisq-network/bisq/pull/5770@github.com>
Message-ID: <bisq-network/bisq/pull/5770/push/8197238201@github.com>

@chimp1984 pushed 4 commits.

d4bb026e3e7ce64710a947557962e0f4e32bfc26  Only check for localhost btc node if mainnet
f8751a8c4d5974068864f90729c889411f86ae73  Make TxConfidenceListener and its onTransactionConfidenceChanged method abstract
a927bea71f236769af7d5c3bba37488fd58370ec  Add scriptTypeId to RawTransactionInput
75072ebc26acef94bfe15eba5eaa3c152c63a416  Add deprecated annotation, null checks and comment to getRawInputFromTransactionInput


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/bisq-network/bisq/pull/5770/files/88198be7ffbfe00854207e3f9e6e907ffd7581b2..75072ebc26acef94bfe15eba5eaa3c152c63a416
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211020/86663cd7/attachment.htm>

From notifications at github.com  Wed Oct 20 15:37:48 2021
From: notifications at github.com (chimp1984)
Date: Wed, 20 Oct 2021 06:37:48 -0700
Subject: [bisq-network/bisq] BSQ swap low risk refactorings (PR #5770)
In-Reply-To: <bisq-network/bisq/pull/5770@github.com>
References: <bisq-network/bisq/pull/5770@github.com>
Message-ID: <bisq-network/bisq/pull/5770/push/8197375717@github.com>

@chimp1984 pushed 42 commits.

577b07ba9a9b50fdb76d9cdb2d675781c17eed53  Move OfferPayload into package bisq.core.offer.bisq_v1
19f813eea3b0ed753e8bc90754585e1a4f0344c0  Move CreateOfferService into package bisq.core.offer.bisq_v1
d98cb278057e27907ba894f696732026a5ba4820  Move MarketPriceNotAvailableException into package bisq.core.offer.bisq_v1
346fc79094cc0941b2ede33edb3d8d778b81c1a5  Move MutableOfferPayloadFields into package bisq.core.offer.bisq_v1
8a4c05c1e48b9fd81640456defecc8d472cb8f6c  Move TriggerPriceService into package bisq.core.offer.bisq_v1
ade5d322374f455a54dd48e9e82e754e9e596b5f  Move TakeOfferModel into package bisq.core.offer.bisq_v1
20d298061d8c4213bd46f62eedf623f610654288  Move AvailabilityResult into package bisq.core.offer.availability
0107519f4307aa594b1a695515d0b31eab39da6c  Move bisq.core.offer.messages package into package bisq.core.offer.availability
ed9f248c277afb23464860913119835f79e6395e  Move content of bisq.core.offer.placeoffer package into package bisq.core.offer.placeoffer.bisq_v1
b584fdf419b031818016505596aa6b899e492972  Rename OfferFilter to OfferFilterService
0e23cbe24e63b2a7e792bd496db510ea028e4388  Move Contract, SellerAsMakerTrade, SellerAsTakerTrade, SellerTrade,
c0cca781de5646ccf7836341f15ae65e7c30b6e6  Make updateDepositTxFromWallet public
0f7cfa99d51d87f378d994c75ef9ec3c8303619c  Move Trade to bisq.core.trade.model.bisq_v1 package
5944218a4bb31d914f08b96560f0b1fb3aad61b1  Move MakerTrade and TakerTrade to bisq.core.trade.model package
5a0145d1d94b31c916f6dca30fbdaa4b60dd67e1  Move Tradable to bisq.core.trade.model package
81ec06d0dcf397a224fbc950be2fd67ea3f7fb1e  Move TradableList to bisq.core.trade.model package
2489bbc119db6095abef7a7c659cd851b8ad0509  Make FluentProtocol.Event public
c0d13083c8c64ea486a1013059d3a5e1d4fca32e  Make setup in FluentProtocol public
87c12fda8c9d95cac288235dd9655ba707ac3391  Move protocol classes to bisq.core.trade.protocol.bisq_v1 package
babd70cc2a8230ba72cf8ed205ec326ef2d24969  Move tasks package into bisq.core.trade.protocol.bisq_v1 package
5099d974353f424af82d611b416e64e23d123202  Move TradingPeer into bisq.core.trade.protocol.bisq_v1 package
a212cec19c9bb32d9bd781e9ac33d75c552fa4a9  Move messages package into bisq.core.trade.protocol.bisq_v1 package
c9817ed6dbb1709077b46d07da50566b3a3545ca  Move ClosedTradableManager, FailedTradesManager into bisq.core.trade.bisq_v1 package
1b74b4efe9bb3907c0d9dfdf0b482c4cad8b24af  Rename CleanupMailboxMessages to CleanupMailboxMessagesService
2141f8f665dab4933022f38d1a2c6b1e42e51d84  Move CleanupMailboxMessagesService, ClosedTradeUtil to package bisq.core.trade.bisq_v1
f871e8339d294334f46b42ee41572d6c54177a80  Move TransactionResultHandler, TradeResultHandler to package bisq.core.trade.bisq_v1
71c663eb5306a6e7cbd05d55e95f984eaddd95ec  Move TradeDataValidation, DumpDelayedPayoutTx, TradeDataValidation, TradeUtil, TradeTxException to package bisq.core.trade.bisq_v1
26e2676268f409aa12d9d9e5a814c587c4a8a01b  Rename ProcessModelServiceProvider to Provider
c282b700010479b5c67f978eb434b5d41529f669  Rename txID to txId
30dd5683ef08083949252f4924065389f4a4bc15  Move createoffer package inside bisq.desktop.main.offer.bisq_v1 package
0cd0e16b53870ff663c357e9e78adf92be157dbc  Move takeoffer package inside bisq.desktop.main.offer.bisq_v1 package
4169a8719bf8984e6e1afd8fe67eca987682e807  Move MutableOffer view classes into bisq.desktop.main.offer.bisq_v1 package
a2a7e87af5ef944f17dbdc2e0a531a20fd7a854e  Move OfferDataModel, OfferViewUtil into bisq.desktop.main.offer.bisq_v1 package
a9f4bb76b687f724db84b37f69603b9289a5ea6a  Rename FeeUtil to OfferViewModelUtil
1e03aae2ac81ada51fc8a319b83be5209a1684c7  Move OfferViewModelUtil into bisq.desktop.main.offer.bisq_v1 package
72284d7d9f7c25236010a88389e88c218012248d  Cleanups, refromatting, add final qualifier
71eec7b2e0c98b8b036d4ab3fa52cc4701e0fc30  Move TradingPeer to package bisq.core.trade.protocol.bisq_v1.model
e1efc5e96fc6909e28446876c36393cc3e80a4e4  Make setPaymentStartedAckMessage and setDepositTxSentAckMessage public
760732f03a2cff68590935bd92f63ac81793f823  Move ProcessModel to package bisq.core.trade.protocol.bisq_v1.model
561ebe940e369aaa54668fa50751c154cc047764  Move test classes into bisq.desktop.main.offer.bisq_v1.createoffer
8ee255412fe1fe5ea023654614d99f05837afed5  Merge branch 'bsq-swap-low-risk-refactorings' into wip-merge2
559bc58ec23b942b0b90a2325800d40e5302af90  Fix merge issues


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/bisq-network/bisq/pull/5770/files/75072ebc26acef94bfe15eba5eaa3c152c63a416..559bc58ec23b942b0b90a2325800d40e5302af90
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211020/c51c0de1/attachment.htm>

From notifications at github.com  Wed Oct 20 16:06:51 2021
From: notifications at github.com (chimp1984)
Date: Wed, 20 Oct 2021 07:06:51 -0700
Subject: [bisq-network/bisq] BSQ swap low risk refactorings (PR #5770)
In-Reply-To: <bisq-network/bisq/pull/5770@github.com>
References: <bisq-network/bisq/pull/5770@github.com>
Message-ID: <bisq-network/bisq/pull/5770/push/8197642935@github.com>

@chimp1984 pushed 4 commits.

34c4eefb590c0678b3523a70e0673efdba109fea  Add allowSpendMyOwnUnconfirmedTxOutputs flag to BsqCoinSelector
47572888e7711f176b6018c9561d8b11447afff1  Add isMine method. Add error logs
0f6364d2bd4625619e6dbcce925efb0565db4639  Inline TransactionWitness
e582ffddad7db84481b76f6a518fc13c5796cdc2  Add new methods


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/bisq-network/bisq/pull/5770/files/559bc58ec23b942b0b90a2325800d40e5302af90..e582ffddad7db84481b76f6a518fc13c5796cdc2
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211020/84f8615b/attachment.htm>

From notifications at github.com  Wed Oct 20 16:29:30 2021
From: notifications at github.com (chimp1984)
Date: Wed, 20 Oct 2021 07:29:30 -0700
Subject: [bisq-network/bisq] BSQ swap low risk refactorings (PR #5770)
In-Reply-To: <bisq-network/bisq/pull/5770@github.com>
References: <bisq-network/bisq/pull/5770@github.com>
Message-ID: <bisq-network/bisq/pull/5770/push/8197855798@github.com>

@chimp1984 pushed 4 commits.

54e81d14731ee57a8ede3e5857e6b4c73f134ce2  Add signTx and verifyNonDustTxo methods
5f8bc834f798e94e25a0540a154c33598eb4be76  Remove unused signTx method
d95356be211786d67ebd47e27e8801e33f3197e6  Add verifiedBalance field.
cfc404b4c0ee8d495c167446e58e88ad152d1407  Rename signTx to signTxAndVerifyNoDustOutputs (no code change)


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/bisq-network/bisq/pull/5770/files/e582ffddad7db84481b76f6a518fc13c5796cdc2..cfc404b4c0ee8d495c167446e58e88ad152d1407
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211020/94b186c3/attachment-0001.htm>

From notifications at github.com  Wed Oct 20 18:08:00 2021
From: notifications at github.com (Stan)
Date: Wed, 20 Oct 2021 09:08:00 -0700
Subject: [bisq-network/bisq] Refactorings (non funtional changes) (PR
 #5769)
In-Reply-To: <bisq-network/bisq/pull/5769@github.com>
References: <bisq-network/bisq/pull/5769@github.com>
Message-ID: <bisq-network/bisq/pull/5769/review/784706580@github.com>

@ghubstan commented on this pull request.



> @@ -458,7 +458,7 @@ delayconfirmpaymentreceived() {
 }
 
 # This is a large function that should be broken up if it ever makes sense to not treat a trade
-# execution simulation as an atomic operation.  But we are not testing api methods here, just
+# execution simulation as an bsq swap operation.  But we are not testing api methods here, just

grammar change needed:  "as _a_ bsq swap operation."

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5769#pullrequestreview-784706580
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211020/ce22e6b9/attachment.htm>

From notifications at github.com  Wed Oct 20 18:16:22 2021
From: notifications at github.com (Stan)
Date: Wed, 20 Oct 2021 09:16:22 -0700
Subject: [bisq-network/bisq] Refactorings (non funtional changes) (PR
 #5769)
In-Reply-To: <bisq-network/bisq/pull/5769@github.com>
References: <bisq-network/bisq/pull/5769@github.com>
Message-ID: <bisq-network/bisq/pull/5769/c947823799@github.com>

The build fails because `bisq.desktop.main.offer.bisq_v1.createoffer.CreateOfferDataModel` is package protected, but this refactoring looks fine to me.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5769#issuecomment-947823799
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211020/cc0b9f9b/attachment.htm>

From notifications at github.com  Wed Oct 20 20:17:04 2021
From: notifications at github.com (Christoph Atteneder)
Date: Wed, 20 Oct 2021 11:17:04 -0700
Subject: [bisq-network/compensation] For Cycle 29 (Issue #930)
In-Reply-To: <bisq-network/compensation/issues/930@github.com>
References: <bisq-network/compensation/issues/930@github.com>
Message-ID: <bisq-network/compensation/issues/930/947919787@github.com>

As dev team lead I approve this compensation request for dev.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/930#issuecomment-947919787
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211020/0203a9ca/attachment.htm>

From notifications at github.com  Wed Oct 20 20:19:08 2021
From: notifications at github.com (Christoph Atteneder)
Date: Wed, 20 Oct 2021 11:19:08 -0700
Subject: [bisq-network/compensation] For Cycle 29 (Issue #926)
In-Reply-To: <bisq-network/compensation/issues/926@github.com>
References: <bisq-network/compensation/issues/926@github.com>
Message-ID: <bisq-network/compensation/issues/926/947921230@github.com>

As dev team lead I approve this compensation request for dev.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/926#issuecomment-947921230
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211020/b99aada9/attachment.htm>

From notifications at github.com  Wed Oct 20 20:19:42 2021
From: notifications at github.com (Christoph Atteneder)
Date: Wed, 20 Oct 2021 11:19:42 -0700
Subject: [bisq-network/compensation] For Cycle 29 (Issue #928)
In-Reply-To: <bisq-network/compensation/issues/928@github.com>
References: <bisq-network/compensation/issues/928@github.com>
Message-ID: <bisq-network/compensation/issues/928/947921593@github.com>

As dev team lead I approve this compensation request for dev.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/928#issuecomment-947921593
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211020/636be0ba/attachment.htm>

From notifications at github.com  Wed Oct 20 20:25:44 2021
From: notifications at github.com (Christoph Atteneder)
Date: Wed, 20 Oct 2021 11:25:44 -0700
Subject: [bisq-network/compensation] [WIP] For Cycle 29 (Issue #931)
Message-ID: <bisq-network/compensation/issues/931@github.com>

<!--
Compensation requests have a specific format that enables them to be evaluated by a bot for more efficient budgeting. Please make sure you stick to the template. A linter will evaluate your request after you remove [WIP] from the issue title and notify you of any issues.

See the following link for details:
https://bisq.wiki/Making_a_compensation_request

Feel free to browse other requests if you're not sure about something, or reach out in #compensation on Keybase (https://keybase.io/team/bisq).
-->


## Summary

> _Specify the total amount of BSQ you are requesting, along with the USD total and BSQ/USD rate (don't include the brackets!):_

- **BSQ requested**: **`TBD`** <!-- [BSQ amount] should be: USD amount / BSQ rate -->
- USD requested: TBD <!-- [USD amount] should be: total of all contributions listed in "contributions delivered" table below -->
- BSQ rate: 1.55 USD per BSQ <!-- [rate] should be the rate used to determine the BSQ amount above, as specified in the cycle's rate announcement (https://bisq.wiki/Compensation_Maintainer#Announce_BSQ-USD_rate) -->
- Previous compensation request (if applicable): #904     <!-- Link to last compensation request submitted -->

## Contributions delivered

> _Add contributions you have [delivered](https://github.com/bisq-network/proposals/issues/19) and roles you have performed here as new rows in the table below. Role line-items should include an asterisk (*) in the team column._

| Title | Team | USD | Link | Notes |
| --- | --- | --- | --- | --- |
| Bisq Desktop Maintainer | dev* | TBD | https://github.com/bisq-network/roles/issues/63#issuecomment-903615057 |  |
| Bitcoin Fullnode Operator | ops* | 50 | https://github.com/bisq-network/roles/issues/67#issuecomment-903616172 |  |
| GitHub Admin | ops* | 25 | https://github.com/bisq-network/roles/issues/16#issuecomment-922699719 |  |
| Release preparations  | dev* | TBD |  | v1.7.4
| Testing  | dev | TBD |  | Test reports for [v1.7.4](https://bisq.ontestpad.com/project/1/folder/f137/report/?auth=e7aae2d15a9fc9de90576dfe441ed3d3) |
| PR Review #| dev |  TBD | https://github.com/bisq-network/bisq/pull/#| |

I'm not putting up my team lead efforts up for compensation (~TBD% of my time).

<!-- 

Each contribution should be a new line-item in the table above. 

Title - optional, string.
Team - optional, must one of the following: admin, dev, growth, ops, support (case-insensitive). If the line-item is for a role, please add a `*`. See Example 2 below.
USD - optional, number. Please do not specify 'USD', as the column title makes units clear.
Link - optional, string.
Notes - optional, string.

Example 1 - typical contribution:

| Add local Bitcoin node configuration detection | dev | 240 | https://github.com/bisq-network/bisq/pull/3982

Example 2 - role (note the asterisk):

| Community manager | growth* | 400 | https://github.com/bisq-network/roles/issues/95#issuecomment-628431613

Example 3 - list of minor contributions, such as reviews:

| | | | https://github.com/bisq-network/bisq/pull/3968 | This and PRs below too small to be valued separately. See total at bottom.
| | | | https://github.com/bisq-network/bisq/pull/4040
| | | | https://github.com/bisq-network/bisq/pull/4044
| | | | https://github.com/bisq-network/bisq/pull/4048
| | | | https://github.com/bisq-network/bisq/pull/4066
| | dev | 400 | https://github.com/bisq-network/bisq/pull/4062 | Total for items above.

-->


## Contributions in progress

> _Provide links to work you're involved with that is still [in progress](https://github.com/bisq-network/proposals/issues/19). **This section is optional (the linter ignores it),** and is for your own benefit in keeping track of what you're doing and keeping other contributors up to date with the same._

I'm working right now on completing https://github.com/bisq-network/bisq/pull/5055 and will continue afterwards to help testing and reviewing the UI parts of the BSQ <-> BTC swap.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/931
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211020/ea7dbced/attachment-0001.htm>

From notifications at github.com  Wed Oct 20 20:27:20 2021
From: notifications at github.com (Christoph Atteneder)
Date: Wed, 20 Oct 2021 11:27:20 -0700
Subject: [bisq-network/roles] Bisq Maintainer (#63)
In-Reply-To: <bisq-network/roles/issues/63@github.com>
References: <bisq-network/roles/issues/63@github.com>
Message-ID: <bisq-network/roles/issues/63/947927839@github.com>

## Cycle 29 report

We released [v1.7.4] (https://github.com/bisq-network/bisq/releases/tag/v1.7.4) containing the Tor v3 support. So far the release went fine and most of the network already upgraded to Tor v3 addresses as well.

/cc https://github.com/bisq-network/compensation/issues/931

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/roles/issues/63#issuecomment-947927839
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211020/6b1f5445/attachment.htm>

From notifications at github.com  Wed Oct 20 20:28:10 2021
From: notifications at github.com (Christoph Atteneder)
Date: Wed, 20 Oct 2021 11:28:10 -0700
Subject: [bisq-network/roles] Bitcoin Node Operator (#67)
In-Reply-To: <bisq-network/roles/issues/67@github.com>
References: <bisq-network/roles/issues/67@github.com>
Message-ID: <bisq-network/roles/issues/67/947928405@github.com>

## Cycle 29 report
Running one instance both on onion and clear net.

### Events:
Nothing to report.

/cc https://github.com/bisq-network/compensation/issues/931

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/roles/issues/67#issuecomment-947928405
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211020/126880b6/attachment.htm>

From notifications at github.com  Wed Oct 20 20:30:00 2021
From: notifications at github.com (Christoph Atteneder)
Date: Wed, 20 Oct 2021 11:30:00 -0700
Subject: [bisq-network/roles] GitHub Admin (#16)
In-Reply-To: <bisq-network/roles/issues/16@github.com>
References: <bisq-network/roles/issues/16@github.com>
Message-ID: <bisq-network/roles/issues/16/947929763@github.com>

## Cycle 29 report

Transferred https://github.com/bisq-network/bisq-client to the bisq-network and granted maintainer permissions to @devinbileck .

/cc bisq-network/compensation#931



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/roles/issues/16#issuecomment-947929763
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211020/87e5644e/attachment.htm>

From notifications at github.com  Wed Oct 20 21:22:01 2021
From: notifications at github.com (MwithM)
Date: Wed, 20 Oct 2021 12:22:01 -0700
Subject: [bisq-network/proposals] BSQ trading fee update for Cycle 29 (Issue
 #345)
Message-ID: <bisq-network/proposals/issues/345@github.com>

_This proposal keeps a record of the [process](https://bisq.wiki/Updating_BSQ_trading_fees) to keep the BSQ trading fee at 50% discount to BTC trading fee. It will remain open until we need to update BSQ trading fees again._

Last update was on #339

## Cycle 29
**Parameters** ([see issue](https://github.com/bisq-network/proposals/issues/289))
* USD/BTC price: 66.200
* USD/BSQ price: 1.62
* Current BSQ discount: 68%

![imagen](https://user-images.githubusercontent.com/50149324/138157498-49a7d903-44c6-4fd7-ad28-59a41d43100b.png)


![imagen](https://user-images.githubusercontent.com/50149324/138157558-80bb67d0-6e38-4e5f-883d-a90dc199d072.png)




It's necessary to **update BSQ trading fee on Cycle 28**.


### New BSQ trading fees
A change parameter request for BSQ trading fees will be submitted to DAO voting:
New BSQ maker fee: `15.14`
New BSQ taker fee: `105.97`

The 15% cap to increase BSQ trading fees has been used.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/proposals/issues/345
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211020/be86691b/attachment.htm>

From notifications at github.com  Wed Oct 20 21:22:57 2021
From: notifications at github.com (MwithM)
Date: Wed, 20 Oct 2021 12:22:57 -0700
Subject: [bisq-network/proposals] BSQ trading fee update for Cycle 27
 (#339)
In-Reply-To: <bisq-network/proposals/issues/339@github.com>
References: <bisq-network/proposals/issues/339@github.com>
Message-ID: <bisq-network/proposals/issues/339/947967243@github.com>

Closing as new fees are proposed on Cycle 29.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/proposals/issues/339#issuecomment-947967243
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211020/085e3999/attachment-0001.htm>

From notifications at github.com  Wed Oct 20 21:22:58 2021
From: notifications at github.com (MwithM)
Date: Wed, 20 Oct 2021 12:22:58 -0700
Subject: [bisq-network/proposals] BSQ trading fee update for Cycle 27
 (#339)
In-Reply-To: <bisq-network/proposals/issues/339@github.com>
References: <bisq-network/proposals/issues/339@github.com>
Message-ID: <bisq-network/proposals/issue/339/issue_event/5494074159@github.com>

Closed #339.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/proposals/issues/339#event-5494074159
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211020/cc4f5215/attachment-0001.htm>

From notifications at github.com  Wed Oct 20 21:33:57 2021
From: notifications at github.com (MwithM)
Date: Wed, 20 Oct 2021 12:33:57 -0700
Subject: [bisq-network/roles] Community Manager (#95)
In-Reply-To: <bisq-network/roles/issues/95@github.com>
References: <bisq-network/roles/issues/95@github.com>
Message-ID: <bisq-network/roles/issues/95/947975265@github.com>

### Cycle 29 report


[Twitter](https://twitter.com/BisqEs): A more normal activity on twitter than last cycle, nothing specially important to remark.
[Telegram](https://t.me/bisq_p2p): Too much spam, but thre's been activity in Spanish and English channels almost every day.
[Reddit](https://www.reddit.com/r/bisq/): Raising interest about legal issues.


![imagen](https://user-images.githubusercontent.com/50149324/138159542-2b041642-8c06-4a57-9886-e8453ea8d202.png)


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/roles/issues/95#issuecomment-947975265
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211020/49460069/attachment.htm>

From notifications at github.com  Wed Oct 20 21:36:32 2021
From: notifications at github.com (MwithM)
Date: Wed, 20 Oct 2021 12:36:32 -0700
Subject: [bisq-network/roles] Transifex Admin (#20)
In-Reply-To: <bisq-network/roles/issues/20@github.com>
References: <bisq-network/roles/issues/20@github.com>
Message-ID: <bisq-network/roles/issues/20/947976890@github.com>

### Cycle 29

Discussion about adding Hindi to Bisq, but has been rejected since we expect that first Bisq users will be fluent in English. Language could be one of the last hurdles for new users.
As last cycle, there has been no activity in this cycle.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/roles/issues/20#issuecomment-947976890
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211020/e3ee4ac2/attachment.htm>

From notifications at github.com  Wed Oct 20 21:46:09 2021
From: notifications at github.com (MwithM)
Date: Wed, 20 Oct 2021 12:46:09 -0700
Subject: [bisq-network/roles] L1 Support Agent (#64)
In-Reply-To: <bisq-network/roles/issues/64@github.com>
References: <bisq-network/roles/issues/64@github.com>
Message-ID: <bisq-network/roles/issues/64/947983258@github.com>

### Cycle 29

- I have been as active for support as last cycle, a little bit less maybe, specially through Keybase and Telegram.
- There's one case where a trader lost data and I reported that to keybase channel.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/roles/issues/64#issuecomment-947983258
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211020/d5873846/attachment.htm>

From notifications at github.com  Wed Oct 20 21:46:36 2021
From: notifications at github.com (m52go)
Date: Wed, 20 Oct 2021 12:46:36 -0700
Subject: [bisq-network/compensation] For Cycle 29 (Issue #927)
In-Reply-To: <bisq-network/compensation/issues/927@github.com>
References: <bisq-network/compensation/issues/927@github.com>
Message-ID: <bisq-network/compensation/issues/927/947983560@github.com>

This spot on the back cover of the magazine is the last component of the contract we signed with Bitcoin Magazine in 2019. As wiz mentioned, we're splitting costs for it with Mempool, just as we did for the conference itself. 

For those following closely, the Miami event turned out to be much more expensive than planned, but it also turned out to be much better than expected. Mempool has taken on all these unexpected costs until now, which add up to over 30,000 USD. 

Thus I find it more than fair to split these last expenses for the back cover.

Note that this issue will be historic since the front is all about El Salvador, so Bisq's spot on the back is even more special, noteworthy, and enduring.

[Approved](https://bisq.wiki/Compensation#Team_Lead).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/927#issuecomment-947983560
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211020/32417349/attachment.htm>

From notifications at github.com  Wed Oct 20 21:54:06 2021
From: notifications at github.com (MwithM)
Date: Wed, 20 Oct 2021 12:54:06 -0700
Subject: [bisq-network/compensation] For Cycle 29 (Issue #932)
Message-ID: <bisq-network/compensation/issues/932@github.com>

<!--
Compensation requests have a specific format that enables them to be evaluated by a bot for more efficient budgeting. Please make sure you stick to the template. A linter will evaluate your request after you remove [WIP] from the issue title and notify you of any issues.

See the following link for details:
https://bisq.wiki/Making_a_compensation_request

Feel free to browse other requests if you're not sure about something, or reach out in #compensation on Keybase (https://keybase.io/team/bisq).
-->

## Summary

> _Specify the total amount of BSQ you are requesting, along with the USD total and BSQ/USD rate (don't include the brackets!):_

- **BSQ requested**: **`387.09`** <!-- [BSQ amount] should be: USD amount / BSQ rate -->
- USD requested: 600 USD <!-- [USD amount] should be: total of all contributions listed in "contributions delivered" table below -->
- BSQ rate: 1.55 USD per BSQ  <!-- [rate] should be the rate used to determine the BSQ amount above, as specified in the cycle's rate announcement (https://bisq.wiki/Compensation_Maintainer#Announce_BSQ-USD_rate) -->
- Previous compensation request (if applicable): #910    <!-- Link to last compensation request submitted -->


## Contributions delivered

> _Add contributions you have [delivered](https://github.com/bisq-network/proposals/issues/19) and roles you have performed here as new rows in the table below. Role line-items should include an asterisk (*) in the team column._

| Title | Team | USD | Link | Notes |
| --- | --- | --- | --- | --- |
| Community Manager | *Growth | 200 | https://github.com/bisq-network/roles/issues/95#issuecomment-947975265 |  |
| Transfiex Admin | *Growth | 0 | https://github.com/bisq-network/roles/issues/20#issuecomment-947976890 |  |
| Support Agent | *Support | 300 | https://github.com/bisq-network/roles/issues/64#issuecomment-947983258|  |
| Compensation Maintainer | *Admin | 100 | https://github.com/bisq-network/roles/issues/86#issuecomment-9312953865 |  |

<!-- 

Each contribution should be a new line-item in the table above. 

Title - optional, string.
Team - optional, must one of the following: admin, dev, growth, ops, support (case-insensitive). If the line-item is for a role, please add a `*`. See Example 2 below.
USD - optional, number. Please do not specify 'USD', as the column title makes units clear.
Link - optional, string.
Notes - optional, string.

Example 1 - typical contribution:

| Add local Bitcoin node configuration detection | dev | 240 | https://github.com/bisq-network/bisq/pull/3982

Example 2 - role (note the asterisk):

| Community manager | growth* | 400 | https://github.com/bisq-network/roles/issues/95#issuecomment-628431613

Example 3 - list of minor contributions, such as reviews:

| | | | https://github.com/bisq-network/bisq/pull/3968 | This and PRs below too small to be valued separately. See total at bottom.
| | | | https://github.com/bisq-network/bisq/pull/4040
| | | | https://github.com/bisq-network/bisq/pull/4044
| | | | https://github.com/bisq-network/bisq/pull/4048
| | | | https://github.com/bisq-network/bisq/pull/4066
| | dev | 400 | https://github.com/bisq-network/bisq/pull/4062 | Total for items above.

-->


## Contributions in progress

> _Provide links to work you're involved with that is still [in progress](https://github.com/bisq-network/proposals/issues/19). **This section is optional (the linter ignores it),** and is for your own benefit in keeping track of what you're doing and keeping other contributors up to date with the same._


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/932
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211020/c1d877ce/attachment-0001.htm>

From notifications at github.com  Wed Oct 20 22:17:45 2021
From: notifications at github.com (m52go)
Date: Wed, 20 Oct 2021 13:17:45 -0700
Subject: [bisq-network/compensation] For Cycle 29 (Issue #932)
In-Reply-To: <bisq-network/compensation/issues/932@github.com>
References: <bisq-network/compensation/issues/932@github.com>
Message-ID: <bisq-network/compensation/issues/932/948004299@github.com>

[Approved](https://bisq.wiki/Compensation#Team_Lead) for growth and admin.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/932#issuecomment-948004299
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211020/3ee38845/attachment.htm>

From notifications at github.com  Wed Oct 20 22:32:48 2021
From: notifications at github.com (MwithM)
Date: Wed, 20 Oct 2021 13:32:48 -0700
Subject: [bisq-network/bisq] Use onchain trade protocol for offchain
 trading (Discussion #5756)
In-Reply-To: <bisq-network/bisq/repo-discussions/5756@github.com>
References: <bisq-network/bisq/repo-discussions/5756@github.com>
Message-ID: <bisq-network/bisq/repo-discussions/5756/comments/1510771@github.com>

I I traded frequently with one user and I felt like we didn't need to release the deposit, as we would probably trade later in a month or couple months. I think that this is proposing something similar, but I don't find a huge advantage on it. 
If a lot of trust is established, there is no need Bisq, and if there's no much trust, or want to try a better offer somewhere else, traders won't like to let a deposit for a long time.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/discussions/5756#discussioncomment-1510771
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211020/c656fa81/attachment.htm>

From notifications at github.com  Wed Oct 20 22:53:56 2021
From: notifications at github.com (chimp1984)
Date: Wed, 20 Oct 2021 13:53:56 -0700
Subject: [bisq-network/bisq] BSQ swap low risk refactorings (PR #5770)
In-Reply-To: <bisq-network/bisq/pull/5770@github.com>
References: <bisq-network/bisq/pull/5770@github.com>
Message-ID: <bisq-network/bisq/pull/5770/push/8200690061@github.com>

@chimp1984 pushed 2 commits.

82c1be1d97f57c0bd2b2380125468d80d607bbd7  Change log level
c15fc0c0a7a1d33db8a334881d03e9ee1185ce47  Add comment, cleanups


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/bisq-network/bisq/pull/5770/files/cfc404b4c0ee8d495c167446e58e88ad152d1407..c15fc0c0a7a1d33db8a334881d03e9ee1185ce47
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211020/b76de3c3/attachment.htm>

From notifications at github.com  Wed Oct 20 22:58:49 2021
From: notifications at github.com (chimp1984)
Date: Wed, 20 Oct 2021 13:58:49 -0700
Subject: [bisq-network/bisq] BSQ swap low risk refactorings (PR #5770)
In-Reply-To: <bisq-network/bisq/pull/5770@github.com>
References: <bisq-network/bisq/pull/5770@github.com>
Message-ID: <bisq-network/bisq/pull/5770/push/8200720347@github.com>

@chimp1984 pushed 1 commit.

d7f1b00221ac07b914cd37302888edb357f5bc71  Rename processModel.getTradingPeer to getTradePeer


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/bisq-network/bisq/pull/5770/files/c15fc0c0a7a1d33db8a334881d03e9ee1185ce47..d7f1b00221ac07b914cd37302888edb357f5bc71
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211020/42cc4963/attachment.htm>

From notifications at github.com  Wed Oct 20 23:08:06 2021
From: notifications at github.com (jmacxx)
Date: Wed, 20 Oct 2021 14:08:06 -0700
Subject: [bisq-network/bisq] Avoid that outdated donation and fee
 addresses are used. (PR #5764)
In-Reply-To: <bisq-network/bisq/pull/5764@github.com>
References: <bisq-network/bisq/pull/5764@github.com>
Message-ID: <bisq-network/bisq/pull/5764/review/784996831@github.com>

@jmacxx requested changes on this pull request.



> @@ -34,12 +32,16 @@
 
 @Slf4j
 public class FeeReceiverSelector {
-    public static String getAddress(DaoFacade daoFacade, FilterManager filterManager) {
-        return getAddress(daoFacade, filterManager, new Random());
+    public static String getMostRecentAddress() {
+        return "38bZBj5peYS3Husdz7AH3gEUiUbYRD951t";

This fails when run in regtest, suggest something like this:

    public static String getMostRecentAddress() {
        return Config.baseCurrencyNetwork().isMainnet() ? Config.LATEST_DONATION_ADDRESS :  // mainnet
                Config.baseCurrencyNetwork().isDaoBetaNet() ? Config.LATEST_DONATION_ADDRESS : // daoBetaNet
                        Config.baseCurrencyNetwork().isTestnet() ? Config.TESTNET_DONATION_ADDRESS : // testnet
                                Config.REGTEST_DONATION_ADDRESS; // regtest
    }


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5764#pullrequestreview-784996831
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211020/2c2b2d58/attachment.htm>

From notifications at github.com  Wed Oct 20 23:54:39 2021
From: notifications at github.com (chimp1984)
Date: Wed, 20 Oct 2021 14:54:39 -0700
Subject: [bisq-network/bisq] BSQ swap low risk refactorings (PR #5770)
In-Reply-To: <bisq-network/bisq/pull/5770@github.com>
References: <bisq-network/bisq/pull/5770@github.com>
Message-ID: <bisq-network/bisq/pull/5770/push/8201044334@github.com>

@chimp1984 pushed 6 commits.

02d7dfdaefeeaea5aaadf5a85596abb1c500d2cb  Only print stack trace if dev mode
9e4be1367a399d6d24fe075409331ff028a004fc  Change log level
8d2579866a61508f3c1e5cd7559763006ef941e6  Replace Value annotation with Getter and EqualsAndHashCode
d976f11e09db208a9abceca4bb265c18e17713b6  Add methods
a3b3d561ecc0685e017e1f498715326de4dee570  Simplify
9d106468b04f53fae29b76f80e7d95575a6afb5c  Move getRandomOfferId method to OfferUtil


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/bisq-network/bisq/pull/5770/files/d7f1b00221ac07b914cd37302888edb357f5bc71..9d106468b04f53fae29b76f80e7d95575a6afb5c
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211020/41a38ede/attachment-0001.htm>

From notifications at github.com  Thu Oct 21 00:11:26 2021
From: notifications at github.com (jmacxx)
Date: Wed, 20 Oct 2021 15:11:26 -0700
Subject: [bisq-network/bisq] Option to not repeat popup message of locked up
 funds from failed trade (PR #5771)
Message-ID: <bisq-network/bisq/pull/5771@github.com>


When Bisq detects funds locked up from a failed trade it pops up a message alert at frequent intervals (for example every block).  This can get frustrating especially if more than one trade is affected.

This PR allows users to selectively choose to stop receiving these popups **on a trade by trade basis**, via the &quot;Don&#39;t show again&quot; checkbox.

![failed_trade_popup](https://user-images.githubusercontent.com/47253594/138179193-61f2f99a-97cf-4ef2-b11a-ee99b7a29c23.png)

Requested by @leo816 and users in keybase support channel.

You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/5771

-- Commit Summary --

  * <a href="https://github.com/bisq-network/bisq/pull/5771/commits/1dffec00f2e323ac5d2999c35dce276c55dce837">Add option to not repeat popup message of locked up funds from failed trade</a>

-- File Changes --

    M desktop/src/main/java/bisq/desktop/main/MainViewModel.java (14)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/5771.patch
https://github.com/bisq-network/bisq/pull/5771.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5771
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211020/f6d279f7/attachment.htm>

From notifications at github.com  Thu Oct 21 01:24:05 2021
From: notifications at github.com (chimp1984)
Date: Wed, 20 Oct 2021 16:24:05 -0700
Subject: [bisq-network/bisq] BSQ swap low risk refactorings (PR #5770)
In-Reply-To: <bisq-network/bisq/pull/5770@github.com>
References: <bisq-network/bisq/pull/5770@github.com>
Message-ID: <bisq-network/bisq/pull/5770/push/8201476452@github.com>

@chimp1984 pushed 12 commits.

e061d6a476e78b7368ec88952bf27bf2e9a6b0f3  Replace Value with Getter
5b0e9ab92fbe8b62ef612e5f8cab27d17a33f2c4  Rename trade.getPhase to getTradePhase
544dd895fc279926e11e23565286dff2de0d9dd9  Rename trade.getState to getTradeState
12fff5403d9d13045726ee08410fcb2f3d3706f6  Cleanup
2440d7234d2d7fc83e772e0a2ff9c52128cd3f6f  Extract methods, Cleanups
4cb074694da118b3f62c4e21ea7b92d197e5e1bc  Extract methods, cleanups. Rename methods and vars
7211f892e13041979784ebaa2896f45975a2982c  Add exclude fields to EqualsAndHashCode
07883e9b8ba1fc5b5f4de146e28c0542c8da21b9  Rename trade.getPhase to getTradePhase
0148a36566c554c3c898d8fc8e14ba60d7abd723  Extract to method in TradeUtil
10516407de34fc3d07255ec246dac99bce07151a  Use early return. cleanup
8219bf84070dab6cb4ce448c94ff26da7b114bc2  Extract method. Rename vars
ee374c3c39720e540a79311d48a1d6daa93d8abd  Cleanups, apply rename of getTradePhase


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/bisq-network/bisq/pull/5770/files/9d106468b04f53fae29b76f80e7d95575a6afb5c..ee374c3c39720e540a79311d48a1d6daa93d8abd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211020/d17d278c/attachment.htm>

From notifications at github.com  Thu Oct 21 04:06:14 2021
From: notifications at github.com (m52go)
Date: Wed, 20 Oct 2021 19:06:14 -0700
Subject: [bisq-network/roles] Community Manager (#95)
In-Reply-To: <bisq-network/roles/issues/95@github.com>
References: <bisq-network/roles/issues/95@github.com>
Message-ID: <bisq-network/roles/issues/95/948189851@github.com>

@cbeams can we get @stopfeds assigned here as well? He started running a [German Twitter account](https://twitter.com/bisqde) in this cycle.

https://github.com/bisq-network/growth/issues/249

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/roles/issues/95#issuecomment-948189851
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211020/5540492d/attachment.htm>

From notifications at github.com  Thu Oct 21 09:13:48 2021
From: notifications at github.com (boring-cyborg[bot])
Date: Thu, 21 Oct 2021 00:13:48 -0700
Subject: [bisq-network/bisq] Cannot Confirm Payment Received (Issue #5772)
In-Reply-To: <bisq-network/bisq/issues/5772@github.com>
References: <bisq-network/bisq/issues/5772@github.com>
Message-ID: <bisq-network/bisq/issues/5772/948323847@github.com>

**Thanks for opening your first issue here!**<br/><br/>Be sure to follow the issue template. Your issue will be reviewed by a maintainer and labeled for further action.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5772#issuecomment-948323847
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211021/0abe11e8/attachment-0001.htm>

From notifications at github.com  Thu Oct 21 09:13:49 2021
From: notifications at github.com (tut4499)
Date: Thu, 21 Oct 2021 00:13:49 -0700
Subject: [bisq-network/bisq] Cannot Confirm Payment Received (Issue #5772)
Message-ID: <bisq-network/bisq/issues/5772@github.com>

I am unable to confirm received SEPA payment.

Version 1.7.4

Does not show 
"Your trading account"
"Buyer account data"



Cannot invoke "bisq.core.payment.payload.PaymentAccountPayload.getAgeWitnessInputData()" because "paymentAccountPayload" is null


[bisq.log](https://github.com/bisq-network/bisq/files/7386776/bisq.log)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5772
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211021/fe40830c/attachment-0001.htm>

From notifications at github.com  Thu Oct 21 09:42:58 2021
From: notifications at github.com (Chris Beams)
Date: Thu, 21 Oct 2021 00:42:58 -0700
Subject: [bisq-network/roles] Community Manager (#95)
In-Reply-To: <bisq-network/roles/issues/95@github.com>
References: <bisq-network/roles/issues/95@github.com>
Message-ID: <bisq-network/roles/issues/95/948344149@github.com>

> can we get @stopfeds assigned here as well?

Done, and added to @bisq-network/community-managers. Wilkommen, @stopfeds! 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/roles/issues/95#issuecomment-948344149
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211021/6e47ce97/attachment.htm>

From notifications at github.com  Thu Oct 21 09:43:43 2021
From: notifications at github.com (chimp1984)
Date: Thu, 21 Oct 2021 00:43:43 -0700
Subject: [bisq-network/bisq] BSQ swap low risk refactorings (PR #5770)
In-Reply-To: <bisq-network/bisq/pull/5770@github.com>
References: <bisq-network/bisq/pull/5770@github.com>
Message-ID: <bisq-network/bisq/pull/5770/push/8203818961@github.com>

@chimp1984 pushed 3 commits.

e940f6f9f0a06059ec0e003dfbc4a01b775598f4  Add method. Dont return null in case of no amount but min fee
19aabba12c701f5aa311dd4d445484d711953ef9  Add method. cleanups
1c0b52cd31d27c1bf66f5cf6eb87fc75efb2aaca  Move OfferDirection from bisq.core.offer.bisq_v1 to bisq.core.offer


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/bisq-network/bisq/pull/5770/files/ee374c3c39720e540a79311d48a1d6daa93d8abd..1c0b52cd31d27c1bf66f5cf6eb87fc75efb2aaca
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211021/78cf09de/attachment.htm>

From notifications at github.com  Thu Oct 21 10:13:47 2021
From: notifications at github.com (chimp1984)
Date: Thu, 21 Oct 2021 01:13:47 -0700
Subject: [bisq-network/bisq] BSQ swap low risk refactorings (PR #5770)
In-Reply-To: <bisq-network/bisq/pull/5770@github.com>
References: <bisq-network/bisq/pull/5770@github.com>
Message-ID: <bisq-network/bisq/pull/5770/push/8204038906@github.com>

@chimp1984 pushed 3 commits.

07354191a6bddb4ca5ff3bcee8a51c37ee6a43c5  Remove handling of BundleOfEnvelopes in send method.
b80b6ec836d778ef3a1a11e06d2a8f024931d947  Cleanups
23af4558b5e624d02a7457d9c217609555b1d641  Add filterPredicate


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/bisq-network/bisq/pull/5770/files/1c0b52cd31d27c1bf66f5cf6eb87fc75efb2aaca..23af4558b5e624d02a7457d9c217609555b1d641
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211021/6db235a1/attachment.htm>

From notifications at github.com  Thu Oct 21 11:08:38 2021
From: notifications at github.com (chimp1984)
Date: Thu, 21 Oct 2021 02:08:38 -0700
Subject: [bisq-network/bisq] BSQ swap low risk refactorings (PR #5770)
In-Reply-To: <bisq-network/bisq/pull/5770@github.com>
References: <bisq-network/bisq/pull/5770@github.com>
Message-ID: <bisq-network/bisq/pull/5770/push/8204474802@github.com>

@chimp1984 pushed 9 commits.

2e384ede59ec232e5b9e390a465eaec51f7f0fff  Make onDeleteAccount more clear
9d8c705104f53aefac8018e08cedc7ad35d1515e  Only add delay if not devmode
d2851574425c1fe587cdca81399c7b5bb325a463  Reduce visibility
8bb42e1421d4c6ee5e14cb91d53ac699e84e08fb  Add methods, move field up
1aa5e7053d70f2e25311481a0318698b478e72bf  Add method
8ac40a3e0cd34262d302ce5f8c59ac52411ca3c1  Add style
c60df6e978866162e16dcef6c6801419a0eacd3c  Add linebreak (no code change)
9fb6a6ca9f9666f805ee6bea4882c45df10cfaa1  Add isNotPublished method (will be combined later with bsq swap checks)
cfae096c1f14952cebdb56edc909b354c2585e49  Add null checks, extract variables, cleanups


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/bisq-network/bisq/pull/5770/files/23af4558b5e624d02a7457d9c217609555b1d641..cfae096c1f14952cebdb56edc909b354c2585e49
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211021/c59dcd97/attachment.htm>

From notifications at github.com  Thu Oct 21 11:17:42 2021
From: notifications at github.com (Stephan Oeste)
Date: Thu, 21 Oct 2021 02:17:42 -0700
Subject: [bisq-network/compensation] For Cycle 29 (Issue #931)
In-Reply-To: <bisq-network/compensation/issues/931@github.com>
References: <bisq-network/compensation/issues/931@github.com>
Message-ID: <bisq-network/compensation/issues/931/948419152@github.com>

As ops team lead I approve this compensation request for ops.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/931#issuecomment-948419152
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211021/6af2e6d5/attachment.htm>

From notifications at github.com  Thu Oct 21 11:17:57 2021
From: notifications at github.com (Stephan Oeste)
Date: Thu, 21 Oct 2021 02:17:57 -0700
Subject: [bisq-network/compensation] For Cycle 29 (Issue #930)
In-Reply-To: <bisq-network/compensation/issues/930@github.com>
References: <bisq-network/compensation/issues/930@github.com>
Message-ID: <bisq-network/compensation/issues/930/948419371@github.com>

As ops team lead I approve this compensation request for ops.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/930#issuecomment-948419371
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211021/29b14425/attachment-0001.htm>

From notifications at github.com  Thu Oct 21 11:17:58 2021
From: notifications at github.com (chimp1984)
Date: Thu, 21 Oct 2021 02:17:58 -0700
Subject: [bisq-network/bisq] Refactorings (non funtional changes) (PR
 #5769)
In-Reply-To: <bisq-network/bisq/pull/5769@github.com>
References: <bisq-network/bisq/pull/5769@github.com>
Message-ID: <bisq-network/bisq/pull/5769/review/785427517@github.com>

@chimp1984 commented on this pull request.



> @@ -458,7 +458,7 @@ delayconfirmpaymentreceived() {
 }
 
 # This is a large function that should be broken up if it ever makes sense to not treat a trade
-# execution simulation as an atomic operation.  But we are not testing api methods here, just
+# execution simulation as an bsq swap operation.  But we are not testing api methods here, just

I will add that commit in the follow up branch to avoid merge effort.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5769#discussion_r733483003
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211021/c921d321/attachment.htm>

From notifications at github.com  Thu Oct 21 11:18:42 2021
From: notifications at github.com (Stephan Oeste)
Date: Thu, 21 Oct 2021 02:18:42 -0700
Subject: [bisq-network/compensation] For Cycle 29 (Issue #929)
In-Reply-To: <bisq-network/compensation/issues/929@github.com>
References: <bisq-network/compensation/issues/929@github.com>
Message-ID: <bisq-network/compensation/issues/929/948419958@github.com>

As ops team lead I approve this compensation request for ops.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/929#issuecomment-948419958
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211021/d45a4d2a/attachment.htm>

From notifications at github.com  Thu Oct 21 11:18:52 2021
From: notifications at github.com (chimp1984)
Date: Thu, 21 Oct 2021 02:18:52 -0700
Subject: [bisq-network/bisq] Avoid that outdated donation and fee
 addresses are used. (PR #5764)
In-Reply-To: <bisq-network/bisq/pull/5764@github.com>
References: <bisq-network/bisq/pull/5764@github.com>
Message-ID: <bisq-network/bisq/pull/5764/push/8204559004@github.com>

@chimp1984 pushed 1 commit.

6f5b1cbbdc478e80280a04acacf4950fa8b14be5  Fix comment


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/bisq-network/bisq/pull/5764/files/621d9956837f5ace7a37d43b8db08a8cd19f736b..6f5b1cbbdc478e80280a04acacf4950fa8b14be5
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211021/2c84014e/attachment.htm>

From notifications at github.com  Thu Oct 21 11:20:15 2021
From: notifications at github.com (Stephan Oeste)
Date: Thu, 21 Oct 2021 02:20:15 -0700
Subject: [bisq-network/compensation] For Cycle 29 (Issue #927)
In-Reply-To: <bisq-network/compensation/issues/927@github.com>
References: <bisq-network/compensation/issues/927@github.com>
Message-ID: <bisq-network/compensation/issues/927/948421194@github.com>

As ops team lead I approve this compensation request for ops.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/927#issuecomment-948421194
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211021/69c86d6a/attachment.htm>

From notifications at github.com  Thu Oct 21 11:23:45 2021
From: notifications at github.com (chimp1984)
Date: Thu, 21 Oct 2021 02:23:45 -0700
Subject: [bisq-network/bisq] Refactorings (non funtional changes) (PR
 #5769)
In-Reply-To: <bisq-network/bisq/pull/5769@github.com>
References: <bisq-network/bisq/pull/5769@github.com>
Message-ID: <bisq-network/bisq/pull/5769/push/8204599576@github.com>

@chimp1984 pushed 1 commit.

2ae1860dac9729c71e03a4649c6f8364fad26a5a  Move tests to package bisq.desktop.main.offer.bisq_v1.createoffer


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/bisq-network/bisq/pull/5769/files/dca0c93f477f66da22f6eeba2532fffb844dde90..2ae1860dac9729c71e03a4649c6f8364fad26a5a
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211021/bfb48d57/attachment.htm>

From notifications at github.com  Thu Oct 21 11:29:33 2021
From: notifications at github.com (chimp1984)
Date: Thu, 21 Oct 2021 02:29:33 -0700
Subject: [bisq-network/bisq] BSQ swap low risk refactorings (PR #5770)
In-Reply-To: <bisq-network/bisq/pull/5770@github.com>
References: <bisq-network/bisq/pull/5770@github.com>
Message-ID: <bisq-network/bisq/pull/5770/push/8204646182@github.com>

@chimp1984 pushed 2 commits.

2ae1860dac9729c71e03a4649c6f8364fad26a5a  Move tests to package bisq.desktop.main.offer.bisq_v1.createoffer
080dc3e8a1cfc17004b4df32811af9fe81c91c54  Merge branch 'chimp-bsq-swap' into wip-merge021.10


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/bisq-network/bisq/pull/5770/files/cfae096c1f14952cebdb56edc909b354c2585e49..080dc3e8a1cfc17004b4df32811af9fe81c91c54
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211021/b6d996c7/attachment-0001.htm>

From notifications at github.com  Thu Oct 21 11:44:57 2021
From: notifications at github.com (chimp1984)
Date: Thu, 21 Oct 2021 02:44:57 -0700
Subject: [bisq-network/bisq] Refactorings (non funtional changes) (PR
 #5769)
In-Reply-To: <bisq-network/bisq/pull/5769@github.com>
References: <bisq-network/bisq/pull/5769@github.com>
Message-ID: <bisq-network/bisq/pull/5769/push/8204769164@github.com>

@chimp1984 pushed 1 commit.

ab6e4e1b8f3fcb7f2f4bc0547980d7fc6724fec9  Dummy commit to enforce rebuild at CI


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/bisq-network/bisq/pull/5769/files/2ae1860dac9729c71e03a4649c6f8364fad26a5a..ab6e4e1b8f3fcb7f2f4bc0547980d7fc6724fec9
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211021/5de75cd1/attachment.htm>

From notifications at github.com  Thu Oct 21 12:24:02 2021
From: notifications at github.com (chimp1984)
Date: Thu, 21 Oct 2021 03:24:02 -0700
Subject: [bisq-network/bisq] BSQ swap low risk refactorings (PR #5770)
In-Reply-To: <bisq-network/bisq/pull/5770@github.com>
References: <bisq-network/bisq/pull/5770@github.com>
Message-ID: <bisq-network/bisq/pull/5770/push/8205082841@github.com>

@chimp1984 pushed 4 commits.

ab6e4e1b8f3fcb7f2f4bc0547980d7fc6724fec9  Dummy commit to enforce rebuild at CI
5412f8b669a13a6da70e8f3e365aeb64d56fa3be  Merge branch 'chimp-bsq-swap' into bsq-swap-low-risk-refactorings
c920da36c08d679de8d1ef47b171e79c5765c2aa  Add abstract classes and interfaces. Let ProcessModel and TradingPeer extend those.
8cd85a77c148a7d01de9b41d25832ca0af6f334e  Let Trade extend TradeModel


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/bisq-network/bisq/pull/5770/files/080dc3e8a1cfc17004b4df32811af9fe81c91c54..8cd85a77c148a7d01de9b41d25832ca0af6f334e
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211021/537a67a9/attachment.htm>

From notifications at github.com  Thu Oct 21 12:50:41 2021
From: notifications at github.com (chimp1984)
Date: Thu, 21 Oct 2021 03:50:41 -0700
Subject: [bisq-network/bisq] BSQ swap low risk refactorings (PR #5770)
In-Reply-To: <bisq-network/bisq/pull/5770@github.com>
References: <bisq-network/bisq/pull/5770@github.com>
Message-ID: <bisq-network/bisq/pull/5770/push/8205282130@github.com>

@chimp1984 pushed 4 commits.

dcd0101c52142dd534fe9bd738d766e3f9b5fd56  Generify TradeResultHandler
5d687bd064ab3754ffcf8614b5de982114823baf  Use TradeModel and ProtocolModel in TradeTaskRunner, TradeTask, TradeProtocol and FluentProtocol
308bb687c552573cd371c372dea4d93c8f1aa22d  Use TradeModel
453229e3708c0e9742b710b87cbdfd30db1425ad  Impl. onAckMessage. Add fields for concrete types


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/bisq-network/bisq/pull/5770/files/8cd85a77c148a7d01de9b41d25832ca0af6f334e..453229e3708c0e9742b710b87cbdfd30db1425ad
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211021/a786661a/attachment.htm>

From notifications at github.com  Thu Oct 21 12:56:44 2021
From: notifications at github.com (BtcContributor)
Date: Thu, 21 Oct 2021 03:56:44 -0700
Subject: [bisq-network/bisq] Allow standard mark & copy functionality for
 displayed text fields (#5747)
In-Reply-To: <bisq-network/bisq/pull/5747@github.com>
References: <bisq-network/bisq/pull/5747@github.com>
Message-ID: <bisq-network/bisq/pull/5747/c948493582@github.com>

I noticed that in the trade detail window if you try to right click on "green" strings like all the txid to copy them, the context menu will open but then instantly it is opened also the mempool.space link.

I know that a user should use the copy button but maybe we could block right click on strings that already have a copy button?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5747#issuecomment-948493582
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211021/b056fc8a/attachment.htm>

From notifications at github.com  Thu Oct 21 13:09:24 2021
From: notifications at github.com (chimp1984)
Date: Thu, 21 Oct 2021 04:09:24 -0700
Subject: [bisq-network/bisq] BSQ swap low risk refactorings (PR #5770)
In-Reply-To: <bisq-network/bisq/pull/5770@github.com>
References: <bisq-network/bisq/pull/5770@github.com>
Message-ID: <bisq-network/bisq/pull/5770/push/8205423773@github.com>

@chimp1984 pushed 1 commit.

c0e70b81ef641801a84ef37188e57e20bcdc1306  Use TradeModel in trade domain


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/bisq-network/bisq/pull/5770/files/453229e3708c0e9742b710b87cbdfd30db1425ad..c0e70b81ef641801a84ef37188e57e20bcdc1306
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211021/a586ad41/attachment.htm>

From notifications at github.com  Thu Oct 21 13:34:34 2021
From: notifications at github.com (Stephan Oeste)
Date: Thu, 21 Oct 2021 04:34:34 -0700
Subject: [bisq-network/compensation] For Cycle 29 (Issue #928)
In-Reply-To: <bisq-network/compensation/issues/928@github.com>
References: <bisq-network/compensation/issues/928@github.com>
Message-ID: <bisq-network/compensation/issues/928/948522628@github.com>

TXID: 556ef9319555c6fc51f98e27e370258407ac095dff93811ca54bc704f52c939e

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/928#issuecomment-948522628
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211021/c8e27a79/attachment.htm>

From notifications at github.com  Thu Oct 21 13:50:45 2021
From: notifications at github.com (chimp1984)
Date: Thu, 21 Oct 2021 04:50:45 -0700
Subject: [bisq-network/bisq] BSQ swap low risk refactorings (PR #5770)
In-Reply-To: <bisq-network/bisq/pull/5770@github.com>
References: <bisq-network/bisq/pull/5770@github.com>
Message-ID: <bisq-network/bisq/pull/5770/push/8205735193@github.com>

@chimp1984 pushed 1 commit.

d063aff5bfd8bfc3425cccd1b0c5fbdb44ea09e1  Let OfferPayload extend OfferPayloadBase


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/bisq-network/bisq/pull/5770/files/c0e70b81ef641801a84ef37188e57e20bcdc1306..d063aff5bfd8bfc3425cccd1b0c5fbdb44ea09e1
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211021/9040bfc8/attachment-0001.htm>

From notifications at github.com  Thu Oct 21 14:41:24 2021
From: notifications at github.com (sqrrm)
Date: Thu, 21 Oct 2021 05:41:24 -0700
Subject: [bisq-network/bitcoinj] Wallet: clone transaction before
 committing (#38)
In-Reply-To: <bisq-network/bitcoinj/pull/38@github.com>
References: <bisq-network/bitcoinj/pull/38@github.com>
Message-ID: <bisq-network/bitcoinj/pull/38/push/8206160639@github.com>

@sqrrm pushed 1 commit.

8bfa8c3e3f4da52cbeebe66e59dc9118fe665bd8  SPVBlockStoreTest: Disable testing SPVBlockStore deletion on Windows.


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/bisq-network/bitcoinj/pull/38/files/d6e6f397738bc0f9f489640175067439120a9cf9..8bfa8c3e3f4da52cbeebe66e59dc9118fe665bd8
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211021/4aa6e54f/attachment.htm>

From notifications at github.com  Thu Oct 21 15:13:29 2021
From: notifications at github.com (chimp1984)
Date: Thu, 21 Oct 2021 06:13:29 -0700
Subject: [bisq-network/bitcoinj] Wallet: clone transaction before
 committing (#38)
In-Reply-To: <bisq-network/bitcoinj/pull/38@github.com>
References: <bisq-network/bitcoinj/pull/38@github.com>
Message-ID: <bisq-network/bitcoinj/pull/38/review/781495095@github.com>

@chimp1984 approved this pull request.

utACK
Take my utACK with caution. Not familiar much with BitcoinJ and not sure if there would be a better way to make sure deleting would work on Windows. But I guess its acceptable to get the test on windows ok. 

> @@ -1891,7 +1891,14 @@ public void receivePending(Transaction tx, @Nullable List<Transaction> dependenc
                 return;
             if (isTransactionRisky(tx, dependencies) && !acceptRiskyTransactions) {
                 // isTransactionRisky already logged the reason.
-                riskDropped.put(tx.getTxId(), tx);
+
+                // Clone transaction to avoid multiple wallets pointing to the same transaction. This can happen when
+                // two wallets depend on the same transaction.
+                Transaction cloneTx = tx.getParams().getDefaultSerializer().makeTransaction(tx.bitcoinSerialize());
+                cloneTx.setPurpose(tx.getPurpose());
+                cloneTx.setUpdateTime(tx.getUpdateTime());

Are there any other properties we need to move over to the cloneTx?
Maybe avoid code duplication at line 1913 and use a method for getting the clone from the tx?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bitcoinj/pull/38#pullrequestreview-781495095
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211021/33ce90f1/attachment.htm>

From notifications at github.com  Thu Oct 21 15:16:18 2021
From: notifications at github.com (jmacxx)
Date: Thu, 21 Oct 2021 06:16:18 -0700
Subject: [bisq-network/bisq] Cannot Confirm Payment Received (Issue #5772)
In-Reply-To: <bisq-network/bisq/issues/5772@github.com>
References: <bisq-network/bisq/issues/5772@github.com>
Message-ID: <bisq-network/bisq/issues/5772/948606516@github.com>

Unfortunately that logfile does not go back far enough to show why paymentAccountPayload was missing.  Could you arrange to send the older log files to your mediator so this can be investigated?  Thanks.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5772#issuecomment-948606516
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211021/3a953934/attachment.htm>

From notifications at github.com  Thu Oct 21 15:29:27 2021
From: notifications at github.com (chimp1984)
Date: Thu, 21 Oct 2021 06:29:27 -0700
Subject: [bisq-network/bisq] BSQ swap low risk refactorings (PR #5770)
In-Reply-To: <bisq-network/bisq/pull/5770@github.com>
References: <bisq-network/bisq/pull/5770@github.com>
Message-ID: <bisq-network/bisq/pull/5770/push/8206606297@github.com>

@chimp1984 pushed 1 commit.

b194960c63644761eb55bc2efa036e3fe7853949  Use TradeModel instead of Trade where appropriate.


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/bisq-network/bisq/pull/5770/files/d063aff5bfd8bfc3425cccd1b0c5fbdb44ea09e1..b194960c63644761eb55bc2efa036e3fe7853949
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211021/15f20eb6/attachment.htm>

From notifications at github.com  Thu Oct 21 15:29:38 2021
From: notifications at github.com (RequestPrivacy)
Date: Thu, 21 Oct 2021 06:29:38 -0700
Subject: [bisq-network/bisq] Trigger price doesn't automatically reactivate
 offer after price falls below threshold (Issue #5773)
Message-ID: <bisq-network/bisq/issues/5773@github.com>

### Description

If a Trigger price above the current price level is set and the price moves above, but comes back down after some time, the offer remains inactive and isn't reactivated.

#### Version

Bisq v1.7.4

### Steps to reproduce

- Make an offer to buy Bitcoin
- Set trigger price above current price level
- Check that offer is active
- Wait until price rises above said level 
- Observe how trigger sets offer inactive

(_If price comes back down_)

- Offer remains inactive

### Expected behaviour

Automatic reactivation of the offer after price falls below Trigger price level.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5773
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211021/0dc01280/attachment.htm>

From notifications at github.com  Thu Oct 21 15:36:51 2021
From: notifications at github.com (chimp1984)
Date: Thu, 21 Oct 2021 06:36:51 -0700
Subject: [bisq-network/bisq] BSQ swap low risk refactorings (PR #5770)
In-Reply-To: <bisq-network/bisq/pull/5770@github.com>
References: <bisq-network/bisq/pull/5770@github.com>
Message-ID: <bisq-network/bisq/pull/5770/push/8206675919@github.com>

@chimp1984 pushed 1 commit.

14765d6caa56fe1460f22c0fa0c7d0002945c860  Move protobuf OfferPayload.Direction to OfferDirection


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/bisq-network/bisq/pull/5770/files/b194960c63644761eb55bc2efa036e3fe7853949..14765d6caa56fe1460f22c0fa0c7d0002945c860
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211021/43d47ceb/attachment-0001.htm>

From notifications at github.com  Thu Oct 21 15:40:53 2021
From: notifications at github.com (chimp1984)
Date: Thu, 21 Oct 2021 06:40:53 -0700
Subject: [bisq-network/bisq] BSQ swap low risk refactorings (PR #5770)
In-Reply-To: <bisq-network/bisq/pull/5770@github.com>
References: <bisq-network/bisq/pull/5770@github.com>
Message-ID: <bisq-network/bisq/pull/5770/push/8206714589@github.com>

@chimp1984 pushed 1 commit.

611b9446094ac0389a49b2daccbb7b95784b714e  Move protobuf OfferPayload.Direction to OfferDirection


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/bisq-network/bisq/pull/5770/files/14765d6caa56fe1460f22c0fa0c7d0002945c860..611b9446094ac0389a49b2daccbb7b95784b714e
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211021/75f80309/attachment.htm>

From notifications at github.com  Thu Oct 21 15:41:36 2021
From: notifications at github.com (chimp1984)
Date: Thu, 21 Oct 2021 06:41:36 -0700
Subject: [bisq-network/bisq] BSQ swap low risk refactorings (PR #5770)
In-Reply-To: <bisq-network/bisq/pull/5770@github.com>
References: <bisq-network/bisq/pull/5770@github.com>
Message-ID: <bisq-network/bisq/pull/5770/push/8206721309@github.com>

@chimp1984 pushed 1 commit.

2f40eddae868c6294e44479738ad140222bcb413  Use bitcoinj 42bbae9 (with fix required for bsq swaps)


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/bisq-network/bisq/pull/5770/files/611b9446094ac0389a49b2daccbb7b95784b714e..2f40eddae868c6294e44479738ad140222bcb413
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211021/ccd7d22b/attachment.htm>

From notifications at github.com  Thu Oct 21 16:34:26 2021
From: notifications at github.com (Stan)
Date: Thu, 21 Oct 2021 07:34:26 -0700
Subject: [bisq-network/bisq] Refactorings (non funtional changes) (PR
 #5769)
In-Reply-To: <bisq-network/bisq/pull/5769@github.com>
References: <bisq-network/bisq/pull/5769@github.com>
Message-ID: <bisq-network/bisq/pull/5769/c948680224@github.com>

API tests pass for this branch.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5769#issuecomment-948680224
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211021/3adc08b6/attachment.htm>

From notifications at github.com  Thu Oct 21 17:48:21 2021
From: notifications at github.com (chimp1984)
Date: Thu, 21 Oct 2021 08:48:21 -0700
Subject: [bisq-network/bisq] BSQ swap low risk refactorings (PR #5770)
In-Reply-To: <bisq-network/bisq/pull/5770@github.com>
References: <bisq-network/bisq/pull/5770@github.com>
Message-ID: <bisq-network/bisq/pull/5770/push/8207860472@github.com>

@chimp1984 pushed 2 commits.

63c385bbba238b468bf675ff592e8db507af153b  Add support for RemoveDataMessage in testCapability
54f17b00af64c9aa706c3c39322e4c353b3f296d  Cleanups


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/bisq-network/bisq/pull/5770/files/2f40eddae868c6294e44479738ad140222bcb413..54f17b00af64c9aa706c3c39322e4c353b3f296d
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211021/39897476/attachment.htm>

From notifications at github.com  Thu Oct 21 17:55:11 2021
From: notifications at github.com (chimp1984)
Date: Thu, 21 Oct 2021 08:55:11 -0700
Subject: [bisq-network/bisq] Make clone offer feature more visible (Issue
 #5774)
Message-ID: <bisq-network/bisq/issues/5774@github.com>

The right click funtionality for cloning an existing offer is not very obvious to find. I think an additional icon in the open offer view next to edit would be better.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5774
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211021/857702d6/attachment.htm>

From notifications at github.com  Thu Oct 21 17:57:37 2021
From: notifications at github.com (chimp1984)
Date: Thu, 21 Oct 2021 08:57:37 -0700
Subject: [bisq-network/bisq] BSQ swap low risk refactorings (PR #5770)
In-Reply-To: <bisq-network/bisq/pull/5770@github.com>
References: <bisq-network/bisq/pull/5770@github.com>
Message-ID: <bisq-network/bisq/pull/5770/push/8207963483@github.com>

@chimp1984 pushed 1 commit.

ebfd1b557412b419b96adb4647547970f713ed30  Remove todo


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/bisq-network/bisq/pull/5770/files/54f17b00af64c9aa706c3c39322e4c353b3f296d..ebfd1b557412b419b96adb4647547970f713ed30
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211021/cbab61fb/attachment.htm>

From notifications at github.com  Thu Oct 21 18:10:36 2021
From: notifications at github.com (Stan)
Date: Thu, 21 Oct 2021 09:10:36 -0700
Subject: [bisq-network/bisq] BSQ swap low risk refactorings (PR #5770)
In-Reply-To: <bisq-network/bisq/pull/5770@github.com>
References: <bisq-network/bisq/pull/5770@github.com>
Message-ID: <bisq-network/bisq/pull/5770/review/785914921@github.com>

@ghubstan commented on this pull request.



>              user.removePaymentAccount(paymentAccount);
+        }

What would happen if 
- an open trade is moved to failed trades
- the payment acct associated with the formerly open trade is deleted
- the user attempts to move the failed trade back to open trades
?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5770#pullrequestreview-785914921
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211021/091ff7d1/attachment-0001.htm>

From notifications at github.com  Thu Oct 21 18:19:25 2021
From: notifications at github.com (Stan)
Date: Thu, 21 Oct 2021 09:19:25 -0700
Subject: [bisq-network/bisq] BSQ swap low risk refactorings (PR #5770)
In-Reply-To: <bisq-network/bisq/pull/5770@github.com>
References: <bisq-network/bisq/pull/5770@github.com>
Message-ID: <bisq-network/bisq/pull/5770/review/785925218@github.com>

@ghubstan commented on this pull request.



>      private final Preferences preferences;
     private final PriceFeedService priceFeedService;
     private final ObservableList<ClosedTradableListItem> list = FXCollections.observableArrayList();
     private final ListChangeListener<Tradable> tradesListChangeListener;
 
+    /**
+     * Supplies a List<Tradable> from this JFX ObservableList<ClosedTradableListItem>
+     * collection, for passing to core's ClosedTradeUtil which has no dependency on JFX.

My bad comment:  I should not have said anything about what might call this supplier, just remark that it can be used in layers that cannot have any JFX deps.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5770#pullrequestreview-785925218
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211021/b2197b22/attachment.htm>

From notifications at github.com  Thu Oct 21 18:40:08 2021
From: notifications at github.com (refund-agent2)
Date: Thu, 21 Oct 2021 09:40:08 -0700
Subject: [bisq-network/roles] Arbitrator (formerly known as Refund Agent)
 (#93)
In-Reply-To: <bisq-network/roles/issues/93@github.com>
References: <bisq-network/roles/issues/93@github.com>
Message-ID: <bisq-network/roles/issues/93/948789479@github.com>

### Cycle 29 compensation and reimbursement report

|Date  |ID      |Asset|Del payout                                                                                           |Refund tx                                                                                              |
|------|--------|-----|-----------------------------------------------------------------------------------------------------|-------------------------------------------------------------------------------------------------------|
|21 Sep|ZRDJOLD |GBP  |[0.0328](https://mempool.space/tx/55c3f385c885390b5c8f8be26db6092b37f0195de43d1f3edd1d1dd82e4d03f5)  |[-0.0323](https://mempool.space/tx/ca3005580dc37f7b081ff730d46d0e42e5459a7c830e393df905ba830c7a3976)   |
|23 Sep|LPEKMHOK|EUR  |[0.02](https://mempool.space/tx/ab8dc950616ad14002dce2ce85e8fd46fdd95cff0664b936ced2ead6128c03e6)    |[-0.0185](https://mempool.space/tx/897372b4e997894b45a798313404e1e9a0083a4c901dcc4a4022e0093430a796)   |
|23 Sep|6eqtx8c |GBP  |[0.075](https://mempool.space/tx/9c21561e7b5110854571bd5343d030c2e47a2717bf7f0239b5b6b84b565d3c53)   |[-0.075](https://mempool.space/tx/b527b939414a5f26dc2459e3eaca3d17ede191afee93de9da29b5fab346fb1ca)    |
|28 Sep|PrBITcK |EUR  |[0.02](https://mempool.space/tx/17c15094761f1433a7708651305a39b98198e20c0aa59447b04c592f42a445ca)    |[-0.0185](https://mempool.space/tx/c37306ed086ed5792cba2ad4b00175f72f65aad9c6c9e751bb83022f1a004a72)   |
|28 Sep|07094777|EUR  |[0.01534](https://mempool.space/tx/1fc3896120956ef6560282cd894f17df11790b87ccb7690bf475b5d319bf8bba) |[-0.014809](https://mempool.space/tx/214e49cbf9b69a1bb5882965aeacf544d033a39dd73009f1f61d807874082475) |
|28 Sep|39728485|EUR  |[0.01781](https://mempool.space/tx/84e17f8706879c032a7937efaeea8782e50857c65730269107c0281da25c6cbc) |[-0.0171935](https://mempool.space/tx/a0cd449e86b526a36b155c4c117d5af1c69e5d80ddb4e3b92459b61417e00d10)|
|28 Sep|05528568|EUR  |[0.013](https://mempool.space/tx/c38c7cd6c122714d6d2f8722e9d7656553b0385aa04da93c007837da1ab9b16d)   |[-0.013](https://mempool.space/tx/5d46b217ebbf36e00cb919338c8081bf10c93fbb003ac75521dc103de16fd5be)    |
|02 Oct|2553387 |EUR  |[0.0065](https://mempool.space/tx/0f23a3805239a98fb87c8273a613c2e3bf269e02490f9f92e06268d6efe1a493)  |[-0.006](https://mempool.space/tx/599d47c20807336cf273e9b7181df6d8085cdf445faa852e0ad278463e25cd9b)    |
|02 Oct|RNVuXdG |GBP  |[0.015](https://mempool.space/tx/4c7f9271af0acc638009be760d2fefcbd8c0d9a431ee14a0c2decf6a5b453681)   |[-0.01425](https://mempool.space/tx/851a2af7fb6a2607e99535a848016357dadc4191b9be524196e80a3163817f9b)  |
|02 Oct|2975845 |XMR  |[0.004](https://mempool.space/tx/3d7b335f723e0fb2ad35ac66aefd87456f95d3c377163d786718c0a223ad12d3)   |[-0.004](https://mempool.space/tx/ac695999728d27b2051c4cd86df0d260ede69b6bd15038302609163993e02364)    |
|02 Oct|EQD0W   |XMR  |[0.325](https://mempool.space/tx/8e96d4ed7dd627eee05374090e557f19ad6ff856d35bc12ca0048a973215c3c2)   |[-0.323125](https://mempool.space/tx/31385038b5ff24888159d8cffc428de4da1dbc3d60083da7d8ca4072f4ec584a) |
|02 Oct|QVPCM4Y |EUR  |[0.0585](https://mempool.space/tx/cf04e82f2e2c5bb2327943de2e83bf7ea75944c8249f6af239885a532f18b9fc)  |[-0.0585](https://mempool.space/tx/a1ad72c791a27a30d5c63c19dab125e06e2bee5df2977e5d3140a288626a7130)   |
|05 Oct|XGNWZ   |EUR  |[0.02](https://mempool.space/tx/bd117b581c8914db3e9964fa9d71fc5681dd7593212f711944efd818aa0509d0)    |[-0.0185](https://mempool.space/tx/44383050c1d450aa465624afecfe024f5572d4fccde87fa270a2068e27d77f5f)   |
|05 Oct|07690115|EUR  |[0.022](https://mempool.space/tx/c995e5511c3e9b183a97f4473b4edbd1a415ad79c8afa7b9765633533a00faee)   |[-0.02035](https://mempool.space/tx/cb6ced9052529e8e6540aafcfbcc57a79439e816bff3442350a7eb23e90be543)  |
|11 Oct|aGzPY3eY|CAD  |[0.01501](https://mempool.space/tx/249785d3acdfaab227d658235e782d4dac9a8f579c9d4189d70a304a56cd924c) |[-0.01451](https://mempool.space/tx/9d6c91a7fd432ea95054258e6392d829b029c50032793558fdeb4d1a496d04ad)  |
|11 Oct|994417  |CAD  |[0.015202](https://mempool.space/tx/c383cc378c63626e15e06978a391e558a41d5a1ae453b65d4e03e837122db4eb)|[-0.014702](https://mempool.space/tx/88cd2684a17ecb4175c27bbaa7f996d1b4f1f46d17e602be2959ea8a8b068d52) |
|15 Oct|0316603 |USD  |[0.016136](https://mempool.space/tx/2aa9fca27593bbc9d583bbaf09ba1f989f0e48c8a2e52bf21017a87e4ff00fdc)|[-0.0149088](https://mempool.space/tx/b5d08c1c5d7d3fa3c07f5ba8528de1da15d9355212b11ecc6b2f89ea0e6588a5)|
|15 Oct|hjgvDnd |USD  |[0.01](https://mempool.space/tx/500625c493615952e6a68f5207230530f7a4da4999328ea13395bcf2e2e0f226)    |[-0.0095](https://mempool.space/tx/4342006f6280bfeaae2ef60465a4a387dbe273c88287bf377a9de90071fce991)   |
|15 Oct|POATYOEN|CAD  |[0.086](https://mempool.space/tx/195adb9594916d6142e29d4388b50ba96927ee3b064ec83ec7e85f01c2183b35)   |[-0.0833](https://mempool.space/tx/ff8866f122b3407be83f454e2078c5d7b00a9226fe72eb51430e19e0bd4f16d4)   |
|20 Oct|9186044 |BRL  |[0.014](https://mempool.space/tx/dc593073aa84590df0bc47fff5f37310cb31b84c71de7deb760a6f50b5f5d34a)   |[-0.0134](https://mempool.space/tx/63188ef71735ef123718e70e07a894563fcd499325d9e0721fc3a1fd0950dfb8)   |
|20 Oct|76343   |USD  |[0.008](https://mempool.space/tx/fcf8656e403212111270f7d99dd6d0ce2926aaaf2ebf17abdd924d3baf16046b)   |[-0.0075](https://mempool.space/tx/22dee8b8249474537457b491b28f50ae8da932966cf7344705a37f53d0731ec2)   |
|21 Oct|33019906|EUR  |[0.013](https://mempool.space/tx/cb9c76b5e16fe6a72e28b3a06ae24c9029be09ded2ce3aeac6a4aa7ca987d601)   |[-0.013](https://mempool.space/tx/c138bf2e0d9f02234ccf3314ba9a614524b426f591b9f36b39f5667f6297947e)    |
|      |        |     |0.822298                                                                                             |-0.8048483                                                                                             |

|COMPENSATION   |1037.33 BSQ|For Cycle 29|FIELD4   |REIMBURSEMENT|25904.41 BSQ|
|---------------|-----------|------------|---------|-------------|------------|
|Number of cases|22         |Subtotal    |$1,100.00|Refunded     |0.80485     |
|USD per case   |$50        |            |         |             |            |
|1% payouts     |0.0080485  |Subtotal    |$507.86  |30D BSQ/BTC  |0.00003107  |
|BTC price      |$63,100    |            |         |             |            |
|               |           |Total       |$1,607.86|Fees to DAO  |0.01745     |
|BSQ rate       |$1.55      |            |         |             |            |

|Date           |ID       |Event   |BTC      |BSQ         |BTC       |BSQ       |                                                                                       |                                                                                       |
|---------------|---------|--------|---------|------------|----------|----------|---------------------------------------------------------------------------------------------|---------------------------------------------------------------------------------------------|
|21-09-20       |         |Cycle Beginning|2.64363280 BTC|-3,915.61   |-0.98324262 BTC|-55,610.13|                                                                                             |                                                                                             |
|21-09-29       |         |Reimbursement|         |            |          |36,052.00 |[link](https://github.com/bisq-network/support/issues/1004)                                  |[link](www.mempool.space/tx/66674809026a66c2ec28976e042d87322520a9c9c874e61ecc646fbcb74b934c)|
|21-10-03       |wmjdpnxo |RA trade|-1.20900000 BTC|37,781.25   |1.20900000 BTC|-37,781.25|[link](www.mempool.space/tx/9a4246470d36e98fc82b764c55c114d9c91c0456778a25a7aacb686f5551065d)|[link](c166575af06dda3995487a4d6447b7b417189f86b3e7feef42e083e4a4fc9e55)                     |
|               |         |total payouts|0.822298 |            |-0.8048483|          |                                                                                             |                                                                                             |
|               |         |        |         |            |          |          |                                                                                             |                                                                                             |
|               |         |State after Cycle 29|2.25693080 BTC|33,865.64   |-0.57909092 BTC|-57,339.38|                                                                                             |                                                                                             |


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/roles/issues/93#issuecomment-948789479
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211021/9da70095/attachment.htm>

From notifications at github.com  Thu Oct 21 18:44:12 2021
From: notifications at github.com (refund-agent2)
Date: Thu, 21 Oct 2021 09:44:12 -0700
Subject: [bisq-network/roles] Arbitrator (formerly known as Refund Agent)
 (#93)
In-Reply-To: <bisq-network/roles/issues/93@github.com>
References: <bisq-network/roles/issues/93@github.com>
Message-ID: <bisq-network/roles/issues/93/948792499@github.com>

### Cycle 29 support report.

- One trade has been delayed for more than a month at arbitration, further details will come publicly soon.
- 19/22 trades are traders not responding.
- In one case, both traders have been penalized, one did wrong at mediation and other did not show at arbitration.
- No arbitration cases solved out of Bisq on this cycle. Thanks for solving that!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/roles/issues/93#issuecomment-948792499
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211021/8afb5d05/attachment-0001.htm>

From notifications at github.com  Thu Oct 21 18:50:31 2021
From: notifications at github.com (refund-agent2)
Date: Thu, 21 Oct 2021 09:50:31 -0700
Subject: [bisq-network/compensation] For Cycle 29 (Issue #933)
Message-ID: <bisq-network/compensation/issues/933@github.com>

<!--
Compensation requests have a specific format that enables them to be evaluated by a bot for more efficient budgeting. Please make sure you stick to the template. A linter will evaluate your request after you remove [WIP] from the issue title and notify you of any issues.

See the following link for details:
https://bisq.wiki/Making_a_compensation_request

Feel free to browse other requests if you're not sure about something, or reach out in #compensation on Keybase (https://keybase.io/team/bisq).
-->


## Summary

> _Specify the total amount of BSQ you are requesting, along with the USD total and BSQ/USD rate (don't include the brackets!):_

- **BSQ requested**: **`1037.33`** <!-- [BSQ amount] should be: USD amount / BSQ rate -->
- USD requested: 1607.86 <!-- [USD amount] should be: total of all contributions listed in "contributions delivered" table below -->
- BSQ rate: 1.55 USD per BSQ <!-- [rate] should be the rate used to determine the BSQ amount above, as specified in the cycle's rate announcement (https://bisq.wiki/Compensation_Maintainer#Announce_BSQ-USD_rate) -->
- Previous compensation request (if applicable): #909  <!-- Link to last compensation request submitted -->


## Contributions delivered

> _Add contributions you have [delivered](https://github.com/bisq-network/proposals/issues/19) and roles you have performed here as new rows in the table below. Role line-items should include an asterisk (*) in the team column._

| Title | Team | USD | Link | Notes |
| --- | --- | --- | --- | --- |
| Refunds | *Support | 1607.86 | https://github.com/bisq-network/roles/issues/93#issuecomment-948789479 |  |

<!-- 

Each contribution should be a new line-item in the table above. 

Title - optional, string.
Team - optional, must one of the following: admin, dev, growth, ops, support (case-insensitive). If the line-item is for a role, please add a `*`. See Example 2 below.
USD - optional, number. Please do not specify 'USD', as the column title makes units clear.
Link - optional, string.
Notes - optional, string.

Example 1 - typical contribution:

| Add local Bitcoin node configuration detection | dev | 240 | https://github.com/bisq-network/bisq/pull/3982

Example 2 - role (note the asterisk):

| Community manager | growth* | 400 | https://github.com/bisq-network/roles/issues/95#issuecomment-628431613

Example 3 - list of minor contributions, such as reviews:

| | | | https://github.com/bisq-network/bisq/pull/3968 | This and PRs below too small to be valued separately. See total at bottom.
| | | | https://github.com/bisq-network/bisq/pull/4040
| | | | https://github.com/bisq-network/bisq/pull/4044
| | | | https://github.com/bisq-network/bisq/pull/4048
| | | | https://github.com/bisq-network/bisq/pull/4066
| | dev | 400 | https://github.com/bisq-network/bisq/pull/4062 | Total for items above.

-->


## Contributions in progress

> _Provide links to work you're involved with that is still [in progress](https://github.com/bisq-network/proposals/issues/19). **This section is optional (the linter ignores it),** and is for your own benefit in keeping track of what you're doing and keeping other contributors up to date with the same._


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/933
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211021/8309a005/attachment.htm>

From notifications at github.com  Thu Oct 21 18:54:49 2021
From: notifications at github.com (refund-agent2)
Date: Thu, 21 Oct 2021 09:54:49 -0700
Subject: [bisq-network/support] Refund agent reimbursement for cycle 29 (Issue
 #1013)
Message-ID: <bisq-network/support/issues/1013@github.com>

On cycle 29 I [paid](
https://github.com/bisq-network/roles/issues/93#issuecomment-948789479) 0.80485 BTC. 30D BSQ/BTC rate is 0.00003107.

I ask DAO to reimburse me  **25904.41 BSQ**.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/support/issues/1013
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211021/956ca4e4/attachment.htm>

From notifications at github.com  Thu Oct 21 19:28:45 2021
From: notifications at github.com (Devin Bileck)
Date: Thu, 21 Oct 2021 10:28:45 -0700
Subject: [bisq-network/compensation] For Cycle 29 (Issue #929)
In-Reply-To: <bisq-network/compensation/issues/929@github.com>
References: <bisq-network/compensation/issues/929@github.com>
Message-ID: <bisq-network/compensation/issues/929/948848141@github.com>

Tx ID babe42f8dff4dd7a2ac0f2b517d9800cc1a7aab989671a573db092cdb887a317

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/929#issuecomment-948848141
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211021/2c9da37e/attachment.htm>

From notifications at github.com  Thu Oct 21 19:30:51 2021
From: notifications at github.com (Stan)
Date: Thu, 21 Oct 2021 10:30:51 -0700
Subject: [bisq-network/bisq] BSQ swap low risk refactorings (PR #5770)
In-Reply-To: <bisq-network/bisq/pull/5770@github.com>
References: <bisq-network/bisq/pull/5770@github.com>
Message-ID: <bisq-network/bisq/pull/5770/review/786006518@github.com>

@ghubstan commented on this pull request.



> +package bisq.core.trade.model;
+
+import bisq.core.offer.Offer;
+import bisq.core.trade.protocol.ProtocolModel;
+import bisq.core.trade.protocol.Provider;
+import bisq.core.trade.protocol.TradePeer;
+
+import bisq.network.p2p.NodeAddress;
+
+import bisq.common.taskrunner.Model;
+import bisq.common.util.Utilities;
+
+import javafx.beans.property.ReadOnlyStringProperty;
+import javafx.beans.property.SimpleStringProperty;
+import javafx.beans.property.StringProperty;
+

Since this lives in the core gradle subproject, could it be refactored a bit to get rid of these three imports?
```
import javafx.beans.property.ReadOnlyStringProperty;
import javafx.beans.property.SimpleStringProperty;
import javafx.beans.property.StringProperty;
```
I know they are critical for the bisq desktop app, but in a more modular system (like the misq prototype), they would be excluded from its `core` module, and this `TradeModel` could / would be used in all three higher level modules (grpc, web, jfx) without mixing any user-interface dependencies that one or the other higher level module would not use.  Put another way, the misq `grpc` and `web` modules should not have to include any `javafx` dependency, but it would have to if they wanted to use this class.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5770#pullrequestreview-786006518
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211021/e01f976a/attachment.htm>

From notifications at github.com  Thu Oct 21 19:58:44 2021
From: notifications at github.com (chimp1984)
Date: Thu, 21 Oct 2021 10:58:44 -0700
Subject: [bisq-network/bisq] Bsq swap impl (PR #5775)
Message-ID: <bisq-network/bisq/pull/5775@github.com>

Based on https://github.com/bisq-network/bisq/pull/5770

Starts at 9c56202

This adds the whole BSQ swap implementation. I did not see much value in breaking it up into many commits. I think for review its best to check it out and do a full compare to the previous PR to see the changes.
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/5775

-- Commit Summary --

  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/8fbccb75479ffcb1e7b1fcc0feed03aa7fc55735">Bump version number for v1.7.5</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/e39ae59683f6c45fd741063a364d7ae8366d43c9">Update translations for v1.7.5</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/48a0ebe30973915fd80ff778a131d33a8012a616">Add new v3 onions for wiz&#39;s bitcoin nodes</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/577b07ba9a9b50fdb76d9cdb2d675781c17eed53">Move OfferPayload into package bisq.core.offer.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/19f813eea3b0ed753e8bc90754585e1a4f0344c0">Move CreateOfferService into package bisq.core.offer.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/d98cb278057e27907ba894f696732026a5ba4820">Move MarketPriceNotAvailableException into package bisq.core.offer.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/346fc79094cc0941b2ede33edb3d8d778b81c1a5">Move MutableOfferPayloadFields into package bisq.core.offer.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/8a4c05c1e48b9fd81640456defecc8d472cb8f6c">Move TriggerPriceService into package bisq.core.offer.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/ade5d322374f455a54dd48e9e82e754e9e596b5f">Move TakeOfferModel into package bisq.core.offer.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/20d298061d8c4213bd46f62eedf623f610654288">Move AvailabilityResult into package bisq.core.offer.availability</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/0107519f4307aa594b1a695515d0b31eab39da6c">Move bisq.core.offer.messages package into package bisq.core.offer.availability</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/ed9f248c277afb23464860913119835f79e6395e">Move content of bisq.core.offer.placeoffer package into package bisq.core.offer.placeoffer.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/b584fdf419b031818016505596aa6b899e492972">Rename OfferFilter to OfferFilterService</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/0e23cbe24e63b2a7e792bd496db510ea028e4388">Move Contract, SellerAsMakerTrade, SellerAsTakerTrade, SellerTrade,</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/c0cca781de5646ccf7836341f15ae65e7c30b6e6">Make updateDepositTxFromWallet public</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/0f7cfa99d51d87f378d994c75ef9ec3c8303619c">Move Trade to bisq.core.trade.model.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/5944218a4bb31d914f08b96560f0b1fb3aad61b1">Move MakerTrade and TakerTrade to bisq.core.trade.model package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/5a0145d1d94b31c916f6dca30fbdaa4b60dd67e1">Move Tradable to bisq.core.trade.model package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/81ec06d0dcf397a224fbc950be2fd67ea3f7fb1e">Move TradableList to bisq.core.trade.model package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/2489bbc119db6095abef7a7c659cd851b8ad0509">Make FluentProtocol.Event public</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/c0d13083c8c64ea486a1013059d3a5e1d4fca32e">Make setup in FluentProtocol public</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/87c12fda8c9d95cac288235dd9655ba707ac3391">Move protocol classes to bisq.core.trade.protocol.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/babd70cc2a8230ba72cf8ed205ec326ef2d24969">Move tasks package into bisq.core.trade.protocol.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/5099d974353f424af82d611b416e64e23d123202">Move TradingPeer into bisq.core.trade.protocol.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/a212cec19c9bb32d9bd781e9ac33d75c552fa4a9">Move messages package into bisq.core.trade.protocol.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/c9817ed6dbb1709077b46d07da50566b3a3545ca">Move ClosedTradableManager, FailedTradesManager into bisq.core.trade.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/1b74b4efe9bb3907c0d9dfdf0b482c4cad8b24af">Rename CleanupMailboxMessages to CleanupMailboxMessagesService</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/2141f8f665dab4933022f38d1a2c6b1e42e51d84">Move CleanupMailboxMessagesService, ClosedTradeUtil to package bisq.core.trade.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/f871e8339d294334f46b42ee41572d6c54177a80">Move TransactionResultHandler, TradeResultHandler to package bisq.core.trade.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/71c663eb5306a6e7cbd05d55e95f984eaddd95ec">Move TradeDataValidation, DumpDelayedPayoutTx, TradeDataValidation, TradeUtil, TradeTxException to package bisq.core.trade.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/26e2676268f409aa12d9d9e5a814c587c4a8a01b">Rename ProcessModelServiceProvider to Provider</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/c282b700010479b5c67f978eb434b5d41529f669">Rename txID to txId</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/30dd5683ef08083949252f4924065389f4a4bc15">Move createoffer package inside bisq.desktop.main.offer.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/0cd0e16b53870ff663c357e9e78adf92be157dbc">Move takeoffer package inside bisq.desktop.main.offer.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/4169a8719bf8984e6e1afd8fe67eca987682e807">Move MutableOffer view classes into bisq.desktop.main.offer.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/a2a7e87af5ef944f17dbdc2e0a531a20fd7a854e">Move OfferDataModel, OfferViewUtil into bisq.desktop.main.offer.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/a9f4bb76b687f724db84b37f69603b9289a5ea6a">Rename FeeUtil to OfferViewModelUtil</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/1e03aae2ac81ada51fc8a319b83be5209a1684c7">Move OfferViewModelUtil into bisq.desktop.main.offer.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/72284d7d9f7c25236010a88389e88c218012248d">Cleanups, refromatting, add final qualifier</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/71eec7b2e0c98b8b036d4ab3fa52cc4701e0fc30">Move TradingPeer to package bisq.core.trade.protocol.bisq_v1.model</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/e1efc5e96fc6909e28446876c36393cc3e80a4e4">Make setPaymentStartedAckMessage and setDepositTxSentAckMessage public</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/760732f03a2cff68590935bd92f63ac81793f823">Move ProcessModel to package bisq.core.trade.protocol.bisq_v1.model</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/94d3638d9841c8653a5db40fa5b1c52fa3e3b0e4">Remove m52go bitcoin node</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/41d9d3f505516ed34c1f33d86952ef8f4d036d75">Move OfferPayload into package bisq.core.offer.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/edf5c3e097094f35e4f25c439416cff196afbf76">Move CreateOfferService into package bisq.core.offer.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/4341a7e0d2c5610baa95b09bdb82584b520bc776">Move MarketPriceNotAvailableException into package bisq.core.offer.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/042476a68a22ea95eb9faaa84eeed8594a6c3d06">Move MutableOfferPayloadFields into package bisq.core.offer.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/d9fd8a45f72d377e2ba04c95df1974aa44e36b87">Move TriggerPriceService into package bisq.core.offer.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/e348000cb16923ab1b973ad9aa1bb0d2f616cc16">Move TakeOfferModel into package bisq.core.offer.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/a2d1e8888d0c6274121428b86cdd39b32f3d6ba0">Move AvailabilityResult into package bisq.core.offer.availability</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/1badd699a4a6a82910701a89c5fbad4115985503">Move bisq.core.offer.messages package into package bisq.core.offer.availability</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/7197b316fccd63e2f0b66d27d167ea6cd0452c11">Move content of bisq.core.offer.placeoffer package into package bisq.core.offer.placeoffer.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/1b4c4871c0d03e00dbc07571ac120d2a3a9c534d">Rename OfferFilter to OfferFilterService</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/1e9b6065441d27873ad962920aed363ed9a25aa0">Move Contract, SellerAsMakerTrade, SellerAsTakerTrade, SellerTrade,</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/8b21b85c3e8fd20b8d5c541ee6ad6ee5e099a0c6">Make updateDepositTxFromWallet public</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/d42242762ffb448e8ebdda5e311602e6db60f1c7">Move Trade to bisq.core.trade.model.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/fc3177c23f06d16eed25408fe7064f5364b2e42f">Move MakerTrade and TakerTrade to bisq.core.trade.model package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/58cfcffeb970ffc81d9ba6979eb256892ce00ff2">Move Tradable to bisq.core.trade.model package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/3474a2b69520d52af239c79cbaa65135bdc776d5">Move TradableList to bisq.core.trade.model package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/d7b2e99e43a404c6121dcbb94a0acaf028037dbe">Make FluentProtocol.Event public</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/e3eea6350cb07f3c517e0fc148b4d771fff26afc">Make setup in FluentProtocol public</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/1b2e798faaa64fa19a3cd858c99c6af22d38fa99">Move protocol classes to bisq.core.trade.protocol.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/508296c2a3b609ab9166d250226271622f430d34">Move tasks package into bisq.core.trade.protocol.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/97906e05db34277a96631c4e4eeaef91dd732f04">Move TradingPeer into bisq.core.trade.protocol.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/cbf2822cdf422cfca7404a0cb4486f498bc8a171">Move messages package into bisq.core.trade.protocol.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/fd6934c4e3f1fd93744343bc7c1f907b7e981f8c">Move ClosedTradableManager, FailedTradesManager into bisq.core.trade.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/fe2871baa50c5f196e92458d38bdda53ab9b6d77">Rename CleanupMailboxMessages to CleanupMailboxMessagesService</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/e80cdf8ac7217ab0e2025be10e0feaa6dc8a5ee6">Move CleanupMailboxMessagesService, ClosedTradeUtil to package bisq.core.trade.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/956ffc902d2258199a07f96adaa91ff98ae2411a">Move TransactionResultHandler, TradeResultHandler to package bisq.core.trade.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/eacf446ab422352bb303eb9830b3dc03d9adc8e4">Move TradeDataValidation, DumpDelayedPayoutTx, TradeDataValidation, TradeUtil, TradeTxException to package bisq.core.trade.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/e1de502a9bf1aae7e87830096934ac6a1684665d">Rename ProcessModelServiceProvider to Provider</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/2733af955a3ec04d4311a18b691415933146b35c">Rename txID to txId</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/932c0f856aa36ee87cb55dbb3b4e11992ed2b13c">Move createoffer package inside bisq.desktop.main.offer.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/0efa0bd7cad6278faac96edc64f4008061a7998f">Move takeoffer package inside bisq.desktop.main.offer.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/601956dc1fe2927549ff7723ef8cd25f16f646ee">Move MutableOffer view classes into bisq.desktop.main.offer.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/9777005ec7e44b4efb123e7d5a9c48976bde2a81">Move OfferDataModel, OfferViewUtil into bisq.desktop.main.offer.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/4a9db790682506fdda88f6d31f5874fc473dba2e">Rename FeeUtil to OfferViewModelUtil</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/25bbad1f9c9f5383d8af6f64cbacdb74df2b1d01">Move OfferViewModelUtil into bisq.desktop.main.offer.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/777287af95cfd791389b0cdbf9eecf9b98913496">Cleanups, refromatting, add final qualifier</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/401880b64e8f8645e42d6a34179fcc71000c7363">Move TradingPeer to package bisq.core.trade.protocol.bisq_v1.model</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/afed78813d3d81c1ca4d63adac6ca0d5cffb1741">Make setPaymentStartedAckMessage and setDepositTxSentAckMessage public</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/734d429cc9612709bcee8c0e4784070406daf731">Move ProcessModel to package bisq.core.trade.protocol.bisq_v1.model</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/dca0c93f477f66da22f6eeba2532fffb844dde90">Cleanups</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/e75296557739f6b8ae86bd3004781fd268036a9e">Add linebreak in error popup</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/9f3034e91c83559c5a37b7c235c0c997a0e84042">Fix layout/text issues</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/dc82fbabab24ab385b085afdfe0ef88c62849970">Increase visibility</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/8768345b74148ab49f57cefef9952bb2ad5667be">Remove Inject annotation at abstract classes</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/d1d1706a7f05539b930db6437f20b6934576515e">Add delegate methods to offer</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/dfbc746d5b4dc3fd4c115adb34498089e744918d">Move Offer.Direction one level up and rename to OfferDirection</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/6cf0a7c126fb2bf43ca004bb139b5b856ad1d67e">Rename paymentMethod.isAsset to paymentMethod.isBlockchain</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/dad19ba1c174087e3f29f66577739409e32bc544">Add isFiat and isAltcoin methods.</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/88198be7ffbfe00854207e3f9e6e907ffd7581b2">Rename availableConfirmedBalance to availableBalance</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/d4bb026e3e7ce64710a947557962e0f4e32bfc26">Only check for localhost btc node if mainnet</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/f8751a8c4d5974068864f90729c889411f86ae73">Make TxConfidenceListener and its onTransactionConfidenceChanged method abstract</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/a927bea71f236769af7d5c3bba37488fd58370ec">Add scriptTypeId to RawTransactionInput</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/75072ebc26acef94bfe15eba5eaa3c152c63a416">Add deprecated annotation, null checks and comment to getRawInputFromTransactionInput</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/561ebe940e369aaa54668fa50751c154cc047764">Move test classes into bisq.desktop.main.offer.bisq_v1.createoffer</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/8ee255412fe1fe5ea023654614d99f05837afed5">Merge branch &#39;bsq-swap-low-risk-refactorings&#39; into wip-merge2</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/559bc58ec23b942b0b90a2325800d40e5302af90">Fix merge issues</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/34c4eefb590c0678b3523a70e0673efdba109fea">Add allowSpendMyOwnUnconfirmedTxOutputs flag to BsqCoinSelector</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/47572888e7711f176b6018c9561d8b11447afff1">Add isMine method. Add error logs</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/0f6364d2bd4625619e6dbcce925efb0565db4639">Inline TransactionWitness</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/e582ffddad7db84481b76f6a518fc13c5796cdc2">Add new methods</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/54e81d14731ee57a8ede3e5857e6b4c73f134ce2">Add signTx and verifyNonDustTxo methods</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/5f8bc834f798e94e25a0540a154c33598eb4be76">Remove unused signTx method</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/d95356be211786d67ebd47e27e8801e33f3197e6">Add verifiedBalance field.</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/cfc404b4c0ee8d495c167446e58e88ad152d1407">Rename signTx to signTxAndVerifyNoDustOutputs (no code change)</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/82c1be1d97f57c0bd2b2380125468d80d607bbd7">Change log level</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/c15fc0c0a7a1d33db8a334881d03e9ee1185ce47">Add comment, cleanups</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/d7f1b00221ac07b914cd37302888edb357f5bc71">Rename processModel.getTradingPeer to getTradePeer</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/02d7dfdaefeeaea5aaadf5a85596abb1c500d2cb">Only print stack trace if dev mode</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/9e4be1367a399d6d24fe075409331ff028a004fc">Change log level</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/8d2579866a61508f3c1e5cd7559763006ef941e6">Replace Value annotation with Getter and EqualsAndHashCode</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/d976f11e09db208a9abceca4bb265c18e17713b6">Add methods</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/a3b3d561ecc0685e017e1f498715326de4dee570">Simplify</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/9d106468b04f53fae29b76f80e7d95575a6afb5c">Move getRandomOfferId method to OfferUtil</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/e061d6a476e78b7368ec88952bf27bf2e9a6b0f3">Replace Value with Getter</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/5b0e9ab92fbe8b62ef612e5f8cab27d17a33f2c4">Rename trade.getPhase to getTradePhase</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/544dd895fc279926e11e23565286dff2de0d9dd9">Rename trade.getState to getTradeState</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/12fff5403d9d13045726ee08410fcb2f3d3706f6">Cleanup</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/2440d7234d2d7fc83e772e0a2ff9c52128cd3f6f">Extract methods, Cleanups</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/4cb074694da118b3f62c4e21ea7b92d197e5e1bc">Extract methods, cleanups. Rename methods and vars</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/7211f892e13041979784ebaa2896f45975a2982c">Add exclude fields to EqualsAndHashCode</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/07883e9b8ba1fc5b5f4de146e28c0542c8da21b9">Rename trade.getPhase to getTradePhase</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/0148a36566c554c3c898d8fc8e14ba60d7abd723">Extract to method in TradeUtil</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/10516407de34fc3d07255ec246dac99bce07151a">Use early return. cleanup</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/8219bf84070dab6cb4ce448c94ff26da7b114bc2">Extract method. Rename vars</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/ee374c3c39720e540a79311d48a1d6daa93d8abd">Cleanups, apply rename of getTradePhase</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/e940f6f9f0a06059ec0e003dfbc4a01b775598f4">Add method. Dont return null in case of no amount but min fee</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/19aabba12c701f5aa311dd4d445484d711953ef9">Add method. cleanups</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/1c0b52cd31d27c1bf66f5cf6eb87fc75efb2aaca">Move OfferDirection from bisq.core.offer.bisq_v1 to bisq.core.offer</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/07354191a6bddb4ca5ff3bcee8a51c37ee6a43c5">Remove handling of BundleOfEnvelopes in send method.</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/b80b6ec836d778ef3a1a11e06d2a8f024931d947">Cleanups</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/23af4558b5e624d02a7457d9c217609555b1d641">Add filterPredicate</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/2e384ede59ec232e5b9e390a465eaec51f7f0fff">Make onDeleteAccount more clear</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/9d8c705104f53aefac8018e08cedc7ad35d1515e">Only add delay if not devmode</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/d2851574425c1fe587cdca81399c7b5bb325a463">Reduce visibility</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/8bb42e1421d4c6ee5e14cb91d53ac699e84e08fb">Add methods, move field up</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/1aa5e7053d70f2e25311481a0318698b478e72bf">Add method</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/8ac40a3e0cd34262d302ce5f8c59ac52411ca3c1">Add style</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/c60df6e978866162e16dcef6c6801419a0eacd3c">Add linebreak (no code change)</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/9fb6a6ca9f9666f805ee6bea4882c45df10cfaa1">Add isNotPublished method (will be combined later with bsq swap checks)</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/cfae096c1f14952cebdb56edc909b354c2585e49">Add null checks, extract variables, cleanups</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/2ae1860dac9729c71e03a4649c6f8364fad26a5a">Move tests to package bisq.desktop.main.offer.bisq_v1.createoffer</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/080dc3e8a1cfc17004b4df32811af9fe81c91c54">Merge branch &#39;chimp-bsq-swap&#39; into wip-merge021.10</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/ab6e4e1b8f3fcb7f2f4bc0547980d7fc6724fec9">Dummy commit to enforce rebuild at CI</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/5412f8b669a13a6da70e8f3e365aeb64d56fa3be">Merge branch &#39;chimp-bsq-swap&#39; into bsq-swap-low-risk-refactorings</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/c920da36c08d679de8d1ef47b171e79c5765c2aa">Add abstract classes and interfaces. Let ProcessModel and TradingPeer extend those.</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/8cd85a77c148a7d01de9b41d25832ca0af6f334e">Let Trade extend TradeModel</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/dcd0101c52142dd534fe9bd738d766e3f9b5fd56">Generify TradeResultHandler</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/5d687bd064ab3754ffcf8614b5de982114823baf">Use TradeModel and ProtocolModel in TradeTaskRunner, TradeTask, TradeProtocol and FluentProtocol</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/308bb687c552573cd371c372dea4d93c8f1aa22d">Use TradeModel</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/453229e3708c0e9742b710b87cbdfd30db1425ad">Impl. onAckMessage. Add fields for concrete types</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/c0e70b81ef641801a84ef37188e57e20bcdc1306">Use TradeModel in trade domain</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/d063aff5bfd8bfc3425cccd1b0c5fbdb44ea09e1">Let OfferPayload extend OfferPayloadBase</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/b194960c63644761eb55bc2efa036e3fe7853949">Use TradeModel instead of Trade where appropriate.</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/14765d6caa56fe1460f22c0fa0c7d0002945c860">Move protobuf OfferPayload.Direction to OfferDirection</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/611b9446094ac0389a49b2daccbb7b95784b714e">Move protobuf OfferPayload.Direction to OfferDirection</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/2f40eddae868c6294e44479738ad140222bcb413">Use bitcoinj 42bbae9 (with fix required for bsq swaps)</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/63c385bbba238b468bf675ff592e8db507af153b">Add support for RemoveDataMessage in testCapability</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/54f17b00af64c9aa706c3c39322e4c353b3f296d">Cleanups</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/ebfd1b557412b419b96adb4647547970f713ed30">Remove todo</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5775/commits/9c5620276ea8ae015ad993379d3f972981edaf81">Add BSQ swap code</a>

-- File Changes --

    M apitest/scripts/trade-simulation-utils.sh (2)
    M apitest/src/test/java/bisq/apitest/ApiTestCase.java (10)
    M apitest/src/test/java/bisq/apitest/method/offer/AbstractOfferTest.java (10)
    A apitest/src/test/java/bisq/apitest/method/offer/BsqSwapOfferTest.java (172)
    M apitest/src/test/java/bisq/apitest/method/offer/CancelOfferTest.java (2)
    M apitest/src/test/java/bisq/apitest/method/offer/CreateBSQOffersTest.java (4)
    M apitest/src/test/java/bisq/apitest/method/offer/CreateOfferUsingFixedPriceTest.java (4)
    M apitest/src/test/java/bisq/apitest/method/offer/CreateOfferUsingMarketPriceMarginTest.java (4)
    M apitest/src/test/java/bisq/apitest/method/offer/EditOfferTest.java (4)
    M apitest/src/test/java/bisq/apitest/method/offer/ValidateCreateOfferTest.java (2)
    A apitest/src/test/java/bisq/apitest/method/trade/BsqSwapTradeTest.java (163)
    A apitest/src/test/java/bisq/apitest/method/trade/BsqSwapTradeTestLoop.java (65)
    M apitest/src/test/java/bisq/apitest/method/trade/ExpectedProtocolStatus.java (2)
    M apitest/src/test/java/bisq/apitest/method/trade/TakeBuyBSQOfferTest.java (16)
    M apitest/src/test/java/bisq/apitest/method/trade/TakeBuyBTCOfferTest.java (10)
    M apitest/src/test/java/bisq/apitest/method/trade/TakeBuyBTCOfferWithNationalBankAcctTest.java (10)
    M apitest/src/test/java/bisq/apitest/method/trade/TakeSellBSQOfferTest.java (18)
    M apitest/src/test/java/bisq/apitest/method/trade/TakeSellBTCOfferTest.java (12)
    M apitest/src/test/java/bisq/apitest/method/wallet/BsqWalletTest.java (6)
    M apitest/src/test/java/bisq/apitest/method/wallet/WalletTestUtil.java (6)
    M apitest/src/test/java/bisq/apitest/scenario/LongRunningOfferDeactivationTest.java (4)
    M build.gradle (4)
    M cli/src/main/java/bisq/cli/CliMain.java (1)
    M cli/src/main/java/bisq/cli/DirectionFormat.java (4)
    M cli/src/main/java/bisq/cli/GrpcClient.java (71)
    M cli/src/main/java/bisq/cli/opts/AbstractMethodOptionParser.java (2)
    M cli/src/main/java/bisq/cli/opts/CreateCryptoCurrencyPaymentAcctOptionParser.java (14)
    M cli/src/main/java/bisq/cli/opts/OptLabel.java (1)
    M cli/src/main/java/bisq/cli/request/OffersServiceRequest.java (58)
    M cli/src/main/java/bisq/cli/request/TradesServiceRequest.java (8)
    M common/src/main/java/bisq/common/app/Capability.java (3)
    M common/src/main/java/bisq/common/app/Version.java (2)
    M common/src/main/java/bisq/common/config/ConfigFileEditor.java (2)
    A common/src/main/java/bisq/common/crypto/HashCashService.java (181)
    A common/src/main/java/bisq/common/crypto/ProofOfWork.java (122)
    A common/src/main/java/bisq/common/crypto/ProofOfWorkService.java (156)
    A common/src/test/java/bisq/common/crypto/HashCashServiceTest.java (84)
    A common/src/test/java/bisq/common/crypto/ProofOfWorkServiceTest.java (81)
    M core/src/main/java/bisq/core/account/witness/AccountAgeWitnessService.java (25)
    M core/src/main/java/bisq/core/account/witness/AccountAgeWitnessUtils.java (2)
    M core/src/main/java/bisq/core/api/CoreApi.java (83)
    M core/src/main/java/bisq/core/api/CoreOffersService.java (132)
    M core/src/main/java/bisq/core/api/CorePaymentAccountsService.java (25)
    M core/src/main/java/bisq/core/api/CoreTradesService.java (50)
    M core/src/main/java/bisq/core/api/CoreWalletsService.java (5)
    M core/src/main/java/bisq/core/api/model/BsqBalanceInfo.java (15)
    A core/src/main/java/bisq/core/api/model/BsqSwapOfferInfo.java (227)
    A core/src/main/java/bisq/core/api/model/BsqSwapTradeInfo.java (323)
    M core/src/main/java/bisq/core/api/model/OfferInfo.java (4)
    M core/src/main/java/bisq/core/api/model/TradeInfo.java (10)
    M core/src/main/java/bisq/core/app/BisqExecutable.java (2)
    M core/src/main/java/bisq/core/app/BisqSetup.java (10)
    M core/src/main/java/bisq/core/app/DomainInitialisation.java (18)
    M core/src/main/java/bisq/core/app/P2PNetworkSetup.java (22)
    M core/src/main/java/bisq/core/app/misc/ExecutableForAppWithP2p.java (2)
    M core/src/main/java/bisq/core/btc/Balances.java (6)
    M core/src/main/java/bisq/core/btc/TxFeeEstimationService.java (8)
    M core/src/main/java/bisq/core/btc/listeners/BsqBalanceListener.java (2)
    M core/src/main/java/bisq/core/btc/listeners/TxConfidenceListener.java (17)
    M core/src/main/java/bisq/core/btc/model/RawTransactionInput.java (79)
    M core/src/main/java/bisq/core/btc/nodes/BtcNodes.java (16)
    M core/src/main/java/bisq/core/btc/wallet/BsqCoinSelector.java (16)
    M core/src/main/java/bisq/core/btc/wallet/BsqTransferService.java (2)
    M core/src/main/java/bisq/core/btc/wallet/BsqWalletService.java (124)
    M core/src/main/java/bisq/core/btc/wallet/BtcWalletService.java (29)
    M core/src/main/java/bisq/core/btc/wallet/TradeWalletService.java (149)
    M core/src/main/java/bisq/core/btc/wallet/WalletService.java (57)
    M core/src/main/java/bisq/core/dao/DaoFacade.java (13)
    M core/src/main/java/bisq/core/dao/governance/asset/AssetService.java (2)
    M core/src/main/java/bisq/core/dao/governance/blindvote/MyBlindVoteListService.java (2)
    M core/src/main/java/bisq/core/dao/governance/bond/lockup/LockupTxService.java (2)
    M core/src/main/java/bisq/core/dao/governance/bond/unlock/UnlockTxService.java (2)
    M core/src/main/java/bisq/core/dao/governance/proofofburn/ProofOfBurnService.java (2)
    M core/src/main/java/bisq/core/dao/governance/proposal/BaseProposalFactory.java (2)
    M core/src/main/java/bisq/core/dao/governance/votereveal/VoteRevealService.java (2)
    M core/src/main/java/bisq/core/dao/state/DaoStateService.java (12)
    M core/src/main/java/bisq/core/filter/Filter.java (44)
    M core/src/main/java/bisq/core/filter/FilterManager.java (28)
    M core/src/main/java/bisq/core/locale/Res.java (6)
    M core/src/main/java/bisq/core/notifications/alerts/TradeEvents.java (2)
    M core/src/main/java/bisq/core/notifications/alerts/market/MarketAlerts.java (6)
    M core/src/main/java/bisq/core/offer/Offer.java (252)
    M core/src/main/java/bisq/core/offer/OfferBookService.java (36)
    A core/src/main/java/bisq/core/offer/OfferDirection.java (33)
    R core/src/main/java/bisq/core/offer/OfferFilterService.java (17)
    M core/src/main/java/bisq/core/offer/OfferForJson.java (8)
    A core/src/main/java/bisq/core/offer/OfferPayloadBase.java (147)
    M core/src/main/java/bisq/core/offer/OfferRestrictions.java (4)
    M core/src/main/java/bisq/core/offer/OfferUtil.java (124)
    M core/src/main/java/bisq/core/offer/OpenOffer.java (43)
    M core/src/main/java/bisq/core/offer/OpenOfferManager.java (277)
    R core/src/main/java/bisq/core/offer/availability/AvailabilityResult.java (2)
    M core/src/main/java/bisq/core/offer/availability/OfferAvailabilityModel.java (2)
    M core/src/main/java/bisq/core/offer/availability/OfferAvailabilityProtocol.java (4)
    R core/src/main/java/bisq/core/offer/availability/messages/OfferAvailabilityRequest.java (6)
    R core/src/main/java/bisq/core/offer/availability/messages/OfferAvailabilityResponse.java (8)
    R core/src/main/java/bisq/core/offer/availability/messages/OfferMessage.java (2)
    M core/src/main/java/bisq/core/offer/availability/tasks/ProcessOfferAvailabilityResponse.java (4)
    M core/src/main/java/bisq/core/offer/availability/tasks/SendOfferAvailabilityRequest.java (2)
    R core/src/main/java/bisq/core/offer/bisq_v1/CreateOfferService.java (23)
    R core/src/main/java/bisq/core/offer/bisq_v1/MarketPriceNotAvailableException.java (2)
    R core/src/main/java/bisq/core/offer/bisq_v1/MutableOfferPayloadFields.java (2)
    R core/src/main/java/bisq/core/offer/bisq_v1/OfferPayload.java (196)
    R core/src/main/java/bisq/core/offer/bisq_v1/TakeOfferModel.java (4)
    R core/src/main/java/bisq/core/offer/bisq_v1/TriggerPriceService.java (29)
    A core/src/main/java/bisq/core/offer/bsq_swap/BsqSwapOfferModel.java (392)
    A core/src/main/java/bisq/core/offer/bsq_swap/BsqSwapOfferPayload.java (169)
    A core/src/main/java/bisq/core/offer/bsq_swap/BsqSwapTakeOfferModel.java (135)
    A core/src/main/java/bisq/core/offer/bsq_swap/OpenBsqSwapOffer.java (211)
    A core/src/main/java/bisq/core/offer/bsq_swap/OpenBsqSwapOfferService.java (396)
    R core/src/main/java/bisq/core/offer/placeoffer/bisq_v1/PlaceOfferModel.java (2)
    R core/src/main/java/bisq/core/offer/placeoffer/bisq_v1/PlaceOfferProtocol.java (14)
    R core/src/main/java/bisq/core/offer/placeoffer/bisq_v1/tasks/AddToOfferBook.java (4)
    R core/src/main/java/bisq/core/offer/placeoffer/bisq_v1/tasks/CheckNumberOfUnconfirmedTransactions.java (4)
    R core/src/main/java/bisq/core/offer/placeoffer/bisq_v1/tasks/CreateMakerFeeTx.java (6)
    R core/src/main/java/bisq/core/offer/placeoffer/bisq_v1/tasks/ValidateOffer.java (8)
    A core/src/main/java/bisq/core/offer/placeoffer/bsqswap/PlaceBsqSwapOfferModel.java (46)
    A core/src/main/java/bisq/core/offer/placeoffer/bsqswap/PlaceBsqSwapOfferProtocol.java (83)
    A core/src/main/java/bisq/core/offer/placeoffer/bsqswap/tasks/AddBsqSwapOfferToOfferBook.java (55)
    A core/src/main/java/bisq/core/offer/placeoffer/bsqswap/tasks/ValidateBsqSwapOffer.java (80)
    A core/src/main/java/bisq/core/payment/BsqSwapAccount.java (50)
    M core/src/main/java/bisq/core/payment/PaymentAccountFactory.java (2)
    A core/src/main/java/bisq/core/payment/payload/BsqSwapAccountPayload.java (70)
    M core/src/main/java/bisq/core/payment/payload/PaymentMethod.java (21)
    M core/src/main/java/bisq/core/proto/CoreProtoResolver.java (3)
    M core/src/main/java/bisq/core/proto/ProtoDevUtil.java (12)
    M core/src/main/java/bisq/core/proto/network/CoreNetworkProtoResolver.java (53)
    M core/src/main/java/bisq/core/proto/persistable/CorePersistenceProtoResolver.java (2)
    M core/src/main/java/bisq/core/provider/mempool/MempoolService.java (4)
    M core/src/main/java/bisq/core/setup/CoreNetworkCapabilities.java (3)
    M core/src/main/java/bisq/core/setup/CorePersistedDataHost.java (6)
    M core/src/main/java/bisq/core/support/dispute/Dispute.java (2)
    M core/src/main/java/bisq/core/support/dispute/DisputeListService.java (2)
    M core/src/main/java/bisq/core/support/dispute/DisputeManager.java (10)
    M core/src/main/java/bisq/core/support/dispute/agent/MultipleHolderNameDetection.java (2)
    M core/src/main/java/bisq/core/support/dispute/arbitration/ArbitrationManager.java (8)
    M core/src/main/java/bisq/core/support/dispute/mediation/MediationManager.java (10)
    M core/src/main/java/bisq/core/support/dispute/refund/RefundManager.java (4)
    M core/src/main/java/bisq/core/support/traderchat/TradeChatSession.java (6)
    M core/src/main/java/bisq/core/support/traderchat/TraderChatManager.java (9)
    M core/src/main/java/bisq/core/trade/TradeManager.java (333)
    M core/src/main/java/bisq/core/trade/TradeModule.java (4)
    R core/src/main/java/bisq/core/trade/bisq_v1/CleanupMailboxMessagesService.java (12)
    R core/src/main/java/bisq/core/trade/bisq_v1/ClosedTradableManager.java (17)
    R core/src/main/java/bisq/core/trade/bisq_v1/ClosedTradeUtil.java (14)
    R core/src/main/java/bisq/core/trade/bisq_v1/DumpDelayedPayoutTx.java (6)
    R core/src/main/java/bisq/core/trade/bisq_v1/FailedTradesManager.java (17)
    R core/src/main/java/bisq/core/trade/bisq_v1/TradeDataValidation.java (3)
    R core/src/main/java/bisq/core/trade/bisq_v1/TradeResultHandler.java (8)
    R core/src/main/java/bisq/core/trade/bisq_v1/TradeTxException.java (2)
    R core/src/main/java/bisq/core/trade/bisq_v1/TradeUtil.java (40)
    R core/src/main/java/bisq/core/trade/bisq_v1/TransactionResultHandler.java (2)
    A core/src/main/java/bisq/core/trade/bsq_swap/BsqSwapCalculation.java (244)
    A core/src/main/java/bisq/core/trade/bsq_swap/BsqSwapTakeOfferRequestVerification.java (106)
    A core/src/main/java/bisq/core/trade/bsq_swap/BsqSwapTradeManager.java (119)
    R core/src/main/java/bisq/core/trade/model/MakerTrade.java (2)
    R core/src/main/java/bisq/core/trade/model/TakerTrade.java (2)
    R core/src/main/java/bisq/core/trade/model/Tradable.java (2)
    R core/src/main/java/bisq/core/trade/model/TradableList.java (18)
    A core/src/main/java/bisq/core/trade/model/TradeModel.java (111)
    A core/src/main/java/bisq/core/trade/model/TradePhase.java (28)
    A core/src/main/java/bisq/core/trade/model/TradeState.java (28)
    R core/src/main/java/bisq/core/trade/model/bisq_v1/BuyerAsMakerTrade.java (6)
    R core/src/main/java/bisq/core/trade/model/bisq_v1/BuyerAsTakerTrade.java (6)
    R core/src/main/java/bisq/core/trade/model/bisq_v1/BuyerTrade.java (4)
    R core/src/main/java/bisq/core/trade/model/bisq_v1/Contract.java (4)
    R core/src/main/java/bisq/core/trade/model/bisq_v1/SellerAsMakerTrade.java (6)
    R core/src/main/java/bisq/core/trade/model/bisq_v1/SellerAsTakerTrade.java (6)
    R core/src/main/java/bisq/core/trade/model/bisq_v1/SellerTrade.java (4)
    R core/src/main/java/bisq/core/trade/model/bisq_v1/Trade.java (159)
    A core/src/main/java/bisq/core/trade/model/bsq_swap/BsqSwapBuyerAsMakerTrade.java (122)
    A core/src/main/java/bisq/core/trade/model/bsq_swap/BsqSwapBuyerAsTakerTrade.java (122)
    A core/src/main/java/bisq/core/trade/model/bsq_swap/BsqSwapBuyerTrade.java (59)
    A core/src/main/java/bisq/core/trade/model/bsq_swap/BsqSwapSellerAsMakerTrade.java (122)
    A core/src/main/java/bisq/core/trade/model/bsq_swap/BsqSwapSellerAsTakerTrade.java (123)
    A core/src/main/java/bisq/core/trade/model/bsq_swap/BsqSwapSellerTrade.java (56)
    A core/src/main/java/bisq/core/trade/model/bsq_swap/BsqSwapTrade.java (248)
    M core/src/main/java/bisq/core/trade/protocol/FluentProtocol.java (80)
    A core/src/main/java/bisq/core/trade/protocol/ProtocolModel.java (28)
    R core/src/main/java/bisq/core/trade/protocol/Provider.java (40)
    R core/src/main/java/bisq/core/trade/protocol/TradeMessage.java (2)
    A core/src/main/java/bisq/core/trade/protocol/TradePeer.java (27)
    M core/src/main/java/bisq/core/trade/protocol/TradeProtocol.java (109)
    M core/src/main/java/bisq/core/trade/protocol/TradeProtocolFactory.java (53)
    M core/src/main/java/bisq/core/trade/protocol/TradeTaskRunner.java (14)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/BuyerAsMakerProtocol.java (47)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/BuyerAsTakerProtocol.java (52)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/BuyerProtocol.java (42)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/DisputeProtocol.java (77)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/MakerProtocol.java (4)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/SellerAsMakerProtocol.java (49)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/SellerAsTakerProtocol.java (42)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/SellerProtocol.java (44)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/TakerProtocol.java (4)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/messages/CounterCurrencyTransferStartedMessage.java (2)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/messages/DelayedPayoutTxSignatureRequest.java (4)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/messages/DelayedPayoutTxSignatureResponse.java (4)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/messages/DepositTxAndDelayedPayoutTxMessage.java (2)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/messages/DepositTxMessage.java (4)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/messages/InputsForDepositTxRequest.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/messages/InputsForDepositTxResponse.java (3)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/messages/MediatedPayoutTxPublishedMessage.java (2)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/messages/MediatedPayoutTxSignatureMessage.java (2)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/messages/PayoutTxPublishedMessage.java (2)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/messages/PeerPublishedDelayedPayoutTxMessage.java (2)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/messages/RefreshTradeStateRequest.java (2)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/messages/ShareBuyerPaymentAccountMessage.java (2)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/messages/TradeMailboxMessage.java (4)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/messages/TraderSignedWitnessMessage.java (2)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/model/ProcessModel.java (35)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/model/TradingPeer.java (6)
    A core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/ApplyFilter.java (63)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/BroadcastPayoutTx.java (4)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/ProcessPeerPublishedDelayedPayoutTxMessage.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/SendMailboxMessageTask.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/SetupPayoutTxListener.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/TradeTask.java (9)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/VerifyPeersAccountAgeWitness.java (8)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/arbitration/PublishedDelayedPayoutTx.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/arbitration/SendPeerPublishedDelayedPayoutTxMessage.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer/BuyerFinalizesDelayedPayoutTx.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer/BuyerProcessDelayedPayoutTxSignatureRequest.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer/BuyerProcessDepositTxAndDelayedPayoutTxMessage.java (20)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer/BuyerProcessPayoutTxPublishedMessage.java (9)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer/BuyerSendCounterCurrencyTransferStartedMessage.java (18)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer/BuyerSendsDelayedPayoutTxSignatureResponse.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer/BuyerSendsShareBuyerPaymentAccountMessage.java (12)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer/BuyerSetupDepositTxListener.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer/BuyerSetupPayoutTxListener.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer/BuyerSignPayoutTx.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer/BuyerSignsDelayedPayoutTx.java (8)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer/BuyerVerifiesFinalDelayedPayoutTx.java (8)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer/BuyerVerifiesPreparedDelayedPayoutTx.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer_as_maker/BuyerAsMakerCreatesAndSignsDepositTx.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer_as_maker/BuyerAsMakerSendsInputsForDepositTxResponse.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer_as_taker/BuyerAsTakerCreatesDepositTxInputs.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer_as_taker/BuyerAsTakerSendsDepositTxMessage.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer_as_taker/BuyerAsTakerSignsDepositTx.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/maker/MakerCreateAndSignContract.java (25)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/maker/MakerProcessesInputsForDepositTxRequest.java (12)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/maker/MakerRemovesOpenOffer.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/maker/MakerSendsInputsForDepositTxResponse.java (12)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/maker/MakerSetsLockTime.java (8)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/maker/MakerVerifyTakerFeePayment.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/mediation/BroadcastMediatedPayoutTx.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/mediation/FinalizeMediatedPayoutTx.java (12)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/mediation/ProcessMediatedPayoutSignatureMessage.java (11)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/mediation/ProcessMediatedPayoutTxPublishedMessage.java (9)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/mediation/SendMediatedPayoutSignatureMessage.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/mediation/SendMediatedPayoutTxPublishedMessage.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/mediation/SetupMediatedPayoutTxListener.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/mediation/SignMediatedPayoutTx.java (12)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller/SellerBroadcastPayoutTx.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller/SellerCreatesDelayedPayoutTx.java (8)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller/SellerFinalizesDelayedPayoutTx.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller/SellerProcessCounterCurrencyTransferStartedMessage.java (13)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller/SellerProcessDelayedPayoutTxSignatureResponse.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller/SellerProcessShareBuyerPaymentAccountMessage.java (14)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller/SellerPublishesDepositTx.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller/SellerPublishesTradeStatistics.java (8)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller/SellerSendDelayedPayoutTxSignatureRequest.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller/SellerSendPayoutTxPublishedMessage.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller/SellerSendsDepositTxAndDelayedPayoutTxMessage.java (12)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller/SellerSignAndFinalizePayoutTx.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller/SellerSignsDelayedPayoutTx.java (8)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller_as_maker/SellerAsMakerCreatesUnsignedDepositTx.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller_as_maker/SellerAsMakerFinalizesDepositTx.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller_as_maker/SellerAsMakerProcessDepositTxMessage.java (11)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller_as_maker/SellerAsMakerSendsInputsForDepositTxResponse.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller_as_taker/SellerAsTakerCreatesDepositTxInputs.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller_as_taker/SellerAsTakerSignsDepositTx.java (14)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/taker/CreateTakerFeeTx.java (8)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/taker/TakerProcessesInputsForDepositTxResponse.java (14)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/taker/TakerPublishFeeTx.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/taker/TakerSendInputsForDepositTxRequest.java (12)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/taker/TakerVerifyAndSignContract.java (28)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/taker/TakerVerifyMakerFeePayment.java (6)
    A core/src/main/java/bisq/core/trade/protocol/bsq_swap/BsqSwapBuyerAsMakerProtocol.java (111)
    A core/src/main/java/bisq/core/trade/protocol/bsq_swap/BsqSwapBuyerAsTakerProtocol.java (99)
    A core/src/main/java/bisq/core/trade/protocol/bsq_swap/BsqSwapBuyerProtocol.java (30)
    A core/src/main/java/bisq/core/trade/protocol/bsq_swap/BsqSwapMakerProtocol.java (31)
    A core/src/main/java/bisq/core/trade/protocol/bsq_swap/BsqSwapProtocol.java (44)
    A core/src/main/java/bisq/core/trade/protocol/bsq_swap/BsqSwapSellerAsMakerProtocol.java (98)
    A core/src/main/java/bisq/core/trade/protocol/bsq_swap/BsqSwapSellerAsTakerProtocol.java (110)
    A core/src/main/java/bisq/core/trade/protocol/bsq_swap/BsqSwapSellerProtocol.java (30)
    A core/src/main/java/bisq/core/trade/protocol/bsq_swap/BsqSwapTakerProtocol.java (23)
    A core/src/main/java/bisq/core/trade/protocol/bsq_swap/messages/BsqSwapFinalizeTxRequest.java (129)
    A core/src/main/java/bisq/core/trade/protocol/bsq_swap/messages/BsqSwapFinalizedTxMessage.java (83)
    A core/src/main/java/bisq/core/trade/protocol/bsq_swap/messages/BsqSwapRequest.java (60)
    A core/src/main/java/bisq/core/trade/protocol/bsq_swap/messages/BsqSwapTxInputsMessage.java (107)
    A core/src/main/java/bisq/core/trade/protocol/bsq_swap/messages/BuyersBsqSwapRequest.java (138)
    A core/src/main/java/bisq/core/trade/protocol/bsq_swap/messages/SellersBsqSwapRequest.java (101)
    A core/src/main/java/bisq/core/trade/protocol/bsq_swap/messages/TxInputsMessage.java (34)
    A core/src/main/java/bisq/core/trade/protocol/bsq_swap/model/BsqSwapProtocolModel.java (259)
    A core/src/main/java/bisq/core/trade/protocol/bsq_swap/model/BsqSwapTradePeer.java (115)
    A core/src/main/java/bisq/core/trade/protocol/bsq_swap/package-info.java (86)
    A core/src/main/java/bisq/core/trade/protocol/bsq_swap/tasks/ApplyFilter.java (51)
    A core/src/main/java/bisq/core/trade/protocol/bsq_swap/tasks/BsqSwapTask.java (74)
    A core/src/main/java/bisq/core/trade/protocol/bsq_swap/tasks/SendBsqSwapMessageTask.java (68)
    A core/src/main/java/bisq/core/trade/protocol/bsq_swap/tasks/buyer/BuyerCreatesAndSignsFinalizedTx.java (104)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/5775.patch
https://github.com/bisq-network/bisq/pull/5775.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5775
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211021/cf58ae60/attachment-0001.htm>

From notifications at github.com  Thu Oct 21 20:08:06 2021
From: notifications at github.com (Stan)
Date: Thu, 21 Oct 2021 11:08:06 -0700
Subject: [bisq-network/bisq] BSQ swap low risk refactorings [2] (PR #5770)
In-Reply-To: <bisq-network/bisq/pull/5770@github.com>
References: <bisq-network/bisq/pull/5770@github.com>
Message-ID: <bisq-network/bisq/pull/5770/review/786042708@github.com>

@ghubstan commented on this pull request.



> +package bisq.core.trade.model;
+
+import bisq.core.offer.Offer;
+import bisq.core.trade.protocol.ProtocolModel;
+import bisq.core.trade.protocol.Provider;
+import bisq.core.trade.protocol.TradePeer;
+
+import bisq.network.p2p.NodeAddress;
+
+import bisq.common.taskrunner.Model;
+import bisq.common.util.Utilities;
+
+import javafx.beans.property.ReadOnlyStringProperty;
+import javafx.beans.property.SimpleStringProperty;
+import javafx.beans.property.StringProperty;
+

The next commit (8cd85a77c148a7d01de9b41d25832ca0af6f334e) reminds me `Trade` is pretty tightly coupled to JFX, it will be quite awhile before we can separate the `core.Trade` entity from JFX, and refactoring `TradeModel` is a less-than-half measure.   So these comments are not really change request, but only a reminder.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5770#discussion_r733930132
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211021/e9cae42b/attachment.htm>

From notifications at github.com  Thu Oct 21 20:09:38 2021
From: notifications at github.com (chimp1984)
Date: Thu, 21 Oct 2021 11:09:38 -0700
Subject: [bisq-network/bisq] Refactorings (non funtional changes) [1] (PR
 #5769)
In-Reply-To: <bisq-network/bisq/pull/5769@github.com>
References: <bisq-network/bisq/pull/5769@github.com>
Message-ID: <bisq-network/bisq/pull/5769/push/8208930500@github.com>

@chimp1984 pushed 1 commit.

4c1cb81a3a2d4e4d4448d6de24367768612afadd  Dummy commit to trigger CI


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/bisq-network/bisq/pull/5769/files/559491ebd1f22ab5cf1286458ac16978e5ee4606..4c1cb81a3a2d4e4d4448d6de24367768612afadd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211021/ff4cb337/attachment.htm>

From notifications at github.com  Thu Oct 21 20:16:02 2021
From: notifications at github.com (pazza)
Date: Thu, 21 Oct 2021 11:16:02 -0700
Subject: [bisq-network/bisq] Promote Keybase as a support channel within
 Bisq GUI (#4904)
In-Reply-To: <bisq-network/bisq/issues/4904@github.com>
References: <bisq-network/bisq/issues/4904@github.com>
Message-ID: <bisq-network/bisq/issues/4904/948882839@github.com>

@m52go in the meantime do you think we could update the text in the below sections:

- Trade process
- Trader chat 
- Pop up new users see 
- Support Popups 
- Setting page 
- Alerts
- Error in trade information screen

Currently there is a lack of mention where users should seek support, or they are pointed to the Bisq community forum. Rarely is Keybase mentioned.

The above changes would be text only so should be straightforward to implement, providing strings were agreed prior.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/4904#issuecomment-948882839
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211021/25fdea2a/attachment.htm>

From notifications at github.com  Thu Oct 21 20:32:12 2021
From: notifications at github.com (chimp1984)
Date: Thu, 21 Oct 2021 11:32:12 -0700
Subject: [bisq-network/bisq] Bsq swap impl [3] (PR #5775)
In-Reply-To: <bisq-network/bisq/pull/5775@github.com>
References: <bisq-network/bisq/pull/5775@github.com>
Message-ID: <bisq-network/bisq/pull/5775/push/8209088982@github.com>

@chimp1984 pushed 1 commit.

50473e012dd0682e7d4e530265707d1293f0761f  Add missing import


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/bisq-network/bisq/pull/5775/files/3558d0171c60a44dc21ed2814d95c85274072655..50473e012dd0682e7d4e530265707d1293f0761f
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211021/d95d5562/attachment.htm>

From notifications at github.com  Thu Oct 21 20:41:41 2021
From: notifications at github.com (chimp1984)
Date: Thu, 21 Oct 2021 11:41:41 -0700
Subject: [bisq-network/bisq] Refactorings (non funtional changes) [1] (PR
 #5769)
In-Reply-To: <bisq-network/bisq/pull/5769@github.com>
References: <bisq-network/bisq/pull/5769@github.com>
Message-ID: <bisq-network/bisq/pull/5769/c948901350@github.com>

No idea why the gradle dependencyVerification fails. It is the same content as in the release branch.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5769#issuecomment-948901350
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211021/4578e557/attachment.htm>

From notifications at github.com  Thu Oct 21 20:41:47 2021
From: notifications at github.com (chimp1984)
Date: Thu, 21 Oct 2021 11:41:47 -0700
Subject: [bisq-network/bisq] BSQ swap low risk refactorings [2] (PR #5770)
In-Reply-To: <bisq-network/bisq/pull/5770@github.com>
References: <bisq-network/bisq/pull/5770@github.com>
Message-ID: <bisq-network/bisq/pull/5770/c948901450@github.com>

No idea why the gradle dependencyVerification fails. It is the same content as in the release branch.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5770#issuecomment-948901450
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211021/2b5ae678/attachment-0001.htm>

From notifications at github.com  Thu Oct 21 20:48:01 2021
From: notifications at github.com (chimp1984)
Date: Thu, 21 Oct 2021 11:48:01 -0700
Subject: [bisq-network/bisq] Bsq swap impl [3] (PR #5775)
In-Reply-To: <bisq-network/bisq/pull/5775@github.com>
References: <bisq-network/bisq/pull/5775@github.com>
Message-ID: <bisq-network/bisq/pull/5775/push/8209201273@github.com>

@chimp1984 pushed 1 commit.

4087e7b58d44abf3d0fa3cc29c52628cacbbf134  Apply codacy review suggestions


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/bisq-network/bisq/pull/5775/files/50473e012dd0682e7d4e530265707d1293f0761f..4087e7b58d44abf3d0fa3cc29c52628cacbbf134
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211021/2bb1329c/attachment.htm>

From notifications at github.com  Thu Oct 21 21:13:53 2021
From: notifications at github.com (Stan)
Date: Thu, 21 Oct 2021 12:13:53 -0700
Subject: [bisq-network/bisq] BSQ swap low risk refactorings [2] (PR #5770)
In-Reply-To: <bisq-network/bisq/pull/5770@github.com>
References: <bisq-network/bisq/pull/5770@github.com>
Message-ID: <bisq-network/bisq/pull/5770/review/786103288@github.com>

@ghubstan commented on this pull request.



> @@ -718,6 +733,11 @@ private void addTrade(Trade trade) {
         }
     }
 
+    private Stream<TradeModel> getPendingTrades() {
+        return Stream.concat(tradableList.stream(),
+                Stream.empty());
+    }

Can't you just `return tradableList.stream();` ?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5770#pullrequestreview-786103288
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211021/aaac7da1/attachment.htm>

From notifications at github.com  Thu Oct 21 21:47:06 2021
From: notifications at github.com (stopfeds)
Date: Thu, 21 Oct 2021 12:47:06 -0700
Subject: [bisq-network/roles] Community Manager (#95)
In-Reply-To: <bisq-network/roles/issues/95@github.com>
References: <bisq-network/roles/issues/95@github.com>
Message-ID: <bisq-network/roles/issues/95/948949785@github.com>

# Cycle 29 report

[Twitter:](https://twitter.com/BisqDe)
After building up a timeline with a few tweets (and an instant ban after the first tweet), the account went officially public on 23rd of October. So far 169 Followers and around 20 tweets. All in all +3k profile visits and 10 mentions.

![image](https://user-images.githubusercontent.com/71401614/138344748-d4073583-d275-4cf5-8e61-884b179784b2.png)

Best tweets are about KYC bashing. Need to improve meme game. I'll start a 2 x 20 BSQ give-away on Saturday to gain more followers.


PS: Thank you for assigning and adding to the community managers!


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/roles/issues/95#issuecomment-948949785
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211021/1c1765c4/attachment.htm>

From notifications at github.com  Thu Oct 21 22:30:02 2021
From: notifications at github.com (chimp1984)
Date: Thu, 21 Oct 2021 13:30:02 -0700
Subject: [bisq-network/bisq] Bsq swap impl [3] (PR #5775)
In-Reply-To: <bisq-network/bisq/pull/5775@github.com>
References: <bisq-network/bisq/pull/5775@github.com>
Message-ID: <bisq-network/bisq/pull/5775/push/8209862241@github.com>

@chimp1984 pushed 1 commit.

6d9d0f75732cdae03265574c106b2daa51ab45b5  Apply codacy review suggestions


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/bisq-network/bisq/pull/5775/files/4087e7b58d44abf3d0fa3cc29c52628cacbbf134..6d9d0f75732cdae03265574c106b2daa51ab45b5
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211021/57338014/attachment.htm>

From notifications at github.com  Thu Oct 21 22:37:51 2021
From: notifications at github.com (chimp1984)
Date: Thu, 21 Oct 2021 13:37:51 -0700
Subject: [bisq-network/bisq] BSQ swap low risk refactorings [2] (PR #5770)
In-Reply-To: <bisq-network/bisq/pull/5770@github.com>
References: <bisq-network/bisq/pull/5770@github.com>
Message-ID: <bisq-network/bisq/pull/5770/review/786176008@github.com>

@chimp1984 commented on this pull request.



> @@ -718,6 +733,11 @@ private void addTrade(Trade trade) {
         }
     }
 
+    private Stream<TradeModel> getPendingTrades() {
+        return Stream.concat(tradableList.stream(),
+                Stream.empty());
+    }

That was just for preparing for bsq swap, there the second stream is used. I just added it that way to reduce diffs to the target version.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5770#discussion_r734028461
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211021/d5c3ac9c/attachment.htm>

From notifications at github.com  Thu Oct 21 22:41:15 2021
From: notifications at github.com (chimp1984)
Date: Thu, 21 Oct 2021 13:41:15 -0700
Subject: [bisq-network/bisq] BSQ swap low risk refactorings [2] (PR #5770)
In-Reply-To: <bisq-network/bisq/pull/5770@github.com>
References: <bisq-network/bisq/pull/5770@github.com>
Message-ID: <bisq-network/bisq/pull/5770/review/786178795@github.com>

@chimp1984 commented on this pull request.



>              user.removePaymentAccount(paymentAccount);
+        }

The account is only required if there are open offers then deletion is not allowed. It is called from the account UI, so yes there might be edge cases where a user deleted an account of a failed trade and then move it back to open trades. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5770#discussion_r734030554
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211021/0a5f916d/attachment-0001.htm>

From notifications at github.com  Thu Oct 21 22:42:43 2021
From: notifications at github.com (chimp1984)
Date: Thu, 21 Oct 2021 13:42:43 -0700
Subject: [bisq-network/bisq] BSQ swap low risk refactorings [2] (PR #5770)
In-Reply-To: <bisq-network/bisq/pull/5770@github.com>
References: <bisq-network/bisq/pull/5770@github.com>
Message-ID: <bisq-network/bisq/pull/5770/review/786180029@github.com>

@chimp1984 commented on this pull request.



>      private final Preferences preferences;
     private final PriceFeedService priceFeedService;
     private final ObservableList<ClosedTradableListItem> list = FXCollections.observableArrayList();
     private final ListChangeListener<Tradable> tradesListChangeListener;
 
+    /**
+     * Supplies a List<Tradable> from this JFX ObservableList<ClosedTradableListItem>
+     * collection, for passing to core's ClosedTradeUtil which has no dependency on JFX.

Yes, but I think there are so many dependenceis with Observables and Properties in core that it would be too much effort to try to get rid of it. But for new code if it can be a simple List the better of course.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5770#discussion_r734031460
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211021/80abf032/attachment.htm>

From notifications at github.com  Thu Oct 21 22:44:42 2021
From: notifications at github.com (chimp1984)
Date: Thu, 21 Oct 2021 13:44:42 -0700
Subject: [bisq-network/bisq] BSQ swap low risk refactorings [2] (PR #5770)
In-Reply-To: <bisq-network/bisq/pull/5770@github.com>
References: <bisq-network/bisq/pull/5770@github.com>
Message-ID: <bisq-network/bisq/pull/5770/review/786181729@github.com>

@chimp1984 commented on this pull request.



> +package bisq.core.trade.model;
+
+import bisq.core.offer.Offer;
+import bisq.core.trade.protocol.ProtocolModel;
+import bisq.core.trade.protocol.Provider;
+import bisq.core.trade.protocol.TradePeer;
+
+import bisq.network.p2p.NodeAddress;
+
+import bisq.common.taskrunner.Model;
+import bisq.common.util.Utilities;
+
+import javafx.beans.property.ReadOnlyStringProperty;
+import javafx.beans.property.SimpleStringProperty;
+import javafx.beans.property.StringProperty;
+

See comment of previous post. In Misq I would start also with no FX dependencies and use diff observer patterns but in Bisq its all over the place already. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5770#discussion_r734032573
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211021/87d71151/attachment.htm>

From notifications at github.com  Thu Oct 21 22:44:55 2021
From: notifications at github.com (chimp1984)
Date: Thu, 21 Oct 2021 13:44:55 -0700
Subject: [bisq-network/bisq] Bsq swap impl [3] (PR #5775)
In-Reply-To: <bisq-network/bisq/pull/5775@github.com>
References: <bisq-network/bisq/pull/5775@github.com>
Message-ID: <bisq-network/bisq/pull/5775/c948989120@github.com>

No idea why the gradle dependencyVerification fails. It is the same content as in the release branch.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5775#issuecomment-948989120
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211021/23467da5/attachment.htm>

From notifications at github.com  Thu Oct 21 22:46:12 2021
From: notifications at github.com (chimp1984)
Date: Thu, 21 Oct 2021 13:46:12 -0700
Subject: [bisq-network/bisq] BSQ swap low risk refactorings [2] (PR #5770)
In-Reply-To: <bisq-network/bisq/pull/5770@github.com>
References: <bisq-network/bisq/pull/5770@github.com>
Message-ID: <bisq-network/bisq/pull/5770/review/786183022@github.com>

@chimp1984 commented on this pull request.



> @@ -718,6 +733,11 @@ private void addTrade(Trade trade) {
         }
     }
 
+    private Stream<TradeModel> getPendingTrades() {
+        return Stream.concat(tradableList.stream(),
+                Stream.empty());
+    }

By the way there are plenty of such commits which would not make sense isolated. They are all with the intention to get step by step closer to the version where only BSQ swap features are missing...

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5770#discussion_r734033492
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211021/c5672da9/attachment.htm>

From notifications at github.com  Thu Oct 21 23:36:49 2021
From: notifications at github.com (wiz)
Date: Thu, 21 Oct 2021 14:36:49 -0700
Subject: [bisq-network/compensation] For Cycle 29 (Issue #927)
In-Reply-To: <bisq-network/compensation/issues/927@github.com>
References: <bisq-network/compensation/issues/927@github.com>
Message-ID: <bisq-network/compensation/issues/927/949022232@github.com>

5577b735a3787e00bc2ffdd41605c316e92f38dc8559e7ecde7f1f6697ff23a4

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/927#issuecomment-949022232
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211021/f566f413/attachment.htm>

From notifications at github.com  Thu Oct 21 23:38:33 2021
From: notifications at github.com (chimp1984)
Date: Thu, 21 Oct 2021 14:38:33 -0700
Subject: [bisq-network/bisq] Bsq swap: Implementation [3] (PR #5775)
In-Reply-To: <bisq-network/bisq/pull/5775@github.com>
References: <bisq-network/bisq/pull/5775@github.com>
Message-ID: <bisq-network/bisq/pull/5775/c949023122@github.com>

Seems its a jitpack issue. Devs on keybase complained also about problems.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5775#issuecomment-949023122
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211021/4dc01d51/attachment-0001.htm>

From notifications at github.com  Fri Oct 22 06:18:29 2021
From: notifications at github.com (tut4499)
Date: Thu, 21 Oct 2021 21:18:29 -0700
Subject: [bisq-network/bisq] Cannot Confirm Payment Received (Issue #5772)
In-Reply-To: <bisq-network/bisq/issues/5772@github.com>
References: <bisq-network/bisq/issues/5772@github.com>
Message-ID: <bisq-network/bisq/issues/5772/949273752@github.com>

How to export them? So i should contact the mediator now yes?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5772#issuecomment-949273752
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211021/a23e4a9e/attachment.htm>

From notifications at github.com  Fri Oct 22 06:24:33 2021
From: notifications at github.com (jmacxx)
Date: Thu, 21 Oct 2021 21:24:33 -0700
Subject: [bisq-network/bisq] Cannot Confirm Payment Received (Issue #5772)
In-Reply-To: <bisq-network/bisq/issues/5772@github.com>
References: <bisq-network/bisq/issues/5772@github.com>
Message-ID: <bisq-network/bisq/issues/5772/949276097@github.com>

Yes, contact the mediator (ctrl-o).  Log files are located in the data directory, see https://bisq.wiki/Data_directory

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5772#issuecomment-949276097
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211021/358073f8/attachment.htm>

From notifications at github.com  Fri Oct 22 06:28:34 2021
From: notifications at github.com (tut4499)
Date: Thu, 21 Oct 2021 21:28:34 -0700
Subject: [bisq-network/bisq] Cannot Confirm Payment Received (Issue #5772)
In-Reply-To: <bisq-network/bisq/issues/5772@github.com>
References: <bisq-network/bisq/issues/5772@github.com>
Message-ID: <bisq-network/bisq/issues/5772/949277655@github.com>

Impossible to attach bigger files to mediator over 200kb.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5772#issuecomment-949277655
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211021/0fad1c26/attachment.htm>

From notifications at github.com  Fri Oct 22 06:38:41 2021
From: notifications at github.com (jmacxx)
Date: Thu, 21 Oct 2021 21:38:41 -0700
Subject: [bisq-network/bisq] Cannot Confirm Payment Received (Issue #5772)
In-Reply-To: <bisq-network/bisq/issues/5772@github.com>
References: <bisq-network/bisq/issues/5772@github.com>
Message-ID: <bisq-network/bisq/issues/5772/949281239@github.com>

Your mediator can advise you on how to transfer the files.  Also https://bisq.wiki/User_support#Via_Keybase_chat

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5772#issuecomment-949281239
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211021/764bc39f/attachment.htm>

From notifications at github.com  Fri Oct 22 14:51:48 2021
From: notifications at github.com (Liisachan)
Date: Fri, 22 Oct 2021 05:51:48 -0700
Subject: [bisq-network/bisq] Allow 1 sat/vbyte fee (#5633)
In-Reply-To: <bisq-network/bisq/issues/5633@github.com>
References: <bisq-network/bisq/issues/5633@github.com>
Message-ID: <bisq-network/bisq/issues/5633/949602427@github.com>

~1.01 sat/vB works perfectly and quickly when mempool is not crowded; supported by e.g. Electrum too. Although the difference between 2 sats and 1 sat is so small, probably it'd be a good feature request.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5633#issuecomment-949602427
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211022/665d1568/attachment.htm>

From notifications at github.com  Fri Oct 22 18:49:34 2021
From: notifications at github.com (Stan)
Date: Fri, 22 Oct 2021 09:49:34 -0700
Subject: [bisq-network/bisq] BSQ swaps: Low risk refactorings [2] (PR
 #5770)
In-Reply-To: <bisq-network/bisq/pull/5770@github.com>
References: <bisq-network/bisq/pull/5770@github.com>
Message-ID: <bisq-network/bisq/pull/5770/review/787072570@github.com>

@ghubstan commented on this pull request.



> @@ -96,7 +95,7 @@
     ///////////////////////////////////////////////////////////////////////////////////////////
 
     @Getter
-    private final OfferPayload offerPayload;
+    private final OfferPayloadBase offerPayloadBase;

It's odd to me that `Offer`'s payload is an instance of an abstract class, instead of an `OfferPayload`.  I'm a little confused but understand `Offer` might have an `OfferPayloadBase` (not an `OfferPayload`) due to the incremental refactoring towards supporting BSQ swaps.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5770#pullrequestreview-787072570
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211022/5d270054/attachment.htm>

From notifications at github.com  Fri Oct 22 18:53:02 2021
From: notifications at github.com (Stan)
Date: Fri, 22 Oct 2021 09:53:02 -0700
Subject: [bisq-network/bisq] BSQ swaps: Low risk refactorings [2] (PR
 #5770)
In-Reply-To: <bisq-network/bisq/pull/5770@github.com>
References: <bisq-network/bisq/pull/5770@github.com>
Message-ID: <bisq-network/bisq/pull/5770/review/787075578@github.com>

@ghubstan commented on this pull request.



> @@ -96,7 +95,7 @@
     ///////////////////////////////////////////////////////////////////////////////////////////
 
     @Getter
-    private final OfferPayload offerPayload;
+    private final OfferPayloadBase offerPayloadBase;

OK, Offer line 537 gives me the hint that this is no accident.  (No need to reply, can mark this 'resolved'.)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5770#discussion_r734702301
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211022/84bd5bf4/attachment.htm>

From notifications at github.com  Fri Oct 22 19:06:19 2021
From: notifications at github.com (Stan)
Date: Fri, 22 Oct 2021 10:06:19 -0700
Subject: [bisq-network/bisq] BSQ swaps: Low risk refactorings [2] (PR
 #5770)
In-Reply-To: <bisq-network/bisq/pull/5770@github.com>
References: <bisq-network/bisq/pull/5770@github.com>
Message-ID: <bisq-network/bisq/pull/5770/review/787087368@github.com>

@ghubstan commented on this pull request.



> @@ -414,7 +414,7 @@ public void validateBasicOfferData(PaymentMethod paymentMethod, String currencyC
     // Immutable fields are sourced from the original openOffer param.
     public OfferPayload getMergedOfferPayload(OpenOffer openOffer,
                                               MutableOfferPayloadFields mutableOfferPayloadFields) {
-        OfferPayload original = openOffer.getOffer().getOfferPayload();
+        OfferPayload original = openOffer.getOffer().getOfferPayload().orElseThrow();

How about throwing something more specific than a 'no such element' ex?

```
OfferPayload original = openOffer.getOffer().getOfferPayload().orElseThrow(() ->
                new IllegalStateException(format("OpenOffer %s has no payload.", openOffer.getId())));

```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5770#pullrequestreview-787087368
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211022/cab90c3b/attachment.htm>

From notifications at github.com  Fri Oct 22 19:10:15 2021
From: notifications at github.com (Stan)
Date: Fri, 22 Oct 2021 10:10:15 -0700
Subject: [bisq-network/bisq] BSQ swaps: Low risk refactorings [2] (PR
 #5770)
In-Reply-To: <bisq-network/bisq/pull/5770@github.com>
References: <bisq-network/bisq/pull/5770@github.com>
Message-ID: <bisq-network/bisq/pull/5770/review/787090557@github.com>

@ghubstan commented on this pull request.



> @@ -790,7 +790,7 @@ private void maybeUpdatePersistedOffers() {
         openOffersClone.forEach(originalOpenOffer -> {
             Offer originalOffer = originalOpenOffer.getOffer();
 
-            OfferPayload original = originalOffer.getOfferPayload();
+            OfferPayload original = originalOffer.getOfferPayload().orElseThrow();
             // We added CAPABILITIES with entry for Capability.MEDIATION in v1.1.6 and

```
.orElseThrow(() ->
                new IllegalStateException(format("Offer %s has no payload.", openOffer.getId())));
```
?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5770#pullrequestreview-787090557
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211022/d728b1c9/attachment.htm>

From notifications at github.com  Fri Oct 22 19:12:55 2021
From: notifications at github.com (Stan)
Date: Fri, 22 Oct 2021 10:12:55 -0700
Subject: [bisq-network/bisq] BSQ swaps: Low risk refactorings [2] (PR
 #5770)
In-Reply-To: <bisq-network/bisq/pull/5770@github.com>
References: <bisq-network/bisq/pull/5770@github.com>
Message-ID: <bisq-network/bisq/pull/5770/review/787092712@github.com>

@ghubstan commented on this pull request.



> @@ -69,7 +69,7 @@ protected void run() {
             byte[] hashOfTakersPaymentAccountPayload = taker.getHashOfPaymentAccountPayload();
             String makersPaymentMethodId = checkNotNull(processModel.getPaymentAccountPayload(trade)).getPaymentMethodId();
             String takersPaymentMethodId = checkNotNull(taker.getPaymentMethodId());
-            OfferPayload offerPayload = offer.getOfferPayload();
+            OfferPayload offerPayload = offer.getOfferPayload().orElseThrow();
 

```
.orElseThrow(() ->
                new IllegalStateException(format("Offer %s has no payload.", openOffer.getId())));

```
?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5770#pullrequestreview-787092712
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211022/fbc9830b/attachment-0001.htm>

From notifications at github.com  Fri Oct 22 19:13:23 2021
From: notifications at github.com (Stan)
Date: Fri, 22 Oct 2021 10:13:23 -0700
Subject: [bisq-network/bisq] BSQ swaps: Low risk refactorings [2] (PR
 #5770)
In-Reply-To: <bisq-network/bisq/pull/5770@github.com>
References: <bisq-network/bisq/pull/5770@github.com>
Message-ID: <bisq-network/bisq/pull/5770/review/787093104@github.com>

@ghubstan commented on this pull request.



> @@ -83,7 +83,7 @@ protected void run() {
             String takersPaymentMethodId = checkNotNull(processModel.getPaymentAccountPayload(trade)).getPaymentMethodId();
 
             Coin tradeAmount = checkNotNull(trade.getTradeAmount());
-            OfferPayload offerPayload = offer.getOfferPayload();
+            OfferPayload offerPayload = offer.getOfferPayload().orElseThrow();
             Contract contract = new Contract(

```
.orElseThrow(() ->
                new IllegalStateException(format("Offer %s has no payload.", openOffer.getId())));

```
?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5770#pullrequestreview-787093104
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211022/5cf55556/attachment.htm>

From notifications at github.com  Fri Oct 22 19:14:23 2021
From: notifications at github.com (Stan)
Date: Fri, 22 Oct 2021 10:14:23 -0700
Subject: [bisq-network/bisq] BSQ swaps: Low risk refactorings [2] (PR
 #5770)
In-Reply-To: <bisq-network/bisq/pull/5770@github.com>
References: <bisq-network/bisq/pull/5770@github.com>
Message-ID: <bisq-network/bisq/pull/5770/review/787093927@github.com>

@ghubstan commented on this pull request.



> @@ -96,7 +96,7 @@ public static TradeStatistics2 from(Trade trade,
         Offer offer = trade.getOffer();
         checkNotNull(offer, "offer must not ne null");
         checkNotNull(trade.getTradeAmount(), "trade.getTradeAmount() must not ne null");
-        OfferPayload offerPayload = offer.getOfferPayload();
+        OfferPayload offerPayload = offer.getOfferPayload().orElseThrow();

```
.orElseThrow(() ->
                new IllegalStateException(format("Offer %s has no payload.", openOffer.getId())));

```
?

Resolve these remarks when annoyed ;-)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5770#pullrequestreview-787093927
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211022/7d21788e/attachment.htm>

From notifications at github.com  Fri Oct 22 19:14:53 2021
From: notifications at github.com (Stan)
Date: Fri, 22 Oct 2021 10:14:53 -0700
Subject: [bisq-network/bisq] BSQ swaps: Low risk refactorings [2] (PR
 #5770)
In-Reply-To: <bisq-network/bisq/pull/5770@github.com>
References: <bisq-network/bisq/pull/5770@github.com>
Message-ID: <bisq-network/bisq/pull/5770/review/787094319@github.com>

@ghubstan commented on this pull request.



> @@ -257,7 +257,7 @@ void initWithData(Offer offer) {
         });
 
         mempoolStatus.setValue(-1);
-        OfferPayload offerPayload = offer.getOfferPayload();
+        OfferPayload offerPayload = offer.getOfferPayload().orElseThrow();

```
.orElseThrow(() ->
                new IllegalStateException(format("Offer %s has no payload.", openOffer.getId())));

```
?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5770#pullrequestreview-787094319
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211022/9b3e3e23/attachment.htm>

From notifications at github.com  Fri Oct 22 19:15:34 2021
From: notifications at github.com (Stan)
Date: Fri, 22 Oct 2021 10:15:34 -0700
Subject: [bisq-network/bisq] BSQ swaps: Low risk refactorings [2] (PR
 #5770)
In-Reply-To: <bisq-network/bisq/pull/5770@github.com>
References: <bisq-network/bisq/pull/5770@github.com>
Message-ID: <bisq-network/bisq/pull/5770/review/787094912@github.com>

@ghubstan commented on this pull request.



> @@ -256,7 +256,7 @@ public void initialize() {
                     MenuItem editItem = new MenuItem(Res.get("portfolio.context.offerLikeThis"));
                     editItem.setOnAction((event) -> {
                         try {
-                            OfferPayload offerPayload = row.getItem().getTradable().getOffer().getOfferPayload();
+                            OfferPayload offerPayload = row.getItem().getTradable().getOffer().getOfferPayload().orElseThrow();

```
.orElseThrow(() ->
                new IllegalStateException(format("Offer %s has no payload.", openOffer.getId())));

```
?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5770#pullrequestreview-787094912
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211022/2f261d17/attachment.htm>

From notifications at github.com  Fri Oct 22 19:17:48 2021
From: notifications at github.com (Stan)
Date: Fri, 22 Oct 2021 10:17:48 -0700
Subject: [bisq-network/bisq] BSQ swaps: Low risk refactorings [2] (PR
 #5770)
In-Reply-To: <bisq-network/bisq/pull/5770@github.com>
References: <bisq-network/bisq/pull/5770@github.com>
Message-ID: <bisq-network/bisq/pull/5770/review/787097484@github.com>

@ghubstan commented on this pull request.



> @@ -184,7 +184,7 @@ public void onStartEditOffer(ErrorMessageHandler errorMessageHandler) {
     }
 
     public void onPublishOffer(ResultHandler resultHandler, ErrorMessageHandler errorMessageHandler) {
-        OfferPayload offerPayload = createAndGetOffer().getOfferPayload();
+        OfferPayload offerPayload = createAndGetOffer().getOfferPayload().orElseThrow();

`orElseThrow()` 'offer has no payload' instead?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5770#pullrequestreview-787097484
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211022/0388d0e3/attachment.htm>

From notifications at github.com  Fri Oct 22 19:17:54 2021
From: notifications at github.com (Stan)
Date: Fri, 22 Oct 2021 10:17:54 -0700
Subject: [bisq-network/bisq] BSQ swaps: Low risk refactorings [2] (PR
 #5770)
In-Reply-To: <bisq-network/bisq/pull/5770@github.com>
References: <bisq-network/bisq/pull/5770@github.com>
Message-ID: <bisq-network/bisq/pull/5770/review/787097591@github.com>

@ghubstan commented on this pull request.



> @@ -188,7 +188,7 @@ public void initialize() {
                     MenuItem editItem = new MenuItem(Res.get("portfolio.context.offerLikeThis"));
                     editItem.setOnAction((event) -> {
                         try {
-                            OfferPayload offerPayload = row.getItem().getOffer().getOfferPayload();
+                            OfferPayload offerPayload = row.getItem().getOffer().getOfferPayload().orElseThrow();
                             navigation.navigateToWithData(offerPayload, MainView.class, PortfolioView.class,

`orElseThrow()` 'offer has no payload' instead?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5770#pullrequestreview-787097591
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211022/f60aab88/attachment-0001.htm>

From notifications at github.com  Fri Oct 22 19:18:06 2021
From: notifications at github.com (Stan)
Date: Fri, 22 Oct 2021 10:18:06 -0700
Subject: [bisq-network/bisq] BSQ swaps: Low risk refactorings [2] (PR
 #5770)
In-Reply-To: <bisq-network/bisq/pull/5770@github.com>
References: <bisq-network/bisq/pull/5770@github.com>
Message-ID: <bisq-network/bisq/pull/5770/review/787097745@github.com>

@ghubstan commented on this pull request.



> @@ -235,7 +235,7 @@ public void initialize() {
                     MenuItem editItem = new MenuItem(Res.get("portfolio.context.offerLikeThis"));
                     editItem.setOnAction((event) -> {
                         try {
-                            OfferPayload offerPayload = row.getItem().getTrade().getOffer().getOfferPayload();
+                            OfferPayload offerPayload = row.getItem().getTrade().getOffer().getOfferPayload().orElseThrow();
                             if (offerPayload.getPubKeyRing().equals(keyRing.getPubKeyRing())) {

`orElseThrow()` 'offer has no payload' instead?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5770#pullrequestreview-787097745
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211022/4fd74e1b/attachment.htm>

From notifications at github.com  Sat Oct 23 05:19:56 2021
From: notifications at github.com (jmacxx)
Date: Fri, 22 Oct 2021 20:19:56 -0700
Subject: [bisq-network/compensation] For Cycle 29 (Issue #926)
In-Reply-To: <bisq-network/compensation/issues/926@github.com>
References: <bisq-network/compensation/issues/926@github.com>
Message-ID: <bisq-network/compensation/issues/926/950048808@github.com>

882905856b33e08085c61f316c13620f7e31f2db7a2c976b9b500de7d5128e2d

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/926#issuecomment-950048808
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211022/bf8389f5/attachment.htm>

From notifications at github.com  Sat Oct 23 12:08:37 2021
From: notifications at github.com (dgyg)
Date: Sat, 23 Oct 2021 03:08:37 -0700
Subject: [bisq-network/bisq] BSQ Missing Fund Warning (Issue #5776)
Message-ID: <bisq-network/bisq/issues/5776@github.com>

### Description

When trying to create a new offer paying with BSQ early after the startup of Bisq then a misleading warning may be displayed saying there is not enough BSQ funds available:

![bsq-warning](https://user-images.githubusercontent.com/7886722/138551927-57a5dda9-1284-4a02-bc59-385deae2927c.png)

In fact however there are enough funds available but the blockchain is still being scanned for BSQ transaction in the background and the current balance is not yet fully calculated:

![verifying](https://user-images.githubusercontent.com/7886722/138551820-fd680f9b-92f9-429f-9c97-35426fbb5efc.png)

#### Version

v1.7.4

### Expected behaviour

Warning saying that you have to wait for the blockchain to be fully verified. 

### Workaround

Wait for the blocks to be fully verified.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5776
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211023/6e75fb2d/attachment.htm>

From notifications at github.com  Sat Oct 23 12:53:52 2021
From: notifications at github.com (chimp1984)
Date: Sat, 23 Oct 2021 03:53:52 -0700
Subject: [bisq-network/bisq] Bsq swap: Implementation [3] (PR #5775)
In-Reply-To: <bisq-network/bisq/pull/5775@github.com>
References: <bisq-network/bisq/pull/5775@github.com>
Message-ID: <bisq-network/bisq/pull/5775/push/8220634770@github.com>

@chimp1984 pushed 2 commits.

fdfb029b0d038343448605c7c549d65be6a390c2  Move Utilities.objectToJson to JsonUtil.objectToJson
4ab1ee3d5865c7ab4d5bf84f48bfef35da080aa2  Add custom json serializer for OfferPayload


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/bisq-network/bisq/pull/5775/files/6d9d0f75732cdae03265574c106b2daa51ab45b5..4ab1ee3d5865c7ab4d5bf84f48bfef35da080aa2
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211023/c1a66e0d/attachment.htm>

From notifications at github.com  Sat Oct 23 13:04:49 2021
From: notifications at github.com (MwithM)
Date: Sat, 23 Oct 2021 04:04:49 -0700
Subject: [bisq-network/proposals] BSQ trading fee update for Cycle 29
 (Issue #345)
In-Reply-To: <bisq-network/proposals/issues/345@github.com>
References: <bisq-network/proposals/issues/345@github.com>
Message-ID: <bisq-network/proposals/issues/345/950135681@github.com>

Parameter proposal change for maker TXID: 227d3d6ae7a4309d816aaa28b87b210c9cba1723c0ea31751ab9c741fc2f4481
Parameter proposal change for taker TXID : e9457ce914c855ea607003ea2fe4f70dd31721590cbf125d95d27acd2f23cdca

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/proposals/issues/345#issuecomment-950135681
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211023/332872ce/attachment.htm>

From notifications at github.com  Sat Oct 23 13:06:33 2021
From: notifications at github.com (MwithM)
Date: Sat, 23 Oct 2021 04:06:33 -0700
Subject: [bisq-network/compensation] For Cycle 29 (Issue #930)
In-Reply-To: <bisq-network/compensation/issues/930@github.com>
References: <bisq-network/compensation/issues/930@github.com>
Message-ID: <bisq-network/compensation/issues/930/950135955@github.com>

Last hours to submit compensation request.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/930#issuecomment-950135955
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211023/e6bfcfef/attachment.htm>

From notifications at github.com  Sat Oct 23 13:07:19 2021
From: notifications at github.com (boring-cyborg[bot])
Date: Sat, 23 Oct 2021 04:07:19 -0700
Subject: [bisq-network/bisq] An error occurred when taking the offer
 (Issue #5777)
In-Reply-To: <bisq-network/bisq/issues/5777@github.com>
References: <bisq-network/bisq/issues/5777@github.com>
Message-ID: <bisq-network/bisq/issues/5777/950136043@github.com>

**Thanks for opening your first issue here!**<br/><br/>Be sure to follow the issue template. Your issue will be reviewed by a maintainer and labeled for further action.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5777#issuecomment-950136043
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211023/1c6ff1e9/attachment.htm>

From notifications at github.com  Sat Oct 23 13:07:21 2021
From: notifications at github.com (Daniel Domingues)
Date: Sat, 23 Oct 2021 04:07:21 -0700
Subject: [bisq-network/bisq] An error occurred when taking the offer (Issue
 #5777)
Message-ID: <bisq-network/bisq/issues/5777@github.com>

### Description

An error occurred when taking the offer

v1.7.4

### Steps to reproduce

Same steps to take take offer and the error occurred after client the button review and take the order.

### Expected behaviour

Order taken

### Screenshots

![image](https://user-images.githubusercontent.com/25759599/138553109-6da2d70b-1e4f-4c15-a3f2-cee1541a08fe.png)

#### Device or machine

System:    Kernel: 5.11.0-38-generic x86_64 bits: 64 compiler: N/A Desktop: Cinnamon 5.0.6 
           wm: muffin dm: LightDM Distro: Linux Mint 20.2 Uma base: Ubuntu 20.04 focal 
Machine:   Type: Laptop System: Dell product: Vostro 5490 v: N/A serial: <filter> Chassis: 
           type: 10 serial: <filter> 
           Mobo: Dell model: 0M9F58 v: A04 serial: <filter> UEFI: Dell v: 1.12.1 date: 11/20/2020 
Battery:   ID-1: BAT0 charge: 29.8 Wh condition: 29.8/42.0 Wh (71%) volts: 12.4/11.4 
           model: SMP DELL VM73283 serial: <filter> status: Full 
CPU:       Topology: Quad Core model: Intel Core i7-10510U bits: 64 type: MT MCP arch: Kaby Lake 
           rev: C L2 cache: 8192 KiB 
           flags: avx avx2 lm nx pae sse sse2 sse3 sse4_1 sse4_2 ssse3 vmx bogomips: 36799 
           Speed: 800 MHz min/max: 400/4900 MHz Core speeds (MHz): 1: 794 2: 790 3: 788 4: 800 
           5: 800 6: 800 7: 800 8: 800 
Graphics:  Device-1: Intel UHD Graphics vendor: Dell driver: i915 v: kernel bus ID: 00:02.0 
           chip ID: 8086:9b41 
           Device-2: NVIDIA GP108M [GeForce MX230] vendor: Dell driver: N/A bus ID: 01:00.0 
           chip ID: 10de:1d11 
           Display: x11 server: X.Org 1.20.11 driver: modesetting unloaded: fbdev,vesa 
           resolution: 1920x1080~60Hz, 1920x1080~60Hz 
           OpenGL: renderer: Mesa Intel UHD Graphics (CML GT2) v: 4.6 Mesa 21.0.3 
           direct render: Yes 
Audio:     Device-1: Intel vendor: Dell driver: sof-audio-pci bus ID: 00:1f.3 chip ID: 8086:02c8 
           Sound Server: ALSA v: k5.11.0-38-generic 
Network:   Device-1: Intel Wireless-AC 9462 driver: iwlwifi v: kernel port: 5000 bus ID: 00:14.3 
           chip ID: 8086:02f0 
           IF: wlp0s20f3 state: up mac: <filter> 
           Device-2: Realtek RTL8111/8168/8411 PCI Express Gigabit Ethernet vendor: Dell 
           driver: r8169 v: kernel port: 3000 bus ID: 02:00.0 chip ID: 10ec:8168 
           IF: enp2s0 state: down mac: <filter> 
           IF-ID-1: br-6f4f3f70148c state: down mac: <filter> 
           IF-ID-2: docker0 state: down mac: <filter> 
Drives:    Local Storage: total: 3.18 TiB used: 980.21 GiB (30.1%) 
           ID-1: /dev/nvme0n1 vendor: A-Data model: IM2P33F3A NVMe ADATA 256GB size: 238.47 GiB 
           speed: 31.6 Gb/s lanes: 4 serial: <filter> 
           ID-2: /dev/sda vendor: SanDisk model: SSD PLUS 240GB size: 223.58 GiB speed: 6.0 Gb/s 
           serial: <filter> 
           ID-3: /dev/sdb type: USB vendor: Seagate model: Expansion size: 1.82 TiB 
           serial: <filter> 
           ID-4: /dev/sdc type: USB vendor: JMicron Tech model: Generic size: 465.76 GiB 
           serial: <filter> 
           ID-5: /dev/sdd type: USB vendor: Hitachi model: HTS545050B9S size: 465.76 GiB 
           serial: <filter> 
Partition: ID-1: / size: 238.00 GiB used: 170.99 GiB (71.8%) fs: btrfs dev: /dev/nvme0n1p2 
           ID-2: /home size: 238.00 GiB used: 170.99 GiB (71.8%) fs: btrfs dev: /dev/nvme0n1p2 
Sensors:   System Temperatures: cpu: 58.0 C mobo: N/A 
           Fan Speeds (RPM): cpu: 2535 
Repos:     No active apt repos in: /etc/apt/sources.list 
           Active apt repos in: /etc/apt/sources.list.d/additional-repositories.list 
           1: deb [arch=amd64] https: //download.docker.com/linux/ubuntu bionic stable
           Active apt repos in: /etc/apt/sources.list.d/brave-browser-release.list 
           1: deb [arch=amd64] https: //brave-browser-apt-release.s3.brave.com/ stable main
           Active apt repos in: /etc/apt/sources.list.d/deadsnakes-ppa-focal.list 
           1: deb http: //ppa.launchpad.net/deadsnakes/ppa/ubuntu focal main
           Active apt repos in: /etc/apt/sources.list.d/focal-dell.list 
           1: deb http: //dell.archive.canonical.com/updates/ focal-dell public
           2: deb http: //dell.archive.canonical.com/updates/ focal-oem public
           3: deb http: //dell.archive.canonical.com/updates/ focal-somerville public
           4: deb http: //dell.archive.canonical.com/updates/ focal-somerville-melisa public
           Active apt repos in: /etc/apt/sources.list.d/google-chrome.list 
           1: deb [arch=amd64] http: //dl.google.com/linux/chrome/deb/ stable main
           Active apt repos in: /etc/apt/sources.list.d/maarten-fonville-android-studio-focal.list 
           1: deb http: //ppa.launchpad.net/maarten-fonville/android-studio/ubuntu focal main
           Active apt repos in: /etc/apt/sources.list.d/microsoft-edge-dev.list 
           1: deb [arch=amd64] http: //packages.microsoft.com/repos/edge/ stable main
           Active apt repos in: /etc/apt/sources.list.d/microsoft-prod.list 
           1: deb [arch=amd64,armhf,arm64] https: //packages.microsoft.com/ubuntu/20.04/prod focal main
           Active apt repos in: /etc/apt/sources.list.d/mongodb-org-4.4.list 
           1: deb [ arch=amd64,arm64 ] https: //repo.mongodb.org/apt/ubuntu focal/mongodb-org/4.4 multiverse
           Active apt repos in: /etc/apt/sources.list.d/official-package-repositories.list 
           1: deb http: //mirror.ufscar.br/mint-archive uma main upstream import backport
           2: deb http: //sft.if.usp.br/ubuntu focal main restricted universe multiverse
           3: deb http: //sft.if.usp.br/ubuntu focal-updates main restricted universe multiverse
           4: deb http: //sft.if.usp.br/ubuntu focal-backports main restricted universe multiverse
           5: deb http: //security.ubuntu.com/ubuntu/ focal-security main restricted universe multiverse
           6: deb http: //archive.canonical.com/ubuntu/ focal partner
           Active apt repos in: /etc/apt/sources.list.d/slack.list 
           1: deb https: //packagecloud.io/slacktechnologies/slack/debian/ jessie main
           Active apt repos in: /etc/apt/sources.list.d/sublime-text.list 
           1: deb https: //download.sublimetext.com/ apt/stable/
           Active apt repos in: /etc/apt/sources.list.d/teams.list 
           1: deb [arch=amd64] https: //packages.microsoft.com/repos/ms-teams stable main
           Active apt repos in: /etc/apt/sources.list.d/teamviewer.list 
           1: deb https: //linux.teamviewer.com/deb stable main
           Active apt repos in: /etc/apt/sources.list.d/ubuntuhandbook1-apps-focal.list 
           1: deb http: //ppa.launchpad.net/ubuntuhandbook1/apps/ubuntu focal main
           Active apt repos in: /etc/apt/sources.list.d/vscode.list 
           1: deb [arch=amd64,arm64,armhf] http: //packages.microsoft.com/repos/code stable main
Info:      Processes: 444 Uptime: 3d 2h 03m Memory: 15.43 GiB used: 5.47 GiB (35.5%) Init: systemd 
           v: 245 runlevel: 5 Compilers: gcc: 9.3.0 alt: 9 Client: Unknown python3.8 client 
           inxi: 3.0.38 



#### Additional info

Connection 3
Age: 1 hour, 16 minutes, 47.911 seconds
Peer: crq6fmhtlsnyaganzlqzgyeupipc2n4betr3vdyokg7jylrtidkwyqad.onion:9999 
Type: PEER 
Direction: Outbound
UID: f46ce511-eb21-4777-9a01-f8652119ac36
Time since last message: 5.350 seconds
Sent data: 1.864 MB; {AddDataMessage=899, NewDaoStateHashMessage=12, AddPersistableNetworkPayloadMessage=8, RefreshOfferMessage=1458, RemoveDataMessage=20, NewBlockBroadcastMessage=7, GetPeersRequest=1, RemoveMailboxDataMessage=9, BundleOfEnvelopes=527}
Received data: 2.295 MB; {AddDataMessage=1104, NewDaoStateHashMessage=12, AddPersistableNetworkPayloadMessage=8, GetPeersResponse=1, RefreshOfferMessage=1681, RemoveDataMessage=27, NewBlockBroadcastMessage=11, RemoveMailboxDataMessage=16}
CPU time spent on sending messages: 0.933 seconds
CPU time spent on receiving messages: 2.832 seconds

Connection 4
Age: 1 hour, 10 minutes, 25.983 seconds
Peer: 2qpl24kkf6dgtbh2pcmtamwmhgqdgkj2ikvyl5lpg47vlq75ijzo4yqd.onion:9999 
Type: PEER 
Direction: Outbound
UID: 2685d0e7-5637-48a9-8521-bb77eee93798
Time since last message: 0.415 seconds
Sent data: 1.722 MB; {AddDataMessage=820, NewDaoStateHashMessage=12, AddPersistableNetworkPayloadMessage=6, RefreshOfferMessage=1335, NewBlockBroadcastMessage=8, RemoveDataMessage=18, GetPeersRequest=1, RemoveMailboxDataMessage=14, BundleOfEnvelopes=469}
Received data: 1.833 MB; {AddDataMessage=873, NewDaoStateHashMessage=12, AddPersistableNetworkPayloadMessage=5, GetPeersResponse=1, RefreshOfferMessage=1503, NewBlockBroadcastMessage=6, RemoveDataMessage=27, RemoveMailboxDataMessage=8}
CPU time spent on sending messages: 0.799 seconds
CPU time spent on receiving messages: 4.375 seconds

Connection 5
Age: 1 hour, 10 minutes, 13.730 seconds
Peer: bjwxrjyspyo6qxpo4bkb56jws3i2l24tvrwcxiv45qqqo4bye7zmj2ad.onion:9999 
Type: PEER 
Direction: Outbound
UID: f65e66d1-2ecf-447e-bff1-3534cb13a49b
Time since last message: 0.118 seconds
Sent data: 1.802 MB; {AddDataMessage=860, NewDaoStateHashMessage=12, AddPersistableNetworkPayloadMessage=6, RefreshOfferMessage=1393, NewBlockBroadcastMessage=7, RemoveDataMessage=22, GetPeersRequest=1, RemoveMailboxDataMessage=13, BundleOfEnvelopes=504}
Received data: 2.059 MB; {AddDataMessage=984, NewDaoStateHashMessage=11, AddPersistableNetworkPayloadMessage=6, GetPeersResponse=1, RefreshOfferMessage=1798, NewBlockBroadcastMessage=9, RemoveDataMessage=23, RemoveMailboxDataMessage=7, BundleOfEnvelopes=7}
CPU time spent on sending messages: 0.944 seconds
CPU time spent on receiving messages: 3.581 seconds

Connection 6
Age: 1 hour, 10 minutes, 8.235 seconds
Peer: 7k5h362xgrnhxd7lngbg677rovcoiozopc6angi64437yyqbngu3nxid.onion:9999 
Type: PEER 
Direction: Outbound
UID: fc7dc572-85ee-48d2-84e6-603a1fbd656c
Time since last message: 4.886 seconds
Sent data: 1.68 MB; {AddDataMessage=804, NewDaoStateHashMessage=12, AddPersistableNetworkPayloadMessage=5, RefreshOfferMessage=1316, RemoveDataMessage=19, NewBlockBroadcastMessage=6, GetPeersRequest=1, RemoveMailboxDataMessage=10, BundleOfEnvelopes=481}
Received data: 1.937 MB; {AddDataMessage=907, AddPersistableNetworkPayloadMessage=4, GetPeersResponse=1, RefreshOfferMessage=1698, NewBlockBroadcastMessage=7, RemoveDataMessage=27, RemoveMailboxDataMessage=15}
CPU time spent on sending messages: 1.109 seconds
CPU time spent on receiving messages: 3.974 seconds

Connection 7
Age: 1 hour, 9 minutes, 45.703 seconds
Peer: ztv7vjk5bzmwyrys3ycjuh3f544rbgedap3e6g2vxfpvtltlu46xkcad.onion:9999 
Type: PEER 
Direction: Outbound
UID: 63fc9ad5-0327-4454-8214-1c26052edfc3
Time since last message: 6.284 seconds
Sent data: 1.522 MB; {AddDataMessage=729, NewDaoStateHashMessage=12, AddPersistableNetworkPayloadMessage=6, RefreshOfferMessage=1408, NewBlockBroadcastMessage=8, RemoveDataMessage=5, GetPeersRequest=1, RemoveMailboxDataMessage=7, BundleOfEnvelopes=466}
Received data: 1.81 MB; {AddDataMessage=859, NewDaoStateHashMessage=12, AddPersistableNetworkPayloadMessage=5, GetPeersResponse=1, RefreshOfferMessage=1543, NewBlockBroadcastMessage=6, RemoveDataMessage=21, RemoveMailboxDataMessage=10}
CPU time spent on sending messages: 0.815 seconds
CPU time spent on receiving messages: 2.562 seconds

Connection 8
Age: 1 hour, 8 minutes, 30.716 seconds
Peer: r63nibw7csoxvqizw3koyhwkpc6ddo5dmjpcfnwg47coma7fw3tzg5ad.onion:9999 
Type: PEER 
Direction: Outbound
UID: a0a64aae-ddb9-4ee3-8a3f-33d8f3d18a46
Time since last message: 7.502 seconds
Sent data: 1.53 MB; {AddDataMessage=734, NewDaoStateHashMessage=11, AddPersistableNetworkPayloadMessage=4, RefreshOfferMessage=1262, RemoveDataMessage=16, NewBlockBroadcastMessage=3, GetPeersRequest=1, RemoveMailboxDataMessage=8, BundleOfEnvelopes=432}
Received data: 2.149 MB; {AddDataMessage=1023, NewDaoStateHashMessage=11, AddPersistableNetworkPayloadMessage=7, GetPeersResponse=1, RefreshOfferMessage=1787, NewBlockBroadcastMessage=9, RemoveDataMessage=22, RemoveMailboxDataMessage=15}
CPU time spent on sending messages: 0.970 seconds
CPU time spent on receiving messages: 4.629 seconds

Connection 9
Age: 54 minutes, 22.820 seconds
Peer: vdqdsvz7o3fykz5galmo272mpxc63fxkfjijzjztco6v6d5ycglpz5ad.onion:8000 
Type: PEER 
Direction: Inbound
UID: a2cfb22d-b64b-4ef9-a05d-f5d705be21e3
Time since last message: 3.653 seconds
Sent data: 1.33 MB; {AddDataMessage=629, NewDaoStateHashMessage=10, AddPersistableNetworkPayloadMessage=5, GetPeersResponse=1, RefreshOfferMessage=1148, RemoveDataMessage=17, NewBlockBroadcastMessage=8, RemoveMailboxDataMessage=8, BundleOfEnvelopes=383}
Received data: 1.25 MB; {AddDataMessage=596, AddPersistableNetworkPayloadMessage=2, RefreshOfferMessage=1000, RemoveDataMessage=9, GetPeersRequest=1, RemoveMailboxDataMessage=14}
CPU time spent on sending messages: 0.722 seconds
CPU time spent on receiving messages: 1.636 seconds

Connection 10
Age: 21 minutes, 51.619 seconds
Peer: f4aofdr2isiwfnginhc2dsb7faxf4vf22l3zvtcwgte7be5dcfa3lpid.onion:9999 
Type: PEER 
Direction: Inbound
UID: b70ad285-0759-4c1a-bde7-c934bf79e8c3
Time since last message: 2.589 seconds
Sent data: 548.567 kB; {AddDataMessage=262, NewDaoStateHashMessage=5, AddPersistableNetworkPayloadMessage=1, GetPeersResponse=1, RefreshOfferMessage=365, RemoveDataMessage=4, NewBlockBroadcastMessage=2, RemoveMailboxDataMessage=3, BundleOfEnvelopes=149}
Received data: 754.868 kB; {AddDataMessage=356, NewDaoStateHashMessage=5, AddPersistableNetworkPayloadMessage=4, RefreshOfferMessage=613, RemoveDataMessage=5, NewBlockBroadcastMessage=4, GetPeersRequest=1, RemoveMailboxDataMessage=3}
CPU time spent on sending messages: 0.478 seconds
CPU time spent on receiving messages: 2.334 seconds

Connection 11
Age: 11 minutes, 20.016 seconds
Peer: yt2qy7nzy76iap5g2pgicknln7n4j7ppeyzpco5hlbsgqmkj5iytfwid.onion:9999 
Type: DIRECT_MSG_PEER 
Direction: Outbound
UID: 2b337856-9961-4eec-b500-d54fc0decf4a
Time since last message: 1.978 seconds
Sent data: 260.445 kB; {AddDataMessage=119, NewDaoStateHashMessage=1, AddPersistableNetworkPayloadMessage=1, RefreshOfferMessage=202, PrefixedSealedAndSignedMessage=7, NewBlockBroadcastMessage=1, RemoveMailboxDataMessage=1, BundleOfEnvelopes=70}
Received data: 417.305 kB; {AddDataMessage=199, NewDaoStateHashMessage=1, AddPersistableNetworkPayloadMessage=1, RefreshOfferMessage=284, PrefixedSealedAndSignedMessage=8, NewBlockBroadcastMessage=1, RemoveDataMessage=1, RemoveMailboxDataMessage=1}
CPU time spent on sending messages: 0.569 seconds
CPU time spent on receiving messages: 0.868 seconds
 
Oct-23 07:34:58.344 [JavaFX Application Thread] INFO  b.n.p.n.Statistic: Accumulated network statistics:
Bytes sent: 107.625 MB;
Number of sent messages/Sent messages: 35993 / {PreliminaryGetDataRequest=2, NewDaoStateHashMessage=126, GetBlocksRequest=6, RefreshOfferMessage=6114, RemoveDataMessage=163, GetPeersRequest=81, BundleOfEnvelopes=27412, AddDataMessage=1841, GetDaoStateHashesRequest=5, AddPersistableNetworkPayloadMessage=61, Ping=56, GetPeersResponse=24, NewBlockBroadcastMessage=58, PrefixedSealedAndSignedMessage=7, GetUpdatedDataRequest=16, RemoveMailboxDataMessage=14, Pong=7};
Number of sent messages per sec: 1.1880054130772024;
Bytes received: 106.6 MB
Number of received messages/Received messages: 33979 / {NewDaoStateHashMessage=83, RefreshOfferMessage=5210, GetProposalStateHashesResponse=4, RemoveDataMessage=106, GetPeersRequest=24, GetBlindVoteStateHashesResponse=4, BundleOfEnvelopes=27123, AddDataMessage=1174, GetDaoStateHashesResponse=5, AddPersistableNetworkPayloadMessage=56, GetPeersResponse=80, Ping=7, GetDataResponse=8, CloseConnectionMessage=16, NewBlockBroadcastMessage=39, PrefixedSealedAndSignedMessage=8, RemoveMailboxDataMessage=9, GetBlocksResponse=6, Pong=17};
Number of received messages per sec: 1.121530184506717;
 
Oct-23 07:36:24.170 [JavaFX Application Thread] INFO  b.c.u.DesktopUtil: Trying to exec: cmd = kde-open args = %s file = /home/user1/.local/share/Bisq/bisq.log 
Oct-23 07:36:24.173 [JavaFX Application Thread] WARN  b.c.u.DesktopUtil: Error running command. java.io.IOException: Cannot run program "kde-open": error=2, No such file or directory 
Oct-23 07:36:24.173 [JavaFX Application Thread] INFO  b.c.u.DesktopUtil: Trying to exec: cmd = gnome-open args = %s file = /home/user1/.local/share/Bisq/bisq.log 
Oct-23 07:36:24.175 [JavaFX Application Thread] WARN  b.c.u.DesktopUtil: Error running command. java.io.IOException: Cannot run program "gnome-open": error=2, No such file or directory 
Oct-23 07:36:24.175 [JavaFX Application Thread] INFO  b.c.u.DesktopUtil: Trying to exec: cmd = xdg-open args = %s file = /home/user1/.local/share/Bisq/bisq.log 
Oct-23 07:36:24.177 [JavaFX Application Thread] INFO  b.c.u.DesktopUtil: Process is running. 


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5777
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211023/05325379/attachment-0001.htm>

From notifications at github.com  Sat Oct 23 13:16:25 2021
From: notifications at github.com (sqrrm)
Date: Sat, 23 Oct 2021 04:16:25 -0700
Subject: [bisq-network/compensation] For Cycle 29 (Issue #930)
In-Reply-To: <bisq-network/compensation/issues/930@github.com>
References: <bisq-network/compensation/issues/930@github.com>
Message-ID: <bisq-network/compensation/issues/930/950137024@github.com>

@MwithM Thanks for the reminder.

Tx: 4a2bb44abcf3ed01c1a8c1ea21f1a82898974e5530a7354aaf149619a8e64e25

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/930#issuecomment-950137024
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211023/9f6e32de/attachment.htm>

From notifications at github.com  Sat Oct 23 13:19:53 2021
From: notifications at github.com (sqrrm)
Date: Sat, 23 Oct 2021 04:19:53 -0700
Subject: [bisq-network/compensation] For Cycle 29 (Issue #931)
In-Reply-To: <bisq-network/compensation/issues/931@github.com>
References: <bisq-network/compensation/issues/931@github.com>
Message-ID: <bisq-network/compensation/issues/931/950137412@github.com>

I approve this compensation request

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/931#issuecomment-950137412
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211023/b6da5b06/attachment.htm>

From notifications at github.com  Sat Oct 23 13:38:11 2021
From: notifications at github.com (MwithM)
Date: Sat, 23 Oct 2021 04:38:11 -0700
Subject: [bisq-network/compensation] For Cycle 29 (Issue #932)
In-Reply-To: <bisq-network/compensation/issues/932@github.com>
References: <bisq-network/compensation/issues/932@github.com>
Message-ID: <bisq-network/compensation/issues/932/950139462@github.com>

Proposal TXID: bd8133e2e7b117c50d8c0c3e5f65941133db9709c86591bf87064efd60da0216

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/932#issuecomment-950139462
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211023/ba5fc5fc/attachment.htm>

From notifications at github.com  Sat Oct 23 13:42:30 2021
From: notifications at github.com (Chris Beams)
Date: Sat, 23 Oct 2021 04:42:30 -0700
Subject: [bisq-network/compensation] For Cycle 29 (Issue #924)
In-Reply-To: <bisq-network/compensation/issues/924@github.com>
References: <bisq-network/compensation/issues/924@github.com>
Message-ID: <bisq-network/compensation/issues/924/950139964@github.com>

proposal txid: `d6180270317ab34cb8d9aff83ee7cd788d7fb47a60d51c3f6caf7e4afaeba3f6`

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/924#issuecomment-950139964
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211023/bda3c9f1/attachment.htm>

From notifications at github.com  Sat Oct 23 13:57:01 2021
From: notifications at github.com (Chris Beams)
Date: Sat, 23 Oct 2021 04:57:01 -0700
Subject: [bisq-network/roles] Comptroller (Issue #111)
In-Reply-To: <bisq-network/roles/issues/111@github.com>
References: <bisq-network/roles/issues/111@github.com>
Message-ID: <bisq-network/roles/issues/111/950141585@github.com>

> > * I like the simple breakdown of numbers you've started with here. I think it would be worth having a single rolled up, USD denominated revenue number that sums up the BSQ and BTC revenue numbers above, but this is a minor point.
> 
> I am not sure what you mean with this? Can you expand?

I just mean that when a reader sees the two line items below:

|  August 2021 | USD | BTC | BSQ |
| ------------- | ------------- | ------------- | ------------- |
| BSQ trade revenue fees  | $8,562 | 0.18759448 BTC | **546.81 BSQ** |
| BTC trade revenue fees  | $35,096 | **0.76895773 BTC** | N/A |

They must mentally add up the items to get a "rolled up revenue number", making it hard to answer the basic question "how much did we take in this month?".

I think it's good to see a single, top-line revenue number, denominated in USD, but it can have the calculated BTC and BSQ equivalents right next to it, just for reference.

Basically, it's this top-line revenue number that I would want to track over time. Is that number going up or down, cycle-over-cycle?

Being able to break the top-line revenue number down into BTC and BSQ parts is of course important information too, but I wouldn't want to miss making the top line number explicit and easily trackable.




> > * It would be good to see the actual BSQ number in the BSQ trade revenue fees line item. Same with contributor costs. Since these are actually denominated in BSQ, it would be good to see a third column "BSQ" that lists these values. Perhaps you could **bold** the values for each row that represent the original denomination.
> 
> Included, and updated.

Thanks for adding the BSQ column. Instead of putting 'N/A' in the "BTC trade fee revenues" row, however, I'd suggest putting the calculated equivalent BSQ number there too. Just like we do in the other rows with calculated BTC and USD values.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/roles/issues/111#issuecomment-950141585
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211023/45c279e2/attachment.htm>

From notifications at github.com  Sat Oct 23 14:14:35 2021
From: notifications at github.com (Chris Beams)
Date: Sat, 23 Oct 2021 05:14:35 -0700
Subject: [bisq-network/roles] Monitoring Operator/Maintainer (#10)
In-Reply-To: <bisq-network/roles/issues/10@github.com>
References: <bisq-network/roles/issues/10@github.com>
Message-ID: <bisq-network/roles/issues/10/950143679@github.com>

> ## Cycle 29 report
> 
> Running monitor.bisq.network

Looks like a lot of errors at https://monitor.bisq.network. Not sure how long it's been that way. Any insights, @Emzy? I wonder who / how many users or contributors are using this resource regularly.

<img width="1552" alt="Screen Shot 2021-10-23 at 2 12 44 PM" src="https://user-images.githubusercontent.com/301810/138555571-7eca2e62-7e14-48c0-abd3-289edaf2dd49.png">




-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/roles/issues/10#issuecomment-950143679
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211023/5a2b3147/attachment-0001.htm>

From notifications at github.com  Sat Oct 23 14:15:32 2021
From: notifications at github.com (chimp1984)
Date: Sat, 23 Oct 2021 05:15:32 -0700
Subject: [bisq-network/bisq] Bsq swap: Implementation [3] (PR #5775)
In-Reply-To: <bisq-network/bisq/pull/5775@github.com>
References: <bisq-network/bisq/pull/5775@github.com>
Message-ID: <bisq-network/bisq/pull/5775/push/8220857046@github.com>

@chimp1984 pushed 3 commits.

348bf3bda64ad936ce4f63f4adbc4bb6abae1542  Update text
238a7dc1f5d13d091425c5e1fdee990a68a4cc54  Remove missingFundsListener after successful take offer
b39396858097dbefd3296aab81675e7978a819e1  Change log level


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/bisq-network/bisq/pull/5775/files/4ab1ee3d5865c7ab4d5bf84f48bfef35da080aa2..b39396858097dbefd3296aab81675e7978a819e1
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211023/7e88ca1c/attachment.htm>

From notifications at github.com  Sat Oct 23 14:25:28 2021
From: notifications at github.com (Chris Beams)
Date: Sat, 23 Oct 2021 05:25:28 -0700
Subject: [bisq-network/compensation] For Cycle 29 (Issue #926)
In-Reply-To: <bisq-network/compensation/issues/926@github.com>
References: <bisq-network/compensation/issues/926@github.com>
Message-ID: <bisq-network/compensation/issues/926/950144929@github.com>

> maintenance/operation of compensation-bot

Hey @jmacxx. I asked @MwithM to start creating actual issues around cycle deadlines so that subscribers to the compensation repository get notifications about these deadlines instead of having to diligently check in on them.

https://github.com/bisq-network/compensation/issues/922 is the first such example issue, and as you can see, it resulted in a bunch of false errors from the compensation-bot. Could you implement support for suppressing the bot with a #nobot hashtag in the title, or (better) a `#nobot` GH Issues label? Would be the equivalent of what we do with `[WIP]` prefixes, but made more obvious and explicit for this use case of "non-compensation request issues in the compensation repository". Thanks!

BTW, the advantage of a `#nobot` hashtag in the title is that any issue creator could use it, but given that the only use case we have right now for this is @MwithM creating these deadline issues, and given that he's an admin for the compensation repo, I'd think it would be better to implement a `#nobot` GH Issues label, as it'll be cleaner and he has permissions to apply labels at issue creation time.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/926#issuecomment-950144929
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211023/0974783c/attachment.htm>

From notifications at github.com  Sat Oct 23 14:27:40 2021
From: notifications at github.com (jmacxx)
Date: Sat, 23 Oct 2021 05:27:40 -0700
Subject: [bisq-network/bisq] An error occurred when taking the offer
 (Issue #5777)
In-Reply-To: <bisq-network/bisq/issues/5777@github.com>
References: <bisq-network/bisq/issues/5777@github.com>
Message-ID: <bisq-network/bisq/issues/5777/950145167@github.com>

Please contact support on keybase if possible https://bisq.wiki/User_support

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5777#issuecomment-950145167
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211023/f3e77f30/attachment.htm>

From notifications at github.com  Sat Oct 23 14:31:27 2021
From: notifications at github.com (Stephan Oeste)
Date: Sat, 23 Oct 2021 05:31:27 -0700
Subject: [bisq-network/roles] Monitoring Operator/Maintainer (#10)
In-Reply-To: <bisq-network/roles/issues/10@github.com>
References: <bisq-network/roles/issues/10@github.com>
Message-ID: <bisq-network/roles/issues/10/950145643@github.com>

This was the issue: https://github.com/bisq-network/bisq/issues/5297
AFAIK is the broken part is the data delivery from the local running Bisq client.
I just never got the version of the Bisq client with proper monitoring. The data I get on the Graphite/Grafana site is empty.
What's working is the data send from all the pricenodes. 
Example: https://monitor.bisq.network/d/qclhStdWz/server-metrics?orgId=1&var-Server=devinpndvdwll4wiqcyq5e7itezmarg7rzicrvf6brzkwxdm374kmmyd

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/roles/issues/10#issuecomment-950145643
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211023/e60bafad/attachment.htm>

From notifications at github.com  Sat Oct 23 14:33:36 2021
From: notifications at github.com (jmacxx)
Date: Sat, 23 Oct 2021 05:33:36 -0700
Subject: [bisq-network/compensation] For Cycle 29 (Issue #926)
In-Reply-To: <bisq-network/compensation/issues/926@github.com>
References: <bisq-network/compensation/issues/926@github.com>
Message-ID: <bisq-network/compensation/issues/926/950145886@github.com>

@cbeams sounds good, working on it.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/926#issuecomment-950145886
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211023/41bae8dc/attachment.htm>

From notifications at github.com  Sat Oct 23 15:05:47 2021
From: notifications at github.com (chimp1984)
Date: Sat, 23 Oct 2021 06:05:47 -0700
Subject: [bisq-network/bisq] Bsq swap: Implementation [3] (PR #5775)
In-Reply-To: <bisq-network/bisq/pull/5775@github.com>
References: <bisq-network/bisq/pull/5775@github.com>
Message-ID: <bisq-network/bisq/pull/5775/push/8221006344@github.com>

@chimp1984 pushed 1 commit.

a77d65b4db0f29a663bccbc951f63ea6936fc2b7  Improve BSQ swap offer details window


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/bisq-network/bisq/pull/5775/files/b39396858097dbefd3296aab81675e7978a819e1..a77d65b4db0f29a663bccbc951f63ea6936fc2b7
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211023/8c7bcaf3/attachment-0001.htm>

From notifications at github.com  Sat Oct 23 16:07:35 2021
From: notifications at github.com (m52go)
Date: Sat, 23 Oct 2021 07:07:35 -0700
Subject: [bisq-network/growth] Creating a German-only Bisq account on
 Twitter to reach the growing German-speaking audience (#249)
In-Reply-To: <bisq-network/growth/issues/249@github.com>
References: <bisq-network/growth/issues/249@github.com>
Message-ID: <bisq-network/growth/issues/249/950158276@github.com>

@stopfeds [your latest tweet](https://twitter.com/BisqDe/status/1451867511692177413) looks really scammy...to me it doesn't come off well at all.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/growth/issues/249#issuecomment-950158276
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211023/c18da42b/attachment.htm>

From notifications at github.com  Sat Oct 23 16:12:32 2021
From: notifications at github.com (chimp1984)
Date: Sat, 23 Oct 2021 07:12:32 -0700
Subject: [bisq-network/bisq] Bsq swap: Implementation [3] (PR #5775)
In-Reply-To: <bisq-network/bisq/pull/5775@github.com>
References: <bisq-network/bisq/pull/5775@github.com>
Message-ID: <bisq-network/bisq/pull/5775/push/8221209426@github.com>

@chimp1984 pushed 2 commits.

7dfb2617625f595e16e45f3d1abd0c52b329d654  Update dev mode values for create offer
c86801fa03aa6e1265bb62460d78084d8a0d8904  Workaround for weird JFXComboBox bug


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/bisq-network/bisq/pull/5775/files/a77d65b4db0f29a663bccbc951f63ea6936fc2b7..c86801fa03aa6e1265bb62460d78084d8a0d8904
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211023/d710fd6e/attachment.htm>

From notifications at github.com  Sat Oct 23 16:49:54 2021
From: notifications at github.com (chimp1984)
Date: Sat, 23 Oct 2021 07:49:54 -0700
Subject: [bisq-network/bisq] Bsq swap: Implementation [3] (PR #5775)
In-Reply-To: <bisq-network/bisq/pull/5775@github.com>
References: <bisq-network/bisq/pull/5775@github.com>
Message-ID: <bisq-network/bisq/pull/5775/push/8221324418@github.com>

@chimp1984 pushed 3 commits.

395d93975bbe68f9cbf75f739941f43b22286032  Add default value if no filter is available
f970f09798eb13cf92b7e58b8d8022d17b30d7fc  Add log
904fa07eae7967be32a6eb635af7651ff5030754  Reset address entry if BSQ swap offer is used for create offer


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/bisq-network/bisq/pull/5775/files/c86801fa03aa6e1265bb62460d78084d8a0d8904..904fa07eae7967be32a6eb635af7651ff5030754
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211023/16ce10e9/attachment.htm>

From notifications at github.com  Sat Oct 23 17:17:07 2021
From: notifications at github.com (jmacxx)
Date: Sat, 23 Oct 2021 08:17:07 -0700
Subject: [jmacxx/compensation-bot] Where is the code for bisq-bot? (#8)
In-Reply-To: <jmacxx/compensation-bot/issues/8@github.com>
References: <jmacxx/compensation-bot/issues/8@github.com>
Message-ID: <jmacxx/compensation-bot/issue/8/issue_event/5508382185@github.com>

Closed #8.

-- 
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/jmacxx/compensation-bot/issues/8#event-5508382185
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211023/5a5ff559/attachment.htm>

From notifications at github.com  Sat Oct 23 17:17:08 2021
From: notifications at github.com (jmacxx)
Date: Sat, 23 Oct 2021 08:17:08 -0700
Subject: [jmacxx/compensation-bot] Where is the code for bisq-bot? (#8)
In-Reply-To: <jmacxx/compensation-bot/issues/8@github.com>
References: <jmacxx/compensation-bot/issues/8@github.com>
Message-ID: <jmacxx/compensation-bot/issues/8/950167173@github.com>

It is in the Bisq growth repo:
https://github.com/bisq-network/growth/tree/master/reporting/compensation-bot

-- 
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/jmacxx/compensation-bot/issues/8#issuecomment-950167173
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211023/0714a1ee/attachment.htm>

From notifications at github.com  Sat Oct 23 17:18:44 2021
From: notifications at github.com (jmacxx)
Date: Sat, 23 Oct 2021 08:18:44 -0700
Subject: [bisq-network/growth] Compensation bot update - handle the nobot
 label (PR #252)
Message-ID: <bisq-network/growth/pull/252@github.com>

Per request by @cbeams the bot will check for the label `nobot` and if found the issue is not parsed as a compensation request.  If an issue has the `nobot` label applied after parsing, any existing bot-applied labels will be removed.

---

Example from my [test repo](https://github.com/jmacxx/compensation-bot/issues):

![image](https://user-images.githubusercontent.com/47253594/138562126-d00390e6-c23c-4e46-bb90-a036eb273843.png)

---

@mwithm please could you define the label `nobot` in the https://github.com/bisq-network/compensation/labels.

You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/growth/pull/252

-- Commit Summary --

  * <a href="https://github.com/bisq-network/growth/pull/252/commits/27c695f31b72d31ba5e238e4573600c00a0568a5">Bumped probot version to 10.8.1</a>
  * <a href="https://github.com/bisq-network/growth/pull/252/commits/94782ce03f7347088249d6dcd3e8dbcc00cdfbef">Handle nobot label for issues not to be parsed; fix bug with BSQ rate announcement sticky parsing</a>

-- File Changes --

    M reporting/compensation-bot/index.js (15)
    M reporting/compensation-bot/package.json (2)

-- Patch Links --

https://github.com/bisq-network/growth/pull/252.patch
https://github.com/bisq-network/growth/pull/252.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/growth/pull/252
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211023/48ef4899/attachment-0001.htm>

From notifications at github.com  Sat Oct 23 17:32:39 2021
From: notifications at github.com (jmacxx)
Date: Sat, 23 Oct 2021 08:32:39 -0700
Subject: [bisq-network/growth] Creating a German-only Bisq account on
 Twitter to reach the growing German-speaking audience (#249)
In-Reply-To: <bisq-network/growth/issues/249@github.com>
References: <bisq-network/growth/issues/249@github.com>
Message-ID: <bisq-network/growth/issues/249/950169166@github.com>

This is a classic "you can't have nice things".  All giveaways have been made toxic by bad actors on youtube and twitter.  I am of the opinion that the tweet is ok; as a rational human being I think I can distinguish between good intentions and bad, but I understand not everyone can do that and people tend to knee-jerk reactions (I don't mean you @m52go, just people in general).  Just wanted to speak up in favor of @stopfeds honorable intentions.  Whatever the community thinks tho..

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/growth/issues/249#issuecomment-950169166
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211023/2c98af6a/attachment.htm>

From notifications at github.com  Sat Oct 23 18:52:53 2021
From: notifications at github.com (burningman3)
Date: Sat, 23 Oct 2021 09:52:53 -0700
Subject: [bisq-network/roles] BTC donation address owner ("Burningman")
 (#80)
In-Reply-To: <bisq-network/roles/issues/80@github.com>
References: <bisq-network/roles/issues/80@github.com>
Message-ID: <bisq-network/roles/issues/80/950180332@github.com>

## Report Oct 23 2021 - Cycle 29

Trades since last report. The first new trade is highlighted.
![trades-20211023](https://user-images.githubusercontent.com/65353630/138564976-8acdea0f-7424-4711-86e4-07e1a68b9c39.png)


Trade history in csv format
[tradeHistory.txt](https://github.com/bisq-network/roles/files/7403354/tradeHistory.txt)



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/roles/issues/80#issuecomment-950180332
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211023/f57e1de9/attachment.htm>

From notifications at github.com  Sat Oct 23 18:55:57 2021
From: notifications at github.com (burningman3)
Date: Sat, 23 Oct 2021 09:55:57 -0700
Subject: [bisq-network/compensation] For Cycle 29 (Issue #934)
Message-ID: <bisq-network/compensation/issues/934@github.com>

<!--
Compensation requests have a specific format that enables them to be evaluated by a bot for more efficient budgeting. Please make sure you stick to the template. A linter will evaluate your request after you remove [WIP] from the issue title and notify you of any issues.

See the following link for details:
https://bisq.wiki/Making_a_compensation_request

Feel free to browse other requests if you're not sure about something, or reach out in #compensation on Keybase (https://keybase.io/team/bisq).
-->


## Summary

> _Specify the total amount of BSQ you are requesting, along with the USD total and BSQ/USD rate (don't include the brackets!):_

- **BSQ requested**: **`[645.16]`** <!-- [BSQ amount] should be: USD amount / BSQ rate -->
- USD requested: [1000] <!-- [USD amount] should be: total of all contributions listed in "contributions delivered" table below -->
- BSQ rate: [1.55] USD per BSQ <!-- [rate] should be the rate used to determine the BSQ amount above, as specified in the cycle's rate announcement (https://bisq.wiki/Compensation_Maintainer#Announce_BSQ-USD_rate) -->
- Previous compensation request (if applicable): #918  <!-- Link to last compensation request submitted -->


## Contributions delivered

> _Add contributions you have [delivered](https://github.com/bisq-network/proposals/issues/19) and roles you have performed here as new rows in the table below. Role line-items should include an asterisk (*) in the team column._

| Title | Team | USD | Link | Notes |
| --- | --- | --- | --- | --- |
| BSQ buying and burning, using funds from donation and fee addresses | support | 1000 | https://github.com/bisq-network/roles/issues/80#issuecomment-950180332 | |

<!-- 

Each contribution should be a new line-item in the table above. 

Title - optional, string.
Team - optional, must one of the following: admin, dev, growth, ops, support (case-insensitive). If the line-item is for a role, please add a `*`. See Example 2 below.
USD - optional, number. Please do not specify 'USD', as the column title makes units clear.
Link - optional, string.
Notes - optional, string.

Example 1 - typical contribution:

| Add local Bitcoin node configuration detection | dev | 240 | https://github.com/bisq-network/bisq/pull/3982

Example 2 - role (note the asterisk):

| Community manager | growth* | 400 | https://github.com/bisq-network/roles/issues/95#issuecomment-628431613

Example 3 - list of minor contributions, such as reviews:

| | | | https://github.com/bisq-network/bisq/pull/3968 | This and PRs below too small to be valued separately. See total at bottom.
| | | | https://github.com/bisq-network/bisq/pull/4040
| | | | https://github.com/bisq-network/bisq/pull/4044
| | | | https://github.com/bisq-network/bisq/pull/4048
| | | | https://github.com/bisq-network/bisq/pull/4066
| | dev | 400 | https://github.com/bisq-network/bisq/pull/4062 | Total for items above.

-->


## Contributions in progress

> _Provide links to work you're involved with that is still [in progress](https://github.com/bisq-network/proposals/issues/19). **This section is optional (the linter ignores it),** and is for your own benefit in keeping track of what you're doing and keeping other contributors up to date with the same._


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/934
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211023/4a7c2b5d/attachment.htm>

From notifications at github.com  Sat Oct 23 19:12:04 2021
From: notifications at github.com (burningman3)
Date: Sat, 23 Oct 2021 10:12:04 -0700
Subject: [bisq-network/compensation] For Cycle 29 (Issue #934)
In-Reply-To: <bisq-network/compensation/issues/934@github.com>
References: <bisq-network/compensation/issues/934@github.com>
Message-ID: <bisq-network/compensation/issues/934/950182994@github.com>

Tx ID: eb779e97283000dd081d14f0fcdea44f1d6d06c5e91e3511e8e510c8f844633a

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/934#issuecomment-950182994
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211023/dd818a82/attachment.htm>

From notifications at github.com  Sat Oct 23 19:35:56 2021
From: notifications at github.com (pazza)
Date: Sat, 23 Oct 2021 10:35:56 -0700
Subject: [bisq-network/roles] Comptroller (Issue #111)
In-Reply-To: <bisq-network/roles/issues/111@github.com>
References: <bisq-network/roles/issues/111@github.com>
Message-ID: <bisq-network/roles/issues/111/950186481@github.com>

I have made the above changes and added a few heading to try and make things clearer.

Might also be good to see if I can breakdown trade volume into; Fiat, XMR, other altcoins. I will see if I can do this for the next cycle.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/roles/issues/111#issuecomment-950186481
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211023/1be8b3dd/attachment-0001.htm>

From notifications at github.com  Sat Oct 23 19:52:12 2021
From: notifications at github.com (pazza)
Date: Sat, 23 Oct 2021 10:52:12 -0700
Subject: [bisq-network/bisq] Running the numbers on Bisq DAO revenues
 (Discussion #5171)
In-Reply-To: <bisq-network/bisq/repo-discussions/5171@github.com>
References: <bisq-network/bisq/repo-discussions/5171@github.com>
Message-ID: <bisq-network/bisq/repo-discussions/5171/comments/1525741@github.com>

[Comptroller role](https://github.com/bisq-network/roles/issues/111) has been created.

Reports will be issued on a monthly cycle. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/discussions/5171#discussioncomment-1525741
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211023/70899aa4/attachment.htm>

From notifications at github.com  Sat Oct 23 20:03:04 2021
From: notifications at github.com (pazza)
Date: Sat, 23 Oct 2021 11:03:04 -0700
Subject: [bisq-network/compensation] For Cycle 29 (Issue #925)
In-Reply-To: <bisq-network/compensation/issues/925@github.com>
References: <bisq-network/compensation/issues/925@github.com>
Message-ID: <bisq-network/compensation/issues/925/950190193@github.com>

Submitted compensation request to not miss close of proposal stage. Still awaiting review from @leo816 

Tx Id: 42d22611b49af9f015fceb5f4050edcaaf2abf53db090cf071a96d5104891278

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/925#issuecomment-950190193
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211023/8d4baf53/attachment.htm>

From notifications at github.com  Sat Oct 23 20:06:55 2021
From: notifications at github.com (leo816)
Date: Sat, 23 Oct 2021 11:06:55 -0700
Subject: [bisq-network/compensation] For Cycle 29 (#923)
In-Reply-To: <bisq-network/compensation/issues/923@github.com>
References: <bisq-network/compensation/issues/923@github.com>
Message-ID: <bisq-network/compensation/issues/923/950190697@github.com>

My [Team Lead](https://bisq.wiki/Compensation#Team_Lead)  review is complete and I approve this request. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/923#issuecomment-950190697
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211023/0ee38ffe/attachment.htm>

From notifications at github.com  Sat Oct 23 20:07:11 2021
From: notifications at github.com (leo816)
Date: Sat, 23 Oct 2021 11:07:11 -0700
Subject: [bisq-network/compensation] For Cycle 29 (Issue #925)
In-Reply-To: <bisq-network/compensation/issues/925@github.com>
References: <bisq-network/compensation/issues/925@github.com>
Message-ID: <bisq-network/compensation/issues/925/950190732@github.com>

My [Team Lead](https://bisq.wiki/Compensation#Team_Lead)  review is complete and I approve this request. Please submit your DAO proposal and paste the transaction ID here as a comment when complete, thanks.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/925#issuecomment-950190732
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211023/9a6e551c/attachment.htm>

From notifications at github.com  Sat Oct 23 20:07:54 2021
From: notifications at github.com (leo816)
Date: Sat, 23 Oct 2021 11:07:54 -0700
Subject: [bisq-network/compensation] For Cycle 29 (Issue #926)
In-Reply-To: <bisq-network/compensation/issues/926@github.com>
References: <bisq-network/compensation/issues/926@github.com>
Message-ID: <bisq-network/compensation/issues/926/950190817@github.com>

My [Team Lead](https://bisq.wiki/Compensation#Team_Lead)  review is complete and I approve this request.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/926#issuecomment-950190817
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211023/b94ad450/attachment.htm>

From notifications at github.com  Sat Oct 23 20:08:39 2021
From: notifications at github.com (leo816)
Date: Sat, 23 Oct 2021 11:08:39 -0700
Subject: [bisq-network/compensation] For Cycle 29 (Issue #932)
In-Reply-To: <bisq-network/compensation/issues/932@github.com>
References: <bisq-network/compensation/issues/932@github.com>
Message-ID: <bisq-network/compensation/issues/932/950190908@github.com>

My [Team Lead](https://bisq.wiki/Compensation#Team_Lead)  review is complete and I approve this request. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/932#issuecomment-950190908
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211023/d2c5482d/attachment.htm>

From notifications at github.com  Sat Oct 23 20:08:58 2021
From: notifications at github.com (leo816)
Date: Sat, 23 Oct 2021 11:08:58 -0700
Subject: [bisq-network/compensation] For Cycle 29 (Issue #933)
In-Reply-To: <bisq-network/compensation/issues/933@github.com>
References: <bisq-network/compensation/issues/933@github.com>
Message-ID: <bisq-network/compensation/issues/933/950190962@github.com>

My [Team Lead](https://bisq.wiki/Compensation#Team_Lead)  review is complete and I approve this request. Please submit your DAO proposal and paste the transaction ID here as a comment when complete, thanks.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/933#issuecomment-950190962
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211023/cd94b136/attachment-0001.htm>

From notifications at github.com  Sat Oct 23 20:09:09 2021
From: notifications at github.com (leo816)
Date: Sat, 23 Oct 2021 11:09:09 -0700
Subject: [bisq-network/compensation] For Cycle 29 (Issue #934)
In-Reply-To: <bisq-network/compensation/issues/934@github.com>
References: <bisq-network/compensation/issues/934@github.com>
Message-ID: <bisq-network/compensation/issues/934/950190986@github.com>

My [Team Lead](https://bisq.wiki/Compensation#Team_Lead)  review is complete and I approve this request. Please submit your DAO proposal and paste the transaction ID here as a comment when complete, thanks.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/934#issuecomment-950190986
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211023/5339665c/attachment.htm>

From notifications at github.com  Sat Oct 23 20:20:02 2021
From: notifications at github.com (leo816)
Date: Sat, 23 Oct 2021 11:20:02 -0700
Subject: [bisq-network/compensation] For Cycle 29 (Issue #935)
Message-ID: <bisq-network/compensation/issues/935@github.com>

<!--
Compensation requests have a specific format that enables them to be evaluated by a bot for more efficient budgeting. Please make sure you stick to the template. A linter will evaluate your request after you remove [WIP] from the issue title and notify you of any issues.

See the following link for details:
https://bisq.wiki/Making_a_compensation_request

Feel free to browse other requests if you're not sure about something, or reach out in #compensation on Keybase (https://keybase.io/team/bisq).
-->


## Summary

> _Specify the total amount of BSQ you are requesting, along with the USD total and BSQ/USD rate (don't include the brackets!):_

- **BSQ requested**: **`[967.74]`** <!-- [BSQ amount] should be: USD amount / BSQ rate -->
- USD requested: [1500] <!-- [USD amount] should be: total of all contributions listed in "contributions delivered" table below -->
- BSQ rate: [1.55] USD per BSQ <!-- [rate] should be the rate used to determine the BSQ amount above, as specified in the cycle's rate announcement (https://bisq.wiki/Compensation_Maintainer#Announce_BSQ-USD_rate) -->
- Previous compensation request (if applicable): #903  <!-- Link to last compensation request submitted -->


## Contributions delivered

> _Add contributions you have [delivered](https://github.com/bisq-network/proposals/issues/19) and roles you have performed here as new rows in the table below. Role line-items should include an asterisk (*) in the team column._

| Title | Team | USD | Link | Notes |
| --- | --- | --- | --- | --- |
| Mediator |Support | 1000 |  https://github.com/bisq-network/roles/issues/83#issuecomment-923895771 | Cycle 29 |
| Support Agent | Support | 500 |https://github.com/bisq-network/roles/issues/64#issuecomment-923898966 | Cycle 28 |
| Fee Reimbursement Agent | Support |   | https://github.com/bisq-network/roles/issues/76#issuecomment-860212316 | Cycle 26 |
| Support Team Lead | Support | |https://github.com/bisq-network/roles/issues/102#issuecomment-923915785|Cycle 28  |
<!-- 

Each contribution should be a new line-item in the table above. 

Title - optional, string.
Team - optional, must one of the following: admin, dev, growth, ops, support (case-insensitive). If the line-item is for a role, please add a `*`. See Example 2 below.
USD - optional, number. Please do not specify 'USD', as the column title makes units clear.
Link - optional, string.
Notes - optional, string.

Example 1 - typical contribution:

| Add local Bitcoin node configuration detection | dev | 240 | https://github.com/bisq-network/bisq/pull/3982

Example 2 - role (note the asterisk):

| Community manager | growth* | 400 | https://github.com/bisq-network/roles/issues/95#issuecomment-628431613

Example 3 - list of minor contributions, such as reviews:

| | | | https://github.com/bisq-network/bisq/pull/3968 | This and PRs below too small to be valued separately. See total at bottom.
| | | | https://github.com/bisq-network/bisq/pull/4040
| | | | https://github.com/bisq-network/bisq/pull/4044
| | | | https://github.com/bisq-network/bisq/pull/4048
| | | | https://github.com/bisq-network/bisq/pull/4066
| | dev | 400 | https://github.com/bisq-network/bisq/pull/4062 | Total for items above.

-->


## Contributions in progress

> _Provide links to work you're involved with that is still [in progress](https://github.com/bisq-network/proposals/issues/19). **This section is optional (the linter ignores it),** and is for your own benefit in keeping track of what you're doing and keeping other contributors up to date with the same._

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/935
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211023/cec0a2ae/attachment.htm>

From notifications at github.com  Sat Oct 23 20:48:02 2021
From: notifications at github.com (Peter at Clearwater-Trust.com)
Date: Sat, 23 Oct 2021 11:48:02 -0700
Subject: [bisq-network/growth] Creating a German-only Bisq account on
 Twitter to reach the growing German-speaking audience (#249)
In-Reply-To: <bisq-network/growth/issues/249@github.com>
References: <bisq-network/growth/issues/249@github.com>
Message-ID: <bisq-network/growth/issues/249/950196154@github.com>

@m52go - remove face mask. Maybe Dorsey has a cancel and ban position for you at twshitter garbage service. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/growth/issues/249#issuecomment-950196154
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211023/923d282e/attachment.htm>

From notifications at github.com  Sat Oct 23 21:08:42 2021
From: notifications at github.com (m52go)
Date: Sat, 23 Oct 2021 12:08:42 -0700
Subject: [bisq-network/growth] Creating a German-only Bisq account on
 Twitter to reach the growing German-speaking audience (#249)
In-Reply-To: <bisq-network/growth/issues/249@github.com>
References: <bisq-network/growth/issues/249@github.com>
Message-ID: <bisq-network/growth/issues/249/950198928@github.com>

Another core contributor sent me the link so I'm not the only one with concerns. Maybe the same thing could have been done in a different way, e.g. emphasize "50% off trading fees" instead of "BSQ giveaway". Not sure.

@stopfeds if there's any way to survey your new followers to see what their experience is and/or what they're trading, etc., that could be helpful. In my opinion, attracting just a few repeat users would be way more preferable to attracting 50 one-time users looking to flip an airdrop for a few sats.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/growth/issues/249#issuecomment-950198928
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211023/149564a9/attachment.htm>

From notifications at github.com  Sat Oct 23 21:22:06 2021
From: notifications at github.com (chimp1984)
Date: Sat, 23 Oct 2021 12:22:06 -0700
Subject: [bisq-network/bisq] Bsq swap: Implementation [3] (PR #5775)
In-Reply-To: <bisq-network/bisq/pull/5775@github.com>
References: <bisq-network/bisq/pull/5775@github.com>
Message-ID: <bisq-network/bisq/pull/5775/push/8222125726@github.com>

@chimp1984 pushed 4 commits.

0662fa783c2cfa59f475c152bca76704021dd6aa  Use checkNotNull and checkArgument for checking pre conditions
7c389e312dc1bcd0a2de1d1d67b4ff7ef602e5f2  Add requestPersistence call.
ecdda101ad19ce0e258a5e49a8cdaa8d4ed4fc1f  Improve naming, comments, extract variables
b9756dec2053a978886cccf276448370c2df613d  Improve naming, comments, extract variables, inline method


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/bisq-network/bisq/pull/5775/files/904fa07eae7967be32a6eb635af7651ff5030754..b9756dec2053a978886cccf276448370c2df613d
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211023/02a6f92b/attachment-0001.htm>

From notifications at github.com  Sat Oct 23 21:38:26 2021
From: notifications at github.com (chimp1984)
Date: Sat, 23 Oct 2021 12:38:26 -0700
Subject: [bisq-network/bisq] Bsq swap: Implementation [3] (PR #5775)
In-Reply-To: <bisq-network/bisq/pull/5775@github.com>
References: <bisq-network/bisq/pull/5775@github.com>
Message-ID: <bisq-network/bisq/pull/5775/push/8222171519@github.com>

@chimp1984 pushed 2 commits.

b92044b201b20e8eb5b144f97a4e6a5c78462586  Remove redundant complete call
89e7b64c062791146afdb3296ebcf99c4f385cf0  Improve naming, cleanups, use static imports


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/bisq-network/bisq/pull/5775/files/b9756dec2053a978886cccf276448370c2df613d..89e7b64c062791146afdb3296ebcf99c4f385cf0
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211023/17b47dbc/attachment.htm>

From notifications at github.com  Sat Oct 23 22:03:50 2021
From: notifications at github.com (chimp1984)
Date: Sat, 23 Oct 2021 13:03:50 -0700
Subject: [bisq-network/bisq] Bsq swap: Implementation [3] (PR #5775)
In-Reply-To: <bisq-network/bisq/pull/5775@github.com>
References: <bisq-network/bisq/pull/5775@github.com>
Message-ID: <bisq-network/bisq/pull/5775/push/8222240698@github.com>

@chimp1984 pushed 1 commit.

d30c943ae848731c6ca1d901a4eb80af7d567658  Fix linebreak


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/bisq-network/bisq/pull/5775/files/89e7b64c062791146afdb3296ebcf99c4f385cf0..d30c943ae848731c6ca1d901a4eb80af7d567658
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211023/632dd4a6/attachment.htm>

From notifications at github.com  Sat Oct 23 22:21:20 2021
From: notifications at github.com (Chris Beams)
Date: Sat, 23 Oct 2021 13:21:20 -0700
Subject: [bisq-network/compensation] For Cycle 29 (Issue #935)
In-Reply-To: <bisq-network/compensation/issues/935@github.com>
References: <bisq-network/compensation/issues/935@github.com>
Message-ID: <bisq-network/compensation/issues/935/950207900@github.com>

Not sure I understand, @leo816, why the Notes above mention different cycles. Can you clarify?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/935#issuecomment-950207900
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211023/18ae3172/attachment.htm>

From notifications at github.com  Sat Oct 23 22:30:56 2021
From: notifications at github.com (chimp1984)
Date: Sat, 23 Oct 2021 13:30:56 -0700
Subject: [bisq-network/bisq] Still v2 addresses used in BitcoinJ? (Issue #5778)
Message-ID: <bisq-network/bisq/issues/5778@github.com>

I see that error in the logs:

`[BlockingClient network thread for wizbit5555bsslwv4ctronnsgk5vh2w2pdx7v7eyuivlyuoteejk7lid.onion:8333] WARN  org.bitcoinj.core.Peer: Peer{[wizbit5555bsslwv4ctronnsgk5vh2w2pdx7v7eyuivlyuoteejk7lid.onion]:8333, version=70016, subVer=/Satoshi:0.20.99(@wiz)/, services=1037 (NETWORK, BLOOM, WITNESS, NETWORK_LIMITED), time=2021-10-23 22:28:21, height=706355}: Received unhandled message: org.bitcoinj.core.SendAddrV2Message at 2f5d3a99 `

Looks like there is still usage of v2 addresses?
@ripcurlx any idea? 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5778
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211023/81c06093/attachment.htm>

From notifications at github.com  Sat Oct 23 22:37:50 2021
From: notifications at github.com (pazza)
Date: Sat, 23 Oct 2021 13:37:50 -0700
Subject: [bisq-network/bisq] Allow 1 sat/vbyte fee (#5633)
In-Reply-To: <bisq-network/bisq/issues/5633@github.com>
References: <bisq-network/bisq/issues/5633@github.com>
Message-ID: <bisq-network/bisq/issues/5633/950211964@github.com>

@kilrau and @lichuan please see the proposal here if you would like to add your comments: https://github.com/bisq-network/proposals/issues/343

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5633#issuecomment-950211964
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211023/c07e2ac7/attachment.htm>

From notifications at github.com  Sun Oct 24 01:25:07 2021
From: notifications at github.com (chimp1984)
Date: Sat, 23 Oct 2021 16:25:07 -0700
Subject: [bisq-network/bisq] Deactivate DAO state monitoring as it is too slow
 (Issue #5779)
Message-ID: <bisq-network/bisq/issues/5779@github.com>

The DAO state monitoring is creating after each block a hash from the DAO state (excluding the blocks) + the latest block (as that contains a hash to the prev. block that is enough to ensure the whole chain is correct).
Some data like the spentInfoMap is already pretty large (about 80k entries) and serializing the data to a bytearray via protobuf serialisation and hashing it takes quite some time. This is the reason why parsing of even empty blocks takes about 100-200 ms. We could optimize a bit by serializing a big part of the data only if there have been actual changes (if no tx was added there is usually no change beside the blockheight and an empty block added), but that would only reduce the required time by about 50 ms. As we still need to add the block height and the latest block all the rest needs to be redone still (hashing, concatenating with prev hash,...).

So I do not see a good solution how to fix that, specially of we do not want to break the hash compatibility (if redesigning dao state hash creation some optimisations might help a bit, but I doubt it will be much better).

It takes about 10-15 min for syncing for a user who downloads the app after a 1 months release (about 4000 blocks). This is a pretty bad user experience.

When deactivating the monitoring it takes about 4 seconds to parse 4000 blocks!

I would recommend that we add a flag to the preferences and disable dao state monitoring by default, and let users choose to enable it if wanted. For users who are regularily online the parsing costs are not critical, but for new users or users who have not used the app since a while its a real problem IMO.

The DAO state is anyway an area which will require some larger refactoring to not cause more scaling issues. In such a process the monitoring could be redesigned as well. Not an easy task though....

Any input/feedback?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5779
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211023/348952ef/attachment-0001.htm>

From notifications at github.com  Sun Oct 24 08:06:29 2021
From: notifications at github.com (Christoph Atteneder)
Date: Sat, 23 Oct 2021 23:06:29 -0700
Subject: [bisq-network/compensation] For Cycle 29 (Issue #931)
In-Reply-To: <bisq-network/compensation/issues/931@github.com>
References: <bisq-network/compensation/issues/931@github.com>
Message-ID: <bisq-network/compensation/issues/931/950266665@github.com>

Unfortunately I was travelling and afk the last three days, so I missed the deadline to submit my CR to the DAO. I'll re-submit it in the next cycle.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/931#issuecomment-950266665
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211023/21501554/attachment.htm>

From notifications at github.com  Sun Oct 24 10:19:39 2021
From: notifications at github.com (Chris Beams)
Date: Sun, 24 Oct 2021 01:19:39 -0700
Subject: [bisq-network/growth] Compensation bot update - handle the nobot
 label (PR #252)
In-Reply-To: <bisq-network/growth/pull/252@github.com>
References: <bisq-network/growth/pull/252@github.com>
Message-ID: <bisq-network/growth/pull/252/c950282006@github.com>

Nice! Thanks, @jmacxx 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/growth/pull/252#issuecomment-950282006
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211024/b4b507a7/attachment.htm>

From notifications at github.com  Sun Oct 24 10:40:13 2021
From: notifications at github.com (Chris Beams)
Date: Sun, 24 Oct 2021 01:40:13 -0700
Subject: [bisq-network/roles] Comptroller (Issue #111)
In-Reply-To: <bisq-network/roles/issues/111@github.com>
References: <bisq-network/roles/issues/111@github.com>
Message-ID: <bisq-network/roles/issues/111/950284730@github.com>

> I have made the above changes and added a few heading to try and make things clearer.
The [updated report](https://github.com/bisq-network/roles/issues/111#issuecomment-945342800) looks great now, IMO. Really gives the at-a-glance overview I think we're all wanting. Will be great to see the trendlines in the reported numbers over time. Thanks!

Here are a few tweaks I'd suggest to tighten up the presentation:

## Before

|  August 2021 | USD | BTC | BSQ |
| ------------- | ------------- | ------------- | ------------- |
| **Trade volume** |  |  |  |
| Trade volume  | $6,527,571  | **143.0199 BTC**  | 4,157,688 BSQ |
| **Revenue** |  |  |  |
| Total revenue fees  | $43,658 | 0.9671348 BTC | 28,115.28 BSQ |
| - Trade revenue fees from BSQ | $8,562 | 0.18759448 BTC | **5,461.81 BSQ** |
| - Trade revenue fees from BTC  | $35,096 | **0.76895773 BTC** | 22,354.14 BSQ |
| - Arbitration fees  | $483 | **0.01058259 BTC** | 307.64 BSQ |
| **Expenses** |  |  |  |
| Contributor costs  | $17,351 | 0.38015315 BTC | **11,051.32 BSQ** |
| **P&L** |  |  |  |
| Net Profit (Loss)  | $26,790 | 0.58697158 BTC | 17,063.69 BSQ |

## After

|  August 2021 | USD | BTC | BSQ |
| ------------- | ------------- | ------------- | ------------- |
| **Volume**  | 6,527,571  | **143.0199**  | 4,157,688 |
| **Revenue**  | 43,658 | 0.9671348 | 28,115.28 |
| - BSQ trading fees | 8,562 | 0.18759448 | **5,461.81** |
| - BTC trading fees  | 35,096 | **0.76895773** | 22,354.14 |
| - Arbitration fees  | 483 | **0.01058259** | 307.64 |
| **Compensation**  | (17,351) | (0.38015315) | **(11,051.32)** |
| **Net Profit (Loss)**  | 26,790 | 0.58697158 | 17,063.69 |



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/roles/issues/111#issuecomment-950284730
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211024/ac0b8400/attachment.htm>

From notifications at github.com  Sun Oct 24 13:15:20 2021
From: notifications at github.com (MwithM)
Date: Sun, 24 Oct 2021 04:15:20 -0700
Subject: [bisq-network/compensation] For Cycle 29 (Issue #931)
In-Reply-To: <bisq-network/compensation/issues/931@github.com>
References: <bisq-network/compensation/issues/931@github.com>
Message-ID: <bisq-network/compensation/issues/931/950305418@github.com>

Closed as not submitted.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/931#issuecomment-950305418
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211024/05c52b11/attachment.htm>

From notifications at github.com  Sun Oct 24 13:15:20 2021
From: notifications at github.com (MwithM)
Date: Sun, 24 Oct 2021 04:15:20 -0700
Subject: [bisq-network/compensation] For Cycle 29 (Issue #931)
In-Reply-To: <bisq-network/compensation/issues/931@github.com>
References: <bisq-network/compensation/issues/931@github.com>
Message-ID: <bisq-network/compensation/issue/931/issue_event/5509392233@github.com>

Closed #931.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/931#event-5509392233
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211024/65de890e/attachment.htm>

From notifications at github.com  Sun Oct 24 14:46:48 2021
From: notifications at github.com (pazza)
Date: Sun, 24 Oct 2021 05:46:48 -0700
Subject: [bisq-network/roles] Comptroller (Issue #111)
In-Reply-To: <bisq-network/roles/issues/111@github.com>
References: <bisq-network/roles/issues/111@github.com>
Message-ID: <bisq-network/roles/issues/111/950319460@github.com>

Thanks, I will use your example as the template for the reports. I have used the template to update the role summary and August's report.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/roles/issues/111#issuecomment-950319460
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211024/981548c5/attachment.htm>

From notifications at github.com  Sun Oct 24 17:28:39 2021
From: notifications at github.com (m52go)
Date: Sun, 24 Oct 2021 08:28:39 -0700
Subject: [bisq-network/growth] Compensation bot update - handle the nobot
 label (PR #252)
In-Reply-To: <bisq-network/growth/pull/252@github.com>
References: <bisq-network/growth/pull/252@github.com>
Message-ID: <bisq-network/growth/pull/252/c950344791@github.com>

I'm not sure how I can test this myself, but I assume @jmacxx has already done necessary diligence. Will merge tomorrow if there isn't any further feedback.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/growth/pull/252#issuecomment-950344791
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211024/473dd545/attachment.htm>

From notifications at github.com  Sun Oct 24 23:00:13 2021
From: notifications at github.com (frrckfrr)
Date: Sun, 24 Oct 2021 14:00:13 -0700
Subject: [bisq-network/support] Fee reimbursement for trade 46190 (#531)
In-Reply-To: <bisq-network/support/issues/531@github.com>
References: <bisq-network/support/issues/531@github.com>
Message-ID: <bisq-network/support/issues/531/950394225@github.com>

@leo816 hello, can you please provide a more concrete timeline for the reimbursement? I still haven?t received the funds. Thanks

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/support/issues/531#issuecomment-950394225
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211024/4d061f86/attachment.htm>

From notifications at github.com  Sun Oct 24 23:15:22 2021
From: notifications at github.com (pazza)
Date: Sun, 24 Oct 2021 14:15:22 -0700
Subject: [bisq-network/support] Fee reimbursement for trade M2XnyDcw
 (#1012)
In-Reply-To: <bisq-network/support/issues/1012@github.com>
References: <bisq-network/support/issues/1012@github.com>
Message-ID: <bisq-network/support/issues/1012/950396265@github.com>

Hi @davidceloud 

Thanks for posting.

As you were the maker of this offer and the trade failed to create a deposit transaction you will not have lost any fees.

Your offer will still be available for others to take.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/support/issues/1012#issuecomment-950396265
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211024/61b85571/attachment.htm>

From notifications at github.com  Sun Oct 24 23:18:31 2021
From: notifications at github.com (pazza)
Date: Sun, 24 Oct 2021 14:18:31 -0700
Subject: [bisq-network/bisq] Bisq SPV download stuck at %57 (#5707)
In-Reply-To: <bisq-network/bisq/issues/5707@github.com>
References: <bisq-network/bisq/issues/5707@github.com>
Message-ID: <bisq-network/bisq/issues/5707/950396634@github.com>

Hi @BENDYMAN20 any updates to this issue?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5707#issuecomment-950396634
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211024/84f2f40b/attachment-0001.htm>

From notifications at github.com  Sun Oct 24 23:20:36 2021
From: notifications at github.com (pazza)
Date: Sun, 24 Oct 2021 14:20:36 -0700
Subject: [bisq-network/bisq] Some BTC addresses utilized by Bisq are
 receiving both trade fees and time-locked deposits (Issue #5762)
In-Reply-To: <bisq-network/bisq/issues/5762@github.com>
References: <bisq-network/bisq/issues/5762@github.com>
Message-ID: <bisq-network/bisq/issues/5762/950396939@github.com>

Many thanks for sorting, will try and import the transactions into a spreadsheet, will close this issue.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5762#issuecomment-950396939
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211024/50df17c3/attachment.htm>

From notifications at github.com  Sun Oct 24 23:20:37 2021
From: notifications at github.com (pazza)
Date: Sun, 24 Oct 2021 14:20:37 -0700
Subject: [bisq-network/bisq] Some BTC addresses utilized by Bisq are
 receiving both trade fees and time-locked deposits (Issue #5762)
In-Reply-To: <bisq-network/bisq/issues/5762@github.com>
References: <bisq-network/bisq/issues/5762@github.com>
Message-ID: <bisq-network/bisq/issue/5762/issue_event/5510017047@github.com>

Closed #5762.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5762#event-5510017047
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211024/365202dc/attachment.htm>

From notifications at github.com  Sun Oct 24 23:24:35 2021
From: notifications at github.com (chimp1984)
Date: Sun, 24 Oct 2021 14:24:35 -0700
Subject: [bisq-network/bisq] Bsq swap: Implementation [3] (PR #5775)
In-Reply-To: <bisq-network/bisq/pull/5775@github.com>
References: <bisq-network/bisq/pull/5775@github.com>
Message-ID: <bisq-network/bisq/pull/5775/push/8226250121@github.com>

@chimp1984 pushed 3 commits.

77b8ae778f231d48992623f5fd22dc9e2a8bbc1b  Combine nested if statements
363e0a2a7fca30731b240da4193a5f9d8a4b7190  Revert behaviour to old version in master to return null if amount is null.
1e7de9e8b75aead8c2d6cc6b87b69a84b3a193cb  Cleanups


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/bisq-network/bisq/pull/5775/files/d30c943ae848731c6ca1d901a4eb80af7d567658..1e7de9e8b75aead8c2d6cc6b87b69a84b3a193cb
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211024/de356d83/attachment.htm>

From notifications at github.com  Mon Oct 25 01:34:46 2021
From: notifications at github.com (chimp1984)
Date: Sun, 24 Oct 2021 16:34:46 -0700
Subject: [bisq-network/bisq] Optimize dao monitor (PR #5780)
Message-ID: <bisq-network/bisq/pull/5780@github.com>

Based on https://github.com/bisq-network/bisq/pull/5775

Fixes https://github.com/bisq-network/bisq/issues/5779
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/5780

-- Commit Summary --

  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/8fbccb75479ffcb1e7b1fcc0feed03aa7fc55735">Bump version number for v1.7.5</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/e39ae59683f6c45fd741063a364d7ae8366d43c9">Update translations for v1.7.5</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/48a0ebe30973915fd80ff778a131d33a8012a616">Add new v3 onions for wiz&#39;s bitcoin nodes</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/577b07ba9a9b50fdb76d9cdb2d675781c17eed53">Move OfferPayload into package bisq.core.offer.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/19f813eea3b0ed753e8bc90754585e1a4f0344c0">Move CreateOfferService into package bisq.core.offer.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/d98cb278057e27907ba894f696732026a5ba4820">Move MarketPriceNotAvailableException into package bisq.core.offer.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/346fc79094cc0941b2ede33edb3d8d778b81c1a5">Move MutableOfferPayloadFields into package bisq.core.offer.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/8a4c05c1e48b9fd81640456defecc8d472cb8f6c">Move TriggerPriceService into package bisq.core.offer.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/ade5d322374f455a54dd48e9e82e754e9e596b5f">Move TakeOfferModel into package bisq.core.offer.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/20d298061d8c4213bd46f62eedf623f610654288">Move AvailabilityResult into package bisq.core.offer.availability</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/0107519f4307aa594b1a695515d0b31eab39da6c">Move bisq.core.offer.messages package into package bisq.core.offer.availability</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/ed9f248c277afb23464860913119835f79e6395e">Move content of bisq.core.offer.placeoffer package into package bisq.core.offer.placeoffer.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/b584fdf419b031818016505596aa6b899e492972">Rename OfferFilter to OfferFilterService</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/0e23cbe24e63b2a7e792bd496db510ea028e4388">Move Contract, SellerAsMakerTrade, SellerAsTakerTrade, SellerTrade,</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/c0cca781de5646ccf7836341f15ae65e7c30b6e6">Make updateDepositTxFromWallet public</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/0f7cfa99d51d87f378d994c75ef9ec3c8303619c">Move Trade to bisq.core.trade.model.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/5944218a4bb31d914f08b96560f0b1fb3aad61b1">Move MakerTrade and TakerTrade to bisq.core.trade.model package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/5a0145d1d94b31c916f6dca30fbdaa4b60dd67e1">Move Tradable to bisq.core.trade.model package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/81ec06d0dcf397a224fbc950be2fd67ea3f7fb1e">Move TradableList to bisq.core.trade.model package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/2489bbc119db6095abef7a7c659cd851b8ad0509">Make FluentProtocol.Event public</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/c0d13083c8c64ea486a1013059d3a5e1d4fca32e">Make setup in FluentProtocol public</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/87c12fda8c9d95cac288235dd9655ba707ac3391">Move protocol classes to bisq.core.trade.protocol.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/babd70cc2a8230ba72cf8ed205ec326ef2d24969">Move tasks package into bisq.core.trade.protocol.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/5099d974353f424af82d611b416e64e23d123202">Move TradingPeer into bisq.core.trade.protocol.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/a212cec19c9bb32d9bd781e9ac33d75c552fa4a9">Move messages package into bisq.core.trade.protocol.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/c9817ed6dbb1709077b46d07da50566b3a3545ca">Move ClosedTradableManager, FailedTradesManager into bisq.core.trade.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/1b74b4efe9bb3907c0d9dfdf0b482c4cad8b24af">Rename CleanupMailboxMessages to CleanupMailboxMessagesService</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/2141f8f665dab4933022f38d1a2c6b1e42e51d84">Move CleanupMailboxMessagesService, ClosedTradeUtil to package bisq.core.trade.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/f871e8339d294334f46b42ee41572d6c54177a80">Move TransactionResultHandler, TradeResultHandler to package bisq.core.trade.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/71c663eb5306a6e7cbd05d55e95f984eaddd95ec">Move TradeDataValidation, DumpDelayedPayoutTx, TradeDataValidation, TradeUtil, TradeTxException to package bisq.core.trade.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/26e2676268f409aa12d9d9e5a814c587c4a8a01b">Rename ProcessModelServiceProvider to Provider</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/c282b700010479b5c67f978eb434b5d41529f669">Rename txID to txId</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/30dd5683ef08083949252f4924065389f4a4bc15">Move createoffer package inside bisq.desktop.main.offer.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/0cd0e16b53870ff663c357e9e78adf92be157dbc">Move takeoffer package inside bisq.desktop.main.offer.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/4169a8719bf8984e6e1afd8fe67eca987682e807">Move MutableOffer view classes into bisq.desktop.main.offer.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/a2a7e87af5ef944f17dbdc2e0a531a20fd7a854e">Move OfferDataModel, OfferViewUtil into bisq.desktop.main.offer.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/a9f4bb76b687f724db84b37f69603b9289a5ea6a">Rename FeeUtil to OfferViewModelUtil</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/1e03aae2ac81ada51fc8a319b83be5209a1684c7">Move OfferViewModelUtil into bisq.desktop.main.offer.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/72284d7d9f7c25236010a88389e88c218012248d">Cleanups, refromatting, add final qualifier</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/71eec7b2e0c98b8b036d4ab3fa52cc4701e0fc30">Move TradingPeer to package bisq.core.trade.protocol.bisq_v1.model</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/e1efc5e96fc6909e28446876c36393cc3e80a4e4">Make setPaymentStartedAckMessage and setDepositTxSentAckMessage public</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/760732f03a2cff68590935bd92f63ac81793f823">Move ProcessModel to package bisq.core.trade.protocol.bisq_v1.model</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/94d3638d9841c8653a5db40fa5b1c52fa3e3b0e4">Remove m52go bitcoin node</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/41d9d3f505516ed34c1f33d86952ef8f4d036d75">Move OfferPayload into package bisq.core.offer.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/edf5c3e097094f35e4f25c439416cff196afbf76">Move CreateOfferService into package bisq.core.offer.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/4341a7e0d2c5610baa95b09bdb82584b520bc776">Move MarketPriceNotAvailableException into package bisq.core.offer.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/042476a68a22ea95eb9faaa84eeed8594a6c3d06">Move MutableOfferPayloadFields into package bisq.core.offer.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/d9fd8a45f72d377e2ba04c95df1974aa44e36b87">Move TriggerPriceService into package bisq.core.offer.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/e348000cb16923ab1b973ad9aa1bb0d2f616cc16">Move TakeOfferModel into package bisq.core.offer.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/a2d1e8888d0c6274121428b86cdd39b32f3d6ba0">Move AvailabilityResult into package bisq.core.offer.availability</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/1badd699a4a6a82910701a89c5fbad4115985503">Move bisq.core.offer.messages package into package bisq.core.offer.availability</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/7197b316fccd63e2f0b66d27d167ea6cd0452c11">Move content of bisq.core.offer.placeoffer package into package bisq.core.offer.placeoffer.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/1b4c4871c0d03e00dbc07571ac120d2a3a9c534d">Rename OfferFilter to OfferFilterService</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/1e9b6065441d27873ad962920aed363ed9a25aa0">Move Contract, SellerAsMakerTrade, SellerAsTakerTrade, SellerTrade,</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/8b21b85c3e8fd20b8d5c541ee6ad6ee5e099a0c6">Make updateDepositTxFromWallet public</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/d42242762ffb448e8ebdda5e311602e6db60f1c7">Move Trade to bisq.core.trade.model.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/fc3177c23f06d16eed25408fe7064f5364b2e42f">Move MakerTrade and TakerTrade to bisq.core.trade.model package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/58cfcffeb970ffc81d9ba6979eb256892ce00ff2">Move Tradable to bisq.core.trade.model package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/3474a2b69520d52af239c79cbaa65135bdc776d5">Move TradableList to bisq.core.trade.model package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/d7b2e99e43a404c6121dcbb94a0acaf028037dbe">Make FluentProtocol.Event public</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/e3eea6350cb07f3c517e0fc148b4d771fff26afc">Make setup in FluentProtocol public</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/1b2e798faaa64fa19a3cd858c99c6af22d38fa99">Move protocol classes to bisq.core.trade.protocol.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/508296c2a3b609ab9166d250226271622f430d34">Move tasks package into bisq.core.trade.protocol.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/97906e05db34277a96631c4e4eeaef91dd732f04">Move TradingPeer into bisq.core.trade.protocol.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/cbf2822cdf422cfca7404a0cb4486f498bc8a171">Move messages package into bisq.core.trade.protocol.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/fd6934c4e3f1fd93744343bc7c1f907b7e981f8c">Move ClosedTradableManager, FailedTradesManager into bisq.core.trade.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/fe2871baa50c5f196e92458d38bdda53ab9b6d77">Rename CleanupMailboxMessages to CleanupMailboxMessagesService</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/e80cdf8ac7217ab0e2025be10e0feaa6dc8a5ee6">Move CleanupMailboxMessagesService, ClosedTradeUtil to package bisq.core.trade.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/956ffc902d2258199a07f96adaa91ff98ae2411a">Move TransactionResultHandler, TradeResultHandler to package bisq.core.trade.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/eacf446ab422352bb303eb9830b3dc03d9adc8e4">Move TradeDataValidation, DumpDelayedPayoutTx, TradeDataValidation, TradeUtil, TradeTxException to package bisq.core.trade.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/e1de502a9bf1aae7e87830096934ac6a1684665d">Rename ProcessModelServiceProvider to Provider</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/2733af955a3ec04d4311a18b691415933146b35c">Rename txID to txId</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/932c0f856aa36ee87cb55dbb3b4e11992ed2b13c">Move createoffer package inside bisq.desktop.main.offer.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/0efa0bd7cad6278faac96edc64f4008061a7998f">Move takeoffer package inside bisq.desktop.main.offer.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/601956dc1fe2927549ff7723ef8cd25f16f646ee">Move MutableOffer view classes into bisq.desktop.main.offer.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/9777005ec7e44b4efb123e7d5a9c48976bde2a81">Move OfferDataModel, OfferViewUtil into bisq.desktop.main.offer.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/4a9db790682506fdda88f6d31f5874fc473dba2e">Rename FeeUtil to OfferViewModelUtil</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/25bbad1f9c9f5383d8af6f64cbacdb74df2b1d01">Move OfferViewModelUtil into bisq.desktop.main.offer.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/777287af95cfd791389b0cdbf9eecf9b98913496">Cleanups, refromatting, add final qualifier</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/401880b64e8f8645e42d6a34179fcc71000c7363">Move TradingPeer to package bisq.core.trade.protocol.bisq_v1.model</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/afed78813d3d81c1ca4d63adac6ca0d5cffb1741">Make setPaymentStartedAckMessage and setDepositTxSentAckMessage public</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/734d429cc9612709bcee8c0e4784070406daf731">Move ProcessModel to package bisq.core.trade.protocol.bisq_v1.model</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/dca0c93f477f66da22f6eeba2532fffb844dde90">Cleanups</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/e75296557739f6b8ae86bd3004781fd268036a9e">Add linebreak in error popup</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/9f3034e91c83559c5a37b7c235c0c997a0e84042">Fix layout/text issues</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/dc82fbabab24ab385b085afdfe0ef88c62849970">Increase visibility</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/8768345b74148ab49f57cefef9952bb2ad5667be">Remove Inject annotation at abstract classes</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/d1d1706a7f05539b930db6437f20b6934576515e">Add delegate methods to offer</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/dfbc746d5b4dc3fd4c115adb34498089e744918d">Move Offer.Direction one level up and rename to OfferDirection</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/6cf0a7c126fb2bf43ca004bb139b5b856ad1d67e">Rename paymentMethod.isAsset to paymentMethod.isBlockchain</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/dad19ba1c174087e3f29f66577739409e32bc544">Add isFiat and isAltcoin methods.</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/88198be7ffbfe00854207e3f9e6e907ffd7581b2">Rename availableConfirmedBalance to availableBalance</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/d4bb026e3e7ce64710a947557962e0f4e32bfc26">Only check for localhost btc node if mainnet</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/f8751a8c4d5974068864f90729c889411f86ae73">Make TxConfidenceListener and its onTransactionConfidenceChanged method abstract</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/a927bea71f236769af7d5c3bba37488fd58370ec">Add scriptTypeId to RawTransactionInput</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/75072ebc26acef94bfe15eba5eaa3c152c63a416">Add deprecated annotation, null checks and comment to getRawInputFromTransactionInput</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/561ebe940e369aaa54668fa50751c154cc047764">Move test classes into bisq.desktop.main.offer.bisq_v1.createoffer</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/8ee255412fe1fe5ea023654614d99f05837afed5">Merge branch &#39;bsq-swap-low-risk-refactorings&#39; into wip-merge2</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/559bc58ec23b942b0b90a2325800d40e5302af90">Fix merge issues</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/34c4eefb590c0678b3523a70e0673efdba109fea">Add allowSpendMyOwnUnconfirmedTxOutputs flag to BsqCoinSelector</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/47572888e7711f176b6018c9561d8b11447afff1">Add isMine method. Add error logs</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/0f6364d2bd4625619e6dbcce925efb0565db4639">Inline TransactionWitness</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/e582ffddad7db84481b76f6a518fc13c5796cdc2">Add new methods</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/54e81d14731ee57a8ede3e5857e6b4c73f134ce2">Add signTx and verifyNonDustTxo methods</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/5f8bc834f798e94e25a0540a154c33598eb4be76">Remove unused signTx method</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/d95356be211786d67ebd47e27e8801e33f3197e6">Add verifiedBalance field.</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/cfc404b4c0ee8d495c167446e58e88ad152d1407">Rename signTx to signTxAndVerifyNoDustOutputs (no code change)</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/82c1be1d97f57c0bd2b2380125468d80d607bbd7">Change log level</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/c15fc0c0a7a1d33db8a334881d03e9ee1185ce47">Add comment, cleanups</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/d7f1b00221ac07b914cd37302888edb357f5bc71">Rename processModel.getTradingPeer to getTradePeer</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/02d7dfdaefeeaea5aaadf5a85596abb1c500d2cb">Only print stack trace if dev mode</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/9e4be1367a399d6d24fe075409331ff028a004fc">Change log level</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/8d2579866a61508f3c1e5cd7559763006ef941e6">Replace Value annotation with Getter and EqualsAndHashCode</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/d976f11e09db208a9abceca4bb265c18e17713b6">Add methods</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/a3b3d561ecc0685e017e1f498715326de4dee570">Simplify</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/9d106468b04f53fae29b76f80e7d95575a6afb5c">Move getRandomOfferId method to OfferUtil</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/e061d6a476e78b7368ec88952bf27bf2e9a6b0f3">Replace Value with Getter</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/5b0e9ab92fbe8b62ef612e5f8cab27d17a33f2c4">Rename trade.getPhase to getTradePhase</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/544dd895fc279926e11e23565286dff2de0d9dd9">Rename trade.getState to getTradeState</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/12fff5403d9d13045726ee08410fcb2f3d3706f6">Cleanup</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/2440d7234d2d7fc83e772e0a2ff9c52128cd3f6f">Extract methods, Cleanups</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/4cb074694da118b3f62c4e21ea7b92d197e5e1bc">Extract methods, cleanups. Rename methods and vars</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/7211f892e13041979784ebaa2896f45975a2982c">Add exclude fields to EqualsAndHashCode</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/07883e9b8ba1fc5b5f4de146e28c0542c8da21b9">Rename trade.getPhase to getTradePhase</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/0148a36566c554c3c898d8fc8e14ba60d7abd723">Extract to method in TradeUtil</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/10516407de34fc3d07255ec246dac99bce07151a">Use early return. cleanup</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/8219bf84070dab6cb4ce448c94ff26da7b114bc2">Extract method. Rename vars</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/ee374c3c39720e540a79311d48a1d6daa93d8abd">Cleanups, apply rename of getTradePhase</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/e940f6f9f0a06059ec0e003dfbc4a01b775598f4">Add method. Dont return null in case of no amount but min fee</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/19aabba12c701f5aa311dd4d445484d711953ef9">Add method. cleanups</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/1c0b52cd31d27c1bf66f5cf6eb87fc75efb2aaca">Move OfferDirection from bisq.core.offer.bisq_v1 to bisq.core.offer</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/07354191a6bddb4ca5ff3bcee8a51c37ee6a43c5">Remove handling of BundleOfEnvelopes in send method.</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/b80b6ec836d778ef3a1a11e06d2a8f024931d947">Cleanups</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/23af4558b5e624d02a7457d9c217609555b1d641">Add filterPredicate</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/2e384ede59ec232e5b9e390a465eaec51f7f0fff">Make onDeleteAccount more clear</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/9d8c705104f53aefac8018e08cedc7ad35d1515e">Only add delay if not devmode</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/d2851574425c1fe587cdca81399c7b5bb325a463">Reduce visibility</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/8bb42e1421d4c6ee5e14cb91d53ac699e84e08fb">Add methods, move field up</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/1aa5e7053d70f2e25311481a0318698b478e72bf">Add method</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/8ac40a3e0cd34262d302ce5f8c59ac52411ca3c1">Add style</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/c60df6e978866162e16dcef6c6801419a0eacd3c">Add linebreak (no code change)</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/9fb6a6ca9f9666f805ee6bea4882c45df10cfaa1">Add isNotPublished method (will be combined later with bsq swap checks)</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/cfae096c1f14952cebdb56edc909b354c2585e49">Add null checks, extract variables, cleanups</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/2ae1860dac9729c71e03a4649c6f8364fad26a5a">Move tests to package bisq.desktop.main.offer.bisq_v1.createoffer</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/080dc3e8a1cfc17004b4df32811af9fe81c91c54">Merge branch &#39;chimp-bsq-swap&#39; into wip-merge021.10</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/ab6e4e1b8f3fcb7f2f4bc0547980d7fc6724fec9">Dummy commit to enforce rebuild at CI</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/5412f8b669a13a6da70e8f3e365aeb64d56fa3be">Merge branch &#39;chimp-bsq-swap&#39; into bsq-swap-low-risk-refactorings</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/c920da36c08d679de8d1ef47b171e79c5765c2aa">Add abstract classes and interfaces. Let ProcessModel and TradingPeer extend those.</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/8cd85a77c148a7d01de9b41d25832ca0af6f334e">Let Trade extend TradeModel</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/dcd0101c52142dd534fe9bd738d766e3f9b5fd56">Generify TradeResultHandler</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/5d687bd064ab3754ffcf8614b5de982114823baf">Use TradeModel and ProtocolModel in TradeTaskRunner, TradeTask, TradeProtocol and FluentProtocol</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/308bb687c552573cd371c372dea4d93c8f1aa22d">Use TradeModel</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/453229e3708c0e9742b710b87cbdfd30db1425ad">Impl. onAckMessage. Add fields for concrete types</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/c0e70b81ef641801a84ef37188e57e20bcdc1306">Use TradeModel in trade domain</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/d063aff5bfd8bfc3425cccd1b0c5fbdb44ea09e1">Let OfferPayload extend OfferPayloadBase</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/b194960c63644761eb55bc2efa036e3fe7853949">Use TradeModel instead of Trade where appropriate.</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/14765d6caa56fe1460f22c0fa0c7d0002945c860">Move protobuf OfferPayload.Direction to OfferDirection</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/611b9446094ac0389a49b2daccbb7b95784b714e">Move protobuf OfferPayload.Direction to OfferDirection</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/2f40eddae868c6294e44479738ad140222bcb413">Use bitcoinj 42bbae9 (with fix required for bsq swaps)</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/63c385bbba238b468bf675ff592e8db507af153b">Add support for RemoveDataMessage in testCapability</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/54f17b00af64c9aa706c3c39322e4c353b3f296d">Cleanups</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/ebfd1b557412b419b96adb4647547970f713ed30">Remove todo</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/9c5620276ea8ae015ad993379d3f972981edaf81">Add BSQ swap code</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/559491ebd1f22ab5cf1286458ac16978e5ee4606">Merge branch &#39;master_upstream&#39; into chimp-bsq-swap</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/cff719b3e8df4f0d67b77ca08d6b00fdef16c09a">Merge branch &#39;chimp-bsq-swap&#39; into bsq-swap-low-risk-refactorings</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/3558d0171c60a44dc21ed2814d95c85274072655">Merge branch &#39;bsq-swap-low-risk-refactorings&#39; into bsq-swap-impl</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/6d9d0f75732cdae03265574c106b2daa51ab45b5">Apply codacy review suggestions</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/fdfb029b0d038343448605c7c549d65be6a390c2">Move Utilities.objectToJson to JsonUtil.objectToJson</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/4ab1ee3d5865c7ab4d5bf84f48bfef35da080aa2">Add custom json serializer for OfferPayload</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/348bf3bda64ad936ce4f63f4adbc4bb6abae1542">Update text</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/238a7dc1f5d13d091425c5e1fdee990a68a4cc54">Remove missingFundsListener after successful take offer</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/b39396858097dbefd3296aab81675e7978a819e1">Change log level</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/a77d65b4db0f29a663bccbc951f63ea6936fc2b7">Improve BSQ swap offer details window</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/7dfb2617625f595e16e45f3d1abd0c52b329d654">Update dev mode values for create offer</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/c86801fa03aa6e1265bb62460d78084d8a0d8904">Workaround for weird JFXComboBox bug</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/395d93975bbe68f9cbf75f739941f43b22286032">Add default value if no filter is available</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/f970f09798eb13cf92b7e58b8d8022d17b30d7fc">Add log</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/904fa07eae7967be32a6eb635af7651ff5030754">Reset address entry if BSQ swap offer is used for create offer</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/0662fa783c2cfa59f475c152bca76704021dd6aa">Use checkNotNull and checkArgument for checking pre conditions</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/7c389e312dc1bcd0a2de1d1d67b4ff7ef602e5f2">Add requestPersistence call.</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/ecdda101ad19ce0e258a5e49a8cdaa8d4ed4fc1f">Improve naming, comments, extract variables</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/b9756dec2053a978886cccf276448370c2df613d">Improve naming, comments, extract variables, inline method</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/b92044b201b20e8eb5b144f97a4e6a5c78462586">Remove redundant complete call</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/89e7b64c062791146afdb3296ebcf99c4f385cf0">Improve naming, cleanups, use static imports</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/d30c943ae848731c6ca1d901a4eb80af7d567658">Fix linebreak</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/1ef21ac7cd2da174f231e0cb9846540606ea0d1d">Add useDaoMonitor field to PreferencesPayload</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/593bc348240494ad47798465f673b19e7769f4e8">Remove DaoEventCoordinator</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/35be6a1801d673b38298fd12348586c263c289fa">Only call `daoStateMonitoringService.createHashFromBlock(block);`</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/71cc1215f95191eb6d5f98d6f79125a684944adf">If dao state chain is not connecting (e.g. user had deactivated it</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/72184d690b027b98eddcfdecd2b0356ed23d217a">Add toggle to dao monitor view to deactivate monitoring</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/d54d43ff88c03f643386fb32015a389916b20cdc">Add toggle to PreferencesView</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/50d69e15f3ae9d033437bb5f2e7dee0e4aac9176">Fix text</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/85e864acb9c9e24eead0d8e9598592b686428dc7">Fix text handling</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/463722e528009f75ee030b92f8d5eb105a86606d">Set useDaoMonitor in preferences to true for seed nodes.</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5780/commits/b8290a7e255ec18398eb88f782889c10c94b7041">Do not handle state hash messages if not activated</a>

-- File Changes --

    M apitest/scripts/trade-simulation-utils.sh (2)
    M apitest/src/test/java/bisq/apitest/ApiTestCase.java (10)
    M apitest/src/test/java/bisq/apitest/method/offer/AbstractOfferTest.java (10)
    A apitest/src/test/java/bisq/apitest/method/offer/BsqSwapOfferTest.java (172)
    M apitest/src/test/java/bisq/apitest/method/offer/CancelOfferTest.java (2)
    M apitest/src/test/java/bisq/apitest/method/offer/CreateBSQOffersTest.java (4)
    M apitest/src/test/java/bisq/apitest/method/offer/CreateOfferUsingFixedPriceTest.java (4)
    M apitest/src/test/java/bisq/apitest/method/offer/CreateOfferUsingMarketPriceMarginTest.java (4)
    M apitest/src/test/java/bisq/apitest/method/offer/EditOfferTest.java (4)
    M apitest/src/test/java/bisq/apitest/method/offer/ValidateCreateOfferTest.java (2)
    A apitest/src/test/java/bisq/apitest/method/trade/BsqSwapTradeTest.java (163)
    A apitest/src/test/java/bisq/apitest/method/trade/BsqSwapTradeTestLoop.java (65)
    M apitest/src/test/java/bisq/apitest/method/trade/ExpectedProtocolStatus.java (2)
    M apitest/src/test/java/bisq/apitest/method/trade/TakeBuyBSQOfferTest.java (16)
    M apitest/src/test/java/bisq/apitest/method/trade/TakeBuyBTCOfferTest.java (10)
    M apitest/src/test/java/bisq/apitest/method/trade/TakeBuyBTCOfferWithNationalBankAcctTest.java (10)
    M apitest/src/test/java/bisq/apitest/method/trade/TakeSellBSQOfferTest.java (18)
    M apitest/src/test/java/bisq/apitest/method/trade/TakeSellBTCOfferTest.java (12)
    M apitest/src/test/java/bisq/apitest/method/wallet/BsqWalletTest.java (6)
    M apitest/src/test/java/bisq/apitest/method/wallet/WalletTestUtil.java (6)
    M apitest/src/test/java/bisq/apitest/scenario/LongRunningOfferDeactivationTest.java (4)
    M apitest/src/test/java/bisq/apitest/scenario/bot/script/BotScriptGenerator.java (5)
    M build.gradle (4)
    M cli/src/main/java/bisq/cli/DirectionFormat.java (4)
    M cli/src/main/java/bisq/cli/GrpcClient.java (71)
    M cli/src/main/java/bisq/cli/opts/AbstractMethodOptionParser.java (2)
    M cli/src/main/java/bisq/cli/opts/CreateCryptoCurrencyPaymentAcctOptionParser.java (14)
    M cli/src/main/java/bisq/cli/opts/OptLabel.java (1)
    M cli/src/main/java/bisq/cli/request/OffersServiceRequest.java (58)
    M cli/src/main/java/bisq/cli/request/TradesServiceRequest.java (8)
    M common/src/main/java/bisq/common/app/Capability.java (3)
    M common/src/main/java/bisq/common/app/Version.java (2)
    M common/src/main/java/bisq/common/config/ConfigFileEditor.java (2)
    A common/src/main/java/bisq/common/crypto/HashCashService.java (181)
    A common/src/main/java/bisq/common/crypto/ProofOfWork.java (122)
    A common/src/main/java/bisq/common/crypto/ProofOfWorkService.java (156)
    M common/src/main/java/bisq/common/util/Utilities.java (26)
    A common/src/test/java/bisq/common/crypto/HashCashServiceTest.java (84)
    A common/src/test/java/bisq/common/crypto/ProofOfWorkServiceTest.java (81)
    M core/src/main/java/bisq/core/account/witness/AccountAgeWitnessService.java (25)
    M core/src/main/java/bisq/core/account/witness/AccountAgeWitnessUtils.java (2)
    M core/src/main/java/bisq/core/api/CoreApi.java (83)
    M core/src/main/java/bisq/core/api/CoreOffersService.java (132)
    M core/src/main/java/bisq/core/api/CorePaymentAccountsService.java (25)
    M core/src/main/java/bisq/core/api/CoreTradesService.java (50)
    M core/src/main/java/bisq/core/api/CoreWalletsService.java (5)
    M core/src/main/java/bisq/core/api/model/BsqBalanceInfo.java (15)
    A core/src/main/java/bisq/core/api/model/BsqSwapOfferInfo.java (227)
    A core/src/main/java/bisq/core/api/model/BsqSwapTradeInfo.java (323)
    M core/src/main/java/bisq/core/api/model/OfferInfo.java (4)
    M core/src/main/java/bisq/core/api/model/TradeInfo.java (10)
    M core/src/main/java/bisq/core/app/BisqExecutable.java (2)
    M core/src/main/java/bisq/core/app/BisqSetup.java (10)
    M core/src/main/java/bisq/core/app/DomainInitialisation.java (18)
    M core/src/main/java/bisq/core/app/P2PNetworkSetup.java (22)
    M core/src/main/java/bisq/core/app/misc/AppSetupWithP2PAndDAO.java (7)
    M core/src/main/java/bisq/core/app/misc/ExecutableForAppWithP2p.java (2)
    M core/src/main/java/bisq/core/btc/Balances.java (6)
    M core/src/main/java/bisq/core/btc/TxFeeEstimationService.java (8)
    M core/src/main/java/bisq/core/btc/listeners/BsqBalanceListener.java (2)
    M core/src/main/java/bisq/core/btc/listeners/TxConfidenceListener.java (17)
    M core/src/main/java/bisq/core/btc/model/RawTransactionInput.java (79)
    M core/src/main/java/bisq/core/btc/nodes/BtcNodes.java (6)
    M core/src/main/java/bisq/core/btc/wallet/BsqCoinSelector.java (16)
    M core/src/main/java/bisq/core/btc/wallet/BsqTransferService.java (2)
    M core/src/main/java/bisq/core/btc/wallet/BsqWalletService.java (92)
    M core/src/main/java/bisq/core/btc/wallet/BtcWalletService.java (29)
    M core/src/main/java/bisq/core/btc/wallet/TradeWalletService.java (150)
    M core/src/main/java/bisq/core/btc/wallet/WalletService.java (57)
    D core/src/main/java/bisq/core/dao/DaoEventCoordinator.java (69)
    M core/src/main/java/bisq/core/dao/DaoFacade.java (13)
    M core/src/main/java/bisq/core/dao/DaoModule.java (1)
    M core/src/main/java/bisq/core/dao/DaoSetup.java (9)
    M core/src/main/java/bisq/core/dao/governance/asset/AssetService.java (2)
    M core/src/main/java/bisq/core/dao/governance/blindvote/MyBlindVoteListService.java (2)
    M core/src/main/java/bisq/core/dao/governance/bond/lockup/LockupTxService.java (2)
    M core/src/main/java/bisq/core/dao/governance/bond/unlock/UnlockTxService.java (2)
    M core/src/main/java/bisq/core/dao/governance/proofofburn/ProofOfBurnService.java (2)
    M core/src/main/java/bisq/core/dao/governance/proposal/BaseProposalFactory.java (2)
    M core/src/main/java/bisq/core/dao/governance/votereveal/VoteRevealService.java (2)
    M core/src/main/java/bisq/core/dao/monitoring/DaoStateMonitoringService.java (40)
    M core/src/main/java/bisq/core/dao/node/explorer/ExportJsonFilesService.java (7)
    M core/src/main/java/bisq/core/dao/state/DaoStateService.java (12)
    M core/src/main/java/bisq/core/dao/state/DaoStateSnapshotService.java (39)
    M core/src/main/java/bisq/core/dao/state/storage/DaoStateStorageService.java (2)
    M core/src/main/java/bisq/core/filter/Filter.java (44)
    M core/src/main/java/bisq/core/filter/FilterManager.java (28)
    M core/src/main/java/bisq/core/locale/Res.java (6)
    M core/src/main/java/bisq/core/notifications/alerts/TradeEvents.java (2)
    M core/src/main/java/bisq/core/notifications/alerts/market/MarketAlerts.java (6)
    M core/src/main/java/bisq/core/offer/Offer.java (252)
    M core/src/main/java/bisq/core/offer/OfferBookService.java (40)
    A core/src/main/java/bisq/core/offer/OfferDirection.java (33)
    R core/src/main/java/bisq/core/offer/OfferFilterService.java (17)
    M core/src/main/java/bisq/core/offer/OfferForJson.java (8)
    A core/src/main/java/bisq/core/offer/OfferPayloadBase.java (147)
    M core/src/main/java/bisq/core/offer/OfferRestrictions.java (4)
    M core/src/main/java/bisq/core/offer/OfferUtil.java (124)
    M core/src/main/java/bisq/core/offer/OpenOffer.java (43)
    M core/src/main/java/bisq/core/offer/OpenOfferManager.java (277)
    R core/src/main/java/bisq/core/offer/availability/AvailabilityResult.java (2)
    M core/src/main/java/bisq/core/offer/availability/OfferAvailabilityModel.java (2)
    M core/src/main/java/bisq/core/offer/availability/OfferAvailabilityProtocol.java (4)
    R core/src/main/java/bisq/core/offer/availability/messages/OfferAvailabilityRequest.java (6)
    R core/src/main/java/bisq/core/offer/availability/messages/OfferAvailabilityResponse.java (8)
    R core/src/main/java/bisq/core/offer/availability/messages/OfferMessage.java (2)
    M core/src/main/java/bisq/core/offer/availability/tasks/ProcessOfferAvailabilityResponse.java (4)
    M core/src/main/java/bisq/core/offer/availability/tasks/SendOfferAvailabilityRequest.java (2)
    R core/src/main/java/bisq/core/offer/bisq_v1/CreateOfferService.java (23)
    R core/src/main/java/bisq/core/offer/bisq_v1/MarketPriceNotAvailableException.java (2)
    R core/src/main/java/bisq/core/offer/bisq_v1/MutableOfferPayloadFields.java (2)
    R core/src/main/java/bisq/core/offer/bisq_v1/OfferPayload.java (244)
    R core/src/main/java/bisq/core/offer/bisq_v1/TakeOfferModel.java (4)
    R core/src/main/java/bisq/core/offer/bisq_v1/TriggerPriceService.java (29)
    A core/src/main/java/bisq/core/offer/bsq_swap/BsqSwapOfferModel.java (392)
    A core/src/main/java/bisq/core/offer/bsq_swap/BsqSwapOfferPayload.java (169)
    A core/src/main/java/bisq/core/offer/bsq_swap/BsqSwapTakeOfferModel.java (135)
    A core/src/main/java/bisq/core/offer/bsq_swap/OpenBsqSwapOffer.java (211)
    A core/src/main/java/bisq/core/offer/bsq_swap/OpenBsqSwapOfferService.java (396)
    R core/src/main/java/bisq/core/offer/placeoffer/bisq_v1/PlaceOfferModel.java (2)
    R core/src/main/java/bisq/core/offer/placeoffer/bisq_v1/PlaceOfferProtocol.java (14)
    R core/src/main/java/bisq/core/offer/placeoffer/bisq_v1/tasks/AddToOfferBook.java (4)
    R core/src/main/java/bisq/core/offer/placeoffer/bisq_v1/tasks/CheckNumberOfUnconfirmedTransactions.java (4)
    R core/src/main/java/bisq/core/offer/placeoffer/bisq_v1/tasks/CreateMakerFeeTx.java (6)
    R core/src/main/java/bisq/core/offer/placeoffer/bisq_v1/tasks/ValidateOffer.java (8)
    A core/src/main/java/bisq/core/offer/placeoffer/bsqswap/PlaceBsqSwapOfferModel.java (46)
    A core/src/main/java/bisq/core/offer/placeoffer/bsqswap/PlaceBsqSwapOfferProtocol.java (83)
    A core/src/main/java/bisq/core/offer/placeoffer/bsqswap/tasks/AddBsqSwapOfferToOfferBook.java (55)
    A core/src/main/java/bisq/core/offer/placeoffer/bsqswap/tasks/ValidateBsqSwapOffer.java (80)
    A core/src/main/java/bisq/core/payment/BsqSwapAccount.java (50)
    M core/src/main/java/bisq/core/payment/PaymentAccountFactory.java (2)
    A core/src/main/java/bisq/core/payment/payload/BsqSwapAccountPayload.java (70)
    M core/src/main/java/bisq/core/payment/payload/PaymentMethod.java (21)
    M core/src/main/java/bisq/core/proto/CoreProtoResolver.java (3)
    M core/src/main/java/bisq/core/proto/ProtoDevUtil.java (12)
    M core/src/main/java/bisq/core/proto/network/CoreNetworkProtoResolver.java (53)
    M core/src/main/java/bisq/core/proto/persistable/CorePersistenceProtoResolver.java (2)
    M core/src/main/java/bisq/core/provider/mempool/MempoolService.java (4)
    M core/src/main/java/bisq/core/setup/CoreNetworkCapabilities.java (3)
    M core/src/main/java/bisq/core/setup/CorePersistedDataHost.java (6)
    M core/src/main/java/bisq/core/support/dispute/Dispute.java (2)
    M core/src/main/java/bisq/core/support/dispute/DisputeListService.java (2)
    M core/src/main/java/bisq/core/support/dispute/DisputeManager.java (10)
    M core/src/main/java/bisq/core/support/dispute/agent/MultipleHolderNameDetection.java (2)
    M core/src/main/java/bisq/core/support/dispute/arbitration/ArbitrationManager.java (8)
    M core/src/main/java/bisq/core/support/dispute/mediation/MediationManager.java (10)
    M core/src/main/java/bisq/core/support/dispute/refund/RefundManager.java (4)
    M core/src/main/java/bisq/core/support/traderchat/TradeChatSession.java (6)
    M core/src/main/java/bisq/core/support/traderchat/TraderChatManager.java (9)
    M core/src/main/java/bisq/core/trade/TradeManager.java (333)
    M core/src/main/java/bisq/core/trade/TradeModule.java (4)
    R core/src/main/java/bisq/core/trade/bisq_v1/CleanupMailboxMessagesService.java (12)
    R core/src/main/java/bisq/core/trade/bisq_v1/ClosedTradableManager.java (17)
    R core/src/main/java/bisq/core/trade/bisq_v1/ClosedTradeUtil.java (14)
    R core/src/main/java/bisq/core/trade/bisq_v1/DumpDelayedPayoutTx.java (9)
    R core/src/main/java/bisq/core/trade/bisq_v1/FailedTradesManager.java (17)
    R core/src/main/java/bisq/core/trade/bisq_v1/TradeDataValidation.java (3)
    R core/src/main/java/bisq/core/trade/bisq_v1/TradeResultHandler.java (8)
    R core/src/main/java/bisq/core/trade/bisq_v1/TradeTxException.java (2)
    R core/src/main/java/bisq/core/trade/bisq_v1/TradeUtil.java (40)
    R core/src/main/java/bisq/core/trade/bisq_v1/TransactionResultHandler.java (2)
    A core/src/main/java/bisq/core/trade/bsq_swap/BsqSwapCalculation.java (245)
    A core/src/main/java/bisq/core/trade/bsq_swap/BsqSwapTakeOfferRequestVerification.java (106)
    A core/src/main/java/bisq/core/trade/bsq_swap/BsqSwapTradeManager.java (119)
    R core/src/main/java/bisq/core/trade/model/MakerTrade.java (2)
    R core/src/main/java/bisq/core/trade/model/TakerTrade.java (2)
    R core/src/main/java/bisq/core/trade/model/Tradable.java (2)
    R core/src/main/java/bisq/core/trade/model/TradableList.java (18)
    A core/src/main/java/bisq/core/trade/model/TradeModel.java (111)
    A core/src/main/java/bisq/core/trade/model/TradePhase.java (28)
    A core/src/main/java/bisq/core/trade/model/TradeState.java (28)
    R core/src/main/java/bisq/core/trade/model/bisq_v1/BuyerAsMakerTrade.java (6)
    R core/src/main/java/bisq/core/trade/model/bisq_v1/BuyerAsTakerTrade.java (6)
    R core/src/main/java/bisq/core/trade/model/bisq_v1/BuyerTrade.java (4)
    R core/src/main/java/bisq/core/trade/model/bisq_v1/Contract.java (7)
    R core/src/main/java/bisq/core/trade/model/bisq_v1/SellerAsMakerTrade.java (6)
    R core/src/main/java/bisq/core/trade/model/bisq_v1/SellerAsTakerTrade.java (6)
    R core/src/main/java/bisq/core/trade/model/bisq_v1/SellerTrade.java (4)
    R core/src/main/java/bisq/core/trade/model/bisq_v1/Trade.java (159)
    A core/src/main/java/bisq/core/trade/model/bsq_swap/BsqSwapBuyerAsMakerTrade.java (122)
    A core/src/main/java/bisq/core/trade/model/bsq_swap/BsqSwapBuyerAsTakerTrade.java (122)
    A core/src/main/java/bisq/core/trade/model/bsq_swap/BsqSwapBuyerTrade.java (59)
    A core/src/main/java/bisq/core/trade/model/bsq_swap/BsqSwapSellerAsMakerTrade.java (122)
    A core/src/main/java/bisq/core/trade/model/bsq_swap/BsqSwapSellerAsTakerTrade.java (123)
    A core/src/main/java/bisq/core/trade/model/bsq_swap/BsqSwapSellerTrade.java (56)
    A core/src/main/java/bisq/core/trade/model/bsq_swap/BsqSwapTrade.java (248)
    M core/src/main/java/bisq/core/trade/protocol/FluentProtocol.java (80)
    A core/src/main/java/bisq/core/trade/protocol/ProtocolModel.java (28)
    R core/src/main/java/bisq/core/trade/protocol/Provider.java (40)
    R core/src/main/java/bisq/core/trade/protocol/TradeMessage.java (2)
    A core/src/main/java/bisq/core/trade/protocol/TradePeer.java (27)
    M core/src/main/java/bisq/core/trade/protocol/TradeProtocol.java (109)
    M core/src/main/java/bisq/core/trade/protocol/TradeProtocolFactory.java (53)
    M core/src/main/java/bisq/core/trade/protocol/TradeTaskRunner.java (14)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/BuyerAsMakerProtocol.java (47)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/BuyerAsTakerProtocol.java (52)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/BuyerProtocol.java (42)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/DisputeProtocol.java (77)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/MakerProtocol.java (4)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/SellerAsMakerProtocol.java (49)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/SellerAsTakerProtocol.java (42)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/SellerProtocol.java (44)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/TakerProtocol.java (4)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/messages/CounterCurrencyTransferStartedMessage.java (2)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/messages/DelayedPayoutTxSignatureRequest.java (4)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/messages/DelayedPayoutTxSignatureResponse.java (4)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/messages/DepositTxAndDelayedPayoutTxMessage.java (2)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/messages/DepositTxMessage.java (4)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/messages/InputsForDepositTxRequest.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/messages/InputsForDepositTxResponse.java (3)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/messages/MediatedPayoutTxPublishedMessage.java (2)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/messages/MediatedPayoutTxSignatureMessage.java (2)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/messages/PayoutTxPublishedMessage.java (2)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/messages/PeerPublishedDelayedPayoutTxMessage.java (2)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/messages/RefreshTradeStateRequest.java (2)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/messages/ShareBuyerPaymentAccountMessage.java (2)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/messages/TradeMailboxMessage.java (4)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/messages/TraderSignedWitnessMessage.java (2)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/model/ProcessModel.java (35)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/model/TradingPeer.java (6)
    A core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/ApplyFilter.java (63)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/BroadcastPayoutTx.java (4)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/ProcessPeerPublishedDelayedPayoutTxMessage.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/SendMailboxMessageTask.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/SetupPayoutTxListener.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/TradeTask.java (9)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/VerifyPeersAccountAgeWitness.java (8)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/arbitration/PublishedDelayedPayoutTx.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/arbitration/SendPeerPublishedDelayedPayoutTxMessage.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer/BuyerFinalizesDelayedPayoutTx.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer/BuyerProcessDelayedPayoutTxSignatureRequest.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer/BuyerProcessDepositTxAndDelayedPayoutTxMessage.java (23)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer/BuyerProcessPayoutTxPublishedMessage.java (9)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer/BuyerSendCounterCurrencyTransferStartedMessage.java (18)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer/BuyerSendsDelayedPayoutTxSignatureResponse.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer/BuyerSendsShareBuyerPaymentAccountMessage.java (12)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer/BuyerSetupDepositTxListener.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer/BuyerSetupPayoutTxListener.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer/BuyerSignPayoutTx.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer/BuyerSignsDelayedPayoutTx.java (8)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer/BuyerVerifiesFinalDelayedPayoutTx.java (8)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer/BuyerVerifiesPreparedDelayedPayoutTx.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer_as_maker/BuyerAsMakerCreatesAndSignsDepositTx.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer_as_maker/BuyerAsMakerSendsInputsForDepositTxResponse.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer_as_taker/BuyerAsTakerCreatesDepositTxInputs.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer_as_taker/BuyerAsTakerSendsDepositTxMessage.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer_as_taker/BuyerAsTakerSignsDepositTx.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/maker/MakerCreateAndSignContract.java (29)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/maker/MakerProcessesInputsForDepositTxRequest.java (12)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/maker/MakerRemovesOpenOffer.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/maker/MakerSendsInputsForDepositTxResponse.java (12)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/maker/MakerSetsLockTime.java (8)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/maker/MakerVerifyTakerFeePayment.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/mediation/BroadcastMediatedPayoutTx.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/mediation/FinalizeMediatedPayoutTx.java (12)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/mediation/ProcessMediatedPayoutSignatureMessage.java (11)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/mediation/ProcessMediatedPayoutTxPublishedMessage.java (9)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/mediation/SendMediatedPayoutSignatureMessage.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/mediation/SendMediatedPayoutTxPublishedMessage.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/mediation/SetupMediatedPayoutTxListener.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/mediation/SignMediatedPayoutTx.java (12)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller/SellerBroadcastPayoutTx.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller/SellerCreatesDelayedPayoutTx.java (8)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller/SellerFinalizesDelayedPayoutTx.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller/SellerProcessCounterCurrencyTransferStartedMessage.java (13)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller/SellerProcessDelayedPayoutTxSignatureResponse.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller/SellerProcessShareBuyerPaymentAccountMessage.java (18)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller/SellerPublishesDepositTx.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller/SellerPublishesTradeStatistics.java (8)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller/SellerSendDelayedPayoutTxSignatureRequest.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller/SellerSendPayoutTxPublishedMessage.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller/SellerSendsDepositTxAndDelayedPayoutTxMessage.java (12)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller/SellerSignAndFinalizePayoutTx.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller/SellerSignsDelayedPayoutTx.java (8)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller_as_maker/SellerAsMakerCreatesUnsignedDepositTx.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller_as_maker/SellerAsMakerFinalizesDepositTx.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller_as_maker/SellerAsMakerProcessDepositTxMessage.java (11)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller_as_maker/SellerAsMakerSendsInputsForDepositTxResponse.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller_as_taker/SellerAsTakerCreatesDepositTxInputs.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller_as_taker/SellerAsTakerSignsDepositTx.java (14)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/taker/CreateTakerFeeTx.java (8)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/taker/TakerProcessesInputsForDepositTxResponse.java (14)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/taker/TakerPublishFeeTx.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/taker/TakerSendInputsForDepositTxRequest.java (12)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/taker/TakerVerifyAndSignContract.java (32)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/taker/TakerVerifyMakerFeePayment.java (6)
    A core/src/main/java/bisq/core/trade/protocol/bsq_swap/BsqSwapBuyerAsMakerProtocol.java (111)
    A core/src/main/java/bisq/core/trade/protocol/bsq_swap/BsqSwapBuyerAsTakerProtocol.java (99)
    A core/src/main/java/bisq/core/trade/protocol/bsq_swap/BsqSwapBuyerProtocol.java (30)
    A core/src/main/java/bisq/core/trade/protocol/bsq_swap/BsqSwapMakerProtocol.java (31)
    A core/src/main/java/bisq/core/trade/protocol/bsq_swap/BsqSwapProtocol.java (44)
    A core/src/main/java/bisq/core/trade/protocol/bsq_swap/BsqSwapSellerAsMakerProtocol.java (98)
    A core/src/main/java/bisq/core/trade/protocol/bsq_swap/BsqSwapSellerAsTakerProtocol.java (110)
    A core/src/main/java/bisq/core/trade/protocol/bsq_swap/BsqSwapSellerProtocol.java (30)
    A core/src/main/java/bisq/core/trade/protocol/bsq_swap/BsqSwapTakerProtocol.java (23)
    A core/src/main/java/bisq/core/trade/protocol/bsq_swap/messages/BsqSwapFinalizeTxRequest.java (129)
    A core/src/main/java/bisq/core/trade/protocol/bsq_swap/messages/BsqSwapFinalizedTxMessage.java (83)
    A core/src/main/java/bisq/core/trade/protocol/bsq_swap/messages/BsqSwapRequest.java (60)
    A core/src/main/java/bisq/core/trade/protocol/bsq_swap/messages/BsqSwapTxInputsMessage.java (107)
    A core/src/main/java/bisq/core/trade/protocol/bsq_swap/messages/BuyersBsqSwapRequest.java (138)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/5780.patch
https://github.com/bisq-network/bisq/pull/5780.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5780
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211024/b0e49bae/attachment-0001.htm>

From notifications at github.com  Mon Oct 25 02:38:15 2021
From: notifications at github.com (chimp1984)
Date: Sun, 24 Oct 2021 17:38:15 -0700
Subject: [bisq-network/bisq] Deactivate dao monitor by default (PR #5780)
In-Reply-To: <bisq-network/bisq/pull/5780@github.com>
References: <bisq-network/bisq/pull/5780@github.com>
Message-ID: <bisq-network/bisq/pull/5780/push/8226768178@github.com>

@chimp1984 pushed 2 commits.

79ced0742fc0ff8562525750bcc4d3a1ab172d95  Create snapshot after parsing done if dao monitor is deactivated
296c917023aca1b7e471fbc345dada90ea7bd409  Don't check utxos during sync


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/bisq-network/bisq/pull/5780/files/b8290a7e255ec18398eb88f782889c10c94b7041..296c917023aca1b7e471fbc345dada90ea7bd409
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211024/6bf606f3/attachment.htm>

From notifications at github.com  Mon Oct 25 10:38:38 2021
From: notifications at github.com (MwithM)
Date: Mon, 25 Oct 2021 01:38:38 -0700
Subject: [bisq-network/compensation] For Cycle 29 (Issue #933)
In-Reply-To: <bisq-network/compensation/issues/933@github.com>
References: <bisq-network/compensation/issues/933@github.com>
Message-ID: <bisq-network/compensation/issues/933/950669890@github.com>

Is 28b33fa1d7851e4c2ab641d90db668474412f230d7920937440c685e20a847bb the correct TXID?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/933#issuecomment-950669890
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211025/395ea64c/attachment.htm>

From notifications at github.com  Mon Oct 25 11:34:30 2021
From: notifications at github.com (leo816)
Date: Mon, 25 Oct 2021 02:34:30 -0700
Subject: [bisq-network/roles] Mediator (#83)
In-Reply-To: <bisq-network/roles/issues/83@github.com>
References: <bisq-network/roles/issues/83@github.com>
Message-ID: <bisq-network/roles/issues/83/950722707@github.com>

# Cycle 29 Report 

l'll break down the distribution of the  mediation cases I've handled in Cycle 29, the main _BUGS_ are:

 - **Banking Issues**
Banks not accepting payments from given accounts who have been blocked due to bitcoin payments, Monthly payment limit allowed (Zelle) , Making a payment from the wrong account.

 - **Messages not arriving to peer**
It seems it has to do with the Hibernating mode, Fix was already implemented and will be in the next release.

- **Funds showing as locked when the trade fails**: SPV resync doesn't always fix this, when this happens the easiest is to delete the ClosedTrades and FailedTrades files in the db folder.**:



| Reason                	 	| Cycle 29	|
|-----------------------	|----------	|
| PEER_WAS_LATE       	|   21	| 
| BANK_PROBLEMS         	|   20	| 
| TX BUGGED                  	|     4  |  
| SELLER NOT RESPONDING 	|    10	| 
| USABILITY 	|    3 	| 
| TRADE_ALREADY_SETTLED 	|   10	| 
| OTHER 	|     4	| 
| Total Result          	|        72	|




-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/roles/issues/83#issuecomment-950722707
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211025/47c735fd/attachment.htm>

From notifications at github.com  Mon Oct 25 11:36:17 2021
From: notifications at github.com (leo816)
Date: Mon, 25 Oct 2021 02:36:17 -0700
Subject: [bisq-network/compensation] For Cycle 29 (Issue #935)
In-Reply-To: <bisq-network/compensation/issues/935@github.com>
References: <bisq-network/compensation/issues/935@github.com>
Message-ID: <bisq-network/compensation/issues/935/950724331@github.com>

Just did a quick proposal since I was traveling and that information was left from the earlier cycle. fixed.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/935#issuecomment-950724331
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211025/fb32383b/attachment.htm>

From notifications at github.com  Mon Oct 25 11:39:06 2021
From: notifications at github.com (leo816)
Date: Mon, 25 Oct 2021 02:39:06 -0700
Subject: [bisq-network/roles] L1 Support Agent (#64)
In-Reply-To: <bisq-network/roles/issues/64@github.com>
References: <bisq-network/roles/issues/64@github.com>
Message-ID: <bisq-network/roles/issues/64/950727065@github.com>

## Cycle 29

- Been available on Keybase from 7:30pm - 9:30pm Monday to Sunday. But active all day answering messages. 

- Been in constant communication with devs when issues occur.

- Hosted the weekly support call, were we discussed the main issues and reported bugs.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/roles/issues/64#issuecomment-950727065
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211025/d4f85e2d/attachment.htm>

From notifications at github.com  Mon Oct 25 12:00:48 2021
From: notifications at github.com (leo816)
Date: Mon, 25 Oct 2021 03:00:48 -0700
Subject: [bisq-network/roles] Support Team Lead (#102)
In-Reply-To: <bisq-network/roles/issues/102@github.com>
References: <bisq-network/roles/issues/102@github.com>
Message-ID: <bisq-network/roles/issues/102/950745933@github.com>

## Cycle 29 Report

- **Continued with the Weekly Support calls**
https://github.com/bisq-network/support/issues/916#issuecomment-910472694

No reports were made of the last calls but all took place. The main topics of discussion were:

1. Bugs
2. Priorities list
3. Most common Mediation cases
4. Penalties.
5. Monero traders 
6. Payment methods
7. messages not received by peers

Main points from this cycle:

- **@huey735 hasn't answered back**
 @huey735 has been missing for over 2 months, I hope he is fine and we would love to have him back as has been a great help for bisq.

- **Continued with Dev Calls**
Along with @jmacxx our aim is to improve communication with the dev team and have a better roadmap for bisq.
reports: https://github.com/bisq-network/projects/issues/60#issuecomment-944501972

- **@BtcContributor continued as support agent**
Has been having around 4-5 cases a week, mainly focused on keybase but was encouraged to also keep an eye on the forum.
his reported suggestion as improvements to the wiki: https://shrib.com/#Bronson9V9N8R4

- **Constantly in conversations with @jmacxx  and @pazza83  on how to improve user experience**  
Both of them are working really well with bisq, always giving feedback and available for calls to help sort out bugs or problems users might have.

- **Overall keeping track of the performance of the support team**



**_Analysis of Mediation Cases_**
 We have had 139 mediation cases this cylce. more than 

If I continue the mediation progression report, it would look like this:

<details>

<summary>Click to see report</summary>

### Mediation Issues Report

_N of Issues cycle 15: **85**_
_38 Wiz
24 B Knight
23 Leo816_

- Different reasons for disputes: 
```
1) 20% Both parties agreed to cancel
2) 30% trader provided the wrong information
3) 50% User took longer to confirm/answer
```


_N of Issues cycle 16:  **111**_
 
_44 Wiz
 38 B knight
 29 Leo816_

- Different reasons for disputes: 
```
1) 25% Both parties agreed to cancel
2) 20% trader provided the wrong information
3) 40% User took longer to confirm/answer
4) 15% buyer could not make the payment
```


_N of Issues cycle 17:  **128**_

_52 Wiz
36 B knight
40 Leo816_

- Different reasons for disputes: 
```
1) 20% Stuck in Stage 2
2) 25% Banking issues, buyer couldn't make the payment
3) 55% BTC seller took longer to confirm/answer
```
**Summary**: the btc seller took longer to respond/ confirm the payment for 

_N of Issues cycle 18:  **89**_

_31 Huey735
21 B Knight
37 Leo816_

- Different reasons for disputes: 

```
1) 25% Stuck in Stage 2
2) 15% Banking issues (zelle and revolut)
3) 60% User behaviour- took longer to confirm/ answer (disagreements)
```



_N of Issues cycle 19: **184**_

 _36 Huey735
 75 B Knight
 73 Leo816
Pending report Wiz_ 

- Different reasons for disputes: 
```
1) 40% Stuck in Stage 2
2) 10% Banking issues
3) 40% User took longer to confirm/ answer
4) 10% Failed Trades
```


_N of Issues cycle 20: **160**_
 
_82 Huey735
 78 Leo816_


- Different reasons for disputes: 
```
1) 50% _BUGS_ (Stuck in Stage 2)
2) 22% Banking issues
3) 20% User took longer to confirm/ answer
4) 8% Failed Trades
```

_N of Issues cycle 21: **160**_
Missing report from Huey735
 160 Leo816

_N of Issues cycle 22: **101**_
Missing report from Huey735
 101 Leo816

- Different reasons for disputes: 
```
1) 35% _BUGS_ (Stuck in Stage 2, button greyed out)
2) 25% Late Payments
3) 20% Trade already settled (former user took longer to confirm/answer)
4) 8% Failed Trades
5) 6% Stuck in Multisig
6) 6% Bank problems
```

Report from cycle 21 was a late report instead of midcycle like usually, reason why the amount is significantly larger than in previous cycles. Mediation tickets seem like there are more to me but it's just because we are now just two mediators working instead of 3 or 4. 
On cycle 22 there is a considerable increase from **78 to 101 tickets**. That means 3 new ones everyday.
Would like to also see Huey's report to compare.

_N of Issues cycle 28: **107**_
54 Pazza
53 Leo816

- Different reasons for disputes: 
```
1) 30% Bank Problems
2) 18% Late Payments
3) 17% Trader not responding
4) 9% Bug
5) 9% Trade settled
6)10% Usability
7) 7% Other

```
_N of Issues cycle 29: **139**_
67 Pazza
72 Leo816

- Different reasons for disputes: 
```
1) 25% Bank Problems
2) 20% Late Payments
3) 7% Trader not responding
4) 13% Bug
5) 8% Trade settled
6)10% Usability
7) 17% Other

```






-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/roles/issues/102#issuecomment-950745933
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211025/329a2e3b/attachment.htm>

From notifications at github.com  Mon Oct 25 13:16:55 2021
From: notifications at github.com (chimp1984)
Date: Mon, 25 Oct 2021 04:16:55 -0700
Subject: [bisq-network/bisq] Deactivate dao monitor by default (PR #5780)
In-Reply-To: <bisq-network/bisq/pull/5780@github.com>
References: <bisq-network/bisq/pull/5780@github.com>
Message-ID: <bisq-network/bisq/pull/5780/push/8230201857@github.com>

@chimp1984 pushed 2 commits.

5dcbb90300a45719fcaef1b16a10cf7ae5b02358  Move DaoStateMonitorView specific fields from
9b04889b98b01343bda5a6ac30d75f3d2f53b124  Remove prevHash from StateHash classes.


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/bisq-network/bisq/pull/5780/files/296c917023aca1b7e471fbc345dada90ea7bd409..9b04889b98b01343bda5a6ac30d75f3d2f53b124
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211025/97c00b81/attachment.htm>

From notifications at github.com  Mon Oct 25 13:33:30 2021
From: notifications at github.com (Liisachan)
Date: Mon, 25 Oct 2021 04:33:30 -0700
Subject: [bisq-network/proposals] Allow 1sat/vByte fee for withdrawals
 (#343)
In-Reply-To: <bisq-network/proposals/issues/343@github.com>
References: <bisq-network/proposals/issues/343@github.com>
Message-ID: <bisq-network/proposals/issues/343/950829728@github.com>

Basically, this is simply widening options without breaking anything that already exists in the current version.

When sending something to your peer, you should obviously try to do that quickly, paying reasonable fees if necessary, because your peer is waiting. But here we're talking about withdrawal, a solo/private action of the user. Even if such a transaction takes forever or even fails, no one would be annoyed in any way, except maybe that user themselves.

As such, I'm not really sure if discussion like this is even necessary. Why would anyone be against this? The only possible reason I can think of is, well, one could argue that by setting the withdrawal fee higher than actually necessary, users are somewhat discouraged from withdrawing their BTC from Bisq wallets, and thus encouraged (or implicitly forced) to use Bisq forever, which is beneficial to the community in a way. However, such an attitude (taking your fund as a hostage, so to speak) would be imho antithetical to what Bisq stands for - decentralization, anti-monopolization, liberty, etc. Moreover, high fees would only make it less attractive to potential new users, so that'll only backfire in the long run.

That said, the difference between 1 sat and 2 sats is so small, perhaps almost no one really cares whichever. Then again, every satoshi counts :) A satoshi saved is a satoshi earned. Relatively speaking, 1 sat/vB is a whapping 50% discount compared to 2 sat/vB, even though the absolute amount is negligible anyway!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/proposals/issues/343#issuecomment-950829728
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211025/4a7cfbd9/attachment.htm>

From notifications at github.com  Mon Oct 25 14:59:16 2021
From: notifications at github.com (chimp1984)
Date: Mon, 25 Oct 2021 05:59:16 -0700
Subject: [bisq-network/bisq] Deactivate DAO state monitoring as it is too
 slow (Issue #5779)
In-Reply-To: <bisq-network/bisq/issues/5779@github.com>
References: <bisq-network/bisq/issues/5779@github.com>
Message-ID: <bisq-network/bisq/issues/5779/950899345@github.com>

I found a good compromise.
We can request the missing daoStateHashes from the seed node (we do that anyway for the past 10, I extend that to the missing number of hashes). We add those missing hashes to our list and mark them with a flag that we have not created them by ourslef (just informational). At every new block we create the hash ourself (the performance penalty of 200 ms is here not an issue). As the hash is created with the previous hash + the current dao state we would detect if our local dao state would be out of sync with the network, just as like we detect it if we would have created the missing hashes by ourself. We can do that also for the latest block, so we can be sure after sync that our local dao state is in sync.
This eliminates besically the problems with not having the DAO state monitored. We still leave the toggle in the preferences to enable/disable that kind of "full monitoring" mode. Seed nodes have that enabled by default and power users can/should od that as well. But for casual users there is basically no disadvantage to not have it enabled but removes the high performance degradation at syncing. 
   

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5779#issuecomment-950899345
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211025/b04668b5/attachment-0001.htm>

From notifications at github.com  Mon Oct 25 15:11:47 2021
From: notifications at github.com (chimp1984)
Date: Mon, 25 Oct 2021 06:11:47 -0700
Subject: [bisq-network/bisq] Deactivate dao monitor by default (PR #5780)
In-Reply-To: <bisq-network/bisq/pull/5780@github.com>
References: <bisq-network/bisq/pull/5780@github.com>
Message-ID: <bisq-network/bisq/pull/5780/push/8231100727@github.com>

@chimp1984 pushed 1 commit.

965f5269a19605dbfe13ea429d3ebc80fbcbb49a  Add isSelfConstructed to DaoStateHash (and remove it from


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/bisq-network/bisq/pull/5780/files/9b04889b98b01343bda5a6ac30d75f3d2f53b124..965f5269a19605dbfe13ea429d3ebc80fbcbb49a
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211025/9fc23156/attachment.htm>

From notifications at github.com  Mon Oct 25 15:27:42 2021
From: notifications at github.com (asvdf)
Date: Mon, 25 Oct 2021 06:27:42 -0700
Subject: [bisq-network/proposals] Allow 1sat/vByte fee for withdrawals
 (#343)
In-Reply-To: <bisq-network/proposals/issues/343@github.com>
References: <bisq-network/proposals/issues/343@github.com>
Message-ID: <bisq-network/proposals/issues/343/950929629@github.com>

At current prices, we are looking for a 10c saved, or little less, for each transaction, by being able to set 1sat/vB per withdrawal. Don't know about you, but if I found a penny on the street I'd pick it up, so all the more reason not to throw away 10c in unneeded fees ? 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/proposals/issues/343#issuecomment-950929629
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211025/b7651496/attachment.htm>

From notifications at github.com  Mon Oct 25 15:30:59 2021
From: notifications at github.com (Aleksej)
Date: Mon, 25 Oct 2021 06:30:59 -0700
Subject: [bisq-network/roles] Pricenode Operator (#14)
In-Reply-To: <bisq-network/roles/issues/14@github.com>
References: <bisq-network/roles/issues/14@github.com>
Message-ID: <bisq-network/roles/issues/14/950932736@github.com>

## Cycle 29 report
Running 1 instance.
Nothing to report.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/roles/issues/14#issuecomment-950932736
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211025/48e4fb0d/attachment.htm>

From notifications at github.com  Mon Oct 25 15:32:14 2021
From: notifications at github.com (Aleksej)
Date: Mon, 25 Oct 2021 06:32:14 -0700
Subject: [bisq-network/roles] Reddit Moderator (#25)
In-Reply-To: <bisq-network/roles/issues/25@github.com>
References: <bisq-network/roles/issues/25@github.com>
Message-ID: <bisq-network/roles/issues/25/950933789@github.com>

## Cycle 29 report

Currently we have **4255** readers, which is an increase of **115** new users from last report.
The increase from last report is around **2.7%**.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/roles/issues/25#issuecomment-950933789
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211025/fc4ee29b/attachment.htm>

From notifications at github.com  Mon Oct 25 15:55:59 2021
From: notifications at github.com (Aleksej)
Date: Mon, 25 Oct 2021 06:55:59 -0700
Subject: [bisq-network/roles] Forum Operator (#19)
In-Reply-To: <bisq-network/roles/issues/19@github.com>
References: <bisq-network/roles/issues/19@github.com>
Message-ID: <bisq-network/roles/issues/19/950954765@github.com>

## Cycle 28 report
Discourse was updated once this cycle to the current version of **2.8.0.beta7**.

![Screenshot from 2021-10-20 23-28-56](https://user-images.githubusercontent.com/24721710/138705022-c806c248-98e3-4c5b-be4c-6fee30b60b3b.png)


Forum activity decreased from last cycle.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/roles/issues/19#issuecomment-950954765
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211025/3436a215/attachment.htm>

From notifications at github.com  Mon Oct 25 15:56:23 2021
From: notifications at github.com (Aleksej)
Date: Mon, 25 Oct 2021 06:56:23 -0700
Subject: [bisq-network/compensation] For Cycle 29 (Issue #936)
Message-ID: <bisq-network/compensation/issues/936@github.com>

## Summary
This is a compensation request for work done in Cycle 27.

- **BSQ requested** : **161*
- USD requested: **250**
- BSQ rate: **1.55** USD per BSQ
- Previous compensation request: https://github.com/bisq-network/compensation/issues/915

## Contributions delivered

| Title | Team | USD | Link | Notes |
| --- | --- | --- | --- | --- |
| Forum operator | ops* | 100 | https://github.com/bisq-network/roles/issues/19#issuecomment-950954765 |
| Reddit moderator | growth* | 50 | https://github.com/bisq-network/roles/issues/25#issuecomment-950933789 |
| Pricenode operator | ops* | 100 | https://github.com/bisq-network/roles/issues/14#issuecomment-950932736 |


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/936
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211025/cbfaa423/attachment-0001.htm>

From notifications at github.com  Mon Oct 25 18:13:18 2021
From: notifications at github.com (jmacxx)
Date: Mon, 25 Oct 2021 09:13:18 -0700
Subject: [bisq-network/roles] Mediator (#83)
In-Reply-To: <bisq-network/roles/issues/83@github.com>
References: <bisq-network/roles/issues/83@github.com>
Message-ID: <bisq-network/roles/issues/83/951083795@github.com>

@leo816 I want to clarify that using "fixed" for the following issue is not correct.

> Messages not arriving to peer
> It seems it has to do with the Hibernating mode, Fix was already implemented and will be in the next release.

The issue of [dropped messages](https://github.com/bisq-network/bisq/issues/5526) is not necessarily fixed by https://github.com/bisq-network/bisq/pull/5719 -- it is simply a popup shown if the PC had been in sleep mode -- so we've added an informational message.  It might encourage users to disable sleep mode, and at best, it might reduce the occurrences.  As things stand, its the best suggestion based on speculation that hibernating computers can cause the issue.  

I think there's more to the problem, and IMHO missed messages are likely to still be an issue.  


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/roles/issues/83#issuecomment-951083795
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211025/7b151652/attachment.htm>

From notifications at github.com  Mon Oct 25 18:19:30 2021
From: notifications at github.com (leo816)
Date: Mon, 25 Oct 2021 09:19:30 -0700
Subject: [bisq-network/roles] Mediator (#83)
In-Reply-To: <bisq-network/roles/issues/83@github.com>
References: <bisq-network/roles/issues/83@github.com>
Message-ID: <bisq-network/roles/issues/83/951089451@github.com>

Thank you for clarifying. Just edited it

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/roles/issues/83#issuecomment-951089451
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211025/60f0b5b0/attachment.htm>

From notifications at github.com  Mon Oct 25 22:16:36 2021
From: notifications at github.com (chimp1984)
Date: Mon, 25 Oct 2021 13:16:36 -0700
Subject: [bisq-network/bisq] Deactivate dao monitor by default (PR #5780)
In-Reply-To: <bisq-network/bisq/pull/5780@github.com>
References: <bisq-network/bisq/pull/5780@github.com>
Message-ID: <bisq-network/bisq/pull/5780/push/8234431114@github.com>

@chimp1984 pushed 1 commit.

d97449a4d197f3339c7d61fc555333a3643bb37c  Create daoStateBlocks from peers data in case we have daoMonitor deactivated


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/bisq-network/bisq/pull/5780/files/965f5269a19605dbfe13ea429d3ebc80fbcbb49a..d97449a4d197f3339c7d61fc555333a3643bb37c
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211025/08eba4df/attachment.htm>

From notifications at github.com  Mon Oct 25 22:18:43 2021
From: notifications at github.com (chimp1984)
Date: Mon, 25 Oct 2021 13:18:43 -0700
Subject: [bisq-network/bisq] Refactor dao monitor handling (PR #5780)
In-Reply-To: <bisq-network/bisq/pull/5780@github.com>
References: <bisq-network/bisq/pull/5780@github.com>
Message-ID: <bisq-network/bisq/pull/5780/issue_event/5516093847@github.com>

Closed #5780.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5780#event-5516093847
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211025/30047af8/attachment.htm>

From notifications at github.com  Mon Oct 25 22:19:10 2021
From: notifications at github.com (chimp1984)
Date: Mon, 25 Oct 2021 13:19:10 -0700
Subject: [bisq-network/bisq] Refactor dao monitor handling (PR #5780)
In-Reply-To: <bisq-network/bisq/pull/5780@github.com>
References: <bisq-network/bisq/pull/5780@github.com>
Message-ID: <bisq-network/bisq/pull/5780/c951280498@github.com>

Will re-open PR once complete. Had got too many changes....

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5780#issuecomment-951280498
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211025/cad59736/attachment.htm>

From notifications at github.com  Mon Oct 25 23:11:14 2021
From: notifications at github.com (stopfeds)
Date: Mon, 25 Oct 2021 14:11:14 -0700
Subject: [bisq-network/growth] Creating a German-only Bisq account on
 Twitter to reach the growing German-speaking audience (#249)
In-Reply-To: <bisq-network/growth/issues/249@github.com>
References: <bisq-network/growth/issues/249@github.com>
Message-ID: <bisq-network/growth/issues/249/951334576@github.com>

Hey all,
Thanks for the feedback. Maybe I should have asked here before tweeting, you are right. Now it is too late and we can't go back. Luckily there were no concerns or negative comments about BSQ. I also linked the website explaining the DAO & a good Blocktrainer article. I'll consider this for next time.
Sorry.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/growth/issues/249#issuecomment-951334576
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211025/99f21989/attachment-0001.htm>

From notifications at github.com  Tue Oct 26 12:07:14 2021
From: notifications at github.com (Christoph Atteneder)
Date: Tue, 26 Oct 2021 03:07:14 -0700
Subject: [bisq-network/bisq] Update data stores for v1.7.5 (PR #5781)
Message-ID: <bisq-network/bisq/pull/5781@github.com>

Light node in light mode and full node in dark mode.
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/5781

-- Commit Summary --

  * <a href="https://github.com/bisq-network/bisq/pull/5781/commits/8fbccb75479ffcb1e7b1fcc0feed03aa7fc55735">Bump version number for v1.7.5</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5781/commits/e39ae59683f6c45fd741063a364d7ae8366d43c9">Update translations for v1.7.5</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5781/commits/48a0ebe30973915fd80ff778a131d33a8012a616">Add new v3 onions for wiz&#39;s bitcoin nodes</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5781/commits/94d3638d9841c8653a5db40fa5b1c52fa3e3b0e4">Remove m52go bitcoin node</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5781/commits/8bcfbea47721263bbc5f59988e17b773d48f059b">Update data stores for v1.7.5</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5781/commits/32fcc69fcb330f845b821e8693ecb584d1132f37">Update bitcoinj checkpoints for v1.7.5</a>

-- File Changes --

    M build.gradle (2)
    M common/src/main/java/bisq/common/app/Version.java (2)
    M core/src/main/java/bisq/core/btc/nodes/BtcNodes.java (10)
    M core/src/main/resources/i18n/displayStrings_cs.properties (215)
    M core/src/main/resources/i18n/displayStrings_de.properties (167)
    M core/src/main/resources/i18n/displayStrings_es.properties (137)
    M core/src/main/resources/i18n/displayStrings_fa.properties (137)
    M core/src/main/resources/i18n/displayStrings_fr.properties (137)
    M core/src/main/resources/i18n/displayStrings_it.properties (139)
    M core/src/main/resources/i18n/displayStrings_ja.properties (137)
    M core/src/main/resources/i18n/displayStrings_pt-br.properties (141)
    M core/src/main/resources/i18n/displayStrings_pt.properties (141)
    M core/src/main/resources/i18n/displayStrings_ru.properties (137)
    M core/src/main/resources/i18n/displayStrings_th.properties (137)
    M core/src/main/resources/i18n/displayStrings_vi.properties (157)
    M core/src/main/resources/i18n/displayStrings_zh-hans.properties (151)
    M core/src/main/resources/i18n/displayStrings_zh-hant.properties (137)
    M core/src/main/resources/wallet/checkpoints.txt (4)
    M desktop/package/linux/Dockerfile (2)
    M desktop/package/macosx/Info.plist (4)
    M desktop/package/macosx/copy_dbs.sh (2)
    M desktop/package/macosx/finalize.sh (2)
    M desktop/package/macosx/replace_version_number.sh (4)
    M p2p/src/main/resources/DaoStateStore_BTC_MAINNET (4)
    M p2p/src/main/resources/SignedWitnessStore_BTC_MAINNET (4)
    M relay/src/main/resources/version.txt (2)
    M seednode/src/main/java/bisq/seednode/SeedNodeMain.java (2)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/5781.patch
https://github.com/bisq-network/bisq/pull/5781.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5781
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211026/e2fa5810/attachment.htm>

From notifications at github.com  Tue Oct 26 14:28:25 2021
From: notifications at github.com (chimp1984)
Date: Tue, 26 Oct 2021 05:28:25 -0700
Subject: [bisq-network/bisq] Redesign dao state monitoring (PR #5782)
Message-ID: <bisq-network/bisq/pull/5782@github.com>

Based on https://github.com/bisq-network/bisq/pull/5775
Starts at 3ed6914

Fixes https://github.com/bisq-network/bisq/issues/5779

Spec see at https://github.com/bisq-network/bisq/issues/5779
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/5782

-- Commit Summary --

  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/8fbccb75479ffcb1e7b1fcc0feed03aa7fc55735">Bump version number for v1.7.5</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/e39ae59683f6c45fd741063a364d7ae8366d43c9">Update translations for v1.7.5</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/48a0ebe30973915fd80ff778a131d33a8012a616">Add new v3 onions for wiz&#39;s bitcoin nodes</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/577b07ba9a9b50fdb76d9cdb2d675781c17eed53">Move OfferPayload into package bisq.core.offer.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/19f813eea3b0ed753e8bc90754585e1a4f0344c0">Move CreateOfferService into package bisq.core.offer.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/d98cb278057e27907ba894f696732026a5ba4820">Move MarketPriceNotAvailableException into package bisq.core.offer.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/346fc79094cc0941b2ede33edb3d8d778b81c1a5">Move MutableOfferPayloadFields into package bisq.core.offer.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/8a4c05c1e48b9fd81640456defecc8d472cb8f6c">Move TriggerPriceService into package bisq.core.offer.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/ade5d322374f455a54dd48e9e82e754e9e596b5f">Move TakeOfferModel into package bisq.core.offer.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/20d298061d8c4213bd46f62eedf623f610654288">Move AvailabilityResult into package bisq.core.offer.availability</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/0107519f4307aa594b1a695515d0b31eab39da6c">Move bisq.core.offer.messages package into package bisq.core.offer.availability</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/ed9f248c277afb23464860913119835f79e6395e">Move content of bisq.core.offer.placeoffer package into package bisq.core.offer.placeoffer.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/b584fdf419b031818016505596aa6b899e492972">Rename OfferFilter to OfferFilterService</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/0e23cbe24e63b2a7e792bd496db510ea028e4388">Move Contract, SellerAsMakerTrade, SellerAsTakerTrade, SellerTrade,</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/c0cca781de5646ccf7836341f15ae65e7c30b6e6">Make updateDepositTxFromWallet public</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/0f7cfa99d51d87f378d994c75ef9ec3c8303619c">Move Trade to bisq.core.trade.model.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/5944218a4bb31d914f08b96560f0b1fb3aad61b1">Move MakerTrade and TakerTrade to bisq.core.trade.model package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/5a0145d1d94b31c916f6dca30fbdaa4b60dd67e1">Move Tradable to bisq.core.trade.model package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/81ec06d0dcf397a224fbc950be2fd67ea3f7fb1e">Move TradableList to bisq.core.trade.model package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/2489bbc119db6095abef7a7c659cd851b8ad0509">Make FluentProtocol.Event public</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/c0d13083c8c64ea486a1013059d3a5e1d4fca32e">Make setup in FluentProtocol public</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/87c12fda8c9d95cac288235dd9655ba707ac3391">Move protocol classes to bisq.core.trade.protocol.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/babd70cc2a8230ba72cf8ed205ec326ef2d24969">Move tasks package into bisq.core.trade.protocol.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/5099d974353f424af82d611b416e64e23d123202">Move TradingPeer into bisq.core.trade.protocol.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/a212cec19c9bb32d9bd781e9ac33d75c552fa4a9">Move messages package into bisq.core.trade.protocol.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/c9817ed6dbb1709077b46d07da50566b3a3545ca">Move ClosedTradableManager, FailedTradesManager into bisq.core.trade.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/1b74b4efe9bb3907c0d9dfdf0b482c4cad8b24af">Rename CleanupMailboxMessages to CleanupMailboxMessagesService</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/2141f8f665dab4933022f38d1a2c6b1e42e51d84">Move CleanupMailboxMessagesService, ClosedTradeUtil to package bisq.core.trade.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/f871e8339d294334f46b42ee41572d6c54177a80">Move TransactionResultHandler, TradeResultHandler to package bisq.core.trade.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/71c663eb5306a6e7cbd05d55e95f984eaddd95ec">Move TradeDataValidation, DumpDelayedPayoutTx, TradeDataValidation, TradeUtil, TradeTxException to package bisq.core.trade.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/26e2676268f409aa12d9d9e5a814c587c4a8a01b">Rename ProcessModelServiceProvider to Provider</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/c282b700010479b5c67f978eb434b5d41529f669">Rename txID to txId</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/30dd5683ef08083949252f4924065389f4a4bc15">Move createoffer package inside bisq.desktop.main.offer.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/0cd0e16b53870ff663c357e9e78adf92be157dbc">Move takeoffer package inside bisq.desktop.main.offer.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/4169a8719bf8984e6e1afd8fe67eca987682e807">Move MutableOffer view classes into bisq.desktop.main.offer.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/a2a7e87af5ef944f17dbdc2e0a531a20fd7a854e">Move OfferDataModel, OfferViewUtil into bisq.desktop.main.offer.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/a9f4bb76b687f724db84b37f69603b9289a5ea6a">Rename FeeUtil to OfferViewModelUtil</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/1e03aae2ac81ada51fc8a319b83be5209a1684c7">Move OfferViewModelUtil into bisq.desktop.main.offer.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/72284d7d9f7c25236010a88389e88c218012248d">Cleanups, refromatting, add final qualifier</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/71eec7b2e0c98b8b036d4ab3fa52cc4701e0fc30">Move TradingPeer to package bisq.core.trade.protocol.bisq_v1.model</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/e1efc5e96fc6909e28446876c36393cc3e80a4e4">Make setPaymentStartedAckMessage and setDepositTxSentAckMessage public</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/760732f03a2cff68590935bd92f63ac81793f823">Move ProcessModel to package bisq.core.trade.protocol.bisq_v1.model</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/94d3638d9841c8653a5db40fa5b1c52fa3e3b0e4">Remove m52go bitcoin node</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/41d9d3f505516ed34c1f33d86952ef8f4d036d75">Move OfferPayload into package bisq.core.offer.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/edf5c3e097094f35e4f25c439416cff196afbf76">Move CreateOfferService into package bisq.core.offer.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/4341a7e0d2c5610baa95b09bdb82584b520bc776">Move MarketPriceNotAvailableException into package bisq.core.offer.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/042476a68a22ea95eb9faaa84eeed8594a6c3d06">Move MutableOfferPayloadFields into package bisq.core.offer.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/d9fd8a45f72d377e2ba04c95df1974aa44e36b87">Move TriggerPriceService into package bisq.core.offer.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/e348000cb16923ab1b973ad9aa1bb0d2f616cc16">Move TakeOfferModel into package bisq.core.offer.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/a2d1e8888d0c6274121428b86cdd39b32f3d6ba0">Move AvailabilityResult into package bisq.core.offer.availability</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/1badd699a4a6a82910701a89c5fbad4115985503">Move bisq.core.offer.messages package into package bisq.core.offer.availability</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/7197b316fccd63e2f0b66d27d167ea6cd0452c11">Move content of bisq.core.offer.placeoffer package into package bisq.core.offer.placeoffer.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/1b4c4871c0d03e00dbc07571ac120d2a3a9c534d">Rename OfferFilter to OfferFilterService</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/1e9b6065441d27873ad962920aed363ed9a25aa0">Move Contract, SellerAsMakerTrade, SellerAsTakerTrade, SellerTrade,</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/8b21b85c3e8fd20b8d5c541ee6ad6ee5e099a0c6">Make updateDepositTxFromWallet public</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/d42242762ffb448e8ebdda5e311602e6db60f1c7">Move Trade to bisq.core.trade.model.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/fc3177c23f06d16eed25408fe7064f5364b2e42f">Move MakerTrade and TakerTrade to bisq.core.trade.model package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/58cfcffeb970ffc81d9ba6979eb256892ce00ff2">Move Tradable to bisq.core.trade.model package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/3474a2b69520d52af239c79cbaa65135bdc776d5">Move TradableList to bisq.core.trade.model package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/d7b2e99e43a404c6121dcbb94a0acaf028037dbe">Make FluentProtocol.Event public</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/e3eea6350cb07f3c517e0fc148b4d771fff26afc">Make setup in FluentProtocol public</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/1b2e798faaa64fa19a3cd858c99c6af22d38fa99">Move protocol classes to bisq.core.trade.protocol.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/508296c2a3b609ab9166d250226271622f430d34">Move tasks package into bisq.core.trade.protocol.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/97906e05db34277a96631c4e4eeaef91dd732f04">Move TradingPeer into bisq.core.trade.protocol.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/cbf2822cdf422cfca7404a0cb4486f498bc8a171">Move messages package into bisq.core.trade.protocol.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/fd6934c4e3f1fd93744343bc7c1f907b7e981f8c">Move ClosedTradableManager, FailedTradesManager into bisq.core.trade.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/fe2871baa50c5f196e92458d38bdda53ab9b6d77">Rename CleanupMailboxMessages to CleanupMailboxMessagesService</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/e80cdf8ac7217ab0e2025be10e0feaa6dc8a5ee6">Move CleanupMailboxMessagesService, ClosedTradeUtil to package bisq.core.trade.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/956ffc902d2258199a07f96adaa91ff98ae2411a">Move TransactionResultHandler, TradeResultHandler to package bisq.core.trade.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/eacf446ab422352bb303eb9830b3dc03d9adc8e4">Move TradeDataValidation, DumpDelayedPayoutTx, TradeDataValidation, TradeUtil, TradeTxException to package bisq.core.trade.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/e1de502a9bf1aae7e87830096934ac6a1684665d">Rename ProcessModelServiceProvider to Provider</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/2733af955a3ec04d4311a18b691415933146b35c">Rename txID to txId</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/932c0f856aa36ee87cb55dbb3b4e11992ed2b13c">Move createoffer package inside bisq.desktop.main.offer.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/0efa0bd7cad6278faac96edc64f4008061a7998f">Move takeoffer package inside bisq.desktop.main.offer.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/601956dc1fe2927549ff7723ef8cd25f16f646ee">Move MutableOffer view classes into bisq.desktop.main.offer.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/9777005ec7e44b4efb123e7d5a9c48976bde2a81">Move OfferDataModel, OfferViewUtil into bisq.desktop.main.offer.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/4a9db790682506fdda88f6d31f5874fc473dba2e">Rename FeeUtil to OfferViewModelUtil</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/25bbad1f9c9f5383d8af6f64cbacdb74df2b1d01">Move OfferViewModelUtil into bisq.desktop.main.offer.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/777287af95cfd791389b0cdbf9eecf9b98913496">Cleanups, refromatting, add final qualifier</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/401880b64e8f8645e42d6a34179fcc71000c7363">Move TradingPeer to package bisq.core.trade.protocol.bisq_v1.model</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/afed78813d3d81c1ca4d63adac6ca0d5cffb1741">Make setPaymentStartedAckMessage and setDepositTxSentAckMessage public</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/734d429cc9612709bcee8c0e4784070406daf731">Move ProcessModel to package bisq.core.trade.protocol.bisq_v1.model</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/dca0c93f477f66da22f6eeba2532fffb844dde90">Cleanups</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/e75296557739f6b8ae86bd3004781fd268036a9e">Add linebreak in error popup</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/9f3034e91c83559c5a37b7c235c0c997a0e84042">Fix layout/text issues</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/dc82fbabab24ab385b085afdfe0ef88c62849970">Increase visibility</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/8768345b74148ab49f57cefef9952bb2ad5667be">Remove Inject annotation at abstract classes</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/d1d1706a7f05539b930db6437f20b6934576515e">Add delegate methods to offer</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/dfbc746d5b4dc3fd4c115adb34498089e744918d">Move Offer.Direction one level up and rename to OfferDirection</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/6cf0a7c126fb2bf43ca004bb139b5b856ad1d67e">Rename paymentMethod.isAsset to paymentMethod.isBlockchain</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/dad19ba1c174087e3f29f66577739409e32bc544">Add isFiat and isAltcoin methods.</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/88198be7ffbfe00854207e3f9e6e907ffd7581b2">Rename availableConfirmedBalance to availableBalance</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/d4bb026e3e7ce64710a947557962e0f4e32bfc26">Only check for localhost btc node if mainnet</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/f8751a8c4d5974068864f90729c889411f86ae73">Make TxConfidenceListener and its onTransactionConfidenceChanged method abstract</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/a927bea71f236769af7d5c3bba37488fd58370ec">Add scriptTypeId to RawTransactionInput</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/75072ebc26acef94bfe15eba5eaa3c152c63a416">Add deprecated annotation, null checks and comment to getRawInputFromTransactionInput</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/561ebe940e369aaa54668fa50751c154cc047764">Move test classes into bisq.desktop.main.offer.bisq_v1.createoffer</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/8ee255412fe1fe5ea023654614d99f05837afed5">Merge branch &#39;bsq-swap-low-risk-refactorings&#39; into wip-merge2</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/559bc58ec23b942b0b90a2325800d40e5302af90">Fix merge issues</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/34c4eefb590c0678b3523a70e0673efdba109fea">Add allowSpendMyOwnUnconfirmedTxOutputs flag to BsqCoinSelector</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/47572888e7711f176b6018c9561d8b11447afff1">Add isMine method. Add error logs</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/0f6364d2bd4625619e6dbcce925efb0565db4639">Inline TransactionWitness</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/e582ffddad7db84481b76f6a518fc13c5796cdc2">Add new methods</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/54e81d14731ee57a8ede3e5857e6b4c73f134ce2">Add signTx and verifyNonDustTxo methods</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/5f8bc834f798e94e25a0540a154c33598eb4be76">Remove unused signTx method</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/d95356be211786d67ebd47e27e8801e33f3197e6">Add verifiedBalance field.</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/cfc404b4c0ee8d495c167446e58e88ad152d1407">Rename signTx to signTxAndVerifyNoDustOutputs (no code change)</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/82c1be1d97f57c0bd2b2380125468d80d607bbd7">Change log level</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/c15fc0c0a7a1d33db8a334881d03e9ee1185ce47">Add comment, cleanups</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/d7f1b00221ac07b914cd37302888edb357f5bc71">Rename processModel.getTradingPeer to getTradePeer</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/02d7dfdaefeeaea5aaadf5a85596abb1c500d2cb">Only print stack trace if dev mode</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/9e4be1367a399d6d24fe075409331ff028a004fc">Change log level</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/8d2579866a61508f3c1e5cd7559763006ef941e6">Replace Value annotation with Getter and EqualsAndHashCode</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/d976f11e09db208a9abceca4bb265c18e17713b6">Add methods</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/a3b3d561ecc0685e017e1f498715326de4dee570">Simplify</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/9d106468b04f53fae29b76f80e7d95575a6afb5c">Move getRandomOfferId method to OfferUtil</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/e061d6a476e78b7368ec88952bf27bf2e9a6b0f3">Replace Value with Getter</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/5b0e9ab92fbe8b62ef612e5f8cab27d17a33f2c4">Rename trade.getPhase to getTradePhase</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/544dd895fc279926e11e23565286dff2de0d9dd9">Rename trade.getState to getTradeState</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/12fff5403d9d13045726ee08410fcb2f3d3706f6">Cleanup</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/2440d7234d2d7fc83e772e0a2ff9c52128cd3f6f">Extract methods, Cleanups</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/4cb074694da118b3f62c4e21ea7b92d197e5e1bc">Extract methods, cleanups. Rename methods and vars</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/7211f892e13041979784ebaa2896f45975a2982c">Add exclude fields to EqualsAndHashCode</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/07883e9b8ba1fc5b5f4de146e28c0542c8da21b9">Rename trade.getPhase to getTradePhase</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/0148a36566c554c3c898d8fc8e14ba60d7abd723">Extract to method in TradeUtil</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/10516407de34fc3d07255ec246dac99bce07151a">Use early return. cleanup</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/8219bf84070dab6cb4ce448c94ff26da7b114bc2">Extract method. Rename vars</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/ee374c3c39720e540a79311d48a1d6daa93d8abd">Cleanups, apply rename of getTradePhase</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/e940f6f9f0a06059ec0e003dfbc4a01b775598f4">Add method. Dont return null in case of no amount but min fee</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/19aabba12c701f5aa311dd4d445484d711953ef9">Add method. cleanups</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/1c0b52cd31d27c1bf66f5cf6eb87fc75efb2aaca">Move OfferDirection from bisq.core.offer.bisq_v1 to bisq.core.offer</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/07354191a6bddb4ca5ff3bcee8a51c37ee6a43c5">Remove handling of BundleOfEnvelopes in send method.</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/b80b6ec836d778ef3a1a11e06d2a8f024931d947">Cleanups</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/23af4558b5e624d02a7457d9c217609555b1d641">Add filterPredicate</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/2e384ede59ec232e5b9e390a465eaec51f7f0fff">Make onDeleteAccount more clear</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/9d8c705104f53aefac8018e08cedc7ad35d1515e">Only add delay if not devmode</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/d2851574425c1fe587cdca81399c7b5bb325a463">Reduce visibility</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/8bb42e1421d4c6ee5e14cb91d53ac699e84e08fb">Add methods, move field up</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/1aa5e7053d70f2e25311481a0318698b478e72bf">Add method</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/8ac40a3e0cd34262d302ce5f8c59ac52411ca3c1">Add style</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/c60df6e978866162e16dcef6c6801419a0eacd3c">Add linebreak (no code change)</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/9fb6a6ca9f9666f805ee6bea4882c45df10cfaa1">Add isNotPublished method (will be combined later with bsq swap checks)</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/cfae096c1f14952cebdb56edc909b354c2585e49">Add null checks, extract variables, cleanups</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/2ae1860dac9729c71e03a4649c6f8364fad26a5a">Move tests to package bisq.desktop.main.offer.bisq_v1.createoffer</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/080dc3e8a1cfc17004b4df32811af9fe81c91c54">Merge branch &#39;chimp-bsq-swap&#39; into wip-merge021.10</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/ab6e4e1b8f3fcb7f2f4bc0547980d7fc6724fec9">Dummy commit to enforce rebuild at CI</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/5412f8b669a13a6da70e8f3e365aeb64d56fa3be">Merge branch &#39;chimp-bsq-swap&#39; into bsq-swap-low-risk-refactorings</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/c920da36c08d679de8d1ef47b171e79c5765c2aa">Add abstract classes and interfaces. Let ProcessModel and TradingPeer extend those.</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/8cd85a77c148a7d01de9b41d25832ca0af6f334e">Let Trade extend TradeModel</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/dcd0101c52142dd534fe9bd738d766e3f9b5fd56">Generify TradeResultHandler</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/5d687bd064ab3754ffcf8614b5de982114823baf">Use TradeModel and ProtocolModel in TradeTaskRunner, TradeTask, TradeProtocol and FluentProtocol</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/308bb687c552573cd371c372dea4d93c8f1aa22d">Use TradeModel</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/453229e3708c0e9742b710b87cbdfd30db1425ad">Impl. onAckMessage. Add fields for concrete types</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/c0e70b81ef641801a84ef37188e57e20bcdc1306">Use TradeModel in trade domain</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/d063aff5bfd8bfc3425cccd1b0c5fbdb44ea09e1">Let OfferPayload extend OfferPayloadBase</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/b194960c63644761eb55bc2efa036e3fe7853949">Use TradeModel instead of Trade where appropriate.</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/14765d6caa56fe1460f22c0fa0c7d0002945c860">Move protobuf OfferPayload.Direction to OfferDirection</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/611b9446094ac0389a49b2daccbb7b95784b714e">Move protobuf OfferPayload.Direction to OfferDirection</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/2f40eddae868c6294e44479738ad140222bcb413">Use bitcoinj 42bbae9 (with fix required for bsq swaps)</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/63c385bbba238b468bf675ff592e8db507af153b">Add support for RemoveDataMessage in testCapability</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/54f17b00af64c9aa706c3c39322e4c353b3f296d">Cleanups</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/ebfd1b557412b419b96adb4647547970f713ed30">Remove todo</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/9c5620276ea8ae015ad993379d3f972981edaf81">Add BSQ swap code</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/559491ebd1f22ab5cf1286458ac16978e5ee4606">Merge branch &#39;master_upstream&#39; into chimp-bsq-swap</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/cff719b3e8df4f0d67b77ca08d6b00fdef16c09a">Merge branch &#39;chimp-bsq-swap&#39; into bsq-swap-low-risk-refactorings</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/3558d0171c60a44dc21ed2814d95c85274072655">Merge branch &#39;bsq-swap-low-risk-refactorings&#39; into bsq-swap-impl</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/6d9d0f75732cdae03265574c106b2daa51ab45b5">Apply codacy review suggestions</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/fdfb029b0d038343448605c7c549d65be6a390c2">Move Utilities.objectToJson to JsonUtil.objectToJson</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/4ab1ee3d5865c7ab4d5bf84f48bfef35da080aa2">Add custom json serializer for OfferPayload</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/348bf3bda64ad936ce4f63f4adbc4bb6abae1542">Update text</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/238a7dc1f5d13d091425c5e1fdee990a68a4cc54">Remove missingFundsListener after successful take offer</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/b39396858097dbefd3296aab81675e7978a819e1">Change log level</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/a77d65b4db0f29a663bccbc951f63ea6936fc2b7">Improve BSQ swap offer details window</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/7dfb2617625f595e16e45f3d1abd0c52b329d654">Update dev mode values for create offer</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/c86801fa03aa6e1265bb62460d78084d8a0d8904">Workaround for weird JFXComboBox bug</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/395d93975bbe68f9cbf75f739941f43b22286032">Add default value if no filter is available</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/f970f09798eb13cf92b7e58b8d8022d17b30d7fc">Add log</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/904fa07eae7967be32a6eb635af7651ff5030754">Reset address entry if BSQ swap offer is used for create offer</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/0662fa783c2cfa59f475c152bca76704021dd6aa">Use checkNotNull and checkArgument for checking pre conditions</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/7c389e312dc1bcd0a2de1d1d67b4ff7ef602e5f2">Add requestPersistence call.</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/ecdda101ad19ce0e258a5e49a8cdaa8d4ed4fc1f">Improve naming, comments, extract variables</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/b9756dec2053a978886cccf276448370c2df613d">Improve naming, comments, extract variables, inline method</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/b92044b201b20e8eb5b144f97a4e6a5c78462586">Remove redundant complete call</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/89e7b64c062791146afdb3296ebcf99c4f385cf0">Improve naming, cleanups, use static imports</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/d30c943ae848731c6ca1d901a4eb80af7d567658">Fix linebreak</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/77b8ae778f231d48992623f5fd22dc9e2a8bbc1b">Combine nested if statements</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/363e0a2a7fca30731b240da4193a5f9d8a4b7190">Revert behaviour to old version in master to return null if amount is null.</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/1e7de9e8b75aead8c2d6cc6b87b69a84b3a193cb">Cleanups</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/3ed69147bb5190a7a95a44a7f62c059ff74fc0d6">Cleanups, improve logs</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/12f46ed58f00fef4ffc3b472ca3207d3a2967e98">Rename onChangeAfterBatchProcessing to onDaoStateHashesChanged</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/931e4109174598af6150b2db18878fe5e4eb00f1">Add method. Inline var</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/f144820ff66479c6b5d21cbe6521ef1fdb54de06">Fix getCycleIndex method</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/27e1da4a18fa92b5b2398fb02cc980abd552b1f6">Improve GcUtil</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/5f67b1e2e1961149e343ad25612659ff6d9e411d">Add useFullModeDaoMonitor field to PreferencesPayload</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/ed150f6e415c10f2f898f353e1ead8205fb3ff65">Remove prevHash from StateHash classes (the prevHash was only used for display.</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/18c87f2ae48ccd160c732968405d506838f0354b">Add daoStateBlockChainNotConnecting property (impl. will come in other commits)</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/0255b5cbf69a97aa2db3e7c016b2d967c59e811d">Delete DaoEventCoordinator (we will handle coordination in</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/fcea83d5238daa035cea8d07b9d0ff5ef639aaf7">Add pruneStore method</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5782/commits/32d9242059ed8cc617266876322080444740a68f">Implement new behaviour for dao state monitoring and snapshotting</a>

-- File Changes --

    M apitest/scripts/trade-simulation-utils.sh (2)
    M apitest/src/test/java/bisq/apitest/ApiTestCase.java (10)
    M apitest/src/test/java/bisq/apitest/method/offer/AbstractOfferTest.java (10)
    A apitest/src/test/java/bisq/apitest/method/offer/BsqSwapOfferTest.java (172)
    M apitest/src/test/java/bisq/apitest/method/offer/CancelOfferTest.java (2)
    M apitest/src/test/java/bisq/apitest/method/offer/CreateBSQOffersTest.java (4)
    M apitest/src/test/java/bisq/apitest/method/offer/CreateOfferUsingFixedPriceTest.java (4)
    M apitest/src/test/java/bisq/apitest/method/offer/CreateOfferUsingMarketPriceMarginTest.java (4)
    M apitest/src/test/java/bisq/apitest/method/offer/EditOfferTest.java (4)
    M apitest/src/test/java/bisq/apitest/method/offer/ValidateCreateOfferTest.java (2)
    A apitest/src/test/java/bisq/apitest/method/trade/BsqSwapTradeTest.java (163)
    A apitest/src/test/java/bisq/apitest/method/trade/BsqSwapTradeTestLoop.java (65)
    M apitest/src/test/java/bisq/apitest/method/trade/ExpectedProtocolStatus.java (2)
    M apitest/src/test/java/bisq/apitest/method/trade/TakeBuyBSQOfferTest.java (16)
    M apitest/src/test/java/bisq/apitest/method/trade/TakeBuyBTCOfferTest.java (10)
    M apitest/src/test/java/bisq/apitest/method/trade/TakeBuyBTCOfferWithNationalBankAcctTest.java (10)
    M apitest/src/test/java/bisq/apitest/method/trade/TakeSellBSQOfferTest.java (18)
    M apitest/src/test/java/bisq/apitest/method/trade/TakeSellBTCOfferTest.java (12)
    M apitest/src/test/java/bisq/apitest/method/wallet/BsqWalletTest.java (6)
    M apitest/src/test/java/bisq/apitest/method/wallet/WalletTestUtil.java (6)
    M apitest/src/test/java/bisq/apitest/scenario/LongRunningOfferDeactivationTest.java (4)
    M apitest/src/test/java/bisq/apitest/scenario/bot/script/BotScriptGenerator.java (5)
    M build.gradle (4)
    M cli/src/main/java/bisq/cli/DirectionFormat.java (4)
    M cli/src/main/java/bisq/cli/GrpcClient.java (71)
    M cli/src/main/java/bisq/cli/opts/AbstractMethodOptionParser.java (2)
    M cli/src/main/java/bisq/cli/opts/CreateCryptoCurrencyPaymentAcctOptionParser.java (14)
    M cli/src/main/java/bisq/cli/opts/OptLabel.java (1)
    M cli/src/main/java/bisq/cli/request/OffersServiceRequest.java (58)
    M cli/src/main/java/bisq/cli/request/TradesServiceRequest.java (8)
    M common/src/main/java/bisq/common/app/Capability.java (3)
    M common/src/main/java/bisq/common/app/Version.java (2)
    M common/src/main/java/bisq/common/config/ConfigFileEditor.java (2)
    A common/src/main/java/bisq/common/crypto/HashCashService.java (181)
    A common/src/main/java/bisq/common/crypto/ProofOfWork.java (122)
    A common/src/main/java/bisq/common/crypto/ProofOfWorkService.java (156)
    M common/src/main/java/bisq/common/persistence/PersistenceManager.java (2)
    M common/src/main/java/bisq/common/util/GcUtil.java (24)
    M common/src/main/java/bisq/common/util/Utilities.java (26)
    A common/src/test/java/bisq/common/crypto/HashCashServiceTest.java (84)
    A common/src/test/java/bisq/common/crypto/ProofOfWorkServiceTest.java (81)
    M core/src/main/java/bisq/core/account/witness/AccountAgeWitnessService.java (25)
    M core/src/main/java/bisq/core/account/witness/AccountAgeWitnessUtils.java (2)
    M core/src/main/java/bisq/core/api/CoreApi.java (83)
    M core/src/main/java/bisq/core/api/CoreOffersService.java (132)
    M core/src/main/java/bisq/core/api/CorePaymentAccountsService.java (25)
    M core/src/main/java/bisq/core/api/CoreTradesService.java (50)
    M core/src/main/java/bisq/core/api/CoreWalletsService.java (5)
    M core/src/main/java/bisq/core/api/model/BsqBalanceInfo.java (15)
    A core/src/main/java/bisq/core/api/model/BsqSwapOfferInfo.java (227)
    A core/src/main/java/bisq/core/api/model/BsqSwapTradeInfo.java (323)
    M core/src/main/java/bisq/core/api/model/OfferInfo.java (4)
    M core/src/main/java/bisq/core/api/model/TradeInfo.java (10)
    M core/src/main/java/bisq/core/app/BisqExecutable.java (2)
    M core/src/main/java/bisq/core/app/BisqSetup.java (10)
    M core/src/main/java/bisq/core/app/DomainInitialisation.java (18)
    M core/src/main/java/bisq/core/app/P2PNetworkSetup.java (22)
    M core/src/main/java/bisq/core/app/misc/AppSetupWithP2PAndDAO.java (7)
    M core/src/main/java/bisq/core/app/misc/ExecutableForAppWithP2p.java (2)
    M core/src/main/java/bisq/core/btc/Balances.java (6)
    M core/src/main/java/bisq/core/btc/TxFeeEstimationService.java (8)
    M core/src/main/java/bisq/core/btc/listeners/BsqBalanceListener.java (2)
    M core/src/main/java/bisq/core/btc/listeners/TxConfidenceListener.java (17)
    M core/src/main/java/bisq/core/btc/model/RawTransactionInput.java (79)
    M core/src/main/java/bisq/core/btc/nodes/BtcNodes.java (6)
    M core/src/main/java/bisq/core/btc/wallet/BsqCoinSelector.java (16)
    M core/src/main/java/bisq/core/btc/wallet/BsqTransferService.java (2)
    M core/src/main/java/bisq/core/btc/wallet/BsqWalletService.java (92)
    M core/src/main/java/bisq/core/btc/wallet/BtcWalletService.java (29)
    M core/src/main/java/bisq/core/btc/wallet/TradeWalletService.java (150)
    M core/src/main/java/bisq/core/btc/wallet/WalletService.java (57)
    D core/src/main/java/bisq/core/dao/DaoEventCoordinator.java (69)
    M core/src/main/java/bisq/core/dao/DaoFacade.java (13)
    M core/src/main/java/bisq/core/dao/DaoModule.java (1)
    M core/src/main/java/bisq/core/dao/DaoSetup.java (9)
    M core/src/main/java/bisq/core/dao/governance/asset/AssetService.java (2)
    M core/src/main/java/bisq/core/dao/governance/blindvote/MyBlindVoteListService.java (2)
    M core/src/main/java/bisq/core/dao/governance/bond/lockup/LockupTxService.java (2)
    M core/src/main/java/bisq/core/dao/governance/bond/unlock/UnlockTxService.java (2)
    M core/src/main/java/bisq/core/dao/governance/period/CycleService.java (3)
    M core/src/main/java/bisq/core/dao/governance/proofofburn/ProofOfBurnService.java (2)
    M core/src/main/java/bisq/core/dao/governance/proposal/BaseProposalFactory.java (2)
    M core/src/main/java/bisq/core/dao/governance/votereveal/VoteRevealService.java (2)
    M core/src/main/java/bisq/core/dao/monitoring/BlindVoteStateMonitoringService.java (2)
    M core/src/main/java/bisq/core/dao/monitoring/DaoStateMonitoringService.java (274)
    M core/src/main/java/bisq/core/dao/monitoring/ProposalStateMonitoringService.java (2)
    M core/src/main/java/bisq/core/dao/monitoring/model/BlindVoteStateHash.java (6)
    M core/src/main/java/bisq/core/dao/monitoring/model/DaoStateBlock.java (6)
    M core/src/main/java/bisq/core/dao/monitoring/model/DaoStateHash.java (24)
    M core/src/main/java/bisq/core/dao/monitoring/model/ProposalStateHash.java (6)
    M core/src/main/java/bisq/core/dao/monitoring/model/StateBlock.java (4)
    M core/src/main/java/bisq/core/dao/monitoring/model/StateHash.java (6)
    M core/src/main/java/bisq/core/dao/monitoring/network/StateNetworkService.java (10)
    M core/src/main/java/bisq/core/dao/node/explorer/ExportJsonFilesService.java (7)
    M core/src/main/java/bisq/core/dao/node/full/FullNode.java (5)
    M core/src/main/java/bisq/core/dao/node/lite/LiteNode.java (2)
    M core/src/main/java/bisq/core/dao/node/lite/network/LiteNodeNetworkService.java (2)
    M core/src/main/java/bisq/core/dao/node/parser/BlockParser.java (9)
    M core/src/main/java/bisq/core/dao/state/DaoStateService.java (12)
    M core/src/main/java/bisq/core/dao/state/DaoStateSnapshotService.java (162)
    M core/src/main/java/bisq/core/dao/state/storage/DaoStateStorageService.java (12)
    M core/src/main/java/bisq/core/filter/Filter.java (44)
    M core/src/main/java/bisq/core/filter/FilterManager.java (28)
    M core/src/main/java/bisq/core/locale/Res.java (6)
    M core/src/main/java/bisq/core/notifications/alerts/TradeEvents.java (2)
    M core/src/main/java/bisq/core/notifications/alerts/market/MarketAlerts.java (6)
    M core/src/main/java/bisq/core/offer/Offer.java (252)
    M core/src/main/java/bisq/core/offer/OfferBookService.java (40)
    A core/src/main/java/bisq/core/offer/OfferDirection.java (33)
    R core/src/main/java/bisq/core/offer/OfferFilterService.java (17)
    M core/src/main/java/bisq/core/offer/OfferForJson.java (8)
    A core/src/main/java/bisq/core/offer/OfferPayloadBase.java (147)
    M core/src/main/java/bisq/core/offer/OfferRestrictions.java (4)
    M core/src/main/java/bisq/core/offer/OfferUtil.java (124)
    M core/src/main/java/bisq/core/offer/OpenOffer.java (43)
    M core/src/main/java/bisq/core/offer/OpenOfferManager.java (277)
    R core/src/main/java/bisq/core/offer/availability/AvailabilityResult.java (2)
    M core/src/main/java/bisq/core/offer/availability/OfferAvailabilityModel.java (2)
    M core/src/main/java/bisq/core/offer/availability/OfferAvailabilityProtocol.java (4)
    R core/src/main/java/bisq/core/offer/availability/messages/OfferAvailabilityRequest.java (6)
    R core/src/main/java/bisq/core/offer/availability/messages/OfferAvailabilityResponse.java (8)
    R core/src/main/java/bisq/core/offer/availability/messages/OfferMessage.java (2)
    M core/src/main/java/bisq/core/offer/availability/tasks/ProcessOfferAvailabilityResponse.java (4)
    M core/src/main/java/bisq/core/offer/availability/tasks/SendOfferAvailabilityRequest.java (2)
    R core/src/main/java/bisq/core/offer/bisq_v1/CreateOfferService.java (23)
    R core/src/main/java/bisq/core/offer/bisq_v1/MarketPriceNotAvailableException.java (2)
    R core/src/main/java/bisq/core/offer/bisq_v1/MutableOfferPayloadFields.java (2)
    R core/src/main/java/bisq/core/offer/bisq_v1/OfferPayload.java (244)
    R core/src/main/java/bisq/core/offer/bisq_v1/TakeOfferModel.java (4)
    R core/src/main/java/bisq/core/offer/bisq_v1/TriggerPriceService.java (29)
    A core/src/main/java/bisq/core/offer/bsq_swap/BsqSwapOfferModel.java (392)
    A core/src/main/java/bisq/core/offer/bsq_swap/BsqSwapOfferPayload.java (169)
    A core/src/main/java/bisq/core/offer/bsq_swap/BsqSwapTakeOfferModel.java (135)
    A core/src/main/java/bisq/core/offer/bsq_swap/OpenBsqSwapOffer.java (211)
    A core/src/main/java/bisq/core/offer/bsq_swap/OpenBsqSwapOfferService.java (396)
    R core/src/main/java/bisq/core/offer/placeoffer/bisq_v1/PlaceOfferModel.java (2)
    R core/src/main/java/bisq/core/offer/placeoffer/bisq_v1/PlaceOfferProtocol.java (14)
    R core/src/main/java/bisq/core/offer/placeoffer/bisq_v1/tasks/AddToOfferBook.java (4)
    R core/src/main/java/bisq/core/offer/placeoffer/bisq_v1/tasks/CheckNumberOfUnconfirmedTransactions.java (4)
    R core/src/main/java/bisq/core/offer/placeoffer/bisq_v1/tasks/CreateMakerFeeTx.java (6)
    R core/src/main/java/bisq/core/offer/placeoffer/bisq_v1/tasks/ValidateOffer.java (8)
    A core/src/main/java/bisq/core/offer/placeoffer/bsqswap/PlaceBsqSwapOfferModel.java (46)
    A core/src/main/java/bisq/core/offer/placeoffer/bsqswap/PlaceBsqSwapOfferProtocol.java (83)
    A core/src/main/java/bisq/core/offer/placeoffer/bsqswap/tasks/AddBsqSwapOfferToOfferBook.java (55)
    A core/src/main/java/bisq/core/offer/placeoffer/bsqswap/tasks/ValidateBsqSwapOffer.java (80)
    A core/src/main/java/bisq/core/payment/BsqSwapAccount.java (50)
    M core/src/main/java/bisq/core/payment/PaymentAccountFactory.java (2)
    A core/src/main/java/bisq/core/payment/payload/BsqSwapAccountPayload.java (70)
    M core/src/main/java/bisq/core/payment/payload/PaymentMethod.java (21)
    M core/src/main/java/bisq/core/proto/CoreProtoResolver.java (3)
    M core/src/main/java/bisq/core/proto/ProtoDevUtil.java (12)
    M core/src/main/java/bisq/core/proto/network/CoreNetworkProtoResolver.java (53)
    M core/src/main/java/bisq/core/proto/persistable/CorePersistenceProtoResolver.java (2)
    M core/src/main/java/bisq/core/provider/mempool/MempoolService.java (4)
    M core/src/main/java/bisq/core/setup/CoreNetworkCapabilities.java (3)
    M core/src/main/java/bisq/core/setup/CorePersistedDataHost.java (6)
    M core/src/main/java/bisq/core/support/dispute/Dispute.java (2)
    M core/src/main/java/bisq/core/support/dispute/DisputeListService.java (2)
    M core/src/main/java/bisq/core/support/dispute/DisputeManager.java (10)
    M core/src/main/java/bisq/core/support/dispute/agent/MultipleHolderNameDetection.java (2)
    M core/src/main/java/bisq/core/support/dispute/arbitration/ArbitrationManager.java (8)
    M core/src/main/java/bisq/core/support/dispute/mediation/MediationManager.java (10)
    M core/src/main/java/bisq/core/support/dispute/refund/RefundManager.java (4)
    M core/src/main/java/bisq/core/support/traderchat/TradeChatSession.java (6)
    M core/src/main/java/bisq/core/support/traderchat/TraderChatManager.java (9)
    M core/src/main/java/bisq/core/trade/TradeManager.java (333)
    M core/src/main/java/bisq/core/trade/TradeModule.java (4)
    R core/src/main/java/bisq/core/trade/bisq_v1/CleanupMailboxMessagesService.java (12)
    R core/src/main/java/bisq/core/trade/bisq_v1/ClosedTradableManager.java (17)
    R core/src/main/java/bisq/core/trade/bisq_v1/ClosedTradeUtil.java (14)
    R core/src/main/java/bisq/core/trade/bisq_v1/DumpDelayedPayoutTx.java (9)
    R core/src/main/java/bisq/core/trade/bisq_v1/FailedTradesManager.java (17)
    R core/src/main/java/bisq/core/trade/bisq_v1/TradeDataValidation.java (3)
    R core/src/main/java/bisq/core/trade/bisq_v1/TradeResultHandler.java (8)
    R core/src/main/java/bisq/core/trade/bisq_v1/TradeTxException.java (2)
    R core/src/main/java/bisq/core/trade/bisq_v1/TradeUtil.java (40)
    R core/src/main/java/bisq/core/trade/bisq_v1/TransactionResultHandler.java (2)
    A core/src/main/java/bisq/core/trade/bsq_swap/BsqSwapCalculation.java (245)
    A core/src/main/java/bisq/core/trade/bsq_swap/BsqSwapTakeOfferRequestVerification.java (106)
    A core/src/main/java/bisq/core/trade/bsq_swap/BsqSwapTradeManager.java (119)
    R core/src/main/java/bisq/core/trade/model/MakerTrade.java (2)
    R core/src/main/java/bisq/core/trade/model/TakerTrade.java (2)
    R core/src/main/java/bisq/core/trade/model/Tradable.java (2)
    R core/src/main/java/bisq/core/trade/model/TradableList.java (18)
    A core/src/main/java/bisq/core/trade/model/TradeModel.java (111)
    A core/src/main/java/bisq/core/trade/model/TradePhase.java (28)
    A core/src/main/java/bisq/core/trade/model/TradeState.java (28)
    R core/src/main/java/bisq/core/trade/model/bisq_v1/BuyerAsMakerTrade.java (6)
    R core/src/main/java/bisq/core/trade/model/bisq_v1/BuyerAsTakerTrade.java (6)
    R core/src/main/java/bisq/core/trade/model/bisq_v1/BuyerTrade.java (4)
    R core/src/main/java/bisq/core/trade/model/bisq_v1/Contract.java (7)
    R core/src/main/java/bisq/core/trade/model/bisq_v1/SellerAsMakerTrade.java (6)
    R core/src/main/java/bisq/core/trade/model/bisq_v1/SellerAsTakerTrade.java (6)
    R core/src/main/java/bisq/core/trade/model/bisq_v1/SellerTrade.java (4)
    R core/src/main/java/bisq/core/trade/model/bisq_v1/Trade.java (159)
    A core/src/main/java/bisq/core/trade/model/bsq_swap/BsqSwapBuyerAsMakerTrade.java (122)
    A core/src/main/java/bisq/core/trade/model/bsq_swap/BsqSwapBuyerAsTakerTrade.java (122)
    A core/src/main/java/bisq/core/trade/model/bsq_swap/BsqSwapBuyerTrade.java (59)
    A core/src/main/java/bisq/core/trade/model/bsq_swap/BsqSwapSellerAsMakerTrade.java (122)
    A core/src/main/java/bisq/core/trade/model/bsq_swap/BsqSwapSellerAsTakerTrade.java (123)
    A core/src/main/java/bisq/core/trade/model/bsq_swap/BsqSwapSellerTrade.java (56)
    A core/src/main/java/bisq/core/trade/model/bsq_swap/BsqSwapTrade.java (248)
    M core/src/main/java/bisq/core/trade/protocol/FluentProtocol.java (80)
    A core/src/main/java/bisq/core/trade/protocol/ProtocolModel.java (28)
    R core/src/main/java/bisq/core/trade/protocol/Provider.java (40)
    R core/src/main/java/bisq/core/trade/protocol/TradeMessage.java (2)
    A core/src/main/java/bisq/core/trade/protocol/TradePeer.java (27)
    M core/src/main/java/bisq/core/trade/protocol/TradeProtocol.java (109)
    M core/src/main/java/bisq/core/trade/protocol/TradeProtocolFactory.java (53)
    M core/src/main/java/bisq/core/trade/protocol/TradeTaskRunner.java (14)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/BuyerAsMakerProtocol.java (47)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/BuyerAsTakerProtocol.java (52)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/BuyerProtocol.java (42)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/DisputeProtocol.java (77)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/MakerProtocol.java (4)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/SellerAsMakerProtocol.java (49)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/SellerAsTakerProtocol.java (42)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/SellerProtocol.java (44)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/TakerProtocol.java (4)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/messages/CounterCurrencyTransferStartedMessage.java (2)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/messages/DelayedPayoutTxSignatureRequest.java (4)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/messages/DelayedPayoutTxSignatureResponse.java (4)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/messages/DepositTxAndDelayedPayoutTxMessage.java (2)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/messages/DepositTxMessage.java (4)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/messages/InputsForDepositTxRequest.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/messages/InputsForDepositTxResponse.java (3)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/messages/MediatedPayoutTxPublishedMessage.java (2)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/messages/MediatedPayoutTxSignatureMessage.java (2)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/messages/PayoutTxPublishedMessage.java (2)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/messages/PeerPublishedDelayedPayoutTxMessage.java (2)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/messages/RefreshTradeStateRequest.java (2)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/messages/ShareBuyerPaymentAccountMessage.java (2)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/messages/TradeMailboxMessage.java (4)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/messages/TraderSignedWitnessMessage.java (2)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/model/ProcessModel.java (35)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/model/TradingPeer.java (6)
    A core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/ApplyFilter.java (63)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/BroadcastPayoutTx.java (4)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/ProcessPeerPublishedDelayedPayoutTxMessage.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/SendMailboxMessageTask.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/SetupPayoutTxListener.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/TradeTask.java (9)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/VerifyPeersAccountAgeWitness.java (8)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/arbitration/PublishedDelayedPayoutTx.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/arbitration/SendPeerPublishedDelayedPayoutTxMessage.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer/BuyerFinalizesDelayedPayoutTx.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer/BuyerProcessDelayedPayoutTxSignatureRequest.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer/BuyerProcessDepositTxAndDelayedPayoutTxMessage.java (23)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer/BuyerProcessPayoutTxPublishedMessage.java (9)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer/BuyerSendCounterCurrencyTransferStartedMessage.java (18)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer/BuyerSendsDelayedPayoutTxSignatureResponse.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer/BuyerSendsShareBuyerPaymentAccountMessage.java (12)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer/BuyerSetupDepositTxListener.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer/BuyerSetupPayoutTxListener.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer/BuyerSignPayoutTx.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer/BuyerSignsDelayedPayoutTx.java (8)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer/BuyerVerifiesFinalDelayedPayoutTx.java (8)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer/BuyerVerifiesPreparedDelayedPayoutTx.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer_as_maker/BuyerAsMakerCreatesAndSignsDepositTx.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer_as_maker/BuyerAsMakerSendsInputsForDepositTxResponse.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer_as_taker/BuyerAsTakerCreatesDepositTxInputs.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer_as_taker/BuyerAsTakerSendsDepositTxMessage.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer_as_taker/BuyerAsTakerSignsDepositTx.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/maker/MakerCreateAndSignContract.java (29)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/maker/MakerProcessesInputsForDepositTxRequest.java (12)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/maker/MakerRemovesOpenOffer.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/maker/MakerSendsInputsForDepositTxResponse.java (12)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/maker/MakerSetsLockTime.java (8)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/maker/MakerVerifyTakerFeePayment.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/mediation/BroadcastMediatedPayoutTx.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/mediation/FinalizeMediatedPayoutTx.java (12)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/mediation/ProcessMediatedPayoutSignatureMessage.java (11)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/mediation/ProcessMediatedPayoutTxPublishedMessage.java (9)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/mediation/SendMediatedPayoutSignatureMessage.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/mediation/SendMediatedPayoutTxPublishedMessage.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/mediation/SetupMediatedPayoutTxListener.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/mediation/SignMediatedPayoutTx.java (12)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller/SellerBroadcastPayoutTx.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller/SellerCreatesDelayedPayoutTx.java (8)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller/SellerFinalizesDelayedPayoutTx.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller/SellerProcessCounterCurrencyTransferStartedMessage.java (13)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller/SellerProcessDelayedPayoutTxSignatureResponse.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller/SellerProcessShareBuyerPaymentAccountMessage.java (18)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller/SellerPublishesDepositTx.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller/SellerPublishesTradeStatistics.java (8)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller/SellerSendDelayedPayoutTxSignatureRequest.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller/SellerSendPayoutTxPublishedMessage.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller/SellerSendsDepositTxAndDelayedPayoutTxMessage.java (12)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller/SellerSignAndFinalizePayoutTx.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller/SellerSignsDelayedPayoutTx.java (8)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller_as_maker/SellerAsMakerCreatesUnsignedDepositTx.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller_as_maker/SellerAsMakerFinalizesDepositTx.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller_as_maker/SellerAsMakerProcessDepositTxMessage.java (11)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller_as_maker/SellerAsMakerSendsInputsForDepositTxResponse.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller_as_taker/SellerAsTakerCreatesDepositTxInputs.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller_as_taker/SellerAsTakerSignsDepositTx.java (14)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/taker/CreateTakerFeeTx.java (8)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/taker/TakerProcessesInputsForDepositTxResponse.java (14)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/taker/TakerPublishFeeTx.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/taker/TakerSendInputsForDepositTxRequest.java (12)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/5782.patch
https://github.com/bisq-network/bisq/pull/5782.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5782
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211026/31ecdcc1/attachment-0001.htm>

From notifications at github.com  Tue Oct 26 14:58:52 2021
From: notifications at github.com (chimp1984)
Date: Tue, 26 Oct 2021 05:58:52 -0700
Subject: [bisq-network/bisq] Redesign DAO state monitoring to avoid
 performance degradation (Issue #5779)
In-Reply-To: <bisq-network/bisq/issues/5779@github.com>
References: <bisq-network/bisq/issues/5779@github.com>
Message-ID: <bisq-network/bisq/issues/5779/951912926@github.com>

The PR https://github.com/bisq-network/bisq/pull/5782 is now ready for review.

### Here a specification of the new behaviour.

There is a new boolean field in PreferencePayload `useFullModeDaoMonitor` which indicates if the user wants to create the daoStateHashes by themself or if they take the hashes received from seed nodes during initial BSQ block parsing.

As descibed above that reduces dramatically costs for parsing. For 4000 blocks (about 1 month) it takes about 10-15 min. with useFullModeDaoMonitor is set to true and about 2-4 sec. if useFullModeDaoMonitor is set to false (default).

If `useFullModeDaoMonitor` is disabled (default for normal users) it behaves like following:
- User gets the missing BSQ blocks from seed nodes. Parsing is super fast (usually < 1 ms). We do not create the daoStateHash at each new block.
- Once initial BSQ block parsing is done we request the DaoStateHashes from the seed nodes from the last hash we have. The data is about 26 bytes for one hash (as we removed the prevHash its 50% smaller now)
- When we receive the hashes we create our `DaoStateBlock` from the peers `DaoStateHash` and mark the `isSelfCreated` field with false as information that we have not created the hash by ourself.
- We apply the checks and add the peer into the `peersMap`
- At the last block we do instead the hashing ourself by using our daoState and the previous hash (from the peer) and add the peer into our `peersMap` and apply the conflic checks
- After that we create a snapshot of our current state
- At each new block we create the hash now by ourself. The shortcut with the peers hashes was only applied during parsing to avoid the performance penalty
- The snapshotting will happen then after the next snapshot interval (20 blocks grid)
- If the user shuts down and starts up again they might see some of the new blocks where we had created the hash by ourself now delivered by the peer again. That is because the new blocks have not been added to the next snapshop yet (only after about 20 blocks have passed). But the important thing is that the current block is always created by ourself and by that we can verify that the created hash, based on the previous hash from the peer is not in conflict with the network.

If `useFullModeDaoMonitor` is enabled (default for headless apps like seed nodes) it behaves like following (behaviour has not really changed):
- User gets the missing BSQ blocks from seed nodes (if lite mode, otherwise from bitcoind rcp. Parsing is super fast (usually < 1 ms) but creating the hash at each new block takes about 100-200 ms. This is because the daoState data is already quite large. The `spentInfoMap` for instance has about 80k items. There are several steps which accumulate to the costs. 
    - 1. Serializing the daoState excluding the blockchain. 
    - 2. Adding the last block
    - 3. Concatenating the data as bytes with the previous hash
    - 4. Creating a hash out of that data
    - Some small part could be optimized but would improve overall cost by only 20-30%
- Spapshots are created at each snapshot interval. This is done on background threads but still has costs of about 1-4 sec. as the daoState is about 150 MB. Writing to disc includes serialisation and write operation, both are slow for that large data.
- After initial sync is done at each new block we create our hash and at each new snapshot interval we create a new snapshot
- We request the hashes from the seed nodes and apply the checks to see if we are in sync

### What are the drawbacks if `useFullModeDaoMonitor` is disabled?
- If all nodes have it disabled potential conflicts might not be discovered as there would be very few nodes which are actually creating the hash from their daoState. At least the seed nodes are running in enabled mode. But it would be good that developers and power users also have the mode enabled to get a bit more resiliance.
- As long there are seed nodes with correct hashes a potential conflict should be discovered. All seed nodes need to have the same hashes, if not we have to investigate and find out the issue. 

### Any other option to fix that performance problem?
The DAO state scaling problem need to be addressed as some point. When redesigning that there might be new options how to deal with it. But at the moment I don't see any easy solution and the suggested one here comes with quite low risks but improves the user experience a lot.





-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5779#issuecomment-951912926
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211026/273edfba/attachment.htm>

From notifications at github.com  Tue Oct 26 16:16:47 2021
From: notifications at github.com (metaltrance)
Date: Tue, 26 Oct 2021 07:16:47 -0700
Subject: [bisq-network/support] Fee reimbursement for trade 718499 (Issue
 #1014)
Message-ID: <bisq-network/support/issues/1014@github.com>


![image](https://user-images.githubusercontent.com/88378939/138896792-7d11f705-37b1-42c4-9e39-b0a29463deb3.png)

Maker:  3080165d189cc124eeb47e98d7e5902a1921e547381472a9294e08e77ea91651
Taker: 82cf5fb5d2198022b7ac85d83622bab513c1a005f806362ef30e328cddce8854
Deposit: bdb359dfc12679f7bfdab7bc7a38a88ece655c38aa7fa99f35f536556b8a79ef


Bisq version: v1.7.4
BTC address for reimbursement:
bc1q5m0ytwjswle9kgjghfdu67l85wrda820kfzgr5

Other notes:
Error: Deposit transaction is null or has unexpected input count


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/support/issues/1014
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211026/7f7566a0/attachment.htm>

From notifications at github.com  Tue Oct 26 16:54:36 2021
From: notifications at github.com (sqrrm)
Date: Tue, 26 Oct 2021 07:54:36 -0700
Subject: [bisq-network/roles] Arbitrator (formerly known as Refund Agent)
 (#93)
In-Reply-To: <bisq-network/roles/issues/93@github.com>
References: <bisq-network/roles/issues/93@github.com>
Message-ID: <bisq-network/roles/issues/93/952023189@github.com>

@refund-agent2 I'm trying to check the cycle29 reimbursement report but the refund tx links don't correspond to the amounts. Do you have this in a better format to help the review?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/roles/issues/93#issuecomment-952023189
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211026/b5c690e5/attachment.htm>

From notifications at github.com  Tue Oct 26 16:57:06 2021
From: notifications at github.com (MwithM)
Date: Tue, 26 Oct 2021 07:57:06 -0700
Subject: [bisq-network/growth] Compensation bot update - handle the nobot
 label (PR #252)
In-Reply-To: <bisq-network/growth/pull/252@github.com>
References: <bisq-network/growth/pull/252@github.com>
Message-ID: <bisq-network/growth/pull/252/c952025560@github.com>

Apparently, it works. https://github.com/bisq-network/compensation/issues/922

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/growth/pull/252#issuecomment-952025560
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211026/c4cce398/attachment.htm>

From notifications at github.com  Tue Oct 26 17:24:49 2021
From: notifications at github.com (chimp1984)
Date: Tue, 26 Oct 2021 08:24:49 -0700
Subject: [bisq-network/bisq] Update data stores for v1.7.5 (PR #5781)
In-Reply-To: <bisq-network/bisq/pull/5781@github.com>
References: <bisq-network/bisq/pull/5781@github.com>
Message-ID: <bisq-network/bisq/pull/5781/c952051431@github.com>

Test and compared with my standard node (both lite mode) and all have same hash.
 
<img width="2397" alt="Screenshot 2021-10-26 at 17 23 23" src="https://user-images.githubusercontent.com/54558767/138910435-b7c4904f-8455-4f62-af53-6886b19eecdc.png">
<img width="2393" alt="Screenshot 2021-10-26 at 17 23 29" src="https://user-images.githubusercontent.com/54558767/138910444-a02eb425-237a-450f-8c80-8e1ba09f0088.png">

<img width="2394" alt="Screenshot 2021-10-26 at 17 23 14" src="https://user-images.githubusercontent.com/54558767/138910420-dbd20964-d255-4c32-9c4c-c45fbe1df511.png">


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5781#issuecomment-952051431
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211026/15fcc4ce/attachment-0001.htm>

From notifications at github.com  Tue Oct 26 17:25:19 2021
From: notifications at github.com (chimp1984)
Date: Tue, 26 Oct 2021 08:25:19 -0700
Subject: [bisq-network/bisq] Update data stores for v1.7.5 (PR #5781)
In-Reply-To: <bisq-network/bisq/pull/5781@github.com>
References: <bisq-network/bisq/pull/5781@github.com>
Message-ID: <bisq-network/bisq/pull/5781/review/789566689@github.com>

@chimp1984 approved this pull request.

ACK



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5781#pullrequestreview-789566689
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211026/101be662/attachment.htm>

From notifications at github.com  Tue Oct 26 17:27:00 2021
From: notifications at github.com (chimp1984)
Date: Tue, 26 Oct 2021 08:27:00 -0700
Subject: [bisq-network/bisq] Update data stores for v1.7.5 (PR #5781)
In-Reply-To: <bisq-network/bisq/pull/5781@github.com>
References: <bisq-network/bisq/pull/5781@github.com>
Message-ID: <bisq-network/bisq/pull/5781/c952053458@github.com>

Tested and compared with my standard app.

<img width="2394" alt="Screenshot 2021-10-26 at 17 23 14" src="https://user-images.githubusercontent.com/54558767/138910870-4e9466c6-1c3a-4730-bcb3-1b63fcd686f3.png">
<img width="2397" alt="Screenshot 2021-10-26 at 17 23 23" src="https://user-images.githubusercontent.com/54558767/138910880-a0bc8de6-771f-44f0-b654-8ab177cda2ab.png">
<img width="2393" alt="Screenshot 2021-10-26 at 17 23 29" src="https://user-images.githubusercontent.com/54558767/138910882-fc01f80d-1e46-4f65-ab12-35edfdb64f29.png">


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5781#issuecomment-952053458
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211026/4e46d187/attachment.htm>

From notifications at github.com  Tue Oct 26 17:45:54 2021
From: notifications at github.com (refund-agent2)
Date: Tue, 26 Oct 2021 08:45:54 -0700
Subject: [bisq-network/roles] Arbitrator (formerly known as Refund Agent)
 (#93)
In-Reply-To: <bisq-network/roles/issues/93@github.com>
References: <bisq-network/roles/issues/93@github.com>
Message-ID: <bisq-network/roles/issues/93/952070694@github.com>

It has been edited just now.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/roles/issues/93#issuecomment-952070694
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211026/98a880f8/attachment.htm>

From notifications at github.com  Tue Oct 26 17:47:02 2021
From: notifications at github.com (jmacxx)
Date: Tue, 26 Oct 2021 08:47:02 -0700
Subject: [bisq-network/support] Fee reimbursement for trade 718499 (Issue
 #1014)
In-Reply-To: <bisq-network/support/issues/1014@github.com>
References: <bisq-network/support/issues/1014@github.com>
Message-ID: <bisq-network/support/issues/1014/952071679@github.com>

The deposit tx is valid.  You can continue the trade as normal, open mediation (ctrl-o), or [seek assistance on keybase](https://bisq.wiki/User_support#Via_Keybase_chat).  Whatever you're more comfortable with.

FYI that bug is https://github.com/bisq-network/bisq/issues/5494 which has a fix pending for next release, 1.7.5

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/support/issues/1014#issuecomment-952071679
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211026/7343697b/attachment.htm>

From notifications at github.com  Tue Oct 26 17:47:25 2021
From: notifications at github.com (m52go)
Date: Tue, 26 Oct 2021 08:47:25 -0700
Subject: [bisq-network/growth] Compensation bot update - handle the nobot
 label (PR #252)
In-Reply-To: <bisq-network/growth/pull/252@github.com>
References: <bisq-network/growth/pull/252@github.com>
Message-ID: <bisq-network/growth/pull/252/issue_event/5521663633@github.com>

Merged #252 into master.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/growth/pull/252#event-5521663633
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211026/e43135ed/attachment.htm>

From notifications at github.com  Tue Oct 26 17:52:38 2021
From: notifications at github.com (sqrrm)
Date: Tue, 26 Oct 2021 08:52:38 -0700
Subject: [bisq-network/bisq] Update data stores for v1.7.5 (PR #5781)
In-Reply-To: <bisq-network/bisq/pull/5781@github.com>
References: <bisq-network/bisq/pull/5781@github.com>
Message-ID: <bisq-network/bisq/pull/5781/c952076449@github.com>

ACK

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5781#issuecomment-952076449
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211026/de5d564b/attachment.htm>

From notifications at github.com  Tue Oct 26 17:52:46 2021
From: notifications at github.com (sqrrm)
Date: Tue, 26 Oct 2021 08:52:46 -0700
Subject: [bisq-network/bisq] Update data stores for v1.7.5 (PR #5781)
In-Reply-To: <bisq-network/bisq/pull/5781@github.com>
References: <bisq-network/bisq/pull/5781@github.com>
Message-ID: <bisq-network/bisq/pull/5781/issue_event/5521696740@github.com>

Merged #5781 into release/v1.7.5.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5781#event-5521696740
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211026/a2d34701/attachment-0001.htm>

From notifications at github.com  Tue Oct 26 17:54:02 2021
From: notifications at github.com (metaltrance)
Date: Tue, 26 Oct 2021 08:54:02 -0700
Subject: [bisq-network/support] Fee reimbursement for trade 718499 (Issue
 #1014)
In-Reply-To: <bisq-network/support/issues/1014@github.com>
References: <bisq-network/support/issues/1014@github.com>
Message-ID: <bisq-network/support/issues/1014/952078399@github.com>

The app wont let me continue the trade and tells me not to send any fiat.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/support/issues/1014#issuecomment-952078399
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211026/bd019afb/attachment.htm>

From notifications at github.com  Tue Oct 26 17:56:39 2021
From: notifications at github.com (metaltrance)
Date: Tue, 26 Oct 2021 08:56:39 -0700
Subject: [bisq-network/support] Fee reimbursement for trade 718499 (Issue
 #1014)
In-Reply-To: <bisq-network/support/issues/1014@github.com>
References: <bisq-network/support/issues/1014@github.com>
Message-ID: <bisq-network/support/issues/1014/952080619@github.com>

![image](https://user-images.githubusercontent.com/88378939/138916231-ac701e39-56cf-4fd9-a2f6-f62bd941b48a.png)


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/support/issues/1014#issuecomment-952080619
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211026/13e519e6/attachment.htm>

From notifications at github.com  Tue Oct 26 17:57:00 2021
From: notifications at github.com (jmacxx)
Date: Tue, 26 Oct 2021 08:57:00 -0700
Subject: [bisq-network/support] Fee reimbursement for trade 718499 (Issue
 #1014)
In-Reply-To: <bisq-network/support/issues/1014@github.com>
References: <bisq-network/support/issues/1014@github.com>
Message-ID: <bisq-network/support/issues/1014/952080950@github.com>

Yes, that is a symptom of the bug.  Try restarting Bisq, if the issue persists, open mediation (ctrl-o).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/support/issues/1014#issuecomment-952080950
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211026/f8981781/attachment.htm>

From notifications at github.com  Tue Oct 26 17:58:06 2021
From: notifications at github.com (metaltrance)
Date: Tue, 26 Oct 2021 08:58:06 -0700
Subject: [bisq-network/support] Fee reimbursement for trade 718499 (Issue
 #1014)
In-Reply-To: <bisq-network/support/issues/1014@github.com>
References: <bisq-network/support/issues/1014@github.com>
Message-ID: <bisq-network/support/issues/1014/952081934@github.com>

ok thanks

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/support/issues/1014#issuecomment-952081934
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211026/39e83476/attachment.htm>

From notifications at github.com  Tue Oct 26 18:00:07 2021
From: notifications at github.com (metaltrance)
Date: Tue, 26 Oct 2021 09:00:07 -0700
Subject: [bisq-network/support] Fee reimbursement for trade 718499 (Issue
 #1014)
In-Reply-To: <bisq-network/support/issues/1014@github.com>
References: <bisq-network/support/issues/1014@github.com>
Message-ID: <bisq-network/support/issues/1014/952083566@github.com>

It wont let me open mediation and tells me to do a SPV resync instead. I already did that but will try again.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/support/issues/1014#issuecomment-952083566
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211026/ebf24b61/attachment.htm>

From notifications at github.com  Tue Oct 26 18:11:35 2021
From: notifications at github.com (metaltrance)
Date: Tue, 26 Oct 2021 09:11:35 -0700
Subject: [bisq-network/support] Fee reimbursement for trade 718499 (Issue
 #1014)
In-Reply-To: <bisq-network/support/issues/1014@github.com>
References: <bisq-network/support/issues/1014@github.com>
Message-ID: <bisq-network/support/issues/1014/952093844@github.com>

After spv resync and restarting it popped up this error.
![image](https://user-images.githubusercontent.com/88378939/138918737-2066cb8a-e2ab-4055-ac41-73d368f1eb13.png)


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/support/issues/1014#issuecomment-952093844
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211026/e4e79507/attachment.htm>

From notifications at github.com  Tue Oct 26 18:12:33 2021
From: notifications at github.com (metaltrance)
Date: Tue, 26 Oct 2021 09:12:33 -0700
Subject: [bisq-network/support] Fee reimbursement for trade 718499 (Issue
 #1014)
In-Reply-To: <bisq-network/support/issues/1014@github.com>
References: <bisq-network/support/issues/1014@github.com>
Message-ID: <bisq-network/support/issues/1014/952094668@github.com>

But the open trade now looks ok and the status is correct. dep tx id is populated and no more error.
Can I safely continue with the fiat payment?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/support/issues/1014#issuecomment-952094668
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211026/0c3f8fe8/attachment-0001.htm>

From notifications at github.com  Tue Oct 26 18:19:43 2021
From: notifications at github.com (metaltrance)
Date: Tue, 26 Oct 2021 09:19:43 -0700
Subject: [bisq-network/support] Fee reimbursement for trade 718499 (Issue
 #1014)
In-Reply-To: <bisq-network/support/issues/1014@github.com>
References: <bisq-network/support/issues/1014@github.com>
Message-ID: <bisq-network/support/issues/1014/952101480@github.com>

This error keeps popping up sometimes at a random time it seems... also after restart
The trade data looks ok though.
https://github.com/bisq-network/support/issues/1014#issuecomment-952093844

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/support/issues/1014#issuecomment-952101480
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211026/8c32bee2/attachment.htm>

From notifications at github.com  Tue Oct 26 19:10:24 2021
From: notifications at github.com (jmacxx)
Date: Tue, 26 Oct 2021 10:10:24 -0700
Subject: [bisq-network/support] Fee reimbursement for trade 718499 (Issue
 #1014)
In-Reply-To: <bisq-network/support/issues/1014@github.com>
References: <bisq-network/support/issues/1014@github.com>
Message-ID: <bisq-network/support/issues/1014/952141306@github.com>

"The maker fee transaction for offer with ID 081732 is invalid" is saying that your offer `081732` is bad because the transaction does not exist in the blockchain.  Delete that offer and the message will go away.

> But the open trade now looks ok and the status is correct. dep tx id is populated and no more error.  Can I safely continue with the fiat payment?

For trade `718499` yes, I'd suggest you continue with it.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/support/issues/1014#issuecomment-952141306
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211026/d11cc09a/attachment.htm>

From notifications at github.com  Tue Oct 26 19:24:30 2021
From: notifications at github.com (metaltrance)
Date: Tue, 26 Oct 2021 10:24:30 -0700
Subject: [bisq-network/support] Fee reimbursement for trade 718499 (Issue
 #1014)
In-Reply-To: <bisq-network/support/issues/1014@github.com>
References: <bisq-network/support/issues/1014@github.com>
Message-ID: <bisq-network/support/issues/1014/952152468@github.com>

Ok I continued with the trade and removed that offer. Not sure what went wrong there...
Thanks for your help.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/support/issues/1014#issuecomment-952152468
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211026/a4dfb604/attachment.htm>

From notifications at github.com  Tue Oct 26 19:24:31 2021
From: notifications at github.com (metaltrance)
Date: Tue, 26 Oct 2021 10:24:31 -0700
Subject: [bisq-network/support] Fee reimbursement for trade 718499 (Issue
 #1014)
In-Reply-To: <bisq-network/support/issues/1014@github.com>
References: <bisq-network/support/issues/1014@github.com>
Message-ID: <bisq-network/support/issue/1014/issue_event/5522237329@github.com>

Closed #1014.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/support/issues/1014#event-5522237329
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211026/20ca15f6/attachment.htm>

From notifications at github.com  Tue Oct 26 21:35:23 2021
From: notifications at github.com (Stan)
Date: Tue, 26 Oct 2021 12:35:23 -0700
Subject: [bisq-network/bisq] BSQ swaps: Low risk refactorings [2] (PR
 #5770)
In-Reply-To: <bisq-network/bisq/pull/5770@github.com>
References: <bisq-network/bisq/pull/5770@github.com>
Message-ID: <bisq-network/bisq/pull/5770/review/789833099@github.com>

@ghubstan commented on this pull request.



>      string id = 1;
     int64 date = 2;
     NodeAddress owner_node_address = 3;
     PubKeyRing pub_key_ring = 4;
-    Direction direction = 5;
+    OfferDirection direction = 5;

Is this going to be backward compatible, with older msg receivers expecting an `OfferPayload.Direction`?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5770#pullrequestreview-789833099
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211026/305c84d6/attachment.htm>

From notifications at github.com  Tue Oct 26 22:12:08 2021
From: notifications at github.com (Christoph Atteneder)
Date: Tue, 26 Oct 2021 13:12:08 -0700
Subject: [bisq-network/bisq] Pre-release v1.7.5 - v1.7.5
Message-ID: <bisq-network/bisq/releases/51641983@github.com>

## Release notes
This release introduces 13 new payment methods: Strike, Verse, Monese, Satispay, Bizum, Pix, Nequi, CelPay, PayTM, UPI, RTGS, NEFT and IMPS. It also upgrades Tor to the its latest version and moves all remaining nodes to Tor v3 addresses. And as always, there are many additional bug fixes and minor improvements across the board.

### Improvements
- [Allow standard mark & copy functionality for displayed text fields](https://github.com/bisq-network/bisq/pull/5747)
- [Allow trader chat to continue after trade complete](https://github.com/bisq-network/bisq/pull/5742)
- [Show a warning if PC has been in sleep mode](https://github.com/bisq-network/bisq/pull/5719)
- [Display support agent's Keybase link when opening mediation / arbitration](https://github.com/bisq-network/bisq/pull/5716)
- [Add payment methods Strike and Verse](https://github.com/bisq-network/bisq/pull/5752)
- [Add payment methods Monese and Satispay](https://github.com/bisq-network/bisq/pull/5745)
- [Add payment methods Bizum and Pix](https://github.com/bisq-network/bisq/pull/5741)
- [Add payment methods Nequi and CelPay](https://github.com/bisq-network/bisq/pull/5724)
- [Add five Indian payment methods: PayTM, UPI, RTGS, NEFT and IMPS](https://github.com/bisq-network/bisq/pull/5696)
- [Remove trade id reference for Amazon gift card](https://github.com/bisq-network/bisq/pull/5727)
- [Add new v3 onions for wiz's bitcoin nodes](https://github.com/bisq-network/bisq/pull/5767)
- [Upgrade Tor to v0.4.5.10](https://github.com/bisq-network/bisq/pull/5763)

### Bug fixes
- [Fix issue of Trade Step 1 validation done too soon](https://github.com/bisq-network/bisq/pull/5746)
- [Fix exception in create offer screen](https://github.com/bisq-network/bisq/pull/5753)
- [Fix logic of SEPA country comparison routine](https://github.com/bisq-network/bisq/pull/5748)
- [Disable GC calls if fullDaoNode is set (like in case of seed nodes)](https://github.com/bisq-network/bisq/pull/5728)
- [Fix data handling if DAO is deactivated](https://github.com/bisq-network/bisq/pull/5711)
- [Fix typo (SHA)](https://github.com/bisq-network/bisq/pull/5760)

### Development & Documentation
- [Update Tor upgrade documentation](https://github.com/bisq-network/bisq/pull/5758)
- [Remove v2 nodes and backup nodes from DAO monitor](https://github.com/bisq-network/bisq/pull/5731)
- [Replace Adopt with Zulu for GitHub builds](https://github.com/bisq-network/bisq/pull/5676)
- [Refactor desktop Closed Tradable model utils for API](https://github.com/bisq-network/bisq/pull/5743)
- [Move volume formatting from DisplayUtils to VolumeUtil](https://github.com/bisq-network/bisq/pull/5740)
- [Call `keepfunds` (close trade) on both sides of trade simulation](https://github.com/bisq-network/bisq/pull/5708)
- [CLI bug fix: show trade's contract volume, not moving offer volume](https://github.com/bisq-network/bisq/pull/5704)
- [Add custom bisq.properties to API test harness](https://github.com/bisq-network/bisq/pull/5718)

### New Assets
- [Add Tether (ERC20)](https://github.com/bisq-network/bisq/pull/5735).

## Verification

For a detailed description on how to verify your Bisq installer please have a look at our wiki: https://bisq.wiki/Downloading_and_installing#Verify_installer_file

Url of the signing key (Christoph Atteneder): https://bisq.network/pubkey/29CDFD3B.asc
Full fingerprint: `CB36 D7D2 EBB2 E35D 9B75  500B CD5D C1C5 29CD FD3B`

Import the key:
`curl https://bisq.network/pubkey/29CDFD3B.asc | gpg --import`
GPG prints a confusion warning: "This key is not certified with a trusted signature!" - See https://serverfault.com/questions/569911/how-to-verify-an-imported-gpg-key for background information what it means.

How to verify signatures?
`gpg --digest-algo SHA256 --verify BINARY{.asc*,}`
Replace BINARY with the file you downloaded (e.g. Bisq-1.7.4.dmg)

Verify jar file inside binary:
You can verify on OSX the jar file with:
shasum -a256 [PATH TO BISQ APP]/Bisq.app/Contents/app/desktop-1.7.4-all.jar
The output need to match the value from the Bisq-1.7.4.jar.txt file.

There are three hashes within the Bisq-1.7.4.jar.txt file (macOS, Windows, Linux).
If you want to reproduce and verify the hash of the jar file locally, you need to do so on Windows or Linux using Java 11.0.10 and the v1.7.4 release tag. Because of the signing and notarization process that requires the developer certificate used for the build on macOS it is not possible to create the same jar on macOS.

## Known issues with installation 

### Windows:

There is a known issue with Anti Virus software. We got several reports from users running into different problems. Either the AV software blocks Bisq or Tor, delete files in the data directory [2] or app directory [1]) or cause such a long delay at startup that Tor gets terminated and a file remains locked which can cause that Bisq cannot be started afterwards. To resolve that you need to restart Windows then the lock get released. We are working on solutions to fix those issues.

If you use Crypto currencies on your Windows system be aware that Windows is much more vulnerable to malware than Linux or OSX. Consider to use a dedicated non-Windows system when dealing with cryptocurrencies.

[1] Application directory (contains application installation files):
C:\Users\<username>\AppData\Local\Bisq

[2] Data directory (contains all Bisq data including wallet):
C:\Users\<username>\AppData\Roaming\Bisq\btc_mainnet\tor (you can delete everything except the hiddenservice directory)


### Linux:

Hint for Debian users:
If you have problems starting Bisq on Debian use: `/opt/bisq/bin/Bisq`

If your Linux distro does not support .deb files please follow this instruction:
```
cd ~/Downloads  
mkdir tmp  
cd tmp   
ar x ../Bisq-64bit-1.7.4.deb  
sudo tar Jxvf data.tar.xz  
sudo cp -rp opt/Bisq /opt/
```
That instruction is not tested on many different distros. If you encounter problems please report it in a Github issue so we can improve it. 

## Credits

Thanks to everyone who directly contributed to this release:

- @cd2357 
- @chimp1984 
- @Emzy 
- @geertjanw 
- @ghubstan 
- @Jakub-CZ 
- @jmacxx 
- @ripcurlx 
- @sqrrm  

As well as to everyone that helped with translations on [Transifex](https://transifex.com/bisq/bisq-desktop).

-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/bisq-network/bisq/releases/tag/v1.7.5
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211026/08526d52/attachment-0001.htm>

From notifications at github.com  Tue Oct 26 22:37:44 2021
From: notifications at github.com (sqrrm)
Date: Tue, 26 Oct 2021 13:37:44 -0700
Subject: [bisq-network/support] Refund agent reimbursement for cycle 29
 (Issue #1013)
In-Reply-To: <bisq-network/support/issues/1013@github.com>
References: <bisq-network/support/issues/1013@github.com>
Message-ID: <bisq-network/support/issues/1013/952305021@github.com>

@refund-agent2 could you post the txid of the reimbursement proposal?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/support/issues/1013#issuecomment-952305021
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211026/8e50afe6/attachment.htm>

From notifications at github.com  Wed Oct 27 00:55:32 2021
From: notifications at github.com (Daniel Domingues)
Date: Tue, 26 Oct 2021 15:55:32 -0700
Subject: [bisq-network/bisq] An error occurred when taking the offer
 (Issue #5777)
In-Reply-To: <bisq-network/bisq/issues/5777@github.com>
References: <bisq-network/bisq/issues/5777@github.com>
Message-ID: <bisq-network/bisq/issues/5777/952389125@github.com>

I gave up using Bisq. Too many bugs. 

Thank you. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5777#issuecomment-952389125
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211026/407e3483/attachment.htm>

From notifications at github.com  Wed Oct 27 12:05:58 2021
From: notifications at github.com (chimp1984)
Date: Wed, 27 Oct 2021 03:05:58 -0700
Subject: [bisq-network/bisq] Improve DAO state management (Issue #5783)
Message-ID: <bisq-network/bisq/issues/5783@github.com>

The DAO state is getting larger with each new block and is a major issue for memory consumption of Bisq.
Currently it is about 150 MB, where 135 MB are the blocks. We load it at startup which takes about 2-4 sec on my machine and then after parsing is complete we write snapshots to disk which also takes a few seconds. Persistence happens on background threads so it is not a major problem but still quite slow.

I was wondering what we could do to improve that situation.
Best would be if we could avoid to load 150 MB into memory but I fear that is not feasible without either a huge and risky effort to optimize and customize the data access or try to use some DB but I am pretty sure that would degrade performance a lot as we need most of the data for different forms of access (the large chunk of data are transactions and we need to look up those for various properties in the DAO context). In Bitcoin it is easier as there the spendability is the only real aspect to consider, so pruning of data which is not relevant for furture use cases can be done easier. In Bisq the DAO has many different use cases where old data is still relevant, so pruning is likely not really possible. The only way I see is to create all kind of data views (lookup maps) for the various use cases we have. E.g. If we need to iterate all txs for finding potential locked outputs we could just make a lookup map where the txOutputType we are interested in is used as key and we hold only the few relevant txs there. If all use cases could be optimized that way we could release the blocks/txs and only keep the relevant views, which likely will be much smaller. That would be one approach but I am not 100% sure if it would really lead to less data and it comes with considerable effort and risks for the DAO consensus.

But the 150 MB in memory are not the only concern. At snapshot creation we have to keep a copy of that in memory. Here we could optimize with much less risks and less effort.
We could extract the blocks from the daoState into a dedicated data store and split that up either automatically in buckets of e.g. 1000 blocks or use a similar versioning model as we use for trade statistics (historical data store). The automatically managed approach would be probably better as it would not require work from the release manager. As blocks are immutable we could treat all old buckets immutable closed data structures as well and therefor wont need to persist them. They are only loaded for getting the data and concatenated with all the other buckets to form the full BSQ block chain. We only persist the current one which will be much faster as data size will be a few MB not 150 MB.
The other DAO state is about 15 MB so that is also ok for fast persistence.
There is still a smaller issue with re-org. Say we just moved to a new bucket with a new block and then there is a 3 block deep re-org so it changes our blocks in the previous bucket which we considered as immutable/closed. But that is a minor issue and there are ways to deal with that, like deleting the previous bucket and resync. We do a resync from the last snapshot also now in case of reorgs. We do not need to support arbitrarily deep re-orgs as realistically reorgs are never deeper than 3-4 blocks. 

So I think that approach is feasible to implement and comes with little risks for DAO consensus issues.

Any other ideas? Feedback?


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5783
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211027/5976cfca/attachment.htm>

From notifications at github.com  Wed Oct 27 15:41:46 2021
From: notifications at github.com (sqrrm)
Date: Wed, 27 Oct 2021 06:41:46 -0700
Subject: [bisq-network/bisq] Improve DAO state management (Issue #5783)
In-Reply-To: <bisq-network/bisq/issues/5783@github.com>
References: <bisq-network/bisq/issues/5783@github.com>
Message-ID: <bisq-network/bisq/issues/5783/952942651@github.com>

I think the splitting of blocks in 1000 block buckets is a reasonable thing to do that doesn't carry much risk.

Modding the data structures for the DAO consensus carries a lot more risk but could perhaps be done. I would avoid it if possible but perhaps just mimicking the current behavior with new data structures in parallel for a while could be a way to get there with reduced risk.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5783#issuecomment-952942651
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211027/9fc33db7/attachment.htm>

From notifications at github.com  Thu Oct 28 01:45:01 2021
From: notifications at github.com (chimp1984)
Date: Wed, 27 Oct 2021 16:45:01 -0700
Subject: [bisq-network/bisq] Improve DAO state management (Issue #5783)
In-Reply-To: <bisq-network/bisq/issues/5783@github.com>
References: <bisq-network/bisq/issues/5783@github.com>
Message-ID: <bisq-network/bisq/issues/5783/953388766@github.com>

Found an interesting approach using MappedByteBuffer. 
https://blogs.oracle.com/javamagazine/post/creating-a-java-off-heap-in-memory-database

Still heavy work in progress but got all blocks stored in that MappedByteBuffer as individual records. Reading of all live blocks takes 1.5 sec instead of about 5-8 sec for the DaoState. Write takes about 1 ms, remaining daoState data is about 18MB and takes abotu 300 ms. But still much faster than with all blocks in the daoState which took about 5-8 sec.

Have not seen yes how much it improves with memory usage, but as we do not clone the large daoState anymore but unly the 18MB data + the blocks since the last write, I guess it will have some positive impact.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5783#issuecomment-953388766
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211027/b3559920/attachment.htm>

From notifications at github.com  Thu Oct 28 17:07:36 2021
From: notifications at github.com (cd2357)
Date: Thu, 28 Oct 2021 08:07:36 -0700
Subject: [bisq-network/bisq] Redesign DAO state monitoring to avoid
 performance degradation (Issue #5779)
In-Reply-To: <bisq-network/bisq/issues/5779@github.com>
References: <bisq-network/bisq/issues/5779@github.com>
Message-ID: <bisq-network/bisq/issues/5779/953938065@github.com>

Sounds very promising for new and casual users ? 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5779#issuecomment-953938065
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211028/7dc4cb64/attachment.htm>

From notifications at github.com  Thu Oct 28 17:23:22 2021
From: notifications at github.com (cd2357)
Date: Thu, 28 Oct 2021 08:23:22 -0700
Subject: [bisq-network/bisq] An error occurred when taking the offer
 (Issue #5777)
In-Reply-To: <bisq-network/bisq/issues/5777@github.com>
References: <bisq-network/bisq/issues/5777@github.com>
Message-ID: <bisq-network/bisq/issue/5777/issue_event/5534970049@github.com>

Closed #5777.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5777#event-5534970049
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211028/adf58013/attachment.htm>

From notifications at github.com  Thu Oct 28 17:28:38 2021
From: notifications at github.com (cd2357)
Date: Thu, 28 Oct 2021 08:28:38 -0700
Subject: [bisq-network/bisq] BSQ Missing Fund Warning (Issue #5776)
In-Reply-To: <bisq-network/bisq/issues/5776@github.com>
References: <bisq-network/bisq/issues/5776@github.com>
Message-ID: <bisq-network/bisq/issues/5776/953957260@github.com>

Thanks for the report @dgyg .

Good news is, this has been known for a while and @sneznaj already prepared a fix with #5766.

I will close this for now, the fix should be delivered probably in the next release.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5776#issuecomment-953957260
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211028/026bbf4a/attachment.htm>

From notifications at github.com  Thu Oct 28 17:28:38 2021
From: notifications at github.com (cd2357)
Date: Thu, 28 Oct 2021 08:28:38 -0700
Subject: [bisq-network/bisq] BSQ Missing Fund Warning (Issue #5776)
In-Reply-To: <bisq-network/bisq/issues/5776@github.com>
References: <bisq-network/bisq/issues/5776@github.com>
Message-ID: <bisq-network/bisq/issue/5776/issue_event/5535005136@github.com>

Closed #5776.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5776#event-5535005136
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211028/11a7d6c5/attachment.htm>

From notifications at github.com  Thu Oct 28 17:30:40 2021
From: notifications at github.com (cd2357)
Date: Thu, 28 Oct 2021 08:30:40 -0700
Subject: [bisq-network/bisq] Fee reimbursement for Failed trade 23773143 
 (#5754)
In-Reply-To: <bisq-network/bisq/issues/5754@github.com>
References: <bisq-network/bisq/issues/5754@github.com>
Message-ID: <bisq-network/bisq/issue/5754/issue_event/5535018803@github.com>

Closed #5754.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5754#event-5535018803
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211028/b572ca56/attachment.htm>

From notifications at github.com  Thu Oct 28 17:31:23 2021
From: notifications at github.com (cd2357)
Date: Thu, 28 Oct 2021 08:31:23 -0700
Subject: [bisq-network/bisq] Failed trade (#5751)
In-Reply-To: <bisq-network/bisq/issues/5751@github.com>
References: <bisq-network/bisq/issues/5751@github.com>
Message-ID: <bisq-network/bisq/issue/5751/issue_event/5535023264@github.com>

Closed #5751.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5751#event-5535023264
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211028/fdc6ee70/attachment.htm>

From notifications at github.com  Thu Oct 28 17:37:03 2021
From: notifications at github.com (cd2357)
Date: Thu, 28 Oct 2021 08:37:03 -0700
Subject: [bisq-network/bisq] Pls see attaced (#5689)
In-Reply-To: <bisq-network/bisq/issues/5689@github.com>
References: <bisq-network/bisq/issues/5689@github.com>
Message-ID: <bisq-network/bisq/issue/5689/issue_event/5535059020@github.com>

Closed #5689.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5689#event-5535059020
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211028/24541f9c/attachment-0001.htm>

From notifications at github.com  Thu Oct 28 17:46:05 2021
From: notifications at github.com (cd2357)
Date: Thu, 28 Oct 2021 08:46:05 -0700
Subject: [bisq-network/bisq] Compiling from source:
 java.security.InvalidAlgorithmParameterException: the trustAnchors parameter
 must be non-empty (#5658)
In-Reply-To: <bisq-network/bisq/issues/5658@github.com>
References: <bisq-network/bisq/issues/5658@github.com>
Message-ID: <bisq-network/bisq/issue/5658/issue_event/5535114742@github.com>

Closed #5658.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5658#event-5535114742
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211028/3d15833e/attachment.htm>

From notifications at github.com  Thu Oct 28 17:46:06 2021
From: notifications at github.com (cd2357)
Date: Thu, 28 Oct 2021 08:46:06 -0700
Subject: [bisq-network/bisq] Compiling from source:
 java.security.InvalidAlgorithmParameterException: the trustAnchors parameter
 must be non-empty (#5658)
In-Reply-To: <bisq-network/bisq/issues/5658@github.com>
References: <bisq-network/bisq/issues/5658@github.com>
Message-ID: <bisq-network/bisq/issues/5658/953972251@github.com>

Make sure you really are using Java 11 (via `update-java-alternatives`, see [how-to](https://askubuntu.com/a/740782))

We've seen several java-version-related certificate issues in the past (https://github.com/bisq-network/bisq/pull/4315#issuecomment-669493884) . The link from ripcurl above also points to a java version issue.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5658#issuecomment-953972251
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211028/7f111032/attachment.htm>

From notifications at github.com  Thu Oct 28 17:47:16 2021
From: notifications at github.com (cd2357)
Date: Thu, 28 Oct 2021 08:47:16 -0700
Subject: [bisq-network/bisq] error when trying to buy an offer (#5655)
In-Reply-To: <bisq-network/bisq/issues/5655@github.com>
References: <bisq-network/bisq/issues/5655@github.com>
Message-ID: <bisq-network/bisq/issue/5655/issue_event/5535121725@github.com>

Closed #5655.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5655#event-5535121725
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211028/9c74a01d/attachment.htm>

From notifications at github.com  Thu Oct 28 17:58:17 2021
From: notifications at github.com (jan zens)
Date: Thu, 28 Oct 2021 08:58:17 -0700
Subject: [bisq-network/bisq] add alternative popup "no BSQ while
 Synchronizing DAO" (PR #5766)
In-Reply-To: <bisq-network/bisq/pull/5766@github.com>
References: <bisq-network/bisq/pull/5766@github.com>
Message-ID: <bisq-network/bisq/pull/5766/push/8260485314@github.com>

@sneznaj pushed 1 commit.

030c8910d55c5d75d5dc2cc47cb5fa475296a3a3  Merge branch 'bisq-network:master' into master


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/bisq-network/bisq/pull/5766/files/f2cac86b50af9fcbcdf8eb82a274e19ebbb22c36..030c8910d55c5d75d5dc2cc47cb5fa475296a3a3
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211028/9f969704/attachment.htm>

From notifications at github.com  Thu Oct 28 18:02:09 2021
From: notifications at github.com (cd2357)
Date: Thu, 28 Oct 2021 09:02:09 -0700
Subject: [bisq-network/bisq] Improve performance of
 ParseBlockChainComplete (#4972)
In-Reply-To: <bisq-network/bisq/issues/4972@github.com>
References: <bisq-network/bisq/issues/4972@github.com>
Message-ID: <bisq-network/bisq/issues/4972/953985724@github.com>

Duplicate of #5779, fixed with #5782

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/4972#issuecomment-953985724
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211028/8aad4f4e/attachment.htm>

From notifications at github.com  Thu Oct 28 18:02:11 2021
From: notifications at github.com (cd2357)
Date: Thu, 28 Oct 2021 09:02:11 -0700
Subject: [bisq-network/bisq] Improve performance of
 ParseBlockChainComplete (#4972)
In-Reply-To: <bisq-network/bisq/issues/4972@github.com>
References: <bisq-network/bisq/issues/4972@github.com>
Message-ID: <bisq-network/bisq/issue/4972/issue_event/5535213379@github.com>

Closed #4972.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/4972#event-5535213379
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211028/1aa1a9de/attachment-0001.htm>

From notifications at github.com  Thu Oct 28 18:03:44 2021
From: notifications at github.com (cd2357)
Date: Thu, 28 Oct 2021 09:03:44 -0700
Subject: [bisq-network/bisq] Bitcoin node tor v3 support? (#5179)
In-Reply-To: <bisq-network/bisq/issues/5179@github.com>
References: <bisq-network/bisq/issues/5179@github.com>
Message-ID: <bisq-network/bisq/issues/5179/953987055@github.com>

Bisq now supports Tor v3 addresses.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5179#issuecomment-953987055
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211028/27e0fa68/attachment.htm>

From notifications at github.com  Thu Oct 28 18:03:44 2021
From: notifications at github.com (cd2357)
Date: Thu, 28 Oct 2021 09:03:44 -0700
Subject: [bisq-network/bisq] Bitcoin node tor v3 support? (#5179)
In-Reply-To: <bisq-network/bisq/issues/5179@github.com>
References: <bisq-network/bisq/issues/5179@github.com>
Message-ID: <bisq-network/bisq/issue/5179/issue_event/5535223566@github.com>

Closed #5179.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5179#event-5535223566
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211028/326d0494/attachment.htm>

From notifications at github.com  Thu Oct 28 18:10:31 2021
From: notifications at github.com (cd2357)
Date: Thu, 28 Oct 2021 09:10:31 -0700
Subject: [bisq-network/bisq] Support of Torv3 (Required for BTCPay Server)
 (#2873)
In-Reply-To: <bisq-network/bisq/issues/2873@github.com>
References: <bisq-network/bisq/issues/2873@github.com>
Message-ID: <bisq-network/bisq/issue/2873/issue_event/5535265790@github.com>

Closed #2873.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/2873#event-5535265790
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211028/36630260/attachment.htm>

From notifications at github.com  Thu Oct 28 18:10:31 2021
From: notifications at github.com (cd2357)
Date: Thu, 28 Oct 2021 09:10:31 -0700
Subject: [bisq-network/bisq] Support of Torv3 (Required for BTCPay Server)
 (#2873)
In-Reply-To: <bisq-network/bisq/issues/2873@github.com>
References: <bisq-network/bisq/issues/2873@github.com>
Message-ID: <bisq-network/bisq/issues/2873/953992673@github.com>

Bisq now supports Tor v3 addresses.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/2873#issuecomment-953992673
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211028/cdfc6d4a/attachment.htm>

From notifications at github.com  Thu Oct 28 19:22:24 2021
From: notifications at github.com (Christoph Atteneder)
Date: Thu, 28 Oct 2021 10:22:24 -0700
Subject: [bisq-network/compensation] For Cycle 29 (Issue #935)
In-Reply-To: <bisq-network/compensation/issues/935@github.com>
References: <bisq-network/compensation/issues/935@github.com>
Message-ID: <bisq-network/compensation/issues/935/954047920@github.com>

As dev team lead I approve this compensation request.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/935#issuecomment-954047920
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211028/e694e239/attachment.htm>

From notifications at github.com  Thu Oct 28 19:26:54 2021
From: notifications at github.com (Christoph Atteneder)
Date: Thu, 28 Oct 2021 10:26:54 -0700
Subject: [bisq-network/bisq-website] [WIP] Updates for v1.7.5 release (PR #448)
Message-ID: <bisq-network/bisq-website/pull/448@github.com>


You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq-website/pull/448

-- Commit Summary --

  * <a href="https://github.com/bisq-network/bisq-website/pull/448/commits/3ae3ceec7cf365a7c04992141bbc8f23407b7015">Updates for v1.7.5 release</a>

-- File Changes --

    M _config.yml (2)

-- Patch Links --

https://github.com/bisq-network/bisq-website/pull/448.patch
https://github.com/bisq-network/bisq-website/pull/448.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq-website/pull/448
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211028/26ad8140/attachment.htm>

From notifications at github.com  Thu Oct 28 19:28:48 2021
From: notifications at github.com (Christoph Atteneder)
Date: Thu, 28 Oct 2021 10:28:48 -0700
Subject: [bisq-network/bisq-website] Updates for v1.7.5 release (PR #448)
In-Reply-To: <bisq-network/bisq-website/pull/448@github.com>
References: <bisq-network/bisq-website/pull/448@github.com>
Message-ID: <bisq-network/bisq-website/pull/448/issue_event/5535688492@github.com>

Merged #448 into master.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq-website/pull/448#event-5535688492
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211028/06fa02a2/attachment-0001.htm>

From notifications at github.com  Thu Oct 28 21:41:27 2021
From: notifications at github.com (Stan)
Date: Thu, 28 Oct 2021 12:41:27 -0700
Subject: [bisq-network/bisq] Bsq swap: Implementation [3] (PR #5775)
In-Reply-To: <bisq-network/bisq/pull/5775@github.com>
References: <bisq-network/bisq/pull/5775@github.com>
Message-ID: <bisq-network/bisq/pull/5775/review/792350814@github.com>

@ghubstan commented on this pull request.



> @@ -145,8 +145,12 @@ public void initialize() {
     protected void activate() {
         if (DevEnv.isDaoActivated()) {
 
-            // Hide dao new badge if user saw this section
-            preferences.dontShowAgain(DaoPresentation.DAO_NEWS, true);
+            if (preferences.showAgain(DaoPresentation.DAO_NEWS)) {
+                preferences.dontShowAgain(DaoPresentation.DAO_NEWS, true);
+                new Popup().headLine(Res.get("news.bsqSwap.title"))
+                        .information(Res.get("news.bsqSwap.description"))

TODO Write and publish [BSQ Swaps wiki.](https://bisq.wiki/BSQ_Swaps)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5775#pullrequestreview-792350814
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211028/dfc25e09/attachment.htm>

From notifications at github.com  Thu Oct 28 21:54:07 2021
From: notifications at github.com (Stan)
Date: Thu, 28 Oct 2021 12:54:07 -0700
Subject: [bisq-network/bisq] Bsq swap: Implementation [3] (PR #5775)
In-Reply-To: <bisq-network/bisq/pull/5775@github.com>
References: <bisq-network/bisq/pull/5775@github.com>
Message-ID: <bisq-network/bisq/pull/5775/review/792361722@github.com>

@ghubstan commented on this pull request.



> + *
+ * Bisq is free software: you can redistribute it and/or modify it
+ * under the terms of the GNU Affero General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or (at
+ * your option) any later version.
+ *
+ * Bisq is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU Affero General Public
+ * License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with Bisq. If not, see <http://www.gnu.org/licenses/>.
+ */
+
+package bisq.core.offer.placeoffer.bsqswap;

Some packages are named `bsq_swap`, but this one is `bsqswap`.  Could the `bsq_swap` pkgs be renamed `bsqswap` too?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5775#pullrequestreview-792361722
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211028/64e09624/attachment.htm>

From notifications at github.com  Thu Oct 28 22:02:19 2021
From: notifications at github.com (Stan)
Date: Thu, 28 Oct 2021 13:02:19 -0700
Subject: [bisq-network/bisq] Bsq swap: Implementation [3] (PR #5775)
In-Reply-To: <bisq-network/bisq/pull/5775@github.com>
References: <bisq-network/bisq/pull/5775@github.com>
Message-ID: <bisq-network/bisq/pull/5775/review/792369174@github.com>

@ghubstan commented on this pull request.



> +        if (!isTakeOfferScreen)
+            rows++;
+
+        addTitledGroupBg(gridPane, ++rowIndex, rows, Res.get("shared.Offer"));
+
+        String bsqDirectionInfo = "";
+        String btcDirectionInfo = "";
+        OfferDirection direction = offer.getDirection();
+        String currencyCode = offer.getCurrencyCode();
+        String offerTypeLabel = Res.get("shared.offerType");
+        String toReceive = " " + Res.get("shared.toReceive");
+        String toSpend = " " + Res.get("shared.toSpend");
+        String minus = " - ";
+        String plus = " + ";
+        String minerFeePostFix = Res.get("tradeDetailsWindow.txFee");
+        String tradeFeePostFix = Res.get("shared.tradeFee");

Is there no way to tell the bsq swap offer creator what the trade fee will be
![how-much-is-trade-fee](https://user-images.githubusercontent.com/36207203/139327043-ca7084ae-94d9-45d2-8773-1e6cdacf69c2.png)
?


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5775#pullrequestreview-792369174
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211028/e43c3afe/attachment.htm>

From notifications at github.com  Thu Oct 28 22:05:04 2021
From: notifications at github.com (Stan)
Date: Thu, 28 Oct 2021 13:05:04 -0700
Subject: [bisq-network/bisq] Bsq swap: Implementation [3] (PR #5775)
In-Reply-To: <bisq-network/bisq/pull/5775@github.com>
References: <bisq-network/bisq/pull/5775@github.com>
Message-ID: <bisq-network/bisq/pull/5775/review/792372019@github.com>

@ghubstan commented on this pull request.



> +        if (!isTakeOfferScreen)
+            rows++;
+
+        addTitledGroupBg(gridPane, ++rowIndex, rows, Res.get("shared.Offer"));
+
+        String bsqDirectionInfo = "";
+        String btcDirectionInfo = "";
+        OfferDirection direction = offer.getDirection();
+        String currencyCode = offer.getCurrencyCode();
+        String offerTypeLabel = Res.get("shared.offerType");
+        String toReceive = " " + Res.get("shared.toReceive");
+        String toSpend = " " + Res.get("shared.toSpend");
+        String minus = " - ";
+        String plus = " + ";
+        String minerFeePostFix = Res.get("tradeDetailsWindow.txFee");
+        String tradeFeePostFix = Res.get("shared.tradeFee");

The taker can see the trade fee before taking the offer, but the maker still doesn't know yet.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5775#discussion_r738724987
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211028/278994c6/attachment.htm>

From notifications at github.com  Thu Oct 28 22:06:58 2021
From: notifications at github.com (Stan)
Date: Thu, 28 Oct 2021 13:06:58 -0700
Subject: [bisq-network/bisq] Bsq swap: Implementation [3] (PR #5775)
In-Reply-To: <bisq-network/bisq/pull/5775@github.com>
References: <bisq-network/bisq/pull/5775@github.com>
Message-ID: <bisq-network/bisq/pull/5775/review/792373647@github.com>

@ghubstan commented on this pull request.



> +        if (!isTakeOfferScreen)
+            rows++;
+
+        addTitledGroupBg(gridPane, ++rowIndex, rows, Res.get("shared.Offer"));
+
+        String bsqDirectionInfo = "";
+        String btcDirectionInfo = "";
+        OfferDirection direction = offer.getDirection();
+        String currencyCode = offer.getCurrencyCode();
+        String offerTypeLabel = Res.get("shared.offerType");
+        String toReceive = " " + Res.get("shared.toReceive");
+        String toSpend = " " + Res.get("shared.toSpend");
+        String minus = " - ";
+        String plus = " + ";
+        String minerFeePostFix = Res.get("tradeDetailsWindow.txFee");
+        String tradeFeePostFix = Res.get("shared.tradeFee");

After taking the offer, the maker still can't find the trade fee, until he checks the swap tx in a block explorer.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5775#discussion_r738726909
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211028/b0db842c/attachment-0001.htm>

From notifications at github.com  Thu Oct 28 23:30:51 2021
From: notifications at github.com (Liisachan)
Date: Thu, 28 Oct 2021 14:30:51 -0700
Subject: [bisq-network/bisq] Download a new version via Tor; warning before
 direct connections (Discussion #5785)
Message-ID: <bisq-network/bisq/repo-discussions/5785@github.com>

When a new version of Bisq is available and user lets Bisq download it, currently Bisq tries to make directly connecion(s), without warning, to clearnet addresses (prob. eventually to github.com and amazonaws.com).

For better privacy, updating via onion would be ideal, or at least there should be a warning before making non-proxied direct connections. As it is now, github and amazonaws could gather private data and have a list of the IPs of unsuspecting Bisq users, potentially producing a loophole of anonymity (inadvertent "centralized points" that could be avoidable), making Bisq less censor-resistant.

It'll be easy for a user to misunderstand that Bisq connections are Tor-based and safe (anonymous), like when Tor Browser updates itself. Am I just too paranoid? I'd like to ask others' opinions about this. Thank you very much.

Workarounds: (1) manually download a new version and verify .asc; or (2) set every connection proxied with VPN, Tails, etc.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/discussions/5785
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211028/8dfc80ce/attachment.htm>

From notifications at github.com  Thu Oct 28 23:44:19 2021
From: notifications at github.com (UX-P)
Date: Thu, 28 Oct 2021 14:44:19 -0700
Subject: [bisq-network/proposals] New role request- User Researcher (#344)
In-Reply-To: <bisq-network/proposals/issues/344@github.com>
References: <bisq-network/proposals/issues/344@github.com>
Message-ID: <bisq-network/proposals/issues/344/954245899@github.com>

I have analysed the comments left by users on Keybase support and designed an [affinity map]( https://miro.com/app/board/o9J_lo8abDg=/?invite_link_id=107283228134 
) grouping the most common subjects and talking points.
Below is a summary of possible solutions based on these key points and takes into consideration the heuristics web standard.
This list is also applicable to any new releases (maybe some of these have been addressed already) and future app considerations when developing Misq. Let me know what you think. 

**Language**
Error messages were also a common issue. The user seems to be unclear of their next steps e.g. error reads ?Contact a Bisq developer? without providing a call to action button, contact or link. The language used in the error messages is often incomprehensible to the user, it is important to use language that the user is familiar with where possible.
-	Unmatched account details should be stated in UI as: a breach of protocol and may result in mediator intervention.
-	Error messages should be translated where possible using language familiar to the user and should contain an action e.g., restart Bisq, or contact support, including an action button.

**Support**
Although Keybase is great for discussing certain issues, Users are seeking that immediate help. There does not appear to be enough guidance given directly from the Bisq app itself, which is where the user would initially look for support.
There is not a support system on Bisq that encourages one on one queries between mediator and user outside of mediation. Here are a few ways to encourage this:
The chat panel should clearly state where the user can go for further support or who to contact.
-	Support team available on Bisq
-	Create a support chat window separate to mediation and P2P chat window, required on Bisq for general queries during trade.
-	If no resolution is provided on Bisq chat, direct the user to Keybase support using a link or button.
-	Direct users to Keybase for tech issues or specific mediator
-	Link to Keybase support displayed in chat panel and support button.
-	Separate mediation and P2P chat window

**How to guide**
Users make many ?How to? enquiries. The support tab currently contains mediation history and could appear misleading as the term ?support? is associated with help. The support click-through should contain information and links for quick access to guidance and documentation. Include a search bar to look up words and popular search terms used on Bisq. This will help to alleviate the Keybase support channel and prevent it from being clogged up with issues that can be resolved by the user. Here is a list of guides derived from the most common ?how to? queries:
-	Getting started guide, include the Bisq basics
-	Step by step guide on disputes
-	Security and privacy protocol
-	Trading process guide
Many users seem confused by the terms and wording used by Bisq. As a web standard users should not have to learn, they want to comprehend almost immediately using as little amount of thinking in order to relieve their cognitive load. However, it is understandable that in some cases certain words are required, so perhaps these suggestions could help the user to broaden their understanding:
Glossary
-	Glossary in Bisq support
-	Wiki descriptions available on Bisq under support tab

**Technical**
Users are having node connection issues; I am not a developer so I do not know if this is solely a technical issue. I have spoken with a user and they have explained that when Bisq has not yet connected to a node it is displayed on screen as an error message. Is this an error? If not, it could be better represented as a loading message.
-	Connections to node can be shown as a waiting period not a warning. E.g., ?Please wait for syncing to complete? appears at relevant points of the user journey, as opposed to appearing on screen as an error message.
Long waiting periods
The long waiting periods causes complaints and seems to agitate the user, some even stating that they won?t be using Bisq again. These issues could be rectified with the following suggestions:
-	State arbitrator?s expected response time clearly in chat e.g., arbitrator will respond within 5 days
-	Inform the user of what to do when the arbitrator does not respond after specified time.
-	Show when mediator is online
-	State mediator?s expected response time
-	Inform user of what to do when mediator does not respond

**P2P Interaction**
On average users complain on Keybase after 18 hours wait for peer to confirm.
P2P interaction should be encouraged so that it does not result in the user having to contact support. Prevention of escalation via P2P communication will make the peer less inclined to neglect a trade and may result in less mediator intervention, here are several ways this could be applied:
-	Show if peer is online with the option to switch status to offline.
-	Notifications once Bisq is minimised prompting, next steps, confirmation, chat messages, time period terminated, reminder to either confirm or transfer.
-	After 18hrs waiting period prompt user to contact peer

**UI**
These are changes that should essentially be applied for immediate enhancement of UX experience.
-	Optimise scaling so that all essential elements are displayed
-	Remove ?locked funds from failed trade? pop up.  Prevent it from obscuring the UI. -	Clearly displaying shortcuts are essential for both new users and power users. Shortcuts stated on UI e.g., Open mediation Ctrl + o, Open wallet data Ctrl + j
-Mediation and P2P chat box should be separated

**Next steps**
I would like to ask users on Keybase to state what features they like, dislike, or would like to improve on Bisq etc. with the option to also participate in a short user interview, any research suggestions from the team is welcome.  In the meantime, let me know what you think of the above user analyse. 

It would be excellent to hear from a UX designer and @pazza83  as I know you contribute in the support team. I am not aware of who to add to this but any feedback is welcome!


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/proposals/issues/344#issuecomment-954245899
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211028/f7117d89/attachment.htm>

From notifications at github.com  Fri Oct 29 00:35:40 2021
From: notifications at github.com (pazza)
Date: Thu, 28 Oct 2021 15:35:40 -0700
Subject: [bisq-network/proposals] Allow 1sat/vByte fee for withdrawals
 (#343)
In-Reply-To: <bisq-network/proposals/issues/343@github.com>
References: <bisq-network/proposals/issues/343@github.com>
Message-ID: <bisq-network/proposals/issues/343/954275616@github.com>

Are any of the @bisq-network/dev able to comment as to the benefits / negatives of reducing withdrawal fees to 1 sat/vB?

Is the 2 sat/vB min limit is to reduce potential support requests for users that fail to make a withdrawal with the appropriate fee? Or is their another reason/s?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/proposals/issues/343#issuecomment-954275616
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211028/5b55b4c8/attachment.htm>

From notifications at github.com  Fri Oct 29 01:02:56 2021
From: notifications at github.com (pazza)
Date: Thu, 28 Oct 2021 16:02:56 -0700
Subject: [bisq-network/compensation] For Cycle 29 (Issue #935)
In-Reply-To: <bisq-network/compensation/issues/935@github.com>
References: <bisq-network/compensation/issues/935@github.com>
Message-ID: <bisq-network/compensation/issues/935/954286599@github.com>

Hi @leo816 thanks for the report.

I think support is working really well at the moment. Communication is good and most issues are quickly resolved.

The weekly support calls have been really beneficial, as have the inclusion of @jmacxx in the support team to help with all the much needed dev support.

All of the recent developments have been coordinated and lead by yourself. 

I am not sure at what point the Support Team Lead role is eligible for compensation, but from my perspective I think it should be. There are still lots of things that can be done to improve support and I am sure they will be achieved quicker and more effectively if you are coordinating / leading the support team.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/935#issuecomment-954286599
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211028/e97a517b/attachment-0001.htm>

From notifications at github.com  Fri Oct 29 01:06:36 2021
From: notifications at github.com (asvdf)
Date: Thu, 28 Oct 2021 16:06:36 -0700
Subject: [bisq-network/proposals] Allow 1sat/vByte fee for withdrawals
 (#343)
In-Reply-To: <bisq-network/proposals/issues/343@github.com>
References: <bisq-network/proposals/issues/343@github.com>
Message-ID: <bisq-network/proposals/issues/343/954288264@github.com>

We are probably looking at a long while (if not forever) with low onchain fees, thanks to a lot of traffic moving on lightning, so I'd say no reason not to let users save on fees.
Plus, anything that will get stuck on mempool at 1sat/vB, would probably get stuck at 2sat/vB as well, just a little less.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/proposals/issues/343#issuecomment-954288264
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211028/c16ad32f/attachment.htm>

From notifications at github.com  Fri Oct 29 01:15:55 2021
From: notifications at github.com (pazza)
Date: Thu, 28 Oct 2021 16:15:55 -0700
Subject: [bisq-network/compensation] For Cycle 29 (Issue #926)
In-Reply-To: <bisq-network/compensation/issues/926@github.com>
References: <bisq-network/compensation/issues/926@github.com>
Message-ID: <bisq-network/compensation/issues/926/954292063@github.com>

Hi @jmacxx just wanted to say many thanks for getting the payment methods implemented so quickly. It is much appreciated. Hopefully it will allow for more fiat payment options for traders and also open up new markets.

Many thanks ?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/926#issuecomment-954292063
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211028/aeae14dc/attachment.htm>

From notifications at github.com  Fri Oct 29 01:23:06 2021
From: notifications at github.com (chimp1984)
Date: Thu, 28 Oct 2021 16:23:06 -0700
Subject: [bisq-network/proposals] Allow 1sat/vByte fee for withdrawals
 (#343)
In-Reply-To: <bisq-network/proposals/issues/343@github.com>
References: <bisq-network/proposals/issues/343@github.com>
Message-ID: <bisq-network/proposals/issues/343/954295005@github.com>

I think lowering it is ok but going too low adds risks for stuck txs. It is not only the users risk but extended to any trade peer as unconfirmed inputs are ok to be used but if they never get confirmed because of too low fees the trade for both traders end up as failed and both need to do a SPV resync which is a bit painful user experience. So it is a bit different to a normal wallet where in the worst case the user need to re-send a tx. 
I guess a range of 3-5 sat should be ok.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/proposals/issues/343#issuecomment-954295005
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211028/c9d3f5c6/attachment.htm>

From notifications at github.com  Fri Oct 29 01:26:45 2021
From: notifications at github.com (asvdf)
Date: Thu, 28 Oct 2021 16:26:45 -0700
Subject: [bisq-network/proposals] Allow 1sat/vByte fee for withdrawals
 (#343)
In-Reply-To: <bisq-network/proposals/issues/343@github.com>
References: <bisq-network/proposals/issues/343@github.com>
Message-ID: <bisq-network/proposals/issues/343/954296300@github.com>

We are talking withdrawal fees in this topic, after trade has been concluded and you send your funds to private wallet, so 1sat or 2sat per vByte makes no difference at all, and is a hardcoded limitation that I fail to understand.

Regarding trades miner fees, YES, they could be cheaper indeed. I almost intended to open another proposal for those as well, in the same range that you suggested, but I suppose for the trade's smooth operation, overspending is better than the risk of the trade going stale... something could be worked out though.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/proposals/issues/343#issuecomment-954296300
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211028/632ac964/attachment.htm>

From notifications at github.com  Fri Oct 29 01:30:17 2021
From: notifications at github.com (chimp1984)
Date: Thu, 28 Oct 2021 16:30:17 -0700
Subject: [bisq-network/proposals] Allow 1sat/vByte fee for withdrawals
 (#343)
In-Reply-To: <bisq-network/proposals/issues/343@github.com>
References: <bisq-network/proposals/issues/343@github.com>
Message-ID: <bisq-network/proposals/issues/343/954297580@github.com>

But the change outputs of any withdrawal can be used as inputs for a trade, thus affecting another trader. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/proposals/issues/343#issuecomment-954297580
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211028/cea5b816/attachment.htm>

From notifications at github.com  Fri Oct 29 01:34:25 2021
From: notifications at github.com (pazza)
Date: Thu, 28 Oct 2021 16:34:25 -0700
Subject: [bisq-network/proposals] Allow 1sat/vByte fee for withdrawals
 (#343)
In-Reply-To: <bisq-network/proposals/issues/343@github.com>
References: <bisq-network/proposals/issues/343@github.com>
Message-ID: <bisq-network/proposals/issues/343/954298989@github.com>

> But the change outputs of any withdrawal can be used as inputs for a trade, thus affecting another trader.

Many thanks for the explanation. Makes sense,

Would it be possible to reserve the btc the moment they are attempted to be withdrawn to prevent them being used in subsequent trades?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/proposals/issues/343#issuecomment-954298989
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211028/4f664993/attachment-0001.htm>

From notifications at github.com  Fri Oct 29 01:34:57 2021
From: notifications at github.com (asvdf)
Date: Thu, 28 Oct 2021 16:34:57 -0700
Subject: [bisq-network/proposals] Allow 1sat/vByte fee for withdrawals
 (#343)
In-Reply-To: <bisq-network/proposals/issues/343@github.com>
References: <bisq-network/proposals/issues/343@github.com>
Message-ID: <bisq-network/proposals/issues/343/954299194@github.com>

True, albeit I find it far fetched as I'd think someone would be interested in withdrawing only whole utxo's, and then send trade deposits from their external wallet.
In any case, 1sat vs 2sat is not the deciding point of a confirmed transaction vs one in limbo, only sure thing is that you're saving half of the fees... choice should be left to the user, I think it would be fair to those who know what they are doing, that they are not impaired by a decision made to protect inexperienced users from themselves

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/proposals/issues/343#issuecomment-954299194
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211028/72fcc171/attachment.htm>

From notifications at github.com  Fri Oct 29 01:36:44 2021
From: notifications at github.com (asvdf)
Date: Thu, 28 Oct 2021 16:36:44 -0700
Subject: [bisq-network/proposals] Allow 1sat/vByte fee for withdrawals
 (#343)
In-Reply-To: <bisq-network/proposals/issues/343@github.com>
References: <bisq-network/proposals/issues/343@github.com>
Message-ID: <bisq-network/proposals/issues/343/954299734@github.com>

> Would it be possible to reserve the btc the moment they are attempted to be withdrawn to prevent them being used in subsequent trades?

internal wallet should definitely be able to prevent spending unconfirmed utxo's to fund new trades

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/proposals/issues/343#issuecomment-954299734
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211028/3170962e/attachment.htm>

From notifications at github.com  Fri Oct 29 01:50:28 2021
From: notifications at github.com (pazza)
Date: Thu, 28 Oct 2021 16:50:28 -0700
Subject: [bisq-network/roles] BTC donation address owner ("Burningman")
 (#80)
In-Reply-To: <bisq-network/roles/issues/80@github.com>
References: <bisq-network/roles/issues/80@github.com>
Message-ID: <bisq-network/roles/issues/80/954304148@github.com>

Hi @burningman3 

There is ?0.12 BTC in the address 3A8Zc1XioE2HRzYfbb5P8iemCS72M6vRJV that has been there since August.

I assume this is an address under the control of @burningman2? Looks like it is only receiving sporadic funds.

Are there plans in place for previous burningmen to use the BTC that accumulates post finishing their role to burn the BTC deposits?



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/roles/issues/80#issuecomment-954304148
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211028/9fa4a7ae/attachment.htm>

From notifications at github.com  Fri Oct 29 01:54:10 2021
From: notifications at github.com (chimp1984)
Date: Thu, 28 Oct 2021 16:54:10 -0700
Subject: [bisq-network/proposals] Allow 1sat/vByte fee for withdrawals
 (#343)
In-Reply-To: <bisq-network/proposals/issues/343@github.com>
References: <bisq-network/proposals/issues/343@github.com>
Message-ID: <bisq-network/proposals/issues/343/954305326@github.com>

> > Would it be possible to reserve the btc the moment they are attempted to be withdrawn to prevent them being used in subsequent trades?
> 
> internal wallet should definitely be able to prevent spending unconfirmed utxo's to fund new trades

That would decrease usability a lot. Much worse impace than to pay 20 cents instead of 5 cents on miner fees.

Just looked up a random tx. 5 sat is about 50 cents. So I think we are discussing nothingburgers here....
https://mempool.space/tx/e19a5fce774e8ea0566d446a067174f5a70ff5f7d9ab1e40a7fa1a09753e5f65

The problems when a trade tx gets stuck to loose weeks until the issue is clear and resolved and SPV resync is done, which can take quite some time with old and heavy wallets is far worse than to over pay a few cents. Also support costs are considerable in such times. 

Bisq has experience such events in the past when we used other (bad) fee estimation services and when fees have ben spiking fast many trade got stuck. It has been messy situation over weeks and many users got frustrated and probably left Bisq after such an experience. To make it more clear what happens:
- You are in a trade and wait days and days for the confirmation
- You start contacting support, mediation other trader but notbody can help you, you have to wait
- After about 2 weeks unconfirmed the tx is likely removed from mempools so no chance that it will ever get confirmed
- You get from support recommendation to do a SPV resync. With that the tx gets removed and the trade is a failed trade (but not lost money). The peer need to do the same. SPV resync can take hours if you have 1000s of transactions and an old wallet and CPU is 100% all that time. Not a great experience specially for non-technical users.

So thats whats at risk when we go too low...   


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/proposals/issues/343#issuecomment-954305326
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211028/71a30ddd/attachment.htm>

From notifications at github.com  Fri Oct 29 04:18:52 2021
From: notifications at github.com (Liisachan)
Date: Thu, 28 Oct 2021 19:18:52 -0700
Subject: [bisq-network/proposals] Allow 1sat/vByte fee for withdrawals
 (#343)
In-Reply-To: <bisq-network/proposals/issues/343@github.com>
References: <bisq-network/proposals/issues/343@github.com>
Message-ID: <bisq-network/proposals/issues/343/954356274@github.com>

> But the change outputs of any withdrawal can be used as inputs for a trade, thus affecting another trader.

Correct me if I'm wrong but if that is allowed, the exact same problem can happen already, when one sends BTC with 1 sat/vB from another non-Bisq wallet to Bisq and use it for trading before confirmations. Also, if 1 sat could cause a problem, 2 sats (already allowed) can cause similar problems too.
True, when mempool is kept super-crowded for a long time, 1 sat would never work. But in such a situation, 2 (or even 10) sats also might be too low. On the other hand, if mempool is empty, a tx with a 1 sat fee will be confirmed quickly perhaps within 10 minutes.

This is a custom option disabled by default, usable only when a user ticks a checkbox. If a user manually enables an advanced option, usually they know what they are doing. Maybe they're simply sending BTC between their own Bisq and non-Bisq wallets, thinking they won't mind even if it takes days. Plus, such a cost-conscious user is likely to check mempool before doing that.

I'd like to believe that Bisq users, being privacy-aware, tend to be careful and thoughtful. I'd never even think about using a fund that is not yet confirmed for trading, partially because there would be penalty if things go wrong. But admittedly, there might be careless users or innocent mistakes, and so it might be safer for the devs to assume that every user is like a stupid kid. Either way, allowing 2 sats and allowing 1 sat seem the same difference:
- Potential problems of 1 sat are almost equally possible with 2 sats.
- A user agrees to pay 10+ sats/vB within Bisq anyway, plus maker's fee, taker's fee. So basically, NOT allowing 1 sat would be the same difference too. When you're paying 10+ plus other fees, a 1 sat discount would be rather nominal.

So the bottom line is "whichever"... until someday RBF is implemented in Bisq.
Just my two sats :)




-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/proposals/issues/343#issuecomment-954356274
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211028/0caac480/attachment-0001.htm>

From notifications at github.com  Fri Oct 29 04:44:48 2021
From: notifications at github.com (wiz)
Date: Thu, 28 Oct 2021 19:44:48 -0700
Subject: [bisq-network/proposals] Allow 1sat/vByte fee for withdrawals
 (#343)
In-Reply-To: <bisq-network/proposals/issues/343@github.com>
References: <bisq-network/proposals/issues/343@github.com>
Message-ID: <bisq-network/proposals/issues/343/954364311@github.com>

Hi there,

The minimum transaction fee is dynamically set for all Bisq nodes by the Bisq price servers once per minute. It is calculated by multiplying the "minimum fee" from mempool.space by 2, in order to avoid transactions being rejected or purged by the Bitcoin network in the event of a congested mempool. This works very well while the mempool is full, and when the mempool is empty it drops down to 2 sat/vB which is a reasonable minimum to keep things flowing smoothly. Quite often users would make large withdrawal transactions that consolidate all of their UTXOs at 1 sat/vB and because of CPFP effective rate calculation it could cause other transactions to have an effective fee rate of less than half of what was intended. In the future, Bisq could utilize the new CPFP effective fee rate calculation API we developed to optimize this, but for now the current system works well and I'd be against changing it just to save a few sats. And of course, if you are truly a hardcore 1 sat/vB maximalist then you're always welcome to load your  seed words into electrum or another wallet and spend from there using 1 sat/vB but you're on your then if you get your transactions stuck :)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/proposals/issues/343#issuecomment-954364311
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211028/2c1ed80b/attachment.htm>

From notifications at github.com  Fri Oct 29 05:26:49 2021
From: notifications at github.com (waleehoohaa)
Date: Thu, 28 Oct 2021 20:26:49 -0700
Subject: [bisq-network/support] Fee reimbursement for trade 6I6TG (Issue #1015)
Message-ID: <bisq-network/support/issues/1015@github.com>

![6I6TG](https://user-images.githubusercontent.com/93359441/139361821-2d9da170-ce12-45b1-b806-5023ab0c6652.jpg)

Maker:  28e76fd1c459800bc5d988bd5f46828fd4b5ec569a132c1b749b172e4f0e1938
Taker: 8a801c4072c52c6940f8aca621b92881b0128484b9852ac75a625aa3af88bf36
Deposit: 54621a9e53aee4dcbb25da58a11b9bec963347a35ff0e49aaee7aafced068012

Bisq version: 1.7.4
BTC address for reimbursement: bc1qzqt0x26mf0a9phvmn0eg67jup6vgdlfh9seqxv

Other notes: The trade failed because payment details were not shared during the transaction. Mediator Pazza advised requesting reimbursement for the trade and miner fees. Please reimburse the trade/miner fees to the above address. Thank you!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/support/issues/1015
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211028/230d9a9a/attachment.htm>

From notifications at github.com  Fri Oct 29 06:46:26 2021
From: notifications at github.com (m52go)
Date: Thu, 28 Oct 2021 21:46:26 -0700
Subject: [bisq-network/bisq-website] Add semi-automated dashboard (PR #449)
Message-ID: <bisq-network/bisq-website/pull/449@github.com>

This pull request adds a semi-automated workflow to generate reporting for key DAO figures: supply, issuance, burn, and governance.

It was annoying to update the stats page and collect all figures to write DAO reports every cycle. This PR automates all of that?all DAO reports included in this PR are 100% generated with the scripts in this PR.

**Going forward, with this workflow, anyone can generate a new cycle report and make a PR to this repository to update the dashboard.** This means updates can be more prompt, and the variety of people who can do them is broader. Of course, that also means anyone can verify the reports too, which is a nice benefit.

More practical details on what this PR does:
- Replace `/stats` page with new `/dashboard` page (markets items can be found at https://bisq.markets)
- Add `/dashboard/cycle-n` pages to cover details about each DAO cycle
- Remove old DAO reports in the blog section; place redirects where necessary

I added a README in the `/.dao` folder with details on how to run the script.
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq-website/pull/449

-- Commit Summary --

  * <a href="https://github.com/bisq-network/bisq-website/pull/449/commits/137dc29da531f49f27226b475e33fa96ac98a521">Rename stats to dashboard and make english-only</a>
  * <a href="https://github.com/bisq-network/bisq-website/pull/449/commits/cac6a057aadecaca7d33f7e38f307b370bbe9be2">Remove markets graphs</a>
  * <a href="https://github.com/bisq-network/bisq-website/pull/449/commits/c1d936f8d92760fe0c300a391183b7a9b1ae2e10">Remove markets graphs and clarify purpose of page</a>
  * <a href="https://github.com/bisq-network/bisq-website/pull/449/commits/1eaa34a8c3403b32ccb7715c20f20d08717ae6e6">Improve bsq supply graph and graph headings</a>
  * <a href="https://github.com/bisq-network/bisq-website/pull/449/commits/9eb58dd0c7add5f9bd1ee3cf03230766e0d27a12">Change source of data for bsq supply</a>
  * <a href="https://github.com/bisq-network/bisq-website/pull/449/commits/4e9524e2dcc6226ff6adcd0d6455d5a4775177db">Rename stats.js to dashboard.js</a>
  * <a href="https://github.com/bisq-network/bisq-website/pull/449/commits/b73a0d2d1a46239dc2182a6d0a5159f2e2769da6">Add bsq supply generated automatically</a>
  * <a href="https://github.com/bisq-network/bisq-website/pull/449/commits/a42ddc18dd9d29a2c22912a0202db2ce75422466">Add forkawesome for dashboard icons</a>
  * <a href="https://github.com/bisq-network/bisq-website/pull/449/commits/491434363dcb809922c3ecf043cc81397b4228d4">Generate cycle overview tiles for dashboard page</a>
  * <a href="https://github.com/bisq-network/bisq-website/pull/449/commits/0cd9cad68aed6afc8c147334ade0a2b9100d761c">Add block times to cycle overview data dump</a>
  * <a href="https://github.com/bisq-network/bisq-website/pull/449/commits/fc1234326fc187232e16fc1754880529dd4dbd8f">Redirect /stats to /dashboard</a>
  * <a href="https://github.com/bisq-network/bisq-website/pull/449/commits/3d994b7f4df223f90e552e6096bd72c75ec25e1c">Add accepted/rejected count to cycle overview dump</a>
  * <a href="https://github.com/bisq-network/bisq-website/pull/449/commits/71470b3192312fa2850c2d0cad19f1ae671bb38d">Add script to generate basic cycle pages</a>
  * <a href="https://github.com/bisq-network/bisq-website/pull/449/commits/050ee372adf038d5db06c378ec6407d6dd4b27b7">Add funds transfer section to cycle pages</a>
  * <a href="https://github.com/bisq-network/bisq-website/pull/449/commits/cfee29eb9fc7989dd40af2d5aeffee7ff52d82b5">Add governance section to cycle pages</a>
  * <a href="https://github.com/bisq-network/bisq-website/pull/449/commits/ec6dbc59796c965fcdfd781b69c841629e5f2cb1">Add dark mode tweaks</a>
  * <a href="https://github.com/bisq-network/bisq-website/pull/449/commits/ff99d36491fb151c55a9fb5862a8125052c80716">Update link to dashboard generation scripts</a>
  * <a href="https://github.com/bisq-network/bisq-website/pull/449/commits/87e637154450529fb14e75a1e6bd32c9034bcd96">Add back link on cycle pages</a>
  * <a href="https://github.com/bisq-network/bisq-website/pull/449/commits/75918b5bf677e1005f0d3082036935eb7203d766">Remove old dao reports + add redirects</a>

-- File Changes --

    A .dao/README.md (38)
    A .dao/generate_dashboard.sh (34)
    A .dao/settings.json (4)
    A .dao/utilities/cycle-detail-pages/generate.py (234)
    A .dao/utilities/cycle-overview-data/fetch.py (87)
    A .dao/utilities/dao-burn/README.md (9)
    A .dao/utilities/dao-burn/parse-txs.py (223)
    A .dao/utilities/dashboard-tiles/generate.py (33)
    A .dao/utilities/supply-graph-series/generate.py (48)
    M .gitignore (1)
    M _config.yml (4)
    A _dashboard/cycle-1.md (183)
    A _dashboard/cycle-10.md (197)
    A _dashboard/cycle-11.md (235)
    A _dashboard/cycle-12.md (204)
    A _dashboard/cycle-13.md (212)
    A _dashboard/cycle-14.md (187)
    A _dashboard/cycle-15.md (208)
    A _dashboard/cycle-16.md (176)
    A _dashboard/cycle-17.md (219)
    A _dashboard/cycle-18.md (198)
    A _dashboard/cycle-19.md (194)
    A _dashboard/cycle-2.md (130)
    A _dashboard/cycle-20.md (51)
    A _dashboard/cycle-21.md (200)
    A _dashboard/cycle-22.md (189)
    A _dashboard/cycle-23.md (163)
    A _dashboard/cycle-24.md (138)
    A _dashboard/cycle-25.md (147)
    A _dashboard/cycle-26.md (127)
    A _dashboard/cycle-27.md (132)
    A _dashboard/cycle-28.md (127)
    A _dashboard/cycle-3.md (151)
    A _dashboard/cycle-4.md (145)
    A _dashboard/cycle-5.md (227)
    A _dashboard/cycle-6.md (174)
    A _dashboard/cycle-7.md (176)
    A _dashboard/cycle-8.md (218)
    A _dashboard/cycle-9.md (262)
    M _data/de.yml (15)
    M _data/en.yml (17)
    M _data/es.yml (15)
    M _data/fr.yml (15)
    M _data/ja.yml (15)
    M _data/pt-BR.yml (15)
    M _data/pt-PT.yml (15)
    M _data/ru.yml (15)
    M _data/zh-CN.yml (15)
    A _includes/dao_dashboard_tiles.html (56)
    M _includes/main_nav.html (4)
    A _layouts/dashboard.html (261)
    M _layouts/page.html (2)
    D _layouts/page_stats.html (70)
    M _plugins/custom_tag.rb (16)
    D _posts/2019-09-18-cycle-5-results.md (116)
    D _posts/2019-11-01-cycle-6-results.md (43)
    D _posts/2020-01-16-cycle-8-results.md (59)
    D _posts/2020-02-12-cycle-9-results.md (82)
    D _posts/2020-02-26-cycle-10-results.md (47)
    D _posts/2020-04-07-cycle-11-results.md (65)
    D _posts/2020-05-17-cycle-12-results.md (55)
    D _posts/2020-06-20-cycle-13-results.md (72)
    D _posts/2020-07-21-cycle-14-results.md (44)
    D _posts/2020-08-17-cycle-15-results.md (58)
    D _posts/2020-09-19-cycle-16-results.md (44)
    D _posts/2020-10-06-cycle-17-results.md (49)
    D _posts/2020-12-28-cycle-18-results.md (56)
    D _posts/2020-12-29-cycle-19-results.md (43)
    D _posts/2021-02-17-cycle-21-results.md (45)
    A _proposalcommentaries/cycle-1/571747.md (9)
    A _proposalcommentaries/cycle-10/613867.md (11)
    A _proposalcommentaries/cycle-11/618547.md (7)
    A _proposalcommentaries/cycle-11/d4daefe740bd4e1007ec0a0876049e992b06259d634a9eabeecc9067fd372aff.md (5)
    A _proposalcommentaries/cycle-11/ff5ee77458ff2b31aec6b27036bd3899e9821e55de8106f20a0cff7218976451.md (5)
    A _proposalcommentaries/cycle-12/3022d9acabc4e3805cd7317ad2bb311d264c74078f4c65c19227c2eec1d849e1.md (7)
    A _proposalcommentaries/cycle-12/3057f12f13e68a300a70739b39289b785c6d52a4b3332adaad4cc9044fe6bc5e.md (9)
    A _proposalcommentaries/cycle-13/3299d99a577611ea4e599ed547b6ee861527d8d3c8cbe7ee4f528f026d900881.md (9)
    A _proposalcommentaries/cycle-13/a1d90bd148b143dfd32935cad808d505281363ebb1229da052bfe4ecab1cbc24.md (5)
    A _proposalcommentaries/cycle-13/e56ae10d2f0f3232b019a0ffa954095fc6a3792e1a0b0be2bce0582d542987b0.md (7)
    A _proposalcommentaries/cycle-14/e9d769e7b6f9125a2decfa0f0483af6082fa1dc8411c0b9790adcca622b29605.md (9)
    A _proposalcommentaries/cycle-15/66169ea5c8d1ba72ac777c4f84cf708faf5f047a9e7a94f3aaeb583254fdc765.md (7)
    A _proposalcommentaries/cycle-15/88bbe0e8e24154ba37aa8b7bfad89ed8ca12bd89d4ad2ca7f890558a19354822.md (7)
    A _proposalcommentaries/cycle-16/c6dae566e95a1f4c2c40fef28f79d8cd8cb26a722171e82bb9eb4322927f7971.md (9)
    A _proposalcommentaries/cycle-17/6e6558bcc092b2d11f43b0ad4e229bec66a3648b53c9e2c3724f602638ced6c5.md (5)
    A _proposalcommentaries/cycle-18/7de1c11713ea58553833b5cd2ae8b0557bf83bde0a83134bbc64c15d6d4cd448.md (11)
    A _proposalcommentaries/cycle-18/f95eb74eea16db9cb8b77468f0170782caee7a20cfd82935637e9cdb5ad96268.md (7)
    A _proposalcommentaries/cycle-19/fbb556d1914c1c2a63ae912ed418b1df511202adc8bd6404b5097e478214055a.md (7)
    A _proposalcommentaries/cycle-2/15ebb38e62d555616b39909312cab5bb0d4036001692a7b75bc6d5cd520bdd59.md (23)
    A _proposalcommentaries/cycle-2/576427.md (7)
    A _proposalcommentaries/cycle-2/5a40b4763fa7373053f8320e8cca0d8159e7f5ef0b3e6674ca5b1ca44b8bfada.md (9)
    R _proposalcommentaries/cycle-20/665346.md (19)
    A _proposalcommentaries/cycle-21/cd003c1d5cdb5f301b1b32f323003270a9111b1ec4d5abd0ddc2f101b1b811a1.md (9)
    A _proposalcommentaries/cycle-22/3be6e7c18f9184e0fca7b2e0da2e19d5f03c2339ceccc2605aaaecec4ba3694b.md (5)
    A _proposalcommentaries/cycle-23/3373c55d8d48c37f9cbac60cce07d762975c57a0efb35553ee6e5c330ecbd1be.md (5)
    A _proposalcommentaries/cycle-3/581107.md (17)
    A _proposalcommentaries/cycle-4/585787.md (7)
    A _proposalcommentaries/cycle-4/d65b71b9b43f866a7b31e16f1c9dda722fcb56bdbac8123a074c50056d20f808.md (5)
    A _proposalcommentaries/cycle-5/4a59f592b5d81f90e36a939372640e3637c28930a9ab23a2af6ef1bd13bd9139.md (11)
    A _proposalcommentaries/cycle-5/590467.md (23)
    A _proposalcommentaries/cycle-5/79516359ae11ff0ac80f13c84d4870ee54c15703688c530b5198450cddd30622.md (7)
    A _proposalcommentaries/cycle-5/de1b4b55a040e1b78da7213c17a242b35672c02699b016d79aa8bc362e56ad49.md (7)
    A _proposalcommentaries/cycle-5/e4433aa7305080ff0e53f44dc501c29f316ca3466aee097d79d4b10a6fc71daf.md (7)
    A _proposalcommentaries/cycle-6/595147.md (5)
    A _proposalcommentaries/cycle-6/c9a7c6c04780b6c895d9273d8777459dd622625cbfef35fc502b2279b8e01067.md (7)
    A _proposalcommentaries/cycle-7/599827.md (5)
    R _proposalcommentaries/cycle-7/766686efa6e75dd41509b5896d6d29fb6927ec92d10bed7468ea3da1ae266858.md (44)
    A _proposalcommentaries/cycle-7/aed5b61cd5fdedbaa8095f7a2d6e29215cbcc2e0d29c7eddb4a8ff4b9fed10c2.md (11)
    A _proposalcommentaries/cycle-8/604507.md (9)
    A _proposalcommentaries/cycle-8/aa616eef833f3e6176b83e197da0db08166825eaeb80f0d39ff4dc472fd1af50.md (7)
    A _proposalcommentaries/cycle-8/aaf257f59e6ecefb46586f8d1ee90ab175c5d1545da02f9d8cc323c49826621d.md (9)
    A _proposalcommentaries/cycle-9/34de24c7d5e42ae3239e5943aed62cd3af185601828788f1649cdec96ebd2f49.md (7)
    A _proposalcommentaries/cycle-9/609187.md (9)
    A _proposalcommentaries/cycle-9/6a645427cfc3d5448d092a8d4e7558c4bf0f32f893627450d1e99f4ee6d1fad7.md (9)
    A _proposalcommentaries/cycle-9/74325029651f3319684a49774e75da05feb23d371500a1eb3a1534b8debb6207.md (9)
    A _proposalcommentaries/cycle-9/81747dad36dc823c37297bd6b067dbb8b30707d96b85050bbf321b7fa20ad8d4.md (11)
    A _proposalcommentaries/cycle-9/b6a242b02a1519b9eeb18dcddd51aa2935fe8f5631d7b5b0c25d377943afc51f.md (9)
    M _redirects (19)
    A css/fork-awesome.min.css (12)
    M css/styles.scss (201)
    A dashboard.html (33)
    D de/stats.md (8)
    D es/stats.md (8)
    A fonts/forkawesome-webfont.eot (0)
    A fonts/forkawesome-webfont.svg (2849)
    A fonts/forkawesome-webfont.ttf (0)
    A fonts/forkawesome-webfont.woff (0)
    A fonts/forkawesome-webfont.woff2 (0)
    D fr/stats.md (8)
    D ja/stats.md (8)
    A js/dashboard.js (79)
    D js/stats.js (225)
    D pt-BR/stats.md (8)
    D pt-PT/stats.md (8)
    D ru/stats.md (8)
    D stats.md (7)
    D zh-CN/stats.md (8)

-- Patch Links --

https://github.com/bisq-network/bisq-website/pull/449.patch
https://github.com/bisq-network/bisq-website/pull/449.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq-website/pull/449
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211028/0d6922c6/attachment-0001.htm>

From notifications at github.com  Fri Oct 29 07:00:49 2021
From: notifications at github.com (wiz)
Date: Thu, 28 Oct 2021 22:00:49 -0700
Subject: [bisq-network/roles] BTC donation address owner ("Burningman")
 (#80)
In-Reply-To: <bisq-network/roles/issues/80@github.com>
References: <bisq-network/roles/issues/80@github.com>
Message-ID: <bisq-network/roles/issues/80/954431024@github.com>

Yeah, @burningman2 should transfer to @burningman3 - anyone who can contact them, please pass the above message along

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/roles/issues/80#issuecomment-954431024
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211028/c0e4bd4a/attachment.htm>

From notifications at github.com  Fri Oct 29 07:10:37 2021
From: notifications at github.com (m52go)
Date: Thu, 28 Oct 2021 22:10:37 -0700
Subject: [bisq-network/bisq-website] Add semi-automated dashboard (PR #449)
In-Reply-To: <bisq-network/bisq-website/pull/449@github.com>
References: <bisq-network/bisq-website/pull/449@github.com>
Message-ID: <bisq-network/bisq-website/pull/449/push/8264601241@github.com>

@m52go pushed 1 commit.

e9933a428e7bef2f438dded25fe641f8fe57870a  Implement codacy suggestions


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/bisq-network/bisq-website/pull/449/files/75918b5bf677e1005f0d3082036935eb7203d766..e9933a428e7bef2f438dded25fe641f8fe57870a
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211028/624211a5/attachment.htm>

From notifications at github.com  Fri Oct 29 09:18:00 2021
From: notifications at github.com (asvdf)
Date: Fri, 29 Oct 2021 00:18:00 -0700
Subject: [bisq-network/proposals] Allow 1sat/vByte fee for withdrawals
 (#343)
In-Reply-To: <bisq-network/proposals/issues/343@github.com>
References: <bisq-network/proposals/issues/343@github.com>
Message-ID: <bisq-network/proposals/issues/343/954490367@github.com>

People spent probably a few cumulative hours of human time to discuss the issue of 1sat vs 2sat, while actually implementing the change in the code would have taken less than 5 minutes.

I beg to differ from wiz, the withdraw minimum custom fee is not set to double the mempool's suggested (probably you meant the trade miner fee?) I have had, and successfully took, the option of withdrawing funds at 2sat/vByte when the mempool block backlog was about 15 units.
It's a hardcoded 2sats value in the source. One developer needs to go to that line, delete 2 and write 1... and then I'd be able to account myself responsible for my own money without doing officially-non-recommended seed import on an external wallet software (that would take time and defeat the purpose of saving on fees, since time has a cost, too, see above). That mempool.space tag that tells me "overpaid 2x" really stings, that's how I am, so sue me.

One day 1sat vs 2sat will mean 1 dollar more, not 10c.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/proposals/issues/343#issuecomment-954490367
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211029/eb181c44/attachment.htm>

From notifications at github.com  Fri Oct 29 09:52:04 2021
From: notifications at github.com (Conza)
Date: Fri, 29 Oct 2021 00:52:04 -0700
Subject: [bisq-network/proposals] Allow 1sat/vByte fee for withdrawals
 (#343)
In-Reply-To: <bisq-network/proposals/issues/343@github.com>
References: <bisq-network/proposals/issues/343@github.com>
Message-ID: <bisq-network/proposals/issues/343/954509868@github.com>

Will bite my tongue re: save another rant, but allow the individual to control their own funds.

Give warnings, educate, remove mediation possibilities/escalations after properly indicating the risks etc etc. But allow FREEDOM OF CHOICE, I mean gawd damn.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/proposals/issues/343#issuecomment-954509868
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211029/f5063c02/attachment.htm>

From notifications at github.com  Fri Oct 29 10:55:10 2021
From: notifications at github.com (cd2357)
Date: Fri, 29 Oct 2021 01:55:10 -0700
Subject: [bisq-network/proposals] Allow 1sat/vByte fee for withdrawals
 (#343)
In-Reply-To: <bisq-network/proposals/issues/343@github.com>
References: <bisq-network/proposals/issues/343@github.com>
Message-ID: <bisq-network/proposals/issues/343/954569703@github.com>

There were periods when the min fee was 1sat/vB and when the mempool filled up for a few weeks, it caused countless issues with failed trades, DAO voting, BSQ compensation, support tickets, etc. People complaining
- "Bisq is broken, has too many bugs, it should just work"
- "My trade is hanging, I want my money back"
- "My trade failed, I want my fees back"

Many of us have spent a lot of time to optimize and minimize the mining fees (and overall trading fees) where possible:
- switched from earn.com to mempool.space fee estimation
- ongoing efforts to reduce trading protocol from 3 on-chain to 1 on-chain transactions
- year-long efforts, backed by generous donors, to fund custom dev work to fully enable segwit
- tweaking of fee estimation at different stages of the trade protocol, to ensure trade is reliable, but to not overpay
- and countless more

So it is an ongoing balancing act. Its not just "devs go find the line, edit, save, done".

My personal opinion: before asking for a code change, it might be worth it to first look for easier / more profitable / less disruptive ways to make up for the 1 sat/vB difference in withdrawal mining fees:
- for all your trades, pay the trading fees in BSQ instead of BTC (about 50% savings)
- become a market maker, instead of a taker (those who create offers pay much smaller trading fees)
- try to create trade offers when the mempool is free (lower estimated mining fees for both trade participants)
- instead of many trades with small amounts, go for fewer trades with higher amounts



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/proposals/issues/343#issuecomment-954569703
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211029/68a677f9/attachment.htm>

From notifications at github.com  Fri Oct 29 13:11:10 2021
From: notifications at github.com (metaltrance)
Date: Fri, 29 Oct 2021 04:11:10 -0700
Subject: [bisq-network/support] Fee reimbursement for trade 718499 (Issue
 #1014)
In-Reply-To: <bisq-network/support/issues/1014@github.com>
References: <bisq-network/support/issues/1014@github.com>
Message-ID: <bisq-network/support/issues/1014/954657333@github.com>

FYI: This issue just happened to me again on v1.7.5 so it does not seem to be resolved.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/support/issues/1014#issuecomment-954657333
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211029/b79a7e64/attachment.htm>

From notifications at github.com  Fri Oct 29 13:33:30 2021
From: notifications at github.com (asvdf)
Date: Fri, 29 Oct 2021 04:33:30 -0700
Subject: [bisq-network/proposals] Allow 1sat/vByte fee for withdrawals
 (#343)
In-Reply-To: <bisq-network/proposals/issues/343@github.com>
References: <bisq-network/proposals/issues/343@github.com>
Message-ID: <bisq-network/proposals/issues/343/954670431@github.com>

Thank you for the detailed reply, I am on point for each bullet of that last list :)
To let me get this straight: letting users go down to 1sat/vB fee when withdrawing funds from Bisq wallet to private wallet could be a problem because, if they then go and spend those unconfirmed UTXO's to start a new trade, it might mean a big headache if mempool fills up suddenly.
And this won't happen by paying 2sat/vByte instead?

All the while, the miner fee is usually hefty on trade opens, so the effective fee rate ends up being higher than what you originally set anyway.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/proposals/issues/343#issuecomment-954670431
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211029/6329dc21/attachment.htm>

From notifications at github.com  Fri Oct 29 13:50:55 2021
From: notifications at github.com (myp2132)
Date: Fri, 29 Oct 2021 04:50:55 -0700
Subject: [bisq-network/bisq] Cannot create P2PDataStorage.ByteArray with empty
 byte[] array argument. (Issue #5786)
Message-ID: <bisq-network/bisq/issues/5786@github.com>

Woke up this morning to this error.   
[bisq.log](https://github.com/bisq-network/bisq/files/7441642/bisq.log)


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5786
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211029/3d49a79c/attachment.htm>

From notifications at github.com  Fri Oct 29 13:50:55 2021
From: notifications at github.com (boring-cyborg[bot])
Date: Fri, 29 Oct 2021 04:50:55 -0700
Subject: [bisq-network/bisq] Cannot create P2PDataStorage.ByteArray with
 empty byte[] array argument. (Issue #5786)
In-Reply-To: <bisq-network/bisq/issues/5786@github.com>
References: <bisq-network/bisq/issues/5786@github.com>
Message-ID: <bisq-network/bisq/issues/5786/954679889@github.com>

**Thanks for opening your first issue here!**<br/><br/>Be sure to follow the issue template. Your issue will be reviewed by a maintainer and labeled for further action.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5786#issuecomment-954679889
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211029/a863f47e/attachment.htm>

From notifications at github.com  Fri Oct 29 14:41:04 2021
From: notifications at github.com (chimp1984)
Date: Fri, 29 Oct 2021 05:41:04 -0700
Subject: [bisq-network/proposals] Allow 1sat/vByte fee for withdrawals
 (#343)
In-Reply-To: <bisq-network/proposals/issues/343@github.com>
References: <bisq-network/proposals/issues/343@github.com>
Message-ID: <bisq-network/proposals/issues/343/954710781@github.com>

> until someday RBF is implemented in Bisq.

BitcoinJ has not implemented it and Bisq use BitcoinJ.
Beside that it would not help for trade transactions as they are created interactively by both traders. Thus a RBF tx would required to re-do the trade process and as it cannot be assumed that both peers are online at the same time after the trade this is not feasible to do.

10 sat might be too high, I think reducing min. fee to 5 sat might be safe IMO.

Going much lower to 1-3 sat are not worth the risk as a fee spike can lead to many failed trades. It is not only damage for the involved user who caused it by trying to save a few cents, but its damage to the trade peer and add costs for Bisq support and cause reputation damage for Bisq (not every user will understand the complex reasons).  

And it can be even worse as described above. When we had last time that fee spike with many failed trades, there have been a few power users how had a long chain of such transactions and polluted othere traders by that. This continued long after the fee spike. It was a nightmare. Damage for all involved was huge and I guess we lost quite some users in that time. Support costs have been considerable and it required also lot of dev support. So would estimate just that costs to about 10k USD.

So lets not play with fire after getting burnt several times in the past. Bisq is a complex collaborative system and not a single user model. Your savings can result in costs for others. Your risk appetite might cause damage to others.  

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/proposals/issues/343#issuecomment-954710781
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211029/37ce91e2/attachment.htm>

From notifications at github.com  Fri Oct 29 15:43:15 2021
From: notifications at github.com (jmacxx)
Date: Fri, 29 Oct 2021 06:43:15 -0700
Subject: [bisq-network/bisq] Cannot create P2PDataStorage.ByteArray with
 empty byte[] array argument. (Issue #5786)
In-Reply-To: <bisq-network/bisq/issues/5786@github.com>
References: <bisq-network/bisq/issues/5786@github.com>
Message-ID: <bisq-network/bisq/issues/5786/954755239@github.com>

Looks like a general network error that should have been handled gracefully.  Will look into it and make a bugfix, thanks for reporting.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5786#issuecomment-954755239
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211029/b5a4f73d/attachment-0001.htm>

From notifications at github.com  Fri Oct 29 15:53:01 2021
From: notifications at github.com (waleehoohaa)
Date: Fri, 29 Oct 2021 06:53:01 -0700
Subject: [bisq-network/support] Fee reimbursement for trade 718499 (Issue
 #1014)
In-Reply-To: <bisq-network/support/issues/1014@github.com>
References: <bisq-network/support/issues/1014@github.com>
Message-ID: <bisq-network/support/issues/1014/954762790@github.com>

ah. thanks for the info. i wanted to wait to upgrade to 1.7.5 until this
issue was resolved anyways.

On Fri, Oct 29, 2021 at 7:11 PM metaltrance ***@***.***>
wrote:

> FYI: This issue just happened to me again on v1.7.5 so it does not seem to
> be resolved.
>
> ?
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/bisq-network/support/issues/1014#issuecomment-954657333>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AWII2UJN34OZFBHMHJZ3VTLUJKFN5ANCNFSM5GX5ZVCA>
> .
> Triage notifications on the go with GitHub Mobile for iOS
> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android
> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>
>


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/support/issues/1014#issuecomment-954762790
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211029/c7d093a9/attachment.htm>

From notifications at github.com  Fri Oct 29 16:07:48 2021
From: notifications at github.com (Christoph Atteneder)
Date: Fri, 29 Oct 2021 07:07:48 -0700
Subject: [bisq-network/bisq] Release/v1.7.5 (PR #5787)
Message-ID: <bisq-network/bisq/pull/5787@github.com>


You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/5787

-- Commit Summary --

  * <a href="https://github.com/bisq-network/bisq/pull/5787/commits/8fbccb75479ffcb1e7b1fcc0feed03aa7fc55735">Bump version number for v1.7.5</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5787/commits/e39ae59683f6c45fd741063a364d7ae8366d43c9">Update translations for v1.7.5</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5787/commits/48a0ebe30973915fd80ff778a131d33a8012a616">Add new v3 onions for wiz&#39;s bitcoin nodes</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5787/commits/94d3638d9841c8653a5db40fa5b1c52fa3e3b0e4">Remove m52go bitcoin node</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5787/commits/8bcfbea47721263bbc5f59988e17b773d48f059b">Update data stores for v1.7.5</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5787/commits/32fcc69fcb330f845b821e8693ecb584d1132f37">Update bitcoinj checkpoints for v1.7.5</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5787/commits/aa1aa688486f56717b29b2f9dafe8e3580e02fae">Merge pull request #5781 from ripcurlx/update-data-stores-for-v1.7.5</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5787/commits/50798f0d628c02b937636026e25c54963e8c0401">Revert to SNAPSHOT version</a>

-- File Changes --

    M build.gradle (2)
    M common/src/main/java/bisq/common/app/Version.java (2)
    M core/src/main/java/bisq/core/btc/nodes/BtcNodes.java (10)
    M core/src/main/resources/i18n/displayStrings_cs.properties (215)
    M core/src/main/resources/i18n/displayStrings_de.properties (167)
    M core/src/main/resources/i18n/displayStrings_es.properties (137)
    M core/src/main/resources/i18n/displayStrings_fa.properties (137)
    M core/src/main/resources/i18n/displayStrings_fr.properties (137)
    M core/src/main/resources/i18n/displayStrings_it.properties (139)
    M core/src/main/resources/i18n/displayStrings_ja.properties (137)
    M core/src/main/resources/i18n/displayStrings_pt-br.properties (141)
    M core/src/main/resources/i18n/displayStrings_pt.properties (141)
    M core/src/main/resources/i18n/displayStrings_ru.properties (137)
    M core/src/main/resources/i18n/displayStrings_th.properties (137)
    M core/src/main/resources/i18n/displayStrings_vi.properties (157)
    M core/src/main/resources/i18n/displayStrings_zh-hans.properties (151)
    M core/src/main/resources/i18n/displayStrings_zh-hant.properties (137)
    M core/src/main/resources/wallet/checkpoints.txt (4)
    M desktop/package/linux/Dockerfile (2)
    M desktop/package/macosx/Info.plist (4)
    M desktop/package/macosx/copy_dbs.sh (2)
    M desktop/package/macosx/finalize.sh (2)
    M desktop/package/macosx/insert_snapshot_version.sh (2)
    M desktop/package/macosx/replace_version_number.sh (4)
    M p2p/src/main/resources/DaoStateStore_BTC_MAINNET (4)
    M p2p/src/main/resources/SignedWitnessStore_BTC_MAINNET (4)
    M relay/src/main/resources/version.txt (2)
    M seednode/src/main/java/bisq/seednode/SeedNodeMain.java (2)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/5787.patch
https://github.com/bisq-network/bisq/pull/5787.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5787
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211029/11d2751d/attachment.htm>

From notifications at github.com  Fri Oct 29 16:33:15 2021
From: notifications at github.com (jmacxx)
Date: Fri, 29 Oct 2021 07:33:15 -0700
Subject: [bisq-network/bisq-website] Add semi-automated dashboard (PR #449)
In-Reply-To: <bisq-network/bisq-website/pull/449@github.com>
References: <bisq-network/bisq-website/pull/449@github.com>
Message-ID: <bisq-network/bisq-website/pull/449/review/793112857@github.com>

@jmacxx approved this pull request.

utACK



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq-website/pull/449#pullrequestreview-793112857
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211029/a291f9d3/attachment.htm>

From notifications at github.com  Fri Oct 29 17:24:50 2021
From: notifications at github.com (m52go)
Date: Fri, 29 Oct 2021 08:24:50 -0700
Subject: [bisq-network/bisq-website] Add semi-automated dashboard (PR #449)
In-Reply-To: <bisq-network/bisq-website/pull/449@github.com>
References: <bisq-network/bisq-website/pull/449@github.com>
Message-ID: <bisq-network/bisq-website/pull/449/push/8268747797@github.com>

@m52go pushed 1 commit.

daea718622837c7a8b47360c08a40096e24ed1f5  Remove try-catch blocks in python scripts


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/bisq-network/bisq-website/pull/449/files/e9933a428e7bef2f438dded25fe641f8fe57870a..daea718622837c7a8b47360c08a40096e24ed1f5
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211029/08c4f944/attachment-0001.htm>

From notifications at github.com  Fri Oct 29 17:31:33 2021
From: notifications at github.com (m52go)
Date: Fri, 29 Oct 2021 08:31:33 -0700
Subject: [bisq-network/bisq-website] Add semi-automated dashboard (PR #449)
In-Reply-To: <bisq-network/bisq-website/pull/449@github.com>
References: <bisq-network/bisq-website/pull/449@github.com>
Message-ID: <bisq-network/bisq-website/pull/449/push/8268797703@github.com>

@m52go pushed 2 commits.

fef7f96bf821ba41eba97c32c8b0aef57024f7b3  Implement codacy suggestions
b6f5e9f4a5b5862fee2c1a096fb0d9ab82d62c6b  Remove try-catch blocks in python scripts


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/bisq-network/bisq-website/pull/449/files/daea718622837c7a8b47360c08a40096e24ed1f5..b6f5e9f4a5b5862fee2c1a096fb0d9ab82d62c6b
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211029/ebb1058f/attachment.htm>

From notifications at github.com  Fri Oct 29 17:39:01 2021
From: notifications at github.com (m52go)
Date: Fri, 29 Oct 2021 08:39:01 -0700
Subject: [bisq-network/bisq-website] Add semi-automated dashboard (PR #449)
In-Reply-To: <bisq-network/bisq-website/pull/449@github.com>
References: <bisq-network/bisq-website/pull/449@github.com>
Message-ID: <bisq-network/bisq-website/pull/449/c954841732@github.com>

Just added some minor tweaks to get rid of Codacy flags.

The [general concept](https://github.com/bisq-network/growth/issues/245) has been open for feedback for months, and most content has already been live in the form of blog posts. This code's main contribution is to create a new automated workflow to create cycle reports, which it does well, so it kind of passes its own test.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq-website/pull/449#issuecomment-954841732
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211029/30cfcebb/attachment.htm>

From notifications at github.com  Fri Oct 29 17:39:13 2021
From: notifications at github.com (m52go)
Date: Fri, 29 Oct 2021 08:39:13 -0700
Subject: [bisq-network/bisq-website] Add semi-automated dashboard (PR #449)
In-Reply-To: <bisq-network/bisq-website/pull/449@github.com>
References: <bisq-network/bisq-website/pull/449@github.com>
Message-ID: <bisq-network/bisq-website/pull/449/issue_event/5541399451@github.com>

Merged #449 into master.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq-website/pull/449#event-5541399451
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211029/0276192f/attachment.htm>

From notifications at github.com  Fri Oct 29 18:52:36 2021
From: notifications at github.com (leo816)
Date: Fri, 29 Oct 2021 09:52:36 -0700
Subject: [bisq-network/support] Fee reimbursement for trade 46190 (#531)
In-Reply-To: <bisq-network/support/issues/531@github.com>
References: <bisq-network/support/issues/531@github.com>
Message-ID: <bisq-network/support/issues/531/954896144@github.com>

Reimbursement here will be done this cycle. that is in the next 5 days.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/support/issues/531#issuecomment-954896144
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211029/c6d2cfce/attachment.htm>

From notifications at github.com  Fri Oct 29 19:55:39 2021
From: notifications at github.com (jmacxx)
Date: Fri, 29 Oct 2021 10:55:39 -0700
Subject: [bisq-network/bisq] Gracefully handle null data in refresh offer
 message and log error (PR #5788)
Message-ID: <bisq-network/bisq/pull/5788@github.com>

User reported an unhandled exception popup in v1.7.5.

Just before the issue the client did get a disconnect: `b.n.p.n.Connection: proto is null because protoInputStream.read()=-1 (EOF). That is expected if client got stopped without proper shutdown.`

A offer refresh TTL message should not contain incomplete data, but is possible if the network connection is interrupted.  There are other examples of interrupted network messages already logged.



Fix is to catch and log the exception stack trace.  Just adds a try..catch block in `P2PDataStorage.refreshTTL`.
Fixes #5786

_If there is an alternative way to handle this, let me know.  @bisq-network/bisq-devs_ 


---


### Before

![crash_p2p_exception](https://user-images.githubusercontent.com/47253594/139478724-dc5cfc4b-deb4-4ae7-95c6-e80bca4dee77.png)

### After:

**[[NO POPUP SHOWN]]**

**and logfile contains a stack trace of the error:**

    WARN  b.n.p.n.Connection: proto is null because protoInputStream.read()=-1 (EOF). That is expected if client got stopped without proper shutdown. 
    java.lang.IllegalArgumentException: Cannot create P2PDataStorage.ByteArray with null byte[] array argument.
	    at bisq.network.p2p.storage.P2PDataStorage$ByteArray.verifyBytesNotEmpty(P2PDataStorage.java:1193)
	    at bisq.network.p2p.storage.P2PDataStorage$ByteArray.&lt;init&gt;(P2PDataStorage.java:1188)
	    at bisq.network.p2p.storage.P2PDataStorage.refreshTTL(P2PDataStorage.java:850)
	    at bisq.network.p2p.storage.P2PDataStorage.lambda$onMessage$22(P2PDataStorage.java:585)
	    at java.base/java.util.Optional.ifPresent(Optional.java:183)
	    at bisq.network.p2p.storage.P2PDataStorage.onMessage(P2PDataStorage.java:577)
	    at bisq.network.p2p.network.NetworkNode.lambda$onMessage$6(NetworkNode.java:392)
	    at java.base/java.util.Spliterators$ArraySpliterator.forEachRemaining(Spliterators.java:948)
	    at java.base/java.util.stream.ReferencePipeline$Head.forEach(ReferencePipeline.java:658)
	    at bisq.network.p2p.network.NetworkNode.onMessage(NetworkNode.java:392)
	    at bisq.network.p2p.network.Connection.lambda$onBundleOfEnvelopes$11(Connection.java:470)
	    at java.base/java.util.concurrent.CopyOnWriteArrayList.forEach(CopyOnWriteArrayList.java:803)
	    at java.base/java.util.concurrent.CopyOnWriteArraySet.forEach(CopyOnWriteArraySet.java:425)
	    at bisq.network.p2p.network.Connection.lambda$onBundleOfEnvelopes$12(Connection.java:470)
	    at com.sun.javafx.application.PlatformImpl.lambda$runLater$10(PlatformImpl.java:428)
	    at java.base/java.security.AccessController.doPrivileged(Native Method)
	    at com.sun.javafx.application.PlatformImpl.lambda$runLater$11(PlatformImpl.java:427)
	    at com.sun.glass.ui.InvokeLaterDispatcher$Future.run(InvokeLaterDispatcher.java:96)
	    at com.sun.glass.ui.gtk.GtkApplication._runLoop(Native Method)
	    at com.sun.glass.ui.gtk.GtkApplication.lambda$runLoop$11(GtkApplication.java:277)
	    at java.base/java.lang.Thread.run(Thread.java:834)


You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/5788

-- Commit Summary --

  * <a href="https://github.com/bisq-network/bisq/pull/5788/commits/e65a992b2681906b7c134057206332afcfa6164c">Gracefully handle null data in refresh offer message and log error</a>

-- File Changes --

    M p2p/src/main/java/bisq/network/p2p/storage/P2PDataStorage.java (57)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/5788.patch
https://github.com/bisq-network/bisq/pull/5788.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5788
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211029/589d497d/attachment-0001.htm>

From notifications at github.com  Fri Oct 29 20:05:22 2021
From: notifications at github.com (asvdf)
Date: Fri, 29 Oct 2021 11:05:22 -0700
Subject: [bisq-network/proposals] Allow 1sat/vByte fee for withdrawals
 (#343)
In-Reply-To: <bisq-network/proposals/issues/343@github.com>
References: <bisq-network/proposals/issues/343@github.com>
Message-ID: <bisq-network/proposals/issues/343/954943178@github.com>

I think you are still talking about trade fees while I am talking about withdrawing my own funds to my own wallet and being able to choose my own fee, be it even 1sat/vB, being totally fine to get it after a week, if ever.
I could do CPFP if I really need it, but let me get down to 1sat/vB when withdrawing to my own wallet, and remove the 2sat/vB limitation please.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/proposals/issues/343#issuecomment-954943178
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211029/d6222164/attachment.htm>

From notifications at github.com  Fri Oct 29 21:21:39 2021
From: notifications at github.com (chimp1984)
Date: Fri, 29 Oct 2021 12:21:39 -0700
Subject: [bisq-network/proposals] New role request- User Researcher (#344)
In-Reply-To: <bisq-network/proposals/issues/344@github.com>
References: <bisq-network/proposals/issues/344@github.com>
Message-ID: <bisq-network/proposals/issues/344/954992665@github.com>

@UX-P Great thanks for all that work! Very valueable collection of issues to improve.

Regarding shortcuts:
I think those which are more essential should get a button in the relevant UI screen to open the info directly. Shortcuts have been intended to be for non critical info and for expert users. But some of those you mention clearly do not fall into that category. 

Maybe @jmacxx find some dev bandwidth to target some of those issues.  

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/proposals/issues/344#issuecomment-954992665
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211029/55f23fba/attachment.htm>

From notifications at github.com  Fri Oct 29 21:27:57 2021
From: notifications at github.com (chimp1984)
Date: Fri, 29 Oct 2021 12:27:57 -0700
Subject: [bisq-network/proposals] Allow 1sat/vByte fee for withdrawals
 (#343)
In-Reply-To: <bisq-network/proposals/issues/343@github.com>
References: <bisq-network/proposals/issues/343@github.com>
Message-ID: <bisq-network/proposals/issues/343/954996887@github.com>

You seem to ignore my comment that a change output of a withdrawal can be used for the next offer/trade and thus affect other users. Sure there can be the isolated single user case but most users are not aware of the details (like change). Requireing confirmation before using funds for offers/trades would decrease UX a lot, so thats our of question and was also never a problem, beside the cases when txs got stuck because of too low fees.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/proposals/issues/343#issuecomment-954996887
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211029/fa36a492/attachment.htm>

From notifications at github.com  Fri Oct 29 22:01:54 2021
From: notifications at github.com (pazza)
Date: Fri, 29 Oct 2021 13:01:54 -0700
Subject: [bisq-network/proposals] Allow 1sat/vByte fee for withdrawals
 (#343)
In-Reply-To: <bisq-network/proposals/issues/343@github.com>
References: <bisq-network/proposals/issues/343@github.com>
Message-ID: <bisq-network/proposals/issues/343/955015076@github.com>

Having read the comments about the risks of low fees for withdrawals I am giving this proposal a thumbs down. I a a big fan of low fees and the ability to transfer out sats at a miner fee of your choosing, but not when it will potentially impact subsequent trades negatively impact the experience of other users. 

Still think it would be good in the long run to look at ways to reduce miner fees on trades and withdrawals.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/proposals/issues/343#issuecomment-955015076
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211029/7ba59806/attachment.htm>

From notifications at github.com  Fri Oct 29 22:06:05 2021
From: notifications at github.com (jmacxx)
Date: Fri, 29 Oct 2021 13:06:05 -0700
Subject: [bisq-network/projects] Dev Call - Priorities (#60)
In-Reply-To: <bisq-network/projects/issues/60@github.com>
References: <bisq-network/projects/issues/60@github.com>
Message-ID: <bisq-network/projects/issues/60/955017379@github.com>

## Dev call 2021-10-29

### Topics & Priorities

- **Bisq mobile**: new potential contributor to be put into contact with Devin.

- **BSQ<->BTC atomic swap**
PRs and refactorings done, being reviewed by @stejbac, @ghubstan, @ripcurlx et al.

- **DAO performance improvement / refactor**
PRs ready for review & testing.  Action all devs.

- **v1.8.0** - We should allocate more time for testing this cycle due to the major changes.  Several more days would be good, so that full regression testing can be performed.  Action @ripcurlx @BtcContributor

- @ripcurlx now has immunity to all viruses (:crossed_fingers: )

- **API**: @ghubstan to continue.

- **Running Bisq on Umbrel** - @ghubstan to consider investigating.

- **Discussion of** https://github.com/bisq-network/proposals/issues/344
Action item for all: give feedback.
See if a small scale project can be defined, with suitable budget.  Project better focus than 'role'.
@pazza83 - One possible project idea would be to solicit input from XMR users.

- **Payment methods** - not mentioned in the meeting, but there are a [few more left to add](https://github.com/bisq-network/bisq/discussions/5462). Action @jmacxx

- @jimmyneutront expressed the desire to hear more about **X Protocol** progress.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/projects/issues/60#issuecomment-955017379
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211029/dc67ca43/attachment-0001.htm>

From notifications at github.com  Fri Oct 29 22:13:29 2021
From: notifications at github.com (pazza)
Date: Fri, 29 Oct 2021 13:13:29 -0700
Subject: [bisq-network/proposals] New role request- User Researcher (#344)
In-Reply-To: <bisq-network/proposals/issues/344@github.com>
References: <bisq-network/proposals/issues/344@github.com>
Message-ID: <bisq-network/proposals/issues/344/955021306@github.com>

Thanks @UX-P for this feedback.

I like the affinity map as a way of presenting the Keybase support enquires. Makes for interesting reading.

> Error messages were also a common issue. The user seems to be unclear of their next steps e.g. error reads ?Contact a Bisq developer? without providing a call to action button, contact or link. The language used in the error messages is often incomprehensible to the user, it is important to use language that the user is familiar with where possible.

> Although Keybase is great for discussing certain issues, Users are seeking that immediate help. There does not appear to be enough guidance given directly from the Bisq app itself, which is where the user would initially look for support.

I agree with these points. I suggested promoting [Keybase in the Bisq app](https://github.com/bisq-network/bisq/issues/4904) to streamline users that have issues to Keybase where issues can be most effectively handled. 

> P2P interaction should be encouraged so that it does not result in the user having to contact support.

I agree with this also. It would be great if users were prompted to communicate with peer to resolve issues before opening mediation tickets., especially when the trade window is still open. 

> Show if peer is online with the option to switch status to offline.  

This would be a privacy concern. Especially when traders may have their counterparties address!! 



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/proposals/issues/344#issuecomment-955021306
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211029/526337e3/attachment.htm>

From notifications at github.com  Fri Oct 29 22:26:33 2021
From: notifications at github.com (pazza)
Date: Fri, 29 Oct 2021 13:26:33 -0700
Subject: [bisq-network/proposals] New role request- User Researcher (#344)
In-Reply-To: <bisq-network/proposals/issues/344@github.com>
References: <bisq-network/proposals/issues/344@github.com>
Message-ID: <bisq-network/proposals/issues/344/955028388@github.com>

With regards the user researcher role. I think it would make sense to limit the role initially to one project at a time.

On a recent [Bisq dev call](https://github.com/bisq-network/projects/issues/60#issuecomment-944453142) the issue of the following was discussed: 

`Monero is our most traded altcoin, we should learn as much as possible and make sure we are doing what we can to attract as many users.`

To date it has been difficult to get feedback from Monero traders. Both myself and @leo816 have been asking Monero traders when they have mediation tickets open if they have any feedback or suggestions as to how Bisq can improve but feedback has not been very forthcoming.

Maybe something like an anonymous online survey that could be access via Tor could be used to encourage traders to be more comfortable sharing feedback and suggestions.

I feel the Monero issue is an important one and so far Bisq has not been able to learn much from Bisq's Monero community.

If other Bisq contributors / stakeholder felt this would be a good project to complete, and if it is something you would be interested in, maybe you could create a fresh proposal that would define a clear project brief and budget.







-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/proposals/issues/344#issuecomment-955028388
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211029/89f74b8a/attachment.htm>

From notifications at github.com  Fri Oct 29 22:59:45 2021
From: notifications at github.com (asvdf)
Date: Fri, 29 Oct 2021 13:59:45 -0700
Subject: [bisq-network/proposals] Allow 1sat/vByte fee for withdrawals
 (#343)
In-Reply-To: <bisq-network/proposals/issues/343@github.com>
References: <bisq-network/proposals/issues/343@github.com>
Message-ID: <bisq-network/proposals/issues/343/955044404@github.com>

> 
> 
> You seem to ignore my comment that a change output of a withdrawal can be used for the next offer/trade and thus affect other users. Sure there can be the isolated single user case but most users are not aware of the details (like change). Requireing confirmation before using funds for offers/trades would decrease UX a lot, so thats our of question and was also never a problem, beside the cases when txs got stuck because of too low fees.

I wasn't actually ignoring this peculiar use case, rather placing it in its context, which is in fact peculiar: someone withdrawing funds to external wallet by using just part of a UTXO, and spending the unconfirmed change to make/take another trade... even if withdraw fees were not the issue at hand, it seems curious to even let users do that in the first place (spending unconfirmed UTXO on trade deposit) while, in order to let users do exactly that, you don't let them withdraw their funds at the go-to fee rate instead.

I hope this dilemma will be sorted out in the near future as it sounds a bit concerning to me, past the merits themselves (or lack thereof) of saving 1sat/vB on  withdraw fees: it's cool that you can make offers even before deposit tx is confirmed, but using unconfirmed parent on top of that? hmmm

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/proposals/issues/343#issuecomment-955044404
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211029/5fb26954/attachment.htm>

From notifications at github.com  Sat Oct 30 00:13:22 2021
From: notifications at github.com (chimp1984)
Date: Fri, 29 Oct 2021 15:13:22 -0700
Subject: [bisq-network/proposals] Allow 1sat/vByte fee for withdrawals
 (#343)
In-Reply-To: <bisq-network/proposals/issues/343@github.com>
References: <bisq-network/proposals/issues/343@github.com>
Message-ID: <bisq-network/proposals/issues/343/955076850@github.com>

To use unconfirmed inputs for the trade has no security issues as a doublespend would render the whole trade txs invalid. The usability costs to need to wait for a confirmation when funding your wallet are much higher than the benefit to let users choose minimal miner fees in withdrawals and require them then to wait for confirmations of change outputs to avoid the risk that it leads to failed trades.  

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/proposals/issues/343#issuecomment-955076850
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211029/8231f818/attachment.htm>

From notifications at github.com  Sat Oct 30 08:41:43 2021
From: notifications at github.com (dcar2121)
Date: Fri, 29 Oct 2021 23:41:43 -0700
Subject: [bisq-network/bisq] Merge pull request #5781 from
 ripcurlx/update-data-stores-for-v1.7.5 (aa1aa68)
In-Reply-To: <bisq-network/bisq/commit/aa1aa688486f56717b29b2f9dafe8e3580e02fae@github.com>
References: <bisq-network/bisq/commit/aa1aa688486f56717b29b2f9dafe8e3580e02fae@github.com>
Message-ID: <bisq-network/bisq/commit/aa1aa688486f56717b29b2f9dafe8e3580e02fae/58959811@github.com>

// TX = {
//   contract: String
//   poll: String (Optional)(Defaults to name)
//   name: String
//   display: String  (Optional)(Defaults to name)
//   errMsg: String
//   onTxHash: {}Strings
//   successMsg: String
// }

import { HASH } from '../utils/general';
import { MINION_TYPES } from '../utils/proposalUtils';

export const CONTRACTS = {
  CURRENT_MOLOCH: {
    location: 'local',
    abiName: 'MOLOCH_V2',
    contractAddress: '.contextData.daoid',
  },
  MINION_ACTION: {
    location: 'fetch',
    // abiName: 'VANILLA_MINION',
    contractAddress: '.values.targetContract',
  },
  SELECTED_MINION: {
    location: 'local',
    abiName: 'VANILLA_MINION',
    contractAddress: '.values.selectedMinion',
  },
  SELECTED_MINION_NIFTY: {
    location: 'local',
    abiName: 'NIFTY_MINION',
    contractAddress: '.values.selectedMinion',
  },
  SELECTED_MINION_SAFE: {
    location: 'local',
    abiName: 'SAFE_MINION',
    contractAddress: '.values.selectedMinion',
  },
  ERC_20: {
    location: 'local',
    abiName: 'ERC_20',
    contractAddress: '.values.tokenAddress',
  },
  ERC_721: {
    location: 'local',
    abiName: 'ERC_721',
    contractAddress: '.values.nftAddress',
  },
  LOCAL_ERC_721: {
    location: 'local',
    abiName: 'ERC_721',
    contractAddress: '.localValues.contractAddress',
  },
  LOCAL_ERC_1155: {
    location: 'local',
    abiName: 'ERC_1155',
    contractAddress: '.localValues.contractAddress',
  },
  LOCAL_ERC_1155_METADATA: {
    location: 'local',
    abiName: 'ERC_1155_METADATA',
    contractAddress: '.localValues.contractAddress',
  },
  LOCAL_VANILLA_MINION: {
    location: 'local',
    abiName: 'VANILLA_MINION',
    contractAddress: '.localValues.minionAddress',
  },
  LOCAL_NIFTY_MINION: {
    location: 'local',
    abiName: 'NIFTY_MINION',
    contractAddress: '.localValues.minionAddress',
  },
  LOCAL_SAFE_MINION: {
    location: 'local',
    abiName: 'SAFE_MINION',
    contractAddress: '.localValues.minionAddress',
  },
  LOCAL_SAFE_MULTISEND: {
    location: 'local',
    abiName: 'SAFE_MULTISEND',
    contractAddress: '.contextData.chainConfig.safeMinion.safe_mutisend_addr',
  },
  LOCAL_SAFE_SIGNLIB: {
    location: 'local',
    abiName: 'SAFE_SIGNLIB',
    contractAddress: '.contextData.chainConfig.safeMinion.safe_sign_lib_addr',
  },
  LOCAL_ERC_20: {
    location: 'local',
    abiName: 'ERC_20',
    contractAddress: '.localValues.tokenAddress',
  },
  NIFTY_INK: {
    location: 'local',
    abiName: 'NIFTY_INK',
    contractAddress: '0xcf964c89f509a8c0ac36391c5460df94b91daba5',
  },
  MINION_SIMPLE_EXECUTE: {
    location: 'local',
    abiName: 'VANILLA_MINION',
    contractAddress: '.localValues.minionAddress',
  },
  MINION_SAFE_EXECUTE: {
    location: 'local',
    abiName: 'SAFE_MINION',
    contractAddress: '.localValues.minionAddress',
  },
  UBERHAUS_MINION: {
    location: 'local',
    abiName: 'UBERHAUS_MINION',
    contractAddress: '.localValues.minionAddress',
  },
  SUPERFLUID_MINION_LOCAL: {
    location: 'local',
    abiName: 'SUPERFLUID_MINION',
    contractAddress: '.localValues.minionAddress',
  },
  SUPERFLUID_MINION_SELECT: {
    location: 'local',
    abiName: 'SUPERFLUID_MINION',
    contractAddress: '.values.selectedMinion',
  },
  SUPERFLUID_MINION_FACTORY: {
    location: 'local',
    abiName: 'SUPERFLUID_MINION_FACTORY',
    contractAddress: '.contextData.chainConfig.superfluid.minion_factory_addr',
  },
  SAFE_MINION_FACTORY: {
    location: 'local',
    abiName: 'SAFE_MINION_FACTORY',
    contractAddress: '.contextData.chainConfig.safeMinion.minion_factory_addr',
  },
  NIFTY_MINION_FACTORY: {
    location: 'local',
    abiName: 'NIFTY_MINION_FACTORY',
    contractAddress: '.contextData.chainConfig.niftyMinion.minion_factory_addr',
  },
  VANILLA_MINION_FACTORY: {
    location: 'local',
    abiName: 'VANILLA_MINION_FACTORY',
    contractAddress: '.contextData.chainConfig.minion_factory_addr',
  },
  WRAP_N_ZAP_FACTORY: {
    location: 'local',
    abiName: 'WRAP_N_ZAP_FACTORY',
    contractAddress: '.contextData.chainConfig.wrap_n_zap_factory_addr',
  },
  WRAP_N_ZAP: {
    location: 'local',
    abiName: 'WRAP_N_ZAP',
    contractAddress: '.localValues.contractAddress',
  },
  DAO_CONDITIONAL_HELPER: {
    location: 'local',
    abiName: 'DAO_CONDITIONAL_HELPER',
    contractAddress: '.contextData.chainConfig.dao_conditional_helper_addr',
  },
  PAYMENT_ERC_20: {
    location: 'local',
    abiName: 'ERC_20',
    contractAddress: 'values.paymentToken',
  },
  ESCROW_MINION: {
    location: 'local',
    abiName: 'ESCROW_MINION',
    contractAddress: '.contextData.chainConfig.escrow_minion',
  },
};

export const ACTIONS = {
  PROPOSAL: ['closeProposalModal', 'openTxModal'],
  BASIC: ['openTxModal'],
  GENERIC_MODAL: ['closeGenericModal', 'openTxModal'],
};

//  HASH.EMPTY_FIELD with '||' allows the search to turn up
//  falsy without crashing searchFields()

//  buildJSONdetails simply filters any values that are HASH.EMPTY_FIELD
//  any other falsy will get stringified as is.

export const DETAILS = {
  STANDARD_PROPOSAL: {
    title: `.values.title`,
    description: `.values.description || ${HASH.EMPTY_FIELD}`,
    link: `.values.link || ${HASH.EMPTY_FIELD}`,
    proposalType: '.formData.type',
  },
  VANILLA_MINION_PROPOSAL: {
    title: `.values.title`,
    description: `.values.description`,
    proposalType: '.formData.type',
    minionType: MINION_TYPES.VANILLA,
  },
  PAYROLL_PROPOSAL: {
    title: 'Minion sends a token',
    description: '.values.description',
    proposalType: '.formData.type',
    minionType: '.formData.minionType',
  },
  MINION_NFT_TRANSFER: {
    title: 'Minion sends a NFT',
    description: '.values.description',
    proposalType: '.formData.type',
  },
  MINION_SELL_NIFTY: {
    title: 'Minion sets Nifty price',
    description: '.values.description',
    proposalType: '.formData.type',
    minionType: MINION_TYPES.VANILLA,
  },
  MINION_BUY_NIFTY: {
    title: 'Minion Buys a NiftyInk',
    description: '.values.nftMetadata.name',
    link: '.values.nftMetadata.image',
    proposalType: '.formData.type',
    minionType: MINION_TYPES.NIFTY,
  },
  SUPERFLUID_STREAM: {
    title: `.values.title`,
    description: `.values.description || ${HASH.EMPTY_FIELD}`,
    link: `.values.link || ${HASH.EMPTY_FIELD}`,
    proposalType: '.formData.type',
    recipient: '.values.applicant',
    token: '.values.paymentToken',
    tokenRate: '.values.rateString',
  },
  SELL_NFT_RARIBLE: {
    title: 'Rarible NFT Sell Order',
    description: '.values.raribleDescription',
    link: '.values.image',
    proposalType: '.formData.type',
    minionType: MINION_TYPES.SAFE,
    orderIpfsHash: '.values.ipfsOrderHash',
    eip712HashValue: '.values.eip712HashValue',
  },
  SET_BUYOUT_TOKEN: {
    title: '.values.title',
    description: `.values.description || ${HASH.EMPTY_FIELD}`,
    link: `.values.link || ${HASH.EMPTY_FIELD}`,
    proposalType: '.formData.type',
    minionType: MINION_TYPES.SAFE,
  },
  SET_BUYOUT_NFT: {
    title: '.values.title',
    description: '.values.description',
    link: '.values.link',
    proposalType: '.formData.type',
    minionType: MINION_TYPES.SAFE,
  },
  OFFER_NFT_TRIBUTE: {
    title: '.values.title',
    description: '.values.description',
    link: '.values.link',
    proposalType: '.formData.type',
  },
  BUY_NFT_RARIBLE: {
    title: 'Rarible NFT Buy Order',
    description: '.values.nftDescription',
    link: '.values.image',
    proposalType: '.formData.type',
    minionType: MINION_TYPES.SAFE,
    orderIpfsHash: '.values.ipfsOrderHash',
    eip712HashValue: '.values.eip712HashValue',
  },
};

export const TX = {
  SUBMIT_PROPOSAL: {
    contract: CONTRACTS.CURRENT_MOLOCH,
    name: 'submitProposal',
    onTxHash: ACTIONS.PROPOSAL,
    poll: 'subgraph',
    display: 'Submit Proposal',
    errMsg: 'Error submitting proposal',
    successMsg: 'Proposal submitted!',
    gatherArgs: [
      '.values.applicant || .contextData.address',
      '.values.sharesRequested || 0',
      '.values.lootRequested || 0',
      '.values.tributeOffered || 0',
      '.values.tributeToken || .contextData.daoOverview.depositToken.tokenAddress',
      '.values.paymentRequested || 0',
      '.values.paymentToken || .contextData.daoOverview.depositToken.tokenAddress',
      { type: 'detailsToJSON', gatherFields: DETAILS.STANDARD_PROPOSAL },
    ],
    createDiscourse: true,
  },
  LOOT_GRAB_PROPOSAL: {
    contract: CONTRACTS.CURRENT_MOLOCH,
    name: 'submitProposal',
    onTxHash: ACTIONS.PROPOSAL,
    poll: 'subgraph',
    display: 'Submit Loot Grab Proposal',
    errMsg: 'Error submitting proposal',
    successMsg: 'Loot Grab submitted!',
    gatherArgs: [
      '.contextData.address',
      0,
      '.values.lootRequested',
      '.values.tributeOffered',
      '.values.tributeToken',
      0,
      '.contextData.daoOverview.depositToken.tokenAddress',
      JSON.stringify({
        title: 'Loot Grab Proposal',
        description: 'Trade Tokens for Loot',
      }),
    ],
  },
  GUILDKICK_PROPOSAL: {
    contract: CONTRACTS.CURRENT_MOLOCH,
    name: 'submitGuildKickProposal',
    poll: 'subgraph',
    onTxHash: ACTIONS.PROPOSAL,
    display: 'Submit GuildKick Proposal',
    errMsg: 'Error submitting proposal',
    successMsg: 'Guild Kick Proposal submitted!',
    createDiscourse: true,
    gatherArgs: [
      '.values.applicant',
      { type: 'detailsToJSON', gatherFields: DETAILS.STANDARD_PROPOSAL },
    ],
  },
  WHITELIST_TOKEN_PROPOSAL: {
    contract: CONTRACTS.CURRENT_MOLOCH,
    name: 'submitWhitelistProposal',
    poll: 'subgraph',
    onTxHash: ACTIONS.PROPOSAL,
    display: 'Whitelist Token Proposal',
    errMsg: 'Error submitting proposal',
    successMsg: 'Token Proposal submitted!',
    createDiscourse: true,
    gatherArgs: [
      '.values.tokenAddress',
      { type: 'detailsToJSON', gatherFields: DETAILS.STANDARD_PROPOSAL },
    ],
  },
  UNLOCK_TOKEN: {
    contract: CONTRACTS.ERC_20,
    name: 'approve',
    specialPoll: 'unlockToken',
    onTxHash: null,
    display: 'Approve Spend Token',
    errMsg: 'Approve Token Failed',
    successMsg: 'Approved Token!',
  },
  UNLOCK_NFTS: {
    contract: CONTRACTS.LOCAL_ERC_721,
    name: 'setApprovalForAll',
    specialPoll: 'approveAllTokens',
    onTxHash: null,
    display: 'Approve All Tokens',
    errMsg: 'Approve Tokens Failed',
    successMsg: 'Approved Tokens!',
  },
  MINION_PROPOSE_ACTION: {
    contract: CONTRACTS.SELECTED_MINION,
    name: 'proposeAction',
    poll: 'subgraph',
    onTxHash: ACTIONS.PROPOSAL,
    display: 'Propose Minion Action',
    errMsg: 'Error submitting action to minion',
    successMsg: 'Minion Proposal Created!',
    createDiscourse: true,
    argsFromCallback: 'proposeActionVanilla',
  },
  MINION_PROPOSE_ACTION_NIFTY: {
    contract: CONTRACTS.SELECTED_MINION_NIFTY,
    name: 'proposeAction',
    poll: 'subgraph',
    onTxHash: ACTIONS.PROPOSAL,
    display: 'Propose Minion Action',
    errMsg: 'Error submitting action to minion',
    successMsg: 'Minion Proposal Created!',
    argsFromCallback: 'proposeActionNifty',
    createDiscourse: true,
  },
  MINION_PROPOSE_ACTION_SAFE: {
    contract: CONTRACTS.SELECTED_MINION_SAFE,
    name: 'proposeAction',
    poll: 'subgraph',
    onTxHash: ACTIONS.PROPOSAL,
    display: 'Propose Minion Action',
    errMsg: 'Error submitting action to minion',
    successMsg: 'Minion Proposal Created!',
    argsFromCallback: 'proposeActionSafe',
    createDiscourse: true,
  },
  CANCEL_PROPOSAL: {
    contract: CONTRACTS.CURRENT_MOLOCH,
    name: 'cancelProposal',
    poll: 'subgraph',
    onTxHash: ACTIONS.BASIC,
    display: 'Cancel Proposal',
    errMsg: 'Error cancelling proposal',
    successMsg: 'Proposal Cancelled!',
  },
  SPONSOR_PROPOSAL: {
    contract: CONTRACTS.CURRENT_MOLOCH,
    name: 'sponsorProposal',
    poll: 'subgraph',
    onTxHash: ACTIONS.BASIC,
    display: 'Sponsor Proposal',
    errMsg: 'Error sponsoring proposal',
    successMsg: 'Proposal Sponsored!',
  },
  SUBMIT_VOTE: {
    contract: CONTRACTS.CURRENT_MOLOCH,
    name: 'submitVote',
    poll: 'subgraph',
    onTxHash: ACTIONS.BASIC,
    display: 'Submit Vote',
    errMsg: 'Error Submitting Vote',
    successMsg: 'Vote Submitted!',
  },
  PROCESS_PROPOSAL: {
    contract: CONTRACTS.CURRENT_MOLOCH,
    name: 'processProposal',
    poll: 'subgraph',
    onTxHash: ACTIONS.BASIC,
    display: 'Process Proposal',
    errMsg: 'Error Processing Proposal',
    successMsg: 'Proposal Processed!',
  },
  PROCESS_GK_PROPOSAL: {
    contract: CONTRACTS.CURRENT_MOLOCH,
    name: 'processGuildKickProposal',
    poll: 'subgraph',
    onTxHash: ACTIONS.BASIC,
    display: 'Process Proposal',
    errMsg: 'Error Processing Proposal',
    successMsg: 'Proposal Processed!',
  },
  PROCESS_WL_PROPOSAL: {
    contract: CONTRACTS.CURRENT_MOLOCH,
    name: 'processWhitelistProposal',
    poll: 'subgraph',
    onTxHash: ACTIONS.BASIC,
    display: 'Process Proposal',
    errMsg: 'Error Processing Proposal',
    successMsg: 'Proposal Processed!',
  },
  COLLECT_TOKENS: {
    contract: CONTRACTS.CURRENT_MOLOCH,
    name: 'collectTokens',
    poll: 'subgraph',
    onTxHash: ACTIONS.BASIC,
    display: 'Sync Token Balances',
    errMsg: 'Error Syncing Token Balances',
    successMsg: 'Token Balances Synced!',
  },
  UPDATE_DELEGATE: {
    contract: CONTRACTS.CURRENT_MOLOCH,
    name: 'updateDelegateKey',
    poll: 'subgraph',
    onTxHash: ACTIONS.GENERIC_MODAL,
    display: 'Update Delegate Key',
    errMsg: 'Error Updating Delegate Key',
    successMsg: 'Delegate Key Updated!',
    gatherArgs: ['.values.delegateAddress'],
  },
  WITHDRAW: {
    contract: CONTRACTS.CURRENT_MOLOCH,
    name: 'withdrawBalance',
    poll: 'subgraph',
    onTxHash: ACTIONS.BASIC,
    display: 'Withdraw Balance',
    errMsg: 'Error Withdrawing Balance',
    successMsg: 'Balance Withdrawn!',
  },
  RAGE_QUIT: {
    contract: CONTRACTS.CURRENT_MOLOCH,
    name: 'ragequit',
    poll: 'subgraph',
    onTxHash: ACTIONS.PROPOSAL,
    display: 'Rage Quit',
    errMsg: 'Error Rage Quitting',
    successMsg: 'Rage quit processed!',
    gatherArgs: ['.values.shares || 0', '.values.loot || 0'],
  },
  RAGE_QUIT_CLAIM: {
    contract: CONTRACTS.CURRENT_MOLOCH,
    name: 'ragequit',
    poll: 'subgraph',
    onTxHash: ACTIONS.PROPOSAL,
    display: 'Rage Quit',
    errMsg: 'Error Rage Quitting',
    successMsg: 'Rage quit processed!',
    // gatherArgs: [
    //   '.contextData.daoMember.shares',
    //   '.contextData.daoMember.loot',
    // ],
  },
  RAGE_KICK: {
    contract: CONTRACTS.CURRENT_MOLOCH,
    name: 'ragekick',
    poll: 'subgraph',
    onTxHash: ACTIONS.GENERIC_MODAL,
    display: 'Rage Kick',
    errMsg: 'Error Rage Kicking',
    successMsg: 'Rage kick processed!',
  },
  PAYROLL: {
    contract: CONTRACTS.SELECTED_MINION,
    name: 'proposeAction',
    poll: 'subgraph',
    onTxHash: ACTIONS.PROPOSAL,
    display: 'Sending Token',
    errMsg: 'Error Submitting Proposal',
    successMsg: 'Proposal Submitted!',
    gatherArgs: [
      '.values.minionToken',
      0,
      {
        type: 'encodeHex',
        contract: CONTRACTS.ERC_20,
        fnName: 'transfer',
        gatherArgs: ['.values.applicant', '.values.minionPayment'],
      },
      {
        type: 'detailsToJSON',
        gatherFields: DETAILS.PAYROLL_PROPOSAL,
      },
    ],
  },
  PAYROLL_NIFTY: {
    contract: CONTRACTS.SELECTED_MINION_NIFTY,
    name: 'proposeAction',
    poll: 'subgraph',
    onTxHash: ACTIONS.PROPOSAL,
    display: 'Sending Token',
    errMsg: 'Error Submitting Proposal',
    successMsg: 'Proposal Submitted!',
    gatherArgs: [
      '.values.minionToken',
      0,
      {
        type: 'encodeHex',
        contract: CONTRACTS.ERC_20,
        fnName: 'transfer',
        gatherArgs: ['.values.applicant', '.values.minionPayment'],
      },
      {
        type: 'detailsToJSON',
        gatherFields: DETAILS.PAYROLL_PROPOSAL,
      },
      '.contextData.daoOverview.depositToken.tokenAddress',
      0,
    ],
  },
  MINION_WITHDRAW: {
    contract: CONTRACTS.LOCAL_VANILLA_MINION,
    name: 'crossWithdraw',
    poll: 'subgraph',
    onTxHash: ACTIONS.GENERIC_MODAL,
    display: 'Transfer Balance',
    errMsg: 'Error Transferring Balance',
    successMsg: 'Balance Transferred!',
  },
  MINION_CANCEL: {
    contract: CONTRACTS.LOCAL_VANILLA_MINION,
    name: 'cancelAction',
    poll: 'subgraph',
    onTxHash: ACTIONS.BASIC,
    display: 'Cancel Minion',
    errMsg: 'Error Cancelling Minion',
    successMsg: 'Cancelled Minion!',
  },
  ESCROW_MINION_CANCEL: {
    contract: CONTRACTS.ESCROW_MINION,
    name: 'cancelAction',
    poll: 'subgraph',
    onTxHash: ACTIONS.BASIC,
    display: 'Cancel Minion',
    errMsg: 'Error Cancelling Minion',
    successMsg: 'Cancelled Minion!',
  },
  MINION_SELL_NIFTY: {
    contract: CONTRACTS.LOCAL_VANILLA_MINION,
    name: 'proposeAction',
    poll: 'subgraph',
    onTxHash: ACTIONS.GENERIC_MODAL,
    display: 'Sell Nifty',
    errMsg: 'Error Submitting Proposal',
    successMsg: 'Proposal Submitted!',
    gatherArgs: [
      '.localValues.contractAddress',
      0,
      {
        type: 'encodeHex',
        contract: CONTRACTS.NIFTY_INK,
        fnName: 'setTokenPrice',
        gatherArgs: ['.localValues.tokenId', '.values.price'],
      },
      {
        type: 'detailsToJSON',
        gatherFields: DETAILS.MINION_SELL_NIFTY,
      },
    ],
  },
  MINION_SELL_NIFTY_NIFTY: {
    contract: CONTRACTS.LOCAL_NIFTY_MINION,
    name: 'proposeAction',
    poll: 'subgraph',
    onTxHash: ACTIONS.GENERIC_MODAL,
    display: 'Sell Nifty',
    errMsg: 'Error Submitting Proposal',
    successMsg: 'Proposal Submitted!',
    gatherArgs: [
      '.localValues.contractAddress',
      0,
      {
        type: 'encodeHex',
        contract: CONTRACTS.NIFTY_INK,
        fnName: 'setTokenPrice',
        gatherArgs: ['.localValues.tokenId', '.values.price'],
      },
      {
        type: 'detailsToJSON',
        gatherFields: DETAILS.MINION_SELL_NIFTY,
      },
      '.contextData.daoOverview.depositToken.tokenAddress',
      0,
    ],
  },
  MINION_SIMPLE_EXECUTE: {
    contract: CONTRACTS.MINION_SIMPLE_EXECUTE,
    name: 'executeAction',
    specialPoll: 'executeAction',
    onTxHash: ACTIONS.GENERIC_MODAL,
    display: 'Executing Minion Proposal',
    errMsg: 'Error Executing Minion Proposal',
    successMsg: 'Minion Proposal Executed!',
  },
  MINION_SAFE_EXECUTE: {
    contract: CONTRACTS.MINION_SAFE_EXECUTE,
    name: 'executeAction',
    poll: 'subgraph',
    onTxHash: ACTIONS.GENERIC_MODAL,
    display: 'Executing Minion Proposal',
    errMsg: 'Error Executing Minion Proposal',
    successMsg: 'Minion Proposal Executed!',
  },
  SUPERFLUID_MINION_EXECUTE: {
    contract: CONTRACTS.SUPERFLUID_MINION_LOCAL,
    name: 'executeAction',
    specialPoll: 'executeAction',
    onTxHash: ACTIONS.GENERIC_MODAL,
    display: 'Executing Minion Proposal',
    errMsg: 'Error Executing Minion Proposal',
    successMsg: 'Minion Proposal Executed!',
  },
  UBERHAUS_MINION_EXECUTE_APPOINTMENT: {
    contract: CONTRACTS.UBERHAUS_MINION,
    name: 'executeAppointment',
    specialPoll: 'executeAction',
    onTxHash: ACTIONS.GENERIC_MODAL,
    display: 'Executing Minion Proposal',
    errMsg: 'Error Executing Minion Proposal',
    successMsg: 'Minion Proposal Executed!',
  },
  SUMMON_MINION_AND_SAFE: {
    contract: CONTRACTS.SAFE_MINION_FACTORY,
    name: 'summonMinionAndSafe',
    poll: 'subgraph',
    display: 'Summoning Minion',
    errMsg: 'Error Summoning Minion',
    successMsg: 'Minion Summoned!',
    gatherArgs: [
      '.contextData.daoid',
      '.values.minionName',
      '.values.minQuorum || 0',
      '.values.saltNonce',
    ],
  },
  SUMMON_MINION_SAFE: {
    contract: CONTRACTS.SAFE_MINION_FACTORY,
    name: 'summonMinion',
    poll: 'subgraph',
    display: 'Summoning Minion',
    errMsg: 'Error Summoning Minion',
    successMsg: 'Minion Summoned!',
    gatherArgs: [
      '.contextData.daoid',
      '.values.safeAddress',
      '.values.minionName',
      '.values.minQuorum || 0',
      '.values.saltNonce',
    ],
  },
  SUMMON_MINION_NIFTY: {
    contract: CONTRACTS.NIFTY_MINION_FACTORY,
    name: 'summonMinion',
    poll: 'subgraph',
    display: 'Summoning Minion',
    errMsg: 'Error Summoning Minion',
    successMsg: 'Minion Summoned!',
    gatherArgs: [
      '.contextData.daoid',
      '.values.minionName',
      '.values.minQuorum',
    ],
  },
  SUMMON_MINION_VANILLA: {
    contract: CONTRACTS.VANILLA_MINION_FACTORY,
    name: 'summonMinion',
    poll: 'subgraph',
    display: 'Summoning Minion',
    errMsg: 'Error Summoning Minion',
    successMsg: 'Minion Summoned!',
    gatherArgs: ['.contextData.daoid', '.values.minionName'],
  },
  SUMMON_MINION_SUPERFLUID: {
    contract: CONTRACTS.SUPERFLUID_MINION_FACTORY,
    name: 'summonMinion',
    poll: 'subgraph',
    display: 'Summoning Minion',
    errMsg: 'Error Summoning Minion',
    successMsg: 'Minion Summoned!',
    gatherArgs: [
      '.contextData.daoid',
      '.contextData.chainConfig.superfluid.superapp_addr.v1',
      '.values.minionName',
    ],
  },
  MINION_BUY_NIFTY_INK: {
    contract: CONTRACTS.SELECTED_MINION_NIFTY,
    name: 'proposeAction',
    poll: 'subgraph',
    onTxHash: ACTIONS.PROPOSAL,
    display: 'Buy NiftyInk',
    errMsg: 'Error Submitting Proposal',
    successMsg: 'Proposal Submitted!',
    gatherArgs: [
      '0xcf964c89f509a8c0ac36391c5460df94b91daba5',
      '.values.paymentRequested',
      {
        type: 'encodeHex',
        contract: CONTRACTS.NIFTY_INK,
        fnName: 'buyInk',
        gatherArgs: ['.values.ipfsHash'],
      },
      {
        type: 'detailsToJSON',
        gatherFields: DETAILS.MINION_BUY_NIFTY,
      },
      '.values.paymentToken',
      '.values.paymentRequested',
    ],
  },
  CREATE_WRAP_N_ZAP: {
    contract: CONTRACTS.WRAP_N_ZAP_FACTORY,
    name: 'create',
    poll: 'boostSubgraph',
    display: 'Create Wrap-N-Zap',
    errMsg: 'Error creating Wrap-N-Zap',
    successMsg: 'Wrap-N-Zap added!',
    gatherArgs: [
      '.contextData.daoid',
      '.contextData.chainConfig.wrapper_contract',
    ],
  },
  POKE_WRAP_N_ZAP: {
    contract: CONTRACTS.WRAP_N_ZAP,
    name: 'poke',
    onTxHash: ACTIONS.GENERIC_MODAL,
    specialPoll: 'pollWrapNZap',
    display: 'Poke Wrap-N-Zap',
    errMsg: 'Error poking Wrap-N-Zap',
    successMsg: 'Wrap-N-Zap Poke Successful!',
  },
  SUPERFLUID_STREAM: {
    contract: CONTRACTS.SUPERFLUID_MINION_SELECT,
    name: 'proposeAction',
    poll: 'subgraph',
    onTxHash: ACTIONS.PROPOSAL,
    display: 'Submitting Stream Proposal',
    errMsg: 'Error Submitting Proposals',
    successMsg: 'Proposal Submitted',
    gatherArgs: [
      '.values.applicant',
      '.values.paymentToken',
      '.values.weiRatePerSec',
      '.values.paymentRequested',
      '0x0',
      {
        type: 'detailsToJSON',
        gatherFields: DETAILS.STANDARD_PROPOSAL,
      },
    ],
  },
  SELL_NFT_RARIBLE: {
    contract: CONTRACTS.SELECTED_MINION_SAFE,
    name: 'proposeAction',
    poll: 'subgraph',
    onTxHash: ACTIONS.PROPOSAL,
    display: 'Submitting NFT Sale Proposal',
    errMsg: 'Error Submitting Proposals',
    successMsg: 'Proposal Submitted',
    gatherArgs: [
      {
        // _transactions,
        type: 'encodeSafeActions',
        contract: CONTRACTS.LOCAL_SAFE_MULTISEND,
        fnName: 'multiSend',
        to: [
          {
            type: 'nestedArgs',
            gatherArgs: [
              '.values.nftAddress',
              '.contextData.chainConfig.safeMinion.safe_sign_lib_addr',
            ],
          },
        ],
        value: [
          {
            type: 'nestedArgs',
            gatherArgs: ['0', '0'],
          },
        ],
        data: [
          {
            type: 'nestedArgs',
            gatherArgs: [
              {
                type: 'encodeHex',
                contract: CONTRACTS.ERC_721,
                fnName: 'setApprovalForAll',
                gatherArgs: [
                  '.contextData.chainConfig.rarible.nft_transfer_proxy',
                  'true',
                ],
              },
              {
                type: 'encodeHex',
                contract: CONTRACTS.LOCAL_SAFE_SIGNLIB,
                fnName: 'signMessage',
                gatherArgs: ['.values.eip712HashValue'],
              },
            ],
          },
        ],
        operation: [
          {
            type: 'nestedArgs',
            gatherArgs: ['0', '1'],
          },
        ],
      },
      '.contextData.daoOverview.depositToken.tokenAddress', // _withdrawToken
      0, // _withdrawAmount
      {
        type: 'detailsToJSON',
        gatherFields: DETAILS.SELL_NFT_RARIBLE,
      },
      true, // _memberOnlyEnabled
    ],
  },
  BUY_NFT_RARIBLE: {
    contract: CONTRACTS.SELECTED_MINION_SAFE,
    name: 'proposeAction',
    poll: 'subgraph',
    onTxHash: ACTIONS.PROPOSAL,
    display: 'Submitting NFT Buy Proposal',
    errMsg: 'Error Submitting Proposals',
    successMsg: 'Proposal Submitted',
    gatherArgs: [
      {
        // _transactions,
        type: 'encodeSafeActions',
        contract: CONTRACTS.LOCAL_SAFE_MULTISEND,
        fnName: 'multiSend',
        to: [
          {
            type: 'nestedArgs',
            gatherArgs: [
              '.values.paymentToken',
              '.contextData.chainConfig.safeMinion.safe_sign_lib_addr',
            ],
          },
        ],
        value: [
          {
            type: 'nestedArgs',
            gatherArgs: ['0', '0'],
          },
        ],
        data: [
          {
            type: 'nestedArgs',
            gatherArgs: [
              {
                type: 'encodeHex',
                contract: CONTRACTS.ERC_20,
                fnName: 'approve',
                gatherArgs: [
                  '.values.raribleTransferProxy',
                  '.values.totalOrderPrice',
                ],
              },
              {
                type: 'encodeHex',
                contract: CONTRACTS.LOCAL_SAFE_SIGNLIB,
                fnName: 'signMessage',
                gatherArgs: ['.values.eip712HashValue'],
              },
            ],
          },
        ],
        operation: [
          {
            type: 'nestedArgs',
            gatherArgs: ['0', '1'],
          },
        ],
      },
      '.values.paymentToken', // _withdrawToken
      '.values.totalOrderPrice', // _withdrawAmount
      {
        type: 'detailsToJSON',
        gatherFields: DETAILS.BUY_NFT_RARIBLE,
      },
      true, // _memberOnlyEnabled
    ],
  },
  SET_BUYOUT_TOKEN: {
    contract: CONTRACTS.SELECTED_MINION_SAFE,
    name: 'proposeAction',
    poll: 'subgraph',
    onTxHash: ACTIONS.PROPOSAL,
    display: 'Submitting Buyout Proposal',
    errMsg: 'Error Submitting Buyout Proposal',
    successMsg: 'Buyout Proposal Submitted',
    gatherArgs: [
      {
        // _transactions,
        type: 'encodeSafeActions',
        contract: CONTRACTS.LOCAL_SAFE_MULTISEND,
        fnName: 'multiSend',
        to: [
          {
            type: 'nestedArgs',
            gatherArgs: [
              '.contextData.chainConfig.dao_conditional_helper_addr',
              '.values.paymentToken',
            ],
          },
        ],
        value: [
          {
            type: 'nestedArgs',
            gatherArgs: ['0', '0'],
          },
        ],
        data: [
          {
            type: 'encodeHex',
            contract: CONTRACTS.DAO_CONDITIONAL_HELPER,
            fnName: 'isNotDaoMember',
            gatherArgs: ['.contextData.address', '.contextData.daoid'],
          },
          {
            type: 'encodeHex',
            contract: CONTRACTS.PAYMENT_ERC_20,
            fnName: 'transfer',
            gatherArgs: ['.contextData.address', '.values.paymentRequested'],
          },
        ],
        operation: [
          {
            type: 'nestedArgs',
            gatherArgs: ['0', '0'],
          },
        ],
      },
      '.values.paymentToken', // _withdrawToken
      '.values.paymentRequested', // _withdrawAmount
      {
        type: 'detailsToJSON',
        gatherFields: DETAILS.SET_BUYOUT_TOKEN,
      },
      true, // _memberOnlyEnabled
    ],
  },
  OFFER_NFT_TRIBUTE: {
    contract: CONTRACTS.ESCROW_MINION,
    name: 'proposeTribute',
    poll: 'subgraph',
    onTxHash: ACTIONS.PROPOSAL,
    display: 'Submitting NFT Tribute Proposal',
    errMsg: 'Error Submitting Proposal',
    successMsg: 'Proposal Submitted',
    gatherArgs: [
      '.contextData.daoid',
      {
        type: 'nestedArgs',
        gatherArgs: ['.values.nftAddress'],
      }, // tokenAddresses
      {
        type: 'nestedArgs',
        gatherArgs: [
          {
            type: 'nestedArgs',
            gatherArgs: [
              '.values.tokenType',
              '.values.tokenId',
              '.values.numTokens || 0',
            ],
          },
        ],
      }, // typesTokensIdsAmounts
      '.values.selectedSafeAddress', // vaultAddress (Minion Address?)
      {
        type: 'nestedArgs',
        gatherArgs: [
          '.values.sharesRequested',
          '.values.lootRequested',
          '.values.paymentRequested', // Funds
        ],
      }, // tokenAddresses
      {
        type: 'detailsToJSON',
        gatherFields: DETAILS.OFFER_NFT_TRIBUTE,
      },
    ],
  },
  WITHDRAW_ESCROW: {
    contract: CONTRACTS.ESCROW_MINION,
    name: 'withdrawToDestination',
    poll: 'subgraph',
    onTxHash: ACTIONS.BASIC,
    display: 'Withdraw Balance from Escrow',
    errMsg: 'Error Withdrawing Balance from Escrow',
    successMsg: 'Balance Withdrawn from Escrow!',
  },
};


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/commit/aa1aa688486f56717b29b2f9dafe8e3580e02fae#commitcomment-58959811
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211029/b0980cd2/attachment-0001.htm>

From notifications at github.com  Sat Oct 30 09:19:44 2021
From: notifications at github.com (Dimitris Apostolou)
Date: Sat, 30 Oct 2021 00:19:44 -0700
Subject: [bisq-network/bisq] Bisq doesn't operate on remote NAS devices
 over SMBFS (Issue #5761)
In-Reply-To: <bisq-network/bisq/issues/5761@github.com>
References: <bisq-network/bisq/issues/5761@github.com>
Message-ID: <bisq-network/bisq/issues/5761/955164572@github.com>

Perhaps using a symlink pointing to your NAS but keeping the symlink in the default path.

Something like `ln -s ~/Library/Application Support/Bisq /Volumes/Bisq/BisqData`

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5761#issuecomment-955164572
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211030/29df016e/attachment.htm>

From notifications at github.com  Sat Oct 30 09:36:33 2021
From: notifications at github.com (Conza)
Date: Sat, 30 Oct 2021 00:36:33 -0700
Subject: [bisq-network/bisq] Trigger price doesn't automatically
 reactivate offer after price falls below threshold (Issue #5773)
In-Reply-To: <bisq-network/bisq/issues/5773@github.com>
References: <bisq-network/bisq/issues/5773@github.com>
Message-ID: <bisq-network/bisq/issues/5773/955166619@github.com>

Yeah dang, should certainly do that. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5773#issuecomment-955166619
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211030/8d2ee224/attachment.htm>

From notifications at github.com  Sat Oct 30 09:36:48 2021
From: notifications at github.com (Conza)
Date: Sat, 30 Oct 2021 00:36:48 -0700
Subject: [bisq-network/bisq] Make clone offer feature more visible (Issue
 #5774)
In-Reply-To: <bisq-network/bisq/issues/5774@github.com>
References: <bisq-network/bisq/issues/5774@github.com>
Message-ID: <bisq-network/bisq/issues/5774/955166660@github.com>

Indeed.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5774#issuecomment-955166660
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211030/f94c1ac7/attachment.htm>

From notifications at github.com  Sat Oct 30 12:17:33 2021
From: notifications at github.com (xmijo)
Date: Sat, 30 Oct 2021 03:17:33 -0700
Subject: [bisq-network/bisq] Unable to start Bisq on macOS (Issue #5789)
Message-ID: <bisq-network/bisq/issues/5789@github.com>

### Description

I'm a longtime Bisq user. Startup is often slow but lately Bisq just does not start at all, I have been waiting for close to an hour. It gets stuck on startup after entering the password and appears like it's just really slow to connect to peers or creating the hidden service, and eventually times out or loses connections. I have restarted many times of course and on different days. I've had this issue for quite some time before opening this report.

I wonder if it has something to do with upgrading to v3 onion protocol a couple months ago. I think I followed the process as outlined in the docs.

Please let me know what additional info is required to debug this.

#### Version

Bisq 1.7.5

### Steps to reproduce

Start Bisq.

### Expected behaviour

Bisq starts as normal.

### Actual behaviour

Bisq gets stuck during startup.

### Screenshots

<!--Screenshots if gui related, drag and drop to add to the issue -->

#### Device or machine

macOS Big Sur 11.5.2


#### Additional info

Getting many FAILED log entries, e.g.
`[TorControlParser] DEBUG o.b.n.tor.Tor: CircuitStatus: 262 FAILED BUILD_FLAGS=IS_INTERNAL,NEED_CAPACITY`
`[TorControlParser] DEBUG o.b.n.tor.Tor: CircuitStatus: 167 FAILED $.....25B21FC3B7781CDD......~DTFNODE19`

It also looks like connections are being closed for some reason:
`TorControlParser] DEBUG o.b.n.tor.Tor: CircuitStatus: 394 CLOSED`

Not sure if these are normal in the logs.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5789
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211030/7c19be55/attachment.htm>

From notifications at github.com  Sat Oct 30 12:17:36 2021
From: notifications at github.com (boring-cyborg[bot])
Date: Sat, 30 Oct 2021 03:17:36 -0700
Subject: [bisq-network/bisq] Unable to start Bisq on macOS (Issue #5789)
In-Reply-To: <bisq-network/bisq/issues/5789@github.com>
References: <bisq-network/bisq/issues/5789@github.com>
Message-ID: <bisq-network/bisq/issues/5789/955185819@github.com>

**Thanks for opening your first issue here!**<br/><br/>Be sure to follow the issue template. Your issue will be reviewed by a maintainer and labeled for further action.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5789#issuecomment-955185819
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211030/dd87b92a/attachment.htm>

From notifications at github.com  Sat Oct 30 12:36:26 2021
From: notifications at github.com (cd2357)
Date: Sat, 30 Oct 2021 03:36:26 -0700
Subject: [bisq-network/bisq] BISQ 64bit 1.7.2 won't launch on windows 10
 (#5648)
In-Reply-To: <bisq-network/bisq/issues/5648@github.com>
References: <bisq-network/bisq/issues/5648@github.com>
Message-ID: <bisq-network/bisq/issues/5648/955187977@github.com>

Solution by @teambitcoin documented in https://bisq.wiki/Troubleshooting

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5648#issuecomment-955187977
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211030/ff4565e0/attachment.htm>

From notifications at github.com  Sat Oct 30 12:36:27 2021
From: notifications at github.com (cd2357)
Date: Sat, 30 Oct 2021 03:36:27 -0700
Subject: [bisq-network/bisq] BISQ 64bit 1.7.2 won't launch on windows 10
 (#5648)
In-Reply-To: <bisq-network/bisq/issues/5648@github.com>
References: <bisq-network/bisq/issues/5648@github.com>
Message-ID: <bisq-network/bisq/issue/5648/issue_event/5543748326@github.com>

Closed #5648.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5648#event-5543748326
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211030/a36984d9/attachment.htm>

From notifications at github.com  Sat Oct 30 14:48:10 2021
From: notifications at github.com (cd2357)
Date: Sat, 30 Oct 2021 05:48:10 -0700
Subject: [bisq-network/bisq] Still v2 addresses used in BitcoinJ? (Issue
 #5778)
In-Reply-To: <bisq-network/bisq/issues/5778@github.com>
References: <bisq-network/bisq/issues/5778@github.com>
Message-ID: <bisq-network/bisq/issues/5778/955204080@github.com>

Getting the same warning when using the BTC node `wizbit5555bsslwv4ctronnsgk5vh2w2pdx7v7eyuivlyuoteejk7lid.onion`:

`Oct-30 14:42:27.156 [BlockingClient network thread for wizbit5555bsslwv4ctronnsgk5vh2w2pdx7v7eyuivlyuoteejk7lid.onion/<unresolved>:8333] WARN  org.bitcoinj.core.Peer: Peer{[wizbit5555bsslwv4ctronnsgk5vh2w2pdx7v7eyuivlyuoteejk7lid.onion]:8333, version=70016, subVer=/Satoshi:0.20.99(@wiz)/, services=1037 (NETWORK, BLOOM, WITNESS, NETWORK_LIMITED), time=2021-10-30 14:42:26, height=707422}: Received unhandled message: org.bitcoinj.core.SendAddrV2Message at 2374be06`

However:
- NOT getting that warning when using my own node (also via tor v3)
- NOT getting that warning when using another of wiz's BTC nodes, `jto2jfbsxhb6yvhcrrjddrgbakte6tgsy3c3z3prss64gndgvovvosyd.onion`

@wiz any difference in setup between `wizbit5555bsslwv4ctronnsgk5vh2w2pdx7v7eyuivlyuoteejk7lid` and `jto2jfbsxhb6yvhcrrjddrgbakte6tgsy3c3z3prss64gndgvovvosyd` ? Are they running the same bisq version?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5778#issuecomment-955204080
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211030/c161bb8c/attachment.htm>

From notifications at github.com  Sat Oct 30 15:22:30 2021
From: notifications at github.com (cd2357)
Date: Sat, 30 Oct 2021 06:22:30 -0700
Subject: [bisq-network/bisq] Still v2 addresses used in BitcoinJ? (Issue
 #5778)
In-Reply-To: <bisq-network/bisq/issues/5778@github.com>
References: <bisq-network/bisq/issues/5778@github.com>
Message-ID: <bisq-network/bisq/issues/5778/955208497@github.com>

> `subVer=/Satoshi:0.20.99(@wiz)/`

Tor v3 support was added in Bitcoin Core v0.21

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5778#issuecomment-955208497
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211030/cc98cf95/attachment-0001.htm>

From notifications at github.com  Sat Oct 30 15:26:34 2021
From: notifications at github.com (wiz)
Date: Sat, 30 Oct 2021 06:26:34 -0700
Subject: [bisq-network/bisq] Still v2 addresses used in BitcoinJ? (Issue
 #5778)
In-Reply-To: <bisq-network/bisq/issues/5778@github.com>
References: <bisq-network/bisq/issues/5778@github.com>
Message-ID: <bisq-network/bisq/issues/5778/955209039@github.com>

Ah okay, looks like this can be fixed by upgrading that one node. It was a custom build of Bitcoin Core v0.20 before the PR to get Tor v3 supported was merged so it supports both v2 and v3 but if that causes issues I can just remove it.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5778#issuecomment-955209039
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211030/94a8d136/attachment.htm>

From notifications at github.com  Sat Oct 30 15:39:53 2021
From: notifications at github.com (pazza)
Date: Sat, 30 Oct 2021 06:39:53 -0700
Subject: [bisq-network/support] Fee reimbursement for trade 6I6TG (Issue
 #1015)
In-Reply-To: <bisq-network/support/issues/1015@github.com>
References: <bisq-network/support/issues/1015@github.com>
Message-ID: <bisq-network/support/issues/1015/955222409@github.com>

Hi @waleehoohaa thanks for opening this ticket.

I can confirm I was the mediator for this trade and that the trade was failed due to lack of payment information being available.  As such I cancelled the trade retuning security deposits to both traders and the trade amount to the seller. I also requested you both to raise an issue here to be compensated for the miner / trade fees incurred.

 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/support/issues/1015#issuecomment-955222409
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211030/2ddbe9ff/attachment.htm>

From notifications at github.com  Sat Oct 30 17:04:55 2021
From: notifications at github.com (pfergi42)
Date: Sat, 30 Oct 2021 08:04:55 -0700
Subject: [bisq-network/support] Fee reimbursement for trade 8hqzF (Issue #1016)
Message-ID: <bisq-network/support/issues/1016@github.com>

![bisq_error](https://user-images.githubusercontent.com/4021240/139538635-07fad107-cc6d-40ad-81e7-1755ebeac6fd.png)

![bisq_error2](https://user-images.githubusercontent.com/4021240/139538445-aab651ac-9ab7-4fca-abdd-861ffd31bb87.png)

Maker:  c5bbc0e1e9d380e5df22cfa888e65d5e22bbed0898601849983cd41cb5efa30b
Taker: N/A
Deposit: N/A

Bisq version: v.1.7.4
BTC address for reimbursement: bc1qkmcnz98lcw9qx0dk04m3lt6pfgfjrj7c0z8fy5

Other notes:



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/support/issues/1016
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211030/ced312b8/attachment.htm>

From notifications at github.com  Sat Oct 30 18:56:45 2021
From: notifications at github.com (jan zens)
Date: Sat, 30 Oct 2021 09:56:45 -0700
Subject: [bisq-network/bisq] add alternative popup "no BSQ while
 Synchronizing DAO" (PR #5766)
In-Reply-To: <bisq-network/bisq/pull/5766@github.com>
References: <bisq-network/bisq/pull/5766@github.com>
Message-ID: <bisq-network/bisq/pull/5766/push/8274139301@github.com>

@sneznaj pushed 1 commit.

2dd95846beca8d01cd08ac80f2774722799b4d6a  Update TakeOfferView.java


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/bisq-network/bisq/pull/5766/files/030c8910d55c5d75d5dc2cc47cb5fa475296a3a3..2dd95846beca8d01cd08ac80f2774722799b4d6a
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211030/f1ec34d3/attachment.htm>

From notifications at github.com  Sat Oct 30 19:21:18 2021
From: notifications at github.com (jan zens)
Date: Sat, 30 Oct 2021 10:21:18 -0700
Subject: [bisq-network/bisq] add alternative popup "no BSQ while
 Synchronizing DAO" (PR #5766)
In-Reply-To: <bisq-network/bisq/pull/5766@github.com>
References: <bisq-network/bisq/pull/5766@github.com>
Message-ID: <bisq-network/bisq/pull/5766/push/8274213905@github.com>

@sneznaj pushed 1 commit.

97cf21931139a83d70111b80e8db02fc0d1e7816  Update TakeOfferView.java


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/bisq-network/bisq/pull/5766/files/2dd95846beca8d01cd08ac80f2774722799b4d6a..97cf21931139a83d70111b80e8db02fc0d1e7816
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211030/8880d1ad/attachment.htm>

From notifications at github.com  Sat Oct 30 19:26:45 2021
From: notifications at github.com (jan zens)
Date: Sat, 30 Oct 2021 10:26:45 -0700
Subject: [bisq-network/bisq] add alternative popup "no BSQ while
 Synchronizing DAO" (PR #5766)
In-Reply-To: <bisq-network/bisq/pull/5766@github.com>
References: <bisq-network/bisq/pull/5766@github.com>
Message-ID: <bisq-network/bisq/pull/5766/push/8274230238@github.com>

@sneznaj pushed 1 commit.

f64584b5339397c194f28f8e2a75f65ffc9f159d  Update MutableOfferView.java


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/bisq-network/bisq/pull/5766/files/97cf21931139a83d70111b80e8db02fc0d1e7816..f64584b5339397c194f28f8e2a75f65ffc9f159d
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211030/83f3bfd8/attachment-0001.htm>

From notifications at github.com  Sat Oct 30 19:28:36 2021
From: notifications at github.com (jan zens)
Date: Sat, 30 Oct 2021 10:28:36 -0700
Subject: [bisq-network/bisq] add alternative popup "no BSQ while
 Synchronizing DAO" (PR #5766)
In-Reply-To: <bisq-network/bisq/pull/5766@github.com>
References: <bisq-network/bisq/pull/5766@github.com>
Message-ID: <bisq-network/bisq/pull/5766/push/8274235465@github.com>

@sneznaj pushed 1 commit.

21599d80a65cbce03dfb2c28c57b312d3391899d  Update MutableOfferView.java


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/bisq-network/bisq/pull/5766/files/f64584b5339397c194f28f8e2a75f65ffc9f159d..21599d80a65cbce03dfb2c28c57b312d3391899d
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211030/a20fb847/attachment.htm>

From notifications at github.com  Sat Oct 30 20:59:07 2021
From: notifications at github.com (bisq-bot[bot])
Date: Sat, 30 Oct 2021 11:59:07 -0700
Subject: [bisq-network/compensation] For Cycle 29 (Issue #928)
In-Reply-To: <bisq-network/compensation/issues/928@github.com>
References: <bisq-network/compensation/issues/928@github.com>
Message-ID: <bisq-network/compensation/issues/928/955577566@github.com>


## Issuance by Team:
|team|amount BSQ|amount USD|
|---|---|---|
|ops|773.33|1200.00|
|dev|38.67|60.00|

Total Issuance: 812.00 BSQ (equivalent to: 1260.00 USD)



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/928#issuecomment-955577566
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211030/f786ea13/attachment.htm>

From notifications at github.com  Sat Oct 30 20:59:18 2021
From: notifications at github.com (MwithM)
Date: Sat, 30 Oct 2021 11:59:18 -0700
Subject: [bisq-network/compensation] For Cycle 29 (Issue #928)
In-Reply-To: <bisq-network/compensation/issues/928@github.com>
References: <bisq-network/compensation/issues/928@github.com>
Message-ID: <bisq-network/compensation/issues/928/955577583@github.com>

Closed as accepted.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/928#issuecomment-955577583
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211030/129209f9/attachment.htm>

From notifications at github.com  Sat Oct 30 20:59:29 2021
From: notifications at github.com (bisq-bot[bot])
Date: Sat, 30 Oct 2021 11:59:29 -0700
Subject: [bisq-network/compensation] For Cycle 29 (Issue #929)
In-Reply-To: <bisq-network/compensation/issues/929@github.com>
References: <bisq-network/compensation/issues/929@github.com>
Message-ID: <bisq-network/compensation/issues/929/955577608@github.com>


## Issuance by Team:
|team|amount BSQ|amount USD|
|---|---|---|
|ops|677.42|1050.00|

Total Issuance: 677.42 BSQ (equivalent to: 1050.00 USD)



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/929#issuecomment-955577608
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211030/6998ca04/attachment.htm>

From notifications at github.com  Sat Oct 30 20:59:35 2021
From: notifications at github.com (MwithM)
Date: Sat, 30 Oct 2021 11:59:35 -0700
Subject: [bisq-network/compensation] For Cycle 29 (Issue #929)
In-Reply-To: <bisq-network/compensation/issues/929@github.com>
References: <bisq-network/compensation/issues/929@github.com>
Message-ID: <bisq-network/compensation/issues/929/955577619@github.com>

Closed as accepted.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/929#issuecomment-955577619
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211030/af92922d/attachment.htm>

From notifications at github.com  Sat Oct 30 20:59:38 2021
From: notifications at github.com (MwithM)
Date: Sat, 30 Oct 2021 11:59:38 -0700
Subject: [bisq-network/compensation] For Cycle 29 (Issue #929)
In-Reply-To: <bisq-network/compensation/issues/929@github.com>
References: <bisq-network/compensation/issues/929@github.com>
Message-ID: <bisq-network/compensation/issue/929/issue_event/5544254776@github.com>

Closed #929.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/929#event-5544254776
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211030/fe52e19d/attachment.htm>

From notifications at github.com  Sat Oct 30 20:59:50 2021
From: notifications at github.com (bisq-bot[bot])
Date: Sat, 30 Oct 2021 11:59:50 -0700
Subject: [bisq-network/compensation] For Cycle 29 (Issue #927)
In-Reply-To: <bisq-network/compensation/issues/927@github.com>
References: <bisq-network/compensation/issues/927@github.com>
Message-ID: <bisq-network/compensation/issues/927/955577655@github.com>


## Issuance by Team:
|team|amount BSQ|amount USD|
|---|---|---|
|ops|903.22|1400.00|
|growth|3225.78|5000.00|

Total Issuance: 4129.00 BSQ (equivalent to: 6400.00 USD)



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/927#issuecomment-955577655
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211030/23facca1/attachment-0001.htm>

From notifications at github.com  Sat Oct 30 20:59:54 2021
From: notifications at github.com (MwithM)
Date: Sat, 30 Oct 2021 11:59:54 -0700
Subject: [bisq-network/compensation] For Cycle 29 (Issue #927)
In-Reply-To: <bisq-network/compensation/issues/927@github.com>
References: <bisq-network/compensation/issues/927@github.com>
Message-ID: <bisq-network/compensation/issues/927/955577664@github.com>

Closed as accepted.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/927#issuecomment-955577664
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211030/c9f50688/attachment.htm>

From notifications at github.com  Sat Oct 30 20:59:54 2021
From: notifications at github.com (MwithM)
Date: Sat, 30 Oct 2021 11:59:54 -0700
Subject: [bisq-network/compensation] For Cycle 29 (Issue #927)
In-Reply-To: <bisq-network/compensation/issues/927@github.com>
References: <bisq-network/compensation/issues/927@github.com>
Message-ID: <bisq-network/compensation/issue/927/issue_event/5544255001@github.com>

Closed #927.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/927#event-5544255001
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211030/ac5b9394/attachment.htm>

From notifications at github.com  Sat Oct 30 21:00:05 2021
From: notifications at github.com (bisq-bot[bot])
Date: Sat, 30 Oct 2021 12:00:05 -0700
Subject: [bisq-network/compensation] For Cycle 29 (Issue #926)
In-Reply-To: <bisq-network/compensation/issues/926@github.com>
References: <bisq-network/compensation/issues/926@github.com>
Message-ID: <bisq-network/compensation/issues/926/955577695@github.com>


## Issuance by Team:
|team|amount BSQ|amount USD|
|---|---|---|
|dev|1870.97|2900.00|
|support|322.58|500.00|

Total Issuance: 2193.55 BSQ (equivalent to: 3400.00 USD)



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/926#issuecomment-955577695
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211030/225f885b/attachment.htm>

From notifications at github.com  Sat Oct 30 21:00:11 2021
From: notifications at github.com (MwithM)
Date: Sat, 30 Oct 2021 12:00:11 -0700
Subject: [bisq-network/compensation] For Cycle 29 (Issue #926)
In-Reply-To: <bisq-network/compensation/issues/926@github.com>
References: <bisq-network/compensation/issues/926@github.com>
Message-ID: <bisq-network/compensation/issues/926/955577707@github.com>

Closed as accepted.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/926#issuecomment-955577707
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211030/911e4046/attachment.htm>

From notifications at github.com  Sat Oct 30 21:00:11 2021
From: notifications at github.com (MwithM)
Date: Sat, 30 Oct 2021 12:00:11 -0700
Subject: [bisq-network/compensation] For Cycle 29 (Issue #926)
In-Reply-To: <bisq-network/compensation/issues/926@github.com>
References: <bisq-network/compensation/issues/926@github.com>
Message-ID: <bisq-network/compensation/issue/926/issue_event/5544255228@github.com>

Closed #926.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/926#event-5544255228
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211030/14155d76/attachment.htm>

From notifications at github.com  Sat Oct 30 21:00:25 2021
From: notifications at github.com (bisq-bot[bot])
Date: Sat, 30 Oct 2021 12:00:25 -0700
Subject: [bisq-network/compensation] For Cycle 29 (Issue #934)
In-Reply-To: <bisq-network/compensation/issues/934@github.com>
References: <bisq-network/compensation/issues/934@github.com>
Message-ID: <bisq-network/compensation/issues/934/955577737@github.com>


## Issuance by Team:
|team|amount BSQ|amount USD|
|---|---|---|
|support|645.16|1000.00|

Total Issuance: 645.16 BSQ (equivalent to: 1000.00 USD)



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/934#issuecomment-955577737
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211030/eac71383/attachment.htm>

From notifications at github.com  Sat Oct 30 21:00:27 2021
From: notifications at github.com (MwithM)
Date: Sat, 30 Oct 2021 12:00:27 -0700
Subject: [bisq-network/compensation] For Cycle 29 (Issue #934)
In-Reply-To: <bisq-network/compensation/issues/934@github.com>
References: <bisq-network/compensation/issues/934@github.com>
Message-ID: <bisq-network/compensation/issues/934/955577741@github.com>

Closed as accepted.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/934#issuecomment-955577741
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211030/c31f9c19/attachment-0001.htm>

From notifications at github.com  Sat Oct 30 21:00:29 2021
From: notifications at github.com (MwithM)
Date: Sat, 30 Oct 2021 12:00:29 -0700
Subject: [bisq-network/compensation] For Cycle 29 (Issue #934)
In-Reply-To: <bisq-network/compensation/issues/934@github.com>
References: <bisq-network/compensation/issues/934@github.com>
Message-ID: <bisq-network/compensation/issue/934/issue_event/5544255482@github.com>

Closed #934.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/934#event-5544255482
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211030/56ece2c6/attachment.htm>

From notifications at github.com  Sat Oct 30 21:01:04 2021
From: notifications at github.com (bisq-bot[bot])
Date: Sat, 30 Oct 2021 12:01:04 -0700
Subject: [bisq-network/compensation] For Cycle 29 (Issue #932)
In-Reply-To: <bisq-network/compensation/issues/932@github.com>
References: <bisq-network/compensation/issues/932@github.com>
Message-ID: <bisq-network/compensation/issues/932/955577816@github.com>


## Issuance by Team:
|team|amount BSQ|amount USD|
|---|---|---|
|growth|129.03|200.00|
|support|193.54|300.00|
|admin|64.51|100.00|

Total Issuance: 387.09 BSQ (equivalent to: 600.00 USD)



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/932#issuecomment-955577816
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211030/13b4583e/attachment.htm>

From notifications at github.com  Sat Oct 30 21:01:07 2021
From: notifications at github.com (MwithM)
Date: Sat, 30 Oct 2021 12:01:07 -0700
Subject: [bisq-network/compensation] For Cycle 29 (Issue #932)
In-Reply-To: <bisq-network/compensation/issues/932@github.com>
References: <bisq-network/compensation/issues/932@github.com>
Message-ID: <bisq-network/compensation/issues/932/955577820@github.com>

Closed as accepted.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/932#issuecomment-955577820
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211030/07729b55/attachment.htm>

From notifications at github.com  Sat Oct 30 21:01:07 2021
From: notifications at github.com (MwithM)
Date: Sat, 30 Oct 2021 12:01:07 -0700
Subject: [bisq-network/compensation] For Cycle 29 (Issue #932)
In-Reply-To: <bisq-network/compensation/issues/932@github.com>
References: <bisq-network/compensation/issues/932@github.com>
Message-ID: <bisq-network/compensation/issue/932/issue_event/5544255992@github.com>

Closed #932.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/932#event-5544255992
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211030/cdec854e/attachment.htm>

From notifications at github.com  Sat Oct 30 21:01:19 2021
From: notifications at github.com (bisq-bot[bot])
Date: Sat, 30 Oct 2021 12:01:19 -0700
Subject: [bisq-network/compensation] For Cycle 29 (Issue #925)
In-Reply-To: <bisq-network/compensation/issues/925@github.com>
References: <bisq-network/compensation/issues/925@github.com>
Message-ID: <bisq-network/compensation/issues/925/955577845@github.com>


## Issuance by Team:
|team|amount BSQ|amount USD|
|---|---|---|
|support|1016.04|1575.00|
|admin|32.26|50.00|

Total Issuance: 1048.30 BSQ (equivalent to: 1625.00 USD)



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/925#issuecomment-955577845
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211030/28dc3cdc/attachment.htm>

From notifications at github.com  Sat Oct 30 21:01:22 2021
From: notifications at github.com (MwithM)
Date: Sat, 30 Oct 2021 12:01:22 -0700
Subject: [bisq-network/compensation] For Cycle 29 (Issue #925)
In-Reply-To: <bisq-network/compensation/issues/925@github.com>
References: <bisq-network/compensation/issues/925@github.com>
Message-ID: <bisq-network/compensation/issues/925/955577847@github.com>

Closed as accepted.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/925#issuecomment-955577847
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211030/746ff28d/attachment-0001.htm>

From notifications at github.com  Sat Oct 30 21:01:22 2021
From: notifications at github.com (MwithM)
Date: Sat, 30 Oct 2021 12:01:22 -0700
Subject: [bisq-network/compensation] For Cycle 29 (Issue #925)
In-Reply-To: <bisq-network/compensation/issues/925@github.com>
References: <bisq-network/compensation/issues/925@github.com>
Message-ID: <bisq-network/compensation/issue/925/issue_event/5544256170@github.com>

Closed #925.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/925#event-5544256170
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211030/8cffcc89/attachment-0001.htm>

From notifications at github.com  Sat Oct 30 21:01:32 2021
From: notifications at github.com (bisq-bot[bot])
Date: Sat, 30 Oct 2021 12:01:32 -0700
Subject: [bisq-network/compensation] For Cycle 29 (#923)
In-Reply-To: <bisq-network/compensation/issues/923@github.com>
References: <bisq-network/compensation/issues/923@github.com>
Message-ID: <bisq-network/compensation/issues/923/955577863@github.com>


## Issuance by Team:
|team|amount BSQ|amount USD|
|---|---|---|
|support|322.58|500.00|

Total Issuance: 322.58 BSQ (equivalent to: 500.00 USD)



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/923#issuecomment-955577863
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211030/7e813403/attachment.htm>

From notifications at github.com  Sat Oct 30 21:01:36 2021
From: notifications at github.com (MwithM)
Date: Sat, 30 Oct 2021 12:01:36 -0700
Subject: [bisq-network/compensation] For Cycle 29 (#923)
In-Reply-To: <bisq-network/compensation/issues/923@github.com>
References: <bisq-network/compensation/issues/923@github.com>
Message-ID: <bisq-network/compensation/issues/923/955577869@github.com>

Closed as accepted.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/923#issuecomment-955577869
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211030/3921d233/attachment.htm>

From notifications at github.com  Sat Oct 30 21:01:37 2021
From: notifications at github.com (MwithM)
Date: Sat, 30 Oct 2021 12:01:37 -0700
Subject: [bisq-network/compensation] For Cycle 29 (#923)
In-Reply-To: <bisq-network/compensation/issues/923@github.com>
References: <bisq-network/compensation/issues/923@github.com>
Message-ID: <bisq-network/compensation/issue/923/issue_event/5544256386@github.com>

Closed #923.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/923#event-5544256386
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211030/f6213d9d/attachment.htm>

From notifications at github.com  Sat Oct 30 21:01:47 2021
From: notifications at github.com (bisq-bot[bot])
Date: Sat, 30 Oct 2021 12:01:47 -0700
Subject: [bisq-network/compensation] For Cycle 29 (Issue #930)
In-Reply-To: <bisq-network/compensation/issues/930@github.com>
References: <bisq-network/compensation/issues/930@github.com>
Message-ID: <bisq-network/compensation/issues/930/955577884@github.com>


## Issuance by Team:
|team|amount BSQ|amount USD|
|---|---|---|
|dev|148.22|230.00|
|ops|83.78|130.00|

Total Issuance: 232.00 BSQ (equivalent to: 360.00 USD)



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/930#issuecomment-955577884
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211030/0ae7f776/attachment.htm>

From notifications at github.com  Sat Oct 30 21:01:50 2021
From: notifications at github.com (MwithM)
Date: Sat, 30 Oct 2021 12:01:50 -0700
Subject: [bisq-network/compensation] For Cycle 29 (Issue #930)
In-Reply-To: <bisq-network/compensation/issues/930@github.com>
References: <bisq-network/compensation/issues/930@github.com>
Message-ID: <bisq-network/compensation/issues/930/955577892@github.com>

Closed as accepted.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/930#issuecomment-955577892
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211030/26988afc/attachment.htm>

From notifications at github.com  Sat Oct 30 21:01:51 2021
From: notifications at github.com (MwithM)
Date: Sat, 30 Oct 2021 12:01:51 -0700
Subject: [bisq-network/compensation] For Cycle 29 (Issue #930)
In-Reply-To: <bisq-network/compensation/issues/930@github.com>
References: <bisq-network/compensation/issues/930@github.com>
Message-ID: <bisq-network/compensation/issue/930/issue_event/5544256580@github.com>

Closed #930.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/930#event-5544256580
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211030/f2685d3e/attachment.htm>

From notifications at github.com  Sat Oct 30 21:02:19 2021
From: notifications at github.com (MwithM)
Date: Sat, 30 Oct 2021 12:02:19 -0700
Subject: [bisq-network/compensation] For Cycle 29 (Issue #928)
In-Reply-To: <bisq-network/compensation/issues/928@github.com>
References: <bisq-network/compensation/issues/928@github.com>
Message-ID: <bisq-network/compensation/issue/928/issue_event/5544256935@github.com>

Closed #928.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/928#event-5544256935
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211030/a5ef411a/attachment-0001.htm>

From notifications at github.com  Sat Oct 30 21:03:02 2021
From: notifications at github.com (bisq-bot[bot])
Date: Sat, 30 Oct 2021 12:03:02 -0700
Subject: [bisq-network/compensation] For Cycle 29 (Issue #924)
In-Reply-To: <bisq-network/compensation/issues/924@github.com>
References: <bisq-network/compensation/issues/924@github.com>
Message-ID: <bisq-network/compensation/issues/924/955578039@github.com>


## Issuance by Team:
|team|amount BSQ|amount USD|
|---|---|---|
|admin|32.26|50.00|

Total Issuance: 32.26 BSQ (equivalent to: 50.00 USD)



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/924#issuecomment-955578039
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211030/cbbada9e/attachment.htm>

From notifications at github.com  Sat Oct 30 21:03:06 2021
From: notifications at github.com (MwithM)
Date: Sat, 30 Oct 2021 12:03:06 -0700
Subject: [bisq-network/compensation] For Cycle 29 (Issue #924)
In-Reply-To: <bisq-network/compensation/issues/924@github.com>
References: <bisq-network/compensation/issues/924@github.com>
Message-ID: <bisq-network/compensation/issue/924/issue_event/5544257548@github.com>

Closed #924.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/924#event-5544257548
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211030/3884026e/attachment.htm>

From notifications at github.com  Sat Oct 30 21:03:07 2021
From: notifications at github.com (MwithM)
Date: Sat, 30 Oct 2021 12:03:07 -0700
Subject: [bisq-network/compensation] For Cycle 29 (Issue #924)
In-Reply-To: <bisq-network/compensation/issues/924@github.com>
References: <bisq-network/compensation/issues/924@github.com>
Message-ID: <bisq-network/compensation/issues/924/955578047@github.com>

Closed as accepted.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/924#issuecomment-955578047
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211030/abfc6e22/attachment.htm>

From notifications at github.com  Sat Oct 30 21:04:19 2021
From: notifications at github.com (MwithM)
Date: Sat, 30 Oct 2021 12:04:19 -0700
Subject: [bisq-network/compensation] For Cycle 29 (Issue #935)
In-Reply-To: <bisq-network/compensation/issues/935@github.com>
References: <bisq-network/compensation/issues/935@github.com>
Message-ID: <bisq-network/compensation/issues/935/955578170@github.com>

Closed as not submitted.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/935#issuecomment-955578170
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211030/5ca965e0/attachment.htm>

From notifications at github.com  Sat Oct 30 21:04:19 2021
From: notifications at github.com (MwithM)
Date: Sat, 30 Oct 2021 12:04:19 -0700
Subject: [bisq-network/compensation] For Cycle 29 (Issue #935)
In-Reply-To: <bisq-network/compensation/issues/935@github.com>
References: <bisq-network/compensation/issues/935@github.com>
Message-ID: <bisq-network/compensation/issue/935/issue_event/5544258509@github.com>

Closed #935.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/935#event-5544258509
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211030/3eac793f/attachment.htm>

From notifications at github.com  Sat Oct 30 21:04:46 2021
From: notifications at github.com (bisq-bot[bot])
Date: Sat, 30 Oct 2021 12:04:46 -0700
Subject: [bisq-network/compensation] For Cycle 29 (Issue #933)
In-Reply-To: <bisq-network/compensation/issues/933@github.com>
References: <bisq-network/compensation/issues/933@github.com>
Message-ID: <bisq-network/compensation/issues/933/955578227@github.com>


## Issuance by Team:
|team|amount BSQ|amount USD|
|---|---|---|
|support|1037.33|1607.86|

Total Issuance: 1037.33 BSQ (equivalent to: 1607.86 USD)



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/933#issuecomment-955578227
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211030/7c71b125/attachment.htm>

From notifications at github.com  Sat Oct 30 21:05:05 2021
From: notifications at github.com (MwithM)
Date: Sat, 30 Oct 2021 12:05:05 -0700
Subject: [bisq-network/compensation] For Cycle 29 (Issue #933)
In-Reply-To: <bisq-network/compensation/issues/933@github.com>
References: <bisq-network/compensation/issues/933@github.com>
Message-ID: <bisq-network/compensation/issue/933/issue_event/5544259174@github.com>

Closed #933.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/933#event-5544259174
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211030/f750e5fa/attachment-0001.htm>

From notifications at github.com  Sat Oct 30 21:05:05 2021
From: notifications at github.com (MwithM)
Date: Sat, 30 Oct 2021 12:05:05 -0700
Subject: [bisq-network/compensation] For Cycle 29 (Issue #933)
In-Reply-To: <bisq-network/compensation/issues/933@github.com>
References: <bisq-network/compensation/issues/933@github.com>
Message-ID: <bisq-network/compensation/issues/933/955578258@github.com>

Closed as accepted.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/933#issuecomment-955578258
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211030/d27f79e5/attachment.htm>

From notifications at github.com  Sat Oct 30 21:11:36 2021
From: notifications at github.com (MwithM)
Date: Sat, 30 Oct 2021 12:11:36 -0700
Subject: [bisq-network/compensation] BSQ rate for Cycle 30 is 1.77USD per BSQ
 (Issue #937)
Message-ID: <bisq-network/compensation/issues/937@github.com>

The recommended rate to be used for compensation requests on cycle 30 is **1.77USD/BSQ.**

![imagen](https://user-images.githubusercontent.com/50149324/139555674-c86f1101-546e-4f02-9e15-abd86e4f8111.png)

Rate for last cycle: #921
More info about the Compensation process at https://bisq.wiki/Compensation

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/937
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211030/5c1de3f5/attachment.htm>

From notifications at github.com  Sat Oct 30 21:17:51 2021
From: notifications at github.com (MwithM)
Date: Sat, 30 Oct 2021 12:17:51 -0700
Subject: [bisq-network/proposals] BSQ trading fee update for Cycle 29
 (Issue #345)
In-Reply-To: <bisq-network/proposals/issues/345@github.com>
References: <bisq-network/proposals/issues/345@github.com>
Message-ID: <bisq-network/proposals/issues/345/955579702@github.com>

The proposals were accepted and the wiki has been updated.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/proposals/issues/345#issuecomment-955579702
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211030/a7744057/attachment.htm>

From notifications at github.com  Sat Oct 30 21:18:07 2021
From: notifications at github.com (MwithM)
Date: Sat, 30 Oct 2021 12:18:07 -0700
Subject: [bisq-network/compensation] BSQ rate for Cycle 29 is 1.55 USD per
 BSQ (#921)
In-Reply-To: <bisq-network/compensation/issues/921@github.com>
References: <bisq-network/compensation/issues/921@github.com>
Message-ID: <bisq-network/compensation/issue/921/issue_event/5544269557@github.com>

Closed #921.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/921#event-5544269557
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211030/736294ee/attachment.htm>

From notifications at github.com  Sat Oct 30 21:31:24 2021
From: notifications at github.com (MwithM)
Date: Sat, 30 Oct 2021 12:31:24 -0700
Subject: [bisq-network/compensation] Cycle 29 deadline is October 17th
 (#922)
In-Reply-To: <bisq-network/compensation/issues/922@github.com>
References: <bisq-network/compensation/issues/922@github.com>
Message-ID: <bisq-network/compensation/issue/922/issue_event/5544279787@github.com>

Closed #922.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/922#event-5544279787
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211030/a989fd74/attachment.htm>

From notifications at github.com  Sat Oct 30 23:14:47 2021
From: notifications at github.com (pazza)
Date: Sat, 30 Oct 2021 14:14:47 -0700
Subject: [bisq-network/support] Fee reimbursement for trade 8hqzF (Issue
 #1016)
In-Reply-To: <bisq-network/support/issues/1016@github.com>
References: <bisq-network/support/issues/1016@github.com>
Message-ID: <bisq-network/support/issues/1016/955594150@github.com>

Hi @pfergi42 thanks for posting. I can see you have lost miner and maker fees on this trade.

@leo816 with arrange compensation in the next reimbursement cycle. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/support/issues/1016#issuecomment-955594150
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211030/e20649c1/attachment.htm>

From notifications at github.com  Sat Oct 30 23:20:45 2021
From: notifications at github.com (pazza)
Date: Sat, 30 Oct 2021 14:20:45 -0700
Subject: [bisq-network/bisq] Make clone offer feature more visible (Issue
 #5774)
In-Reply-To: <bisq-network/bisq/issues/5774@github.com>
References: <bisq-network/bisq/issues/5774@github.com>
Message-ID: <bisq-network/bisq/issues/5774/955595036@github.com>

It would also be a great addition to clone your existing offers from the 'offer book'.

Right click offer, or click associated clone icon, and you are take to create offer screen with the details pre-filled.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5774#issuecomment-955595036
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211030/4565904c/attachment-0001.htm>

From notifications at github.com  Sun Oct 31 01:09:20 2021
From: notifications at github.com (pazza)
Date: Sat, 30 Oct 2021 16:09:20 -0700
Subject: [bisq-network/growth] Add Monese as a payment method (popular
 mobile bank app in UK and Europe) (#227)
In-Reply-To: <bisq-network/growth/issues/227@github.com>
References: <bisq-network/growth/issues/227@github.com>
Message-ID: <bisq-network/growth/issues/227/955606039@github.com>

Hi @jmacxx the implementation of this is missing the "account owner full name field"

It is not a deal breaker but will mean the account owner full name will need to be shared in trader chat.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/growth/issues/227#issuecomment-955606039
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211030/527b4c72/attachment.htm>

From notifications at github.com  Sun Oct 31 01:17:37 2021
From: notifications at github.com (pazza)
Date: Sat, 30 Oct 2021 16:17:37 -0700
Subject: [bisq-network/growth] Satispay (#213)
In-Reply-To: <bisq-network/growth/issues/213@github.com>
References: <bisq-network/growth/issues/213@github.com>
Message-ID: <bisq-network/growth/issues/213/955606677@github.com>

Hi @jmacxx the implementation of Satispay is missing the "account owner full name field"

It is not a deal breaker but will mean the account owner full name will need to be shared in trader chat.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/growth/issues/213#issuecomment-955606677
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211030/570488f0/attachment.htm>

From notifications at github.com  Sun Oct 31 08:55:02 2021
From: notifications at github.com (MwithM)
Date: Sun, 31 Oct 2021 00:55:02 -0700
Subject: [bisq-network/compensation] Cycle 30 deadline is November 17th (Issue
 #938)
Message-ID: <bisq-network/compensation/issues/938@github.com>

The deadline for submitting compensations requests for review is **November 17th**. More deatails at: https://github.com/bisq-network/compensation/issues

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/compensation/issues/938
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211031/f20d9d93/attachment.htm>

From notifications at github.com  Sun Oct 31 08:59:28 2021
From: notifications at github.com (MwithM)
Date: Sun, 31 Oct 2021 00:59:28 -0700
Subject: [bisq-network/roles] Compensation Maintainer (#86)
In-Reply-To: <bisq-network/roles/issues/86@github.com>
References: <bisq-network/roles/issues/86@github.com>
Message-ID: <bisq-network/roles/issues/86/955654396@github.com>

### Cycle 29 report

- 11 compensation [requests](https://github.com/bisq-network/compensation/milestone/20) were accepted, 2 not submitted.
- Fee [rate](https://github.com/bisq-network/compensation/issues/937) and [deadline](https://github.com/bisq-network/compensation/issues/938) for submissions has been announced.
- BSQ trading fee was [updated](https://github.com/bisq-network/proposals/issues/345).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/roles/issues/86#issuecomment-955654396
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211031/89438db9/attachment.htm>

From notifications at github.com  Sun Oct 31 11:07:00 2021
From: notifications at github.com (BtcContributor)
Date: Sun, 31 Oct 2021 03:07:00 -0700
Subject: [bisq-network/roles] BTC donation address owner ("Burningman")
 (#80)
In-Reply-To: <bisq-network/roles/issues/80@github.com>
References: <bisq-network/roles/issues/80@github.com>
Message-ID: <bisq-network/roles/issues/80/955671044@github.com>

Is @burningman3 still buying on Sunday? 
There have been any new notice since 1 month.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/roles/issues/80#issuecomment-955671044
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211031/e2045963/attachment.htm>

From notifications at github.com  Sun Oct 31 11:49:21 2021
From: notifications at github.com (waleehoohaa)
Date: Sun, 31 Oct 2021 03:49:21 -0700
Subject: [bisq-network/support] Fee reimbursement for trade 93203 (Issue #1017)
Message-ID: <bisq-network/support/issues/1017@github.com>

![attention](https://user-images.githubusercontent.com/93359441/139579008-590d6b51-2a43-4e39-9d55-6d45c67f9e8b.png)


![93203](https://user-images.githubusercontent.com/93359441/139578718-2c17dfaa-903a-49ba-9f95-2ceacde61eb7.jpg)

Maker: 3f1e26b3b080c3a3c9e394c492bf29cd7452ee88defc6faebcd2ffc85585f9b9
Taker: 83ab87a465a9709c84482d27671e96fe48313d807c4e62d1fdd86a5f4b9e40ce

Bisq version: 1.7.5
BTC address for reimbursement: bc1q0p96wvdn7nkg03fyuuk86cw0sn2yspe9jecjqz

Other notes: Trade failed because deposit transaction is missing. I recently upgraded to v1.7.5 after another recent failed trade. Please reimburse the trade/mining fees to the above address. Thank you.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/support/issues/1017
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211031/c7129b9e/attachment-0001.htm>

From notifications at github.com  Sun Oct 31 18:50:24 2021
From: notifications at github.com (chimp1984)
Date: Sun, 31 Oct 2021 10:50:24 -0700
Subject: [bisq-network/bisq] Improve DAO state management (Issue #5783)
In-Reply-To: <bisq-network/bisq/issues/5783@github.com>
References: <bisq-network/bisq/issues/5783@github.com>
Message-ID: <bisq-network/bisq/issues/5783/955764177@github.com>

Here an update of my work on that:

I tried out a few different key/value DB solutions ([MapDB](https://github.com/jankotek/mapdb), [LevelDB](https://github.com/pcmind/leveldb), [LMDB](https://github.com/lmdbjava/lmdbjava), [Xodus](https://github.com/JetBrains/xodus), [Chronicle-Map](https://github.com/OpenHFT/Chronicle-Map)...). I did not get Xodus and Chronicle-Map fully working for my example case due APIs which did not fit well to my use cases. I also tried to use the standard logging framework by adding a custom logger but it would have required to write a custom rolling file adapter for our needs and parsing all byte array data to hex was not convenient as well (and would have been probably slow), so did not follow further on that approach.

LevelDB was my favorite candidate for a DB solution but after reading more about its concepts I realized that it does not fit really our use case and requirements as it would not provide determinisitic storage files. It also would add risky dependencies (from the not much used java lib) and would be an overkill for what we need. I tried it also in the PersistenceManager for all sotrage files, but that would lead to pretty bad performance as there are too many compactation cycles triggered by the kind of persistence we do (replacing data and not mainly appening data).

The goal to get off-heap by using memory mapped files (e..g by using MappedByteBuffer,...) would not have led to the desired result as we use Protobuf and that does not has zero-copy support (Capt'n Proto and FlatBuffers does). Also that would have been a large refactoring and not really sure if that would work out well. But its something to keep in mind for Misq/Bisq 2 as it could reduce a lot of memory footprint and performance by avoiding those copy operations and parsing as with Capt'n Proto. 

So after all that, I came to the conclusing its best to do only the minimal changes where it hurts most (BSQ Blocks) and use the simple file based model we use already in the PersistenceManager but split up the blocks in buckets.

Here are out requirements:
- Read only once at startup
- Write infrequent (each 20 blocks for snapshotting)
- Persist in a deterministic manner so we can ship files as resourced with a deterministic set of blocks
- Avoid manual management of the resource files as we require for the version based historical data stores
- Fast write and read, low memory costs
- If possible avoid adding new dependencies, specially of not from well known sources
- If possible avoid JNI based libraries as that might reduce capabilty with some hardware (Raspberry Pi, Apple M1,...)

Implemented solution:
- Split BSQ blocks in buckets of 1000 blocks (about 1 MB, about each week a new bucket) and store those inside a BsqBlocks directory. Buckets are named with the block range inside that bucket (BsqBlocks_584001-585000)
- Auto-migrating existing DaoStateStore to the new model by adding all blocks to the new data structure and then not storing blocks anymore inside the DaoState which is persisted in DaoStateStore. We keep the rest of the DaoStateStore untouched (blockHashes, DaoState). So only the blocks got extracted to its own persistence structure.
- At snapshots we keep only the blocks from the last persisted snapshot up to the most recent (usually 20 blocks as that is the snapshot interval). This reduces memory requirement for the snapshot from 135 MB to a few kb. The rest of the DaoState is about 18MB. The Hashes could be treated also according to the new model but as they are tiny its not worth it.

I made some performance comparision from the branch with the optimizations for the hashChain and that new implementation.

I tested with a fresh start syncing from resources and full-mode for daoStateMonitoring (otherwise we do not do snapshots during parsing).

Here are the results:

**Old version:**
READ:
Reading DaoStateStore about 3-4 sec

WRITE:
Writing the serialized DaoStateStore completed in 2-3 sec

SNAPSHOTS:
Parsing 5808 blocks took 2010.5 seconds (33.51 min.) / 346.16 ms in average / block 
GC reduced memory by 520 MB. Total memory before/after: 2.441 GB/1.934 GB. Took 709 ms. 
Total GC invocations: 242 / Total GC time 125.883 sec 

**New version:**
READ:
Reading and deserializing 135814 blocks took 1342 ms 
PersistenceManager: Reading DaoStateStore completed in 303 ms 
-> Total time for datState+blocks: about 1.5-2 sec

WRITE:
Persist (serialize+write) 806 blocks took 15 ms 
Writing the serialized DaoStateStore completed in 265 msec 
-> Total time for datState+blocks: about 200-300 ms

SNAPSHOTS:
Parsing 5808 blocks took 1575.13 seconds (26.25 min.) / 271.2 ms in average / block 
GC reduced memory by 667 MB. Total memory before/after: 2.348 GB/1.696 GB. Took 516 ms. 
Total GC invocations: 130 / Total GC time 60.478 sec 

So read performance is about half of the old verison, write performance about 10 times faster and total parsing is about 25% faster (hashing is the slow operation here) and there is about 50% work for GC (I am still in the process to optimize that further). Peak memory was also a bit lower in the new version.








-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5783#issuecomment-955764177
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211031/a4c16248/attachment.htm>

From notifications at github.com  Sun Oct 31 19:05:31 2021
From: notifications at github.com (chimp1984)
Date: Sun, 31 Oct 2021 11:05:31 -0700
Subject: [bisq-network/bisq] Bsq swap: Implementation [3] (PR #5775)
In-Reply-To: <bisq-network/bisq/pull/5775@github.com>
References: <bisq-network/bisq/pull/5775@github.com>
Message-ID: <bisq-network/bisq/pull/5775/push/8278103887@github.com>

@chimp1984 pushed 1 commit.

b23d79384972da3aa6b0c6b6da55c5fe5cd81d30  Apply patch from ghubstan


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/bisq-network/bisq/pull/5775/files/1e7de9e8b75aead8c2d6cc6b87b69a84b3a193cb..b23d79384972da3aa6b0c6b6da55c5fe5cd81d30
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211031/5cd078fd/attachment.htm>

From notifications at github.com  Sun Oct 31 19:08:08 2021
From: notifications at github.com (chimp1984)
Date: Sun, 31 Oct 2021 11:08:08 -0700
Subject: [bisq-network/bisq] Bsq swap: Implementation [3] (PR #5775)
In-Reply-To: <bisq-network/bisq/pull/5775@github.com>
References: <bisq-network/bisq/pull/5775@github.com>
Message-ID: <bisq-network/bisq/pull/5775/review/793745768@github.com>

@chimp1984 commented on this pull request.



> @@ -145,8 +145,12 @@ public void initialize() {
     protected void activate() {
         if (DevEnv.isDaoActivated()) {
 
-            // Hide dao new badge if user saw this section
-            preferences.dontShowAgain(DaoPresentation.DAO_NEWS, true);
+            if (preferences.showAgain(DaoPresentation.DAO_NEWS)) {
+                preferences.dontShowAgain(DaoPresentation.DAO_NEWS, true);
+                new Popup().headLine(Res.get("news.bsqSwap.title"))
+                        .information(Res.get("news.bsqSwap.description"))

I pinged @m52go . I think he had already the content but I dont see a PR yet.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5775#discussion_r739857033
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211031/37000ac8/attachment.htm>

From notifications at github.com  Sun Oct 31 19:08:59 2021
From: notifications at github.com (chimp1984)
Date: Sun, 31 Oct 2021 11:08:59 -0700
Subject: [bisq-network/bisq] Bsq swap: Implementation [3] (PR #5775)
In-Reply-To: <bisq-network/bisq/pull/5775@github.com>
References: <bisq-network/bisq/pull/5775@github.com>
Message-ID: <bisq-network/bisq/pull/5775/push/8278115423@github.com>

@chimp1984 pushed 1 commit.

66f6ff69fca83d051e9de441ea959424b3f4d8ea  Rename package


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/bisq-network/bisq/pull/5775/files/b23d79384972da3aa6b0c6b6da55c5fe5cd81d30..66f6ff69fca83d051e9de441ea959424b3f4d8ea
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211031/0b86ac4d/attachment-0001.htm>

From notifications at github.com  Sun Oct 31 19:09:09 2021
From: notifications at github.com (chimp1984)
Date: Sun, 31 Oct 2021 11:09:09 -0700
Subject: [bisq-network/bisq] Bsq swap: Implementation [3] (PR #5775)
In-Reply-To: <bisq-network/bisq/pull/5775@github.com>
References: <bisq-network/bisq/pull/5775@github.com>
Message-ID: <bisq-network/bisq/pull/5775/review/793745878@github.com>

@chimp1984 commented on this pull request.



> + *
+ * Bisq is free software: you can redistribute it and/or modify it
+ * under the terms of the GNU Affero General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or (at
+ * your option) any later version.
+ *
+ * Bisq is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU Affero General Public
+ * License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with Bisq. If not, see <http://www.gnu.org/licenses/>.
+ */
+
+package bisq.core.offer.placeoffer.bsqswap;

Ops. Renamed in a new commit.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5775#discussion_r739857207
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211031/e0504508/attachment.htm>

From notifications at github.com  Sun Oct 31 19:10:57 2021
From: notifications at github.com (chimp1984)
Date: Sun, 31 Oct 2021 11:10:57 -0700
Subject: [bisq-network/bisq] Bsq swap: Implementation [3] (PR #5775)
In-Reply-To: <bisq-network/bisq/pull/5775@github.com>
References: <bisq-network/bisq/pull/5775@github.com>
Message-ID: <bisq-network/bisq/pull/5775/review/793746048@github.com>

@chimp1984 commented on this pull request.



> +        if (!isTakeOfferScreen)
+            rows++;
+
+        addTitledGroupBg(gridPane, ++rowIndex, rows, Res.get("shared.Offer"));
+
+        String bsqDirectionInfo = "";
+        String btcDirectionInfo = "";
+        OfferDirection direction = offer.getDirection();
+        String currencyCode = offer.getCurrencyCode();
+        String offerTypeLabel = Res.get("shared.offerType");
+        String toReceive = " " + Res.get("shared.toReceive");
+        String toSpend = " " + Res.get("shared.toSpend");
+        String minus = " - ";
+        String plus = " + ";
+        String minerFeePostFix = Res.get("tradeDetailsWindow.txFee");
+        String tradeFeePostFix = Res.get("shared.tradeFee");

When creating the offer the second step shows all the fees. I was a bit lazy to add it here as well and as the tx fee are calculated based on the inputs/change its not that trivial. But yes could be added.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5775#discussion_r739857427
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211031/1c9e9e8c/attachment.htm>

From notifications at github.com  Sun Oct 31 19:23:06 2021
From: notifications at github.com (chimp1984)
Date: Sun, 31 Oct 2021 11:23:06 -0700
Subject: [bisq-network/bisq] Extract persistence of blocks [5] (PR #5790)
Message-ID: <bisq-network/bisq/pull/5790@github.com>

Based on https://github.com/bisq-network/bisq/pull/5782
(will merge/rebase once other PRs are in master)
Starts at 107854c

Fixes https://github.com/bisq-network/bisq/issues/5783
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/5790

-- Commit Summary --

  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/8fbccb75479ffcb1e7b1fcc0feed03aa7fc55735">Bump version number for v1.7.5</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/e39ae59683f6c45fd741063a364d7ae8366d43c9">Update translations for v1.7.5</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/48a0ebe30973915fd80ff778a131d33a8012a616">Add new v3 onions for wiz&#39;s bitcoin nodes</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/577b07ba9a9b50fdb76d9cdb2d675781c17eed53">Move OfferPayload into package bisq.core.offer.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/19f813eea3b0ed753e8bc90754585e1a4f0344c0">Move CreateOfferService into package bisq.core.offer.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/d98cb278057e27907ba894f696732026a5ba4820">Move MarketPriceNotAvailableException into package bisq.core.offer.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/346fc79094cc0941b2ede33edb3d8d778b81c1a5">Move MutableOfferPayloadFields into package bisq.core.offer.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/8a4c05c1e48b9fd81640456defecc8d472cb8f6c">Move TriggerPriceService into package bisq.core.offer.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/ade5d322374f455a54dd48e9e82e754e9e596b5f">Move TakeOfferModel into package bisq.core.offer.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/20d298061d8c4213bd46f62eedf623f610654288">Move AvailabilityResult into package bisq.core.offer.availability</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/0107519f4307aa594b1a695515d0b31eab39da6c">Move bisq.core.offer.messages package into package bisq.core.offer.availability</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/ed9f248c277afb23464860913119835f79e6395e">Move content of bisq.core.offer.placeoffer package into package bisq.core.offer.placeoffer.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/b584fdf419b031818016505596aa6b899e492972">Rename OfferFilter to OfferFilterService</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/0e23cbe24e63b2a7e792bd496db510ea028e4388">Move Contract, SellerAsMakerTrade, SellerAsTakerTrade, SellerTrade,</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/c0cca781de5646ccf7836341f15ae65e7c30b6e6">Make updateDepositTxFromWallet public</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/0f7cfa99d51d87f378d994c75ef9ec3c8303619c">Move Trade to bisq.core.trade.model.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/5944218a4bb31d914f08b96560f0b1fb3aad61b1">Move MakerTrade and TakerTrade to bisq.core.trade.model package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/5a0145d1d94b31c916f6dca30fbdaa4b60dd67e1">Move Tradable to bisq.core.trade.model package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/81ec06d0dcf397a224fbc950be2fd67ea3f7fb1e">Move TradableList to bisq.core.trade.model package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/2489bbc119db6095abef7a7c659cd851b8ad0509">Make FluentProtocol.Event public</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/c0d13083c8c64ea486a1013059d3a5e1d4fca32e">Make setup in FluentProtocol public</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/87c12fda8c9d95cac288235dd9655ba707ac3391">Move protocol classes to bisq.core.trade.protocol.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/babd70cc2a8230ba72cf8ed205ec326ef2d24969">Move tasks package into bisq.core.trade.protocol.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/5099d974353f424af82d611b416e64e23d123202">Move TradingPeer into bisq.core.trade.protocol.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/a212cec19c9bb32d9bd781e9ac33d75c552fa4a9">Move messages package into bisq.core.trade.protocol.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/c9817ed6dbb1709077b46d07da50566b3a3545ca">Move ClosedTradableManager, FailedTradesManager into bisq.core.trade.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/1b74b4efe9bb3907c0d9dfdf0b482c4cad8b24af">Rename CleanupMailboxMessages to CleanupMailboxMessagesService</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/2141f8f665dab4933022f38d1a2c6b1e42e51d84">Move CleanupMailboxMessagesService, ClosedTradeUtil to package bisq.core.trade.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/f871e8339d294334f46b42ee41572d6c54177a80">Move TransactionResultHandler, TradeResultHandler to package bisq.core.trade.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/71c663eb5306a6e7cbd05d55e95f984eaddd95ec">Move TradeDataValidation, DumpDelayedPayoutTx, TradeDataValidation, TradeUtil, TradeTxException to package bisq.core.trade.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/26e2676268f409aa12d9d9e5a814c587c4a8a01b">Rename ProcessModelServiceProvider to Provider</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/c282b700010479b5c67f978eb434b5d41529f669">Rename txID to txId</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/30dd5683ef08083949252f4924065389f4a4bc15">Move createoffer package inside bisq.desktop.main.offer.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/0cd0e16b53870ff663c357e9e78adf92be157dbc">Move takeoffer package inside bisq.desktop.main.offer.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/4169a8719bf8984e6e1afd8fe67eca987682e807">Move MutableOffer view classes into bisq.desktop.main.offer.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/a2a7e87af5ef944f17dbdc2e0a531a20fd7a854e">Move OfferDataModel, OfferViewUtil into bisq.desktop.main.offer.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/a9f4bb76b687f724db84b37f69603b9289a5ea6a">Rename FeeUtil to OfferViewModelUtil</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/1e03aae2ac81ada51fc8a319b83be5209a1684c7">Move OfferViewModelUtil into bisq.desktop.main.offer.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/72284d7d9f7c25236010a88389e88c218012248d">Cleanups, refromatting, add final qualifier</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/71eec7b2e0c98b8b036d4ab3fa52cc4701e0fc30">Move TradingPeer to package bisq.core.trade.protocol.bisq_v1.model</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/e1efc5e96fc6909e28446876c36393cc3e80a4e4">Make setPaymentStartedAckMessage and setDepositTxSentAckMessage public</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/760732f03a2cff68590935bd92f63ac81793f823">Move ProcessModel to package bisq.core.trade.protocol.bisq_v1.model</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/94d3638d9841c8653a5db40fa5b1c52fa3e3b0e4">Remove m52go bitcoin node</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/41d9d3f505516ed34c1f33d86952ef8f4d036d75">Move OfferPayload into package bisq.core.offer.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/edf5c3e097094f35e4f25c439416cff196afbf76">Move CreateOfferService into package bisq.core.offer.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/4341a7e0d2c5610baa95b09bdb82584b520bc776">Move MarketPriceNotAvailableException into package bisq.core.offer.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/042476a68a22ea95eb9faaa84eeed8594a6c3d06">Move MutableOfferPayloadFields into package bisq.core.offer.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/d9fd8a45f72d377e2ba04c95df1974aa44e36b87">Move TriggerPriceService into package bisq.core.offer.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/e348000cb16923ab1b973ad9aa1bb0d2f616cc16">Move TakeOfferModel into package bisq.core.offer.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/a2d1e8888d0c6274121428b86cdd39b32f3d6ba0">Move AvailabilityResult into package bisq.core.offer.availability</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/1badd699a4a6a82910701a89c5fbad4115985503">Move bisq.core.offer.messages package into package bisq.core.offer.availability</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/7197b316fccd63e2f0b66d27d167ea6cd0452c11">Move content of bisq.core.offer.placeoffer package into package bisq.core.offer.placeoffer.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/1b4c4871c0d03e00dbc07571ac120d2a3a9c534d">Rename OfferFilter to OfferFilterService</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/1e9b6065441d27873ad962920aed363ed9a25aa0">Move Contract, SellerAsMakerTrade, SellerAsTakerTrade, SellerTrade,</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/8b21b85c3e8fd20b8d5c541ee6ad6ee5e099a0c6">Make updateDepositTxFromWallet public</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/d42242762ffb448e8ebdda5e311602e6db60f1c7">Move Trade to bisq.core.trade.model.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/fc3177c23f06d16eed25408fe7064f5364b2e42f">Move MakerTrade and TakerTrade to bisq.core.trade.model package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/58cfcffeb970ffc81d9ba6979eb256892ce00ff2">Move Tradable to bisq.core.trade.model package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/3474a2b69520d52af239c79cbaa65135bdc776d5">Move TradableList to bisq.core.trade.model package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/d7b2e99e43a404c6121dcbb94a0acaf028037dbe">Make FluentProtocol.Event public</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/e3eea6350cb07f3c517e0fc148b4d771fff26afc">Make setup in FluentProtocol public</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/1b2e798faaa64fa19a3cd858c99c6af22d38fa99">Move protocol classes to bisq.core.trade.protocol.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/508296c2a3b609ab9166d250226271622f430d34">Move tasks package into bisq.core.trade.protocol.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/97906e05db34277a96631c4e4eeaef91dd732f04">Move TradingPeer into bisq.core.trade.protocol.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/cbf2822cdf422cfca7404a0cb4486f498bc8a171">Move messages package into bisq.core.trade.protocol.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/fd6934c4e3f1fd93744343bc7c1f907b7e981f8c">Move ClosedTradableManager, FailedTradesManager into bisq.core.trade.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/fe2871baa50c5f196e92458d38bdda53ab9b6d77">Rename CleanupMailboxMessages to CleanupMailboxMessagesService</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/e80cdf8ac7217ab0e2025be10e0feaa6dc8a5ee6">Move CleanupMailboxMessagesService, ClosedTradeUtil to package bisq.core.trade.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/956ffc902d2258199a07f96adaa91ff98ae2411a">Move TransactionResultHandler, TradeResultHandler to package bisq.core.trade.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/eacf446ab422352bb303eb9830b3dc03d9adc8e4">Move TradeDataValidation, DumpDelayedPayoutTx, TradeDataValidation, TradeUtil, TradeTxException to package bisq.core.trade.bisq_v1</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/e1de502a9bf1aae7e87830096934ac6a1684665d">Rename ProcessModelServiceProvider to Provider</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/2733af955a3ec04d4311a18b691415933146b35c">Rename txID to txId</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/932c0f856aa36ee87cb55dbb3b4e11992ed2b13c">Move createoffer package inside bisq.desktop.main.offer.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/0efa0bd7cad6278faac96edc64f4008061a7998f">Move takeoffer package inside bisq.desktop.main.offer.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/601956dc1fe2927549ff7723ef8cd25f16f646ee">Move MutableOffer view classes into bisq.desktop.main.offer.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/9777005ec7e44b4efb123e7d5a9c48976bde2a81">Move OfferDataModel, OfferViewUtil into bisq.desktop.main.offer.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/4a9db790682506fdda88f6d31f5874fc473dba2e">Rename FeeUtil to OfferViewModelUtil</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/25bbad1f9c9f5383d8af6f64cbacdb74df2b1d01">Move OfferViewModelUtil into bisq.desktop.main.offer.bisq_v1 package</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/777287af95cfd791389b0cdbf9eecf9b98913496">Cleanups, refromatting, add final qualifier</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/401880b64e8f8645e42d6a34179fcc71000c7363">Move TradingPeer to package bisq.core.trade.protocol.bisq_v1.model</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/afed78813d3d81c1ca4d63adac6ca0d5cffb1741">Make setPaymentStartedAckMessage and setDepositTxSentAckMessage public</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/734d429cc9612709bcee8c0e4784070406daf731">Move ProcessModel to package bisq.core.trade.protocol.bisq_v1.model</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/dca0c93f477f66da22f6eeba2532fffb844dde90">Cleanups</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/e75296557739f6b8ae86bd3004781fd268036a9e">Add linebreak in error popup</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/9f3034e91c83559c5a37b7c235c0c997a0e84042">Fix layout/text issues</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/dc82fbabab24ab385b085afdfe0ef88c62849970">Increase visibility</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/8768345b74148ab49f57cefef9952bb2ad5667be">Remove Inject annotation at abstract classes</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/d1d1706a7f05539b930db6437f20b6934576515e">Add delegate methods to offer</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/dfbc746d5b4dc3fd4c115adb34498089e744918d">Move Offer.Direction one level up and rename to OfferDirection</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/6cf0a7c126fb2bf43ca004bb139b5b856ad1d67e">Rename paymentMethod.isAsset to paymentMethod.isBlockchain</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/dad19ba1c174087e3f29f66577739409e32bc544">Add isFiat and isAltcoin methods.</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/88198be7ffbfe00854207e3f9e6e907ffd7581b2">Rename availableConfirmedBalance to availableBalance</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/d4bb026e3e7ce64710a947557962e0f4e32bfc26">Only check for localhost btc node if mainnet</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/f8751a8c4d5974068864f90729c889411f86ae73">Make TxConfidenceListener and its onTransactionConfidenceChanged method abstract</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/a927bea71f236769af7d5c3bba37488fd58370ec">Add scriptTypeId to RawTransactionInput</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/75072ebc26acef94bfe15eba5eaa3c152c63a416">Add deprecated annotation, null checks and comment to getRawInputFromTransactionInput</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/561ebe940e369aaa54668fa50751c154cc047764">Move test classes into bisq.desktop.main.offer.bisq_v1.createoffer</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/8ee255412fe1fe5ea023654614d99f05837afed5">Merge branch &#39;bsq-swap-low-risk-refactorings&#39; into wip-merge2</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/559bc58ec23b942b0b90a2325800d40e5302af90">Fix merge issues</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/34c4eefb590c0678b3523a70e0673efdba109fea">Add allowSpendMyOwnUnconfirmedTxOutputs flag to BsqCoinSelector</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/47572888e7711f176b6018c9561d8b11447afff1">Add isMine method. Add error logs</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/0f6364d2bd4625619e6dbcce925efb0565db4639">Inline TransactionWitness</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/e582ffddad7db84481b76f6a518fc13c5796cdc2">Add new methods</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/54e81d14731ee57a8ede3e5857e6b4c73f134ce2">Add signTx and verifyNonDustTxo methods</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/5f8bc834f798e94e25a0540a154c33598eb4be76">Remove unused signTx method</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/d95356be211786d67ebd47e27e8801e33f3197e6">Add verifiedBalance field.</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/cfc404b4c0ee8d495c167446e58e88ad152d1407">Rename signTx to signTxAndVerifyNoDustOutputs (no code change)</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/82c1be1d97f57c0bd2b2380125468d80d607bbd7">Change log level</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/c15fc0c0a7a1d33db8a334881d03e9ee1185ce47">Add comment, cleanups</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/d7f1b00221ac07b914cd37302888edb357f5bc71">Rename processModel.getTradingPeer to getTradePeer</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/02d7dfdaefeeaea5aaadf5a85596abb1c500d2cb">Only print stack trace if dev mode</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/9e4be1367a399d6d24fe075409331ff028a004fc">Change log level</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/8d2579866a61508f3c1e5cd7559763006ef941e6">Replace Value annotation with Getter and EqualsAndHashCode</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/d976f11e09db208a9abceca4bb265c18e17713b6">Add methods</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/a3b3d561ecc0685e017e1f498715326de4dee570">Simplify</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/9d106468b04f53fae29b76f80e7d95575a6afb5c">Move getRandomOfferId method to OfferUtil</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/e061d6a476e78b7368ec88952bf27bf2e9a6b0f3">Replace Value with Getter</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/5b0e9ab92fbe8b62ef612e5f8cab27d17a33f2c4">Rename trade.getPhase to getTradePhase</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/544dd895fc279926e11e23565286dff2de0d9dd9">Rename trade.getState to getTradeState</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/12fff5403d9d13045726ee08410fcb2f3d3706f6">Cleanup</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/2440d7234d2d7fc83e772e0a2ff9c52128cd3f6f">Extract methods, Cleanups</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/4cb074694da118b3f62c4e21ea7b92d197e5e1bc">Extract methods, cleanups. Rename methods and vars</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/7211f892e13041979784ebaa2896f45975a2982c">Add exclude fields to EqualsAndHashCode</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/07883e9b8ba1fc5b5f4de146e28c0542c8da21b9">Rename trade.getPhase to getTradePhase</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/0148a36566c554c3c898d8fc8e14ba60d7abd723">Extract to method in TradeUtil</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/10516407de34fc3d07255ec246dac99bce07151a">Use early return. cleanup</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/8219bf84070dab6cb4ce448c94ff26da7b114bc2">Extract method. Rename vars</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/ee374c3c39720e540a79311d48a1d6daa93d8abd">Cleanups, apply rename of getTradePhase</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/e940f6f9f0a06059ec0e003dfbc4a01b775598f4">Add method. Dont return null in case of no amount but min fee</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/19aabba12c701f5aa311dd4d445484d711953ef9">Add method. cleanups</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/1c0b52cd31d27c1bf66f5cf6eb87fc75efb2aaca">Move OfferDirection from bisq.core.offer.bisq_v1 to bisq.core.offer</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/07354191a6bddb4ca5ff3bcee8a51c37ee6a43c5">Remove handling of BundleOfEnvelopes in send method.</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/b80b6ec836d778ef3a1a11e06d2a8f024931d947">Cleanups</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/23af4558b5e624d02a7457d9c217609555b1d641">Add filterPredicate</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/2e384ede59ec232e5b9e390a465eaec51f7f0fff">Make onDeleteAccount more clear</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/9d8c705104f53aefac8018e08cedc7ad35d1515e">Only add delay if not devmode</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/d2851574425c1fe587cdca81399c7b5bb325a463">Reduce visibility</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/8bb42e1421d4c6ee5e14cb91d53ac699e84e08fb">Add methods, move field up</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/1aa5e7053d70f2e25311481a0318698b478e72bf">Add method</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/8ac40a3e0cd34262d302ce5f8c59ac52411ca3c1">Add style</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/c60df6e978866162e16dcef6c6801419a0eacd3c">Add linebreak (no code change)</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/9fb6a6ca9f9666f805ee6bea4882c45df10cfaa1">Add isNotPublished method (will be combined later with bsq swap checks)</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/cfae096c1f14952cebdb56edc909b354c2585e49">Add null checks, extract variables, cleanups</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/2ae1860dac9729c71e03a4649c6f8364fad26a5a">Move tests to package bisq.desktop.main.offer.bisq_v1.createoffer</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/080dc3e8a1cfc17004b4df32811af9fe81c91c54">Merge branch &#39;chimp-bsq-swap&#39; into wip-merge021.10</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/ab6e4e1b8f3fcb7f2f4bc0547980d7fc6724fec9">Dummy commit to enforce rebuild at CI</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/5412f8b669a13a6da70e8f3e365aeb64d56fa3be">Merge branch &#39;chimp-bsq-swap&#39; into bsq-swap-low-risk-refactorings</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/c920da36c08d679de8d1ef47b171e79c5765c2aa">Add abstract classes and interfaces. Let ProcessModel and TradingPeer extend those.</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/8cd85a77c148a7d01de9b41d25832ca0af6f334e">Let Trade extend TradeModel</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/dcd0101c52142dd534fe9bd738d766e3f9b5fd56">Generify TradeResultHandler</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/5d687bd064ab3754ffcf8614b5de982114823baf">Use TradeModel and ProtocolModel in TradeTaskRunner, TradeTask, TradeProtocol and FluentProtocol</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/308bb687c552573cd371c372dea4d93c8f1aa22d">Use TradeModel</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/453229e3708c0e9742b710b87cbdfd30db1425ad">Impl. onAckMessage. Add fields for concrete types</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/c0e70b81ef641801a84ef37188e57e20bcdc1306">Use TradeModel in trade domain</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/d063aff5bfd8bfc3425cccd1b0c5fbdb44ea09e1">Let OfferPayload extend OfferPayloadBase</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/b194960c63644761eb55bc2efa036e3fe7853949">Use TradeModel instead of Trade where appropriate.</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/14765d6caa56fe1460f22c0fa0c7d0002945c860">Move protobuf OfferPayload.Direction to OfferDirection</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/611b9446094ac0389a49b2daccbb7b95784b714e">Move protobuf OfferPayload.Direction to OfferDirection</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/2f40eddae868c6294e44479738ad140222bcb413">Use bitcoinj 42bbae9 (with fix required for bsq swaps)</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/63c385bbba238b468bf675ff592e8db507af153b">Add support for RemoveDataMessage in testCapability</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/54f17b00af64c9aa706c3c39322e4c353b3f296d">Cleanups</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/ebfd1b557412b419b96adb4647547970f713ed30">Remove todo</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/9c5620276ea8ae015ad993379d3f972981edaf81">Add BSQ swap code</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/559491ebd1f22ab5cf1286458ac16978e5ee4606">Merge branch &#39;master_upstream&#39; into chimp-bsq-swap</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/cff719b3e8df4f0d67b77ca08d6b00fdef16c09a">Merge branch &#39;chimp-bsq-swap&#39; into bsq-swap-low-risk-refactorings</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/3558d0171c60a44dc21ed2814d95c85274072655">Merge branch &#39;bsq-swap-low-risk-refactorings&#39; into bsq-swap-impl</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/6d9d0f75732cdae03265574c106b2daa51ab45b5">Apply codacy review suggestions</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/fdfb029b0d038343448605c7c549d65be6a390c2">Move Utilities.objectToJson to JsonUtil.objectToJson</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/4ab1ee3d5865c7ab4d5bf84f48bfef35da080aa2">Add custom json serializer for OfferPayload</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/348bf3bda64ad936ce4f63f4adbc4bb6abae1542">Update text</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/238a7dc1f5d13d091425c5e1fdee990a68a4cc54">Remove missingFundsListener after successful take offer</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/b39396858097dbefd3296aab81675e7978a819e1">Change log level</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/a77d65b4db0f29a663bccbc951f63ea6936fc2b7">Improve BSQ swap offer details window</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/7dfb2617625f595e16e45f3d1abd0c52b329d654">Update dev mode values for create offer</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/c86801fa03aa6e1265bb62460d78084d8a0d8904">Workaround for weird JFXComboBox bug</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/395d93975bbe68f9cbf75f739941f43b22286032">Add default value if no filter is available</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/f970f09798eb13cf92b7e58b8d8022d17b30d7fc">Add log</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/904fa07eae7967be32a6eb635af7651ff5030754">Reset address entry if BSQ swap offer is used for create offer</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/0662fa783c2cfa59f475c152bca76704021dd6aa">Use checkNotNull and checkArgument for checking pre conditions</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/7c389e312dc1bcd0a2de1d1d67b4ff7ef602e5f2">Add requestPersistence call.</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/ecdda101ad19ce0e258a5e49a8cdaa8d4ed4fc1f">Improve naming, comments, extract variables</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/b9756dec2053a978886cccf276448370c2df613d">Improve naming, comments, extract variables, inline method</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/b92044b201b20e8eb5b144f97a4e6a5c78462586">Remove redundant complete call</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/89e7b64c062791146afdb3296ebcf99c4f385cf0">Improve naming, cleanups, use static imports</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/d30c943ae848731c6ca1d901a4eb80af7d567658">Fix linebreak</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/77b8ae778f231d48992623f5fd22dc9e2a8bbc1b">Combine nested if statements</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/363e0a2a7fca30731b240da4193a5f9d8a4b7190">Revert behaviour to old version in master to return null if amount is null.</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/1e7de9e8b75aead8c2d6cc6b87b69a84b3a193cb">Cleanups</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/3ed69147bb5190a7a95a44a7f62c059ff74fc0d6">Cleanups, improve logs</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/12f46ed58f00fef4ffc3b472ca3207d3a2967e98">Rename onChangeAfterBatchProcessing to onDaoStateHashesChanged</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/931e4109174598af6150b2db18878fe5e4eb00f1">Add method. Inline var</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/f144820ff66479c6b5d21cbe6521ef1fdb54de06">Fix getCycleIndex method</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/27e1da4a18fa92b5b2398fb02cc980abd552b1f6">Improve GcUtil</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/5f67b1e2e1961149e343ad25612659ff6d9e411d">Add useFullModeDaoMonitor field to PreferencesPayload</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/ed150f6e415c10f2f898f353e1ead8205fb3ff65">Remove prevHash from StateHash classes (the prevHash was only used for display.</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/18c87f2ae48ccd160c732968405d506838f0354b">Add daoStateBlockChainNotConnecting property (impl. will come in other commits)</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/0255b5cbf69a97aa2db3e7c016b2d967c59e811d">Delete DaoEventCoordinator (we will handle coordination in</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/fcea83d5238daa035cea8d07b9d0ff5ef639aaf7">Add pruneStore method</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/32d9242059ed8cc617266876322080444740a68f">Implement new behaviour for dao state monitoring and snapshotting</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/107854c336dd6e429e08765be095c2d394ab4ba9">Remove blockHashes set from daoState</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/1914e6030f14c2cfe57b2c129c1eb7b9c6f10036">Add getBlockTimeAtBlockHeight method</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/fcc34059ca198669a28d5ad13c118248153b93f5">Remove unused field</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/8469a38f49abdb5e55680a66bc0187cbc6216052">Avoid unnecessary serialisation/deserialisation cycle</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/1858436666217e0c68519fb9c8265420a1ec6c4a">Persist bsq blocks as buckets of 1000 blocks</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/a7b27dafda40ececd2fd44e5591e67257b6370d3">Add new resource file</a>
  * <a href="https://github.com/bisq-network/bisq/pull/5790/commits/4d6fde368d7f204690b823f4c007c9069223ca41">Improve log</a>

-- File Changes --

    M apitest/scripts/trade-simulation-utils.sh (2)
    M apitest/src/test/java/bisq/apitest/ApiTestCase.java (10)
    M apitest/src/test/java/bisq/apitest/method/offer/AbstractOfferTest.java (10)
    A apitest/src/test/java/bisq/apitest/method/offer/BsqSwapOfferTest.java (172)
    M apitest/src/test/java/bisq/apitest/method/offer/CancelOfferTest.java (2)
    M apitest/src/test/java/bisq/apitest/method/offer/CreateBSQOffersTest.java (4)
    M apitest/src/test/java/bisq/apitest/method/offer/CreateOfferUsingFixedPriceTest.java (4)
    M apitest/src/test/java/bisq/apitest/method/offer/CreateOfferUsingMarketPriceMarginTest.java (4)
    M apitest/src/test/java/bisq/apitest/method/offer/EditOfferTest.java (4)
    M apitest/src/test/java/bisq/apitest/method/offer/ValidateCreateOfferTest.java (2)
    A apitest/src/test/java/bisq/apitest/method/trade/BsqSwapTradeTest.java (163)
    A apitest/src/test/java/bisq/apitest/method/trade/BsqSwapTradeTestLoop.java (65)
    M apitest/src/test/java/bisq/apitest/method/trade/ExpectedProtocolStatus.java (2)
    M apitest/src/test/java/bisq/apitest/method/trade/TakeBuyBSQOfferTest.java (16)
    M apitest/src/test/java/bisq/apitest/method/trade/TakeBuyBTCOfferTest.java (10)
    M apitest/src/test/java/bisq/apitest/method/trade/TakeBuyBTCOfferWithNationalBankAcctTest.java (10)
    M apitest/src/test/java/bisq/apitest/method/trade/TakeSellBSQOfferTest.java (18)
    M apitest/src/test/java/bisq/apitest/method/trade/TakeSellBTCOfferTest.java (12)
    M apitest/src/test/java/bisq/apitest/method/wallet/BsqWalletTest.java (6)
    M apitest/src/test/java/bisq/apitest/method/wallet/WalletTestUtil.java (6)
    M apitest/src/test/java/bisq/apitest/scenario/LongRunningOfferDeactivationTest.java (4)
    M apitest/src/test/java/bisq/apitest/scenario/bot/script/BotScriptGenerator.java (5)
    M build.gradle (20)
    M cli/src/main/java/bisq/cli/DirectionFormat.java (4)
    M cli/src/main/java/bisq/cli/GrpcClient.java (71)
    M cli/src/main/java/bisq/cli/opts/AbstractMethodOptionParser.java (2)
    M cli/src/main/java/bisq/cli/opts/CreateCryptoCurrencyPaymentAcctOptionParser.java (14)
    M cli/src/main/java/bisq/cli/opts/OptLabel.java (1)
    M cli/src/main/java/bisq/cli/request/OffersServiceRequest.java (58)
    M cli/src/main/java/bisq/cli/request/TradesServiceRequest.java (8)
    M common/src/main/java/bisq/common/app/Capability.java (3)
    M common/src/main/java/bisq/common/app/Version.java (2)
    M common/src/main/java/bisq/common/config/ConfigFileEditor.java (2)
    A common/src/main/java/bisq/common/crypto/HashCashService.java (181)
    A common/src/main/java/bisq/common/crypto/ProofOfWork.java (122)
    A common/src/main/java/bisq/common/crypto/ProofOfWorkService.java (156)
    M common/src/main/java/bisq/common/persistence/PersistenceManager.java (2)
    A common/src/main/java/bisq/common/persistence/db/DataStore.java (78)
    A common/src/main/java/bisq/common/persistence/db/FixedHash.java (418)
    A common/src/main/java/bisq/common/persistence/db/HashBase.java (20)
    A common/src/main/java/bisq/common/persistence/db/NoHeapDB.java (380)
    A common/src/main/java/bisq/common/persistence/db/NoHeapDBStore.java (1051)
    M common/src/main/java/bisq/common/util/GcUtil.java (30)
    M common/src/main/java/bisq/common/util/Utilities.java (26)
    A common/src/test/java/bisq/common/crypto/HashCashServiceTest.java (84)
    A common/src/test/java/bisq/common/crypto/ProofOfWorkServiceTest.java (81)
    M core/src/main/java/bisq/core/account/witness/AccountAgeWitnessService.java (25)
    M core/src/main/java/bisq/core/account/witness/AccountAgeWitnessUtils.java (2)
    M core/src/main/java/bisq/core/api/CoreApi.java (83)
    M core/src/main/java/bisq/core/api/CoreOffersService.java (132)
    M core/src/main/java/bisq/core/api/CorePaymentAccountsService.java (25)
    M core/src/main/java/bisq/core/api/CoreTradesService.java (50)
    M core/src/main/java/bisq/core/api/CoreWalletsService.java (5)
    M core/src/main/java/bisq/core/api/model/BsqBalanceInfo.java (15)
    A core/src/main/java/bisq/core/api/model/BsqSwapOfferInfo.java (227)
    A core/src/main/java/bisq/core/api/model/BsqSwapTradeInfo.java (323)
    M core/src/main/java/bisq/core/api/model/OfferInfo.java (4)
    M core/src/main/java/bisq/core/api/model/TradeInfo.java (10)
    M core/src/main/java/bisq/core/app/BisqExecutable.java (2)
    M core/src/main/java/bisq/core/app/BisqSetup.java (10)
    M core/src/main/java/bisq/core/app/DomainInitialisation.java (18)
    M core/src/main/java/bisq/core/app/P2PNetworkSetup.java (22)
    M core/src/main/java/bisq/core/app/misc/AppSetupWithP2PAndDAO.java (7)
    M core/src/main/java/bisq/core/app/misc/ExecutableForAppWithP2p.java (2)
    M core/src/main/java/bisq/core/btc/Balances.java (6)
    M core/src/main/java/bisq/core/btc/TxFeeEstimationService.java (8)
    M core/src/main/java/bisq/core/btc/listeners/BsqBalanceListener.java (2)
    M core/src/main/java/bisq/core/btc/listeners/TxConfidenceListener.java (17)
    M core/src/main/java/bisq/core/btc/model/RawTransactionInput.java (79)
    M core/src/main/java/bisq/core/btc/nodes/BtcNodes.java (6)
    M core/src/main/java/bisq/core/btc/wallet/BsqCoinSelector.java (16)
    M core/src/main/java/bisq/core/btc/wallet/BsqTransferService.java (2)
    M core/src/main/java/bisq/core/btc/wallet/BsqWalletService.java (92)
    M core/src/main/java/bisq/core/btc/wallet/BtcWalletService.java (29)
    M core/src/main/java/bisq/core/btc/wallet/TradeWalletService.java (150)
    M core/src/main/java/bisq/core/btc/wallet/WalletService.java (57)
    D core/src/main/java/bisq/core/dao/DaoEventCoordinator.java (69)
    M core/src/main/java/bisq/core/dao/DaoFacade.java (30)
    M core/src/main/java/bisq/core/dao/DaoModule.java (1)
    M core/src/main/java/bisq/core/dao/DaoSetup.java (9)
    M core/src/main/java/bisq/core/dao/governance/asset/AssetService.java (2)
    M core/src/main/java/bisq/core/dao/governance/blindvote/MyBlindVoteListService.java (2)
    M core/src/main/java/bisq/core/dao/governance/bond/lockup/LockupTxService.java (2)
    M core/src/main/java/bisq/core/dao/governance/bond/unlock/UnlockTxService.java (2)
    M core/src/main/java/bisq/core/dao/governance/period/CycleService.java (3)
    M core/src/main/java/bisq/core/dao/governance/proofofburn/ProofOfBurnService.java (2)
    M core/src/main/java/bisq/core/dao/governance/proposal/BaseProposalFactory.java (2)
    M core/src/main/java/bisq/core/dao/governance/votereveal/VoteRevealService.java (2)
    M core/src/main/java/bisq/core/dao/monitoring/BlindVoteStateMonitoringService.java (2)
    M core/src/main/java/bisq/core/dao/monitoring/DaoStateMonitoringService.java (274)
    M core/src/main/java/bisq/core/dao/monitoring/ProposalStateMonitoringService.java (2)
    M core/src/main/java/bisq/core/dao/monitoring/model/BlindVoteStateHash.java (6)
    M core/src/main/java/bisq/core/dao/monitoring/model/DaoStateBlock.java (6)
    M core/src/main/java/bisq/core/dao/monitoring/model/DaoStateHash.java (24)
    M core/src/main/java/bisq/core/dao/monitoring/model/ProposalStateHash.java (6)
    M core/src/main/java/bisq/core/dao/monitoring/model/StateBlock.java (4)
    M core/src/main/java/bisq/core/dao/monitoring/model/StateHash.java (6)
    M core/src/main/java/bisq/core/dao/monitoring/network/StateNetworkService.java (10)
    M core/src/main/java/bisq/core/dao/node/explorer/ExportJsonFilesService.java (7)
    M core/src/main/java/bisq/core/dao/node/full/FullNode.java (5)
    M core/src/main/java/bisq/core/dao/node/lite/LiteNode.java (8)
    M core/src/main/java/bisq/core/dao/node/lite/network/LiteNodeNetworkService.java (2)
    M core/src/main/java/bisq/core/dao/node/parser/BlockParser.java (13)
    M core/src/main/java/bisq/core/dao/state/DaoStateService.java (37)
    M core/src/main/java/bisq/core/dao/state/DaoStateSnapshotService.java (183)
    M core/src/main/java/bisq/core/dao/state/model/DaoState.java (20)
    A core/src/main/java/bisq/core/dao/state/storage/BlocksPersistence.java (205)
    A core/src/main/java/bisq/core/dao/state/storage/BsqBlockStore.java (52)
    A core/src/main/java/bisq/core/dao/state/storage/BsqBlocksStorageService.java (173)
    M core/src/main/java/bisq/core/dao/state/storage/DaoStateStorageService.java (120)
    M core/src/main/java/bisq/core/dao/state/storage/DaoStateStore.java (22)
    M core/src/main/java/bisq/core/filter/Filter.java (44)
    M core/src/main/java/bisq/core/filter/FilterManager.java (28)
    M core/src/main/java/bisq/core/locale/Res.java (6)
    M core/src/main/java/bisq/core/notifications/alerts/TradeEvents.java (2)
    M core/src/main/java/bisq/core/notifications/alerts/market/MarketAlerts.java (6)
    M core/src/main/java/bisq/core/offer/Offer.java (252)
    M core/src/main/java/bisq/core/offer/OfferBookService.java (40)
    A core/src/main/java/bisq/core/offer/OfferDirection.java (33)
    R core/src/main/java/bisq/core/offer/OfferFilterService.java (17)
    M core/src/main/java/bisq/core/offer/OfferForJson.java (8)
    A core/src/main/java/bisq/core/offer/OfferPayloadBase.java (147)
    M core/src/main/java/bisq/core/offer/OfferRestrictions.java (4)
    M core/src/main/java/bisq/core/offer/OfferUtil.java (124)
    M core/src/main/java/bisq/core/offer/OpenOffer.java (43)
    M core/src/main/java/bisq/core/offer/OpenOfferManager.java (277)
    R core/src/main/java/bisq/core/offer/availability/AvailabilityResult.java (2)
    M core/src/main/java/bisq/core/offer/availability/OfferAvailabilityModel.java (2)
    M core/src/main/java/bisq/core/offer/availability/OfferAvailabilityProtocol.java (4)
    R core/src/main/java/bisq/core/offer/availability/messages/OfferAvailabilityRequest.java (6)
    R core/src/main/java/bisq/core/offer/availability/messages/OfferAvailabilityResponse.java (8)
    R core/src/main/java/bisq/core/offer/availability/messages/OfferMessage.java (2)
    M core/src/main/java/bisq/core/offer/availability/tasks/ProcessOfferAvailabilityResponse.java (4)
    M core/src/main/java/bisq/core/offer/availability/tasks/SendOfferAvailabilityRequest.java (2)
    R core/src/main/java/bisq/core/offer/bisq_v1/CreateOfferService.java (23)
    R core/src/main/java/bisq/core/offer/bisq_v1/MarketPriceNotAvailableException.java (2)
    R core/src/main/java/bisq/core/offer/bisq_v1/MutableOfferPayloadFields.java (2)
    R core/src/main/java/bisq/core/offer/bisq_v1/OfferPayload.java (244)
    R core/src/main/java/bisq/core/offer/bisq_v1/TakeOfferModel.java (4)
    R core/src/main/java/bisq/core/offer/bisq_v1/TriggerPriceService.java (29)
    A core/src/main/java/bisq/core/offer/bsq_swap/BsqSwapOfferModel.java (392)
    A core/src/main/java/bisq/core/offer/bsq_swap/BsqSwapOfferPayload.java (169)
    A core/src/main/java/bisq/core/offer/bsq_swap/BsqSwapTakeOfferModel.java (135)
    A core/src/main/java/bisq/core/offer/bsq_swap/OpenBsqSwapOffer.java (211)
    A core/src/main/java/bisq/core/offer/bsq_swap/OpenBsqSwapOfferService.java (396)
    R core/src/main/java/bisq/core/offer/placeoffer/bisq_v1/PlaceOfferModel.java (2)
    R core/src/main/java/bisq/core/offer/placeoffer/bisq_v1/PlaceOfferProtocol.java (14)
    R core/src/main/java/bisq/core/offer/placeoffer/bisq_v1/tasks/AddToOfferBook.java (4)
    R core/src/main/java/bisq/core/offer/placeoffer/bisq_v1/tasks/CheckNumberOfUnconfirmedTransactions.java (4)
    R core/src/main/java/bisq/core/offer/placeoffer/bisq_v1/tasks/CreateMakerFeeTx.java (6)
    R core/src/main/java/bisq/core/offer/placeoffer/bisq_v1/tasks/ValidateOffer.java (8)
    A core/src/main/java/bisq/core/offer/placeoffer/bsqswap/PlaceBsqSwapOfferModel.java (46)
    A core/src/main/java/bisq/core/offer/placeoffer/bsqswap/PlaceBsqSwapOfferProtocol.java (83)
    A core/src/main/java/bisq/core/offer/placeoffer/bsqswap/tasks/AddBsqSwapOfferToOfferBook.java (55)
    A core/src/main/java/bisq/core/offer/placeoffer/bsqswap/tasks/ValidateBsqSwapOffer.java (80)
    A core/src/main/java/bisq/core/payment/BsqSwapAccount.java (50)
    M core/src/main/java/bisq/core/payment/PaymentAccountFactory.java (2)
    A core/src/main/java/bisq/core/payment/payload/BsqSwapAccountPayload.java (70)
    M core/src/main/java/bisq/core/payment/payload/PaymentMethod.java (21)
    M core/src/main/java/bisq/core/proto/CoreProtoResolver.java (3)
    M core/src/main/java/bisq/core/proto/ProtoDevUtil.java (12)
    M core/src/main/java/bisq/core/proto/network/CoreNetworkProtoResolver.java (53)
    M core/src/main/java/bisq/core/proto/persistable/CorePersistenceProtoResolver.java (5)
    M core/src/main/java/bisq/core/provider/mempool/MempoolService.java (4)
    M core/src/main/java/bisq/core/setup/CoreNetworkCapabilities.java (3)
    M core/src/main/java/bisq/core/setup/CorePersistedDataHost.java (6)
    M core/src/main/java/bisq/core/support/dispute/Dispute.java (2)
    M core/src/main/java/bisq/core/support/dispute/DisputeListService.java (2)
    M core/src/main/java/bisq/core/support/dispute/DisputeManager.java (10)
    M core/src/main/java/bisq/core/support/dispute/agent/MultipleHolderNameDetection.java (2)
    M core/src/main/java/bisq/core/support/dispute/arbitration/ArbitrationManager.java (8)
    M core/src/main/java/bisq/core/support/dispute/mediation/MediationManager.java (10)
    M core/src/main/java/bisq/core/support/dispute/refund/RefundManager.java (4)
    M core/src/main/java/bisq/core/support/traderchat/TradeChatSession.java (6)
    M core/src/main/java/bisq/core/support/traderchat/TraderChatManager.java (9)
    M core/src/main/java/bisq/core/trade/TradeManager.java (333)
    M core/src/main/java/bisq/core/trade/TradeModule.java (4)
    R core/src/main/java/bisq/core/trade/bisq_v1/CleanupMailboxMessagesService.java (12)
    R core/src/main/java/bisq/core/trade/bisq_v1/ClosedTradableManager.java (17)
    R core/src/main/java/bisq/core/trade/bisq_v1/ClosedTradeUtil.java (14)
    R core/src/main/java/bisq/core/trade/bisq_v1/DumpDelayedPayoutTx.java (9)
    R core/src/main/java/bisq/core/trade/bisq_v1/FailedTradesManager.java (17)
    R core/src/main/java/bisq/core/trade/bisq_v1/TradeDataValidation.java (3)
    R core/src/main/java/bisq/core/trade/bisq_v1/TradeResultHandler.java (8)
    R core/src/main/java/bisq/core/trade/bisq_v1/TradeTxException.java (2)
    R core/src/main/java/bisq/core/trade/bisq_v1/TradeUtil.java (40)
    R core/src/main/java/bisq/core/trade/bisq_v1/TransactionResultHandler.java (2)
    A core/src/main/java/bisq/core/trade/bsq_swap/BsqSwapCalculation.java (245)
    A core/src/main/java/bisq/core/trade/bsq_swap/BsqSwapTakeOfferRequestVerification.java (106)
    A core/src/main/java/bisq/core/trade/bsq_swap/BsqSwapTradeManager.java (119)
    R core/src/main/java/bisq/core/trade/model/MakerTrade.java (2)
    R core/src/main/java/bisq/core/trade/model/TakerTrade.java (2)
    R core/src/main/java/bisq/core/trade/model/Tradable.java (2)
    R core/src/main/java/bisq/core/trade/model/TradableList.java (18)
    A core/src/main/java/bisq/core/trade/model/TradeModel.java (111)
    A core/src/main/java/bisq/core/trade/model/TradePhase.java (28)
    A core/src/main/java/bisq/core/trade/model/TradeState.java (28)
    R core/src/main/java/bisq/core/trade/model/bisq_v1/BuyerAsMakerTrade.java (6)
    R core/src/main/java/bisq/core/trade/model/bisq_v1/BuyerAsTakerTrade.java (6)
    R core/src/main/java/bisq/core/trade/model/bisq_v1/BuyerTrade.java (4)
    R core/src/main/java/bisq/core/trade/model/bisq_v1/Contract.java (7)
    R core/src/main/java/bisq/core/trade/model/bisq_v1/SellerAsMakerTrade.java (6)
    R core/src/main/java/bisq/core/trade/model/bisq_v1/SellerAsTakerTrade.java (6)
    R core/src/main/java/bisq/core/trade/model/bisq_v1/SellerTrade.java (4)
    R core/src/main/java/bisq/core/trade/model/bisq_v1/Trade.java (159)
    A core/src/main/java/bisq/core/trade/model/bsq_swap/BsqSwapBuyerAsMakerTrade.java (122)
    A core/src/main/java/bisq/core/trade/model/bsq_swap/BsqSwapBuyerAsTakerTrade.java (122)
    A core/src/main/java/bisq/core/trade/model/bsq_swap/BsqSwapBuyerTrade.java (59)
    A core/src/main/java/bisq/core/trade/model/bsq_swap/BsqSwapSellerAsMakerTrade.java (122)
    A core/src/main/java/bisq/core/trade/model/bsq_swap/BsqSwapSellerAsTakerTrade.java (123)
    A core/src/main/java/bisq/core/trade/model/bsq_swap/BsqSwapSellerTrade.java (56)
    A core/src/main/java/bisq/core/trade/model/bsq_swap/BsqSwapTrade.java (248)
    M core/src/main/java/bisq/core/trade/protocol/FluentProtocol.java (80)
    A core/src/main/java/bisq/core/trade/protocol/ProtocolModel.java (28)
    R core/src/main/java/bisq/core/trade/protocol/Provider.java (40)
    R core/src/main/java/bisq/core/trade/protocol/TradeMessage.java (2)
    A core/src/main/java/bisq/core/trade/protocol/TradePeer.java (27)
    M core/src/main/java/bisq/core/trade/protocol/TradeProtocol.java (109)
    M core/src/main/java/bisq/core/trade/protocol/TradeProtocolFactory.java (53)
    M core/src/main/java/bisq/core/trade/protocol/TradeTaskRunner.java (14)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/BuyerAsMakerProtocol.java (47)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/BuyerAsTakerProtocol.java (52)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/BuyerProtocol.java (42)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/DisputeProtocol.java (77)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/MakerProtocol.java (4)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/SellerAsMakerProtocol.java (49)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/SellerAsTakerProtocol.java (42)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/SellerProtocol.java (44)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/TakerProtocol.java (4)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/messages/CounterCurrencyTransferStartedMessage.java (2)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/messages/DelayedPayoutTxSignatureRequest.java (4)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/messages/DelayedPayoutTxSignatureResponse.java (4)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/messages/DepositTxAndDelayedPayoutTxMessage.java (2)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/messages/DepositTxMessage.java (4)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/messages/InputsForDepositTxRequest.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/messages/InputsForDepositTxResponse.java (3)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/messages/MediatedPayoutTxPublishedMessage.java (2)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/messages/MediatedPayoutTxSignatureMessage.java (2)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/messages/PayoutTxPublishedMessage.java (2)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/messages/PeerPublishedDelayedPayoutTxMessage.java (2)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/messages/RefreshTradeStateRequest.java (2)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/messages/ShareBuyerPaymentAccountMessage.java (2)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/messages/TradeMailboxMessage.java (4)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/messages/TraderSignedWitnessMessage.java (2)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/model/ProcessModel.java (35)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/model/TradingPeer.java (6)
    A core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/ApplyFilter.java (63)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/BroadcastPayoutTx.java (4)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/ProcessPeerPublishedDelayedPayoutTxMessage.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/SendMailboxMessageTask.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/SetupPayoutTxListener.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/TradeTask.java (9)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/VerifyPeersAccountAgeWitness.java (8)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/arbitration/PublishedDelayedPayoutTx.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/arbitration/SendPeerPublishedDelayedPayoutTxMessage.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer/BuyerFinalizesDelayedPayoutTx.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer/BuyerProcessDelayedPayoutTxSignatureRequest.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer/BuyerProcessDepositTxAndDelayedPayoutTxMessage.java (23)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer/BuyerProcessPayoutTxPublishedMessage.java (9)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer/BuyerSendCounterCurrencyTransferStartedMessage.java (18)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer/BuyerSendsDelayedPayoutTxSignatureResponse.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer/BuyerSendsShareBuyerPaymentAccountMessage.java (12)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer/BuyerSetupDepositTxListener.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer/BuyerSetupPayoutTxListener.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer/BuyerSignPayoutTx.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer/BuyerSignsDelayedPayoutTx.java (8)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer/BuyerVerifiesFinalDelayedPayoutTx.java (8)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer/BuyerVerifiesPreparedDelayedPayoutTx.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer_as_maker/BuyerAsMakerCreatesAndSignsDepositTx.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer_as_maker/BuyerAsMakerSendsInputsForDepositTxResponse.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer_as_taker/BuyerAsTakerCreatesDepositTxInputs.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer_as_taker/BuyerAsTakerSendsDepositTxMessage.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/buyer_as_taker/BuyerAsTakerSignsDepositTx.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/maker/MakerCreateAndSignContract.java (29)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/maker/MakerProcessesInputsForDepositTxRequest.java (12)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/maker/MakerRemovesOpenOffer.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/maker/MakerSendsInputsForDepositTxResponse.java (12)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/maker/MakerSetsLockTime.java (8)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/maker/MakerVerifyTakerFeePayment.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/mediation/BroadcastMediatedPayoutTx.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/mediation/FinalizeMediatedPayoutTx.java (12)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/mediation/ProcessMediatedPayoutSignatureMessage.java (11)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/mediation/ProcessMediatedPayoutTxPublishedMessage.java (9)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/mediation/SendMediatedPayoutSignatureMessage.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/mediation/SendMediatedPayoutTxPublishedMessage.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/mediation/SetupMediatedPayoutTxListener.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/mediation/SignMediatedPayoutTx.java (12)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller/SellerBroadcastPayoutTx.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller/SellerCreatesDelayedPayoutTx.java (8)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller/SellerFinalizesDelayedPayoutTx.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller/SellerProcessCounterCurrencyTransferStartedMessage.java (13)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller/SellerProcessDelayedPayoutTxSignatureResponse.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller/SellerProcessShareBuyerPaymentAccountMessage.java (18)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller/SellerPublishesDepositTx.java (6)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller/SellerPublishesTradeStatistics.java (8)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller/SellerSendDelayedPayoutTxSignatureRequest.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller/SellerSendPayoutTxPublishedMessage.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller/SellerSendsDepositTxAndDelayedPayoutTxMessage.java (12)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller/SellerSignAndFinalizePayoutTx.java (10)
    R core/src/main/java/bisq/core/trade/protocol/bisq_v1/tasks/seller/SellerSignsDelayedPayoutTx.java (8)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/5790.patch
https://github.com/bisq-network/bisq/pull/5790.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5790
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211031/b2a8ad32/attachment-0001.htm>

From notifications at github.com  Sun Oct 31 19:42:49 2021
From: notifications at github.com (chimp1984)
Date: Sun, 31 Oct 2021 11:42:49 -0700
Subject: [bisq-network/bisq] Extract persistence of BSQ blocks out of
 DaoStateStore [5] (PR #5790)
In-Reply-To: <bisq-network/bisq/pull/5790@github.com>
References: <bisq-network/bisq/pull/5790@github.com>
Message-ID: <bisq-network/bisq/pull/5790/push/8278226263@github.com>

@chimp1984 pushed 2 commits.

675c4cb0260b0dc50955bd868738bbfa1ff91d4d  Remove unnecessary sorting
ff674a5a61eb53d3940a2429a619331b6277d3d5  Cleanups, change log levels


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/bisq-network/bisq/pull/5790/files/4d6fde368d7f204690b823f4c007c9069223ca41..ff674a5a61eb53d3940a2429a619331b6277d3d5
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211031/11bdb800/attachment.htm>

From notifications at github.com  Sun Oct 31 20:04:55 2021
From: notifications at github.com (xmijo)
Date: Sun, 31 Oct 2021 12:04:55 -0700
Subject: [bisq-network/bisq] Unable to start Bisq on macOS (Issue #5789)
In-Reply-To: <bisq-network/bisq/issues/5789@github.com>
References: <bisq-network/bisq/issues/5789@github.com>
Message-ID: <bisq-network/bisq/issues/5789/955775117@github.com>

Took a very, very, long time to start up but I eventually got in. At least I know it isn't broken. Closing this.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5789#issuecomment-955775117
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211031/7f9c806c/attachment.htm>

From notifications at github.com  Sun Oct 31 20:04:56 2021
From: notifications at github.com (xmijo)
Date: Sun, 31 Oct 2021 12:04:56 -0700
Subject: [bisq-network/bisq] Unable to start Bisq on macOS (Issue #5789)
In-Reply-To: <bisq-network/bisq/issues/5789@github.com>
References: <bisq-network/bisq/issues/5789@github.com>
Message-ID: <bisq-network/bisq/issue/5789/issue_event/5545604021@github.com>

Closed #5789.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/5789#event-5545604021
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211031/17358947/attachment.htm>

From notifications at github.com  Sun Oct 31 20:19:21 2021
From: notifications at github.com (chimp1984)
Date: Sun, 31 Oct 2021 12:19:21 -0700
Subject: [bisq-network/bisq] Extract persistence of BSQ blocks out of
 DaoStateStore [5] (PR #5790)
In-Reply-To: <bisq-network/bisq/pull/5790@github.com>
References: <bisq-network/bisq/pull/5790@github.com>
Message-ID: <bisq-network/bisq/pull/5790/push/8278341477@github.com>

@chimp1984 pushed 1 commit.

2ce61469fce816ee1d59c1e90a0514673609e0c7  Fix link to BSQ_Swaps wiki


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/bisq-network/bisq/pull/5790/files/ff674a5a61eb53d3940a2429a619331b6277d3d5..2ce61469fce816ee1d59c1e90a0514673609e0c7
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211031/2328ec28/attachment.htm>

From notifications at github.com  Sun Oct 31 20:54:21 2021
From: notifications at github.com (chimp1984)
Date: Sun, 31 Oct 2021 12:54:21 -0700
Subject: [bisq-network/bisq] Bsq swap: Implementation [3] (PR #5775)
In-Reply-To: <bisq-network/bisq/pull/5775@github.com>
References: <bisq-network/bisq/pull/5775@github.com>
Message-ID: <bisq-network/bisq/pull/5775/push/8278450835@github.com>

@chimp1984 pushed 1 commit.

15e617e0c38505364de10991680ee47b5e408425  Fix link to BSQ_Swaps wiki


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/bisq-network/bisq/pull/5775/files/66f6ff69fca83d051e9de441ea959424b3f4d8ea..15e617e0c38505364de10991680ee47b5e408425
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211031/fd9ab808/attachment.htm>

From notifications at github.com  Sun Oct 31 21:13:28 2021
From: notifications at github.com (chimp1984)
Date: Sun, 31 Oct 2021 13:13:28 -0700
Subject: [bisq-network/bisq] Extract persistence of BSQ blocks out of
 DaoStateStore [5] (PR #5790)
In-Reply-To: <bisq-network/bisq/pull/5790@github.com>
References: <bisq-network/bisq/pull/5790@github.com>
Message-ID: <bisq-network/bisq/pull/5790/push/8278511393@github.com>

@chimp1984 pushed 1 commit.

20ae5bba5fa5d04d19288709d43f39b6c02bb4b8  Add BsqBlocks resources


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/bisq-network/bisq/pull/5790/files/2ce61469fce816ee1d59c1e90a0514673609e0c7..20ae5bba5fa5d04d19288709d43f39b6c02bb4b8
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211031/f2e24c14/attachment.htm>

From notifications at github.com  Sun Oct 31 21:24:51 2021
From: notifications at github.com (chimp1984)
Date: Sun, 31 Oct 2021 13:24:51 -0700
Subject: [bisq-network/bisq] Extract persistence of BSQ blocks out of
 DaoStateStore [5] (PR #5790)
In-Reply-To: <bisq-network/bisq/pull/5790@github.com>
References: <bisq-network/bisq/pull/5790@github.com>
Message-ID: <bisq-network/bisq/pull/5790/push/8278545742@github.com>

@chimp1984 pushed 2 commits.

3470684333987fedebd4174793fa5864dc1033ec  Update daostate resource file
e9edd120172fd45c3e0c35f59a2bafc9ada4b9a9  Add check that height of last blocks matches chainHeight in daoState


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/bisq-network/bisq/pull/5790/files/20ae5bba5fa5d04d19288709d43f39b6c02bb4b8..e9edd120172fd45c3e0c35f59a2bafc9ada4b9a9
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211031/cc89bb73/attachment-0001.htm>

From notifications at github.com  Sun Oct 31 22:07:23 2021
From: notifications at github.com (jmacxx)
Date: Sun, 31 Oct 2021 14:07:23 -0700
Subject: [bisq-network/bisq] Include holder name field for Monese & Satispay
 accounts (PR #5791)
Message-ID: <bisq-network/bisq/pull/5791@github.com>

#5745 added Monese &amp; Satispay account types, but by mistake the `holder_name` field was left out of the UI.



Ref: https://github.com/bisq-network/growth/issues/227#issuecomment-955606039
Ref: https://github.com/bisq-network/growth/issues/213#issuecomment-955606677


This PR adds the missing field to the UI.  If a Monese or Satispay accound was created previously, the `holder_name` field will be blank and the user should create a new account.  (As Monese &amp; Satispay are new and therefore not aged I do not think it necessary to implement an account upgrade procedure).



---


![image](https://user-images.githubusercontent.com/47253594/139601213-4af59fbf-a945-43c7-9e6e-37bbb527aba5.png)

&amp;nbsp;

![image](https://user-images.githubusercontent.com/47253594/139601221-af466a22-fb31-4066-a2f9-d5a15f1d9cf5.png)

&amp;nbsp;

![image](https://user-images.githubusercontent.com/47253594/139601084-b815fb4d-210f-4c2f-a7a2-394c7200f271.png)

&amp;nbsp;

![image](https://user-images.githubusercontent.com/47253594/139601146-b7ea6c56-77ba-4bc6-ad21-8ca2a28f7beb.png)


&amp;nbsp;


@pazza83 :eyes: 
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/5791

-- Commit Summary --

  * <a href="https://github.com/bisq-network/bisq/pull/5791/commits/aead47721b4bcf6643af55557d988de1754e4629">Include owner name for Monese &amp; Satispay accounts</a>

-- File Changes --

    M core/src/main/java/bisq/core/payment/MoneseAccount.java (8)
    M core/src/main/java/bisq/core/payment/SatispayAccount.java (8)
    M core/src/main/java/bisq/core/payment/payload/MoneseAccountPayload.java (12)
    M core/src/main/java/bisq/core/payment/payload/SatispayAccountPayload.java (13)
    M desktop/src/main/java/bisq/desktop/components/paymentmethods/MoneseForm.java (22)
    M desktop/src/main/java/bisq/desktop/components/paymentmethods/SatispayForm.java (25)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/5791.patch
https://github.com/bisq-network/bisq/pull/5791.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/5791
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211031/2cfd741e/attachment.htm>

From notifications at github.com  Sun Oct 31 23:19:07 2021
From: notifications at github.com (chimp1984)
Date: Sun, 31 Oct 2021 15:19:07 -0700
Subject: [bisq-network/bisq] Extract persistence of BSQ blocks out of
 DaoStateStore [5] (PR #5790)
In-Reply-To: <bisq-network/bisq/pull/5790@github.com>
References: <bisq-network/bisq/pull/5790@github.com>
Message-ID: <bisq-network/bisq/pull/5790/push/8278872828@github.com>

@chimp1984 pushed 1 commit.

f0db91e8743354dc4e3ecd02df6576138f6efea1  Update dao state resource file


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/bisq-network/bisq/pull/5790/files/e9edd120172fd45c3e0c35f59a2bafc9ada4b9a9..f0db91e8743354dc4e3ecd02df6576138f6efea1
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211031/01379a4a/attachment.htm>

From notifications at github.com  Sun Oct 31 23:19:22 2021
From: notifications at github.com (chimp1984)
Date: Sun, 31 Oct 2021 15:19:22 -0700
Subject: [bisq-network/bisq] Extract persistence of BSQ blocks out of
 DaoStateStore [5] (PR #5790)
In-Reply-To: <bisq-network/bisq/pull/5790@github.com>
References: <bisq-network/bisq/pull/5790@github.com>
Message-ID: <bisq-network/bisq/pull/5790/push/8278873463@github.com>

@chimp1984 pushed 1 commit.

d46d4656235e2512db2cd0f8c6a6999e8e609c5e  Update dao state resource file


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/bisq-network/bisq/pull/5790/files/f0db91e8743354dc4e3ecd02df6576138f6efea1..d46d4656235e2512db2cd0f8c6a6999e8e609c5e
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211031/20440da1/attachment.htm>

From notifications at github.com  Sun Oct 31 23:23:01 2021
From: notifications at github.com (chimp1984)
Date: Sun, 31 Oct 2021 15:23:01 -0700
Subject: [bisq-network/bisq] Extract persistence of BSQ blocks out of
 DaoStateStore [5] (PR #5790)
In-Reply-To: <bisq-network/bisq/pull/5790@github.com>
References: <bisq-network/bisq/pull/5790@github.com>
Message-ID: <bisq-network/bisq/pull/5790/push/8278884017@github.com>

@chimp1984 pushed 1 commit.

70cbf553ece8e4196771b1035382fedebc088c8c  Add check that height of last block matches chainHeight from daoState


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/bisq-network/bisq/pull/5790/files/d46d4656235e2512db2cd0f8c6a6999e8e609c5e..70cbf553ece8e4196771b1035382fedebc088c8c
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20211031/aeefdff4/attachment.htm>