<p>Nice <a class="user-mention" data-hovercard-user-id="735155" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/m52go">@m52go</a>, this reworked PR looks great. Thanks for taking the time. Just a couple things from a Git perspective. I rebased this branch against <code>master</code> such that it now contains only the commits that you and I have have worked on that are specific to this doc, and I force pushed those changes up to this PR branch. See the four commits in the timeline above, and compare with the commits that were in the timeline previously:</p>
<h3>before</h3>
<p><a target="_blank" href="https://user-images.githubusercontent.com/301810/39597467-cd23bb82-4f15-11e8-8a2d-3f7fac9f7c5b.png"><img src="https://user-images.githubusercontent.com/301810/39597467-cd23bb82-4f15-11e8-8a2d-3f7fac9f7c5b.png" alt="image" style="max-width:100%;"></a></p>
<h3>after</h3>
<p><a target="_blank" href="https://user-images.githubusercontent.com/301810/39597719-98b12a82-4f16-11e8-8996-7df4305ab858.png"><img src="https://user-images.githubusercontent.com/301810/39597719-98b12a82-4f16-11e8-8996-7df4305ab858.png" alt="image" style="max-width:100%;"></a></p>
<p>Again, these extra commits were just an artifact of creating the PR branch from <code>master</code> in the first place. No big deal, it's all clean now.</p>
<p>The other thing is your Git author metadata, which I see is cleaned up now for most commits, but is still off on the original commit <a class="commit-link" href="https://github.com/bisq-network/bisq-docs/commit/c9e77effa3cc1af8cff3f3ef8db0e75d82391037"><tt>c9e77ef</tt></a>. It's not a must that you fix this, but if you'd like to, here's what you can do:</p>
<ol>
<li><code>git rebase -i c9e77ef^</code></li>
<li>in the editor, change <code>pick</code> to <code>edit</code> for <a class="commit-link" href="https://github.com/bisq-network/bisq-docs/commit/c9e77effa3cc1af8cff3f3ef8db0e75d82391037"><tt>c9e77ef</tt></a></li>
<li>exit the editor</li>
<li>run <code>git show</code>; notice that commit <a class="commit-link" href="https://github.com/bisq-network/bisq-docs/commit/c9e77effa3cc1af8cff3f3ef8db0e75d82391037"><tt>c9e77ef</tt></a> still has your old author metadata</li>
<li>run <code>git commit --amend --reset-author -C c9e77ef</code></li>
<li>run <code>git show</code> again; notice that your author metadata is fixed</li>
<li>run <code>git rebase --continue</code></li>
<li>run <code>git push --force</code> to force push the changes back up to the PR branch</li>
</ol>
<p>I mention the above again not because you 'must' do it, but because you seem to have taken well to the ideas of rebasing and squashing so far, and you may find these additional exercises enlightening / empowering for future work.</p>
<p>The reason it's practical to clean this up, by the way is because having consistent author metadata makes tools like <code>git shortlog</code> work as expected:</p>
<p>I'm running this against the current HEAD of this PR branch (<a class="commit-link" href="https://github.com/bisq-network/bisq-docs/commit/96f7019e49fc10df68015868fe903e452ac8703f"><tt>96f7019</tt></a>):</p>
<pre><code>$ git shortlog -nse
160 Chris Beams <chris@beams.io>
50 Manfred Karrer <mk@nucleo.io>
1 Christoph Atteneder <christoph.atteneder@gmail.com>
1 Francois Carpentier <Francewhoa@users.noreply.github.com>
1 Steve Jain <mfiver@gmail.com>
1 author <sburnitt@gmail.com>
1 csacher <cris.sacher@gmail.com>
1 Bender <31224386+SylarBend@users.noreply.github.com>
1 m52go <mfiver@gmail.com>
1 Bernard Labno <bernard.labno@pjwstk.edu.pl>
</code></pre>
<p>Notice how you have two entries, (one for "Steve Jain" and one for "m52go"). This will become one single entry if you follow the steps above.</p>
<p>I'll follow up further with review comments on the substance of the outline as soon as possible. And of course anyone else is welcome to as well. Excited about this!</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq-docs/pull/45#issuecomment-386406820">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtv3rIvTxZAUoxdV8VnRyUlYzCfAzks5tu1fkgaJpZM4TxXG2">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZttxSqZQrCmJKZD5gaEoZnX2OKrIMks5tu1fkgaJpZM4TxXG2.gif" height="1" width="1" alt="" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/bisq-network/bisq-docs/pull/45#issuecomment-386406820"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq-docs","title":"bisq-network/bisq-docs","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq-docs"}},"updates":{"snippets":[{"icon":"PERSON","message":"@cbeams in #45: Nice @m52go, this reworked PR looks great. Thanks for taking the time. Just a couple things from a Git perspective. I rebased this branch against `master` such that it now contains only the commits that you and I have have worked on that are specific to this doc, and I force pushed those changes up to this PR branch. See the four commits in the timeline above, and compare with the commits that were in the timeline previously:\r\n\r\n### before\r\n\r\n\r\n### after\r\n\r\n\r\nAgain, these extra commits were just an artifact of creating the PR branch from `master` in the first place. No big deal, it's all clean now.\r\n\r\nThe other thing is your Git author metadata, which I see is cleaned up now for most commits, but is still off on the original commit c9e77ef. It's not a must that you fix this, but if you'd like to, here's what you can do:\r\n\r\n 1. `git rebase -i c9e77ef^`\r\n 1. in the editor, change `pick` to `edit` for c9e77ef\r\n 1. exit the editor\r\n 1. run `git show`; notice that commit c9e77ef still has your old author metadata\r\n 1. run `git commit --amend --reset-author -C c9e77ef`\r\n 1. run `git show` again; notice that your author metadata is fixed\r\n 1. run `git rebase --continue`\r\n 1. run `git push --force` to force push the changes back up to the PR branch\r\n\r\nI mention the above again not because you 'must' do it, but because you seem to have taken well to the ideas of rebasing and squashing so far, and you may find these additional exercises enlightening / empowering for future work.\r\n\r\nThe reason it's practical to clean this up, by the way is because having consistent author metadata makes tools like `git shortlog` work as expected:\r\n\r\nI'm running this against the current HEAD of this PR branch (96f7019):\r\n\r\n```\r\n$ git shortlog -nse\r\n 160 Chris Beams \u003cchris@beams.io\u003e\r\n 50 Manfred Karrer \u003cmk@nucleo.io\u003e\r\n 1 Christoph Atteneder \u003cchristoph.atteneder@gmail.com\u003e\r\n 1 Francois Carpentier \u003cFrancewhoa@users.noreply.github.com\u003e\r\n 1 Steve Jain \u003cmfiver@gmail.com\u003e\r\n 1 author \u003csburnitt@gmail.com\u003e\r\n 1 csacher \u003ccris.sacher@gmail.com\u003e\r\n 1 Bender \u003c31224386+SylarBend@users.noreply.github.com\u003e\r\n 1 m52go \u003cmfiver@gmail.com\u003e\r\n 1 Bernard Labno \u003cbernard.labno@pjwstk.edu.pl\u003e\r\n```\r\n\r\nNotice how you have two entries, (one for \"Steve Jain\" and one for \"m52go\"). This will become one single entry if you follow the steps above.\r\n\r\nI'll follow up further with review comments on the substance of the outline as soon as possible. And of course anyone else is welcome to as well. Excited about this!"}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq-docs/pull/45#issuecomment-386406820"}}}</script>