<p><a class="user-mention" data-hovercard-user-id="431064" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/blabno">@blabno</a>, note that I updated the description of the PR as well. In general, even if you and I have just discussed something in Slack (as we had in this situation), even a one-line description in the PR is good practice. It provides context for the uninitiated, especially those who might come along and do reviews. As time goes by we want to get more and more in the culture / mode where anybody who wants to can do a review. This means that PRs should be as self-contained as they can be, without requiring context from Slack or wherever else.</p>
<p>No big deal—just want to start emphasizing this. Really, just a one liner is fine, whatever you think would help an uninitiated person understand why this PR is being submitted, why now, etc.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq-assets/pull/11#issuecomment-389136559">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtjnK-yTH-PaC722sw6mzu74mH0ROks5tyr7FgaJpZM4T_R7d">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtlGqU6Ll8sgLMKsdRw9YhZBFZHjXks5tyr7FgaJpZM4T_R7d.gif" height="1" width="1" alt="" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/bisq-network/bisq-assets/pull/11#issuecomment-389136559"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq-assets","title":"bisq-network/bisq-assets","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq-assets"}},"updates":{"snippets":[{"icon":"PERSON","message":"@cbeams in #11: @blabno, note that I updated the description of the PR as well. In general, even if you and I have just discussed something in Slack (as we had in this situation), even a one-line description in the PR is good practice. It provides context for the uninitiated, especially those who might come along and do reviews. As time goes by we want to get more and more in the culture / mode where anybody who wants to can do a review. This means that PRs should be as self-contained as they can be, without requiring context from Slack or wherever else.\r\n\r\nNo big deal—just want to start emphasizing this. Really, just a one liner is fine, whatever you think would help an uninitiated person understand why this PR is being submitted, why now, etc."}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq-assets/pull/11#issuecomment-389136559"}}}</script>
<script type="application/ld+json">{"@type":"MessageCard","@context":"http://schema.org/extensions","hideOriginalBody":"false","originator":"37567f93-e2a7-4e2a-ad37-a9160fc62647","title":"Re: [bisq-network/bisq-assets] Check bisq.asset.Asset file sorting during CI (#11)","sections":[{"text":"","activityTitle":"**Chris Beams**","activityImage":"https://avatars0.githubusercontent.com/u/301810?s=160\u0026v=4","activitySubtitle":"@cbeams","facts":[]}],"potentialAction":[{"name":"Add a comment","@type":"ActionCard","inputs":[{"isMultiLine":true,"@type":"TextInput","id":"IssueComment","isRequired":false}],"actions":[{"name":"Comment","@type":"HttpPOST","target":"https://api.github.com","body":"{\"commandName\":\"IssueComment\",\"repositoryFullName\":\"bisq-network/bisq-assets\",\"issueId\":11,\"IssueComment\":\"{{IssueComment.value}}\"}"}]},{"name":"Close pull request","@type":"HttpPOST","target":"https://api.github.com","body":"{\"commandName\":\"PullRequestClose\",\"repositoryFullName\":\"bisq-network/bisq-assets\",\"pullRequestId\":11}"},{"targets":[{"os":"default","uri":"https://github.com/bisq-network/bisq-assets/pull/11#issuecomment-389136559"}],"@type":"OpenUri","name":"View on GitHub"},{"name":"Unsubscribe","@type":"HttpPOST","target":"https://api.github.com","body":"{\"commandName\":\"MuteNotification\",\"threadId\":335355613}"}],"themeColor":"26292E"}</script>