<p><a class="user-mention" data-hovercard-user-id="735155" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/m52go">@m52go</a> wrote:</p>
<blockquote>
<p>from my end this is now a release candidate</p>
</blockquote>
<p>Agreed, I've removed the <code>[WIP]</code> from the title. As mentioned before, reviews welcome, and I'm reviewing now myself. Will push additional commits as appropriate, and will write up comments for anything else.</p>
<blockquote>
<p>pending items:</p>
<p>If a user is funding their trade wallet from an external source (i.e. not a Bisq wallet), should we suggest a minimum miner fee? I thought I remember seeing 20 sat/b recommended somewhere in Bisq, but I can't find it anymore.</p>
</blockquote>
<p>Good question. I think we can leave it out. Most wallets these days should have built in mining fee adjustments. I'd say let's add something like this in if people start complaining about it. Otherwise, it's just one more digression, and I think without much need.</p>
<blockquote>
<p>I think it would be nice to link to some places to help people find ATMs, provide more details on vouchers, find meetups, etc. If you have go-to sources you trust for any of those, let me know.</p>
</blockquote>
<p>ATMs: <a href="https://bitcoinatmmap.com/" rel="nofollow">https://bitcoinatmmap.com/</a>, <a href="https://coinatmradar.com/" rel="nofollow">https://coinatmradar.com/</a> (I have no experience with these, I just found them listed at <a href="https://lopp.net/bitcoin.html" rel="nofollow">https://lopp.net/bitcoin.html</a>).</p>
<p>Vouchers: The only thing I know of is <a href="https://azte.co" rel="nofollow">https://azte.co</a>, and per <a href="https://azte.co/vendors.html" rel="nofollow">https://azte.co/vendors.html</a>, they're still building out their network.</p>
<p>Meetups: <a href="https://www.meetup.com/topics/bitcoin/" rel="nofollow">https://www.meetup.com/topics/bitcoin/</a></p>
<blockquote>
<p>For a buyer, what happens if they don't move their new bitcoin to a wallet after a deal is marked complete? Or forget, etc? Is this something we should warn users about?</p>
</blockquote>
<p>Nothing happens to it. I mean, they should at least transfer it to their Bisq wallet, but it's fine to stay there. The Bisq wallet is a secure, modern wallet like any other, so it's safe there, so long as they have their wallet password in place and seed words secured.</p>
<p>So I don't think we need to warn the user about anything. Just instruct them to move the bitcoin to their Bisq wallet or to an external wallet, and voilá, the trade is complete.</p>
<p>Note: we shouldn't use the word "deal" where the word "trade" would suffice. Once concept instead of two.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq-docs/pull/45#issuecomment-389506748">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtvBT5f-KZuPxZgoo3XXJyWLEgHLTks5tzCCIgaJpZM4TxXG2">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtiBVvGOwQUnUQ0bV9UBI2PZLmA2Yks5tzCCIgaJpZM4TxXG2.gif" height="1" width="1" alt="" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/bisq-network/bisq-docs/pull/45#issuecomment-389506748"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq-docs","title":"bisq-network/bisq-docs","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq-docs"}},"updates":{"snippets":[{"icon":"PERSON","message":"@cbeams in #45: @m52go wrote:\r\n\r\n\u003e from my end this is now a release candidate\r\n\r\nAgreed, I've removed the `[WIP]` from the title. As mentioned before, reviews welcome, and I'm reviewing now myself. Will push additional commits as appropriate, and will write up comments for anything else.\r\n\r\n\u003e pending items:\r\n\u003e \r\n\u003e If a user is funding their trade wallet from an external source (i.e. not a Bisq wallet), should we suggest a minimum miner fee? I thought I remember seeing 20 sat/b recommended somewhere in Bisq, but I can't find it anymore.\r\n\r\nGood question. I think we can leave it out. Most wallets these days should have built in mining fee adjustments. I'd say let's add something like this in if people start complaining about it. Otherwise, it's just one more digression, and I think without much need.\r\n\r\n\r\n\u003e I think it would be nice to link to some places to help people find ATMs, provide more details on vouchers, find meetups, etc. If you have go-to sources you trust for any of those, let me know.\r\n\r\nATMs: https://bitcoinatmmap.com/, https://coinatmradar.com/ (I have no experience with these, I just found them listed at https://lopp.net/bitcoin.html).\r\n\r\nVouchers: The only thing I know of is https://azte.co, and per https://azte.co/vendors.html, they're still building out their network.\r\n\r\nMeetups: https://www.meetup.com/topics/bitcoin/\r\n\r\n\u003e For a buyer, what happens if they don't move their new bitcoin to a wallet after a deal is marked complete? Or forget, etc? Is this something we should warn users about?\r\n\r\nNothing happens to it. I mean, they should at least transfer it to their Bisq wallet, but it's fine to stay there. The Bisq wallet is a secure, modern wallet like any other, so it's safe there, so long as they have their wallet password in place and seed words secured.\r\n\r\nSo I don't think we need to warn the user about anything. Just instruct them to move the bitcoin to their Bisq wallet or to an external wallet, and voilá, the trade is complete.\r\n\r\nNote: we shouldn't use the word \"deal\" where the word \"trade\" would suffice. Once concept instead of two."}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq-docs/pull/45#issuecomment-389506748"}}}</script>
<script type="application/ld+json">{"@type":"MessageCard","@context":"http://schema.org/extensions","hideOriginalBody":"false","originator":"37567f93-e2a7-4e2a-ad37-a9160fc62647","title":"Re: [bisq-network/bisq-docs] Produce a 'getting started' guide (#45)","sections":[{"text":"","activityTitle":"**Chris Beams**","activityImage":"https://avatars0.githubusercontent.com/u/301810?s=160\u0026v=4","activitySubtitle":"@cbeams","facts":[]}],"potentialAction":[{"name":"Add a comment","@type":"ActionCard","inputs":[{"isMultiLine":true,"@type":"TextInput","id":"IssueComment","isRequired":false}],"actions":[{"name":"Comment","@type":"HttpPOST","target":"https://api.github.com","body":"{\"commandName\":\"IssueComment\",\"repositoryFullName\":\"bisq-network/bisq-docs\",\"issueId\":45,\"IssueComment\":\"{{IssueComment.value}}\"}"}]},{"name":"Close pull request","@type":"HttpPOST","target":"https://api.github.com","body":"{\"commandName\":\"PullRequestClose\",\"repositoryFullName\":\"bisq-network/bisq-docs\",\"pullRequestId\":45}"},{"targets":[{"os":"default","uri":"https://github.com/bisq-network/bisq-docs/pull/45#issuecomment-389506748"}],"@type":"OpenUri","name":"View on GitHub"},{"name":"Unsubscribe","@type":"HttpPOST","target":"https://api.github.com","body":"{\"commandName\":\"MuteNotification\",\"threadId\":331706806}"}],"themeColor":"26292E"}</script>