<p><a class="user-mention" data-hovercard-user-id="36703333" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/alfsbs">@alfsbs</a> Thanks. So we would need a check of the buyer to only use a currency which is supported in his country. If a Cambodian buyer is maker he can only use USD or KHR when creating an offer. If a Cambodian buyer is taker he can only take offers which are support USD or KHR. The offer maker as seller has by default all currencies selected but can manually deselect some.<br>
We only have that currency selection atm in the account setup but not at the create offer level. But at account setup you don't know if it will be the buyer or seller.<br>
I fear that implementing that all correctly is quite a lot of effort and the expected gain from it is probably not worth that.<br>
So I am wondering what would be a "cheap" alternative which works good enough for most cases?<br>
Probably to just do it like in OK_PAY and support a set of currencies and leave the special handling either to the users intelligence (e.g. if there is a EUR offer a Cambodian buyer cannot take that even the app allows it but the trader knows that he cannot receive EUR) and/or take into account some dispute cases from such problems.<br>
That would also show us hoe much it is used and if it is worth to implement a proper solution in future releases.<br>
What do you think?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq-core/pull/103#issuecomment-390946500">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZthEnO38e7R8yfe7p1pwC7O0PZf94ks5t0-xWgaJpZM4TqY-y">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtvoZYszK6aOLg_Xs3o07GWRyPlHJks5t0-xWgaJpZM4TqY-y.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","potentialAction":{"@type":"ViewAction","target":"https://github.com/bisq-network/bisq-core/pull/103#issuecomment-390946500","url":"https://github.com/bisq-network/bisq-core/pull/103#issuecomment-390946500","name":"View Pull Request"},"description":"View this Pull Request on GitHub","publisher":{"@type":"Organization","name":"GitHub","url":"https://github.com"}}</script>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq-core","title":"bisq-network/bisq-core","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq-core"}},"updates":{"snippets":[{"icon":"PERSON","message":"@ManfredKarrer in #103: @alfsbs Thanks. So we would need a check of the buyer to only use a currency which is supported in his country. If a Cambodian buyer is maker he can only use USD or KHR when creating an offer. If a Cambodian buyer is taker he can only take offers which are support USD or KHR. The offer maker as seller has by default all currencies selected but can manually deselect some.\r\nWe only have that currency selection atm in the account setup but not at the create offer level. But at account setup you don't know if it will be the buyer or seller. \r\nI fear that implementing that all correctly is quite a lot of effort and the expected gain from it is probably not worth that.\r\nSo I am wondering what would be a \"cheap\" alternative which works good enough for most cases?\r\nProbably to just do it like in OK_PAY and support a set of currencies and leave the special handling either to the users intelligence (e.g. if there is a EUR offer a Cambodian buyer cannot take that even the app allows it but the trader knows that he cannot receive EUR) and/or take into account some dispute cases from such problems. \r\nThat would also show us hoe much it is used and if it is worth to implement a proper solution in future releases.\r\nWhat do you think?"}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq-core/pull/103#issuecomment-390946500"}}}</script>
<script type="application/ld+json">{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "37567f93-e2a7-4e2a-ad37-a9160fc62647",
"title": "Re: [bisq-network/bisq-core] Add payment method: moneygram (#103)",
"sections": [
{
"text": "",
"activityTitle": "**Manfred Karrer**",
"activityImage": "https://avatars2.githubusercontent.com/u/1449498?s=160\u0026v=4",
"activitySubtitle": "@ManfredKarrer",
"facts": [

]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"bisq-network/bisq-core\",\n\"issueId\": 103,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"bisq-network/bisq-core\",\n\"pullRequestId\": 103\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq-core/pull/103#issuecomment-390946500"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 329879474\n}"
}
],
"themeColor": "26292E"
}</script>