<p><b>@blabno</b> requested changes on this pull request.</p>

<p>NACK per comment.</p><hr>

<p>In <a href="https://github.com/bisq-network/bisq-assets/pull/19#discussion_r191478400">src/main/java/bisq/asset/StellarTokenAddressValidator.java</a>:</p>
<pre style='color:#555'>> + * Validates whether a stellar address has the necessary trustline
+ * established to receive the token. The validator uses the stellar
+ * horizon network to do the lookup.
+ *
+ * @author Peter Molnar/litlp007
+ * @since 0.7.0
+ */
+public class StellarTokenAddressValidator implements AddressValidator {
+
+   private String code;
+   private String issuer;
+
+   public static String getText(String url) throws Exception {
+        URL website = new URL(url);
+        URLConnection connection = website.openConnection();
+        BufferedReader in = new BufferedReader(
</pre>
<p>I don't think we want to make any external queries to validate anything.<br>
Validation must work offline.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq-assets/pull/19#pullrequestreview-124057796">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtkEWT3djaAH1WVnsp2g01oM3WFOBks5t3W71gaJpZM4URwmz">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtnjzLFqcFvUmOqSeJTbWnjhYQKt3ks5t3W71gaJpZM4URwmz.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","potentialAction":{"@type":"ViewAction","target":"https://github.com/bisq-network/bisq-assets/pull/19#pullrequestreview-124057796","url":"https://github.com/bisq-network/bisq-assets/pull/19#pullrequestreview-124057796","name":"View Pull Request"},"description":"View this Pull Request on GitHub","publisher":{"@type":"Organization","name":"GitHub","url":"https://github.com"}}</script>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq-assets","title":"bisq-network/bisq-assets","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq-assets"}},"updates":{"snippets":[{"icon":"PERSON","message":"@blabno requested changes on #19"}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq-assets/pull/19#pullrequestreview-124057796"}}}</script>
<script type="application/ld+json">{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "37567f93-e2a7-4e2a-ad37-a9160fc62647",
"title": "@blabno requested changes on 19",
"sections": [
{
"text": "NACK per comment.",
"activityTitle": "**Bernard Labno**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@blabno",
"facts": [

]
}
],
"potentialAction": [
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq-assets/pull/19#pullrequestreview-124057796"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 340199859\n}"
}
],
"themeColor": "26292E"
}</script>