<p>I started to add 2 projects to Bisq [1,2] and added basic setup for a BisqDaemon [3] and a new DesktopMain [4] class which supports 2 new option keys: desktopWithHttpApi and desktopWithGrpcApi.</p>
<p>I think it is cleaner to use a separate main class [5] for the HTTP-API-only (headless) case, so current plan is to not support the API-only version in the same main class which supports the combination Desktop + API.<br>
<a class="user-mention" data-hovercard-user-id="431064" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/blabno">@blabno</a>: If there are strong reasons why such would be required, please let me know, though it might not be that trivial as the JFXApplication is referenced in the Main class which would not work with the headless approach. I don't like to add hacks via reflection to circumvent that....</p>
<p>It is all WIP, but wanted to share early the direction....</p>
<p>[1] <a href="https://github.com/ManfredKarrer/bisq-grpc/tree/api-integration">https://github.com/ManfredKarrer/bisq-grpc/tree/api-integration</a><br>
[2] <a href="https://github.com/ManfredKarrer/bisq-http-api/tree/api-integration">https://github.com/ManfredKarrer/bisq-http-api/tree/api-integration</a><br>
[3] <a href="https://github.com/ManfredKarrer/bisq-core/tree/api-integration">https://github.com/ManfredKarrer/bisq-core/tree/api-integration</a><br>
[4] <a href="https://github.com/ManfredKarrer/bisq-desktop/tree/api-integration">https://github.com/ManfredKarrer/bisq-desktop/tree/api-integration</a><br>
[5] <a href="https://github.com/ManfredKarrer/bisq-http-api/blob/api-integration/src/main/java/bisq/httpapi/BisqHttpApiMain.java">https://github.com/ManfredKarrer/bisq-http-api/blob/api-integration/src/main/java/bisq/httpapi/BisqHttpApiMain.java</a></p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/proposals/issues/22#issuecomment-393354639">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtv4bcIFZpdYz5lV0u9IMF9JQS05dks5t3y9VgaJpZM4UTnht">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtsDFyPSVlWniq6ObOCsoB-mOyExzks5t3y9VgaJpZM4UTnht.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","potentialAction":{"@type":"ViewAction","target":"https://github.com/bisq-network/proposals/issues/22#issuecomment-393354639","url":"https://github.com/bisq-network/proposals/issues/22#issuecomment-393354639","name":"View Issue"},"description":"View this Issue on GitHub","publisher":{"@type":"Organization","name":"GitHub","url":"https://github.com"}}</script>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/proposals","title":"bisq-network/proposals","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/proposals"}},"updates":{"snippets":[{"icon":"PERSON","message":"@ManfredKarrer in #22: I started to add 2 projects to Bisq [1,2] and added basic setup for a BisqDaemon [3] and a new DesktopMain [4] class which supports 2 new option keys: desktopWithHttpApi and desktopWithGrpcApi.\r\n\r\nI think it is cleaner to use a separate main class [5] for the HTTP-API-only (headless) case, so current plan is to not support the API-only version in the same main class which supports the combination Desktop + API. \r\n@blabno: If there are strong reasons why such would be required, please let me know, though it might not be that trivial as the JFXApplication is referenced in the Main class which would not work with the headless approach. I don't like to add hacks via reflection to circumvent that.... \r\n\r\nIt is all WIP, but wanted to share early the direction....\r\n\r\n[1] https://github.com/ManfredKarrer/bisq-grpc/tree/api-integration\r\n[2] https://github.com/ManfredKarrer/bisq-http-api/tree/api-integration\r\n[3] https://github.com/ManfredKarrer/bisq-core/tree/api-integration\r\n[4] https://github.com/ManfredKarrer/bisq-desktop/tree/api-integration\r\n[5] https://github.com/ManfredKarrer/bisq-http-api/blob/api-integration/src/main/java/bisq/httpapi/BisqHttpApiMain.java"}],"action":{"name":"View Issue","url":"https://github.com/bisq-network/proposals/issues/22#issuecomment-393354639"}}}</script>
<script type="application/ld+json">{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "37567f93-e2a7-4e2a-ad37-a9160fc62647",
"title": "Re: [bisq-network/proposals] Integrate HTTP API to bisq-network (#22)",
"sections": [
{
"text": "",
"activityTitle": "**Manfred Karrer**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@ManfredKarrer",
"facts": [

]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"bisq-network/proposals\",\n\"issueId\": 22,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close issue",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueClose\",\n\"repositoryFullName\": \"bisq-network/proposals\",\n\"issueId\": 22\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/proposals/issues/22#issuecomment-393354639"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 340686957\n}"
}
],
"themeColor": "26292E"
}</script>