<p>One other thing to consider are integration tests.<br>
Right now they require special docker image with bisq-api in it running in headless mode.<br>
Because we duplicate startup code (and api module depends on desktop) then it has all it needs to start.</p>
<p>Once we remove main class from api those tests might get problematic.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/proposals/issues/22#issuecomment-393230304">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtqA1xcQpW7oSQhCMhP3zRGpUGl6Vks5t3stRgaJpZM4UTnht">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtjiq-akTsLPZepr3gq3dKNVJDUqgks5t3stRgaJpZM4UTnht.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","potentialAction":{"@type":"ViewAction","target":"https://github.com/bisq-network/proposals/issues/22#issuecomment-393230304","url":"https://github.com/bisq-network/proposals/issues/22#issuecomment-393230304","name":"View Issue"},"description":"View this Issue on GitHub","publisher":{"@type":"Organization","name":"GitHub","url":"https://github.com"}}</script>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/proposals","title":"bisq-network/proposals","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/proposals"}},"updates":{"snippets":[{"icon":"PERSON","message":"@blabno in #22: One other thing to consider are integration tests.\r\nRight now they require special docker image with bisq-api in it running in headless mode.\r\nBecause we duplicate startup code (and api module depends on desktop) then it has all it needs to start.\r\n\r\nOnce we remove main class from api those tests might get problematic. "}],"action":{"name":"View Issue","url":"https://github.com/bisq-network/proposals/issues/22#issuecomment-393230304"}}}</script>
<script type="application/ld+json">{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "37567f93-e2a7-4e2a-ad37-a9160fc62647",
"title": "Re: [bisq-network/proposals] Integrate HTTP API to bisq-network (#22)",
"sections": [
{
"text": "",
"activityTitle": "**Bernard Labno**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@blabno",
"facts": [

]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"bisq-network/proposals\",\n\"issueId\": 22,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close issue",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueClose\",\n\"repositoryFullName\": \"bisq-network/proposals\",\n\"issueId\": 22\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/proposals/issues/22#issuecomment-393230304"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 340686957\n}"
}
],
"themeColor": "26292E"
}</script>