<p>We had recently a case where one price node was failing due an unknown error [1] and clients still got delivered data from that node but the data was outdated (1000 USD price difference to other nodes). We have a timestamp for the delivery to the Bisq node to ignore outdated prices, but the age of the source data is not checked.<br>
So we should add some check at the requests to the price providers (BTC Average,...) to detect if we don't get fresh data and if the requested data are not recent the time stamp for the requests from Bisq nodes should not be updated to reflect the real age if the price data.<br>
I am not 100% sure how it is/was implemented but as the nodes did not detect the outdated prices I assume that the timestamp is not set at the price providers side.</p>
<p>[1] That was logged int eh error.log file:<br>
Exception in thread “Timer-5” java.lang.StackOverflowError<br>
at java.lang.reflect.InvocationTargetException.(InvocationTargetException.java:72)<br>
at sun.reflect.GeneratedMethodAccessor73.invoke(Unknown Source)<br>
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)<br>
at java.lang.reflect.Method.invoke(Method.java:498)<br>
at ch.qos.logback.classic.spi.ThrowableProxy.(ThrowableProxy.java:66)<br>
at ch.qos.logback.classic.spi.ThrowableProxy.(ThrowableProxy.java:60)<br>
at ch.qos.logback.classic.spi.ThrowableProxy.(ThrowableProxy.java:72)</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq-pricenode/issues/13">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtqgUXsrBRKGZ-5ipeWefaeNvDb2tks5t82yFgaJpZM4UpLU9">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtsNh8vDcY6XWB5iNPIro65FJtTJiks5t82yFgaJpZM4UpLU9.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","potentialAction":{"@type":"ViewAction","target":"https://github.com/bisq-network/bisq-pricenode/issues/13","url":"https://github.com/bisq-network/bisq-pricenode/issues/13","name":"View Issue"},"description":"View this Issue on GitHub","publisher":{"@type":"Organization","name":"GitHub","url":"https://github.com"}}</script>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq-pricenode","title":"bisq-network/bisq-pricenode","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq-pricenode"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Don't deliver price data if request from source fails  (#13)"}],"action":{"name":"View Issue","url":"https://github.com/bisq-network/bisq-pricenode/issues/13"}}}</script>
<script type="application/ld+json">{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Don't deliver price data if request from source fails  (#13)",
"sections": [
{
"text": "",
"activityTitle": "**Manfred Karrer**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@ManfredKarrer",
"facts": [
{
"name": "Repository: ",
"value": "bisq-network/bisq-pricenode"
},
{
"name": "Issue #: ",
"value": 13
}
]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"bisq-network/bisq-pricenode\",\n\"issueId\": 13,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close issue",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueClose\",\n\"repositoryFullName\": \"bisq-network/bisq-pricenode\",\n\"issueId\": 13\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq-pricenode/issues/13"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 346338621\n}"
}
],
"themeColor": "26292E"
}</script>