<p>Depends on <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="334808881" data-permission-text="Issue title is private" data-url="https://github.com/bisq-network/bisq-common/issues/25" href="https://github.com/bisq-network/bisq-common/pull/25">bisq-network/bisq-common#25</a></p>
<ul>
<li>Use ProtobufferException for<br>
CoreNetworkProtoResolver.fromProto(PB.NetworkEnvelope proto)</li>
<li>Add raw PB data in case if an exception</li>
<li>log error if the encrypted data contains unknown PB data</li>
</ul>
<p>Note: We should refactor the resolvers with checked exceptions instead<br>
of the ProtobufferRuntimeException, but for the moment we leave that to<br>
not add too much complexity/risk for that release.</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/bisq-network/bisq-p2p/pull/11'>https://github.com/bisq-network/bisq-p2p/pull/11</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Handle unknown PB data from encrypted messages</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-p2p/pull/11/files#diff-0">src/main/java/bisq/network/crypto/EncryptionService.java</a>
    (10)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-p2p/pull/11/files#diff-1">src/main/java/bisq/network/p2p/P2PService.java</a>
    (9)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-p2p/pull/11/files#diff-2">src/main/java/bisq/network/p2p/network/Connection.java</a>
    (3)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/bisq-network/bisq-p2p/pull/11.patch'>https://github.com/bisq-network/bisq-p2p/pull/11.patch</a></li>
  <li><a href='https://github.com/bisq-network/bisq-p2p/pull/11.diff'>https://github.com/bisq-network/bisq-p2p/pull/11.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq-p2p/pull/11">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtmn5O2blP0y4fMluzVssfGIuGAeiks5t_LidgaJpZM4Uza_p">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtraWQcKlTwrzDc4CjSbGShWSmWhTks5t_LidgaJpZM4Uza_p.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","potentialAction":{"@type":"ViewAction","target":"https://github.com/bisq-network/bisq-p2p/pull/11","url":"https://github.com/bisq-network/bisq-p2p/pull/11","name":"View Pull Request"},"description":"View this Pull Request on GitHub","publisher":{"@type":"Organization","name":"GitHub","url":"https://github.com"}}</script>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq-p2p","title":"bisq-network/bisq-p2p","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq-p2p"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Handle unknown PB data from encrypted messages (#11)"}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq-p2p/pull/11"}}}</script>
<script type="application/ld+json">{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Handle unknown PB data from encrypted messages (#11)",
"sections": [
{
"text": "",
"activityTitle": "**Manfred Karrer**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@ManfredKarrer",
"facts": [

]
},
{
"title": "Commit Summary",
"facts": [
{
"name": "2892be6",
"value": "Handle unknown PB data from encrypted messages"
}
]
},
{
"title": "File Changes",
"facts": [
{
"name": "Modified",
"value": "[src/main/java/bisq/network/crypto/EncryptionService.java](https://github.com/bisq-network/bisq-p2p/pull/11/files#diff-0) (10 changes)"
},
{
"name": "Modified",
"value": "[src/main/java/bisq/network/p2p/P2PService.java](https://github.com/bisq-network/bisq-p2p/pull/11/files#diff-1) (9 changes)"
},
{
"name": "Modified",
"value": "[src/main/java/bisq/network/p2p/network/Connection.java](https://github.com/bisq-network/bisq-p2p/pull/11/files#diff-2) (3 changes)"
}
]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"bisq-network/bisq-p2p\",\n\"issueId\": 11,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"bisq-network/bisq-p2p\",\n\"pullRequestId\": 11\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq-p2p/pull/11"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq-p2p/pull/11.patch"
}
],
"@type": "OpenUri",
"name": "View patch"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq-p2p/pull/11.diff"
}
],
"@type": "OpenUri",
"name": "View diff"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 349024233\n}"
}
],
"themeColor": "26292E"
}</script>