<p><b>@ManfredKarrer</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq-p2p/pull/10#discussion_r197366965">src/main/java/bisq/network/p2p/network/Connection.java</a>:</p>
<pre style='color:#555'>> @@ -283,22 +283,26 @@ public boolean isCapabilitySupported(NetworkEnvelope networkEnvelop) {
             final PersistableNetworkPayload persistableNetworkPayload = ((AddPersistableNetworkPayloadMessage) networkEnvelop).getPersistableNetworkPayload();
             return !(persistableNetworkPayload instanceof CapabilityRequiringPayload) || isCapabilitySupported((CapabilityRequiringPayload) persistableNetworkPayload);
         } else {
-            return true;
+            return !(networkEnvelop instanceof CapabilityRequiringPayload) || isCapabilitySupported((CapabilityRequiringPayload) networkEnvelop);
</pre>
<p>It should only affect the CapabilityRequiringPayload messages and so far those all have been covered by they first 2 cases as they have been used as storage payloads. With the AckMessage we have a new case which would not have been covered. As well in the BSQ code there will be new cases. E.g. normal network envelopes which are not supported on older client versions so we don't want to send it to those. Those new messages must be "non-critical" anyway as otherwise we would require a hardfork update.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq-p2p/pull/10#discussion_r197366965">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZttCrpJYs2JmiI5SFypeCr-ttcsZlks5t_KLYgaJpZM4UymZK">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtq5gUa8r2d4ghM2i5J6IkYH6Itqiks5t_KLYgaJpZM4UymZK.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","potentialAction":{"@type":"ViewAction","target":"https://github.com/bisq-network/bisq-p2p/pull/10#discussion_r197366965","url":"https://github.com/bisq-network/bisq-p2p/pull/10#discussion_r197366965","name":"View Pull Request"},"description":"View this Pull Request on GitHub","publisher":{"@type":"Organization","name":"GitHub","url":"https://github.com"}}</script>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq-p2p","title":"bisq-network/bisq-p2p","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq-p2p"}},"updates":{"snippets":[{"icon":"PERSON","message":"@ManfredKarrer commented on #10"}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq-p2p/pull/10#discussion_r197366965"}}}</script>
<script type="application/ld+json">{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "@ManfredKarrer commented on 10",
"sections": [
{
"text": "",
"activityTitle": "**Manfred Karrer**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@ManfredKarrer",
"facts": [

]
}
],
"potentialAction": [
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq-p2p/pull/10#discussion_r197366965"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 348808778\n}"
}
],
"themeColor": "26292E"
}</script>