<p><b>@ManfredKarrer</b> requested changes on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq-desktop/pull/1578#discussion_r197503805">src/main/java/bisq/desktop/main/portfolio/editoffer/EditOpenOfferDataModel.java</a>:</p>
<pre style='color:#555'>>      }
 
     public void initWithData(OpenOffer openOffer) {
         this.openOffer = openOffer;
         this.initialState = openOffer.getState();
         this.paymentAccount = user.getPaymentAccount(openOffer.getOffer().getMakerPaymentAccountId());
+        // select the current offer payment account as default payment account
+        preferences.setSelectedPaymentAccountForCreateOffer(paymentAccount);
</pre>
<p>Is that needed in the base class or should that be only called in the createOffer sub class? If so, maybe better to overwrite initWithData there.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq-desktop/pull/1578#discussion_r197504231">src/main/java/bisq/desktop/main/portfolio/editoffer/EditOpenOfferView.java</a>:</p>
<pre style='color:#555'>> @@ -131,9 +131,9 @@ protected void deactivate() {
     ///////////////////////////////////////////////////////////////////////////////////////////
 
     public void initWithData(OpenOffer openOffer) {
+        model.initWithData(openOffer);
</pre>
<p>I would prefer if we don't have that call before the super call. Carries risky dependencies of order of calls (see my comment in other commit - maybe that solves the issue without changing here the order?)</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq-desktop/pull/1578#pullrequestreview-131266584">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtvGN2IQiFiWez0hvbXMFuFA8PuFbks5t_R9rgaJpZM4UxyRd">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtglZtiihOS5Wp3MtXdYhHXWs-G4_ks5t_R9rgaJpZM4UxyRd.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","potentialAction":{"@type":"ViewAction","target":"https://github.com/bisq-network/bisq-desktop/pull/1578#pullrequestreview-131266584","url":"https://github.com/bisq-network/bisq-desktop/pull/1578#pullrequestreview-131266584","name":"View Pull Request"},"description":"View this Pull Request on GitHub","publisher":{"@type":"Organization","name":"GitHub","url":"https://github.com"}}</script>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq-desktop","title":"bisq-network/bisq-desktop","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq-desktop"}},"updates":{"snippets":[{"icon":"PERSON","message":"@ManfredKarrer requested changes on #1578"}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq-desktop/pull/1578#pullrequestreview-131266584"}}}</script>
<script type="application/ld+json">{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "@ManfredKarrer requested changes on 1578",
"sections": [
{
"text": "",
"activityTitle": "**Manfred Karrer**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@ManfredKarrer",
"facts": [

]
}
],
"potentialAction": [
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq-desktop/pull/1578#pullrequestreview-131266584"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 348595293\n}"
}
],
"themeColor": "26292E"
}</script>