<p>See: <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="335489572" data-permission-text="Issue title is private" data-url="https://github.com/bisq-network/bisq-desktop/issues/1585" href="https://github.com/bisq-network/bisq-desktop/issues/1585">bisq-network/bisq-desktop#1585</a></p>
<p>Depends on: <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="335491863" data-permission-text="Issue title is private" data-url="https://github.com/bisq-network/bisq-common/issues/26" href="https://github.com/bisq-network/bisq-common/pull/26">bisq-network/bisq-common#26</a></p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/bisq-network/bisq-p2p/pull/12'>https://github.com/bisq-network/bisq-p2p/pull/12</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Add ConfirmationMessage and ConfirmationSourceType</li>
  <li>Rename ConfirmationMessage to AckMessage</li>
  <li>Make AckMessage MailboxMessage</li>
  <li>Persist MessageState in processModel</li>
  <li>Merge branch 'cpability-fix' into confirmation-message</li>
  <li>Add supportedCapabilities to Peer</li>
  <li>Add AckMessage to dispute messages</li>
  <li>Improve dispute AckMsg handling</li>
  <li>Add support for AckMessage at offer availability protocol</li>
  <li>Add UidMessage</li>
  <li>Improve logging</li>
  <li>Improve logging</li>
  <li>Rename networkEnvelop to networkEnvelope</li>
  <li>Merge branch 'master' into confirmation-message</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-p2p/pull/12/files#diff-0">src/main/java/bisq/network/crypto/EncryptionService.java</a>
    (8)
  </li>
  <li>
    <strong>A</strong>
    <a href="https://github.com/bisq-network/bisq-p2p/pull/12/files#diff-1">src/main/java/bisq/network/p2p/AckMessage.java</a>
    (180)
  </li>
  <li>
    <strong>A</strong>
    <a href="https://github.com/bisq-network/bisq-p2p/pull/12/files#diff-2">src/main/java/bisq/network/p2p/AckMessageSourceType.java</a>
    (25)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-p2p/pull/12/files#diff-3">src/main/java/bisq/network/p2p/MailboxMessage.java</a>
    (4)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-p2p/pull/12/files#diff-4">src/main/java/bisq/network/p2p/P2PService.java</a>
    (153)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-p2p/pull/12/files#diff-5">src/main/java/bisq/network/p2p/SendDirectMessageListener.java</a>
    (2)
  </li>
  <li>
    <strong>A</strong>
    <a href="https://github.com/bisq-network/bisq-p2p/pull/12/files#diff-6">src/main/java/bisq/network/p2p/UidMessage.java</a>
    (23)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-p2p/pull/12/files#diff-7">src/main/java/bisq/network/p2p/network/Connection.java</a>
    (78)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-p2p/pull/12/files#diff-8">src/main/java/bisq/network/p2p/network/MessageListener.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-p2p/pull/12/files#diff-9">src/main/java/bisq/network/p2p/network/NetworkNode.java</a>
    (23)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-p2p/pull/12/files#diff-10">src/main/java/bisq/network/p2p/network/Statistic.java</a>
    (8)
  </li>
  <li>
    <strong>A</strong>
    <a href="https://github.com/bisq-network/bisq-p2p/pull/12/files#diff-11">src/main/java/bisq/network/p2p/network/SupportedCapabilitiesListener.java</a>
    (24)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-p2p/pull/12/files#diff-12">src/main/java/bisq/network/p2p/peers/BroadcastHandler.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-p2p/pull/12/files#diff-13">src/main/java/bisq/network/p2p/peers/PeerManager.java</a>
    (20)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-p2p/pull/12/files#diff-14">src/main/java/bisq/network/p2p/peers/getdata/GetDataRequestHandler.java</a>
    (3)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-p2p/pull/12/files#diff-15">src/main/java/bisq/network/p2p/peers/getdata/RequestDataHandler.java</a>
    (10)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-p2p/pull/12/files#diff-16">src/main/java/bisq/network/p2p/peers/getdata/RequestDataManager.java</a>
    (8)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-p2p/pull/12/files#diff-17">src/main/java/bisq/network/p2p/peers/keepalive/KeepAliveHandler.java</a>
    (8)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-p2p/pull/12/files#diff-18">src/main/java/bisq/network/p2p/peers/keepalive/KeepAliveManager.java</a>
    (8)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-p2p/pull/12/files#diff-19">src/main/java/bisq/network/p2p/peers/peerexchange/Peer.java</a>
    (56)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-p2p/pull/12/files#diff-20">src/main/java/bisq/network/p2p/peers/peerexchange/PeerExchangeHandler.java</a>
    (9)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-p2p/pull/12/files#diff-21">src/main/java/bisq/network/p2p/peers/peerexchange/PeerExchangeManager.java</a>
    (10)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-p2p/pull/12/files#diff-22">src/main/java/bisq/network/p2p/peers/peerexchange/messages/GetPeersResponse.java</a>
    (14)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-p2p/pull/12/files#diff-23">src/main/java/bisq/network/p2p/storage/P2PDataStorage.java</a>
    (26)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/bisq-network/bisq-p2p/pull/12.patch'>https://github.com/bisq-network/bisq-p2p/pull/12.patch</a></li>
  <li><a href='https://github.com/bisq-network/bisq-p2p/pull/12.diff'>https://github.com/bisq-network/bisq-p2p/pull/12.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq-p2p/pull/12">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtq5u29h5acq6M-bd5aRYYiKxURV2ks5uARhkgaJpZM4U2hVN">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtnnB7hRNHkZmsHtPhU-XbOr6XJO2ks5uARhkgaJpZM4U2hVN.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","potentialAction":{"@type":"ViewAction","target":"https://github.com/bisq-network/bisq-p2p/pull/12","url":"https://github.com/bisq-network/bisq-p2p/pull/12","name":"View Pull Request"},"description":"View this Pull Request on GitHub","publisher":{"@type":"Organization","name":"GitHub","url":"https://github.com"}}</script>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq-p2p","title":"bisq-network/bisq-p2p","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq-p2p"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Ack messages for all trade, offer- and dispute messages (#12)"}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq-p2p/pull/12"}}}</script>
<script type="application/ld+json">{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Ack messages for all trade, offer- and dispute messages (#12)",
"sections": [
{
"text": "",
"activityTitle": "**Manfred Karrer**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@ManfredKarrer",
"facts": [

]
},
{
"title": "Commit Summary",
"facts": [
{
"name": "407ff15",
"value": "Add ConfirmationMessage and ConfirmationSourceType"
},
{
"name": "8895ef7",
"value": "Rename ConfirmationMessage to AckMessage"
},
{
"name": "82374d4",
"value": "Make AckMessage MailboxMessage"
},
{
"name": "11e7b4d",
"value": "Persist MessageState in processModel"
},
{
"name": "288e57a",
"value": "Merge branch 'cpability-fix' into confirmation-message"
},
{
"name": "b76a854",
"value": "Add supportedCapabilities to Peer"
},
{
"name": "1903358",
"value": "Add AckMessage to dispute messages"
},
{
"name": "ea7f917",
"value": "Improve dispute AckMsg handling"
},
{
"name": "e83e001",
"value": "Add support for AckMessage at offer availability protocol"
},
{
"name": "40dea55",
"value": "Add UidMessage"
},
{
"name": "67ddf29",
"value": "Improve logging"
},
{
"name": "bb16496",
"value": "Improve logging"
},
{
"name": "4b0ff36",
"value": "Rename networkEnvelop to networkEnvelope"
},
{
"name": "d57086a",
"value": "Merge branch 'master' into confirmation-message"
}
]
},
{
"title": "File Changes",
"facts": [
{
"name": "Modified",
"value": "[src/main/java/bisq/network/crypto/EncryptionService.java](https://github.com/bisq-network/bisq-p2p/pull/12/files#diff-0) (8 changes)"
},
{
"name": "Added",
"value": "[src/main/java/bisq/network/p2p/AckMessage.java](https://github.com/bisq-network/bisq-p2p/pull/12/files#diff-1) (180 changes)"
},
{
"name": "Added",
"value": "[src/main/java/bisq/network/p2p/AckMessageSourceType.java](https://github.com/bisq-network/bisq-p2p/pull/12/files#diff-2) (25 changes)"
},
{
"name": "Modified",
"value": "[src/main/java/bisq/network/p2p/MailboxMessage.java](https://github.com/bisq-network/bisq-p2p/pull/12/files#diff-3) (4 changes)"
},
{
"name": "Modified",
"value": "[src/main/java/bisq/network/p2p/P2PService.java](https://github.com/bisq-network/bisq-p2p/pull/12/files#diff-4) (153 changes)"
},
{
"name": "Modified",
"value": "[src/main/java/bisq/network/p2p/SendDirectMessageListener.java](https://github.com/bisq-network/bisq-p2p/pull/12/files#diff-5) (2 changes)"
},
{
"name": "Added",
"value": "[src/main/java/bisq/network/p2p/UidMessage.java](https://github.com/bisq-network/bisq-p2p/pull/12/files#diff-6) (23 changes)"
},
{
"name": "Modified",
"value": "[src/main/java/bisq/network/p2p/network/Connection.java](https://github.com/bisq-network/bisq-p2p/pull/12/files#diff-7) (78 changes)"
},
{
"name": "Modified",
"value": "[src/main/java/bisq/network/p2p/network/MessageListener.java](https://github.com/bisq-network/bisq-p2p/pull/12/files#diff-8) (2 changes)"
},
{
"name": "Modified",
"value": "[src/main/java/bisq/network/p2p/network/NetworkNode.java](https://github.com/bisq-network/bisq-p2p/pull/12/files#diff-9) (23 changes)"
},
{
"name": "Modified",
"value": "[src/main/java/bisq/network/p2p/network/Statistic.java](https://github.com/bisq-network/bisq-p2p/pull/12/files#diff-10) (8 changes)"
},
{
"name": "Added",
"value": "[src/main/java/bisq/network/p2p/network/SupportedCapabilitiesListener.java](https://github.com/bisq-network/bisq-p2p/pull/12/files#diff-11) (24 changes)"
},
{
"name": "Modified",
"value": "[src/main/java/bisq/network/p2p/peers/BroadcastHandler.java](https://github.com/bisq-network/bisq-p2p/pull/12/files#diff-12) (2 changes)"
},
{
"name": "Modified",
"value": "[src/main/java/bisq/network/p2p/peers/PeerManager.java](https://github.com/bisq-network/bisq-p2p/pull/12/files#diff-13) (20 changes)"
},
{
"name": "Modified",
"value": "[src/main/java/bisq/network/p2p/peers/getdata/GetDataRequestHandler.java](https://github.com/bisq-network/bisq-p2p/pull/12/files#diff-14) (3 changes)"
},
{
"name": "Modified",
"value": "[src/main/java/bisq/network/p2p/peers/getdata/RequestDataHandler.java](https://github.com/bisq-network/bisq-p2p/pull/12/files#diff-15) (10 changes)"
},
{
"name": "Modified",
"value": "[src/main/java/bisq/network/p2p/peers/getdata/RequestDataManager.java](https://github.com/bisq-network/bisq-p2p/pull/12/files#diff-16) (8 changes)"
},
{
"name": "Modified",
"value": "[src/main/java/bisq/network/p2p/peers/keepalive/KeepAliveHandler.java](https://github.com/bisq-network/bisq-p2p/pull/12/files#diff-17) (8 changes)"
},
{
"name": "Modified",
"value": "[src/main/java/bisq/network/p2p/peers/keepalive/KeepAliveManager.java](https://github.com/bisq-network/bisq-p2p/pull/12/files#diff-18) (8 changes)"
},
{
"name": "Modified",
"value": "[src/main/java/bisq/network/p2p/peers/peerexchange/Peer.java](https://github.com/bisq-network/bisq-p2p/pull/12/files#diff-19) (56 changes)"
},
{
"name": "Modified",
"value": "[src/main/java/bisq/network/p2p/peers/peerexchange/PeerExchangeHandler.java](https://github.com/bisq-network/bisq-p2p/pull/12/files#diff-20) (9 changes)"
},
{
"name": "Modified",
"value": "[src/main/java/bisq/network/p2p/peers/peerexchange/PeerExchangeManager.java](https://github.com/bisq-network/bisq-p2p/pull/12/files#diff-21) (10 changes)"
},
{
"name": "Modified",
"value": "[src/main/java/bisq/network/p2p/peers/peerexchange/messages/GetPeersResponse.java](https://github.com/bisq-network/bisq-p2p/pull/12/files#diff-22) (14 changes)"
},
{
"name": "Modified",
"value": "[src/main/java/bisq/network/p2p/storage/P2PDataStorage.java](https://github.com/bisq-network/bisq-p2p/pull/12/files#diff-23) (26 changes)"
}
]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"bisq-network/bisq-p2p\",\n\"issueId\": 12,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"bisq-network/bisq-p2p\",\n\"pullRequestId\": 12\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq-p2p/pull/12"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq-p2p/pull/12.patch"
}
],
"@type": "OpenUri",
"name": "View patch"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq-p2p/pull/12.diff"
}
],
"@type": "OpenUri",
"name": "View diff"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 349836621\n}"
}
],
"themeColor": "26292E"
}</script>