<p><b>@ManfredKarrer</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq-p2p/pull/12#discussion_r198120031">src/main/java/bisq/network/p2p/AckMessage.java</a>:</p>
<pre style='color:#555'>> +    public String toString() {
+        return "AckMessage{" +
+                "\n     uid='" + uid + '\'' +
+                ",\n     senderNodeAddress=" + senderNodeAddress +
+                ",\n     sourceType=" + sourceType +
+                ",\n     sourceMsgClassName='" + sourceMsgClassName + '\'' +
+                ",\n     sourceUid='" + sourceUid + '\'' +
+                ",\n     sourceId='" + sourceId + '\'' +
+                ",\n     result=" + result +
+                ",\n     errorMessage='" + errorMessage + '\'' +
+                "\n} " + super.toString();
+    }
+
+    @Override
+    public long getTTL() {
+        return TimeUnit.DAYS.toMillis(10);
</pre>
<p>The trade period can take about 1 week (sepa), so 10 days seems to be reasonable safe to not miss acks. Also the dispute can take sometimes longer if a peer need to wait for bank reply or the like. But agree hard to say whats the best value here....</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq-p2p/pull/12#discussion_r198120031">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtmmGu4JildNne9Q8oEEYypm6hDOKks5uAiYtgaJpZM4U2hVN">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtsmN6Vz_wuJ8TR8EqM3DyFtxGHW_ks5uAiYtgaJpZM4U2hVN.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq-p2p","title":"bisq-network/bisq-p2p","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq-p2p"}},"updates":{"snippets":[{"icon":"PERSON","message":"@ManfredKarrer commented on #12"}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq-p2p/pull/12#discussion_r198120031"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq-p2p/pull/12#discussion_r198120031",
"url": "https://github.com/bisq-network/bisq-p2p/pull/12#discussion_r198120031",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "@ManfredKarrer commented on 12",
"sections": [
{
"text": "",
"activityTitle": "**Manfred Karrer**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@ManfredKarrer",
"facts": [

]
}
],
"potentialAction": [
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq-p2p/pull/12#discussion_r198120031"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 349836621\n}"
}
],
"themeColor": "26292E"
}
]</script>