<p>Hey <a class="user-mention" data-hovercard-user-id="431064" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/blabno">@blabno</a>, just a heads up that there's no need to have submitters squash commits if the only "extra commits" in question are review commits, e.g. the one here in which you applied Bisq's code style. It's actually useful to preserve such commits because it teaches others what the style deviation was.</p>
<p>What's <em>not</em> useful is having N partial commits that put together the original pull request. We always those three changes (<code>Asset</code> implementation, test and registration) to be atomic, and thus squashed if necessary. Thanks.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq-assets/pull/29#issuecomment-400239759">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZttXo59Hkkv5wq73TFTjzfYEhasxTks5uAfvqgaJpZM4UcU0a">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtiK9H6gAzdCeJPykFsh7FJlbfhSkks5uAfvqgaJpZM4UcU0a.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq-assets","title":"bisq-network/bisq-assets","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq-assets"}},"updates":{"snippets":[{"icon":"PERSON","message":"@cbeams in #29: Hey @blabno, just a heads up that there's no need to have submitters squash commits if the only \"extra commits\" in question are review commits, e.g. the one here in which you applied Bisq's code style. It's actually useful to preserve such commits because it teaches others what the style deviation was.\r\n\r\nWhat's _not_ useful is having N partial commits that put together the original pull request. We always those three changes (`Asset` implementation, test and registration) to be atomic, and thus squashed if necessary. Thanks."}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq-assets/pull/29#issuecomment-400239759"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq-assets/pull/29#issuecomment-400239759",
"url": "https://github.com/bisq-network/bisq-assets/pull/29#issuecomment-400239759",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Re: [bisq-network/bisq-assets] List BitCloud (BTDX) (#29)",
"sections": [
{
"text": "",
"activityTitle": "**Chris Beams**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@cbeams",
"facts": [

]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"bisq-network/bisq-assets\",\n\"issueId\": 29,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"bisq-network/bisq-assets\",\n\"pullRequestId\": 29\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq-assets/pull/29#issuecomment-400239759"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 342969626\n}"
}
],
"themeColor": "26292E"
}
]</script>