<p>Depends on: <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="335818784" data-permission-text="Issue title is private" data-url="https://github.com/bisq-network/bisq-common/issues/27" href="https://github.com/bisq-network/bisq-common/pull/27">bisq-network/bisq-common#27</a><br>
and <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="335818980" data-permission-text="Issue title is private" data-url="https://github.com/bisq-network/bisq-p2p/issues/13" href="https://github.com/bisq-network/bisq-p2p/pull/13">bisq-network/bisq-p2p#13</a></p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/bisq-network/bisq-core/pull/126'>https://github.com/bisq-network/bisq-core/pull/126</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Move onDisputesChangeListener to disputeManager</li>
  <li>Introduce presentation classes in core</li>
  <li>Add missing @Inject to constructors</li>
  <li>Refactor TradeManager startup code</li>
  <li>Cleanup AccountAgeWitnessService</li>
  <li>Group wallet init code</li>
  <li>Refactoring MainViewModel</li>
  <li>Move checkForCorrectOSArchitecture to BisqSetup</li>
  <li>Cleanup</li>
  <li>Add headless BisqCoreApp and BisqCoreAppMain</li>
  <li>Merge branch 'master' into refactoring-mainviewmodel</li>
  <li>Add popup if bitcoinLocalhostNode detected</li>
  <li>Merge branch 'master' into refactoring-mainviewmodel</li>
  <li>Merge branch 'master' into refactoring-mainviewmodel</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>A</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/126/files#diff-0">src/main/java/bisq/core/app/BisqCoreApp.java</a>
    (135)
  </li>
  <li>
    <strong>A</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/126/files#diff-1">src/main/java/bisq/core/app/BisqCoreAppMain.java</a>
    (113)
  </li>
  <li>
    <strong>A</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/126/files#diff-2">src/main/java/bisq/core/app/BisqSetup.java</a>
    (617)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/126/files#diff-3">src/main/java/bisq/core/app/CoreModule.java</a>
    (10)
  </li>
  <li>
    <strong>A</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/126/files#diff-4">src/main/java/bisq/core/app/P2PNetworkSetup.java</a>
    (219)
  </li>
  <li>
    <strong>A</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/126/files#diff-5">src/main/java/bisq/core/app/WalletAppSetup.java</a>
    (177)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/126/files#diff-6">src/main/java/bisq/core/arbitration/DisputeManager.java</a>
    (46)
  </li>
  <li>
    <strong>A</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/126/files#diff-7">src/main/java/bisq/core/btc/BalanceModel.java</a>
    (113)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/126/files#diff-8">src/main/java/bisq/core/btc/BitcoinModule.java</a>
    (1)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/126/files#diff-9">src/main/java/bisq/core/payment/AccountAgeWitnessService.java</a>
    (67)
  </li>
  <li>
    <strong>A</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/126/files#diff-10">src/main/java/bisq/core/presentation/BalancePresentation.java</a>
    (55)
  </li>
  <li>
    <strong>A</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/126/files#diff-11">src/main/java/bisq/core/presentation/CorePresentationModule.java</a>
    (38)
  </li>
  <li>
    <strong>A</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/126/files#diff-12">src/main/java/bisq/core/presentation/DisputePresentation.java</a>
    (49)
  </li>
  <li>
    <strong>A</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/126/files#diff-13">src/main/java/bisq/core/presentation/TradePresentation.java</a>
    (49)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/126/files#diff-14">src/main/java/bisq/core/trade/TradeManager.java</a>
    (73)
  </li>
  <li>
    <strong>A</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/126/files#diff-15">src/main/java/bisq/core/util/BSFormatter.java</a>
    (731)
  </li>
  <li>
    <strong>A</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/126/files#diff-16">src/main/java/bisq/core/util/BsqFormatter.java</a>
    (104)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/bisq-network/bisq-core/pull/126.patch'>https://github.com/bisq-network/bisq-core/pull/126.patch</a></li>
  <li><a href='https://github.com/bisq-network/bisq-core/pull/126.diff'>https://github.com/bisq-network/bisq-core/pull/126.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq-core/pull/126">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZts6TWoHWBQyS52K06yiE-2Onol6Nks5uAjamgaJpZM4U38JE">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtgNhQ12DVcHpdgv1Wp7cxz-e-LJLks5uAjamgaJpZM4U38JE.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq-core","title":"bisq-network/bisq-core","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq-core"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Refactoring mainviewmodel (#126)"}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq-core/pull/126"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq-core/pull/126",
"url": "https://github.com/bisq-network/bisq-core/pull/126",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Refactoring mainviewmodel (#126)",
"sections": [
{
"text": "",
"activityTitle": "**Manfred Karrer**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@ManfredKarrer",
"facts": [

]
},
{
"title": "Commit Summary",
"facts": [
{
"name": "d29ffff",
"value": "Move onDisputesChangeListener to disputeManager"
},
{
"name": "7175ccf",
"value": "Introduce presentation classes in core"
},
{
"name": "7206500",
"value": "Add missing @Inject to constructors"
},
{
"name": "1e96bc9",
"value": "Refactor TradeManager startup code"
},
{
"name": "67be641",
"value": "Cleanup AccountAgeWitnessService"
},
{
"name": "ee762da",
"value": "Group wallet init code"
},
{
"name": "0605252",
"value": "Refactoring MainViewModel"
},
{
"name": "566f640",
"value": "Move checkForCorrectOSArchitecture to BisqSetup"
},
{
"name": "597d7e7",
"value": "Cleanup"
},
{
"name": "2a87fc6",
"value": "Add headless BisqCoreApp and BisqCoreAppMain"
},
{
"name": "8f1573c",
"value": "Merge branch 'master' into refactoring-mainviewmodel"
},
{
"name": "f2ad5ba",
"value": "Add popup if bitcoinLocalhostNode detected"
},
{
"name": "6293d8c",
"value": "Merge branch 'master' into refactoring-mainviewmodel"
},
{
"name": "ae8f7e0",
"value": "Merge branch 'master' into refactoring-mainviewmodel"
}
]
},
{
"title": "File Changes",
"facts": [
{
"name": "Added",
"value": "[src/main/java/bisq/core/app/BisqCoreApp.java](https://github.com/bisq-network/bisq-core/pull/126/files#diff-0) (135 changes)"
},
{
"name": "Added",
"value": "[src/main/java/bisq/core/app/BisqCoreAppMain.java](https://github.com/bisq-network/bisq-core/pull/126/files#diff-1) (113 changes)"
},
{
"name": "Added",
"value": "[src/main/java/bisq/core/app/BisqSetup.java](https://github.com/bisq-network/bisq-core/pull/126/files#diff-2) (617 changes)"
},
{
"name": "Modified",
"value": "[src/main/java/bisq/core/app/CoreModule.java](https://github.com/bisq-network/bisq-core/pull/126/files#diff-3) (10 changes)"
},
{
"name": "Added",
"value": "[src/main/java/bisq/core/app/P2PNetworkSetup.java](https://github.com/bisq-network/bisq-core/pull/126/files#diff-4) (219 changes)"
},
{
"name": "Added",
"value": "[src/main/java/bisq/core/app/WalletAppSetup.java](https://github.com/bisq-network/bisq-core/pull/126/files#diff-5) (177 changes)"
},
{
"name": "Modified",
"value": "[src/main/java/bisq/core/arbitration/DisputeManager.java](https://github.com/bisq-network/bisq-core/pull/126/files#diff-6) (46 changes)"
},
{
"name": "Added",
"value": "[src/main/java/bisq/core/btc/BalanceModel.java](https://github.com/bisq-network/bisq-core/pull/126/files#diff-7) (113 changes)"
},
{
"name": "Modified",
"value": "[src/main/java/bisq/core/btc/BitcoinModule.java](https://github.com/bisq-network/bisq-core/pull/126/files#diff-8) (1 changes)"
},
{
"name": "Modified",
"value": "[src/main/java/bisq/core/payment/AccountAgeWitnessService.java](https://github.com/bisq-network/bisq-core/pull/126/files#diff-9) (67 changes)"
},
{
"name": "Added",
"value": "[src/main/java/bisq/core/presentation/BalancePresentation.java](https://github.com/bisq-network/bisq-core/pull/126/files#diff-10) (55 changes)"
},
{
"name": "Added",
"value": "[src/main/java/bisq/core/presentation/CorePresentationModule.java](https://github.com/bisq-network/bisq-core/pull/126/files#diff-11) (38 changes)"
},
{
"name": "Added",
"value": "[src/main/java/bisq/core/presentation/DisputePresentation.java](https://github.com/bisq-network/bisq-core/pull/126/files#diff-12) (49 changes)"
},
{
"name": "Added",
"value": "[src/main/java/bisq/core/presentation/TradePresentation.java](https://github.com/bisq-network/bisq-core/pull/126/files#diff-13) (49 changes)"
},
{
"name": "Modified",
"value": "[src/main/java/bisq/core/trade/TradeManager.java](https://github.com/bisq-network/bisq-core/pull/126/files#diff-14) (73 changes)"
},
{
"name": "Added",
"value": "[src/main/java/bisq/core/util/BSFormatter.java](https://github.com/bisq-network/bisq-core/pull/126/files#diff-15) (731 changes)"
},
{
"name": "Added",
"value": "[src/main/java/bisq/core/util/BsqFormatter.java](https://github.com/bisq-network/bisq-core/pull/126/files#diff-16) (104 changes)"
}
]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"bisq-network/bisq-core\",\n\"issueId\": 126,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"bisq-network/bisq-core\",\n\"pullRequestId\": 126\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq-core/pull/126"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq-core/pull/126.patch"
}
],
"@type": "OpenUri",
"name": "View patch"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq-core/pull/126.diff"
}
],
"@type": "OpenUri",
"name": "View diff"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 350208580\n}"
}
],
"themeColor": "26292E"
}
]</script>