<p><b>@ManfredKarrer</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq-core/pull/127#discussion_r198369390">src/main/java/bisq/core/offer/OfferPayload.java</a>:</p>
<pre style='color:#555'>> +                ",\n     makerFee=" + makerFee +
+                ",\n     isCurrencyForMakerFeeBtc=" + isCurrencyForMakerFeeBtc +
+                ",\n     buyerSecurityDeposit=" + buyerSecurityDeposit +
+                ",\n     sellerSecurityDeposit=" + sellerSecurityDeposit +
+                ",\n     maxTradeLimit=" + maxTradeLimit +
+                ",\n     maxTradePeriod=" + maxTradePeriod +
+                ",\n     useAutoClose=" + useAutoClose +
+                ",\n     useReOpenAfterAutoClose=" + useReOpenAfterAutoClose +
+                ",\n     lowerClosePrice=" + lowerClosePrice +
+                ",\n     upperClosePrice=" + upperClosePrice +
+                ",\n     isPrivateOffer=" + isPrivateOffer +
+                ",\n     hashOfChallenge='" + hashOfChallenge + '\'' +
+                ",\n     extraDataMap=" + extraDataMap +
+                ",\n     protocolVersion=" + protocolVersion +
+                "\n}";
+    }
</pre>
<p>I have a custom template for toString:<br>
If you do ctrl + enter you can generate toString. There in the opening window is a settings button right and there are the templates...<br>
The Lombok toString is not editable and for readability I prefer linebreaks, as well there are some type specific behavior (bytes get printed as hex).</p>
<p>public java.lang.String toString() {<br>
#if ( $members.size() > 0 )<br>
#set ( $i = 0 )<br>
return "$classname{" +<br>
#foreach( $member in $members )<br>
#if ( $i == 0 )<br>
"\n     ##<br>
#else<br>
",\n     ##<br>
#end<br>
#if ( $member.objectArray )<br>
#if ($java_version < 5)<br>
$member.name=" + ($member.accessor == null ? null : bisq.common.util.Utilities.bytesAsHexString($member.accessor)) +<br>
#else<br>
$member.name=" + bisq.common.util.Utilities.bytesAsHexString($member.accessor) +<br>
#end<br>
#elseif ( $member.primitiveArray && $java_version >= 5)<br>
$member.name=" + bisq.common.util.Utilities.bytesAsHexString($member.accessor) +<br>
#elseif ( $member.string )<br>
$member.name='" + $member.accessor + ''' +<br>
#else<br>
$member.name=" + $member.accessor +<br>
#end<br>
#set ( $i = $i + 1 )<br>
#end<br>
#if ( $class.hasSuper )<br>
"\n} " + super.toString();<br>
#else<br>
"\n}";<br>
#end<br>
#else<br>
#if ( $class.hasSuper )<br>
return "$classname{} " + super.toString();<br>
#else<br>
return "$classname{}";<br>
#end<br>
#end<br>
}</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq-core/pull/127#discussion_r198369390">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtje9HHmBRoE2_I2-WEDUJ3PQrKA-ks5uAxWogaJpZM4U4jVk">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtmgJgvOHo1MM_gEFvhpdV4vWT4Kyks5uAxWogaJpZM4U4jVk.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq-core","title":"bisq-network/bisq-core","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq-core"}},"updates":{"snippets":[{"icon":"PERSON","message":"@ManfredKarrer commented on #127"}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq-core/pull/127#discussion_r198369390"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq-core/pull/127#discussion_r198369390",
"url": "https://github.com/bisq-network/bisq-core/pull/127#discussion_r198369390",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "@ManfredKarrer commented on 127",
"sections": [
{
"text": "",
"activityTitle": "**Manfred Karrer**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@ManfredKarrer",
"facts": [

]
}
],
"potentialAction": [
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq-core/pull/127#discussion_r198369390"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 350369124\n}"
}
],
"themeColor": "26292E"
}
]</script>