<p><b>@chirhonul</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq-core/pull/124#discussion_r198135377">src/main/java/bisq/core/btc/wallet/BisqRiskAnalysis.java</a>:</p>
<pre style='color:#555'>> +import org.bitcoinj.crypto.TransactionSignature;
+import org.bitcoinj.script.ScriptChunk;
+import org.bitcoinj.wallet.DefaultRiskAnalysis;
+import org.bitcoinj.wallet.RiskAnalysis;
+import org.bitcoinj.wallet.Wallet;
+
+import java.util.List;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import javax.annotation.Nullable;
+
+import static com.google.common.base.Preconditions.checkState;
+
+// Copied from DefaultRiskAnalysis as DefaultRiskAnalysis has mostly private methods and constructor so we cannot
</pre>
<p>Right, it would be somewhat sensitive regardless.. if it was desireable to pursue this, I would start by trying to switch to latest release of BitcoinJ (looks like v0.14.7 at time of writing, <a href="https://github.com/bitcoinj/bitcoinj/tree/v0.14.7">https://github.com/bitcoinj/bitcoinj/tree/v0.14.7</a>), then apply the commits to do any necessary changes for Bisq, then create patches from those commits so only a clean checkout would be necessary, and apply the <code>.patch</code> files during some build step.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq-core/pull/124#discussion_r198135377">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtpZhqrtim5-EeNH4c3iICyo0zZzwks5uAjJDgaJpZM4U28zY">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtuu-wZPjS7wa7b5r_-TJ6L7pL_C7ks5uAjJDgaJpZM4U28zY.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq-core","title":"bisq-network/bisq-core","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq-core"}},"updates":{"snippets":[{"icon":"PERSON","message":"@chirhonul commented on #124"}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq-core/pull/124#discussion_r198135377"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq-core/pull/124#discussion_r198135377",
"url": "https://github.com/bisq-network/bisq-core/pull/124#discussion_r198135377",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "@chirhonul commented on 124",
"sections": [
{
"text": "",
"activityTitle": "**chirhonul**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@chirhonul",
"facts": [

]
}
],
"potentialAction": [
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq-core/pull/124#discussion_r198135377"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 349949144\n}"
}
],
"themeColor": "26292E"
}
]</script>