<p><b>@sqrrm</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/bisq-network/bisq-core/pull/123#discussion_r198186643">src/main/java/bisq/core/arbitration/DisputeManager.java</a>:</p>
<pre style='color:#555'>> }
} else {
- log.error("Trader received openNewDisputeMessage. That must never happen.");
+ errorMessage = "Trader received openNewDisputeMessage. That must never happen.";
+ log.error(errorMessage);
+ }
+
+ // We use the DisputeCommunicationMessage not the openNewDisputeMessage for the ACK
+ ObservableList<DisputeCommunicationMessage> messages = openNewDisputeMessage.getDispute().getDisputeCommunicationMessages();
+ if (!messages.isEmpty()) {
+ DisputeCommunicationMessage msg = messages.get(0);
</pre>
<p>I'm not really following this, what is being acked here?</p>
<hr>
<p>In <a href="https://github.com/bisq-network/bisq-core/pull/123#discussion_r198192803">src/main/java/bisq/core/arbitration/DisputeManager.java</a>:</p>
<pre style='color:#555'>> - payoutTx = tradeOptional.get().getPayoutTx();
- } else {
- final Optional<Tradable> tradableOptional = closedTradableManager.getTradableById(tradeId);
- if (tradableOptional.isPresent() && tradableOptional.get() instanceof Trade) {
- payoutTx = ((Trade) tradableOptional.get()).getPayoutTx();
- }
+ final String tradeId = disputeResult.getTradeId();
+ Optional<Dispute> disputeOptional = findDispute(tradeId, disputeResult.getTraderId());
+ final String uid = disputeResultMessage.getUid();
+ if (!disputeOptional.isPresent()) {
+ log.debug("We got a dispute result msg but we don't have a matching dispute. " +
+ "That might happen when we get the disputeResultMessage before the dispute was created. " +
+ "We try again after 2 sec. to apply the disputeResultMessage. TradeId = " + tradeId);
+ if (!delayMsgMap.containsKey(uid)) {
+ // We delay2 sec. to be sure the comm. msg gets added first
+ Timer timer = UserThread.runAfter(() -> onDisputeResultMessage(disputeResultMessage), 2);
</pre>
<p>This is recursive and seems like it could result in an infinite but very slow loop if there is a real issue somehow. Even if that should never happen it would be better to not have infinite recursion. Unless I missed something on how the timer works.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq-core/pull/123#pullrequestreview-132071326">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtn2Kmh1rUWXiZ1_qxD2SyzQeaqmhks5uAlxWgaJpZM4U2hXw">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtpNi9t-1y9_yHBnW95Xpmp501Hhxks5uAlxWgaJpZM4U2hXw.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq-core","title":"bisq-network/bisq-core","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq-core"}},"updates":{"snippets":[{"icon":"PERSON","message":"@sqrrm commented on #123"}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq-core/pull/123#pullrequestreview-132071326"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq-core/pull/123#pullrequestreview-132071326",
"url": "https://github.com/bisq-network/bisq-core/pull/123#pullrequestreview-132071326",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "@sqrrm commented on 123",
"sections": [
{
"text": "",
"activityTitle": "**sqrrm**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@sqrrm",
"facts": [
]
}
],
"potentialAction": [
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq-core/pull/123#pullrequestreview-132071326"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 349836784\n}"
}
],
"themeColor": "26292E"
}
]</script>