<ul>
<li>Fix bug with ignored taker check (use peer instead of<br>
offer.getMakerNodeAddress()).</li>
<li>Remove redundant tradeStatisticsSet in TradeStatisticsManager</li>
<li>Remove handling for old TradeStatistics objects (since v 0.6.0 not<br>
supported anymore)</li>
<li>Use marketPricePresentation.priceFeedComboBoxItems instead of</li>
<li>MainVievModel.priceFeedComboBoxItems.</li>
<li>Replace Authorisation # with Authorisation number.</li>
<li>Remove <a href="https://bisq.network/survey" rel="nofollow">https://bisq.network/survey</a> and <a href="https://bisq.community" rel="nofollow">https://bisq.community</a> links<br>
in tradeFeedbackWindow text.</li>
<li>Add null checks.</li>
<li>Improve logging.</li>
<li>Cleanup</li>
</ul>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/bisq-network/bisq-core/pull/130'>https://github.com/bisq-network/bisq-core/pull/130</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Misc fixes and cleanups</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/130/files#diff-0">src/main/java/bisq/core/offer/OpenOfferManager.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/130/files#diff-1">src/main/java/bisq/core/provider/price/PriceFeedService.java</a>
    (4)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/130/files#diff-2">src/main/java/bisq/core/trade/statistics/TradeStatisticsManager.java</a>
    (51)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/130/files#diff-3">src/main/resources/i18n/displayStrings.properties</a>
    (18)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/bisq-network/bisq-core/pull/130.patch'>https://github.com/bisq-network/bisq-core/pull/130.patch</a></li>
  <li><a href='https://github.com/bisq-network/bisq-core/pull/130.diff'>https://github.com/bisq-network/bisq-core/pull/130.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq-core/pull/130">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZto8PV0tn4XYDdgZcECgt__59LQFmks5uA028gaJpZM4U5WDW">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtgIxU6fflJ3yhV5XiqXGyk6SLodAks5uA028gaJpZM4U5WDW.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq-core","title":"bisq-network/bisq-core","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq-core"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Misc fixes and cleanups (#130)"}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq-core/pull/130"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq-core/pull/130",
"url": "https://github.com/bisq-network/bisq-core/pull/130",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Misc fixes and cleanups (#130)",
"sections": [
{
"text": "",
"activityTitle": "**Manfred Karrer**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@ManfredKarrer",
"facts": [

]
},
{
"title": "Commit Summary",
"facts": [
{
"name": "952d0d3",
"value": "Misc fixes and cleanups"
}
]
},
{
"title": "File Changes",
"facts": [
{
"name": "Modified",
"value": "[src/main/java/bisq/core/offer/OpenOfferManager.java](https://github.com/bisq-network/bisq-core/pull/130/files#diff-0) (2 changes)"
},
{
"name": "Modified",
"value": "[src/main/java/bisq/core/provider/price/PriceFeedService.java](https://github.com/bisq-network/bisq-core/pull/130/files#diff-1) (4 changes)"
},
{
"name": "Modified",
"value": "[src/main/java/bisq/core/trade/statistics/TradeStatisticsManager.java](https://github.com/bisq-network/bisq-core/pull/130/files#diff-2) (51 changes)"
},
{
"name": "Modified",
"value": "[src/main/resources/i18n/displayStrings.properties](https://github.com/bisq-network/bisq-core/pull/130/files#diff-3) (18 changes)"
}
]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"bisq-network/bisq-core\",\n\"issueId\": 130,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"bisq-network/bisq-core\",\n\"pullRequestId\": 130\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq-core/pull/130"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq-core/pull/130.patch"
}
],
"@type": "OpenUri",
"name": "View patch"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq-core/pull/130.diff"
}
],
"@type": "OpenUri",
"name": "View diff"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 350576854\n}"
}
],
"themeColor": "26292E"
}
]</script>