<p><a class="user-mention" data-hovercard-user-id="301810" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/cbeams">@cbeams</a> Regarding bisq-common tags not been published. Do you mean the tags where not pushed?I also prefer the second option. But I'm not sure if it makes sense to create the tag before building the release as I don't build it based on the JitPack dependencies and wouldn't see any issues during the build process. On the other hand if I run into any issues during testing I would need to remove the tags, fix the problem and tag again.</p>
<p>Just to understand how the process would work. To be able to test it I would need to push all repos first (including the new tag and the revert to the snapshot) and then checkout the bisq-desktop release tag and try to build it. Isn't that something that Travis could do? Or is there an easy way to simulate that locally?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq-desktop/issues/1603#issuecomment-403777209">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtqcvs4Y86SbIp12WqFm_1RHfaPDnks5uFIK9gaJpZM4VIZO9">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtoAJ83Af-TFAblaUbHDHLBuvTDp4ks5uFIK9gaJpZM4VIZO9.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq-desktop","title":"bisq-network/bisq-desktop","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq-desktop"}},"updates":{"snippets":[{"icon":"PERSON","message":"@ripcurlx in #1603: @cbeams Regarding bisq-common tags not been published. Do you mean the tags where not pushed?I also prefer the second option. But I'm not sure if it makes sense to create the tag before building the release as I don't build it based on the JitPack dependencies and wouldn't see any issues during the build process. On the other hand if I run into any issues during testing I would need to remove the tags, fix the problem and tag again.\r\n\r\nJust to understand how the process would work. To be able to test it I would need to push all repos first (including the new tag and the revert to the snapshot) and then checkout the bisq-desktop release tag and try to build it. Isn't that something that Travis could do? Or is there an easy way to simulate that locally?\r\n\r\n"}],"action":{"name":"View Issue","url":"https://github.com/bisq-network/bisq-desktop/issues/1603#issuecomment-403777209"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq-desktop/issues/1603#issuecomment-403777209",
"url": "https://github.com/bisq-network/bisq-desktop/issues/1603#issuecomment-403777209",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Re: [bisq-network/bisq-desktop] Cannot build 0.7.1 (#1603)",
"sections": [
{
"text": "",
"activityTitle": "**Christoph Atteneder**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@ripcurlx",
"facts": [

]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"bisq-network/bisq-desktop\",\n\"issueId\": 1603,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close issue",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueClose\",\n\"repositoryFullName\": \"bisq-network/bisq-desktop\",\n\"issueId\": 1603\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq-desktop/issues/1603#issuecomment-403777209"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 354522045\n}"
}
],
"themeColor": "26292E"
}
]</script>