<p>Depends on:<br>
<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="350795055" data-permission-text="Issue title is private" data-url="https://github.com/bisq-network/bisq-common/issues/33" href="https://github.com/bisq-network/bisq-common/pull/33">bisq-network/bisq-common#33</a></p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/bisq-network/bisq-core/pull/148'>https://github.com/bisq-network/bisq-core/pull/148</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Add mobile notification domain</li>
  <li>Add notifications for offers, trades and disputes</li>
  <li>Merge branch 'master' into notifications</li>
  <li>Add JavaFXWebcam window</li>
  <li>Improve UI, fix productionMode</li>
  <li>Rename msg fields</li>
  <li>Add price alerts</li>
  <li>Remove ptext</li>
  <li>Add testMsg for all types</li>
  <li>Add market alert domain</li>
  <li>Cleanup logs</li>
  <li>Remove dev code</li>
  <li>Add descriptor</li>
  <li>Add tests</li>
  <li>Remove dev code</li>
  <li>Merge branch 'master' into notifications</li>
  <li>Set onion address</li>
  <li>Merge remote-tracking branch 'ManfredKarrer/notifications' into notifications</li>
  <li>Add clearnet relay address</li>
  <li>Remove space</li>
  <li>Merge branch 'master' into notifications</li>
  <li>Cleanups</li>
  <li>Cleanups</li>
  <li>Prepare for custom binary:</li>
  <li>Handle no-webcam case</li>
  <li>Remove assets</li>
  <li>Add more logs</li>
  <li>Remove iphone 6 warning</li>
  <li>Merge branch 'master' into notifications</li>
  <li>Improve price alerts</li>
  <li>Add market price alerts</li>
  <li>Add download link. Filter own offers</li>
  <li>Improve texts</li>
  <li>Merge branch 'master' into notifications</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/148/files#diff-0">build.gradle</a>
    (9)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/148/files#diff-1">src/main/java/bisq/core/CoreModule.java</a>
    (19)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/148/files#diff-2">src/main/java/bisq/core/app/BisqEnvironment.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/148/files#diff-3">src/main/java/bisq/core/app/BisqSetup.java</a>
    (33)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/148/files#diff-4">src/main/java/bisq/core/arbitration/messages/DisputeCommunicationMessage.java</a>
    (5)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/148/files#diff-5">src/main/java/bisq/core/btc/BitcoinModule.java</a>
    (6)
  </li>
  <li>
    <strong>A</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/148/files#diff-6">src/main/java/bisq/core/notifications/MobileMessage.java</a>
    (53)
  </li>
  <li>
    <strong>A</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/148/files#diff-7">src/main/java/bisq/core/notifications/MobileMessageEncryption.java</a>
    (78)
  </li>
  <li>
    <strong>A</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/148/files#diff-8">src/main/java/bisq/core/notifications/MobileMessageType.java</a>
    (28)
  </li>
  <li>
    <strong>A</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/148/files#diff-9">src/main/java/bisq/core/notifications/MobileModel.java</a>
    (147)
  </li>
  <li>
    <strong>A</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/148/files#diff-10">src/main/java/bisq/core/notifications/MobileNotificationService.java</a>
    (253)
  </li>
  <li>
    <strong>A</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/148/files#diff-11">src/main/java/bisq/core/notifications/MobileNotificationValidator.java</a>
    (66)
  </li>
  <li>
    <strong>A</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/148/files#diff-12">src/main/java/bisq/core/notifications/alerts/DisputeMsgEvents.java</a>
    (107)
  </li>
  <li>
    <strong>A</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/148/files#diff-13">src/main/java/bisq/core/notifications/alerts/MyOfferTakenEvents.java</a>
    (79)
  </li>
  <li>
    <strong>A</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/148/files#diff-14">src/main/java/bisq/core/notifications/alerts/TradeEvents.java</a>
    (127)
  </li>
  <li>
    <strong>A</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/148/files#diff-15">src/main/java/bisq/core/notifications/alerts/market/MarketAlertFilter.java</a>
    (107)
  </li>
  <li>
    <strong>A</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/148/files#diff-16">src/main/java/bisq/core/notifications/alerts/market/MarketAlerts.java</a>
    (216)
  </li>
  <li>
    <strong>A</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/148/files#diff-17">src/main/java/bisq/core/notifications/alerts/price/PriceAlert.java</a>
    (102)
  </li>
  <li>
    <strong>A</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/148/files#diff-18">src/main/java/bisq/core/notifications/alerts/price/PriceAlertFilter.java</a>
    (54)
  </li>
  <li>
    <strong>A</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/148/files#diff-19">src/main/java/bisq/core/provider/PriceNodeHttpClient.java</a>
    (32)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/148/files#diff-20">src/main/java/bisq/core/provider/fee/FeeProvider.java</a>
    (5)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/148/files#diff-21">src/main/java/bisq/core/provider/price/PriceFeedService.java</a>
    (3)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/148/files#diff-22">src/main/java/bisq/core/user/Preferences.java</a>
    (35)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/148/files#diff-23">src/main/java/bisq/core/user/PreferencesPayload.java</a>
    (21)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/148/files#diff-24">src/main/java/bisq/core/user/User.java</a>
    (53)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/148/files#diff-25">src/main/java/bisq/core/user/UserPayload.java</a>
    (16)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/148/files#diff-26">src/main/java/bisq/core/util/BSFormatter.java</a>
    (22)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/148/files#diff-27">src/main/resources/i18n/displayStrings.properties</a>
    (75)
  </li>
  <li>
    <strong>A</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/148/files#diff-28">src/test/java/bisq/core/notifications/MobileModelTest.java</a>
    (84)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/bisq-network/bisq-core/pull/148.patch'>https://github.com/bisq-network/bisq-core/pull/148.patch</a></li>
  <li><a href='https://github.com/bisq-network/bisq-core/pull/148.diff'>https://github.com/bisq-network/bisq-core/pull/148.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq-core/pull/148">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtvwoHZjgrICopnTyV4BvI3mZIziaks5uRBcWgaJpZM4V-CpW">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtuTRIOs5WcxbhmXnyzqUhUQktltXks5uRBcWgaJpZM4V-CpW.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq-core","title":"bisq-network/bisq-core","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq-core"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Add mobile notifications (#148)"}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq-core/pull/148"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq-core/pull/148",
"url": "https://github.com/bisq-network/bisq-core/pull/148",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Add mobile notifications (#148)",
"sections": [
{
"text": "",
"activityTitle": "**Manfred Karrer**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@ManfredKarrer",
"facts": [

]
},
{
"title": "Commit Summary",
"facts": [
{
"name": "baa2e14",
"value": "Add mobile notification domain"
},
{
"name": "198e52b",
"value": "Add notifications for offers, trades and disputes"
},
{
"name": "c735878",
"value": "Merge branch 'master' into notifications"
},
{
"name": "b0bdf1d",
"value": "Add JavaFXWebcam window"
},
{
"name": "b0a2833",
"value": "Improve UI, fix productionMode"
},
{
"name": "822b9c9",
"value": "Rename msg fields"
},
{
"name": "a4f6b6c",
"value": "Add price alerts"
},
{
"name": "ce96655",
"value": "Remove ptext"
},
{
"name": "0333e01",
"value": "Add testMsg for all types"
},
{
"name": "fb9945a",
"value": "Add market alert domain"
},
{
"name": "834c6dc",
"value": "Cleanup logs"
},
{
"name": "7768e22",
"value": "Remove dev code"
},
{
"name": "9b8a0e7",
"value": "Add descriptor"
},
{
"name": "b4436ff",
"value": "Add tests"
},
{
"name": "bcc70f5",
"value": "Remove dev code"
},
{
"name": "2ec7daf",
"value": "Merge branch 'master' into notifications"
},
{
"name": "d50f8dc",
"value": "Set onion address"
},
{
"name": "2c5859f",
"value": "Merge remote-tracking branch 'ManfredKarrer/notifications' into notifications"
},
{
"name": "c167775",
"value": "Add clearnet relay address"
},
{
"name": "b4c0b84",
"value": "Remove space"
},
{
"name": "c2aba88",
"value": "Merge branch 'master' into notifications"
},
{
"name": "8af4234",
"value": "Cleanups"
},
{
"name": "3f42f61",
"value": "Cleanups"
},
{
"name": "409d328",
"value": "Prepare for custom binary:"
},
{
"name": "2a4bde8",
"value": "Handle no-webcam case"
},
{
"name": "6455374",
"value": "Remove assets"
},
{
"name": "561c51b",
"value": "Add more logs"
},
{
"name": "82b5167",
"value": "Remove iphone 6 warning"
},
{
"name": "3dc9308",
"value": "Merge branch 'master' into notifications"
},
{
"name": "9deb7a4",
"value": "Improve price alerts"
},
{
"name": "9b9ae1b",
"value": "Add market price alerts"
},
{
"name": "7468159",
"value": "Add download link. Filter own offers"
},
{
"name": "15d9c8a",
"value": "Improve texts"
},
{
"name": "61345bf",
"value": "Merge branch 'master' into notifications"
}
]
},
{
"title": "File Changes",
"facts": [
{
"name": "Modified",
"value": "[build.gradle](https://github.com/bisq-network/bisq-core/pull/148/files#diff-0) (9 changes)"
},
{
"name": "Modified",
"value": "[src/main/java/bisq/core/CoreModule.java](https://github.com/bisq-network/bisq-core/pull/148/files#diff-1) (19 changes)"
},
{
"name": "Modified",
"value": "[src/main/java/bisq/core/app/BisqEnvironment.java](https://github.com/bisq-network/bisq-core/pull/148/files#diff-2) (2 changes)"
},
{
"name": "Modified",
"value": "[src/main/java/bisq/core/app/BisqSetup.java](https://github.com/bisq-network/bisq-core/pull/148/files#diff-3) (33 changes)"
},
{
"name": "Modified",
"value": "[src/main/java/bisq/core/arbitration/messages/DisputeCommunicationMessage.java](https://github.com/bisq-network/bisq-core/pull/148/files#diff-4) (5 changes)"
},
{
"name": "Modified",
"value": "[src/main/java/bisq/core/btc/BitcoinModule.java](https://github.com/bisq-network/bisq-core/pull/148/files#diff-5) (6 changes)"
},
{
"name": "Added",
"value": "[src/main/java/bisq/core/notifications/MobileMessage.java](https://github.com/bisq-network/bisq-core/pull/148/files#diff-6) (53 changes)"
},
{
"name": "Added",
"value": "[src/main/java/bisq/core/notifications/MobileMessageEncryption.java](https://github.com/bisq-network/bisq-core/pull/148/files#diff-7) (78 changes)"
},
{
"name": "Added",
"value": "[src/main/java/bisq/core/notifications/MobileMessageType.java](https://github.com/bisq-network/bisq-core/pull/148/files#diff-8) (28 changes)"
},
{
"name": "Added",
"value": "[src/main/java/bisq/core/notifications/MobileModel.java](https://github.com/bisq-network/bisq-core/pull/148/files#diff-9) (147 changes)"
},
{
"name": "Added",
"value": "[src/main/java/bisq/core/notifications/MobileNotificationService.java](https://github.com/bisq-network/bisq-core/pull/148/files#diff-10) (253 changes)"
},
{
"name": "Added",
"value": "[src/main/java/bisq/core/notifications/MobileNotificationValidator.java](https://github.com/bisq-network/bisq-core/pull/148/files#diff-11) (66 changes)"
},
{
"name": "Added",
"value": "[src/main/java/bisq/core/notifications/alerts/DisputeMsgEvents.java](https://github.com/bisq-network/bisq-core/pull/148/files#diff-12) (107 changes)"
},
{
"name": "Added",
"value": "[src/main/java/bisq/core/notifications/alerts/MyOfferTakenEvents.java](https://github.com/bisq-network/bisq-core/pull/148/files#diff-13) (79 changes)"
},
{
"name": "Added",
"value": "[src/main/java/bisq/core/notifications/alerts/TradeEvents.java](https://github.com/bisq-network/bisq-core/pull/148/files#diff-14) (127 changes)"
},
{
"name": "Added",
"value": "[src/main/java/bisq/core/notifications/alerts/market/MarketAlertFilter.java](https://github.com/bisq-network/bisq-core/pull/148/files#diff-15) (107 changes)"
},
{
"name": "Added",
"value": "[src/main/java/bisq/core/notifications/alerts/market/MarketAlerts.java](https://github.com/bisq-network/bisq-core/pull/148/files#diff-16) (216 changes)"
},
{
"name": "Added",
"value": "[src/main/java/bisq/core/notifications/alerts/price/PriceAlert.java](https://github.com/bisq-network/bisq-core/pull/148/files#diff-17) (102 changes)"
},
{
"name": "Added",
"value": "[src/main/java/bisq/core/notifications/alerts/price/PriceAlertFilter.java](https://github.com/bisq-network/bisq-core/pull/148/files#diff-18) (54 changes)"
},
{
"name": "Added",
"value": "[src/main/java/bisq/core/provider/PriceNodeHttpClient.java](https://github.com/bisq-network/bisq-core/pull/148/files#diff-19) (32 changes)"
},
{
"name": "Modified",
"value": "[src/main/java/bisq/core/provider/fee/FeeProvider.java](https://github.com/bisq-network/bisq-core/pull/148/files#diff-20) (5 changes)"
},
{
"name": "Modified",
"value": "[src/main/java/bisq/core/provider/price/PriceFeedService.java](https://github.com/bisq-network/bisq-core/pull/148/files#diff-21) (3 changes)"
},
{
"name": "Modified",
"value": "[src/main/java/bisq/core/user/Preferences.java](https://github.com/bisq-network/bisq-core/pull/148/files#diff-22) (35 changes)"
},
{
"name": "Modified",
"value": "[src/main/java/bisq/core/user/PreferencesPayload.java](https://github.com/bisq-network/bisq-core/pull/148/files#diff-23) (21 changes)"
},
{
"name": "Modified",
"value": "[src/main/java/bisq/core/user/User.java](https://github.com/bisq-network/bisq-core/pull/148/files#diff-24) (53 changes)"
},
{
"name": "Modified",
"value": "[src/main/java/bisq/core/user/UserPayload.java](https://github.com/bisq-network/bisq-core/pull/148/files#diff-25) (16 changes)"
},
{
"name": "Modified",
"value": "[src/main/java/bisq/core/util/BSFormatter.java](https://github.com/bisq-network/bisq-core/pull/148/files#diff-26) (22 changes)"
},
{
"name": "Modified",
"value": "[src/main/resources/i18n/displayStrings.properties](https://github.com/bisq-network/bisq-core/pull/148/files#diff-27) (75 changes)"
},
{
"name": "Added",
"value": "[src/test/java/bisq/core/notifications/MobileModelTest.java](https://github.com/bisq-network/bisq-core/pull/148/files#diff-28) (84 changes)"
}
]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"bisq-network/bisq-core\",\n\"issueId\": 148,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"bisq-network/bisq-core\",\n\"pullRequestId\": 148\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq-core/pull/148"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq-core/pull/148.patch"
}
],
"@type": "OpenUri",
"name": "View patch"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq-core/pull/148.diff"
}
],
"@type": "OpenUri",
"name": "View diff"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 368585302\n}"
}
],
"themeColor": "26292E"
}
]</script>