<p>Hello!</p>
<p>I saw a comment that <code>applyLatestBisqMarketPrice</code> can take some time and refactored it using parallel streams. So (in theory) it can perform calculation routines faster. State of <code>PriceFeedService</code> is updated in old way because the class is not thread-safe.</p>
<p>If the idea of parrallel streams is bad, implemented unit test can be kept anyway and this branch (with implementation of fallback to ordinary streams) can still be considered as cleanup attempt.</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/bisq-network/bisq-core/pull/149'>https://github.com/bisq-network/bisq-core/pull/149</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>initial refactoring</li>
  <li>implemented unit test for PriceFeedService#applyLatestBisqMarketPrice()</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/149/files#diff-0">src/main/java/bisq/core/provider/price/PriceFeedService.java</a>
    (68)
  </li>
  <li>
    <strong>A</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/149/files#diff-1">src/test/java/bisq/core/provider/price/PriceFeedServiceTest.java</a>
    (67)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/bisq-network/bisq-core/pull/149.patch'>https://github.com/bisq-network/bisq-core/pull/149.patch</a></li>
  <li><a href='https://github.com/bisq-network/bisq-core/pull/149.diff'>https://github.com/bisq-network/bisq-core/pull/149.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq-core/pull/149">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtuwxDOQDeNveiiL36O9kzi-RMOqPks5uRCp-gaJpZM4V-KR7">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtgcjLiTCI4Au3kC3ozG3oEa47UEiks5uRCp-gaJpZM4V-KR7.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq-core","title":"bisq-network/bisq-core","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq-core"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"PriceFeedService#applyLatestPrice() refactoring (#149)"}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq-core/pull/149"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq-core/pull/149",
"url": "https://github.com/bisq-network/bisq-core/pull/149",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "PriceFeedService#applyLatestPrice() refactoring (#149)",
"sections": [
{
"text": "",
"activityTitle": "**tau3**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@tau3",
"facts": [

]
},
{
"title": "Commit Summary",
"facts": [
{
"name": "ebaa049",
"value": "initial refactoring"
},
{
"name": "0054211",
"value": "implemented unit test for PriceFeedService#applyLatestBisqMarketPrice()"
}
]
},
{
"title": "File Changes",
"facts": [
{
"name": "Modified",
"value": "[src/main/java/bisq/core/provider/price/PriceFeedService.java](https://github.com/bisq-network/bisq-core/pull/149/files#diff-0) (68 changes)"
},
{
"name": "Added",
"value": "[src/test/java/bisq/core/provider/price/PriceFeedServiceTest.java](https://github.com/bisq-network/bisq-core/pull/149/files#diff-1) (67 changes)"
}
]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"bisq-network/bisq-core\",\n\"issueId\": 149,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"bisq-network/bisq-core\",\n\"pullRequestId\": 149\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq-core/pull/149"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq-core/pull/149.patch"
}
],
"@type": "OpenUri",
"name": "View patch"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq-core/pull/149.diff"
}
],
"@type": "OpenUri",
"name": "View diff"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 368616571\n}"
}
],
"themeColor": "26292E"
}
]</script>