<p><b>@ripcurlx</b> requested changes on this pull request.</p>

<p>Please reset the version and naming used for the local test build. Besides that utACK</p><hr>

<p>In <a href="https://github.com/bisq-network/bisq-desktop/pull/1624#discussion_r210256297">build.gradle</a>:</p>
<pre style='color:#555'>> @@ -15,7 +16,7 @@ apply plugin: 'witness'
 apply plugin: 'com.github.johnrengelman.shadow'
 
 group = 'network.bisq'
-version = '0.7.1-SNAPSHOT'
+version = '0.8.0'
</pre>
<p>Shouldn't we only do this during the release?</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq-desktop/pull/1624#discussion_r210256464">build.gradle</a>:</p>
<pre style='color:#555'>>      jcenter()
     maven { url 'https://jitpack.io' }
     maven { url 'https://raw.githubusercontent.com/JesusMcCloud/tor-binary/master/release/' }
     maven { url 'https://dl.bintray.com/jerady/maven' }
 }
 
 dependencies {
-    compile 'network.bisq:bisq-p2p:-SNAPSHOT'
-    compile 'network.bisq:bisq-core:-SNAPSHOT'
-    compile 'network.bisq:bisq-common:-SNAPSHOT'
+    compile 'network.bisq:bisq-p2p:0.8.0'
+    compile 'network.bisq:bisq-core:0.8.0'
+    compile 'network.bisq:bisq-common:0.8.0'
</pre>
<p>Same here: I think this should be -SNAPSHOT when merging</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq-desktop/pull/1624#discussion_r210256584">build.gradle</a>:</p>
<pre style='color:#555'>> @@ -33,25 +34,29 @@ tasks.withType(JavaCompile) {
 sourceSets.main.resources.srcDirs += ['src/main/java'] // to copy fxml and css files
 
 repositories {
+    mavenLocal()
</pre>
<p>Was this only for testing purposes locally?</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq-desktop/pull/1624#discussion_r210257225">package/osx/create_app.sh</a>:</p>
<pre style='color:#555'>> @@ -82,18 +82,18 @@ $JAVA_HOME/bin/javapackager \
     -Bicon=package/osx/Bisq.icns \
     -Bruntime="$JAVA_HOME/jre" \
     -native dmg \
-    -name Bisq \
-    -title Bisq \
+    -name Bisq_notifications \
+    -title Bisq_notifications \
</pre>
<p>Also shouldn't be changed here</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq-desktop/pull/1624#pullrequestreview-146430489">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtifYlgyulJKl1CfX4wHDeHAqUpb3ks5uRBlugaJpZM4V-CqZ">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZttvECXQ1kceCNJ7ywIImtshhNK0Jks5uRBlugaJpZM4V-CqZ.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq-desktop","title":"bisq-network/bisq-desktop","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq-desktop"}},"updates":{"snippets":[{"icon":"PERSON","message":"@ripcurlx requested changes on #1624"}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq-desktop/pull/1624#pullrequestreview-146430489"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq-desktop/pull/1624#pullrequestreview-146430489",
"url": "https://github.com/bisq-network/bisq-desktop/pull/1624#pullrequestreview-146430489",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "@ripcurlx requested changes on 1624",
"sections": [
{
"text": "Please reset the version and naming used for the local test build. Besides that utACK",
"activityTitle": "**Christoph Atteneder**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@ripcurlx",
"facts": [

]
}
],
"potentialAction": [
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq-desktop/pull/1624#pullrequestreview-146430489"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 368585369\n}"
}
],
"themeColor": "26292E"
}
]</script>