<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/bisq-network/bisq-common/pull/34'>https://github.com/bisq-network/bisq-common/pull/34</a></p>
<h4>Commit Summary</h4>
<ul>
<li>Improvements for blind vote publishing</li>
<li>Renaming</li>
<li>Remove RevealedVote</li>
<li>Refactor proposal domain and make it more thread safe</li>
<li>Merge branch 'master_origin' into voting</li>
<li>Remove mutable fields of Tx, TxOutput and TxInput in PB definition</li>
<li>Refactorings (WIP)</li>
<li>Improve comment. Use Lombok.</li>
<li>Refactor handling of blocks in state class.</li>
<li>Rename ChangeParamEvent to AddChangeParamEvent</li>
<li>Remove ChangeParamEventList (WIP)</li>
<li>Merge branch 'master_origin'</li>
<li>Merge branch 'master' into voting</li>
<li>Change threading behaviour of ThreadContextAwareListeners</li>
<li>Refactor state</li>
<li>Add comments</li>
<li>Rename Proposal to Ballot and ProposalPayload to Proposal</li>
<li>Split BlindVote in BlindVote and BlindVotePayload</li>
<li>Rename classed with term CompensationRequest to Compensation</li>
<li>Split Proposal into Proposal and ProposalPayload</li>
<li>Merge branch 'master' into voting</li>
<li>Add option key daoActivated to enable all dao features for dev</li>
<li>Rename state change event classes</li>
<li>Move bisq.core.dao.consensus.vote.myvote package to bisq.core.dao</li>
<li>Remove usage of PeriodServiceFacade and ThreadAwareListener</li>
<li>Merge branch 'rpc_thread' into voting</li>
<li>Cleanup</li>
<li>Cleanup protobuffer file</li>
<li>Add PB definition for State, Block and TxBlock</li>
<li>Add Cycle, PhaseWrapper and chainHeight and cycles in State to PB definitions</li>
<li>Remove Meta data from block.</li>
<li>Refactor ParamChange domain</li>
<li>Store only proposal TxId + vote instead of whole ballot in BlindVote</li>
<li>Use single threaded executor for rpc service</li>
<li>Add AccountAgeWitnessMap</li>
<li>Use a list in PB for AccountAgeWitnessStore for reducing disk space (no map with hash)</li>
<li>Merge branch 'storage-provider' into voting</li>
<li>Add append-only storage for Proposal and BlindVote (WIP)</li>
<li>Update to merged changes from p2p network. Renaming</li>
<li>Add protected data storage for proposal and blind vote</li>
<li>Let proposal domain handle all its relevant use cases</li>
<li>Remove unneeded Ballot subclasses</li>
<li>Refactor handling of lists in BlindVote</li>
<li>Use BlockHash and data for append-only store</li>
<li>Merge master</li>
<li>Merge branch 'master' into voting</li>
<li>Merge branch 'refactoring-mainviewmodel' into api-integration</li>
<li>Merge branch 'master' into voting</li>
<li>Remove protectedDataStore at blindVote</li>
<li>Renaming payloads and stores</li>
<li>Support merit (WIP)</li>
<li>Merge branch 'api-integration' into voting</li>
<li>Merge branch 'voting' into merit</li>
<li>Add merit implementation</li>
<li>Merge branch 'merit' into voting</li>
<li>Add lockup version</li>
<li>Add locktime, unlock_block_height to protobuf</li>
<li>Merge pull request #1 from sqrrm/bonding</li>
<li>Merge branch 'master' into voting</li>
<li>Update gradle files</li>
<li>Add options to DevEnv. Cleanup</li>
<li>Refactor mutable data handling in State</li>
<li>Refactor MutableTx and MutableTxOutput</li>
<li>Apply fixes to stateService</li>
<li>Remove date and blockHash from ProposalPayload</li>
<li>Use name instead of ordinal for PB ParamChangeMap</li>
<li>Add param request</li>
<li>Rename</li>
<li>Add PB support for changeParamProposal</li>
<li>Change param map in state</li>
<li>Merge branch 'master' into voting</li>
<li>Show bond info, cleanups, handle non-BSQ funds</li>
<li>Add burn bond proposal</li>
<li>Burn bonds when proposal is accepted</li>
<li>Rename burn bond to confiscate bond</li>
<li>Merge pull request #2 from sqrrm/dao</li>
<li>Changes from review of bond confiscation PR</li>
<li>Add BondedRoles proposal and views</li>
<li>Merge branch 'master' into voting</li>
<li>Add EqualsAndHashCode to PersistableLists</li>
<li>Remvoe title and description from Proposal</li>
<li>Merge branch 'refact-generics' into voting</li>
<li>Update BsqState in PB, reorder fields</li>
<li>Refactor Tx classes</li>
<li>Refactor TxOutput and Block classes</li>
<li>Refactoring</li>
<li>Use DevEnv.logErrorAndThrowIfDevMode</li>
<li>Remove uid from Proposal</li>
<li>Remove BooleanVote and LongVote.</li>
<li>Change version from -SNAPSHOT to 0.9.0</li>
<li>Move genesis data from BsqState to GenesisTxInfo</li>
<li>Merge branch 'master' into voting</li>
<li>Merge branch 'voting'</li>
<li>Merge branch 'master' into voting</li>
<li>Merge branch 'master' of https://github.com/bisq-network/bisq-common</li>
<li>Merge branch 'master' into merged-voting</li>
</ul>
<h4>File Changes</h4>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq-common/pull/34/files#diff-0">src/main/java/bisq/common/app/Version.java</a>
(7)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq-common/pull/34/files#diff-1">src/main/java/bisq/common/proto/ProtoUtil.java</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq-common/pull/34/files#diff-2">src/main/java/bisq/common/proto/persistable/PersistableList.java</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq-common/pull/34/files#diff-3">src/main/java/bisq/common/storage/Storage.java</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq-common/pull/34/files#diff-4">src/main/java/bisq/common/util/Utilities.java</a>
(17)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq-common/pull/34/files#diff-5">src/main/proto/pb.proto</a>
(522)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/bisq-network/bisq-common/pull/34/files#diff-6">src/test/java/bisq/common/util/UtilitiesTest.java</a>
(26)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/bisq-network/bisq-common/pull/34.patch'>https://github.com/bisq-network/bisq-common/pull/34.patch</a></li>
<li><a href='https://github.com/bisq-network/bisq-common/pull/34.diff'>https://github.com/bisq-network/bisq-common/pull/34.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq-common/pull/34">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZthZZqt6eGCtZ26HDxinANFfIG0aeks5uRDOGgaJpZM4V-Ojt">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtiUu6MKtvsqg8L7tpUlmd-Kuub_vks5uRDOGgaJpZM4V-Ojt.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq-common","title":"bisq-network/bisq-common","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq-common"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Add DAO code (#34)"}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq-common/pull/34"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq-common/pull/34",
"url": "https://github.com/bisq-network/bisq-common/pull/34",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Add DAO code (#34)",
"sections": [
{
"text": "",
"activityTitle": "**Manfred Karrer**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@ManfredKarrer",
"facts": [
]
},
{
"title": "Commit Summary",
"facts": [
{
"name": "86ce351",
"value": "Improvements for blind vote publishing"
},
{
"name": "016d3b7",
"value": "Renaming"
},
{
"name": "daae653",
"value": "Remove RevealedVote"
},
{
"name": "747e933",
"value": "Refactor proposal domain and make it more thread safe"
},
{
"name": "30e74c9",
"value": "Merge branch 'master_origin' into voting"
},
{
"name": "f0b1385",
"value": "Remove mutable fields of Tx, TxOutput and TxInput in PB definition"
},
{
"name": "d2d2d8a",
"value": "Refactorings (WIP)"
},
{
"name": "3970892",
"value": "Improve comment. Use Lombok."
},
{
"name": "b2c0171",
"value": "Refactor handling of blocks in state class."
},
{
"name": "1d2b608",
"value": "Rename ChangeParamEvent to AddChangeParamEvent"
},
{
"name": "2528bc4",
"value": "Remove ChangeParamEventList (WIP)"
},
{
"name": "b4a56b9",
"value": "Merge branch 'master_origin'"
},
{
"name": "e60b972",
"value": "Merge branch 'master' into voting"
},
{
"name": "788e227",
"value": "Change threading behaviour of ThreadContextAwareListeners"
},
{
"name": "ebe53eb",
"value": "Refactor state"
},
{
"name": "f108351",
"value": "Add comments"
},
{
"name": "c302c3f",
"value": "Rename Proposal to Ballot and ProposalPayload to Proposal"
},
{
"name": "ac58192",
"value": "Split BlindVote in BlindVote and BlindVotePayload"
},
{
"name": "97b4c73",
"value": "Rename classed with term CompensationRequest to Compensation"
},
{
"name": "2ebe51e",
"value": "Split Proposal into Proposal and ProposalPayload"
},
{
"name": "ed29522",
"value": "Merge branch 'master' into voting"
},
{
"name": "9a3e001",
"value": "Add option key daoActivated to enable all dao features for dev"
},
{
"name": "735ce9c",
"value": "Rename state change event classes"
},
{
"name": "7bb2886",
"value": "Move bisq.core.dao.consensus.vote.myvote package to bisq.core.dao"
},
{
"name": "df65292",
"value": "Remove usage of PeriodServiceFacade and ThreadAwareListener"
},
{
"name": "3909c31",
"value": "Merge branch 'rpc_thread' into voting"
},
{
"name": "5822e6d",
"value": "Cleanup"
},
{
"name": "7e41b5a",
"value": "Cleanup protobuffer file"
},
{
"name": "37b12de",
"value": "Add PB definition for State, Block and TxBlock"
},
{
"name": "d7a7621",
"value": "Add Cycle, PhaseWrapper and chainHeight and cycles in State to PB definitions"
},
{
"name": "2b9ed0b",
"value": "Remove Meta data from block."
},
{
"name": "3483807",
"value": "Refactor ParamChange domain"
},
{
"name": "5fd8683",
"value": "Store only proposal TxId + vote instead of whole ballot in BlindVote"
},
{
"name": "086ed89",
"value": "Use single threaded executor for rpc service"
},
{
"name": "5645ddb",
"value": "Add AccountAgeWitnessMap"
},
{
"name": "9d498d7",
"value": "Use a list in PB for AccountAgeWitnessStore for reducing disk space (no map with hash)"
},
{
"name": "cefed85",
"value": "Merge branch 'storage-provider' into voting"
},
{
"name": "9afe8e5",
"value": "Add append-only storage for Proposal and BlindVote (WIP)"
},
{
"name": "af9f163",
"value": "Update to merged changes from p2p network. Renaming"
},
{
"name": "b308411",
"value": "Add protected data storage for proposal and blind vote"
},
{
"name": "72e016d",
"value": "Let proposal domain handle all its relevant use cases"
},
{
"name": "77adb37",
"value": "Remove unneeded Ballot subclasses"
},
{
"name": "39f6d2d",
"value": "Refactor handling of lists in BlindVote"
},
{
"name": "24129f6",
"value": "Use BlockHash and data for append-only store"
},
{
"name": "770a491",
"value": "Merge master"
},
{
"name": "5655740",
"value": "Merge branch 'master' into voting"
},
{
"name": "6859712",
"value": "Merge branch 'refactoring-mainviewmodel' into api-integration"
},
{
"name": "cb5b708",
"value": "Merge branch 'master' into voting"
},
{
"name": "25bccfe",
"value": "Remove protectedDataStore at blindVote"
},
{
"name": "c86bc0c",
"value": "Renaming payloads and stores"
},
{
"name": "640b960",
"value": "Support merit (WIP)"
},
{
"name": "b42fbae",
"value": "Merge branch 'api-integration' into voting"
},
{
"name": "04bc6bf",
"value": "Merge branch 'voting' into merit"
},
{
"name": "a4dee48",
"value": "Add merit implementation"
},
{
"name": "aeadc3c",
"value": "Merge branch 'merit' into voting"
},
{
"name": "29c3610",
"value": "Add lockup version"
},
{
"name": "b2e56e8",
"value": "Add locktime, unlock_block_height to protobuf"
},
{
"name": "afed2e4",
"value": "Merge pull request #1 from sqrrm/bonding"
},
{
"name": "4c2b979",
"value": "Merge branch 'master' into voting"
},
{
"name": "1b17629",
"value": "Update gradle files"
},
{
"name": "f19f031",
"value": "Add options to DevEnv. Cleanup"
},
{
"name": "197e6e4",
"value": "Refactor mutable data handling in State"
},
{
"name": "6dd6e0f",
"value": "Refactor MutableTx and MutableTxOutput"
},
{
"name": "4208514",
"value": "Apply fixes to stateService"
},
{
"name": "ccc5340",
"value": "Remove date and blockHash from ProposalPayload"
},
{
"name": "950bf71",
"value": "Use name instead of ordinal for PB ParamChangeMap"
},
{
"name": "71075d0",
"value": "Add param request"
},
{
"name": "bf413d5",
"value": "Rename"
},
{
"name": "b52cc3c",
"value": "Add PB support for changeParamProposal"
},
{
"name": "75680f1",
"value": "Change param map in state"
},
{
"name": "b713969",
"value": "Merge branch 'master' into voting"
},
{
"name": "e564778",
"value": "Show bond info, cleanups, handle non-BSQ funds"
},
{
"name": "239484b",
"value": "Add burn bond proposal"
},
{
"name": "bb702d2",
"value": "Burn bonds when proposal is accepted"
},
{
"name": "84be256",
"value": "Rename burn bond to confiscate bond"
},
{
"name": "35ae495",
"value": "Merge pull request #2 from sqrrm/dao"
},
{
"name": "92778a2",
"value": "Changes from review of bond confiscation PR"
},
{
"name": "928e5f9",
"value": "Add BondedRoles proposal and views"
},
{
"name": "a4eda3b",
"value": "Merge branch 'master' into voting"
},
{
"name": "c399c05",
"value": "Add EqualsAndHashCode to PersistableLists"
},
{
"name": "57a3fa9",
"value": "Remvoe title and description from Proposal"
},
{
"name": "b28a1e1",
"value": "Merge branch 'refact-generics' into voting"
},
{
"name": "bd9cb15",
"value": "Update BsqState in PB, reorder fields"
},
{
"name": "81db1de",
"value": "Refactor Tx classes"
},
{
"name": "d278067",
"value": "Refactor TxOutput and Block classes"
},
{
"name": "f05a1b0",
"value": "Refactoring"
},
{
"name": "fa31c11",
"value": "Use DevEnv.logErrorAndThrowIfDevMode"
},
{
"name": "c1dee68",
"value": "Remove uid from Proposal"
},
{
"name": "5d35af9",
"value": "Remove BooleanVote and LongVote."
},
{
"name": "06b9370",
"value": "Change version from -SNAPSHOT to 0.9.0"
},
{
"name": "6e2fee1",
"value": "Move genesis data from BsqState to GenesisTxInfo"
},
{
"name": "b3929f6",
"value": "Merge branch 'master' into voting"
},
{
"name": "f6fc1fd",
"value": "Merge branch 'voting'"
},
{
"name": "89ff8fa",
"value": "Merge branch 'master' into voting"
},
{
"name": "f3939f0",
"value": "Merge branch 'master' of https://github.com/bisq-network/bisq-common"
},
{
"name": "88bb79c",
"value": "Merge branch 'master' into merged-voting"
}
]
},
{
"title": "File Changes",
"facts": [
{
"name": "Modified",
"value": "[src/main/java/bisq/common/app/Version.java](https://github.com/bisq-network/bisq-common/pull/34/files#diff-0) (7 changes)"
},
{
"name": "Modified",
"value": "[src/main/java/bisq/common/proto/ProtoUtil.java](https://github.com/bisq-network/bisq-common/pull/34/files#diff-1) (4 changes)"
},
{
"name": "Modified",
"value": "[src/main/java/bisq/common/proto/persistable/PersistableList.java](https://github.com/bisq-network/bisq-common/pull/34/files#diff-2) (2 changes)"
},
{
"name": "Modified",
"value": "[src/main/java/bisq/common/storage/Storage.java](https://github.com/bisq-network/bisq-common/pull/34/files#diff-3) (2 changes)"
},
{
"name": "Modified",
"value": "[src/main/java/bisq/common/util/Utilities.java](https://github.com/bisq-network/bisq-common/pull/34/files#diff-4) (17 changes)"
},
{
"name": "Modified",
"value": "[src/main/proto/pb.proto](https://github.com/bisq-network/bisq-common/pull/34/files#diff-5) (522 changes)"
},
{
"name": "Modified",
"value": "[src/test/java/bisq/common/util/UtilitiesTest.java](https://github.com/bisq-network/bisq-common/pull/34/files#diff-6) (26 changes)"
}
]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"bisq-network/bisq-common\",\n\"issueId\": 34,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"bisq-network/bisq-common\",\n\"pullRequestId\": 34\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq-common/pull/34"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq-common/pull/34.patch"
}
],
"@type": "OpenUri",
"name": "View patch"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq-common/pull/34.diff"
}
],
"@type": "OpenUri",
"name": "View diff"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 368634093\n}"
}
],
"themeColor": "26292E"
}
]</script>