<p>Depends on:<br>
<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="352660085" data-permission-text="Issue title is private" data-url="https://github.com/bisq-network/bisq-common/issues/37" href="https://github.com/bisq-network/bisq-common/pull/37">bisq-network/bisq-common#37</a></p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/bisq-network/bisq-core/pull/165'>https://github.com/bisq-network/bisq-core/pull/165</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Merged master</li>
  <li>Remove onTimeout at TxBroadcast callback</li>
  <li>Set depositTx at success handler</li>
  <li>Let onTimeout call on onSuccess instead of onFailure</li>
  <li>Increase broadcast timeout to 20 sec</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/165/files#diff-0">src/main/java/bisq/core/btc/wallet/TxBroadcastTimeoutException.java</a>
    (16)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/165/files#diff-1">src/main/java/bisq/core/btc/wallet/TxBroadcaster.java</a>
    (50)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/165/files#diff-2">src/main/java/bisq/core/dao/bonding/lockup/LockupService.java</a>
    (6)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/165/files#diff-3">src/main/java/bisq/core/dao/bonding/unlock/UnlockService.java</a>
    (6)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/165/files#diff-4">src/main/java/bisq/core/dao/governance/blindvote/MyBlindVoteListService.java</a>
    (10)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/165/files#diff-5">src/main/java/bisq/core/dao/governance/proposal/MyProposalListService.java</a>
    (7)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/165/files#diff-6">src/main/java/bisq/core/dao/governance/votereveal/VoteRevealService.java</a>
    (9)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/165/files#diff-7">src/main/java/bisq/core/trade/protocol/tasks/buyer_as_taker/BuyerAsTakerSignAndPublishDepositTx.java</a>
    (8)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/165/files#diff-8">src/main/java/bisq/core/trade/protocol/tasks/seller_as_taker/SellerAsTakerSignAndPublishDepositTx.java</a>
    (8)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/bisq-network/bisq-core/pull/165.patch'>https://github.com/bisq-network/bisq-core/pull/165.patch</a></li>
  <li><a href='https://github.com/bisq-network/bisq-core/pull/165.diff'>https://github.com/bisq-network/bisq-core/pull/165.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq-core/pull/165">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtgO20Kyq3xcPIeo_ffMfMXTyrIyHks5uTFLogaJpZM4WGXuM">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtuUPXJdOkK9LnG0zpUTWV34rq1uqks5uTFLogaJpZM4WGXuM.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq-core","title":"bisq-network/bisq-core","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq-core"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Fix broadcast issues (#165)"}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq-core/pull/165"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq-core/pull/165",
"url": "https://github.com/bisq-network/bisq-core/pull/165",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Fix broadcast issues (#165)",
"sections": [
{
"text": "",
"activityTitle": "**Manfred Karrer**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@ManfredKarrer",
"facts": [

]
},
{
"title": "Commit Summary",
"facts": [
{
"name": "8d74fee",
"value": "Merged master"
},
{
"name": "8c6021a",
"value": "Remove onTimeout at TxBroadcast callback"
},
{
"name": "b2ee5ed",
"value": "Set depositTx at success handler"
},
{
"name": "a0aecdf",
"value": "Let onTimeout call on onSuccess instead of onFailure"
},
{
"name": "3ff38d6",
"value": "Increase broadcast timeout to 20 sec"
}
]
},
{
"title": "File Changes",
"facts": [
{
"name": "Modified",
"value": "[src/main/java/bisq/core/btc/wallet/TxBroadcastTimeoutException.java](https://github.com/bisq-network/bisq-core/pull/165/files#diff-0) (16 changes)"
},
{
"name": "Modified",
"value": "[src/main/java/bisq/core/btc/wallet/TxBroadcaster.java](https://github.com/bisq-network/bisq-core/pull/165/files#diff-1) (50 changes)"
},
{
"name": "Modified",
"value": "[src/main/java/bisq/core/dao/bonding/lockup/LockupService.java](https://github.com/bisq-network/bisq-core/pull/165/files#diff-2) (6 changes)"
},
{
"name": "Modified",
"value": "[src/main/java/bisq/core/dao/bonding/unlock/UnlockService.java](https://github.com/bisq-network/bisq-core/pull/165/files#diff-3) (6 changes)"
},
{
"name": "Modified",
"value": "[src/main/java/bisq/core/dao/governance/blindvote/MyBlindVoteListService.java](https://github.com/bisq-network/bisq-core/pull/165/files#diff-4) (10 changes)"
},
{
"name": "Modified",
"value": "[src/main/java/bisq/core/dao/governance/proposal/MyProposalListService.java](https://github.com/bisq-network/bisq-core/pull/165/files#diff-5) (7 changes)"
},
{
"name": "Modified",
"value": "[src/main/java/bisq/core/dao/governance/votereveal/VoteRevealService.java](https://github.com/bisq-network/bisq-core/pull/165/files#diff-6) (9 changes)"
},
{
"name": "Modified",
"value": "[src/main/java/bisq/core/trade/protocol/tasks/buyer_as_taker/BuyerAsTakerSignAndPublishDepositTx.java](https://github.com/bisq-network/bisq-core/pull/165/files#diff-7) (8 changes)"
},
{
"name": "Modified",
"value": "[src/main/java/bisq/core/trade/protocol/tasks/seller_as_taker/SellerAsTakerSignAndPublishDepositTx.java](https://github.com/bisq-network/bisq-core/pull/165/files#diff-8) (8 changes)"
}
]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"bisq-network/bisq-core\",\n\"issueId\": 165,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"bisq-network/bisq-core\",\n\"pullRequestId\": 165\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq-core/pull/165"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq-core/pull/165.patch"
}
],
"@type": "OpenUri",
"name": "View patch"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq-core/pull/165.diff"
}
],
"@type": "OpenUri",
"name": "View diff"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 370768780\n}"
}
],
"themeColor": "26292E"
}
]</script>