<p>The issue was still not fixed with the latest changes as it has been shown in more tests. We reverted now completely the changes introduced in January 2018 as they did not improve the broadcast reliability but decreased it. It is still not understood why...</p>
<p>Depends on:<br>
<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="352718050" data-permission-text="Issue title is private" data-url="https://github.com/bisq-network/bisq-common/issues/38" href="https://github.com/bisq-network/bisq-common/pull/38">bisq-network/bisq-common#38</a></p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/bisq-network/bisq-core/pull/166'>https://github.com/bisq-network/bisq-core/pull/166</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Improve text</li>
  <li>Remove setBroadcastToAllPeers call on peerGroup</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/166/files#diff-0">src/main/java/bisq/core/btc/wallet/WalletConfig.java</a>
    (1)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/166/files#diff-1">src/main/resources/i18n/displayStrings.properties</a>
    (4)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/bisq-network/bisq-core/pull/166.patch'>https://github.com/bisq-network/bisq-core/pull/166.patch</a></li>
  <li><a href='https://github.com/bisq-network/bisq-core/pull/166.diff'>https://github.com/bisq-network/bisq-core/pull/166.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq-core/pull/166">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtqeO8rBauAdktVRzjtrq8c1PpaeBks5uTHwXgaJpZM4WGoJo">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtvdchsfUTEZL1MQAGisnXYkpHjV6ks5uTHwXgaJpZM4WGoJo.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq-core","title":"bisq-network/bisq-core","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq-core"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Fix tx broadcast issue (#166)"}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq-core/pull/166"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq-core/pull/166",
"url": "https://github.com/bisq-network/bisq-core/pull/166",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Fix tx broadcast issue (#166)",
"sections": [
{
"text": "",
"activityTitle": "**Manfred Karrer**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@ManfredKarrer",
"facts": [

]
},
{
"title": "Commit Summary",
"facts": [
{
"name": "645adc3",
"value": "Improve text"
},
{
"name": "4643131",
"value": "Remove setBroadcastToAllPeers call on peerGroup"
}
]
},
{
"title": "File Changes",
"facts": [
{
"name": "Modified",
"value": "[src/main/java/bisq/core/btc/wallet/WalletConfig.java](https://github.com/bisq-network/bisq-core/pull/166/files#diff-0) (1 changes)"
},
{
"name": "Modified",
"value": "[src/main/resources/i18n/displayStrings.properties](https://github.com/bisq-network/bisq-core/pull/166/files#diff-1) (4 changes)"
}
]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"bisq-network/bisq-core\",\n\"issueId\": 166,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"bisq-network/bisq-core\",\n\"pullRequestId\": 166\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq-core/pull/166"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq-core/pull/166.patch"
}
],
"@type": "OpenUri",
"name": "View patch"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq-core/pull/166.diff"
}
],
"@type": "OpenUri",
"name": "View diff"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 370836072\n}"
}
],
"themeColor": "26292E"
}
]</script>