<p>Check new blocks by hash, not just height.</p>
<p>Add basic BsqStateServiceTest class.</p>
<p>Currently only tests the isBlockHashKnown() method added in <a class="commit-link" href="https://github.com/bisq-network/bisq-core/commit/26842d106a59dafe01c74c1d37cf359d9dad344e"><tt>26842d1</tt></a>.</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/bisq-network/bisq-core/pull/167'>https://github.com/bisq-network/bisq-core/pull/167</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Check new blocks by hash, not just height</li>
  <li>Add basic BsqStateServiceTest class</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/167/files#diff-0">src/main/java/bisq/core/dao/node/parser/BlockParser.java</a>
    (4)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/167/files#diff-1">src/main/java/bisq/core/dao/state/BsqStateService.java</a>
    (13)
  </li>
  <li>
    <strong>A</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/167/files#diff-2">src/test/java/bisq/core/dao/state/BsqStateServiceTest.java</a>
    (68)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/bisq-network/bisq-core/pull/167.patch'>https://github.com/bisq-network/bisq-core/pull/167.patch</a></li>
  <li><a href='https://github.com/bisq-network/bisq-core/pull/167.diff'>https://github.com/bisq-network/bisq-core/pull/167.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq-core/pull/167">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtjUehTrv4NRyhOaAbGMTPGeaqHp3ks5uTXBOgaJpZM4WH0lu">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtozoTgTcLKSo9y21IIbeoC9BOcwhks5uTXBOgaJpZM4WH0lu.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq-core","title":"bisq-network/bisq-core","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq-core"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Check if we know about blocks by hash, not just height, add basic tests (#167)"}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq-core/pull/167"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq-core/pull/167",
"url": "https://github.com/bisq-network/bisq-core/pull/167",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Check if we know about blocks by hash, not just height, add basic tests (#167)",
"sections": [
{
"text": "",
"activityTitle": "**chirhonul**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@chirhonul",
"facts": [

]
},
{
"title": "Commit Summary",
"facts": [
{
"name": "26842d1",
"value": "Check new blocks by hash, not just height"
},
{
"name": "6857c3b",
"value": "Add basic BsqStateServiceTest class"
}
]
},
{
"title": "File Changes",
"facts": [
{
"name": "Modified",
"value": "[src/main/java/bisq/core/dao/node/parser/BlockParser.java](https://github.com/bisq-network/bisq-core/pull/167/files#diff-0) (4 changes)"
},
{
"name": "Modified",
"value": "[src/main/java/bisq/core/dao/state/BsqStateService.java](https://github.com/bisq-network/bisq-core/pull/167/files#diff-1) (13 changes)"
},
{
"name": "Added",
"value": "[src/test/java/bisq/core/dao/state/BsqStateServiceTest.java](https://github.com/bisq-network/bisq-core/pull/167/files#diff-2) (68 changes)"
}
]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"bisq-network/bisq-core\",\n\"issueId\": 167,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"bisq-network/bisq-core\",\n\"pullRequestId\": 167\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq-core/pull/167"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq-core/pull/167.patch"
}
],
"@type": "OpenUri",
"name": "View patch"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq-core/pull/167.diff"
}
],
"@type": "OpenUri",
"name": "View diff"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 371149166\n}"
}
],
"themeColor": "26292E"
}
]</script>