<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/bisq-network/bisq-core/pull/171'>https://github.com/bisq-network/bisq-core/pull/171</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Refactor OpReturnParser</li>
  <li>Refactor TxParser, TxOutputParser and ParsingModel</li>
  <li>Add processOpReturnType method</li>
  <li>Remove availableInputValue from ParsingModel</li>
  <li>Remove bsqOutputFound from ParsingModel</li>
  <li>Remove unlockBlockHeight from ParsingModel</li>
  <li>Remove tx from ParsingModel</li>
  <li>Remove spentLockupTxOutput from ParsingModel</li>
  <li>Remove ParsingModel</li>
  <li>Use connectedTxOutput for accessing lockTime instead of Tx</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/171/files#diff-0">src/main/java/bisq/core/dao/DaoModule.java</a>
    (14)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/171/files#diff-1">src/main/java/bisq/core/dao/bonding/BondingConsensus.java</a>
    (17)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/171/files#diff-2">src/main/java/bisq/core/dao/governance/blindvote/BlindVoteConsensus.java</a>
    (4)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/171/files#diff-3">src/main/java/bisq/core/dao/governance/proposal/ProposalConsensus.java</a>
    (4)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/171/files#diff-4">src/main/java/bisq/core/dao/governance/voteresult/VoteResultConsensus.java</a>
    (4)
  </li>
  <li>
    <strong>D</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/171/files#diff-5">src/main/java/bisq/core/dao/node/parser/OpReturnBlindVoteParser.java</a>
    (53)
  </li>
  <li>
    <strong>D</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/171/files#diff-6">src/main/java/bisq/core/dao/node/parser/OpReturnCompReqParser.java</a>
    (47)
  </li>
  <li>
    <strong>D</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/171/files#diff-7">src/main/java/bisq/core/dao/node/parser/OpReturnLockupParser.java</a>
    (53)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/171/files#diff-8">src/main/java/bisq/core/dao/node/parser/OpReturnParser.java</a>
    (204)
  </li>
  <li>
    <strong>D</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/171/files#diff-9">src/main/java/bisq/core/dao/node/parser/OpReturnProposalParser.java</a>
    (59)
  </li>
  <li>
    <strong>D</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/171/files#diff-10">src/main/java/bisq/core/dao/node/parser/OpReturnVoteRevealParser.java</a>
    (54)
  </li>
  <li>
    <strong>D</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/171/files#diff-11">src/main/java/bisq/core/dao/node/parser/ParsingModel.java</a>
    (102)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/171/files#diff-12">src/main/java/bisq/core/dao/node/parser/TxInputParser.java</a>
    (50)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/171/files#diff-13">src/main/java/bisq/core/dao/node/parser/TxOutputParser.java</a>
    (181)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/171/files#diff-14">src/main/java/bisq/core/dao/node/parser/TxParser.java</a>
    (267)
  </li>
  <li>
    <strong>A</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/171/files#diff-15">src/main/java/bisq/core/dao/node/parser/exceptions/InvalidParsingConditionException.java</a>
    (39)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/bisq-network/bisq-core/pull/171.patch'>https://github.com/bisq-network/bisq-core/pull/171.patch</a></li>
  <li><a href='https://github.com/bisq-network/bisq-core/pull/171.diff'>https://github.com/bisq-network/bisq-core/pull/171.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq-core/pull/171">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtsZtPc4V_711bFlc9eXHli5bNM-Cks5uVF6qgaJpZM4WOf-k">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtuuCK5Ph0MUONt207p42TjOsQPD-ks5uVF6qgaJpZM4WOf-k.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq-core","title":"bisq-network/bisq-core","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq-core"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"TxParser refactoring to get rid of ParsingModel (#171)"}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq-core/pull/171"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq-core/pull/171",
"url": "https://github.com/bisq-network/bisq-core/pull/171",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "TxParser refactoring to get rid of ParsingModel (#171)",
"sections": [
{
"text": "",
"activityTitle": "**Manfred Karrer**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@ManfredKarrer",
"facts": [

]
},
{
"title": "Commit Summary",
"facts": [
{
"name": "19eedae",
"value": "Refactor OpReturnParser"
},
{
"name": "252338f",
"value": "Refactor TxParser, TxOutputParser and ParsingModel"
},
{
"name": "a9183a3",
"value": "Add processOpReturnType method"
},
{
"name": "4e07b9c",
"value": "Remove availableInputValue from ParsingModel"
},
{
"name": "b29da1a",
"value": "Remove bsqOutputFound from ParsingModel"
},
{
"name": "b70b3c8",
"value": "Remove unlockBlockHeight from ParsingModel"
},
{
"name": "3d1c286",
"value": "Remove tx from ParsingModel"
},
{
"name": "a70782a",
"value": "Remove spentLockupTxOutput from ParsingModel"
},
{
"name": "6e795dc",
"value": "Remove ParsingModel"
},
{
"name": "94d988a",
"value": "Use connectedTxOutput for accessing lockTime instead of Tx"
}
]
},
{
"title": "File Changes",
"facts": [
{
"name": "Modified",
"value": "[src/main/java/bisq/core/dao/DaoModule.java](https://github.com/bisq-network/bisq-core/pull/171/files#diff-0) (14 changes)"
},
{
"name": "Modified",
"value": "[src/main/java/bisq/core/dao/bonding/BondingConsensus.java](https://github.com/bisq-network/bisq-core/pull/171/files#diff-1) (17 changes)"
},
{
"name": "Modified",
"value": "[src/main/java/bisq/core/dao/governance/blindvote/BlindVoteConsensus.java](https://github.com/bisq-network/bisq-core/pull/171/files#diff-2) (4 changes)"
},
{
"name": "Modified",
"value": "[src/main/java/bisq/core/dao/governance/proposal/ProposalConsensus.java](https://github.com/bisq-network/bisq-core/pull/171/files#diff-3) (4 changes)"
},
{
"name": "Modified",
"value": "[src/main/java/bisq/core/dao/governance/voteresult/VoteResultConsensus.java](https://github.com/bisq-network/bisq-core/pull/171/files#diff-4) (4 changes)"
},
{
"name": "Removed",
"value": "[src/main/java/bisq/core/dao/node/parser/OpReturnBlindVoteParser.java](https://github.com/bisq-network/bisq-core/pull/171/files#diff-5) (53 changes)"
},
{
"name": "Removed",
"value": "[src/main/java/bisq/core/dao/node/parser/OpReturnCompReqParser.java](https://github.com/bisq-network/bisq-core/pull/171/files#diff-6) (47 changes)"
},
{
"name": "Removed",
"value": "[src/main/java/bisq/core/dao/node/parser/OpReturnLockupParser.java](https://github.com/bisq-network/bisq-core/pull/171/files#diff-7) (53 changes)"
},
{
"name": "Modified",
"value": "[src/main/java/bisq/core/dao/node/parser/OpReturnParser.java](https://github.com/bisq-network/bisq-core/pull/171/files#diff-8) (204 changes)"
},
{
"name": "Removed",
"value": "[src/main/java/bisq/core/dao/node/parser/OpReturnProposalParser.java](https://github.com/bisq-network/bisq-core/pull/171/files#diff-9) (59 changes)"
},
{
"name": "Removed",
"value": "[src/main/java/bisq/core/dao/node/parser/OpReturnVoteRevealParser.java](https://github.com/bisq-network/bisq-core/pull/171/files#diff-10) (54 changes)"
},
{
"name": "Removed",
"value": "[src/main/java/bisq/core/dao/node/parser/ParsingModel.java](https://github.com/bisq-network/bisq-core/pull/171/files#diff-11) (102 changes)"
},
{
"name": "Modified",
"value": "[src/main/java/bisq/core/dao/node/parser/TxInputParser.java](https://github.com/bisq-network/bisq-core/pull/171/files#diff-12) (50 changes)"
},
{
"name": "Modified",
"value": "[src/main/java/bisq/core/dao/node/parser/TxOutputParser.java](https://github.com/bisq-network/bisq-core/pull/171/files#diff-13) (181 changes)"
},
{
"name": "Modified",
"value": "[src/main/java/bisq/core/dao/node/parser/TxParser.java](https://github.com/bisq-network/bisq-core/pull/171/files#diff-14) (267 changes)"
},
{
"name": "Added",
"value": "[src/main/java/bisq/core/dao/node/parser/exceptions/InvalidParsingConditionException.java](https://github.com/bisq-network/bisq-core/pull/171/files#diff-15) (39 changes)"
}
]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"bisq-network/bisq-core\",\n\"issueId\": 171,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"bisq-network/bisq-core\",\n\"pullRequestId\": 171\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq-core/pull/171"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq-core/pull/171.patch"
}
],
"@type": "OpenUri",
"name": "View patch"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq-core/pull/171.diff"
}
],
"@type": "OpenUri",
"name": "View diff"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 372899748\n}"
}
],
"themeColor": "26292E"
}
]</script>