<p>Depends on:<br>
<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="354385930" data-permission-text="Issue title is private" data-url="https://github.com/bisq-network/bisq-common/issues/39" href="https://github.com/bisq-network/bisq-common/pull/39">bisq-network/bisq-common#39</a></p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/bisq-network/bisq-core/pull/170'>https://github.com/bisq-network/bisq-core/pull/170</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Small refactorings, add todos from review</li>
  <li>Refactor OpReturnParser for Proposal</li>
  <li>Make TxOutputParser.isUnlockBondTx() take output value</li>
  <li>Refactor OpReturnParser for CompRequest</li>
  <li>Refactor OpReturnParser for BlindVote</li>
  <li>Refactor OpReturnParser for VoteReveal</li>
  <li>Handle failure states better in TxParser</li>
  <li>Refactor OpReturnParser and TxOutputParser methods</li>
  <li>Refactor OpReturnParser for lockupBond</li>
  <li>Drop commented-out line from TxParser</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/170/files#diff-0">src/main/java/bisq/core/dao/governance/blindvote/BlindVoteConsensus.java</a>
    (3)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/170/files#diff-1">src/main/java/bisq/core/dao/governance/blindvote/BlindVoteService.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/170/files#diff-2">src/main/java/bisq/core/dao/governance/blindvote/MyBlindVoteListService.java</a>
    (7)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/170/files#diff-3">src/main/java/bisq/core/dao/governance/myvote/MyVoteListService.java</a>
    (4)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/170/files#diff-4">src/main/java/bisq/core/dao/governance/voteresult/DecryptedVote.java</a>
    (1)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/170/files#diff-5">src/main/java/bisq/core/dao/governance/voteresult/ProposalVoteResult.java</a>
    (10)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/170/files#diff-6">src/main/java/bisq/core/dao/governance/voteresult/VoteResultConsensus.java</a>
    (24)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/170/files#diff-7">src/main/java/bisq/core/dao/governance/voteresult/VoteResultService.java</a>
    (124)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/170/files#diff-8">src/main/java/bisq/core/dao/governance/voteresult/issuance/IssuanceService.java</a>
    (1)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/170/files#diff-9">src/main/java/bisq/core/dao/governance/votereveal/VoteRevealService.java</a>
    (19)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/170/files#diff-10">src/main/java/bisq/core/dao/node/parser/OpReturnBlindVoteParser.java</a>
    (1)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/170/files#diff-11">src/main/java/bisq/core/dao/node/parser/OpReturnParser.java</a>
    (141)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/170/files#diff-12">src/main/java/bisq/core/dao/node/parser/OpReturnVoteRevealParser.java</a>
    (1)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/170/files#diff-13">src/main/java/bisq/core/dao/node/parser/TxOutputParser.java</a>
    (51)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/170/files#diff-14">src/main/java/bisq/core/dao/node/parser/TxParser.java</a>
    (137)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/170/files#diff-15">src/main/java/bisq/core/dao/state/BsqStateService.java</a>
    (1)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/170/files#diff-16">src/main/java/bisq/core/dao/state/blockchain/BaseTxOutput.java</a>
    (1)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/170/files#diff-17">src/main/java/bisq/core/dao/state/blockchain/TempTx.java</a>
    (5)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/170/files#diff-18">src/main/java/bisq/core/dao/state/blockchain/TempTxOutput.java</a>
    (9)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/170/files#diff-19">src/main/java/bisq/core/dao/state/blockchain/Tx.java</a>
    (14)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/170/files#diff-20">src/main/java/bisq/core/dao/state/blockchain/TxOutput.java</a>
    (15)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq-core/pull/170/files#diff-21">src/main/java/bisq/core/dao/state/governance/Param.java</a>
    (2)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/bisq-network/bisq-core/pull/170.patch'>https://github.com/bisq-network/bisq-core/pull/170.patch</a></li>
  <li><a href='https://github.com/bisq-network/bisq-core/pull/170.diff'>https://github.com/bisq-network/bisq-core/pull/170.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq-core/pull/170">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtkNiJzDM-jj3ZKEdXhX9cowYM6dJks5uVB10gaJpZM4WOFqH">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtgLzZgNjU3lviPsdMeYtf6pmOe1gks5uVB10gaJpZM4WOFqH.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq-core","title":"bisq-network/bisq-core","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq-core"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Refactoring TxParser (#170)"}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq-core/pull/170"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq-core/pull/170",
"url": "https://github.com/bisq-network/bisq-core/pull/170",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Refactoring TxParser (#170)",
"sections": [
{
"text": "",
"activityTitle": "**Manfred Karrer**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@ManfredKarrer",
"facts": [

]
},
{
"title": "Commit Summary",
"facts": [
{
"name": "c557789",
"value": "Small refactorings, add todos from review"
},
{
"name": "3084f7a",
"value": "Refactor OpReturnParser for Proposal"
},
{
"name": "d43d872",
"value": "Make TxOutputParser.isUnlockBondTx() take output value"
},
{
"name": "db6a3af",
"value": "Refactor OpReturnParser for CompRequest"
},
{
"name": "c94a7f3",
"value": "Refactor OpReturnParser for BlindVote"
},
{
"name": "fec8873",
"value": "Refactor OpReturnParser for VoteReveal"
},
{
"name": "fbff0a5",
"value": "Handle failure states better in TxParser"
},
{
"name": "257c848",
"value": "Refactor OpReturnParser and TxOutputParser methods"
},
{
"name": "687581a",
"value": "Refactor OpReturnParser for lockupBond"
},
{
"name": "5e77af6",
"value": "Drop commented-out line from TxParser"
}
]
},
{
"title": "File Changes",
"facts": [
{
"name": "Modified",
"value": "[src/main/java/bisq/core/dao/governance/blindvote/BlindVoteConsensus.java](https://github.com/bisq-network/bisq-core/pull/170/files#diff-0) (3 changes)"
},
{
"name": "Modified",
"value": "[src/main/java/bisq/core/dao/governance/blindvote/BlindVoteService.java](https://github.com/bisq-network/bisq-core/pull/170/files#diff-1) (2 changes)"
},
{
"name": "Modified",
"value": "[src/main/java/bisq/core/dao/governance/blindvote/MyBlindVoteListService.java](https://github.com/bisq-network/bisq-core/pull/170/files#diff-2) (7 changes)"
},
{
"name": "Modified",
"value": "[src/main/java/bisq/core/dao/governance/myvote/MyVoteListService.java](https://github.com/bisq-network/bisq-core/pull/170/files#diff-3) (4 changes)"
},
{
"name": "Modified",
"value": "[src/main/java/bisq/core/dao/governance/voteresult/DecryptedVote.java](https://github.com/bisq-network/bisq-core/pull/170/files#diff-4) (1 changes)"
},
{
"name": "Modified",
"value": "[src/main/java/bisq/core/dao/governance/voteresult/ProposalVoteResult.java](https://github.com/bisq-network/bisq-core/pull/170/files#diff-5) (10 changes)"
},
{
"name": "Modified",
"value": "[src/main/java/bisq/core/dao/governance/voteresult/VoteResultConsensus.java](https://github.com/bisq-network/bisq-core/pull/170/files#diff-6) (24 changes)"
},
{
"name": "Modified",
"value": "[src/main/java/bisq/core/dao/governance/voteresult/VoteResultService.java](https://github.com/bisq-network/bisq-core/pull/170/files#diff-7) (124 changes)"
},
{
"name": "Modified",
"value": "[src/main/java/bisq/core/dao/governance/voteresult/issuance/IssuanceService.java](https://github.com/bisq-network/bisq-core/pull/170/files#diff-8) (1 changes)"
},
{
"name": "Modified",
"value": "[src/main/java/bisq/core/dao/governance/votereveal/VoteRevealService.java](https://github.com/bisq-network/bisq-core/pull/170/files#diff-9) (19 changes)"
},
{
"name": "Modified",
"value": "[src/main/java/bisq/core/dao/node/parser/OpReturnBlindVoteParser.java](https://github.com/bisq-network/bisq-core/pull/170/files#diff-10) (1 changes)"
},
{
"name": "Modified",
"value": "[src/main/java/bisq/core/dao/node/parser/OpReturnParser.java](https://github.com/bisq-network/bisq-core/pull/170/files#diff-11) (141 changes)"
},
{
"name": "Modified",
"value": "[src/main/java/bisq/core/dao/node/parser/OpReturnVoteRevealParser.java](https://github.com/bisq-network/bisq-core/pull/170/files#diff-12) (1 changes)"
},
{
"name": "Modified",
"value": "[src/main/java/bisq/core/dao/node/parser/TxOutputParser.java](https://github.com/bisq-network/bisq-core/pull/170/files#diff-13) (51 changes)"
},
{
"name": "Modified",
"value": "[src/main/java/bisq/core/dao/node/parser/TxParser.java](https://github.com/bisq-network/bisq-core/pull/170/files#diff-14) (137 changes)"
},
{
"name": "Modified",
"value": "[src/main/java/bisq/core/dao/state/BsqStateService.java](https://github.com/bisq-network/bisq-core/pull/170/files#diff-15) (1 changes)"
},
{
"name": "Modified",
"value": "[src/main/java/bisq/core/dao/state/blockchain/BaseTxOutput.java](https://github.com/bisq-network/bisq-core/pull/170/files#diff-16) (1 changes)"
},
{
"name": "Modified",
"value": "[src/main/java/bisq/core/dao/state/blockchain/TempTx.java](https://github.com/bisq-network/bisq-core/pull/170/files#diff-17) (5 changes)"
},
{
"name": "Modified",
"value": "[src/main/java/bisq/core/dao/state/blockchain/TempTxOutput.java](https://github.com/bisq-network/bisq-core/pull/170/files#diff-18) (9 changes)"
},
{
"name": "Modified",
"value": "[src/main/java/bisq/core/dao/state/blockchain/Tx.java](https://github.com/bisq-network/bisq-core/pull/170/files#diff-19) (14 changes)"
},
{
"name": "Modified",
"value": "[src/main/java/bisq/core/dao/state/blockchain/TxOutput.java](https://github.com/bisq-network/bisq-core/pull/170/files#diff-20) (15 changes)"
},
{
"name": "Modified",
"value": "[src/main/java/bisq/core/dao/state/governance/Param.java](https://github.com/bisq-network/bisq-core/pull/170/files#diff-21) (2 changes)"
}
]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"bisq-network/bisq-core\",\n\"issueId\": 170,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"bisq-network/bisq-core\",\n\"pullRequestId\": 170\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq-core/pull/170"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq-core/pull/170.patch"
}
],
"@type": "OpenUri",
"name": "View patch"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq-core/pull/170.diff"
}
],
"@type": "OpenUri",
"name": "View diff"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 372791943\n}"
}
],
"themeColor": "26292E"
}
]</script>