<p><b>@chirhonul</b> approved this pull request.</p>

<p>Lightly tested ACK <a class="commit-link" href="https://github.com/bisq-network/bisq-core/commit/3ca17c4c9fac6cdb1587c19a7c4ef63f38534805"><tt>3ca17c4</tt></a>.</p>
<p>Seeing ~2x as much code removed as code added always makes it likely that the changeset is a move in the right direction, but in this case the code also ends up with a lot more concerns being contained more in the classes that are concerned with parsing that structure, and with input-to-output behavior<br>
that is easier to reason about, and will be easier to test.</p>
<p>Great work on this change!</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq-core/pull/171#pullrequestreview-150022608">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZthTp6iFsDuhPCar_1b-DY4HRDJikks5uVQRSgaJpZM4WOf-k">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtjMe0djn8t8gfuShpaDxmWgocu3kks5uVQRSgaJpZM4WOf-k.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq-core","title":"bisq-network/bisq-core","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq-core"}},"updates":{"snippets":[{"icon":"PERSON","message":"@chirhonul approved #171"}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq-core/pull/171#pullrequestreview-150022608"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq-core/pull/171#pullrequestreview-150022608",
"url": "https://github.com/bisq-network/bisq-core/pull/171#pullrequestreview-150022608",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "@chirhonul approved 171",
"sections": [
{
"text": "Lightly tested ACK 3ca17c4c.\r\n\r\nSeeing ~2x as much code removed as code added always makes it likely that the changeset is a move in the right direction, but in this case the code also ends up with a lot more concerns being contained more in the classes that are concerned with parsing that structure, and with input-to-output behavior\r\nthat is easier to reason about, and will be easier to test.\r\n\r\nGreat work on this change!",
"activityTitle": "**chirhonul**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@chirhonul",
"facts": [

]
}
],
"potentialAction": [
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq-core/pull/171#pullrequestreview-150022608"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 372899748\n}"
}
],
"themeColor": "26292E"
}
]</script>