<p>I did some more refactoring, the main thing being that the txOutputs are only commited after the tx type is determined. That way we avoid inconsistency of adding some outputs to bsq stateservice and later finding out the tx is invalid.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq-core/pull/175#issuecomment-418777576">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtk5d1MFHcAj_lx7xJW80mszSoKeGks5uX_AsgaJpZM4WX1Ap">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtq8nQbiZYjL1TSEhPP2VD12n4E64ks5uX_AsgaJpZM4WX1Ap.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq-core","title":"bisq-network/bisq-core","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq-core"}},"updates":{"snippets":[{"icon":"PERSON","message":"@sqrrm in #175: I did some more refactoring, the main thing being that the txOutputs are only commited after the tx type is determined. That way we avoid inconsistency of adding some outputs to bsq stateservice and later finding out the tx is invalid."}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq-core/pull/175#issuecomment-418777576"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq-core/pull/175#issuecomment-418777576",
"url": "https://github.com/bisq-network/bisq-core/pull/175#issuecomment-418777576",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Re: [bisq-network/bisq-core] Parse opreturn before other outputs (#175)",
"sections": [
{
"text": "",
"activityTitle": "**sqrrm**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@sqrrm",
"facts": [

]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"bisq-network/bisq-core\",\n\"issueId\": 175,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"bisq-network/bisq-core\",\n\"pullRequestId\": 175\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq-core/pull/175#issuecomment-418777576"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 375345193\n}"
}
],
"themeColor": "26292E"
}
]</script>