<p>I've started to adapt the current mono repository to support Java 10.<br>
The current state is, that <code>gradle build</code> runs and you can launch the app from IDEA.<br>
Still there are a couple of things left, where help is wanted (see check list)</p>
<p>[x] Upgrade JavaFX code<br>
[ ] Implement alternative for progress indicator (block chain confirmations) as current implementation won't work for java 10<br>
[x] Update lombok<br>
[x] Update source compatibility settings<br>
[x] Update travis setting<br>
[x] Implement power mock support<br>
[ ] Implement JMockit support (if someone is familiar configuring it for Java 10 - help wanted)</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/bisq-network/bisq/pull/1660'>https://github.com/bisq-network/bisq/pull/1660</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Clean up errors for testing</li>
  <li>Remove files that use classes that can't be accessed anymore</li>
  <li>Update lombok library</li>
  <li>Update source compatibility to Java 10</li>
  <li>Update travis Java version</li>
  <li>Make power mock tests Java 10 compatibile</li>
  <li>Add not working JMockit setup (help wanted)</li>
  <li>Use FXCollections instead of not existing ObservableListWrapper</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1660/files#diff-0">.travis.yml</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1660/files#diff-1">assets/build.gradle</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1660/files#diff-2">common/build.gradle</a>
    (6)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1660/files#diff-3">core/build.gradle</a>
    (27)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1660/files#diff-4">core/src/test/java/bisq/core/arbitration/ArbitratorManagerTest.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1660/files#diff-5">core/src/test/java/bisq/core/btc/wallet/WalletSetupPreferencesTest.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1660/files#diff-6">core/src/test/java/bisq/core/dao/node/full/BlockParserTest.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1660/files#diff-7">core/src/test/java/bisq/core/dao/state/SnapshotManagerTest.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1660/files#diff-8">core/src/test/java/bisq/core/offer/OfferTest.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1660/files#diff-9">core/src/test/java/bisq/core/offer/OpenOfferManagerTest.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1660/files#diff-10">core/src/test/java/bisq/core/payment/PaymentAccountsTest.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1660/files#diff-11">core/src/test/java/bisq/core/payment/ReceiptPredicatesTest.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1660/files#diff-12">core/src/test/java/bisq/core/payment/ReceiptValidatorTest.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1660/files#diff-13">core/src/test/java/bisq/core/trade/TradableListTest.java</a>
    (10)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1660/files#diff-14">core/src/test/java/bisq/core/user/PreferencesTest.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1660/files#diff-15">desktop/build.gradle</a>
    (27)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1660/files#diff-16">desktop/src/main/java/bisq/desktop/components/AutoTooltipButton.java</a>
    (3)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1660/files#diff-17">desktop/src/main/java/bisq/desktop/components/AutoTooltipCheckBox.java</a>
    (3)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1660/files#diff-18">desktop/src/main/java/bisq/desktop/components/AutoTooltipLabel.java</a>
    (3)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1660/files#diff-19">desktop/src/main/java/bisq/desktop/components/AutoTooltipRadioButton.java</a>
    (3)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1660/files#diff-20">desktop/src/main/java/bisq/desktop/components/AutoTooltipToggleButton.java</a>
    (3)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1660/files#diff-21">desktop/src/main/java/bisq/desktop/components/indicator/TxConfidenceIndicator.java</a>
    (8)
  </li>
  <li>
    <strong>D</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1660/files#diff-22">desktop/src/main/java/bisq/desktop/components/indicator/behavior/StaticProgressIndicatorBehavior.java</a>
    (70)
  </li>
  <li>
    <strong>D</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1660/files#diff-23">desktop/src/main/java/bisq/desktop/components/indicator/skin/StaticProgressIndicatorSkin.java</a>
    (775)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1660/files#diff-24">desktop/src/main/java/bisq/desktop/main/market/offerbook/OfferBookChartView.java</a>
    (4)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1660/files#diff-25">desktop/src/main/java/bisq/desktop/main/market/offerbook/OfferBookChartViewModel.java</a>
    (4)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1660/files#diff-26">desktop/src/main/java/bisq/desktop/main/market/trades/TradesChartsViewModel.java</a>
    (4)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1660/files#diff-27">desktop/src/main/java/bisq/desktop/util/CurrencyList.java</a>
    (16)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1660/files#diff-28">desktop/src/main/java/bisq/desktop/util/ImageUtil.java</a>
    (12)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1660/files#diff-29">desktop/src/test/java/bisq/desktop/main/funds/transactions/TransactionAwareTradeTest.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1660/files#diff-30">desktop/src/test/java/bisq/desktop/main/market/offerbook/OfferBookChartViewModelTest.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1660/files#diff-31">desktop/src/test/java/bisq/desktop/main/market/spread/SpreadViewModelTest.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1660/files#diff-32">desktop/src/test/java/bisq/desktop/main/market/trades/TradesChartsViewModelTest.java</a>
    (8)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1660/files#diff-33">desktop/src/test/java/bisq/desktop/main/offer/createoffer/CreateOfferViewModelTest.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1660/files#diff-34">desktop/src/test/java/bisq/desktop/main/offer/offerbook/OfferBookViewModelTest.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1660/files#diff-35">desktop/src/test/java/bisq/desktop/main/settings/preferences/PreferencesViewModelTest.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1660/files#diff-36">desktop/src/test/java/bisq/desktop/util/BSFormatterTest.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1660/files#diff-37">desktop/src/test/java/bisq/desktop/util/CurrencyListTest.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1660/files#diff-38">p2p/build.gradle</a>
    (10)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/bisq-network/bisq/pull/1660.patch'>https://github.com/bisq-network/bisq/pull/1660.patch</a></li>
  <li><a href='https://github.com/bisq-network/bisq/pull/1660.diff'>https://github.com/bisq-network/bisq/pull/1660.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/1660">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtmDcbBOdjznKs2TIPS3uLTA6LWv0ks5uYmM0gaJpZM4WeuKv">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtgxHk_FsvXCjA-IFZOqJALIxlOggks5uYmM0gaJpZM4WeuKv.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq","title":"bisq-network/bisq","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"[WIP] Java 10 support (#1660)"}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq/pull/1660"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/1660",
"url": "https://github.com/bisq-network/bisq/pull/1660",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "[WIP] Java 10 support (#1660)",
"sections": [
{
"text": "",
"activityTitle": "**Christoph Atteneder**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@ripcurlx",
"facts": [

]
},
{
"title": "Commit Summary",
"facts": [
{
"name": "9b4b062",
"value": "Clean up errors for testing"
},
{
"name": "4725191",
"value": "Remove files that use classes that can't be accessed anymore"
},
{
"name": "73e4ee5",
"value": "Update lombok library"
},
{
"name": "bd9a208",
"value": "Update source compatibility to Java 10"
},
{
"name": "5d23971",
"value": "Update travis Java version"
},
{
"name": "e319449",
"value": "Make power mock tests Java 10 compatibile"
},
{
"name": "8ed7f42",
"value": "Add not working JMockit setup (help wanted)"
},
{
"name": "13266b2",
"value": "Use FXCollections instead of not existing ObservableListWrapper"
}
]
},
{
"title": "File Changes",
"facts": [
{
"name": "Modified",
"value": "[.travis.yml](https://github.com/bisq-network/bisq/pull/1660/files#diff-0) (2 changes)"
},
{
"name": "Modified",
"value": "[assets/build.gradle](https://github.com/bisq-network/bisq/pull/1660/files#diff-1) (2 changes)"
},
{
"name": "Modified",
"value": "[common/build.gradle](https://github.com/bisq-network/bisq/pull/1660/files#diff-2) (6 changes)"
},
{
"name": "Modified",
"value": "[core/build.gradle](https://github.com/bisq-network/bisq/pull/1660/files#diff-3) (27 changes)"
},
{
"name": "Modified",
"value": "[core/src/test/java/bisq/core/arbitration/ArbitratorManagerTest.java](https://github.com/bisq-network/bisq/pull/1660/files#diff-4) (2 changes)"
},
{
"name": "Modified",
"value": "[core/src/test/java/bisq/core/btc/wallet/WalletSetupPreferencesTest.java](https://github.com/bisq-network/bisq/pull/1660/files#diff-5) (2 changes)"
},
{
"name": "Modified",
"value": "[core/src/test/java/bisq/core/dao/node/full/BlockParserTest.java](https://github.com/bisq-network/bisq/pull/1660/files#diff-6) (2 changes)"
},
{
"name": "Modified",
"value": "[core/src/test/java/bisq/core/dao/state/SnapshotManagerTest.java](https://github.com/bisq-network/bisq/pull/1660/files#diff-7) (2 changes)"
},
{
"name": "Modified",
"value": "[core/src/test/java/bisq/core/offer/OfferTest.java](https://github.com/bisq-network/bisq/pull/1660/files#diff-8) (2 changes)"
},
{
"name": "Modified",
"value": "[core/src/test/java/bisq/core/offer/OpenOfferManagerTest.java](https://github.com/bisq-network/bisq/pull/1660/files#diff-9) (2 changes)"
},
{
"name": "Modified",
"value": "[core/src/test/java/bisq/core/payment/PaymentAccountsTest.java](https://github.com/bisq-network/bisq/pull/1660/files#diff-10) (2 changes)"
},
{
"name": "Modified",
"value": "[core/src/test/java/bisq/core/payment/ReceiptPredicatesTest.java](https://github.com/bisq-network/bisq/pull/1660/files#diff-11) (2 changes)"
},
{
"name": "Modified",
"value": "[core/src/test/java/bisq/core/payment/ReceiptValidatorTest.java](https://github.com/bisq-network/bisq/pull/1660/files#diff-12) (2 changes)"
},
{
"name": "Modified",
"value": "[core/src/test/java/bisq/core/trade/TradableListTest.java](https://github.com/bisq-network/bisq/pull/1660/files#diff-13) (10 changes)"
},
{
"name": "Modified",
"value": "[core/src/test/java/bisq/core/user/PreferencesTest.java](https://github.com/bisq-network/bisq/pull/1660/files#diff-14) (2 changes)"
},
{
"name": "Modified",
"value": "[desktop/build.gradle](https://github.com/bisq-network/bisq/pull/1660/files#diff-15) (27 changes)"
},
{
"name": "Modified",
"value": "[desktop/src/main/java/bisq/desktop/components/AutoTooltipButton.java](https://github.com/bisq-network/bisq/pull/1660/files#diff-16) (3 changes)"
},
{
"name": "Modified",
"value": "[desktop/src/main/java/bisq/desktop/components/AutoTooltipCheckBox.java](https://github.com/bisq-network/bisq/pull/1660/files#diff-17) (3 changes)"
},
{
"name": "Modified",
"value": "[desktop/src/main/java/bisq/desktop/components/AutoTooltipLabel.java](https://github.com/bisq-network/bisq/pull/1660/files#diff-18) (3 changes)"
},
{
"name": "Modified",
"value": "[desktop/src/main/java/bisq/desktop/components/AutoTooltipRadioButton.java](https://github.com/bisq-network/bisq/pull/1660/files#diff-19) (3 changes)"
},
{
"name": "Modified",
"value": "[desktop/src/main/java/bisq/desktop/components/AutoTooltipToggleButton.java](https://github.com/bisq-network/bisq/pull/1660/files#diff-20) (3 changes)"
},
{
"name": "Modified",
"value": "[desktop/src/main/java/bisq/desktop/components/indicator/TxConfidenceIndicator.java](https://github.com/bisq-network/bisq/pull/1660/files#diff-21) (8 changes)"
},
{
"name": "Removed",
"value": "[desktop/src/main/java/bisq/desktop/components/indicator/behavior/StaticProgressIndicatorBehavior.java](https://github.com/bisq-network/bisq/pull/1660/files#diff-22) (70 changes)"
},
{
"name": "Removed",
"value": "[desktop/src/main/java/bisq/desktop/components/indicator/skin/StaticProgressIndicatorSkin.java](https://github.com/bisq-network/bisq/pull/1660/files#diff-23) (775 changes)"
},
{
"name": "Modified",
"value": "[desktop/src/main/java/bisq/desktop/main/market/offerbook/OfferBookChartView.java](https://github.com/bisq-network/bisq/pull/1660/files#diff-24) (4 changes)"
},
{
"name": "Modified",
"value": "[desktop/src/main/java/bisq/desktop/main/market/offerbook/OfferBookChartViewModel.java](https://github.com/bisq-network/bisq/pull/1660/files#diff-25) (4 changes)"
},
{
"name": "Modified",
"value": "[desktop/src/main/java/bisq/desktop/main/market/trades/TradesChartsViewModel.java](https://github.com/bisq-network/bisq/pull/1660/files#diff-26) (4 changes)"
},
{
"name": "Modified",
"value": "[desktop/src/main/java/bisq/desktop/util/CurrencyList.java](https://github.com/bisq-network/bisq/pull/1660/files#diff-27) (16 changes)"
},
{
"name": "Modified",
"value": "[desktop/src/main/java/bisq/desktop/util/ImageUtil.java](https://github.com/bisq-network/bisq/pull/1660/files#diff-28) (12 changes)"
},
{
"name": "Modified",
"value": "[desktop/src/test/java/bisq/desktop/main/funds/transactions/TransactionAwareTradeTest.java](https://github.com/bisq-network/bisq/pull/1660/files#diff-29) (2 changes)"
},
{
"name": "Modified",
"value": "[desktop/src/test/java/bisq/desktop/main/market/offerbook/OfferBookChartViewModelTest.java](https://github.com/bisq-network/bisq/pull/1660/files#diff-30) (2 changes)"
},
{
"name": "Modified",
"value": "[desktop/src/test/java/bisq/desktop/main/market/spread/SpreadViewModelTest.java](https://github.com/bisq-network/bisq/pull/1660/files#diff-31) (2 changes)"
},
{
"name": "Modified",
"value": "[desktop/src/test/java/bisq/desktop/main/market/trades/TradesChartsViewModelTest.java](https://github.com/bisq-network/bisq/pull/1660/files#diff-32) (8 changes)"
},
{
"name": "Modified",
"value": "[desktop/src/test/java/bisq/desktop/main/offer/createoffer/CreateOfferViewModelTest.java](https://github.com/bisq-network/bisq/pull/1660/files#diff-33) (2 changes)"
},
{
"name": "Modified",
"value": "[desktop/src/test/java/bisq/desktop/main/offer/offerbook/OfferBookViewModelTest.java](https://github.com/bisq-network/bisq/pull/1660/files#diff-34) (2 changes)"
},
{
"name": "Modified",
"value": "[desktop/src/test/java/bisq/desktop/main/settings/preferences/PreferencesViewModelTest.java](https://github.com/bisq-network/bisq/pull/1660/files#diff-35) (2 changes)"
},
{
"name": "Modified",
"value": "[desktop/src/test/java/bisq/desktop/util/BSFormatterTest.java](https://github.com/bisq-network/bisq/pull/1660/files#diff-36) (2 changes)"
},
{
"name": "Modified",
"value": "[desktop/src/test/java/bisq/desktop/util/CurrencyListTest.java](https://github.com/bisq-network/bisq/pull/1660/files#diff-37) (2 changes)"
},
{
"name": "Modified",
"value": "[p2p/build.gradle](https://github.com/bisq-network/bisq/pull/1660/files#diff-38) (10 changes)"
}
]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"bisq-network/bisq\",\n\"issueId\": 1660,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"bisq-network/bisq\",\n\"pullRequestId\": 1660\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq/pull/1660"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq/pull/1660.patch"
}
],
"@type": "OpenUri",
"name": "View patch"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq/pull/1660.diff"
}
],
"@type": "OpenUri",
"name": "View diff"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 377152175\n}"
}
],
"themeColor": "26292E"
}
]</script>