<p><a class="user-mention" data-hovercard-user-id="1449498" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/ManfredKarrer">@ManfredKarrer</a> There is one very important reason why we want to get this in.<br>
It contains startup refactoring, which we heavily depend on. If we don't merge it ASAP then it will diverge over time from master. Even if we keep merging master to that branch, we will hit conflicts sooner or later.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/1686#issuecomment-422287171">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtlL4Vgdm7E5iauOFYI7F8aNTUwwfks5ucKJxgaJpZM4WpWS-">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtnsd7SNevyKM7ayjuk4L9L8axdZ8ks5ucKJxgaJpZM4WpWS-.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq","title":"bisq-network/bisq","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq"}},"updates":{"snippets":[{"icon":"PERSON","message":"@blabno in #1686: @ManfredKarrer There is one very important reason why we want to get this in.\r\nIt contains startup refactoring, which we heavily depend on. If we don't merge it ASAP then it will diverge over time from master. Even if we keep merging master to that branch, we will hit conflicts sooner or later."}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq/pull/1686#issuecomment-422287171"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/1686#issuecomment-422287171",
"url": "https://github.com/bisq-network/bisq/pull/1686#issuecomment-422287171",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Re: [bisq-network/bisq] Porting Manfred's HTTP API changes from bisq-core to the mono repo (#1686)",
"sections": [
{
"text": "",
"activityTitle": "**Bernard Labno**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@blabno",
"facts": [

]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"bisq-network/bisq\",\n\"issueId\": 1686,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq/pull/1686#issuecomment-422287171"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 379937982\n}"
}
],
"themeColor": "26292E"
}
]</script>