<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/bisq-network/bisq/pull/1722'>https://github.com/bisq-network/bisq/pull/1722</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Fix issue causing invalid vote reveal tx</li>
  <li>Fix issue with wrong merit</li>
  <li>Add toString methods, add better logging</li>
  <li>Fix issue with not filtered ballots</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1722/files#diff-0">core/src/main/java/bisq/core/dao/governance/ballot/BallotListService.java</a>
    (12)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1722/files#diff-1">core/src/main/java/bisq/core/dao/governance/blindvote/BlindVoteConsensus.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1722/files#diff-2">core/src/main/java/bisq/core/dao/governance/blindvote/BlindVoteValidator.java</a>
    (5)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1722/files#diff-3">core/src/main/java/bisq/core/dao/governance/blindvote/MyBlindVoteListService.java</a>
    (3)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1722/files#diff-4">core/src/main/java/bisq/core/dao/governance/merit/Merit.java</a>
    (9)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1722/files#diff-5">core/src/main/java/bisq/core/dao/governance/merit/MeritConsensus.java</a>
    (13)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1722/files#diff-6">core/src/main/java/bisq/core/dao/governance/proposal/Proposal.java</a>
    (1)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1722/files#diff-7">core/src/main/java/bisq/core/dao/governance/voteresult/EvaluatedProposal.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1722/files#diff-8">core/src/main/java/bisq/core/dao/node/parser/TxParser.java</a>
    (24)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1722/files#diff-9">core/src/main/java/bisq/core/dao/state/BsqState.java</a>
    (8)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1722/files#diff-10">core/src/main/java/bisq/core/dao/state/governance/Issuance.java</a>
    (10)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1722/files#diff-11">core/src/main/java/bisq/core/dao/state/governance/Param.java</a>
    (4)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/bisq-network/bisq/pull/1722.patch'>https://github.com/bisq-network/bisq/pull/1722.patch</a></li>
  <li><a href='https://github.com/bisq-network/bisq/pull/1722.diff'>https://github.com/bisq-network/bisq/pull/1722.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/1722">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtkI8lYWlyf6ssMR8PyZw7vtqclCaks5ueZPSgaJpZM4W3wSU">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtj5xG5uHbej47SFJ5lVbJgrMHRR6ks5ueZPSgaJpZM4W3wSU.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq","title":"bisq-network/bisq","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Fix bugs with voting (#1722)"}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq/pull/1722"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/1722",
"url": "https://github.com/bisq-network/bisq/pull/1722",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Fix bugs with voting (#1722)",
"sections": [
{
"text": "",
"activityTitle": "**Manfred Karrer**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@ManfredKarrer",
"facts": [

]
},
{
"title": "Commit Summary",
"facts": [
{
"name": "ee1317c",
"value": "Fix issue causing invalid vote reveal tx"
},
{
"name": "d9cada9",
"value": "Fix issue with wrong merit"
},
{
"name": "ff796b3",
"value": "Add toString methods, add better logging"
},
{
"name": "2be68a7",
"value": "Fix issue with not filtered ballots"
}
]
},
{
"title": "File Changes",
"facts": [
{
"name": "Modified",
"value": "[core/src/main/java/bisq/core/dao/governance/ballot/BallotListService.java](https://github.com/bisq-network/bisq/pull/1722/files#diff-0) (12 changes)"
},
{
"name": "Modified",
"value": "[core/src/main/java/bisq/core/dao/governance/blindvote/BlindVoteConsensus.java](https://github.com/bisq-network/bisq/pull/1722/files#diff-1) (2 changes)"
},
{
"name": "Modified",
"value": "[core/src/main/java/bisq/core/dao/governance/blindvote/BlindVoteValidator.java](https://github.com/bisq-network/bisq/pull/1722/files#diff-2) (5 changes)"
},
{
"name": "Modified",
"value": "[core/src/main/java/bisq/core/dao/governance/blindvote/MyBlindVoteListService.java](https://github.com/bisq-network/bisq/pull/1722/files#diff-3) (3 changes)"
},
{
"name": "Modified",
"value": "[core/src/main/java/bisq/core/dao/governance/merit/Merit.java](https://github.com/bisq-network/bisq/pull/1722/files#diff-4) (9 changes)"
},
{
"name": "Modified",
"value": "[core/src/main/java/bisq/core/dao/governance/merit/MeritConsensus.java](https://github.com/bisq-network/bisq/pull/1722/files#diff-5) (13 changes)"
},
{
"name": "Modified",
"value": "[core/src/main/java/bisq/core/dao/governance/proposal/Proposal.java](https://github.com/bisq-network/bisq/pull/1722/files#diff-6) (1 changes)"
},
{
"name": "Modified",
"value": "[core/src/main/java/bisq/core/dao/governance/voteresult/EvaluatedProposal.java](https://github.com/bisq-network/bisq/pull/1722/files#diff-7) (2 changes)"
},
{
"name": "Modified",
"value": "[core/src/main/java/bisq/core/dao/node/parser/TxParser.java](https://github.com/bisq-network/bisq/pull/1722/files#diff-8) (24 changes)"
},
{
"name": "Modified",
"value": "[core/src/main/java/bisq/core/dao/state/BsqState.java](https://github.com/bisq-network/bisq/pull/1722/files#diff-9) (8 changes)"
},
{
"name": "Modified",
"value": "[core/src/main/java/bisq/core/dao/state/governance/Issuance.java](https://github.com/bisq-network/bisq/pull/1722/files#diff-10) (10 changes)"
},
{
"name": "Modified",
"value": "[core/src/main/java/bisq/core/dao/state/governance/Param.java](https://github.com/bisq-network/bisq/pull/1722/files#diff-11) (4 changes)"
}
]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"bisq-network/bisq\",\n\"issueId\": 1722,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"bisq-network/bisq\",\n\"pullRequestId\": 1722\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq/pull/1722"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq/pull/1722.patch"
}
],
"@type": "OpenUri",
"name": "View patch"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq/pull/1722.diff"
}
],
"@type": "OpenUri",
"name": "View diff"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 383714452\n}"
}
],
"themeColor": "26292E"
}
]</script>