<p><a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=170962" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/ripcurlx">@ripcurlx</a> I added a commit to the current PR for the TakeOfferView class</p>
<p>If we have multiple payment accounts we should show some info/warning to<br>
make sure the user has selected the account he wants to use.<br>
To use a popup is not recommended as we have already 3 popups at the<br>
first time (if user has not clicked<br>
don't show again).<br>
<a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=170962" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/ripcurlx">@ripcurlx</a> Maybe a similar warn triangle as used in create offer<br>
might work?</p>
<p>That is only one part, I will look into the trade screens as well...</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/issues/1733#issuecomment-425491318">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtur1wlQ81d6kslK7EXZfpWmyn5I1ks5ufk4BgaJpZM4W-PFE">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtksTAZ1g44Uzn4cCRZdTnt6fR8vVks5ufk4BgaJpZM4W-PFE.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq","title":"bisq-network/bisq","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq"}},"updates":{"snippets":[{"icon":"PERSON","message":"@ManfredKarrer in #1733: @ripcurlx I added a commit to the current PR for the TakeOfferView class \r\n\r\nIf we have multiple payment accounts we should show some info/warning to\r\nmake sure the user has selected the account he wants to use.\r\nTo use a popup is not recommended as we have already 3 popups at the \r\nfirst time (if user has not clicked\r\ndon't show again).\r\n@ripcurlx Maybe a similar warn triangle as used in create offer \r\nmight work?\r\n\r\nThat is only one part, I will look into the trade screens as well..."}],"action":{"name":"View Issue","url":"https://github.com/bisq-network/bisq/issues/1733#issuecomment-425491318"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/issues/1733#issuecomment-425491318",
"url": "https://github.com/bisq-network/bisq/issues/1733#issuecomment-425491318",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Re: [bisq-network/bisq] Make more prominent which payment account should be used to complete a given trade (#1733)",
"sections": [
{
"text": "",
"activityTitle": "**Manfred Karrer**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@ManfredKarrer",
"facts": [

]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"bisq-network/bisq\",\n\"issueId\": 1733,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close issue",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueClose\",\n\"repositoryFullName\": \"bisq-network/bisq\",\n\"issueId\": 1733\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq/issues/1733#issuecomment-425491318"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 385413444\n}"
}
],
"themeColor": "26292E"
}
]</script>