<p>One other improvement would be to persist the last selected account in case there are multiple. We do that in create offer. But for take offer it is a bit more complex as we need to first check which payment account is valid for the selected offer. So it would not be enough to store one account as there might be the case that for 2 payment methods there are multiple accounts and then when the user takes once an offer from one payment method and then later from another the persisted value would become useless. So we would need to store it by payment method or currency, but that is also not perfect as the selection for the possible payment accounts carry more complexity depending on the payment method (country based, currency,... see ReceiptValidator).<br>
So I think that feature is not worth the effort atm.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/issues/1733#issuecomment-425494335">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZthTmECscL3bHZ0ivkOGlSS6gbHWsks5uflB0gaJpZM4W-PFE">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtqcV-1fxZ49JRSULYEHaJvlay-WVks5uflB0gaJpZM4W-PFE.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq","title":"bisq-network/bisq","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq"}},"updates":{"snippets":[{"icon":"PERSON","message":"@ManfredKarrer in #1733: One other improvement would be to persist the last selected account in case there are multiple. We do that in create offer. But for take offer it is a bit more complex as we need to first check which payment account is valid for the selected offer. So it would not be enough to store one account as there might be the case that for 2 payment methods there are multiple accounts and then when the user takes once an offer from one payment method and then later from another the persisted value would become useless. So we would need to store it by payment method or currency, but that is also not perfect as the selection for the possible payment accounts carry more complexity depending on the payment method (country based, currency,... see ReceiptValidator). \r\nSo I think that feature is not worth the effort atm."}],"action":{"name":"View Issue","url":"https://github.com/bisq-network/bisq/issues/1733#issuecomment-425494335"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/issues/1733#issuecomment-425494335",
"url": "https://github.com/bisq-network/bisq/issues/1733#issuecomment-425494335",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Re: [bisq-network/bisq] Make more prominent which payment account should be used to complete a given trade (#1733)",
"sections": [
{
"text": "",
"activityTitle": "**Manfred Karrer**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@ManfredKarrer",
"facts": [

]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"bisq-network/bisq\",\n\"issueId\": 1733,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close issue",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueClose\",\n\"repositoryFullName\": \"bisq-network/bisq\",\n\"issueId\": 1733\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq/issues/1733#issuecomment-425494335"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 385413444\n}"
}
],
"themeColor": "26292E"
}
]</script>