<p>I might be confused, <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=23560607" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/sqrrm">@sqrrm</a>. Compensation requests <em>are</em> proposals, and the idea of having a review period is to be able to modify them accordingly based on review feedback, so it seems that by definition proposals must be modifiable during that period.</p>
<p>Do you mean to ask here about non-compensation request proposals? If so, I think I agree that they should not be modifiable once submitted. Would be helpful to think it through with a concrete example, though. I'm not familiar enough with the way proposals in the DAO software work to be sure about anything, but in principle it seems like non-compensation proposals should just be an up or down vote, and that any review should have happened  before being submitted. I'm assuming here that we'd still have the proposals GitHub repository for that review? Or maybe not. Again, I'm not sure what the thinking on this has been so far, or what the actual implementation expects.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/proposals/issues/40#issuecomment-427940725">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtij4Qz-UEaz3Pux9gH1RIrOBgEiXks5ui53DgaJpZM4W4xDT">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtoN6XJvgBYsVWTYIw4Dv-K9EO034ks5ui53DgaJpZM4W4xDT.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/proposals","title":"bisq-network/proposals","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/proposals"}},"updates":{"snippets":[{"icon":"PERSON","message":"@cbeams in #40: I might be confused, @sqrrm. Compensation requests *are* proposals, and the idea of having a review period is to be able to modify them accordingly based on review feedback, so it seems that by definition proposals must be modifiable during that period.\r\n\r\nDo you mean to ask here about non-compensation request proposals? If so, I think I agree that they should not be modifiable once submitted. Would be helpful to think it through with a concrete example, though. I'm not familiar enough with the way proposals in the DAO software work to be sure about anything, but in principle it seems like non-compensation proposals should just be an up or down vote, and that any review should have happened  before being submitted. I'm assuming here that we'd still have the proposals GitHub repository for that review? Or maybe not. Again, I'm not sure what the thinking on this has been so far, or what the actual implementation expects."}],"action":{"name":"View Issue","url":"https://github.com/bisq-network/proposals/issues/40#issuecomment-427940725"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/proposals/issues/40#issuecomment-427940725",
"url": "https://github.com/bisq-network/proposals/issues/40#issuecomment-427940725",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Re: [bisq-network/proposals] Separate compensation request submission and voting periods (#40)",
"sections": [
{
"text": "",
"activityTitle": "**Chris Beams**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@cbeams",
"facts": [

]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"bisq-network/proposals\",\n\"issueId\": 40,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close issue",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueClose\",\n\"repositoryFullName\": \"bisq-network/proposals\",\n\"issueId\": 40\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/proposals/issues/40#issuecomment-427940725"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 383979731\n}"
}
],
"themeColor": "26292E"
}
]</script>