<p>Using display scaling (e.g. 150% in Windows 10), text content within popups were being truncated.<br>
A couple examples:<br>
<a target="_blank" rel="noopener noreferrer" href="https://user-images.githubusercontent.com/603793/46785717-8541e500-cce7-11e8-942d-b2e50d86de61.png"><img src="https://user-images.githubusercontent.com/603793/46785717-8541e500-cce7-11e8-942d-b2e50d86de61.png" alt="image" style="max-width:100%;"></a></p>
<p><a target="_blank" rel="noopener noreferrer" href="https://user-images.githubusercontent.com/603793/46785774-aa365800-cce7-11e8-92c2-31feed89e4f5.png"><img src="https://user-images.githubusercontent.com/603793/46785774-aa365800-cce7-11e8-92c2-31feed89e4f5.png" alt="image" style="max-width:100%;"></a></p>
<p>This is a result of a known Java bug (<a href="https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8199592" rel="nofollow">https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8199592</a>) which mentions a workaround:</p>
<blockquote>
<p>explicitly calling sizeToScene appears to suppress the bug at DPI levels other than 175%</p>
</blockquote>
<p>I confirmed that this workaround fixes the truncation at 125% and 150% scaling, but noticed it still truncates the checkbox label at 175% (as stated in the workaround):<br>
<a target="_blank" rel="noopener noreferrer" href="https://user-images.githubusercontent.com/603793/46785899-0b5e2b80-cce8-11e8-832b-0ee18dec25c5.png"><img src="https://user-images.githubusercontent.com/603793/46785899-0b5e2b80-cce8-11e8-832b-0ee18dec25c5.png" alt="image" style="max-width:100%;"></a></p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/bisq-network/bisq/pull/1767'>https://github.com/bisq-network/bisq/pull/1767</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Workaround for labels being truncated at certain display scaling levels (JDK-8199592)</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1767/files#diff-0">desktop/src/main/java/bisq/desktop/main/overlays/Overlay.java</a>
    (1)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/bisq-network/bisq/pull/1767.patch'>https://github.com/bisq-network/bisq/pull/1767.patch</a></li>
  <li><a href='https://github.com/bisq-network/bisq/pull/1767.diff'>https://github.com/bisq-network/bisq/pull/1767.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/1767">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZttwW3ExneRiGtEnAHwnqTNyBMpcVks5uju2dgaJpZM4XW58Q">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtnjRTrnVUndVCDtHMW_fwwVRJXihks5uju2dgaJpZM4XW58Q.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq","title":"bisq-network/bisq","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Workaround for JDK-8199592; text being truncated at certain display scaling levels (#1767)"}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq/pull/1767"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/1767",
"url": "https://github.com/bisq-network/bisq/pull/1767",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Workaround for JDK-8199592; text being truncated at certain display scaling levels (#1767)",
"sections": [
{
"text": "",
"activityTitle": "**Devin Bileck**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@devinbileck",
"facts": [

]
},
{
"title": "Commit Summary",
"facts": [
{
"name": "52a565a",
"value": "Workaround for labels being truncated at certain display scaling levels (JDK-8199592)"
}
]
},
{
"title": "File Changes",
"facts": [
{
"name": "Modified",
"value": "[desktop/src/main/java/bisq/desktop/main/overlays/Overlay.java](https://github.com/bisq-network/bisq/pull/1767/files#diff-0) (1 changes)"
}
]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"bisq-network/bisq\",\n\"issueId\": 1767,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"bisq-network/bisq\",\n\"pullRequestId\": 1767\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq/pull/1767"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq/pull/1767.patch"
}
],
"@type": "OpenUri",
"name": "View patch"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq/pull/1767.diff"
}
],
"@type": "OpenUri",
"name": "View diff"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 391880464\n}"
}
],
"themeColor": "26292E"
}
]</script>