<p>As mentioned in <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="368839085" data-permission-text="Issue title is private" data-url="https://github.com/bisq-network/proposals/issues/47" data-hovercard-type="issue" data-hovercard-url="/bisq-network/proposals/issues/47/hovercard" href="https://github.com/bisq-network/proposals/issues/47">bisq-network/proposals#47</a> we need verification of DAO parameter values which are different on parameter type.<br>
The class <code>bisq.core.dao.governance.proposal.param.ChangeParamValidator</code> is doing already a very basic validtion and need to be extended for all params. The current solution for a resrtiction of a max. change is not optimal and a more intuitive solution would be preferred. Double values (specially division) should be avoided to not risk consensus failured due rounding issues on different OS.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/issues/1769">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtuChadFHpb8OKtQ4l0LDb7rtylfjks5ukL-BgaJpZM4XZxSQ">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZthliwDQKPgpeBbV4xBTajdbAKIFkks5ukL-BgaJpZM4XZxSQ.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq","title":"bisq-network/bisq","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Verification for DAO parameter default values (#1769)"}],"action":{"name":"View Issue","url":"https://github.com/bisq-network/bisq/issues/1769"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/issues/1769",
"url": "https://github.com/bisq-network/bisq/issues/1769",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Verification for DAO parameter default values (#1769)",
"sections": [
{
"text": "",
"activityTitle": "**Manfred Karrer**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@ManfredKarrer",
"facts": [
{
"name": "Repository: ",
"value": "bisq-network/bisq"
},
{
"name": "Issue #: ",
"value": 1769
}
]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"bisq-network/bisq\",\n\"issueId\": 1769,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close issue",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueClose\",\n\"repositoryFullName\": \"bisq-network/bisq\",\n\"issueId\": 1769\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq/issues/1769"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 392631440\n}"
}
],
"themeColor": "26292E"
}
]</script>