<p><b>@ManfredKarrer</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/1751#discussion_r224938019">core/src/main/java/bisq/core/provider/fee/FeeService.java</a>:</p>
<pre style='color:#555'>>  
-    // 0.05 BSQ (5 satoshi) for a 1 BTC trade -> 0.005%. 0.05 USD if 1 BSQ = 1 USD, 10 % of BTC fee
-    private static final long MIN_MAKER_FEE_BSQ = 5;
-    private static final long MIN_TAKER_FEE_BSQ = 5;
-    // 2 BSQ or 200 BSQ-satoshi. About 2 USD if 1 BSQ = 1 USD for a 1 BTC trade which is about 10% of a normal BTC fee.
-    private static final long DEFAULT_TAKER_FEE_BSQ = 200;
-    private static final long DEFAULT_MAKER_FEE_BSQ = 200;
+    public static Coin getMakerFeePerBtc(boolean currencyForFeeIsBtc) {
</pre>
<p>Hm.. the handling of the BTC or BSQ fee is not very nice atm... would require a bit more refactoring at the clients side... Atm I don't want to touch more as it is needed so prefer to keep it but yes, its an open TODO...</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/1751#discussion_r224938019">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtvL5JMx467yF7BPQtor9gb5EasEQks5ukSZOgaJpZM4XJuJX">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtjYyXvF6X0njScqyuGSRDbFDGZGFks5ukSZOgaJpZM4XJuJX.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq","title":"bisq-network/bisq","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq"}},"updates":{"snippets":[{"icon":"PERSON","message":"@ManfredKarrer commented on #1751"}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq/pull/1751#discussion_r224938019"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/1751#discussion_r224938019",
"url": "https://github.com/bisq-network/bisq/pull/1751#discussion_r224938019",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "@ManfredKarrer commented on 1751",
"sections": [
{
"text": "",
"activityTitle": "**Manfred Karrer**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@ManfredKarrer",
"facts": [

]
}
],
"potentialAction": [
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq/pull/1751#discussion_r224938019"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 388424279\n}"
}
],
"themeColor": "26292E"
}
]</script>