<p><a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=603793" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/devinbileck">@devinbileck</a> If you have an idea about how to either fix that or to find a nice alternative, that would be rather high-prio to get into the upcoming release with the redesign.<br>
We could either use the same approach with the old version before we upgraded to Java 10 (overwriting and changing the base classes to mitigate most of the performance issues) or replace the indicator with a new component. Unfortunately JavaFX seems to be not well designed for animations, such a small re-rendering should never cost so much CPU...</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/issues/1692#issuecomment-429559532">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtrayhDQR8J3ZGGr6J2flFlbgsYb-ks5ukiEqgaJpZM4WukhH">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtt4oQilOX_AUgkkjPNSU85R_YMpwks5ukiEqgaJpZM4WukhH.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq","title":"bisq-network/bisq","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq"}},"updates":{"snippets":[{"icon":"PERSON","message":"@ManfredKarrer in #1692: @devinbileck If you have an idea about how to either fix that or to find a nice alternative, that would be rather high-prio to get into the upcoming release with the redesign.\r\nWe could either use the same approach with the old version before we upgraded to Java 10 (overwriting and changing the base classes to mitigate most of the performance issues) or replace the indicator with a new component. Unfortunately JavaFX seems to be not well designed for animations, such a small re-rendering should never cost so much CPU... "}],"action":{"name":"View Issue","url":"https://github.com/bisq-network/bisq/issues/1692#issuecomment-429559532"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/issues/1692#issuecomment-429559532",
"url": "https://github.com/bisq-network/bisq/issues/1692#issuecomment-429559532",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Re: [bisq-network/bisq] Fix performacne issues with Java 10 version of ProgressIndicator  (#1692)",
"sections": [
{
"text": "",
"activityTitle": "**Manfred Karrer**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@ManfredKarrer",
"facts": [

]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"bisq-network/bisq\",\n\"issueId\": 1692,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close issue",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueClose\",\n\"repositoryFullName\": \"bisq-network/bisq\",\n\"issueId\": 1692\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq/issues/1692#issuecomment-429559532"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 381306951\n}"
}
],
"themeColor": "26292E"
}
]</script>