<p>Planning to merge the role and reputation service, a lot of copy paste there.</p>
<p>The trade protocol needs to be figured but I think what was discussed about a hashed salt should be enough together with tracking own bonded reputation and that of counter parties since those will be the only ones with known salt. A reputation bond without known salt is useless so no need to track those.</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/bisq-network/bisq/pull/1776'>https://github.com/bisq-network/bisq/pull/1776</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Don't show role type for bonded reputation</li>
  <li>Add interface for BondedRole to allow for more generic bonds</li>
  <li>Add bonded reputation</li>
  <li>Add bonded reputation service, storage</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1776/files#diff-0">common/src/main/proto/pb.proto</a>
    (11)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1776/files#diff-1">core/src/main/java/bisq/core/app/misc/AppSetupWithP2PAndDAO.java</a>
    (3)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1776/files#diff-2">core/src/main/java/bisq/core/dao/DaoFacade.java</a>
    (26)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1776/files#diff-3">core/src/main/java/bisq/core/dao/DaoModule.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1776/files#diff-4">core/src/main/java/bisq/core/dao/bonding/BondingConsensus.java</a>
    (10)
  </li>
  <li>
    <strong>A</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1776/files#diff-5">core/src/main/java/bisq/core/dao/bonding/bond/BondWithHash.java</a>
    (24)
  </li>
  <li>
    <strong>A</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1776/files#diff-6">core/src/main/java/bisq/core/dao/bonding/bond/BondedReputation.java</a>
    (149)
  </li>
  <li>
    <strong>A</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1776/files#diff-7">core/src/main/java/bisq/core/dao/bonding/bond/BondedReputationList.java</a>
    (74)
  </li>
  <li>
    <strong>A</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1776/files#diff-8">core/src/main/java/bisq/core/dao/bonding/bond/BondedReputationService.java</a>
    (201)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1776/files#diff-9">core/src/main/java/bisq/core/dao/bonding/lockup/LockupService.java</a>
    (6)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1776/files#diff-10">core/src/main/java/bisq/core/dao/governance/role/BondedRole.java</a>
    (9)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1776/files#diff-11">core/src/main/java/bisq/core/dao/governance/role/BondedRoleList.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1776/files#diff-12">core/src/main/java/bisq/core/dao/state/BsqStateService.java</a>
    (5)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1776/files#diff-13">core/src/main/java/bisq/core/setup/CorePersistedDataHost.java</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1776/files#diff-14">core/src/main/resources/i18n/displayStrings.properties</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1776/files#diff-15">desktop/src/main/java/bisq/desktop/main/dao/bonding/BondingViewUtils.java</a>
    (23)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/bisq-network/bisq/pull/1776/files#diff-16">desktop/src/main/java/bisq/desktop/main/dao/bonding/lockup/LockupView.java</a>
    (48)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/bisq-network/bisq/pull/1776.patch'>https://github.com/bisq-network/bisq/pull/1776.patch</a></li>
  <li><a href='https://github.com/bisq-network/bisq/pull/1776.diff'>https://github.com/bisq-network/bisq/pull/1776.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/1776">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZttscXH50oTvbj4iJoaE2rlJOJOFdks5ulfkTgaJpZM4XemPr">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtjy62IDlLBRIyhjWisaElMFbPKPJks5ulfkTgaJpZM4XemPr.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq","title":"bisq-network/bisq","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"[WIP] Bonded reputation (#1776)"}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq/pull/1776"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/1776",
"url": "https://github.com/bisq-network/bisq/pull/1776",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "[WIP] Bonded reputation (#1776)",
"sections": [
{
"text": "",
"activityTitle": "**sqrrm**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@sqrrm",
"facts": [

]
},
{
"title": "Commit Summary",
"facts": [
{
"name": "b02daca",
"value": "Don't show role type for bonded reputation"
},
{
"name": "b9d6b3a",
"value": "Add interface for BondedRole to allow for more generic bonds"
},
{
"name": "7b72f10",
"value": "Add bonded reputation"
},
{
"name": "b3c8610",
"value": "Add bonded reputation service, storage"
}
]
},
{
"title": "File Changes",
"facts": [
{
"name": "Modified",
"value": "[common/src/main/proto/pb.proto](https://github.com/bisq-network/bisq/pull/1776/files#diff-0) (11 changes)"
},
{
"name": "Modified",
"value": "[core/src/main/java/bisq/core/app/misc/AppSetupWithP2PAndDAO.java](https://github.com/bisq-network/bisq/pull/1776/files#diff-1) (3 changes)"
},
{
"name": "Modified",
"value": "[core/src/main/java/bisq/core/dao/DaoFacade.java](https://github.com/bisq-network/bisq/pull/1776/files#diff-2) (26 changes)"
},
{
"name": "Modified",
"value": "[core/src/main/java/bisq/core/dao/DaoModule.java](https://github.com/bisq-network/bisq/pull/1776/files#diff-3) (2 changes)"
},
{
"name": "Modified",
"value": "[core/src/main/java/bisq/core/dao/bonding/BondingConsensus.java](https://github.com/bisq-network/bisq/pull/1776/files#diff-4) (10 changes)"
},
{
"name": "Added",
"value": "[core/src/main/java/bisq/core/dao/bonding/bond/BondWithHash.java](https://github.com/bisq-network/bisq/pull/1776/files#diff-5) (24 changes)"
},
{
"name": "Added",
"value": "[core/src/main/java/bisq/core/dao/bonding/bond/BondedReputation.java](https://github.com/bisq-network/bisq/pull/1776/files#diff-6) (149 changes)"
},
{
"name": "Added",
"value": "[core/src/main/java/bisq/core/dao/bonding/bond/BondedReputationList.java](https://github.com/bisq-network/bisq/pull/1776/files#diff-7) (74 changes)"
},
{
"name": "Added",
"value": "[core/src/main/java/bisq/core/dao/bonding/bond/BondedReputationService.java](https://github.com/bisq-network/bisq/pull/1776/files#diff-8) (201 changes)"
},
{
"name": "Modified",
"value": "[core/src/main/java/bisq/core/dao/bonding/lockup/LockupService.java](https://github.com/bisq-network/bisq/pull/1776/files#diff-9) (6 changes)"
},
{
"name": "Modified",
"value": "[core/src/main/java/bisq/core/dao/governance/role/BondedRole.java](https://github.com/bisq-network/bisq/pull/1776/files#diff-10) (9 changes)"
},
{
"name": "Modified",
"value": "[core/src/main/java/bisq/core/dao/governance/role/BondedRoleList.java](https://github.com/bisq-network/bisq/pull/1776/files#diff-11) (2 changes)"
},
{
"name": "Modified",
"value": "[core/src/main/java/bisq/core/dao/state/BsqStateService.java](https://github.com/bisq-network/bisq/pull/1776/files#diff-12) (5 changes)"
},
{
"name": "Modified",
"value": "[core/src/main/java/bisq/core/setup/CorePersistedDataHost.java](https://github.com/bisq-network/bisq/pull/1776/files#diff-13) (2 changes)"
},
{
"name": "Modified",
"value": "[core/src/main/resources/i18n/displayStrings.properties](https://github.com/bisq-network/bisq/pull/1776/files#diff-14) (2 changes)"
},
{
"name": "Modified",
"value": "[desktop/src/main/java/bisq/desktop/main/dao/bonding/BondingViewUtils.java](https://github.com/bisq-network/bisq/pull/1776/files#diff-15) (23 changes)"
},
{
"name": "Modified",
"value": "[desktop/src/main/java/bisq/desktop/main/dao/bonding/lockup/LockupView.java](https://github.com/bisq-network/bisq/pull/1776/files#diff-16) (48 changes)"
}
]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"bisq-network/bisq\",\n\"issueId\": 1776,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"bisq-network/bisq\",\n\"pullRequestId\": 1776\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq/pull/1776"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq/pull/1776.patch"
}
],
"@type": "OpenUri",
"name": "View patch"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq/pull/1776.diff"
}
],
"@type": "OpenUri",
"name": "View diff"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 393896939\n}"
}
],
"themeColor": "26292E"
}
]</script>