<p><a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=1449498" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/ManfredKarrer">@ManfredKarrer</a>, <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=170962" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/ripcurlx">@ripcurlx</a>, <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=603793" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/devinbileck">@devinbileck</a>, I took a quick stab at this, and (as expected), the builds are breaking on not having JavaFX available. I'm sure there's some way to sort this out, but I just had a few minutes here. Somebody can pick up the thread if they like, or it may just be easier in the end to upgrade to (Oracle)JDK11. It would be nice to be on OpenJDK anyway, but if it's too much hassle, perhaps that's a task that somebody can pick up later.</p>
<p>Anyway, feel free to continue hacking on this PR, or to just close it. I'm not sure if I'll be able to get back to it soon.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/1792#issuecomment-431467917">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZttuaTadmiTkD2oEfuKjitBcyJ5xVks5umiPTgaJpZM4XxPnV">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZthskq80aUIPMfKFWD6YarZtceHXEks5umiPTgaJpZM4XxPnV.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq","title":"bisq-network/bisq","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq"}},"updates":{"snippets":[{"icon":"PERSON","message":"@cbeams in #1792: @ManfredKarrer, @ripcurlx, @devinbileck, I took a quick stab at this, and (as expected), the builds are breaking on not having JavaFX available. I'm sure there's some way to sort this out, but I just had a few minutes here. Somebody can pick up the thread if they like, or it may just be easier in the end to upgrade to (Oracle)JDK11. It would be nice to be on OpenJDK anyway, but if it's too much hassle, perhaps that's a task that somebody can pick up later.\r\n\r\nAnyway, feel free to continue hacking on this PR, or to just close it. I'm not sure if I'll be able to get back to it soon."}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq/pull/1792#issuecomment-431467917"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/1792#issuecomment-431467917",
"url": "https://github.com/bisq-network/bisq/pull/1792#issuecomment-431467917",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Re: [bisq-network/bisq] Use OpenJDK10 in Travis CI builds (#1792)",
"sections": [
{
"text": "",
"activityTitle": "**Chris Beams**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@cbeams",
"facts": [

]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"bisq-network/bisq\",\n\"issueId\": 1792,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"bisq-network/bisq\",\n\"pullRequestId\": 1792\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq/pull/1792#issuecomment-431467917"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 398784981\n}"
}
],
"themeColor": "26292E"
}
]</script>