<p><b>@cbeams</b> requested changes on this pull request.</p>

<p>NACK per inline comments; all fairly minor stuff. Thanks for putting this together, <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=603793" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/devinbileck">@devinbileck</a>.</p><hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/1794#discussion_r226827304">.travis.yml</a>:</p>
<pre style='color:#555'>> @@ -1,5 +1,5 @@
 language: java
-jdk: oraclejdk10
+jdk: openjdk10
</pre>
<p>Glad to see this works without the <code>install-jdk.sh</code> bit.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/1794#discussion_r226827351">common/build.gradle</a>:</p>
<pre style='color:#555'>> @@ -1,12 +1,27 @@
+buildscript {
+    repositories {
+        mavenCentral()
+    }
+    dependencies {
+        classpath 'com.google.gradle:osdetector-gradle-plugin:1.6.0'
+    }
+}
+
 plugins {
     id 'java'
     id 'maven'
     id 'com.google.protobuf' version '0.8.5'
</pre>
<p>Add the following line here, and delete the <code>buildscript</code> block above:</p>
<pre><code>id 'com.google.osdetector' version '1.6.0'
</code></pre>
<p>(Per <a href="https://github.com/google/osdetector-gradle-plugin#for-gradle-21-and-higher">https://github.com/google/osdetector-gradle-plugin#for-gradle-21-and-higher</a>)</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/1794#discussion_r226827368">common/build.gradle</a>:</p>
<pre style='color:#555'>>  plugins {
     id 'java'
     id 'maven'
     id 'com.google.protobuf' version '0.8.5'
 }
 
+apply plugin: 'application'
</pre>
<p>Why?</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/1794#discussion_r226827377">common/build.gradle</a>:</p>
<pre style='color:#555'>>  plugins {
     id 'java'
     id 'maven'
     id 'com.google.protobuf' version '0.8.5'
 }
 
+apply plugin: 'application'
+apply plugin: 'com.google.osdetector'
</pre>
<p>Remove along with the <code>buildscript</code> block.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/1794#discussion_r226827451">common/build.gradle</a>:</p>
<pre style='color:#555'>>  group = 'network.bisq'
 version = '-SNAPSHOT'
 
+mainClassName = 'bisq.common'
</pre>
<p>This isn't the name of a class. Assuming you remove the <code>application</code> plugin as suggested above, this should be removed too.</p>

<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/1794#discussion_r226827477">common/build.gradle</a>:</p>
<pre style='color:#555'>> @@ -19,6 +34,7 @@ tasks.withType(JavaCompile) {
 
 repositories {
     jcenter()
+    mavenCentral()
</pre>
<p>Everything resolvable from Maven Central should also be resolvable from JCenter. Did that not prove true for you? Please remove <code>mavenCentral()</code> references here and everywhere else if possible.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/1794#pullrequestreview-166749741">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtg2citAEqypD9IxlSWrbuXKYuLt4ks5umygjgaJpZM4Xxkuu">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtvtQWaNckJ_YwC28hIdM_ZrJPJSuks5umygjgaJpZM4Xxkuu.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq","title":"bisq-network/bisq","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq"}},"updates":{"snippets":[{"icon":"PERSON","message":"@cbeams requested changes on #1794"}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq/pull/1794#pullrequestreview-166749741"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/1794#pullrequestreview-166749741",
"url": "https://github.com/bisq-network/bisq/pull/1794#pullrequestreview-166749741",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "@cbeams requested changes on 1794",
"sections": [
{
"text": "NACK per inline comments; all fairly minor stuff. Thanks for putting this together, @devinbileck.",
"activityTitle": "**Chris Beams**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@cbeams",
"facts": [

]
}
],
"potentialAction": [
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq/pull/1794#pullrequestreview-166749741"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 398871470\n}"
}
],
"themeColor": "26292E"
}
]</script>