<p><a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=1302765" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/fotispap">@fotispap</a> Thanks!<br>
I would use the term private key  for what is exported/imported instead of onion address. Renew onion address is ok, but import/export priv key...</p>
<p>I would also not add it to the Tor settings as that is shown automatically at connection problems. Better to add a button in the network settings for renewing the onion address. Then show the details in a new popup.</p>
<p>It is important to explain the user that he can do that only if he has no offers/trades/disputes open and the he will lose his local reputation (those he has traded with will not see him as the same node and therefore the number of trades displayed in the avatar will be not valid anymore).</p>
<p>I also is important to check for open offers/trades/disputes and only allow then the renewal.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/issues/1055#issuecomment-432005133">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZts1yQ5rcDDL50lR_KTTuo0Lsr60Iks5unj_DgaJpZM4Q1Y7r">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtg5765WGLae2ToLH2GUDWbcQEMDCks5unj_DgaJpZM4Q1Y7r.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq","title":"bisq-network/bisq","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq"}},"updates":{"snippets":[{"icon":"PERSON","message":"@ManfredKarrer in #1055: @fotispap Thanks!\r\nI would use the term private key  for what is exported/imported instead of onion address. Renew onion address is ok, but import/export priv key...\r\n\r\nI would also not add it to the Tor settings as that is shown automatically at connection problems. Better to add a button in the network settings for renewing the onion address. Then show the details in a new popup.\r\n\r\nIt is important to explain the user that he can do that only if he has no offers/trades/disputes open and the he will lose his local reputation (those he has traded with will not see him as the same node and therefore the number of trades displayed in the avatar will be not valid anymore). \r\n\r\nI also is important to check for open offers/trades/disputes and only allow then the renewal."}],"action":{"name":"View Issue","url":"https://github.com/bisq-network/bisq/issues/1055#issuecomment-432005133"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/issues/1055#issuecomment-432005133",
"url": "https://github.com/bisq-network/bisq/issues/1055#issuecomment-432005133",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Re: [bisq-network/bisq] Export/import feature for onion address (#1055)",
"sections": [
{
"text": "",
"activityTitle": "**Manfred Karrer**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@ManfredKarrer",
"facts": [

]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"bisq-network/bisq\",\n\"issueId\": 1055,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close issue",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueClose\",\n\"repositoryFullName\": \"bisq-network/bisq\",\n\"issueId\": 1055\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq/issues/1055#issuecomment-432005133"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 282431211\n}"
}
],
"themeColor": "26292E"
}
]</script>