<p><b>@ripcurlx</b> requested changes on this pull request.</p>
<p>utACK - besides some minor changes</p><hr>
<p>In <a href="https://github.com/bisq-network/bisq/pull/1795#discussion_r227377605">core/src/main/java/bisq/core/dao/DaoFacade.java</a>:</p>
<pre style='color:#555'>> @@ -358,16 +360,92 @@ public void publishBlindVote(Coin stake, ResultHandler resultHandler, ExceptionH
// Use case: Presentation of phases
///////////////////////////////////////////////////////////////////////////////////////////
- public int getFirstBlockOfPhase(int height, DaoPhase.Phase phase) {
- return periodService.getFirstBlockOfPhase(height, phase);
- }
-
- public int getLastBlockOfPhase(int height, DaoPhase.Phase phase) {
- return periodService.getLastBlockOfPhase(height, phase);
- }
-
- public int getDurationForPhase(DaoPhase.Phase phase) {
- return periodService.getDurationForPhase(phase, daoStateService.getChainHeight());
+ // Because last block in request and voting phases must not be used fo making a tx as it will get confirmed in the
</pre>
<p>Typo:</p>
<blockquote>
<p>fo --> for</p>
</blockquote>
<hr>
<p>In <a href="https://github.com/bisq-network/bisq/pull/1795#discussion_r227377678">core/src/main/java/bisq/core/dao/DaoFacade.java</a>:</p>
<pre style='color:#555'>> + case BREAK2:
+ firstBlock++;
+ break;
+ case VOTE_REVEAL:
+ break;
+ case BREAK3:
+ firstBlock++;
+ break;
+ case RESULT:
+ break;
+ }
+
+ return firstBlock;
+ }
+
+ // Because last block in request and voting phases must not be used fo making a tx as it will get confirmed in the
</pre>
<p>Typo:</p>
<blockquote>
<p>fo --> for</p>
</blockquote>
<hr>
<p>In <a href="https://github.com/bisq-network/bisq/pull/1795#discussion_r227377724">core/src/main/java/bisq/core/dao/DaoFacade.java</a>:</p>
<pre style='color:#555'>> + lastBlock--;
+ break;
+ case BREAK2:
+ break;
+ case VOTE_REVEAL:
+ lastBlock--;
+ break;
+ case BREAK3:
+ break;
+ case RESULT:
+ break;
+ }
+ return lastBlock;
+ }
+
+ // Because last block in request and voting phases must not be used fo making a tx as it will get confirmed in the
</pre>
<p>Typo:</p>
<blockquote>
<p>fo --> for</p>
</blockquote>
<hr>
<p>In <a href="https://github.com/bisq-network/bisq/pull/1795#discussion_r227378399">core/src/main/java/bisq/core/dao/governance/proposal/compensation/CompensationProposalService.java</a>:</p>
<pre style='color:#555'>> throws ValidationException, InsufficientMoneyException, TxException {
this.requestedBsq = requestedBsq;
- this.bsqAddress = bsqAddress;
+ this.bsqAddress = "B" + bsqWalletService.getUnusedAddress().toBase58();
</pre>
<p><g-emoji class="g-emoji" alias="+1" fallback-src="https://assets-cdn.github.com/images/icons/emoji/unicode/1f44d.png">👍</g-emoji></p>
<hr>
<p>In <a href="https://github.com/bisq-network/bisq/pull/1795#discussion_r227381221">core/src/main/resources/i18n/displayStrings_de.properties</a>:</p>
<pre style='color:#555'>> @@ -1291,7 +1291,7 @@ dao.wallet.menuItem.send=Senden
dao.wallet.menuItem.receive=Empfangen
dao.wallet.menuItem.transactions=Transaktionen
-dao.wallet.dashboard.statistics=Statistiken
+dao.wallet.dashboard.distribution=Statistiken
</pre>
<p>You don't need to bother about changing translations except displayStrings.properties. All other files will be overwritten by the Transifex state. So if we change keys that have been translated yet we need to copy it over in Transifex. Have to see how easy this is visible in the interface. I'll also have to walk over all supported translations with the redesign branch as lots of ":" in translations need to be removed.</p>
<hr>
<p>In <a href="https://github.com/bisq-network/bisq/pull/1795#discussion_r227382296">desktop/src/main/java/bisq/desktop/main/dao/governance/proposals/ProposalsListItem.java</a>:</p>
<pre style='color:#555'>> if (phase == DaoPhase.Phase.PROPOSAL) {
- icon = AwesomeDude.createIconLabel(AwesomeIcon.FILE_TEXT);
+ //icon = AwesomeDude.createIconLabel(AwesomeIcon.TRASH);
+ icon = AwesomeDude.createIconLabel(AwesomeIcon.TRASH);
</pre>
<p>Please use <code>Formbuilder.getIcon</code> so it is easier when we need to switch to the newest AwesomeDude library.</p>
<hr>
<p>In <a href="https://github.com/bisq-network/bisq/pull/1795#discussion_r227383567">desktop/src/main/java/bisq/desktop/main/settings/preferences/PreferencesView.java</a>:</p>
<pre style='color:#555'>> resyncDaoButton.setOnAction(e -> daoFacade.resyncDao(() -> {
new Popup<>().attention(Res.get("setting.preferences.dao.resync.popup"))
.useShutDownButton()
.hideCloseButton()
.show();
}));
+
+ isDaoFullNodeCheckBox.setOnAction(e -> {
+ String key = "daoFullModeInfoShown";
+ if (isDaoFullNodeCheckBox.isSelected() && preferences.showAgain(key)) {
+ String url = "https://bisq.network/docs/dao-full-node";
</pre>
<p>Maybe we could think about moving all URLs into one place so they get easier to maintain when the structure in the docs is changed.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/1795#pullrequestreview-167402654">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtnrmQxtK-nSuG6j-xi9ukewK5-vUks5unxcqgaJpZM4XxqeJ">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtjR9G1TgO-UWntop0J_ku_6gAzAPks5unxcqgaJpZM4XxqeJ.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq","title":"bisq-network/bisq","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq"}},"updates":{"snippets":[{"icon":"PERSON","message":"@ripcurlx requested changes on #1795"}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq/pull/1795#pullrequestreview-167402654"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/1795#pullrequestreview-167402654",
"url": "https://github.com/bisq-network/bisq/pull/1795#pullrequestreview-167402654",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "@ripcurlx requested changes on 1795",
"sections": [
{
"text": "utACK - besides some minor changes",
"activityTitle": "**Christoph Atteneder**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@ripcurlx",
"facts": [
]
}
],
"potentialAction": [
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq/pull/1795#pullrequestreview-167402654"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 398894985\n}"
}
],
"themeColor": "26292E"
}
]</script>