<p><b>@sqrrm</b> approved this pull request.</p>

<p>utACK</p><hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/1813#discussion_r227914568">core/src/main/java/bisq/core/btc/wallet/BtcWalletService.java</a>:</p>
<pre style='color:#555'>> @@ -174,9 +191,11 @@ public Transaction completePreparedCompensationRequestTx(Coin issuanceAmount, Ad
         // BSQ change outputs from BSQ fee inputs.
         feeTx.getOutputs().forEach(preparedTx::addOutput);
 
-        // BSQ issuance output
-        preparedTx.addOutput(issuanceAmount, issuanceAddress);
-
+        //
</pre>
⬇️ Suggested change
<pre style="color: #555">-        //
+        // For generic proposals there is no issuance output, for compensation and reimburse requests there is
</pre>


<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/1813#discussion_r227921110">core/src/main/java/bisq/core/dao/governance/voteresult/issuance/IssuanceService.java</a>:</p>
<pre style='color:#555'>>                  .forEach(txOutput -> {
+                    IssuanceType issuanceType = IssuanceType.UNDEFINED;
+                    if (issuanceProposal instanceof CompensationProposal) {
+                        issuanceType = IssuanceType.COMPENSATION;
+                    } else if (issuanceProposal instanceof ReimbursementProposal) {
+                        issuanceType = IssuanceType.REIMBURSEMENT;
+                    }
+                    checkArgument(issuanceType != IssuanceType.UNDEFINED, "issuanceType must nto be undefined");
</pre>
⬇️ Suggested change
<pre style="color: #555">-                    checkArgument(issuanceType != IssuanceType.UNDEFINED, "issuanceType must nto be undefined");
+                    checkArgument(issuanceType != IssuanceType.UNDEFINED, "issuanceType must not be undefined");
</pre>


<hr>

<p>In <a href="https://github.com/bisq-network/bisq/pull/1813#discussion_r227924382">core/src/main/java/bisq/core/dao/state/governance/IssuanceType.java</a>:</p>
<pre style='color:#555'>> + * under the terms of the GNU Affero General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or (at
+ * your option) any later version.
+ *
+ * Bisq is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU Affero General Public
+ * License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with Bisq. If not, see <http://www.gnu.org/licenses/>.
+ */
+
+package bisq.core.dao.state.governance;
+
+public enum IssuanceType {
</pre>
<p>GENESIS could be a reasonable type as well, no need really.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/1813#pullrequestreview-168062337">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtg_TIZBDCsRzGC5Sb4HeaT8dshOhks5uoL6CgaJpZM4X4bsg">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtoYn5KeucHRXq0REPNUYLtBCAPPzks5uoL6CgaJpZM4X4bsg.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq","title":"bisq-network/bisq","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq"}},"updates":{"snippets":[{"icon":"PERSON","message":"@sqrrm approved #1813"}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq/pull/1813#pullrequestreview-168062337"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/1813#pullrequestreview-168062337",
"url": "https://github.com/bisq-network/bisq/pull/1813#pullrequestreview-168062337",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "@sqrrm approved 1813",
"sections": [
{
"text": "utACK",
"activityTitle": "**sqrrm**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@sqrrm",
"facts": [

]
}
],
"potentialAction": [
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq/pull/1813#pullrequestreview-168062337"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 400669472\n}"
}
],
"themeColor": "26292E"
}
]</script>