<p>In <code>Task :assets:compileJava</code>, I noticed a lot of assets are using DefaultAddressValidator.<br>
e.g.</p>
<pre><code>assets\src\main\java\bisq\asset\coins\Burstcoin.java:26: warning: [deprecation] DefaultAddressValidator in bisq.asset has been deprecated
        super("Burstcoin", "BURST", new DefaultAddressValidator());
                                        ^
</code></pre>
<p>Which means <code>Task :assets:compileTestJava</code> has warnings like:</p>
<pre><code>assets\src\test\java\bisq\asset\coins\BurstcoinTest.java:22: warning: [deprecation] AbstractAssetWithDefaultValidatorTest in bisq.asset has been deprecated
public class BurstcoinTest extends AbstractAssetWithDefaultValidatorTest {
                                   ^
</code></pre>
<p>These are the coins using DefaultAddressValidator:</p>
<ul>
<li>Burstcoin</li>
<li>Counterparty</li>
<li>DarkNet</li>
<li>Decred</li>
<li>DynamicCoin</li>
<li>Espers</li>
<li>Ether Classic</li>
<li>Gridcoin</li>
<li>LBRY Credits</li>
<li>Lisk</li>
<li>MaidSafeCoin</li>
<li>Namecoin</li>
<li>Nav Coin</li>
<li>NuBits</li>
<li>Pepe Cash</li>
<li>PostCoin</li>
<li>ReddCoin</li>
<li>Safe FileSystem Coin</li>
<li>Siacoin</li>
<li>Siafund</li>
<li>Sibcoin</li>
<li>STEEM</li>
<li>Unobtanium</li>
<li>Zcoin</li>
</ul>
<p>I assume these assets are likely to be removed soon enough so not worth implementing custom validators.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/issues/1815#issuecomment-433112999">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtmbeot11sb4zYu8PgVEG8bB5frZMks5uoeMUgaJpZM4X5PhJ">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtt-ySPe60emNwGrY8yQKbyHfhwDlks5uoeMUgaJpZM4X5PhJ.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq","title":"bisq-network/bisq","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq"}},"updates":{"snippets":[{"icon":"PERSON","message":"@devinbileck in #1815: In `Task :assets:compileJava`, I noticed a lot of assets are using DefaultAddressValidator.\r\ne.g.\r\n```\r\nassets\\src\\main\\java\\bisq\\asset\\coins\\Burstcoin.java:26: warning: [deprecation] DefaultAddressValidator in bisq.asset has been deprecated\r\n        super(\"Burstcoin\", \"BURST\", new DefaultAddressValidator());\r\n                                        ^\r\n```\r\n\r\nWhich means `Task :assets:compileTestJava` has warnings like:\r\n```\r\nassets\\src\\test\\java\\bisq\\asset\\coins\\BurstcoinTest.java:22: warning: [deprecation] AbstractAssetWithDefaultValidatorTest in bisq.asset has been deprecated\r\npublic class BurstcoinTest extends AbstractAssetWithDefaultValidatorTest {\r\n                                   ^\r\n```\r\n\r\nThese are the coins using DefaultAddressValidator:\r\n- Burstcoin\r\n- Counterparty\r\n- DarkNet\r\n- Decred\r\n- DynamicCoin\r\n- Espers\r\n- Ether Classic\r\n- Gridcoin\r\n- LBRY Credits\r\n- Lisk\r\n- MaidSafeCoin\r\n- Namecoin\r\n- Nav Coin\r\n- NuBits\r\n- Pepe Cash\r\n- PostCoin\r\n- ReddCoin\r\n- Safe FileSystem Coin\r\n- Siacoin\r\n- Siafund\r\n- Sibcoin\r\n- STEEM\r\n- Unobtanium\r\n- Zcoin\r\n\r\nI assume these assets are likely to be removed soon enough so not worth implementing custom validators."}],"action":{"name":"View Issue","url":"https://github.com/bisq-network/bisq/issues/1815#issuecomment-433112999"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/issues/1815#issuecomment-433112999",
"url": "https://github.com/bisq-network/bisq/issues/1815#issuecomment-433112999",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Re: [bisq-network/bisq] Resolve deprecation warnings encountered in gradle build (#1815)",
"sections": [
{
"text": "",
"activityTitle": "**Devin Bileck**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@devinbileck",
"facts": [

]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"bisq-network/bisq\",\n\"issueId\": 1815,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close issue",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueClose\",\n\"repositoryFullName\": \"bisq-network/bisq\",\n\"issueId\": 1815\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq/issues/1815#issuecomment-433112999"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 400881737\n}"
}
],
"themeColor": "26292E"
}
]</script>