<p>I'm not so sure if it is a good idea to put the values into an InputField style box if you can't change them. What about putting it together with the security deposit in an advanced options section that can be hidden/shown based on a preferences flag?<br>
<a target="_blank" rel="noopener noreferrer" href="https://user-images.githubusercontent.com/170962/47785143-182ed780-dd08-11e8-9e4b-3ab83dfe0adc.png"><img src="https://user-images.githubusercontent.com/170962/47785143-182ed780-dd08-11e8-9e4b-3ab83dfe0adc.png" alt="trade fees" style="max-width:100%;"></a><br>
This on the other hand makes it still confusing for the first time user. Maybe we could add another step where you have to select the trade fee currency once and your setting is stored. The only way to change it is by activating advanced options in the preferences and/or being able to set the trade fee currency in the preferences as well.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/bisq-network/bisq/pull/1827#issuecomment-434653337">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AkpZtgBMTMh_eP8-3kYPH4LNJPF2b0mvks5uqYo-gaJpZM4X9sCi">mute the thread</a>.<img src="https://github.com/notifications/beacon/AkpZtmPaD6RYEz0fehCXyAqKVp6J5Dn2ks5uqYo-gaJpZM4X9sCi.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/bisq-network/bisq","title":"bisq-network/bisq","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/bisq-network/bisq"}},"updates":{"snippets":[{"icon":"PERSON","message":"@ripcurlx in #1827: I'm not so sure if it is a good idea to put the values into an InputField style box if you can't change them. What about putting it together with the security deposit in an advanced options section that can be hidden/shown based on a preferences flag?\r\n\r\nThis on the other hand makes it still confusing for the first time user. Maybe we could add another step where you have to select the trade fee currency once and your setting is stored. The only way to change it is by activating advanced options in the preferences and/or being able to set the trade fee currency in the preferences as well.\r\n"}],"action":{"name":"View Pull Request","url":"https://github.com/bisq-network/bisq/pull/1827#issuecomment-434653337"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/bisq-network/bisq/pull/1827#issuecomment-434653337",
"url": "https://github.com/bisq-network/bisq/pull/1827#issuecomment-434653337",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Re: [bisq-network/bisq] Add fiat amount to fee (#1827)",
"sections": [
{
"text": "",
"activityTitle": "**Christoph Atteneder**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@ripcurlx",
"facts": [

]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"bisq-network/bisq\",\n\"issueId\": 1827,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"bisq-network/bisq\",\n\"pullRequestId\": 1827\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/bisq-network/bisq/pull/1827#issuecomment-434653337"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 402047138\n}"
}
],
"themeColor": "26292E"
}
]</script>